Fixed coding style issue:
Enclose multiple statements macros definition in a do while loop.
Use one space around binary operators.
Signed-off-by: Sunbing
---
drivers/staging/ks7010/michael_mic.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/sta
Replace unsigned by unsigned int in fbtft driver. Issue found by
checkpatch.
Signed-off-by: Ming Yang
---
drivers/staging/fbtft/fb_ili9320.c | 4 ++--
drivers/staging/fbtft/fb_ili9325.c | 10 +-
drivers/staging/fbtft/fb_pcd8544.c | 4 ++--
drivers/staging/fbtft/fb_ssd1289.c |
From: Markus Elfring
Date: Sun, 17 Jul 2016 22:52:49 +0200
The rc_free_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
dr
From: Markus Elfring
Date: Sun, 17 Jul 2016 22:00:35 +0200
The video_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
On Sun, 17 Jul 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 17 Jul 2016 15:55:02 +0200
>
> Return directly after a memory allocation failed at the beginning.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 19 +++
> 1 file
On Sun, 17 Jul 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 17 Jul 2016 18:15:23 +0200
>
> Some return values can also be directly used for various condition checks.
> Thus remove a local variable for intermediate assignments.
>
> Signed-off-by: Markus Elfring
> ---
> dr
On Sun, 17 Jul 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 17 Jul 2016 18:39:03 +0200
>
> Do not use curly brackets at some source code places
> where a single statement should be sufficient.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/staging/ks7010/ks7010_sdio.c
On Sun, 17 Jul 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 17 Jul 2016 19:40:47 +0200
>
> Three variables will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/staging
From: Markus Elfring
Date: Sun, 17 Jul 2016 19:12:27 +0200
Prefer usage of the macro "pr_err" over the interface "printk".
Fix a typo in an error message.
Signed-off-by: Markus Elfring
---
drivers/staging/ks7010/ks7010_sdio.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff -
From: Markus Elfring
Date: Sun, 17 Jul 2016 19:40:47 +0200
Three variables will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/staging/ks7010/ks7010_sdio.c | 8
1 file changed, 4 insertions(
>From 01291121668ccb54f1a784765a8d2b5811afa75a Mon Sep 17 00:00:00 2001
From: Markus Elfring
Date: Sun, 17 Jul 2016 19:26:15 +0200
Subject: [PATCH 8/9] staging: ks7010: Delete a variable in write_to_device()
The local variable "rc" was assigned a zero at one place.
But it was not read within this
From: Markus Elfring
Date: Sun, 17 Jul 2016 18:39:03 +0200
Do not use curly brackets at some source code places
where a single statement should be sufficient.
Signed-off-by: Markus Elfring
---
drivers/staging/ks7010/ks7010_sdio.c | 48
1 file changed, 16 in
From: Markus Elfring
Date: Sun, 17 Jul 2016 18:15:23 +0200
Some return values can also be directly used for various condition checks.
Thus remove a local variable for intermediate assignments.
Signed-off-by: Markus Elfring
---
drivers/staging/ks7010/ks7010_sdio.c | 81 +++--
From: Markus Elfring
Date: Sun, 17 Jul 2016 16:26:18 +0200
Adjust jump targets according to the Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/staging/ks7010/ks7010_sdio.c | 81 +---
1 file changed, 38 insertions(+), 43 deletions(-)
di
From: Markus Elfring
Date: Sun, 17 Jul 2016 19:54:32 +0200
Further update suggestions were taken into account
after a patch was applied from static source code analysis.
Markus Elfring (9):
Delete unnecessary checks before the function call "kfree"
Delete unnecessary assignments for buffer v
From: Markus Elfring
Date: Sun, 17 Jul 2016 15:55:02 +0200
Return directly after a memory allocation failed at the beginning.
Signed-off-by: Markus Elfring
---
drivers/staging/ks7010/ks7010_sdio.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/
From: Markus Elfring
Date: Sun, 17 Jul 2016 13:38:46 +0200
A few variables were assigned a null pointer despite of the detail
that they were immediately reassigned by the following statement.
Thus remove such unnecessary assignments.
Signed-off-by: Markus Elfring
---
drivers/staging/ks7010/ks7
From: Markus Elfring
Date: Sun, 17 Jul 2016 13:14:57 +0200
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/st
On Jul 15, 2016, at 8:32, Greg KH wrote:
> On Thu, Jul 14, 2016 at 05:01:51PM +0800, Sunbing wrote:
>> The formatting of macros definetion in ks7010/michael_mic.c is not
>> consistent with the general kernel coding style.
>>
>> Fix it by the result of scripts/checkpatch.pl.
>>
>> No functional
Mein lieber Freund,
Ich mцchte mich erstmals gerne vorstellen. Mein Name ist Herr Rodrнguez Ortega
die persцnliche Investment Berater und Vermцgensverwalterin meines verstorbenen
Mandanten, der ihre familienname tragt. Er war als privater Geschдftsmann im
internationalen Bereich tдtig. Im Jahr
20 matches
Mail list logo