[PATCH 5/6] staging: rtl8188eu: remove EFUSE_GetEfuseDefinition function

2016-06-19 Thread Ivan Safonov
This function does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_efuse.c| 63 --- drivers/staging/rtl8188eu/include/rtw_efuse.h | 2 - 2 files changed, 65 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/

[PATCH 3/6] staging: rtl8188eu: replace EFUSE_GetEfuseDefinition(..., TYPE_EFUSE_MAX_SECTION, &a) with a = EFUSE_MAX_SECTION_88E

2016-06-19 Thread Ivan Safonov
This makes the code easier to read. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c index 9d5bd43..1e96a81 1

[PATCH 6/6] staging: rtl8188eu: remove _EFUSE_DEF_TYPE enum

2016-06-19 Thread Ivan Safonov
This enumeration does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_efuse.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_efuse.h b/drivers/staging/rtl8188eu/include/rtw_efuse.h index 9e7d135..168c12d 10064

[PATCH 4/6] staging: rtl8188eu: replace EFUSE_GetEfuseDefinition(..., TYPE_AVAILABLE_EFUSE_BYTES_BANK, &a) call with a = (EFUSE_REAL_CONTENT_LEN_88E - EFUSE_OOB_PROTECT_BYTES_88E)

2016-06-19 Thread Ivan Safonov
This makes the code easier to read. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c index 1e96a81..

[PATCH 1/6] staging: rtl8188eu: replace EFUSE_GetEfuseDefinition(..., TYPE_EFUSE_MAP_LEN, ...) call with it's result (EFUSE_MAP_LEN_88E)

2016-06-19 Thread Ivan Safonov
This makes the code easier to read. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c index c1

[PATCH 2/6] staging: rtl8188eu: remove efuse_max variable in hal_EfusePartialWriteCheck

2016-06-19 Thread Ivan Safonov
This variable does not used after assigning value. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c index ea28f

[PATCH] staging: unisys: visorbus: Replace semaphore with mutex

2016-06-19 Thread Binoy Jayan
The semaphore 'visordriver_callback_lock' is a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- drivers/staging/unisys/include/visorbus.h | 3 ++- drivers/staging/unisys/visorbus/visorbus_main.c | 14 +++--- 2 fi

[PATCH] staging: lustre: remove remote client support

2016-06-19 Thread James Simmons
From: Fan Yong There are several obsolete sub commands for lfs to work with remote client. We do not support that anymore, and should be deleted along with any kernel code related to remote client. Signed-off-by: Fan Yong Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6971 Reviewed-on: htt

[PATCH 24/28] staging/lustre/llite: ll_revalidate_dentry update

2016-06-19 Thread Oleg Drokin
From: Oleg Drokin There are a couple of cases in ll_revalidate_dentry() where we are pretty sure the dentry is valid, so check for them early and save more expensive checks for later. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/dcache.c | 11 +++ 1 file changed,

[PATCH 20/28] staging/lustre/mdc: Zero atime in close RPC

2016-06-19 Thread Oleg Drokin
From: Niu Yawei While atime on close is supposed to only increase, there's a bug in some older server versions where atime from a client is taken no matter the value that allows a stale client atime to overwrite a correct value. Update atime in close rpc to 0 to help such servers out. Signed-of

[PATCH 21/28] staging/lustre/o2ib: Don't access NULL NI on failure path

2016-06-19 Thread Oleg Drokin
From: Doug Oucharek In kiblnd_passive_connect(), if we are failing the connection attempt because we cannot find a valid NI (we have a NULL NI), we were coring after the "goto fail" because the failure path was assuming non-NULL NI. This patch ensures we don't dereference a NULL NI on that failu

[PATCH 19/28] staging/lustre/llite: ensure obd is effective in onu_upcall

2016-06-19 Thread Oleg Drokin
From: Yang Sheng The watched obd device may still not setup while onu_upcall invoked. So we need verify it in cl_ocd_update. Signed-off-by: Yang Sheng Reviewed-on: http://review.whamcloud.com/19597 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8027 Reviewed-by: Niu Yawei Reviewed-by: Lai

[PATCH 11/28] staging/lustre/ptlrpc: lost bulk leads to a hang

2016-06-19 Thread Oleg Drokin
From: Vitaly Fertman The reverse order of request_out_callback() and reply_in_callback() puts the RPC into UNREGISTERING state, which is waiting for RPC & bulk md unlink, whereas only RPC md unlink has been called so far. If bulk is lost, even expired_set does not check for UNREGISTERING state.

[PATCH 10/28] staging/lustre/ptlrpc: Remove __ptlrpc_request_bufs_pack

2016-06-19 Thread Oleg Drokin
From: Ben Evans Combine __ptlrpc_request_bufs_pack into ptlrpc_request_bufs_pack because it was an unnecessary wrapper otherwise. Signed-off-by: Ben Evans Reviewed-on: http://review.whamcloud.com/16765 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7269 Reviewed-by: Frank Zago Reviewed-by

[PATCH 17/28] staging/lustre/llite: change it_data to it_request

2016-06-19 Thread Oleg Drokin
From: "John L. Hammond" Change the void *it_data member of struct lookup_intent to struct ptlrpc_request *it_request. Signed-off-by: John L. Hammond Reviewed-on: http://review.whamcloud.com/17070 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7403 Reviewed-by: Andreas Dilger Reviewed-by:

[PATCH 26/28] staging/lustre/osc: fix signed one bit field

2016-06-19 Thread Oleg Drokin
From: Dmitry Eremin Bit field 'oi_lockless' and 'oi_is_active' has one bit and is signed which is confusing. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/19196 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7258 Reviewed-by: Andreas Dilger Reviewed-by: James Simmo

[PATCH 18/28] staging/lustre/ldlm: const qualify struct lustre_handle * params

2016-06-19 Thread Oleg Drokin
From: "John L. Hammond" Add a const qualifier to several struct lustre_handle * parameters in the LDLM interface. Signed-off-by: John L. Hammond Reviewed-on: http://review.whamcloud.com/17071 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7403 Reviewed-by: Andreas Dilger Reviewed-by: Jame

[PATCH 23/28] staging/lustre/llite: Restore proper opencache operations

2016-06-19 Thread Oleg Drokin
From: Oleg Drokin Mark dentries that came to us via NFS in a special way so that we can tell them apart during open and activate open cache (we really don't want to do open/close RPC for every NFS IO). This became needed since dentry revlidate no longer reimplements any RPCs for lookup, and as s

[PATCH 28/28] staging/lustre/osc: glimpse lock should match only with granted locks

2016-06-19 Thread Oleg Drokin
From: Andriy Skulysh A deadlock is possible during ccc_prep_size()->ldlm_lock_match() vs cl_io_lock() which is waiting for a matched lock and conflicts with already taken lock before ccc_prep_size(). It is better to send an additional lock request to avoid deadlock. Seagate-bug-id: MRP-3312 Sig

[PATCH 27/28] staging/lustre: Add documentation for unstable_stats in sysfs

2016-06-19 Thread Oleg Drokin
commit ac5b14810952 ("staging: lustre: osc: Track and limit "unstable" pages") added a new sysfs variable, but corresponding bit of documentation was not forgotten. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/sysfs-fs-lustre | 8 1 file changed, 8 insertions(+) diff --git a/d

[PATCH 15/28] staging/lustre/llite: flatten struct lookup_intent

2016-06-19 Thread Oleg Drokin
From: "John L. Hammond" Replace the union in struct lookup_intent with the members of struct lustre_indent_data. Remove the then unused struct lustre_intent_data. Signed-off-by: John L. Hammond Reviewed-on: http://review.whamcloud.com/17069 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-74

[PATCH 22/28] staging/lustre/llite: don't panic when fid is insane

2016-06-19 Thread Oleg Drokin
From: Sergey Cheremencev LASSERT should never be done on data that is received to over the network. Return EINVAL when server returns invalid fid despite of it_status == 0. Signed-off-by: Sergey Cheremencev Seagate-bug-id: MRP-3073 Reviewed-on: http://review.whamcloud.com/17985 Intel-bug-id: ht

[PATCH 25/28] staging/lustre/llite: IOC_MDC_GETFILEINFO returns the wrong ino

2016-06-19 Thread Oleg Drokin
From: akam kumar bharathi req_capsule_server_get() through __req_capsule_get in ll_dir_ioctl() returns a pointer to a PTLRPC request or reply buffer, which is assigned to struct mdt_body. If the command is IOC_MDS_GETFILEINFO then the inode "st.st_ino" should be assigned from one extracted from

[PATCH 13/28] staging/lustre: LDLM_DEBUG() shouldn't be passed \n

2016-06-19 Thread Oleg Drokin
From: Alex Zhuravlev as it adds own \n, so any extra \n break log format. Signed-off-by: Alex Zhuravlev Reviewed-on: http://review.whamcloud.com/17494 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7521 Reviewed-by: James Simmons Reviewed-by: John L. Hammond Reviewed-by: Andreas Dilger

[PATCH 16/28] staging/lustre: Inline Lustre intent disposition functions

2016-06-19 Thread Oleg Drokin
They are just one-liners, so no point in having them exported and called through a different module. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_intent.h | 15 +++ drivers/staging/lustre/lustre/include/lustre_mdc.h| 3 --- drivers/staging/lustre/l

[PATCH 12/28] staging/lustre/llite: take trunc_sem only at vvp layer

2016-06-19 Thread Oleg Drokin
From: Patrick Farrell The lli_trunc_sem is taken in 'read' mode in both ll_page_mkwrite and vvp_io_fault_start. This can lead to a deadlock with another thread which asks for the semaphore in write mode between thse two read calls. Since all users of lli_trunc_sem are in the vvp layer, we can sa

[PATCH 14/28] staging/lustre: Add newline to LU_OBJECT_DEBUG() message

2016-06-19 Thread Oleg Drokin
From: Bob Glossman LU_OBJECT_DEBUG expects non \n terminated message from the caller, so it should add it's own to keep debug logger happy. Signed-off-by: Bob Glossman Reviewed-on: http://review.whamcloud.com/19960 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8094 Reviewed-by: Andreas Di

[PATCH 09/28] staging/lustre/ptlrpc: Early Reply vs Reply MDunlink

2016-06-19 Thread Oleg Drokin
From: Vitaly Fertman A race between unregister_reply & early reply. When buffers are busy for the early transfer, they cannon be unlinked by unregister_reply, so the RPC gets into UNREGISTERING state. The coming reply_in_callback for the early RPC already has unlinked flag set due to previous mdu

[PATCH 06/28] staging/lustre/osc: Fix reverted condition in osc_lock_weight

2016-06-19 Thread Oleg Drokin
When importing clio simplification patch, the check for object got reversed by mistake when converting from if (obj == NULL) it somehow became if (obj) which is obviously wrong, and so when it does hit, a crash was happening as result. Fix the condition and all if fine now. Signed-off-by: Oleg Dr

[PATCH 08/28] staging/lustre/ptlrpc: missing wakeup for ptlrpc_check_set

2016-06-19 Thread Oleg Drokin
From: Liang Zhen This patch changes a few things: - There is no guarantee that request_out_callback will happen before reply_in_callback, if a request got reply and unlinked reply buffer before request_out_callback is called, then the thread waiting on ptlrpc_request_set will miss wakeup e

[PATCH 03/28] staging/lustre/llite: Get rid of ll_lock_dcache/ll_unlock_dcache

2016-06-19 Thread Oleg Drokin
These are just doing spin_lock/unlock on inode's i_lock, so just do the spinlock directly to make the code more clear Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/dcache.c | 4 ++-- drivers/staging/lustre/lustre/llite/llite_internal.h | 10 -- drivers/stagi

[PATCH 05/28] staging/lustre/osc: osc_lock_weight endless loop fix

2016-06-19 Thread Oleg Drokin
From: Jinshan Xiong With huge number of pages to scan by osc_lock_weight() it is likely CLP_GANG_RESCHED is returned from osc_page_gang_lookup() and the scan will be repeated again from the start. To be sure that the scan is progressing across those restarts, next scan should be started from the

[PATCH 07/28] staging/lustre/ptlrpc: reorganize ptlrpc_request

2016-06-19 Thread Oleg Drokin
From: Liang Zhen ptlrpc_request has some structure members are only for client side, and some others are only for server side, this patch moved these members to different structure then putting into an union. By doing this, size of ptlrpc_request is decreased about 300 bytes, besides saving memo

[PATCH 04/28] staging/lustre/llite: lock i_lock before __d_drop()

2016-06-19 Thread Oleg Drokin
From: Bruno Faccini There has been several Lustre Client crashes reported by sites running with Lustre versions 2.1/2.5, all showing the same dentry->d_hash->next corrupted pointer cause. This patch fixes a regression that has been introduced since a long time by commit : (LU-506 kernel: FC15 -

[PATCH 00/28] Lustre fixes

2016-06-19 Thread Oleg Drokin
These patches represent another round of Lustre fixes and also a few cleanups that some of the fixes were building up upon. Please consider. Alex Zhuravlev (1): staging/lustre: LDLM_DEBUG() shouldn't be passed \n Andriy Skulysh (1): staging/lustre/osc: glimpse lock should match only with gra

[PATCH 01/28] staging/lustre/llite: allocate and free client cache asynchronously

2016-06-19 Thread Oleg Drokin
From: Emoly Liu Since the inflight request holds import refcount as well as export, sometimes obd_disconnect() in client_common_put_super() can't put the last refcount of OSC import (e.g. due to network disconnection), this will cause cl_cache being accessed after free. To fix this issue, ccc_us

[PATCH 02/28] staging/lustre/llite: correct request handling after ll_lookup_it()

2016-06-19 Thread Oleg Drokin
From: "John L. Hammond" In the FIFO cases of ll_atomic_open() and ll_lookup_nd() remove spurious calls to ptlrpc_req_finished(). Explain that these cases are unreachable in practice anyway. Signed-off-by: John L. Hammond Reviewed-on: http://review.whamcloud.com/17068 Intel-bug-id: https://jira.

Re: [PATCH] staging: dgnc: add __exit macro to dgnc_driver.c

2016-06-19 Thread Joshua Houghton
On Saturday, 18 June 2016 19:42:07 UTC Joshua Houghton wrote: > Add the __exit macro to the dgnc_cleanup_module(void) function > in dgnc_driver.c > > Signed-off-by: Joshua Houghton > --- > drivers/staging/dgnc/dgnc_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup

2016-06-19 Thread Craig Inches
I did build the kernel 1 for each change, then a final with all changes applied. Apologies if I missed something, Craig On Sat, Jun 18, 2016 at 07:02:35PM -0700, Greg Kroah-Hartman wrote: > On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote: > > Macros with complex values should be enc

Re: [PATCH] staging: esp8089: add new driver

2016-06-19 Thread kbuild test robot
-driver/20160619-182134 config: m68k-allyesconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the

Re: [PATCH] staging: esp8089: add new driver

2016-06-19 Thread kbuild test robot
-driver/20160619-182134 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from arch/x86/inclu

Re: [PATCH] staging: esp8089: add new driver

2016-06-19 Thread kbuild test robot
-driver/20160619-182134 config: x86_64-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): drivers/staging/esp8089/esp_mac8

Re: [PATCH 0/2] PCI: hv: fix a couple of issues in hv_pci_onchannelcallback()

2016-06-19 Thread Vitaly Kuznetsov
Bjorn Helgaas writes: > On Fri, Jun 10, 2016 at 06:53:36PM -0500, Bjorn Helgaas wrote: >> On Mon, May 30, 2016 at 04:17:57PM +0200, Vitaly Kuznetsov wrote: >> > kmemleak helped me to identify a memory leak in hv_pci_onchannelcallback() >> > and while fixing it I stumbled upon an unrelated issue(s