On Wed, Jun 08, 2016 at 04:07:59PM -0300, Gustavo Padovan wrote:
> Hi Greg,
>
> Any comment on this?
I am just starting to catch up on patches, please give me some time,
staging patches are at the bottom of my priority list, sorry.
greg k-h
___
devel m
> The semaphore ln_rc_signal is used as completion, so convert it to
> struct completion. Semaphores are going away in the future.
>
> Signed-off-by: Binoy Jayan
No problems in testing.
Acked-by: James Simmons
> ---
> drivers/staging/lustre/include/linux/lnet/lib-types.h | 3 ++-
> drivers
The lloop device was original developed to work around
the lack of direct I/O for the default loop back device.
Also the lloop device greatly out performed the default
loop back device. The lloop hasn't been worked on for
some time and now it no longer out performs the loop
device and loop now supp
Update include/linux to include the s-Par associated common include
header files needed for the s-Par visorbus.
Since we have now moved the include directories over to
include/linux/visorbus this patch makes all of the visor
drivers visorbus, visorinput, visornic, and visorhba use
the new include
This patch simple does a git mv of the
drivers/staging/unisys/Documentation directory to Documentation. Renames
overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to
the correct name sysfs-bus-visorbus.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
.../ABI/stable/sys
From: Bryan Thompson
The STANDALONE_CLIENT define is no longer used by Unisys driver code.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unis
visorbus is currently located at drivers/staging/visorbus,
this patch moves it to drivers/virt.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig| 3 +--
drivers/staging/unisys/Makefile
From: Bryan Thompson
visordriver_callback_lock is just a binary semaphore that logically
makes more sense as a mutex.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 +-
drivers/staging/unisys/visorbus
From: David Binder
This patch ONLY touches comment lines, i.e., NO executable code is
affected.
Comments were fixed in visorchannel.c:
* All functions worthy of documenting now use standard kerneldoc
formatting.
* Multi-line comments were tweaked so as to use appropriate conventions.
* Minor t
Only visorbus needs this header file so move it to visorbus
directory.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/{include => visorbus}/vbushelper.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename drivers/staging/unisys/{include => visorbus}/vbus
From: Tim Sell
The off parameter to visorchannel_create_guts() was never used, so it was
removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchannel.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
From: David Binder
Fixes the kerneldoc comment for struct visor_device - the struct members
were not listed with the appropriate @ prefix.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 34 +++
1 file chang
From: David Binder
Adds kerneldoc formatting to appropriate functions. Other multi-line
comments now use proper formatting.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 292 -
1 fi
From: David Binder
Moves function prototypes that are unique to visorbus from
include/visorbus.h to visorbus/visorbus_private.h.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 25
d
From: David Binder
This patch ONLY touches comment lines, i.e., NO executable code is
affected.
* All functions worthy of documenting now use standard kerneldoc
formatting.
* Improper uses of kerneldoc formatting were converted to standard
multi-line comments.
* Multi-line comments were twea
From: David Binder
When this functionality was first implemented, visorchipset and visorbus
were separate drivers, which necessitated a registration mechanism for
them to communicate. More-recently, visorchipset and visorbus were
combined into a single driver, and now exist as separate source fi
From: David Binder
This patch ONLY touches comment lines, i.e., NO executable code is
affected.
* All functions worthy of documenting now use standard kerneldoc
formatting.
* Multi-line comments were tweaked so as to use appropriate conventions.
* Minor typos were corrected.
Signed-off-by: Da
From: Tim Sell
This patch ONLY touches comment lines, i.e., NO executable code is
affected.
Comments were fixed in visorbus_private.h:
* Minor typos were corrected.
* Useless comments were removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/viso
From: Bryan Thompson
Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail,
visorchannel_signalqueue_max_slots, visorchannel_clear, and
visorchannel_debug which are no longer called by any driver.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
From: Tim Sell
These files were made no-longer-necessary by recent commits.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/periodic_work.h | 40 -
drivers/staging/unisys/visorbus/Makefile| 1 -
drivers/staging/unisys/visorbus/periodic_
From: David Binder
Renames visorchipset_device_pause_response to device_pause_response,
thereby following the convention that other responder functions follow.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c| 4 ++--
drivers/st
From: Tim Sell
Locking in the _interrupt() function is NOT necessary so long as we ensure
that interrupts have been stopped whenever we need to pause or resume the
device, which we now do.
While a device is paused, we ensure that interrupts stay disabled, i.e.
that the _interrupt() function will
From: Bryan Thompson
The driver that is now visorbus started out as multiple separate drivers,
and when they were merged the EXPORT_SYMBOL statements that were required
for separate drivers were left in the code. This patch removes those now
unnecessary exports.
Signed-off-by: Bryan Thompson
Si
From: Tim Sell
periodic_test_workqueue was an unused relic from the past, and was removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/unisys/visor
From: David Binder
Code relating to ktheads was previously removed from s-Par driver code.
This patch cleans up lingering remnants of kthreads by removing thread-
related enum types.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/in
From: Tim Sell
A kernel timer is now used as the vehicle to periodically call the
channel_interrupt function of registered visor drivers, instead of a
workqueue.
This simplifies a lot of things by making periodic_work.c and
periodic_work.h no longer necessary. This change also means that the
ch
From: David Binder
Modifies the format string of snprintf to expect an unsigned int
instead of a signed one, per the supplied argument.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed,
From: David Binder
Removes unused module parameters from visorbus_main.c, in response to
findings by SonarQube.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 9 +
1 file changed, 1 insertion(+), 8
From: David Binder
Fixes a comment spelling mistake in visornic.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/viso
From: David Binder
Removes unused struct definition, channel_size_info, in response to
findings by SonarQube.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6 --
1 file changed, 6 deletions(-)
diff -
From: Erik Arfvidson
This patch removes the return values from the write_vbus_* channel
functions. Nobody was checking the return values and the value stored
into the vbus info is not critical to the functioning of the device.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewe
tglx: The following patchset fixes issues you raised during your
code review of visorbus on 5/18.
Converts visorbus to use a kernel timer for periodic device-specific
callbacks instead of a workqueue, making the implementation in
periodic_work.c and periodic_work.h no longer necessary. These file
From: Erik Arfvidson
This patch modifies the caller of parahotplug_request_complete()
to check the return value and return appropriate result.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 5 -
1 fil
checkpatch.pl reported two warnings: A bare "unsigned" and an
unnecessary cast. Fixed both.
Signed-off-by: Chris Cesare
---
drivers/staging/comedi/drivers/serial2002.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/serial2002.c
b/drivers/
On 06/08/2016 08:34 AM, Brian Starkey wrote:
Hi,
I'm finding "usage_id" a bit confusing - there's not a very clear
distinction between usage_id and heap ID.
For instance, ION_IOC_USAGE_CNT claims to return the number of usage
IDs, but seems to return the number of heaps (i.e. number heap IDs, s
Hi Greg,
Any comment on this?
Gustavo
2016-05-31 Gustavo Padovan :
> From: Gustavo Padovan
>
> Hi,
>
> The following patches do a clean up on the sw_sync inteface. It starts by
> removing struct sync_timeline_ops, which was creating unecessary wrappers
> in the code and the start to
On 06/08/2016 08:15 AM, Brian Starkey wrote:
Hi Laura,
On Mon, Jun 06, 2016 at 11:23:27AM -0700, Laura Abbott wrote:
The ABI for Ion's ioctl interface are a pain to work with. The heap IDs
are a 32-bit non-discoverable namespace that form part of the ABI. There's
no way to determine what ABI ve
From: Vitaly Kuznetsov
Date: Wed, 8 Jun 2016 19:17:41 +0200
> I'm hitting 5 second timeout in rndis_filter_set_rss_param() while setting
> RSS parameters for the device. When this happens we end up returning
> -ETIMEDOUT from the function and rndis_filter_device_add() falls back to
> setting
>
The support functions for the timer subdevice are broken.
1) The (*insn_write) assumes that insn->n is always 2 (data[1] is used)
2) The (*insn_read) assumes that insn->n is always 2 (data can be returned in
data[0] and data[1]).
3) The (*insn_config) does not follow the API. It assumes insn->n
This board supports change-of-state interrupts on digital inputs 4 to 19
not 0 to 15.
The current code "works" but it could set inappropriate bits in the mode1
and mode2 registers that setup which channels are enabled. It also doesn't
return the status of the upper 4 channels (19 to 16).
Fix the
The watchdog subdevice is supported using the addi_watchdog module and
it uses the register defines from addi_tcw.h. The only register define
needed it the iobase offset to the register block.
Remove the unnecessary defines and rename the iobase define.
Signed-off-by: H Hartley Sweeten
Cc: Ian A
The timer subdevice can generate an interrupt. Currently send_sig() is used
to let the task know when the interrupt occurs. Use the dev->read_subdev
and comedi_handle_events() instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/add
This driver still uses some of old broken code in hwdrv_apci1564.c
for the timer and counter subdevices. This code does not follow the
comedi API and does not work without additional patches to the core.
Tidy up the change-of-state support so that the dev->read_subdev
can be used to handle the int
Like the timer, the support functions for the counter subdevice are broken.
Rewrite the code to follow the comedi API.
The new implementation is based on the (minimal) datasheet I have from
ADDI-DATA.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drive
The counter subdevice can generate an interrupt. Currently send_sig() is used
to let the task know when the interrupt occurs. Use the dev->read_subdev and
comedi_handle_events() instead.
Remove the, now unused, 'tsk_current' member from the private data and the
unnecessary include of .
Signed-off
> The semaphore 'lo_sem' in lloop_device is used as completion, so it
> should be written as one. Semaphores are going away in the future.
>
> Signed-off-by: Binoy Jayan
NAK. The lloop_device is about to get deleted.
> ---
> drivers/staging/lustre/lustre/llite/lloop.c | 14 +++---
> 1
> Hi,
>
> These are a set of patches which removes semaphores from:
>
> drivers/staging/lustre (lnet)
>
> These are part of a bigger effort to eliminate all semaphores
> from the linux kernel.
>
> They build correctly (individually and as a whole).
>
> Thanks,
> Binoy
I just finishing runn
On 06/08/2016 06:50 AM, Liviu Dudau wrote:
On Mon, Jun 06, 2016 at 11:23:33AM -0700, Laura Abbott wrote:
From: Laura Abbott
The Ion ABI for heaps is limiting to work with for more complex systems.
Heaps have to be registered at boot time with known ids available to
userspace. This becomes a t
On 06/06/2016 11:59 PM, Chen Feng wrote:
The idea is good, define the heap ids in header file is inconvenient.
But if we query the heaps information from user-space.
It need to maintain this ids and name userspace one by one. The code may
be complicated in different module user-space.
In andro
I'm hitting 5 second timeout in rndis_filter_set_rss_param() while setting
RSS parameters for the device. When this happens we end up returning
-ETIMEDOUT from the function and rndis_filter_device_add() falls back to
setting
net_device->max_chn = 1;
net_device->num_chn = 1;
On Wed, Jun 08, 2016 at 11:28:11AM -0500, Jaime Arrocha wrote:
>
> On Wed, 08 Jun 2016 10:49:47 -0500 Greg KH
> wrote
>
> > On Wed, Jun 08, 2016 at 08:46:06AM -0500, Jaime Arrocha wrote:
> > > From: Jaime Arrocha
> > >
> > > Replaced deprecated goto statements.
> >
> >
On Wednesday, June 08, 2016 2:34 AM, Ian Abbott wrote:
> On 06/06/16 20:51, Hartley Sweeten wrote:
>> From that I assume that the other bits will always return 0.
>
> Since it doesn't explicitly sat the other bits return 0, and until
> someone can confirm, I think it's better not to assume that.
On Wed, 08 Jun 2016 10:49:47 -0500 Greg KH
wrote
> On Wed, Jun 08, 2016 at 08:46:06AM -0500, Jaime Arrocha wrote:
> > From: Jaime Arrocha
> >
> > Replaced deprecated goto statements.
>
> Since when is 'goto' deprecated?
>
> Were you able to test these changes?
>
Vitaly Kuznetsov writes:
> I'm hitting 5 second timeout in rndis_filter_set_rss_param() while setting
> RSS parameters for the device. When this happens we end up returning
> -ETIMEDOUT from the function and rndis_filter_device_add() falls back to
> setting
>
> net_device->max_chn = 1;
>
On Wed, Jun 08, 2016 at 08:46:06AM -0500, Jaime Arrocha wrote:
> From: Jaime Arrocha
>
> Replaced deprecated goto statements.
Since when is 'goto' deprecated?
Were you able to test these changes?
thanks,
greg k-h
___
devel mailing list
de...@linuxdr
On Wednesday, June 8, 2016 1:10:53 PM CEST Binoy Jayan wrote:
> These are a set of patches which removes semaphores from:
>
> drivers/staging/rtl8723au
>
> These are part of a bigger effort to eliminate all semaphores
> from the linux kernel.
>
> They build correctly (individually and as a whol
Hi,
I'm finding "usage_id" a bit confusing - there's not a very clear
distinction between usage_id and heap ID.
For instance, ION_IOC_USAGE_CNT claims to return the number of usage
IDs, but seems to return the number of heaps (i.e. number heap IDs, some
of which might be usage_ids).
Similarly,
Hi Laura,
On Mon, Jun 06, 2016 at 11:23:27AM -0700, Laura Abbott wrote:
The ABI for Ion's ioctl interface are a pain to work with. The heap IDs
are a 32-bit non-discoverable namespace that form part of the ABI. There's
no way to determine what ABI version is in use which leads to problems
if the
On Wed, Jun 08, 2016 at 02:42:08PM +, Binder, David Anthony wrote:
> > -Original Message-
> > From: Neil Horman [mailto:nhor...@redhat.com]
> > Sent: Wednesday, June 08, 2016 9:08 AM
> > To: Binder, David Anthony
> > Cc: Kershner, David A ; cor...@lwn.net;
> > t...@linutronix.de; mi...
> -Original Message-
> From: Neil Horman [mailto:nhor...@redhat.com]
> Sent: Wednesday, June 08, 2016 9:08 AM
> To: Binder, David Anthony
> Cc: Kershner, David A ; cor...@lwn.net;
> t...@linutronix.de; mi...@redhat.com; h...@zytor.com;
> gre...@linuxfoundation.org; Arfvidson, Erik ;
> Sell
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Wednesday, June 8, 2016 10:19 AM
> To: net...@vger.kernel.org
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; KY
> Srinivasan ; Haiyang Zhang
> Subject: [PATCH RFC net-next] netvsc: get r
I'm hitting 5 second timeout in rndis_filter_set_rss_param() while setting
RSS parameters for the device. When this happens we end up returning
-ETIMEDOUT from the function and rndis_filter_device_add() falls back to
setting
net_device->max_chn = 1;
net_device->num_chn = 1;
On Mon, Jun 06, 2016 at 11:23:33AM -0700, Laura Abbott wrote:
> From: Laura Abbott
>
>
> The Ion ABI for heaps is limiting to work with for more complex systems.
> Heaps have to be registered at boot time with known ids available to
> userspace. This becomes a tight ABI which is prone to breakag
From: Jaime Arrocha
Replaced deprecated goto statements.
Signed-off-by: Jaime Arrocha
---
drivers/staging/slicoss/slicoss.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index
On 05/06/16 21:35, Martyn Welch wrote:
> The vme_register_driver() api changed in commit 5d6abf379d73 ("staging:
> vme: make match() driver specific to improve non-VME64x support") but the
> documentation wasn't updated. Update the documentation to match the API.
>
> Signed-off-by: Martyn Welch
>
On Mon, Jun 06, 2016 at 11:23:31AM -0700, Laura Abbott wrote:
>
> The number of Ion ioctls may continue to grow along with necessary
> validation. Pull it out into a separate file for easier management
> and review.
>
> Signed-off-by: Laura Abbott
Reviewed-by: Liviu Dudau
> ---
> drivers/sta
On Mon, Jun 06, 2016 at 11:23:29AM -0700, Laura Abbott wrote:
> From: Laura Abbott
>
>
> In anticipation of dynamic registration of heaps, switch to using
> an idr for heaps. The idr makes it easier to control the assignment
> and management + lookup of heap numbers.
>
> Signed-off-by: Laura Ab
On Wed, Jun 08, 2016 at 02:13:47AM +, Binder, David Anthony wrote:
> > -Original Message-
> > From: Neil Horman [mailto:nhor...@redhat.com]
> > Sent: Tuesday, June 07, 2016 9:23 AM
> > To: Kershner, David A
> > Cc: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com;
> > h...@zytor.co
On Mon, Jun 06, 2016 at 11:23:28AM -0700, Laura Abbott wrote:
> From: Laura Abbott
>
>
> ion_device_add_heap doesn't return an error value. Change it to return
> information to callers.
>
> Signed-off-by: Laura Abbott
Reviewed-by: Liviu Dudau
> ---
> drivers/staging/android/ion/ion.c
On 08/06/16 13:25, Parth Sane wrote:
> No mate, that aint just cutting it.
> I tried putting it, maybe i’m doing something wrong?
> Regards,
> Parth
>> On 08-Jun-2016, at 5:46 PM, Luis de Bethencourt
>> wrote:
>>
>> On 08/06/16 12:58, Parth Sane wrote:
>>> I’m trying to fix line 224 but its simpl
No mate, that aint just cutting it.
I tried putting it, maybe i’m doing something wrong?
Regards,
Parth
> On 08-Jun-2016, at 5:46 PM, Luis de Bethencourt
> wrote:
>
> On 08/06/16 12:58, Parth Sane wrote:
>> I’m trying to fix line 224 but its simply not happening. Can you help me
>> with this?
>
Binoy Jayan writes:
> Hi,
>
> These are a set of patches which removes semaphores from:
>
> drivers/staging/rtl8723au
>
> These are part of a bigger effort to eliminate all semaphores
> from the linux kernel.
>
> They build correctly (individually and as a whole).
> NB: I have not tested this as
On 08/06/16 12:58, Parth Sane wrote:
> I’m trying to fix line 224 but its simply not happening. Can you help me with
> this?
> Regards,
> Parth
>> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt
>> wrote:
>>
>> On 08/06/16 12:37, Parth Sane wrote:
>>>
On 08-Jun-2016, at 5:01 PM, Luis de Bet
I’m trying to fix line 224 but its simply not happening. Can you help me with
this?
Regards,
Parth
> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt
> wrote:
>
> On 08/06/16 12:37, Parth Sane wrote:
>>
>>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt
>>> wrote:
>>>
>>> On 08/06/16 12:27,
On 08/06/16 12:37, Parth Sane wrote:
>
>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt
>> wrote:
>>
>> On 08/06/16 12:27, Parth Sane wrote:
>>> Multiple parenthesis alignment warnings were thrown by checkpatch in
>>> ieee80211.c
>>> This patch effectively fixes that.
>>>
>>> Signed-off-by: P
> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt
> wrote:
>
> On 08/06/16 12:27, Parth Sane wrote:
>> Multiple parenthesis alignment warnings were thrown by checkpatch in
>> ieee80211.c
>> This patch effectively fixes that.
>>
>> Signed-off-by: Parth Sane
>>
>> ---
>> drivers/staging/rtl87
On 08/06/16 12:27, Parth Sane wrote:
> Multiple parenthesis alignment warnings were thrown by checkpatch in
> ieee80211.c
> This patch effectively fixes that.
>
> Signed-off-by: Parth Sane
>
> ---
> drivers/staging/rtl8712/ieee80211.c | 25 -
> 1 file changed, 12 insert
Multiple parenthesis alignment warnings were thrown by checkpatch in ieee80211.c
This patch effectively fixes that.
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/ieee80211.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/r
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the jr3_pci.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/j
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the das16m1.c file that fixes up a
WARNING: 'Block comments use a trailing */ on a separate line'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/dri
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the comedi_bond.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drive
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This patch Replace all occurences of (1<
---
drivers/staging/comedi/drivers/das6402.c | 74
1 file changed, 38 insertions(+), 36 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This patch Replace all occurences of (1<
---
drivers/staging/comedi/drivers/das16.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ M
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the jr3_pci.c file that fixes up a
WARNING: 'Block comments use a trailing */ on a separate line'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/dri
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the me_daq.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/me
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the mpc624.c file that fixes up a
WARNING: 'Statements should start on a tabstop' found by
the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/mpc624.c |
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the pcmuio.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/pc
On 06/06/16 12:01, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the ni_65xx.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni
These have since been reposted by Ravi in a different order and one
minor correction, so can be scrapped, I guess.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
___
devel mailing list
de...@li
On 08/06/16 10:48, Ravishankar Karkala Mallikarjunayya wrote:
This fixes up a WARNING: 'Block comments use a trailing */ on a
separate line'found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/s626.h | 356 +
On 08/06/16 06:30, Ravishankar Karkala Mallikarjunayya wrote:
This fixes all occurences of (1<
---
drivers/staging/comedi/drivers/dmm32at.c | 86
1 file changed, 43 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dmm32at.c
b/drivers
This fixes up a WARNING: 'Block comments use a trailing */ on a
separate line'found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/s626.h | 356 ++
1 file changed, 237 insertions(+), 119 deletions(-
On 08/06/16 06:30, Ravishankar Karkala Mallikarjunayya wrote:
This fixes up a WARNING: 'Block comments use a trailing */ on a
separate line'found by the checkpatch.pl tool
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das800.c | 102
On 08/06/16 06:30, Ravishankar Karkala Mallikarjunayya wrote:
This fixes up a WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das800.c | 4 ++--
1 file changed, 2 i
On 08/06/16 06:30, Ravishankar Karkala Mallikarjunayya wrote:
This fixes up a WARNING: 'Block comments use a trailing */ on a
separate line'found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das16.c | 6 --
1 file change
On 08/06/16 03:23, Akshay Shipurkar wrote:
Where is patch 1/2?
Fixed a multi-line comment coding style issue.
Signed-off-by: Akshay Shipurkar
---
drivers/staging/comedi/drivers/das16.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das1
On 06/06/16 20:51, Hartley Sweeten wrote:
On Monday, June 06, 2016 12:33 PM, Ian Abbott wrote:
Okay, I think I must have got something inverted in my head at the time
I wrote my reply.
Follow-up question: when you do:
s->state = inl(dev->iobase + APCI1564_DI_INT_STATUS_REG);
s
On 07/06/16 21:07, Greg KH wrote:
On Wed, Jun 08, 2016 at 01:30:01AM +0530, Rithvik Patibandla wrote:
**Intro**
Why this line?
The following patch fixes warnings thrown by checkpatch.pl script. The
warnings are:
"It is preferable to use WRITE_ONCE(, ) instead of
ACCESS_ONCE() = "
"It is pre
Hi,
These are a set of patches which removes semaphores from:
drivers/staging/lustre (lnet)
These are part of a bigger effort to eliminate all semaphores
from the linux kernel.
They build correctly (individually and as a whole).
Thanks,
Binoy
Binoy Jayan (2):
staging: lustre: lloop_devic
The semaphore ln_rc_signal is used as completion, so convert it to
struct completion. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
drivers/staging/lustre/include/linux/lnet/lib-types.h | 3 ++-
drivers/staging/lustre/lnet/lnet/router.c | 9 +
2 fil
1 - 100 of 104 matches
Mail list logo