Hi,
These are a set of patches [v3] which removes semaphores from:
drivers/staging/rtl8188eu
These are part of a bigger effort to eliminate all semaphores
from the linux kernel.
They build correctly (individually and as a whole).
NB: I have not tested this as I do not have the following hardwa
The semaphores xmit_sema, terminate_xmitthread_sema and tx_retevt
have no users, hence remove all references to them.
Signed-off-by: Binoy Jayan
Reviewed-by: Arnd Bergmann
Acked-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 4
drivers/staging/rtl8188eu/include/o
The semaphore 'cmd_queue_sema' is used as completion,
so convert it to struct completion.
Signed-off-by: Binoy Jayan
Reviewed-by: Arnd Bergmann
Acked-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c| 6 +++---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
drivers/staging
The semaphore 'terminate_cmdthread_sema' is used as completion,
so convert it to struct completion.
Signed-off-by: Binoy Jayan
Reviewed-by: Arnd Bergmann
Acked-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c| 6 +++---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
drive
The semaphore 'lock' in pwrctrl_priv is a simple mutex, so it should
be written as one. Semaphores are going away in the future.
_enter_pwrlock was using down_interruptible(), so the lock could be broken
by sending a signal. This could be a bug, because nothing checks the return
code here. Hence, u
The semaphore 'terminate_cmdthread_sema' is used as completion,
so convert it to struct completion.
Signed-off-by: Binoy Jayan
Reviewed-by: Arnd Bergmann
---
drivers/staging/rtl8188eu/core/rtw_cmd.c| 6 +++---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
drivers/staging/rtl8188eu/os_
The semaphore 'lock' in pwrctrl_priv is a simple mutex, so it should
be written as one. Semaphores are going away in the future.
_enter_pwrlock was using down_interruptible(), so the lock could be broken
by sending a signal. This could be a bug, because nothing checks the return
code here. Hence, u
Hi,
These are a set of patches [v2] which removes semaphores from:
drivers/staging/rtl8188eu
These are part of a bigger effort to eliminate all semaphores
from the linux kernel.
They build correctly (individually and as a whole).
NB: I have not tested this as I do not have the following hardwa
The semaphores xmit_sema, terminate_xmitthread_sema and tx_retevt
have no users, hence remove all references to them.
Signed-off-by: Binoy Jayan
Reviewed-by: Arnd Bergmann
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 4
drivers/staging/rtl8188eu/include/osdep_service.h | 1 -
dr
The semaphore 'cmd_queue_sema' is used as completion,
so convert it to struct completion.
Signed-off-by: Binoy Jayan
Reviewed-by: Arnd Bergmann
---
drivers/staging/rtl8188eu/core/rtw_cmd.c| 6 +++---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
drivers/staging/rtl8188eu/os_dep/os_int
From: Oleg Drokin
It's no longer used and never set anywhere.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_cl_internal.h | 5 -
drivers/staging/lustre/lustre/osc/osc_page.c| 2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/
From: Oleg Drokin
Here are a few more Lustre fixes and cleanups.
Jinshan Xiong (2):
staging/lustre/lov: calculate file offset correctly
staging/lustre/llite: define per open file cache for ll_cl_context
Oleg Drokin (2):
staging/lustre/osc: Remove ops_temp from osc_page
staging/lustre/os
From: Jinshan Xiong
In ll_readpage and ll_write_begin, it needs to find out the cl_env
and cl_io, a.k.a ll_cl_context, when the IO is initialized. It used
to call cl_env_get() to figure it out but turned out to be contended
if multiple threads are doing IO.
In this patch, a per open file ll_cl_c
From: Oleg Drokin
There was a proper debugging function by that name that's long
gone.
The currently remaining shadow that always returns true is not
really useful so it could be dropped along with all the
asserts it is part of.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/
From: Jinshan Xiong
In lov_stripe_pgoff(), it calls lov_stripe_size() to calculate the
file size by ost_size, which will be wrong if the stripe_index
happens to be stripe aligned.
Signed-off-by: Jinshan Xiong
Reviewed-on: http://review.whamcloud.com/14462
Intel-bug-id: https://jira.hpdd.intel.c
Replaced ACCESS_ONCE calls with READ/WRITE_ONCE calls.
Signed-off-by: Andy Eleftherion
---
drivers/staging/comedi/comedi_fops.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index 6290
From: Vitaly Kuznetsov
Date: Fri, 3 Jun 2016 17:50:57 +0200
> Changes since v1:
> - resend when net-next is open [David Miller]
> - rebased to current net-next.
>
> After we made traveling through our internal structures explicit it became
> obvious that some functions take arguments they don't
The vme_register_driver() api changed in commit 5d6abf379d73 ("staging:
vme: make match() driver specific to improve non-VME64x support") but the
documentation wasn't updated. Update the documentation to match the API.
Signed-off-by: Martyn Welch
---
Documentation/vme_api.txt | 9 +
1 fi
Commit fadbe0cd5292851608e2e01b91d9295fa287b9fe ("staging: rtl8188eu:
Remove rtw_zmalloc(), wrapper for kzalloc()") changed all allocation
calls to be GFP_KERNEL even though the original wrapper was testing
to determine if the caller was in atomic mode. Most of the mistakes
were corrected with comm
This is a patch to the ddk750_chip.c file that fixes up a line length
warning found by the checkpatch.pl tool
Signed-off-by: Moshe Green
---
drivers/staging/sm750fb/ddk750_chip.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/drive
This reverts commit b5e12ec38331 ("Staging: rtl8188eu: rtw_efuse: Use
sizeof type *pointer instead of sizeof type.").
This commit is wrong, the rtw_malloc2d helper function takes the size of
the array elements as its 3th argument, whereas sizeof(*eFuseWord)
gives the size of a pointer instead of t
Hi Greg,
I noticed that the rtl8188eu driver from staging has regressed
after the staging 4.7-rc1 pull-req. Looking through the commits
I found 2 wrong commits, the first one I believe is the cause for
the regression I'm seeing (driver does not work, crashes the kernel),
the second one also is tec
This reverts commit 99aded71b52c ("Staging: drivers: rtl8188eu: use
sizeof(*ptr) instead of sizeof(struct)").
This commit is wrong, as adapt->HalData has a type of "void *", so
now we are allocating a much to small struct, which causes the driver
to overwrite random memory which leads to a non wor
On 06/03/2016 04:59 AM, Binoy Jayan wrote:
The semaphore 'cmd_queue_sema' is used as completion,
so convert it to struct completion.
Signed-off-by: Binoy Jayan
The subject for this patch has a misplaced "i" at the beginning courtesy of vi.
One other point, it is customary to start the patch
Commit 99aded71b52cfdfa22721c42e42efdd13a02f0a6 ("Staging: drivers: rtl8188eu:
use sizeof(*ptr) instead of sizeof(struct)") introduces an error in that the
sizeof(struct hal_data_8188e) is 18712, while the sizeof(*adapt->HalData) is
only 1! As a result, the system panics.
Fixes: 99aded71b52cfdfa22
When this driver preallocates some SKBs, kmemleak is unable to find that
allocated memory when it scans. When the driver is unloaded, that memory
is released; therefore, the report is a false positive.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 2 ++
1 file
On Sun, Jun 05, 2016 at 04:51:23PM +0800, Chen Feng wrote:
> Hi Greg,
>
> Can you take this patch?
It's in my queue, please wait, staging patches are at the bottom of it,
rightfully so...
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverprojec
Hi Greg,
Can you take this patch?
Thanks
On 2016年05月24日 06:32, Laura Abbott wrote:
> On 05/18/2016 08:03 PM, Chen Feng wrote:
>> Add ion cached pool in system heap. This patch add a cached pool
>> in system heap. It has a great improvement of alloc for cached
>> buffer.
>>
>> With memory pressue
Commit 99aded71b52cfdfa22721c42e42efdd13a02f0a6 ("Staging: drivers: rtl8188eu:
use sizeof(*ptr) instead of sizeof(struct)") introduces an error in that the
sizeof(struct hal_data_8188e) is 18712, while the sizeof(*adapt->HalData) is
only 1! As a result, the system panics.
Fixes: 99aded71b52cfdfa22
29 matches
Mail list logo
