Re: [PATCH v2 13/27] staging: unisys: visorbus: Make visordriver_callback_lock a mutex

2016-05-31 Thread Thomas Gleixner
On Tue, 31 May 2016, David Kershner wrote: > From: Bryan Thompson > > visordriver_callback_lock is just a binary semaphore that logically > makes more sense as a mutex. > > Signed-off-by: Bryan Thompson > Signed-off-by: David Kershner > Reviewed-by: Tim Sell > --- > drivers/staging/unisys/i

Re: [PATCH v2 20/27] staging: unisys: visorbus: make visorchannel function descriptions more kerneldoc-like

2016-05-31 Thread Thomas Gleixner
On Tue, 31 May 2016, David Kershner wrote: > From: David Binder > > Per audit feedback from Thomas Gleixner, function descriptions in > visorchannel.c now utilize a more kerneldoc-like formatting. The affected > comments do not implement other kerneldoc requirements. That was not my feedback.

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-05-31 Thread Thomas Gleixner
On Tue, 31 May 2016, David Kershner wrote: > + /* > + * If we're not paused, really enable interrupts. > + * Regardless of whether we are paused, set a flag indicating > + * interrupts should be enabled so when we resume, interrupts > + * will really be enabled. > + */

RE: [PATCH v3] Drivers: hv: vmbus: fix the race when querying & updating the percpu list

2016-05-31 Thread Dexuan Cui
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, June 1, 2016 0:27 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY Srinivasan ; Haiyang

Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue

2016-05-31 Thread Greg KH
On Tue, May 31, 2016 at 11:00:01PM -0700, Ashwin wrote: > From: Ashwin R I need a "full" name here, and in the signed-off-by line please. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mail

[PATCH 2649/2649] Staging: comedi : fixed a camel case style issue

2016-05-31 Thread Ashwin
From: Ashwin R Fixed a coding style issue. Signed-off-by: Ashwin R --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/dri

[PATCH 4/4] rtl8712: pwrctrl_priv: Replace semaphore lock with mutex

2016-05-31 Thread Binoy Jayan
The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- This patch depends on the following patch: rtl8712: intf_priv: Replace semaphore lock with completion drivers/staging/rtl87

[PATCH 1/4] rtl8712: Replace semaphore cmd_queue_sema with completion

2016-05-31 Thread Binoy Jayan
The semaphore 'cmd_queue_sema' is used as completion, so convert it to a struct completion type. Signed-off-by: Binoy Jayan --- drivers/staging/rtl8712/os_intfs.c| 2 +- drivers/staging/rtl8712/osdep_service.h | 7 +++ drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- drivers/stagi

[PATCH 3/4] rtl8712: intf_priv: Replace semaphore lock with completion

2016-05-31 Thread Binoy Jayan
The semaphore 'lock' in 'intf_priv' is used as completion, so convert it to a struct completion type. Signed-off-by: Binoy Jayan --- This patch depends on the following patch: rtl8712: Replace semaphore terminate_cmdthread_sema with completion drivers/staging/rtl8712/osdep_intf.h| 2 +- dr

[PATCH 2/4] rtl8712: Replace semaphore terminate_cmdthread_sema with completion

2016-05-31 Thread Binoy Jayan
The semaphore 'terminate_cmdthread_sema' is used as completion, so convert it to a struct completion type. Signed-off-by: Binoy Jayan --- This patch depends on the following patch: rtl8712: Replace semaphore cmd_queue_sema with completion drivers/staging/rtl8712/os_intfs.c| 2 +- drivers/s

[PATCH 0/4] *** rtl8712: Replace semaphores with mutex / completions ***

2016-05-31 Thread Binoy Jayan
Hi, These are a set of patches which removes semaphores from: drivers/staging/rtl8712 They build correctly (individually and as a whole). NB: I have not tested this as I do not have the following hardware: "RealTek RTL8712U (RTL8192SU) Wireless LAN NIC driver" Thanks, Binoy Binoy Jayan (4):

[PATCH v2 26/27] Documentation: Move visorbus documentation from staging to Documentation/

2016-05-31 Thread David Kershner
This patch simple does a git mv of the drivers/staging/unisys/Documentation directory to Documentation. Renames overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to the correct name sysfs-bus-visorbus. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- .../ABI/stable/sys

[PATCH v2 17/27] staging: unisys: visorbus: vbusdeviceinfo function descriptions more kerneldoc-like

2016-05-31 Thread David Kershner
From: David Binder Per audit feedback from Thomas Gleixner, function descriptions in vbusdeviceinfo.h now utilize a more kerneldoc-like formatting. The affected comments do not implement other kerneldoc requirements. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Se

[PATCH v2 19/27] staging: unisys: visorbus: make visorbus_private.h function descriptions more kerneldoc-like

2016-05-31 Thread David Kershner
From: David Binder Per audit feedback from Thomas Gleixner, function descriptions in visorbus_private.h now utilize a more kerneldoc-like formatting. The affected comments do not implement other kerneldoc requirements. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim

[PATCH v2 20/27] staging: unisys: visorbus: make visorchannel function descriptions more kerneldoc-like

2016-05-31 Thread David Kershner
From: David Binder Per audit feedback from Thomas Gleixner, function descriptions in visorchannel.c now utilize a more kerneldoc-like formatting. The affected comments do not implement other kerneldoc requirements. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v2 00/27] Fixed issues raised by tglx, then move visorbus to drivers/virt

2016-05-31 Thread David Kershner
tglx: The following patchset fixes issues you raised during your code review of visorbus on 5/18. Greg: Please drop all other patch series sent in from me as this patch series incorporates the required patches from the previous series. Converts visorbus to use a kernel timer for periodic device-

[PATCH v2 01/27] staging: unisys: visorbus change -1 return values

2016-05-31 Thread David Kershner
From: Erik Arfvidson This patch changes the vague -1 return values to -EFAULT since it would be the most appropriate, given that this error would only occur in an unexpected bad offset field. Resulting in a bad address. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: T

[PATCH v2 18/27] staging: unisys: visorbus: make function descriptions more kerneldoc-like

2016-05-31 Thread David Kershner
From: David Binder Per audit feedback from Thomas Gleixner, function descriptions in visorbus_main.c now utilize a more kerneldoc-like formatting. The affected comments do not implement other kerneldoc requirements. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sel

[PATCH v2 08/27] staging: unisys: include: Remove thread-related enum members

2016-05-31 Thread David Kershner
From: David Binder Code relating to ktheads was previously removed from s-Par driver code. This patch cleans up lingering remnants of kthreads by removing thread- related enum types. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/in

[PATCH v2 14/27] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements

2016-05-31 Thread David Kershner
From: Bryan Thompson The driver that is now visorbus started out as multiple separate drivers, and when they were merged the EXPORT_SYMBOL statements that were required for separate drivers were left in the code. This patch removes those now unnecessary exports. Signed-off-by: Bryan Thompson Si

[PATCH v2 27/27] drivers: Add visorbus to the drivers directory

2016-05-31 Thread David Kershner
visorbus is currently located at drivers/staging/visorbus, this patch moves it to drivers/virt. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig| 3 +-- drivers/staging/unisys/Makefile

[PATCH v2 16/27] staging: unisys: Remove reference to unused STANDALONE_CLIENT

2016-05-31 Thread David Kershner
From: Bryan Thompson The STANDALONE_CLIENT define is no longer used by Unisys driver code. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unis

[PATCH v2 21/27] staging: unisys: visorbus: make visorchipset function descriptions more kerneldoc-like

2016-05-31 Thread David Kershner
From: David Binder Per audit feedback from Thomas Gleixner, function descriptions in visorchipset.c now utilize a more kerneldoc-like formatting. The affected comments do not implement other kerneldoc requirements. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v2 22/27] staging: unisys: visorbus: Move visorbus-unique functions to private header

2016-05-31 Thread David Kershner
From: David Binder Moves function prototypes that are unique to visorbus from include/visorbus.h to visorbus/visorbus_private.h. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 25 d

[PATCH v2 15/27] staging: unisys: visorbus: Remove unused functions

2016-05-31 Thread David Kershner
From: Bryan Thompson Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail, visorchannel_signalqueue_max_slots, visorchannel_clear, and visorchannel_debug which are no longer called by any driver. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v2 25/27] include: linux: visorbus: Add visorbus to include/linux directory

2016-05-31 Thread David Kershner
Update include/linux to include the s-Par associated common include header files needed for the s-Par visorbus. Since we have now moved the include directories over to include/linux/visorbus this patch makes all of the visor drivers visorbus, visorinput, visornic, and visorhba use the new include

[PATCH v2 23/27] staging: unisys: visorbus: Add kerneldoc-style comments for visorbus API

2016-05-31 Thread David Kershner
From: David Binder Adds kerneldoc-style comments for those functions which may be used outside of the visorbus driver. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 127 drivers/s

[PATCH v2 12/27] staging: unisys: visorbus: remove periodic_work.h/.c

2016-05-31 Thread David Kershner
From: Tim Sell These files were made no-longer-necessary by recent commits. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/include/periodic_work.h | 40 - drivers/staging/unisys/visorbus/Makefile| 1 - drivers/staging/unisys/visorbus/periodic_

[PATCH v2 07/27] staging: unisys: visornic: Correct comment spelling mistake

2016-05-31 Thread David Kershner
From: David Binder Fixes a comment spelling mistake in visornic. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/viso

[PATCH v2 05/27] staging: unisys: visorbus: remove unused struct

2016-05-31 Thread David Kershner
From: David Binder Removes unused struct definition, channel_size_info, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 6 -- 1 file changed, 6 deletions(-) diff -

[PATCH v2 06/27] staging: unisys: visorbus: modify format string to match argument

2016-05-31 Thread David Kershner
From: David Binder Modifies the format string of snprintf to expect an unsigned int instead of a signed one, per the supplied argument. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- 1 file changed,

[PATCH v2 03/27] staging: unisys: iovmcall_gnuc.h change -1 return values

2016-05-31 Thread David Kershner
From: Erik Arfvidson This patch changes the vague -1 return values to -EPERM. This operation is not supported is a good alternative to -1 because the return is basically telling the caller that the processor doesn't support vmcall operations. Signed-off-by: Erik Arfvidson Signed-off-by: David K

[PATCH v2 02/27] staging: unisys: visorchipset change -1 return value

2016-05-31 Thread David Kershner
From: Erik Arfvidson This patch changes the vague -1 return value to -EINVAL Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagin

[PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-05-31 Thread David Kershner
From: Tim Sell Locking in the _interrupt() function is NOT necessary so long as we ensure that interrupts have been stopped whenever we need to pause or resume the device, which we now do. While a device is paused, we ensure that interrupts stay disabled, i.e. that the _interrupt() function will

[PATCH v2 24/27] staging: unisys: Move vbushelper.h to visorbus directory

2016-05-31 Thread David Kershner
Only visorbus needs this header file so move it to visorbus directory. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/{include => visorbus}/vbushelper.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename drivers/staging/unisys/{include => visorbus}/vbus

[PATCH v2 13/27] staging: unisys: visorbus: Make visordriver_callback_lock a mutex

2016-05-31 Thread David Kershner
From: Bryan Thompson visordriver_callback_lock is just a binary semaphore that logically makes more sense as a mutex. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 3 ++- drivers/staging/unisys/visorbu

[PATCH v2 09/27] staging: unisys: visorbus: removed unused periodic_test_workqueue

2016-05-31 Thread David Kershner
From: Tim Sell periodic_test_workqueue was an unused relic from the past, and was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/unisys/visor

[PATCH v2 04/27] staging: unisys: visorbus: remove unused module parameters

2016-05-31 Thread David Kershner
From: David Binder Removes unused module parameters from visorbus_main.c, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 9 + 1 file changed, 1 insertion(+), 8

[PATCH v2 11/27] staging: unisys: visorbus: use kernel timer instead of workqueue

2016-05-31 Thread David Kershner
From: Tim Sell A kernel timer is now used as the vehicle to periodically call the channel_interrupt function of registered visor drivers, instead of a workqueue. This simplifies a lot of things by making periodic_work.c and periodic_work.h no longer necessary. This change also means that the ch

Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c

2016-05-31 Thread Joe Perches
On Tue, 2016-05-31 at 11:29 +0100, Ian Abbott wrote: > On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > > > > This is a patch to the s626.c file that fixes up a type issues like > > i.e Prefer kernel type 'u8' over 'uint8_t' > >  Prefer kernel type 'u16' over 'uint16_t' > >

[PATCH] Staging: comedi: das16.c: Added a blank line fixed a comment, coding style issue

2016-05-31 Thread Pedro Nieto
From: PedroNieto Fixed a coding style issue. Signed-off-by: Pedro Nieto --- drivers/staging/comedi/drivers/das16.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c index fd8e0b7..ef345dc

Re: [PATCH 1/2] staging: iio: accel: fix error check

2016-05-31 Thread Luis de Bethencourt
On 31/05/16 22:08, Luis de Bethencourt wrote: > sca3000_read_ctrl_reg() returns a negative number on failure, check for > this instead of zero. > > Signed-off-by: Luis de Bethencourt > Reviewed-by: Andrew F. Davis > Reviewed-by: Jonathan Cameron > --- > > Patch corrected thanks to comments fro

[PATCH 1/2] staging: iio: accel: fix error check

2016-05-31 Thread Luis de Bethencourt
sca3000_read_ctrl_reg() returns a negative number on failure, check for this instead of zero. Signed-off-by: Luis de Bethencourt Reviewed-by: Andrew F. Davis Reviewed-by: Jonathan Cameron --- Patch corrected thanks to comments from Andrew F. Davis and Jonathan Cameron. https://lkml.org/lkml/20

[PATCH 2/2] staging: iio: accel: add error check

2016-05-31 Thread Luis de Bethencourt
Go to error_ret if sca3000_read_ctrl_reg() failed. Signed-off-by: Luis de Bethencourt --- Noticed this while inspecting the code for the 1/2 patch. Thanks, Luis drivers/staging/iio/accel/sca3000_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/iio/accel/sca3000_cor

Re: [PATCH] staging: iio: accel: remove impossible condition

2016-05-31 Thread Luis de Bethencourt
On 31/05/16 21:23, Jonathan Cameron wrote: > > > On 31 May 2016 20:47:50 BST, Luis de Bethencourt > wrote: >> val is set to the value of ret right after ret is checked. If ret is >> not >> zero it goes to error_ret. So only value ret can have is zero, which >> makes >> the switch (val & 0x03) o

Re: [PATCH] staging: iio: accel: remove impossible condition

2016-05-31 Thread Jonathan Cameron
On 31 May 2016 20:47:50 BST, Luis de Bethencourt wrote: >val is set to the value of ret right after ret is checked. If ret is >not >zero it goes to error_ret. So only value ret can have is zero, which >makes >the switch (val & 0x03) only match the case 0x00. Removing the switch >and >since val i

Re: [PATCH] staging: iio: accel: remove impossible condition

2016-05-31 Thread Andrew F. Davis
On 05/31/2016 02:47 PM, Luis de Bethencourt wrote: > val is set to the value of ret right after ret is checked. If ret is not > zero it goes to error_ret. So only value ret can have is zero, which makes > the switch (val & 0x03) only match the case 0x00. Removing the switch and > since val is only

[PATCH 18/18] staging/android: add DEBUG_FS dependence on Kconfig

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan SW_SYNC only works with DEBUG_FS so state it in the Kconfig file. Signed-off-by: Gustavo Padovan --- drivers/staging/android/Kconfig | 1 + drivers/staging/android/sync_debug.c | 4 drivers/staging/android/sync_debug.h | 4 +--- 3 files changed, 2 insertions(+),

[PATCH 17/18] staging/android: rename sync.h to sync_debug.h

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan This header file only contains information for debugging and SW_SYNC, so rename it to sync_debug.h instead of having a more generic name. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c| 2 +- drivers/staging/android/sync_debug.c

[PATCH 16/18] staging/android: remove drv_name from sync_timeline

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan As it is internal to sw_sync now this value will always be "sw_sync". Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c| 11 +++ drivers/staging/android/sync.h | 2 -- drivers/staging/android/sync_debug.c | 2 +- 3 files changed, 4 i

[PATCH 15/18] staging/android: remove sync_timeline_destroy()

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan This function was just used by the file release function, so we just fold its content there and remove sync_timeline_destroy(). Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-)

[PATCH 14/18] staging/android: remove 'destroyed' member from struct sync_timeline

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan 'destroyed' was set but not used ny anyone. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c | 5 - drivers/staging/android/sync.h| 5 + 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/android/sw_sync.c b/driv

[PATCH 12/18] staging/android: make sync_timeline internal to sw_sync

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan The only use sync_timeline will have in upstream kernel is for debugging through the SW_SYNC interface. So make it internal to SW_SYNC to avoid people use it in the future. Signed-off-by: Gustavo Padovan --- drivers/staging/android/Kconfig | 16 +-- drivers/staging/

[PATCH 13/18] staging/android: make sw_ioctl info internal to sw_sync.c

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan We don't want to export this from the kernel. This is interface is only for testing and debug. So testers shall copy the ioctl info in their own projects. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c | 13 - drivers/staging/android

[PATCH 11/18] staging/android: clean up #includes in the sync framework

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan Most of the includes there are not necessary anymore. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 6 -- drivers/staging/android/sync.h | 3 --- drivers/staging/android/sync_debug.c | 16 3 files changed, 25 deleti

[PATCH 08/18] staging/android: remove size arg of sync_timeline_create()

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan After we removed sw_sync_timeline this arg has not been really used by anyone, all its users pass the size of struct sync_timeline there. So simplify this function but not requiring the size anymore. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c

[PATCH 10/18] staging/android: move sw_sync related code to sw_sync.c

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan Split sync_debug and sw_sync in two different files. Signed-off-by: Gustavo Padovan --- drivers/staging/android/Makefile | 1 + drivers/staging/android/sw_sync.c| 136 +++ drivers/staging/android/sync.h | 2 + drivers/stag

[PATCH 09/18] staging/android: bring struct sync_pt back

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan Move the list_head members from sync_pt to struct fence was a mistake, they will not be used by struct fence as planned before, so here we create sync_pt again to bring the list heads back. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 40 +

[PATCH 07/18] staging/android: remove unnecessary check for fence

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan When we call sync_print_fence() fence is always valid. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync_debug.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/sync_debug.c b/drivers/staging/android/sync_deb

[PATCH 03/18] staging/android: remove struct sync_timeline_ops

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan Move drv_name, the last field of sync_timeline_ops, to sync_timeline and remove sync_timeline_ops. struct sync_timeline_ops was just an extra abstraction on top of fence_ops, and in the last few commits we removed all it ops in favor of cleaner fence_ops. Signed-off-by: Gu

[PATCH 05/18] staging/android: remove sw_sync.[ch] files

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan We can glue the sw_sync file operations directly on the sync framework without the need to pass through sw_sync wrappers. It only builds sw_sync debugfs file support if CONFIG_SW_SYNC is enabled. Signed-off-by: Gustavo Padovan --- drivers/staging/android/Makefile |

[PATCH 06/18] staging/android: rename android_fence to timeline_fence

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan We are moving out of staging/android so rename it to a name that is not related to android anymore. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a

[PATCH 04/18] staging/android: remove sw_sync_timeline and sw_sync_pt

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan As we moved value storage to sync_timeline and fence those two structs became useless and can be removed now. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c| 24 +++- drivers/staging/android/sw_sync.h| 24 ++---

[PATCH 02/18] staging/android: remove .{fence, timeline}_value_str() from timeline_ops

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan Now that the value of fence and the timeline are not stored by sw_sync anymore we can remove this extra abstraction to retrieve this data. This patch changes both fence_ops (.fence_value_str and .timeline_value_str) to return the str directly. It also clean up struct sync_

[PATCH 00/18] staging/android: clean up SW_SYNC

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan Hi, The following patches do a clean up on the sw_sync inteface. It starts by removing struct sync_timeline_ops, which was creating unecessary wrappers in the code and the start to organize the sync_timeline and sw_sync code better. sw_sync interface was moved to sw_sync.c

[PATCH 01/18] staging/android: store last signaled value on sync timeline

2016-05-31 Thread Gustavo Padovan
From: Gustavo Padovan Now fence timeline is aware of the last signaled fence, as it receives the increment to the current value in sync_timeline_signal(). That allow us to remove .has_signaled() from timeline_ops as we can directly compare using timeline->value and fence->seqno in sync.c Signed

[PATCH] staging: iio: accel: remove impossible condition

2016-05-31 Thread Luis de Bethencourt
val is set to the value of ret right after ret is checked. If ret is not zero it goes to error_ret. So only value ret can have is zero, which makes the switch (val & 0x03) only match the case 0x00. Removing the switch and since val is only used for this, removing val as well. Signed-off-by: Luis d

RE: [PATCH 2/2] PCI: hv: handle all pending messages in hv_pci_onchannelcallback()

2016-05-31 Thread Jake Oshins
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Monday, May 30, 2016 7:18 AM > To: linux-...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; Bjorn > Helgaas ; Haiyang Zhang > ; KY Srinivasan ; Jake > Oshins > Subject: [PA

RE: [PATCH 1/2] PCI: hv: don't leak buffer in hv_pci_onchannelcallback()

2016-05-31 Thread Jake Oshins
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Monday, May 30, 2016 7:18 AM > To: linux-...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; Bjorn > Helgaas ; Haiyang Zhang > ; KY Srinivasan ; Jake > Oshins > Subject: [PA

Re: [PATCH v3] Drivers: hv: vmbus: fix the race when querying & updating the percpu list

2016-05-31 Thread Vitaly Kuznetsov
Dexuan Cui writes: > There is a rare race when we remove an entry from the global list > hv_context.percpu_list[cpu] in hv_process_channel_removal() -> > percpu_channel_deq() -> list_del(): at this time, if vmbus_on_event() -> > process_chn_event() -> pcpu_relid2channel() is trying to query the l

[PATCH] staging: gdm724x: gdm_usb: Remove ignored value

2016-05-31 Thread Luis de Bethencourt
The value assigned to ret will be overwritten before it could be read in a future iteration of the loop. Removing the unnecessary assignment. Signed-off-by: Luis de Bethencourt --- drivers/staging/gdm724x/gdm_usb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH 2/3] staging: octeon: check for pow0 before calling interface helper

2016-05-31 Thread Aaro Koskinen
Check for pow0 port first before calling the interface helper. This avoids the following error log when setting up pow0 interface: cvmx_helper_get_interface_num: Illegal IPD port number Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-util.h | 7 --- 1 file changed,

[PATCH 3/3] staging: octeon: delete redundant log message

2016-05-31 Thread Aaro Koskinen
There will be a separate banner message after pow0 is set up (or an error message if it failed). Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index 190a

[PATCH 1/3] staging: octeon: validate interface before calling INDEX

2016-05-31 Thread Aaro Koskinen
Some helper functions call INDEX before checking if the interface is valid. Since pow0 is not a real interface, we get the following errors: cvmx_helper_get_interface_index_num: Illegal IPD port number Fix by using INDEX only when needed with real interfaces. Signed-off-by: Aaro Koskinen

This is to notify you about your late Uncle......

2016-05-31 Thread Mr. Vitalis Ekeh..
This message is the last notification about USD6.2million bearing your name as Beneficiary, all effort to reach you have not be successful, please if you Receive this message kindly respond back stating your desire to make the claim. Mr.Vitalis Ekeh. __

[PATCH V2 18/31] staging: ks7010: indent ks_hostif.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 1960 1 file changed, 1080 insertions(+), 880 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 497b8aaf6daef8..f2

[PATCH V2 28/31] staging: ks7010: adapt to new trans_start handling

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang trans_start is gone from netdevice, so use the new helper function to set the mark. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/stagin

[PATCH V2 30/31] staging: ks7010: drop counting sd errors

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang They were counted but never really used anywhere. Also change the printk to a debug print, since it mostly shows on the expected -ENOMEDIUM on card removal. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 20 ++-- drivers/staging/ks7010

[PATCH V2 25/31] staging: ks7010: indent ks7010_sdio.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Unlike the previous patches which are plain indent outcomes, this has some manual fixups to be not overly strict with the 80 char limit. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 807 --- 1 file changed, 460 insert

[PATCH V2 29/31] staging: ks7010: simplify module_init/exit

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang The printouts are not needed, the driver core has enough debug output for this if wanted. So, use a helper to save boilerplate code. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 25 + 1 file changed, 1 insertion(+), 24 deleti

[PATCH V2 27/31] staging: ks7010: fix module annotations

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang List all authors, beautify description, match license to what is stated in file headers, add firmware information. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/stag

[PATCH V2 26/31] staging: ks7010: remove supported card table with one element

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang There is only this card supported, no need to iterate over the table. The resulting firmware filename wasn't used anyway, but came from the config file or hardcoded default. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 31 ++-

[PATCH V2 31/31] staging: ks7010: cleanup file headers

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Remove svn-ids and fix typos in the licence declaration. Add my copyright to the sdio code which I worked on mainly. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/eap_packet.h| 6 -- drivers/staging/ks7010/ks7010_sdio.c | 8 +++- drivers/staging/ks7010

[PATCH V2 16/31] staging: ks7010: indent ks7010_config.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 353 + 1 file changed, 184 insertions(+), 169 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_config.c b/drivers/staging/ks7010/ks7010_config.c index 48809bcc779

[PATCH V2 21/31] staging: ks7010: indent ks_wlan_ioctl.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_wlan_ioctl.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index e7469f7338f7af..cc4669eddcc1f7 100644

[PATCH V2 17/31] staging: ks7010: indent ks7010_sdio.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.h | 64 +--- 1 file changed, 30 insertions(+), 34 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 1d16673e5dae02..a

[PATCH V2 20/31] staging: ks7010: indent ks_wlan.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_wlan.h | 246 +++ 1 file changed, 121 insertions(+), 125 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 58e3a5a6b44472..f0f9f8ef

[PATCH V2 19/31] staging: ks7010: indent ks_hostif.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.h | 525 ++--- 1 file changed, 262 insertions(+), 263 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index c333ce1a4baa6e..01d

[PATCH V2 15/31] staging: ks7010: indent eap_packet.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/eap_packet.h | 49 ++--- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h index b664bdd8c961db..883

[PATCH V2 24/31] staging: ks7010: indent michael_mic.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/michael_mic.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.h b/drivers/staging/ks7010/michael_mic.h index f14f160ad46549..57ecbe34153202 100644 -

[PATCH V2 23/31] staging: ks7010: indent michael_mic.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/michael_mic.c | 43 ++-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c index ec8769a974427a..a

[PATCH V2 14/31] staging: ks7010: remove unecessary typedef

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Let's simply specify the struct to keep in sync with kernel coding style. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 4 +- drivers/staging/ks7010/ks7010_sdio.c | 44 - drivers/staging/ks7010/ks7010_sdio.h | 2 +- drivers/staging

[PATCH V2 04/31] staging: ks7010: remove checks for WIRELESS_EXT version

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang We are by far newer than that anyhow. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 23 --- drivers/staging/ks7010/ks_wlan_net.c | 14 -- 2 files changed, 37 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.

[PATCH V2 08/31] staging: ks7010: use kernel helper to print buffer

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang No need for an open coded one. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/Makefile | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 9 + drivers/staging/ks7010/ks_debug.c| 30 -- drivers/staging/ks7010/ks_debug.h|

[PATCH V2 10/31] staging: ks7010: really iterate over multicast addresses

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang The loop variable was defined but not really used. Fix this. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c inde

[PATCH V2 13/31] staging: ks7010: add example cfg file as a reference

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang We want to remove it, but to do so properly, it is good to have a working example. Needs to be copied to /lib/firmware in order to be used. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks79xx.cfg | 116 ++ 1 file changed, 116 ins

[PATCH V2 11/31] staging: ks7010: make loading config file optional

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang We have sane defaults, so we don't need to bail out if there is no config file. Note that the config file should go away completely in favour of configuration mechanisms already upstream. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 8 +++- 1

[PATCH V2 09/31] staging: ks7010: delete seperate debug header

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Move the one debug macro to the generic wlan header. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 1 - drivers/staging/ks7010/ks7010_sdio.c | 1 - drivers/staging/ks7010/ks_debug.h | 28 drivers/staging/ks7010

[PATCH V2 12/31] staging: ks7010: fix printk format warnings

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Use proper type for size_t. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_config.c b/drivers/staging/

[PATCH V2 07/31] staging: ks7010: use long preamble as default

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang I had a problem connecting to a network with a short preamble, so let's make the safer option the default. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks

  1   2   >