[PATCH 8/8] staging: unisys: visornic: change return statements

From: David Binder Changes return statements in visornic_rx() to use literals instead of a variable. Also changes function description to reflect the correct return type. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 16 +++

[PATCH 6/8] staging: unisys: visorchipset change -1 return value

From: Erik Arfvidson This patch changes the vague -1 return value to -EINVAL Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visor

[PATCH 7/8] staging: unisys: iovmcall_gnuc.h change -1 return values

From: Erik Arfvidson This patch changes the vague -1 return values to -EPERM. This operation is not supported is a good alternative to -1 because the return is basically telling the caller that the processor doesn't support vmcall operations. Signed-off-by: Erik Arfvidson Signed-off-by: David K

[PATCH 1/8] staging: unisys: visornic: remove extraneous error check

From: David Binder Removes an extraneous error check in devdata_initialize(), and updates the function comment accordingly. Signed-off-by: David Binder Reviewed-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 4 +--- 1 file changed, 1 insertio

[PATCH 3/8] staging: unisys: visorinput change -1 return value

From: Erik Arfvidson This patch changes the vague -1 return value to -EINVAL Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner --- drivers/staging/unisys/visorinput/visorinput.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorinput/vis

[PATCH 5/8] staging: unisys: visorbus change -1 return values

From: Erik Arfvidson This patch changes the vague -1 return values to -EFAULT since it would be the most appropriate, given that this error would only occur in an unexpected bad offset field. Resulting in a bad address. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner --- drivers/s

[PATCH 2/8] staging: unisys: visorhba: "Prefer 'unsigned int'" checkpatch warnings

From: Tim Sell This patch fixes a few checkpatch warnings in visorhba: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletio

[PATCH 0/8] staging: unisys: Additional cleanups

This series cleans up some negative 1 returns and other minor cleanups. David Binder (2): staging: unisys: visornic: remove extraneous error check staging: unisys: visornic: change return statements Erik Arfvidson (5): staging: unisys: visorinput change -1 return value staging: unisys: vi

[PATCH 4/8] staging: unisys: visorhba change -1 return value

From: Erik Arfvidson This patch changes the vague -1 return value to -EBUSY Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorhba/v

Re: [lustre-devel] [PATCH] staging: lustre: use setup_timer().

> Use setup_timer() for initializing the timer, instead of structure > assignments. > This is the preferred/standard way. > > Signed-off-by: Muhammad Falak R Wani Acked-by: James Simmons > --- > drivers/staging/lustre/lnet/lnet/net_fault.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deleti

Re: [PATCH] staging/rdma/hfi1: use RCU_INIT_POINTER() when NULLing.

On 05/01/2016 08:35 AM, Muhammad Falak R Wani wrote: > It is safe to use RCU_INIT_POINTER() to NULL a pointer, instead of > rcu_assign_pointer(). > This results in slightly smaller/faster code. > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/staging/rdma/hfi1/init.c | 2 +- > 1 file cha

Re: [PATCH] staging/lustre/ptlrpc: Removes potential null dereference

On May 12, 2016, at 6:33 PM, Lidza Louina wrote: > The lustre_msg_buf method could return NULL. Subsequent code didn't > check if it's null before using it. This patch adds two checks. Thank you for the patch, it looks good code-wise, but there are some style issues. > > Signed-off-by: Li

Re: staging: add Lustre file system client support

On Apr 27, 2016, at 8:28 AM, Dan Carpenter wrote: > Hello Lustre devs, > > The patch d7e09d0397e8: "staging: add Lustre file system client > support" from May 2, 2013, leads to the following Parfait warning. > Parfait is an Oracle static analysis tool. If there is a patch from > this could you

[PATCH v2] MAINTAINERS: add entry for the Sync File Framework

From: Gustavo Padovan Add Gustavo as maintainer for the Sync File Framework. Sumit is co-maintainer as he maintains drivers/dma-buf/. It also uses Sumit's tree as base. Signed-off-by: Gustavo Padovan Acked-by: Sumit Semwal Acked-by: Maarten Lankhorst --- MAINTAINERS | 11 +++ 1 file

Re: [PATCH 0/6] Intel Secure Guard Extensions

On May 13, 2016 2:42 AM, "Dr. Greg Wettstein" wrote: > > On Sun, May 08, 2016 at 06:32:10PM -0700, Andy Lutomirski wrote: > > Good morning, running behind on e-mail this week but wanted to get > some reflections out on Andy's well taken comments and concerns. > > > On May 8, 2016 2:59 AM, "Dr. Gre

[PATCH net-next v2 4/6] hv_netvsc: get rid of struct net_device pointer in struct netvsc_device

Simplify netvsvc pointer graph by getting rid of the redundant ndev pointer. We can always get a pointer to struct net_device from somewhere else. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/hyperv_net.h | 5 +-- drivers/net/hyperv/netvsc.c | 36 +++- drivers/net/

[PATCH net-next v2 6/6] hv_netvsc: set nvdev link after populating chn_table

Crash in netvsc_send() is observed when netvsc device is re-created on mtu change/set channels. The crash is caused by dereferencing of NULL channel pointer which comes from chn_table. The root cause is a mixture of two facts: - we set nvdev pointer in net_device_context in alloc_net_device() bef

[PATCH net-next v2 5/6] hv_netvsc: synchronize netvsc_change_mtu()/netvsc_set_channels() with netvsc_remove()

When netvsc device is removed during mtu change or channels setup we get into troubles as both paths are trying to remove the device. Synchronize them with start_remove flag and rtnl lock. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/netvsc_drv.c | 9 +++-- 1 file changed, 7 insert

[PATCH net-next v2 3/6] hv_netvsc: untangle the pointer mess

We have the following structures keeping netvsc adapter state: - struct net_device - struct net_device_context - struct netvsc_device - struct rndis_device - struct hv_device and there are pointers/dependencies between them: - struct net_device_context is contained in struct net_device - struct hv_

[PATCH net-next v2 1/6] hv_netvsc: move start_remove flag to net_device_context

struct netvsc_device is destroyed on mtu change so keeping the protection flag there is not a good idea. Move it to struct net_device_context which is preserved. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/hyperv_net.h | 4 +++- drivers/net/hyperv/netvsc.c | 3 +-- drivers/net/h

[PATCH net-next v2 0/6] hv_netvsc: avoid races on mtu change/set channels

Changes since v1: - Rebased to net-next [Haiyang Zhang] Original description: MTU change and set channels operations are implemented as netvsc device re-creation destroying internal structures (struct net_device stays). This is really unfortunate but there is no support from Hyper-V host to do it

[PATCH net-next v2 2/6] hv_netvsc: use start_remove flag to protect netvsc_link_change()

netvsc_link_change() can race with netvsc_change_mtu() or netvsc_set_channels() as these functions destroy struct netvsc_device and rndis filter. Use start_remove flag for syncronization. As netvsc_change_mtu()/netvsc_set_channels() are called with rtnl lock held we need to take it before checking

[PATCH] staging: dgnc: re-arrange functions for removing forward

Re-arrange the functions for removing forward declarations in dgnc_cls.c file. Signed-off-by: Daeseok Youn --- After applying this patch, the object file size was NOT changed. drivers/staging/dgnc/dgnc_cls.c | 949 +++- 1 file changed, 460 insertions(+), 489

Re: [PATCH 0/6] Intel Secure Guard Extensions

On Sun, May 08, 2016 at 06:32:10PM -0700, Andy Lutomirski wrote: Good morning, running behind on e-mail this week but wanted to get some reflections out on Andy's well taken comments and concerns. > On May 8, 2016 2:59 AM, "Dr. Greg Wettstein" wrote: > > > > > > This now means the security of SG