From: Gustavo Padovan
sync_file is useful to connect one or more fences to the file. The file is
used by userspace to track fences.
Signed-off-by: Gustavo Padovan
---
drivers/Kconfig| 2 +
drivers/dma-buf/Kconfig| 11 +
drivers
Use some local variables to clarify this function.
This (*insn_bits) function is a bit different from most comedi drivers.
Add some comments to clarify why the shifts are used.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c
Rename this function to help shorten some of the long lines.
Remove the inline, let the compiler figure it out.
Change the 'unsigned' parameters to 'unsigned int' to fix the
checkpatch.pl issues:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: H Hartley Sweeten
Cc: Ian
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, March 18, 2016 5:33 AM
> To: de...@linuxdriverproject.org
> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ;
> Haiyang Zhang ; Alex Ng (LIS)
> ; Radim Krcmar ; Cathy
> Avery
> Subject: [PATCH] Dri
On Sat, Mar 12, 2016 at 02:11:10PM +0530, PrasannaKumar Muralidharan wrote:
> From: PrasannaKumar Muralidharan
>
> Remove unnecessary use of volatile for 'request_counter' and
> 'service_counter' members.
>
> Signed-off-by: PrasannaKumar Muralidharan
> ---
> drivers/staging/most/hdm-dim2/dim2_
Removed copyright notice as per checkpatch check warning.
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/drv_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers/staging/rtl8712/drv_types.h
index 29e47e1..ae79047 100644
--- a/drive
Smatch reports the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:1960
rtl8812ae_dm_txpower_tracking_callback_thermalmeter() warn: inconsistent
indenting
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8821ae/trx.c
d
On Sun, 2016-03-20 at 07:48 +0530, Parth Sane wrote:
> Hi,
> Thanks for pointing out that the changes have been done. Nevertheless
> this was a good learning exercise. How do I check which changes have
> already been done?
Use this tree:
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next
Hi,
Thanks for pointing out that the changes have been done. Nevertheless this was
a good learning exercise. How do I check which changes have already been done?
I’m planning to send in another patch on a blank line warning on the same file.
I don’t want to overburden the mailing list by repeati
Fixed checkpatch warnings about parenthesis alignment at line #186.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
in
Fixed alignment of parenthesis checkpatch warning to fit coding standards.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_
On Thursday 17 March 2016 10:10:40 H Hartley Sweeten wrote:
> Arnd Bergmann pointed out that gcc-6 warns about passing negative signed
> integer into swab16() due to the macro expansion of 'outw'.
>
> It appears that the register map constants are causing the warnings.
> Actually, it might just be
On Sun, 2016-03-20 at 01:42 +, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.
The subject prefix [PATCH] should be numbered
with the revision like [PATCH v2]
> Please ignore earlier sent patch for paranthesis check and use this one.
This bit of your email should go be
Fixed alignment of paranthesis as per checkpatch. Please ignore earlier sent
patch for paranthesis check and use this one.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/pla
On Fri, Mar 18, 2016 at 01:41:19PM +0100, Geert Uytterhoeven wrote:
> > @@ -249,11 +246,7 @@ aim_read(struct file *filp, char __user *buf, size_t
> > count, loff_t *offset)
> > struct aim_channel *c = filp->private_data;
> >
> > mutex_lock(&c->io_mutex);
> > - if (c->stacked_
On 03/18/2016 07:05 AM, Mauro Carvalho Chehab wrote:
> Now that media_device_unregister() also does a cleanup, rename it
> to media_device_unregister_cleanup().
>
> Signed-off-by: Mauro Carvalho Chehab
I think adding cleanup is redundant. media_device_unregister()
would imply that there has to b
Hello Peng Tao,
The patch d7e09d0397e8: "staging: add Lustre file system client
support" from May 2, 2013, leads to the following static checker
warning:
drivers/staging/lustre/lustre/obdecho/echo_client.c:1040
cl_echo_enqueue0()
error: 'lck' dereferencing possible ERR_PTR()
dri
staging: rtl8192e - dot11d.c
[patch 1/2] Fixed throughout:
spaces preferred around that '+' (ctx:VxV)
[patch 2/2] Fixed throughout:
Please don't use multiple blank lines
Signed-off-by: Yousof El-Sayed
---
drivers/staging/rtl8192e/dot11d.c | 14 ++
1 file changed, 6 insertions(+), 8
On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote:
> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote:
>
> Is this a gcc-6 specific issue? Seems line this warning should be showing
> up in a lot of drivers.
Yes, I did not see this before moving to gcc-6.0, but this is the only dri
On 2016/03/18, 13:28, "lustre-devel on behalf of Dilger, Andreas"
wrote:
>On 2016/03/17, 23:42, "Dan Carpenter" wrote:
>
>>lustre_cfg_new() returns error pointers on error, it never returns NULL.
Hmm, looking at the broader context, I see there are other callers of
lustre_cfg_new() that are che
This BUG_ON() happens if a mite DMA channel is already requested when an
ansynchronous command is started for one of the counter subdevices.
The comedi core will only call the (*do_cmd) if the subdevice is not busy.
In this driver, the (*cancel) for the subdevice will always release any
requested
2016-03-18 16:53+0100, Vitaly Kuznetsov:
> Radim Krcmar writes:
>> 2016-03-18 13:33+0100, Vitaly Kuznetsov:
>>> @@ -530,9 +542,17 @@ static void vmbus_wait_for_unload(void)
>>
>> (I'm not a huge fan of the unloaded variable; what about remembering the
>> header/msgtype here ...
>>
>>>
From: Gustavo Padovan
This function had copies in 3 different files. Unify them in kernel.h.
Cc: Andrew Morton
Cc: David Airlie
Cc: Daniel Vetter
Cc: Rob Clark
Signed-off-by: Gustavo Padovan
---
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 5 -
drivers/gpu/drm/i915/i915_drv.h
On Thu, Mar 17, 2016 at 04:55:37PM +, Yousof El-Sayed wrote:
> Signed-off-by: Yousof El-Sayed
I can't take patches without any changelog entry, sorry.
And be specific about what and why you are changing anything, "coding
style issues" is very vague.
thanks,
greg k-h
___
On Thu, Mar 17, 2016 at 10:19:04PM -0700, Linus Torvalds wrote:
> On Thu, Mar 17, 2016 at 8:25 PM, Greg KH wrote:
> > Ok, the diffstat below seems "odd" in that I had done a merge with my
> > char-misc tree to resolve some merge issues a while ago, and that tree
> > is now in your tree, so the dif
Convert this big switch into an array and refactor ni_660x_gpct_{write,read}()
functions to use the array to find the register offset.
All the TIO (GPCT) registers are included in the array except for NITIO_G0_ABZ
and NITIO_G1_ABZ. These registers only exist on the ni_pcimio m-series boards
and th
Remove the enums global_interrupt_{status,config}_register_bits and
add defines for the CamelCase values.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 27 ++-
1 file changed, 10 insertions(+), 17 d
>A patch intended to add a dependency on LNET for lustre didn't
>actually do that and instead allowed configurations that contain
>lustre with lnet but without IPv4 support that subsequently
>fail to link:
>
>warning: (LUSTRE_FS) selects LNET which has unmet direct dependencies (STAGING
>&& INET &
This member of the struct is not used, and just takes up space. Remove it.
Instead, add the enum ni_660x_register indexes to the table to clarify, and
document, the entries.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 19
lustre_cfg_new() returns error pointers on error, it never returns NULL.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c
b/drivers/staging/lustre/lustre/mgc/mgc_request.c
index 65caffe..b7dc872 100644
--- a/drivers/staging/lustre/lustre/mgc/mgc_request.
Reformat the multi-line comment in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/comedi/
On Thu, Mar 17, 2016 at 8:25 PM, Greg KH wrote:
> Ok, the diffstat below seems "odd" in that I had done a merge with my
> char-misc tree to resolve some merge issues a while ago, and that tree
> is now in your tree, so the diffstat shouldn't be showing it (I updated
> my master branch), but someho
> -Original Message-
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Sent: Wednesday, March 16, 2016 4:41 PM
> To: KY Srinivasan ; Martin K. Petersen
>
> Cc: Christoph Hellwig ; gre...@linuxfoundation.org;
> linux-ker...@vger.kernel.org; de...@linuxdriverproject.
Jandy Gou writes:
> make C=1 M=drivers/staging/rtl8723au/
>
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
> restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
> restricted __le32
>
> Signed-off-by: Jandy Gou
> ---
> drivers/staging/
On Fri, 2016-03-18 at 17:48 +, Yousof El-Sayed wrote:
> This is a patch to the rtllib_softmac.c file that fixes up all instances of
> the 'line over 80 characters' warnings found by the checkpatch.pl tool.
[]
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
> b/drivers/staging/rtl8192
> "KY" == KY Srinivasan writes:
KY> How would I get the sysfs files under fc_host if I don't use the FC
KY> transport. The customer scripts expect these sysfs files.
Right, but I was interested in finding out why they need those
files. And whether an alternative to the FC transport would be
Fixed block comment checkpatch warnings.
Signed-off-by: Gavin O'Leary
---
drivers/staging/unisys/visornic/visornic_main.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/visornic_ma
On Fri, Mar 18, 2016 at 6:42 AM, Linux Kernel Mailing List
wrote:
> Web:
> https://git.kernel.org/torvalds/c/f45b0fba43f415f69982df743dfa9b5d1b57785e
> Commit: f45b0fba43f415f69982df743dfa9b5d1b57785e
> Parent: b3c9f3c56c41cbebe7804b48ba8e6e484509c2c0
> Refname:refs/heads/maste
This is a patch to the rtllib_softmac.c file that fixes up all instances of
the 'line over 80 characters' warnings found by the checkpatch.pl tool.
Signed-off-by: Yousof El-Sayed
---
drivers/staging/rtl8192e/rtllib_softmac.c | 35 +++
1 file changed, 22 insertions(+)
Use the comedi.h provided constants (enum ni_660x_pfi_routing) instead
of defining new ones for the output sources.
Use a switch to clarify the channel/source validation.
For aesthetics, rename the private data members 'pfi_output_selects' and
'pfi_direction_bits'.
Remove the 'min_counter_pfi_ch
On Sat, 2016-03-19 at 18:35 +, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.
Please run your proposed patches through checkpatch.
> diff --git a/drivers/staging/netlogic/platform_net.c
> b/drivers/staging/netlogic/platform_net.c
[]
> @@ -121,9 +121,7 @@ static struct p
2016-03-18 13:33+0100, Vitaly Kuznetsov:
> Kdump keeps biting. Turns out CHANNELMSG_UNLOAD_RESPONSE is always
> delivered to CPU0 regardless of what CPU we're sending CHANNELMSG_UNLOAD
> from. vmbus_wait_for_unload() doesn't account for the fact that in case
> we're crashing on some other CPU and C
Fix the checkpatch.pl issues about:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 17 +++--
1 file
Rename these functions so they have namespace associated with the
driver.
Fix the checkpatch.pl issues:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 16 +++---
Change the generic MODULE_DESCRIPTION text to something more useful.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c
On Mon, Mar 14, 2016 at 03:55:14AM +0200, Andrey Utkin wrote:
> From: Andrey Utkin
>
> Support for boards based on Techwell TW5864 chip which provides
> multichannel video & audio grabbing and encoding (H.264, MJPEG,
> ADPCM G.726).
>
> Signed-off-by: Andrey Utkin
> Tested-by: Andrey Utkin
> -
Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
with devm_request_irq") introduced the following static checker
warning:
drivers/staging/most/hdm-dim2/dim2_hdm.c:841 dim2_probe()
error: 'dev->netinfo_task' dereferencing possible ERR_PTR()
Remove the bug introduced by the commit
Fixed alignment of paranthesis as per checkpatch.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
index daee1b2..82af02
From: Ubuntu
Fixed alignment of paranthesis as per checkpatch.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
index
On Wed, 2016-03-16 at 18:34 -0400, Martin K. Petersen wrote:
> > > > > > "KY" == KY Srinivasan writes:
>
> KY> How would I get the sysfs files under fc_host if I don't use the
> FC
> KY> transport. The customer scripts expect these sysfs files.
>
> Right, but I was interested in finding out why
Em Wed, 16 Mar 2016 10:28:35 +0200
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Tue, Mar 15, 2016 at 12:55:35PM -0300, Mauro Carvalho Chehab wrote:
> > Em Mon, 14 Mar 2016 14:09:09 +0200
> > Sakari Ailus escreveu:
> >
> > > Hi Mauro,
> > >
...
> > > Notify callbacks, perhaps not, but the lis
From: Gustavo Padovan
This function had copies in 3 different files. Unify them in kernel.h.
Cc: Joe Perches
Cc: Andrew Morton
Cc: David Airlie
Cc: Daniel Vetter
Cc: Rob Clark
Signed-off-by: Gustavo Padovan
---
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 11 +++
drivers/gpu/drm
Remove the extra for loop and just initialize the counter as the subdevices
are created.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/
On Fri, Mar 18, 2016 at 05:38:45PM +, Hartley Sweeten wrote:
> On Wednesday, March 16, 2016 3:22 AM, Ian Abbott wrote:
> > On 15/03/16 21:48, H Hartley Sweeten wrote:
> >> Memory mapped io (dev->mmio) should not also be writing to the ioport
> >> (dev->iobase) registers. Add the missing 'else'
On Thursday, March 17, 2016 9:09 AM, Arnd Bergmann wrote:
> On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote:
>> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote:
>>
>> Is this a gcc-6 specific issue? Seems line this warning should be showing
>> up in a lot of drivers.
>
> Yes, I
From: Gustavo Padovan
Change SYNC_IOC_FILE_INFO (former SYNC_IOC_FENCE_INFO) behaviour to avoid
future API breaks and optimize buffer allocation.
Now num_fences can be filled by the caller to inform how many fences it
wants to retrieve from the kernel. If the num_fences passed is greater
than ze
From: Gustavo Padovan
struct sync_merge_data already have documentation on top of the
struct definition. No need to duplicate it.
Signed-off-by: Gustavo Padovan
Reviewed-by: Maarten Lankhorst
---
drivers/staging/android/uapi/sync.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Smatch lists the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c:371
rtl92ee_rx_query_desc() warn: inconsistent indenting
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 2 +-
For aesthetics, add some whitespace to the subdevice init and use
a couple local variables to make the code easier to follow.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 59 +---
1 file change
Hi,
Thanks for getting back to me Greg! I’m still learning, so thanks again for
bearing with me!
Regards,
Parth Sane
> On 19-Mar-2016, at 10:43 PM, Greg KH wrote:
>
> On Sat, Mar 19, 2016 at 10:04:23PM +0530, Parth Sane wrote:
>> Hi,
>> I haven’t received any feedback as to whether my patch has
On Sat, Mar 19, 2016 at 10:04:23PM +0530, Parth Sane wrote:
> Hi,
> I haven’t received any feedback as to whether my patch has been accepted.
> Would request someone to kindly help me out. Maybe you could weigh in here
> Greg?
> Regards,
> Parth Sane
> > On 15-Mar-2016, at 10:16 PM, laerdevstud..
Hi Roger,
Can I submit more patches similarly until this has been accepted? I’ll be sure
to remove the from part in my next patch(I hope I don’t have to submit the
earlier patch again).Thanks for your wise comments!
Regards,
Parth Sane
> On 19-Mar-2016, at 10:33 PM, Roger H Newell wrote:
>
> On
On Sat, Mar 19, 2016 at 2:04 PM, Parth Sane wrote:
> Hi,
> I haven’t received any feedback as to whether my patch has been accepted.
> Would request someone to kindly help me out. Maybe you could weigh in here
> Greg?
> Regards,
> Parth Sane
>> On 15-Mar-2016, at 10:16 PM, laerdevstud...@gmail.c
Hi,
I haven’t received any feedback as to whether my patch has been accepted. Would
request someone to kindly help me out. Maybe you could weigh in here Greg?
Regards,
Parth Sane
> On 15-Mar-2016, at 10:16 PM, laerdevstud...@gmail.com wrote:
>
> From: Parth Sane
>
> Fixed multiple assignment ch
The ni_gpct_device_construct() could fail allocating the memory for
device and its counters. For aesthetics, call the function before
initializing the subdevices.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 20 ++
Rename this CamelCase struct and the associated 'registerData' variable.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/d
Rename this function to help shorten some of the long lines.
Remove the inline, let the compiler figure it out.
Change the 'unsigned' parameters to 'unsigned int' to fix the
checkpatch.pl issues:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: H Hartley Sweeten
Cc: Ian
On Fri, Mar 18, 2016 at 06:32:15PM +0530, Amitoj Kaur Chawla wrote:
> Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
> with devm_request_irq") introduced the following static checker
> warning:
> drivers/staging/most/hdm-dim2/dim2_hdm.c:841 dim2_probe()
> error: 'dev->netinfo_ta
Made comments not break coding style guidlines and easier to read.
Signed-off-by: Gavin O'Leary
---
drivers/staging/unisys/visornic/visornic_main.c | 29 +++--
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/d
Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
with devm_request_irq") introduced the following static checker
warning:
drivers/staging/most/hdm-dim2/dim2_hdm.c:841 dim2_probe()
error: 'dev->netinfo_task' dereferencing possible ERR_PTR()
Remove the warning by returning PTR_ERR
People should not waste time and energy working on this staging driver.
A replacement(rtl8xxxu) using the kernel wireless stack already was merged
in the 4.3 kernel.
Cc: Jes Sorensen
Cc: Larry Finger
Cc: Kalle Valo
Cc: Greg Kroah-Hartman
Cc: Linux Driver Project Developer List
Cc: Linux Wirel
2016-03-17 Joe Perches :
> On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> > This function had copies in 3 different files. Unify them in
> > kernel.h.
>
> This is only used by gpu/drm.
>
> I think this is a poor name for a generic function
> that would be in kernel.h.
>
> Isn't the
Hello Mauro,
On 03/18/2016 10:05 AM, Mauro Carvalho Chehab wrote:
> Now that media_device_unregister() also does a cleanup, rename it
> to media_device_unregister_cleanup().
>
I believe there should be a Suggested-by Sakari Ailus tag here.
> Signed-off-by: Mauro Carvalho Chehab
The patch look
All the registers are defined struct NI_660xRegisterData and they are
either 2 or 4 bytes in size. Remove the enum and just use a char member
to define the size as 2 or 4 bytes.
Simplify the ni_660x_{write,read}_register() functions and remove the
unnecessary BUG() in each.
Signed-off-by: H Hartl
For aesthetics, move the initialization of the default routing for the
DIO channels so it happens when the subdevice is initialized.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 27 +--
1 file chan
This patch corrects checks generated by checkpatch.pl by
replacing comparison to null statements with equivalent
statements in the form "x" or "!x"
Signed-off-by: Roger H. Newell
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_wlan_cfg.c | 4 ++--
2 files cha
This patch corrects warnings generated by checkpatch.pl by
removing braces from single block statements.
Signed-ff-by: Roger H. Newell
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 31 +--
drivers/staging/wilc1000/wilc_wlan_cfg.c | 3 +--
2 files changed,
On Wed, Mar 16, 2016 at 08:00:45PM -0700, Gavin O'Leary wrote:
> Made comments not break coding style guidlines and easier to read.
>
> Signed-off-by: Gavin O'Leary
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 29
> +++--
> 1 file changed, 17 insertions(+), 12 d
On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> This function had copies in 3 different files. Unify them in
> kernel.h.
This is only used by gpu/drm.
I think this is a poor name for a generic function
that would be in kernel.h.
Isn't there an include file in linux/drm that's
appropr
On 16/03/16 20:51, Arnd Bergmann wrote:
gcc-6 warns about passing negative signed integer into swab16()
in the dt282x driver:
drivers/staging/comedi/drivers/dt282x.c: In function 'dt282x_load_changain':
include/uapi/linux/swab.h:14:33: warning: integer overflow in expression
[-Woverflow]
(((
Em Fri, 18 Mar 2016 16:20:19 +0200
Sakari Ailus escreveu:
> Shuah Khan wrote:
> > On 03/18/2016 08:12 AM, Javier Martinez Canillas wrote:
> >> Hello Shuah,
> >>
> >> On 03/18/2016 11:01 AM, Shuah Khan wrote:
> >>> On 03/18/2016 07:05 AM, Mauro Carvalho Chehab wrote:
> Now that media_de
Remove this enum and add a define for the bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c
b/drivers/st
Now that media_device_unregister() also does a cleanup, rename it
to media_device_unregister_cleanup().
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/common/siano/smsdvb-main.c | 2 +-
drivers/media/media-device.c | 4 ++--
drivers/media/pci/saa7134/s
On Thu, Mar 17, 2016 at 01:41:02PM -0500, Larry Finger wrote:
> Smatch reports the following:
>
> CHECK drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c:137
> rtl8723e_dm_bt_need_to_dec_bt_pwr() warn: inconsistent indenting
>
make C=1 M=drivers/staging/rtl8723au/
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
restricted __le32
Signed-off-by: Jandy Gou
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 4 ++--
Convert the inline functions used to set the bits in the NI600X_IO_CFG
registers into macros. Also convert the enum ni_660x_pfi_output_select
into defines. This clarifies the association with the register.
This also fixes a number of checkpatch.pl issues about:
WARNING: Prefer 'unsigned int' to b
On Thu, 2016-03-17 at 16:33 -0400, Rob Clark wrote:
> On Thu, Mar 17, 2016 at 4:22 PM, Joe Perches wrote:
> > On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote:
> > > 2016-03-17 Gustavo Padovan :
> > > > 2016-03-17 Joe Perches :
> > > > > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan w
Remove the unnecessary NULL pointer check.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c
b/drivers/staging/comed
Smatch reports the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c:1140
rtl88e_dm_check_txpower_tracking() warn: inconsistent indenting
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c
drivers/net/wireless/
On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote:
>
> gcc-6 warns about passing negative signed integer into swab16()
> in the dt282x driver:
>
> drivers/staging/comedi/drivers/dt282x.c: In function 'dt282x_load_changain':
> include/uapi/linux/swab.h:14:33: warning: integer overflow in exp
Xose Vazquez Perez writes:
> People should not waste time and energy working on this staging driver.
> A replacement(rtl8xxxu) using the kernel wireless stack already was merged
> in the 4.3 kernel.
>
> Cc: Jes Sorensen
> Cc: Larry Finger
> Cc: Kalle Valo
> Cc: Greg Kroah-Hartman
> Cc: Linux D
On Fri, 2016-03-18 at 10:27 -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> This function had copies in 3 different files. Unify them in
> kernel.h.
This function might be used more in drm files
in a separate patch too:
$ git grep -n -E "__user.*\(\s*uintptr_t\s*\)" drivers/gpu/drm
dr
On 03/18/2016 08:12 AM, Javier Martinez Canillas wrote:
> Hello Shuah,
>
> On 03/18/2016 11:01 AM, Shuah Khan wrote:
>> On 03/18/2016 07:05 AM, Mauro Carvalho Chehab wrote:
>>> Now that media_device_unregister() also does a cleanup, rename it
>>> to media_device_unregister_cleanup().
>>>
>>> Signe
On 17/03/16 17:10, H Hartley Sweeten wrote:
Arnd Bergmann pointed out that gcc-6 warns about passing negative signed
integer into swab16() due to the macro expansion of 'outw'.
It appears that the register map constants are causing the warnings.
Actually, it might just be the (1 << 15) ones...
2016-03-17 Gustavo Padovan :
> 2016-03-17 Joe Perches :
>
> > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> > > This function had copies in 3 different files. Unify them in
> > > kernel.h.
> >
> > This is only used by gpu/drm.
> >
> > I think this is a poor name for a generic func
Made comments not break coding style guidlines and easier to read.
Signed-off-by: Gavin O'Leary
---
drivers/staging/unisys/visornic/visornic_main.c | 29 +++--
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/d
Signed-off-by: Yousof El-Sayed
---
drivers/staging/rtl8192e/dot11d.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c
b/drivers/staging/rtl8192e/dot11d.c
index 4d8fb41..a08bfef 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++
On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote:
> 2016-03-17 Gustavo Padovan :
> > 2016-03-17 Joe Perches :
> > > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> > > >
> > > > This function had copies in 3 different files. Unify them in
> > > > kernel.h.
> > > This is only us
Julian Calaby writes:
> Hi Jandy,
>
> On Thu, Mar 17, 2016 at 7:03 PM, Jandy Gou
> wrote:
>> make C=1 M=drivers/staging/rtl8723au/
>>
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
>> restricted __le16
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast
Fixed the coding style checkpatch warnings.
Signed-off-by: Gavin O'Leary
---
drivers/staging/unisys/visornic/visornic_main.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/vi
1 - 100 of 136 matches
Mail list logo
