[PATCH 2/2] Staging: nvec: fix multiline comment style.

This is a patch in nvec.c file that fixes a multiline comment found by checkpatch.pl tool Signed-off-by: Neha Rani --- drivers/staging/nvec/nvec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 4ae44a5..5

[PATCH] Staging: vt6655: fixed Warnings of more than 80 chars at a line in baseband.c

This is a patch to the baseband.c file that fixes the warnings of more than 80 characters at a line by the checkpatch.pl tool Signed-off-by: Nancy Goel --- drivers/staging/vt6655/baseband.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6

[PATCH 5/5] Staging: comedi: fix type issue in ni_tio.c

This is a patch to the ni_tio.c file that fixes up a type issues found by the checkpatch.pl tool. i.e. Prefer kernel type 'u64' over 'uint64_t' Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/ni_tio.c | 8 1 file changed, 4 insertions(+), 4 deletion

[PATCH 4/5] Staging: comedi: fix CHECK issue in ni_tio.c

This is a patch to the ni_tio.c file that fixes up a CHECK issues found by the checkpatch.pl tool. i.e. Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON(). Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/ni_tio.c | 1

[PATCH 2/5] Staging: comedi: fix WARNING issue in s626.c

This is a patch to the s626.c file that fixes up a Block comments issues found by the checkpatch.pl tool. i.e. Block comments use a trailing */ on a separate line Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/s626.c | 38 ++---

[PATCH 3/5] Staging: comedi: fix WARNING issue in s626.c

This is a patch to the s626.c file that fixes up a line over 80 characters issues found by the checkpatch.pl tool. Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/s626.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/c

[PATCH 1/5] Staging: comedi: fix type issue in s626.c

This is a patch to the s626.c file that fixes up a type issues found by the checkpatch.pl tool. i.e Prefer kernel type 'u8' over 'uint8_t' Prefer kernel type 'u16' over 'uint16_t' Prefer kernel type 'u32' over 'uint32_t' Prefer kernel type 's16' over 'int16_t' Prefer kernel type 's

RE: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Vladimir & Julian The driver is still moving to the Linux driver and also its being changed. Your patch is everything's ok. I also agree to Julian review.  Thanks, BR  Leo -Original Message- From: Vladimir Zapolskiy [mailto:v...@mleia.com] Sent: Thursday, March 10, 2016 9:36 AM To: J

Re: [PATCH 1/2] Staging: atm: fix 'endianess' spelling to 'endianness' in fore200e.c This is a patch to the fore200e that fixes the spelling of 'endianess' to the correct one, that is, 'endianness' fo

On Thu, Mar 10, 2016 at 11:00 AM, rneha725 wrote: > Signed-off-by: Neha Rani > --- Hi Neha, You should ideally submit patches for drivers/staging/ as a newbie and not other drivers. Other than that, Your subject is too long and you haven't written a commit message, A better way to write the su

[PATCH 1/2] Staging: atm: fix 'endianess' spelling to 'endianness' in fore200e.c This is a patch to the fore200e that fixes the spelling of 'endianess' to the correct one, that is, 'endianness' found

Signed-off-by: Neha Rani --- drivers/atm/fore200e.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c index 75dde90..fac5e4fd 100644 --- a/drivers/atm/fore200e.c +++ b/drivers/atm/fore200e.c @@ -409,7 +409,7 @@ fore200e_shutd

[PATCH 2/2] Staging: nvec: fix multiline comment style. This is a patch in nvec.c file that fixes a multiline comment found by checkpatch.pl tool

Signed-off-by: Neha Rani --- drivers/staging/nvec/nvec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 4ae44a5..57ad27a 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -508,8

[RESEND PATCH v3] staging/android/ion : fix a race condition in the ion driver

There is a use-after-free problem in the ion driver. This is caused by a race condition in the ion_ioctl() function. A handle has ref count of 1 and two tasks on different cpus calls ION_IOC_FREE simultaneously. cpu 0 cpu 1 --

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Julian, On 10.03.2016 02:24, Julian Calaby wrote: > Hi Vladimir, > > On Thu, Mar 10, 2016 at 11:02 AM, Vladimir Zapolskiy wrote: >> Hi Julian, >> >> On 10.03.2016 01:42, Julian Calaby wrote: >>> Hi Vladimir, >>> >>> On Thu, Mar 10, 2016 at 10:30 AM, Vladimir Zapolskiy wrote: Hi Julian,

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Vladimir, On Thu, Mar 10, 2016 at 11:02 AM, Vladimir Zapolskiy wrote: > Hi Julian, > > On 10.03.2016 01:42, Julian Calaby wrote: >> Hi Vladimir, >> >> On Thu, Mar 10, 2016 at 10:30 AM, Vladimir Zapolskiy wrote: >>> Hi Julian, >>> >>> On 10.03.2016 01:27, Julian Calaby wrote: Hi Vladimir,

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Julian, On 10.03.2016 01:42, Julian Calaby wrote: > Hi Vladimir, > > On Thu, Mar 10, 2016 at 10:30 AM, Vladimir Zapolskiy wrote: >> Hi Julian, >> >> On 10.03.2016 01:27, Julian Calaby wrote: >>> Hi Vladimir, >>> >>> On Thu, Mar 10, 2016 at 10:13 AM, Vladimir Zapolskiy wrote: The kthread

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Vladimir, On Thu, Mar 10, 2016 at 10:30 AM, Vladimir Zapolskiy wrote: > Hi Julian, > > On 10.03.2016 01:27, Julian Calaby wrote: >> Hi Vladimir, >> >> On Thu, Mar 10, 2016 at 10:13 AM, Vladimir Zapolskiy wrote: >>> The kthread_run() function returns either a valid task_struct or >>> ERR_PTR()

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Julian, On 10.03.2016 01:27, Julian Calaby wrote: > Hi Vladimir, > > On Thu, Mar 10, 2016 at 10:13 AM, Vladimir Zapolskiy wrote: >> The kthread_run() function returns either a valid task_struct or >> ERR_PTR() value, check for NULL is invalid. The change fixes potential >> oops, e.g. in OOM s

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Vladimir, On Thu, Mar 10, 2016 at 10:13 AM, Vladimir Zapolskiy wrote: > The kthread_run() function returns either a valid task_struct or > ERR_PTR() value, check for NULL is invalid. The change fixes potential > oops, e.g. in OOM situation. > > Signed-off-by: Vladimir Zapolskiy > --- > drive

[PATCH] staging: wilc1000: fix check of kthread_run() return value

The kthread_run() function returns either a valid task_struct or ERR_PTR() value, check for NULL is invalid. The change fixes potential oops, e.g. in OOM situation. Signed-off-by: Vladimir Zapolskiy --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

Am 07.03.2016 um 09:48 schrieb Paul Bolle: > On za, 2016-03-05 at 14:08 +0100, Tilman Schmidt wrote: >> As a consequence, owners of HiSAX type adapters are in fact stuck with >> the old hisax driver if they want to continue using i4l userspace >> tools. > > Do you know whether or not mISDN tools o

[PATCH] staging: rtl8712: added few code enhancements in rtl8712_led.c

This patch tries to improve a part of the code from rtl8712_led.c by removing duplicates condition checks. Signed-off-by: Claudiu Beznea --- drivers/staging/rtl8712/rtl8712_led.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging

Re: [RFC PATCH 1/2] iio: core: implement iio_{claim|release}_direct_mode()

On 09/03/16 20:06, Alison Schofield wrote: > On Sat, Mar 05, 2016 at 06:02:36PM +, Jonathan Cameron wrote: >> On 02/03/16 13:28, Lars-Peter Clausen wrote: >>> On 03/01/2016 08:02 PM, Alison Schofield wrote: It is often the case that the driver wants to be sure a device stays in direct

Re: [RFC PATCH 1/2] iio: core: implement iio_{claim|release}_direct_mode()

On Sat, Mar 05, 2016 at 06:02:36PM +, Jonathan Cameron wrote: > On 02/03/16 13:28, Lars-Peter Clausen wrote: > > On 03/01/2016 08:02 PM, Alison Schofield wrote: > >> It is often the case that the driver wants to be sure a device stays > >> in direct mode while it is executing a task or series o

[PATCH 1/6] Drivers: hv: kvp: fix IP Failover

From: Vitaly Kuznetsov Hyper-V VMs can be replicated to another hosts and there is a feature to set different IP for replicas, it is called 'Failover TCP/IP'. When such guest starts Hyper-V host sends it KVP_OP_SET_IP_INFO message as soon as we finish negotiation procedure. The problem is that it

[PATCH 3/6] hv: Lock access to hyperv_mmio resource tree

From: Jake Oshins In existing code, this tree of resources is created in single-threaded code and never modified after it is created, and thus needs no locking. This patch introduces a semaphore for tree access, as other patches in this series introduce run-time modifications of this resource tr

[PATCH 6/6] hv: Track allocations of children of hv_vmbus in private resource tree

From: Jake Oshins This patch changes vmbus_allocate_mmio() and vmbus_free_mmio() so that when child paravirtual devices allocate memory-mapped I/O space, they allocate it privately from a resource tree pointed at by hyperv_mmio and also by the public resource tree iomem_resource. This allows the

[PATCH 0/6] Drivers: hv: vmbus: Fix mmio management

Fix mmio management for vmbus devices. Also included is a patch to fix an issue in KVP. Jake Oshins (5): hv: Make a function to free mmio regions through vmbus hv: Lock access to hyperv_mmio resource tree hv: Use new vmbus_mmio_free() from client drivers. hv: Reverse order of resources in

[PATCH 2/6] hv: Make a function to free mmio regions through vmbus

From: Jake Oshins This patch introduces a function that reverses everything done by vmbus_allocate_mmio(). Existing code just called release_mem_region(). Future patches in this series require a more complex sequence of actions, so this function is introduced to wrap those actions. Signed-off-

[PATCH 5/6] hv: Reverse order of resources in hyperv_mmio

From: Jake Oshins A patch later in this series allocates child nodes in this resource tree. For that to work, this tree needs to be sorted in ascending order. Signed-off-by: Jake Oshins Signed-off-by: K. Y. Srinivasan --- drivers/hv/vmbus_drv.c |3 +-- 1 files changed, 1 insertions(+), 2

[PATCH 4/6] hv: Use new vmbus_mmio_free() from client drivers.

From: Jake Oshins This patch modifies all the callers of vmbus_mmio_allocate() to call vmbus_mmio_free() instead of release_mem_region(). Signed-off-by: Jake Oshins Signed-off-by: K. Y. Srinivasan --- drivers/video/fbdev/hyperv_fb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-

[RFC PATCH v2 2/2] staging: iio: ad7192: use iio_device_{claim|release}_direct_mode()

Replace the code that guarantees the device stays in direct mode with iio_device_{claim|release}_direct_mode() which does same. Signed-off-by: Alison Schofield --- drivers/staging/iio/adc/ad7192.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drive

[RFC PATCH v2 1/2] iio: core: implement iio_device_{claim|release}_direct_mode()

It is often the case that the driver wants to be sure a device stays in direct mode while it is executing a task or series of tasks. To accomplish this today, the driver performs this sequence: 1) take the device state lock, 2) verify it is not in a buffered mode, 3) execute some tasks, and 4) rel

[RFC PATCH v2 0/2] iio: introduce iio_device_{claim|release}_direct_mode()

This patchset introduces two helper functions to simplify driver code requiring the device to be locked in direct mode during execution of a code path. The staging driver ad7192 is updated to demonstrate usage. This could be applied to approximately 18 known cases where the driver is holding the l

RE: [PATCH 3/6] staging: unisys: visorbus: git rid of gotos in devmajorminor_create_file

> -Original Message- > From: Neil Horman [mailto:nhor...@redhat.com] > Sent: Wednesday, March 09, 2016 1:48 PM > To: Sell, Timothy C > Cc: external-ges-uni...@redhat.com; gre...@linuxfoundation.org; > driverdev-devel@linuxdriverproject.org; *S-Par-Maintainer > Subject: Re: [PATCH 3/6] sta

Re: [PATCH 3/6] staging: unisys: visorbus: git rid of gotos in devmajorminor_create_file

On Wed, Mar 09, 2016 at 05:10:28PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, March 09, 2016 11:09 AM > > To: external-ges-uni...@redhat.com > > Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverprojec

RE: [PATCH 3/6] staging: unisys: visorbus: git rid of gotos in devmajorminor_create_file

> -Original Message- > From: Neil Horman [mailto:nhor...@redhat.com] > Sent: Wednesday, March 09, 2016 11:09 AM > To: external-ges-uni...@redhat.com > Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org; > *S-Par-Maintainer > Subject: Re: [PATCH 3/6] staging: unisys: viso

[PATCH] staging:vt6655: fix coding style violations for lines over 80 characters

This patch addresses line length errors reported by checkpatch.pl that could be fixed with simple line breaks. Signed-off-by: Kathryn Hampton --- drivers/staging/vt6655/baseband.c | 20 ++--- drivers/staging/vt6655/baseband.h | 6 ++- drivers/staging/vt6655/card.c | 95 +

Re: [RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not yet defined behaviour

On 03/09/2016 08:29 AM, Emilio López wrote: > One of the tests rely on a behaviour only observed on the driver currently > in use in Android. Disable it here until the behaviour is implemented > or it is decided it should not be implemented on the driver in mainline. > > Signed-off-by: Emilio Lópe

Re: [RFC PATCH v1 0/9] Tests for sync infrastructure

On 03/09/2016 08:28 AM, Emilio López wrote: > Hello everyone, > > This is a series of tests to exercise the sync kernel infrastructure. It is > meant to be a test suite for the work Gustavo has been doing to destage it, > see [0] for his latest series to date. > > These tests were originally part

Re: [PATCH 3/6] staging: unisys: visorbus: git rid of gotos in devmajorminor_create_file

On Tue, Mar 08, 2016 at 08:22:45PM -0500, David Kershner wrote: > The gotos in devmajorminor_create_file aren't needed, get rid of them. > > Signed-off-by: David Kershner > Signed-off-by: Timothy Sell > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 25 > - > 1

Re: [PATCH 5/6] staging: unisys: visorbus: Cleanup gotos in visordriver_probe_device

David Kershner writes: > Visordriver_probe_device gotos were messy, clean them up. > > Signed-off-by: David Kershner > Signed-off-by: Timothy Sell > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drive

[RFC PATCH v1 3/9] selftest: sync: merge tests for sw_sync framework

These tests are based on the libsync test suite from Android. This commit includes tests for basic merge operations. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile | 1 + tools/testing/selftests/sync/sync_merge.c | 60 +++ tools/testing/se

[RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework

These tests are based on the libsync test suite from Android. This commit lays the ground for future tests, as well as includes tests for a variety of basic allocation commands. Signed-off-by: Gustavo Padovan Signed-off-by: Emilio López --- tools/testing/selftests/Makefile | 1 + to

[RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not yet defined behaviour

One of the tests rely on a behaviour only observed on the driver currently in use in Android. Disable it here until the behaviour is implemented or it is decided it should not be implemented on the driver in mainline. Signed-off-by: Emilio López --- tools/testing/selftests/sync/sync_test.c | 7

[RFC PATCH v1 8/9] selftest: sync: stress test for merges

This test is based on the libsync test suite from Android. This commit includes a test to stress merge operations. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile| 1 + tools/testing/selftests/sync/sync_stress_merge.c | 115 +++ tools/test

[RFC PATCH v1 4/9] selftest: sync: wait tests for sw_sync framework

These tests are based on the libsync test suite from Android. This commit includes tests for waiting on fences. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile| 1 + tools/testing/selftests/sync/sync_test.c | 1 + tools/testing/selftests/sync/sync_wait.c | 95 +++

[RFC PATCH v1 5/9] selftest: sync: destruction tests for sw_sync framework

These tests are based on the libsync test suite from Android. This commit includes tests for operations on destructed objects. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile | 1 + tools/testing/selftests/sync/sync_destroyed.c | 90 +++ to

[RFC PATCH v1 6/9] selftest: sync: stress test for parallelism

This test is based on the libsync test suite from Android. This commit includes a stress test that invokes operations in parallel. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile | 1 + .../selftests/sync/sync_stress_parallelism.c | 111 +++

[RFC PATCH v1 0/9] Tests for sync infrastructure

Hello everyone, This is a series of tests to exercise the sync kernel infrastructure. It is meant to be a test suite for the work Gustavo has been doing to destage it, see [0] for his latest series to date. These tests were originally part of a battery of tests shipping with Android's libsync tha

[RFC PATCH v1 2/9] selftest: sync: fence tests for sw_sync framework

These tests are based on the libsync test suite from Android. This commit includes tests for basic fence creation. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile | 1 + tools/testing/selftests/sync/sync_fence.c | 134 ++ tools/testing/sel

[RFC PATCH v1 7/9] selftest: sync: stress consumer/producer test

This test is based on the libsync test suite from Android. This commit includes a stress test that replicates a consumer/producer pattern. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile | 1 + .../testing/selftests/sync/sync_stress_consumer.c | 185 +++

Re: [RFC PATCH v0] Add tw5864 driver

Hi Hans! Some improvements took place on the driver, including cleaner v4l2-compliance tests passing. But there's a single test failure I don't understand. In the code of v4l2-compliance, it seems like an API call CREATE_BUFS is supposed to fail with EINVAL. But in case of my driver, which simply