[PATCH 1/1] staging: ion: debugfs sparse warning, proper mask

2016-02-20 Thread Derek Yerger
From drivers/staging/android TODO file - sparse errors. The current code attempts assignment of -1 to unsigned type gfp_t. Assignment should be an enumerated type of GFP_KERNEL, GFP_ATOMIC, GFP_HIGHMEM, or __GFP_HIGH. The original 2014 patch by Gioh Kim adding debugfs support to android/ion used

Re: [RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE

2016-02-20 Thread Greg Kroah-Hartman
On Fri, Feb 19, 2016 at 07:08:40AM -0800, Olof Johansson wrote: > Hi, > > On Tue, Feb 16, 2016 at 5:32 PM, Nicolas Boichat > wrote: > > From: Lisa Du > > > > There's one point was missed in the patch commit da49889deb34 ("staging: > > binder: Support concurrent 32 bit and 64 bit processes."). W

Re: [PATCH] staging: xgifb: Fix comment style

2016-02-20 Thread Kroah-Hartman
On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote: > Fix comments to use trailing */ on separate lines. > > Signed-off-by: YU BO > --- > drivers/staging/xgifb/vb_init.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Patch doesn't apply :( ___

Re: [PATCH] staging: lusture: obdclass: Remove unnecessary NULL check

2016-02-20 Thread Greg Kroah-Hartman
On Thu, Feb 18, 2016 at 08:55:39PM +0530, Bhaktipriya Shridhar wrote: > NULL check before the debugfs_remove_recursive function is not needed. > > This was detected using scripts/coccinelle/free/ifnullfree.cocci > > Signed-off-by: Bhaktipriya Shridhar > --- > drivers/staging/lustre/lustre/obdc

Re: [PATCH] staging: speakup: Change simple_strtoul usage to kstrtoul

2016-02-20 Thread Greg KH
On Fri, Feb 19, 2016 at 01:27:50PM -0500, Joseph Bisch wrote: > This fixes the checkpatch.pl warning: > > WARNING: simple_strtoul is obsolete, use kstrtoul instead > > Signed-off-by: Joseph Bisch > --- > drivers/staging/speakup/kobjects.c| 12 ++-- > drivers/staging/speakup/main.c

Re: [PATCH] staging: rtl8192u: check return value of read_nic_word_E

2016-02-20 Thread Greg KH
On Fri, Feb 19, 2016 at 01:57:43AM +0100, Salah Triki wrote: > The call of read_nic_word_E may fail, therefore its return value > must be checked. > > Signed-off-by: Salah Triki > --- > drivers/staging/rtl8192u/r8180_93cx6.c | 24 +++- > 1 file changed, 19 insertions(+), 5 de

Re: [PATCH 43/45] staging/lustre/libcfs: Replace use of printk with pr_

2016-02-20 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2016 at 11:12:14AM -0500, Oleg Drokin wrote: > > On Feb 16, 2016, at 12:55 AM, Joe Perches wrote: > > > On Tue, 2016-02-16 at 00:47 -0500, gr...@linuxhacker.ru wrote: > >> From: Oleg Drokin > >> > >> This pacifies checkpatch amongst other things, also is shorter to write > >> an

Re: [PATCH] rtlwifi: Change long delays to sleeps

2016-02-20 Thread ByeoungWook Kim
2016-02-20 23:06 GMT+09:00 Larry Finger : > On 02/19/2016 11:48 PM, ByeoungWook Kim wrote: >> >> 2016-02-16 7:12 GMT+09:00 Larry Finger : >>> >>> Routine rtl_addr_delay() uses delay statements in code that can >>> sleep. To improve system responsiveness, the various delay statements >>> are changed

Re: [PATCH] rtlwifi: Change long delays to sleeps

2016-02-20 Thread Larry Finger
On 02/19/2016 11:48 PM, ByeoungWook Kim wrote: 2016-02-16 7:12 GMT+09:00 Larry Finger : Routine rtl_addr_delay() uses delay statements in code that can sleep. To improve system responsiveness, the various delay statements are changed. In addition, routines rtl_rfreg_delay() and rtl_bb_delay() a