[PATCH] staging: xgifb: Fix comment style

Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 26b539b..c7f02c7 100644 --- a/dri

Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

Hello, Should I send this patch again due the spelling mistake in the patch description? Thanks, Shalin On Mon, Feb 15, 2016 at 6:51 PM, Drokin, Oleg wrote: > > On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote: > >> The parentehsis are fixed in the macro for the ldlm lock to set and >> clear th

[RFC PATCH] staging/android/ion : fix a race condition in the ion driver

There was a use-after-free problem in the ion driver. The problem is detected as an unaligned access in the spin lock functions since it uses load exclusive instruction. In some cases it corrupts the slub's free pointer which causes a unaligned access to the next free pointer.(thus the kmalloc fu

Good Day

I am Ms.Ella Golan, I am the Executive Vice President Banking Division with FIRST INTERNATIONAL BANK OF ISRAEL LTD (FIBI). I am getting in touch with you regarding an extremely important and urgent matter. If you would oblige me the opportunity, I shall provide you with details upon your respons

[RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE

From: Lisa Du There's one point was missed in the patch commit da49889deb34 ("staging: binder: Support concurrent 32 bit and 64 bit processes."). When configure BINDER_IPC_32BIT, the size of binder_uintptr_t was 32bits, but size of void * is 64bit on 64bit system. Correct it here. Signed-off-by:

Re: [PATCH] mm: add MM_SWAPENTS and page table when calculate tasksize in lowmem_scan()

On Tue, 16 Feb 2016, Greg Kroah-Hartman wrote: > On Tue, Feb 16, 2016 at 05:37:05PM +0800, Xishi Qiu wrote: > > Currently tasksize in lowmem_scan() only calculate rss, and not include > > swap. > > But usually smart phones enable zram, so swap space actually use ram. > > Yes, but does that matte

RE: [PATCH RESEND v2 3/3] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Tuesday, February 16, 2016 2:44 PM > To: Jake Oshins > Cc: bhelg...@google.com; linux-...@vger.kernel.org; > gre...@linuxfoundation.org; KY Srinivasan ; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.

Re: [PATCH RESEND v2 3/3] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

On Tue, Feb 16, 2016 at 09:46:55PM +, Jake Oshins wrote: > > -Original Message- > > From: Bjorn Helgaas [mailto:helg...@kernel.org] > > Sent: Tuesday, February 16, 2016 8:46 AM > > To: Jake Oshins > > Cc: bhelg...@google.com; linux-...@vger.kernel.org; > > gre...@linuxfoundation.org; K

[PATCH 4/7] staging: octeon-usb: clean up includes

Clean up includes. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 010b861..3165849 100644

[PATCH 1/7] staging: octeon-usb: delete redundant blank lines

Delete redundant blank lines. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index eaf6ded..91fce2c 100644 --- a/

[PATCH 7/7] staging: octeon-usb: make driver name to match the file name

Make driver name to match the file name. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 68e42fe..1ec8906 100644 -

[PATCH 6/7] staging: octeon-usb: add spaces around operator

Add spaces around operator to improve readability. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/o

[PATCH 2/7] staging: octeon-usb: add missing braces

Some if branches are missing braces as required by coding style. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-h

[PATCH 5/7] staging: octeon-usb: switch to use kernel types

Switch to use kernel types: uint64_t -> u64 uint32_t -> u32 uint16_t -> u16 uint8_t -> u8 int8_t -> s8 Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 75 +++-- drivers/staging/octeon-usb/octeon-hcd.h | 536 -

[PATCH 3/7] staging: octeon-usb: delete space after cast

Delete space after cast. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 2872653..010b861 100644 --- a/dri

[PATCH v4 2/4] Staging: rtl8188eu/core: Coding style fix, set conform spaces between identifiers

And a space after include keyword, making the preprocessor more readable, and remove an unexpected space between a type and variable name. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH v4 4/4] Staging: rtl8188eu/core: Coding style fix, avoid line over 80 characters

Jump a new line after and operator of the test. It avoids to exceed 80 chars line, and remove a checkpatch warning. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol

[PATCH v4 1/4] Staging: rtl8188eu/core: remove paragraph which mention FSF address in comment header

As FSF address changed in the past, and can change in the future, remove the address paragraph in the comment header, and avoid a warning of checkpatch. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/

[PATCH v4 3/4] Staging: rtl8188eu/core: Coding style fix, set constant operand on right in tests

Remove a checkpatch warning, putting constant operant on right of two tests. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/

Re: [PATCH v3 4/4] Staging: gdm72xx: Remove BUG_ON

On Wed, Feb 17, 2016 at 02:00:58AM +0530, Shraddha Barke wrote: > Delete the BUG_ON check. > > Signed-off-by: Shraddha Barke > --- > Changes in v3- > Deleted BUG_ON > Changes in v2- > Nothing > > drivers/staging/gdm72xx/gdm_wimax.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/dr

[PATCH RESEND v3 2/3] PCI: irqdomain: Look up IRQ domain by fwnode_handle

From: Jake Oshins This patch adds a second way of finding an IRQ domain associated with a root PCI bus. After looking to see if one can be found through the OF tree, it attempts to look up the IRQ domain through an fwnode_handle stored in the pci_sysdata struct. Signed-off-by: Jake Oshins ---

[PATCH RESEND v3 3/3] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

From: Jake Oshins This patch introduces a new driver which exposes a root PCI bus whenever a PCI Express device is passed through to a guest VM under Hyper-V. The device can be single- or multi-function. The interrupts for the devices are managed by an IRQ domain, implemented within the driver.

[PATCH RESEND v3 0/3] PCI: hv: New paravirtual PCI front-end driver

From: Jake Oshins This version incorporates more feedback from Bjorn Helgaas. Most notably, I removed some debugging code and I consistently used architectural means for getting the PCI domain instead of just reaching into the sysdata. This is a resend of patches that enable PCI pass-through wi

[PATCH RESEND v3 1/3] PCI: Add fwnode_handle to pci_sysdata

From: Jake Oshins This patch adds an fwnode_handle to struct pci_sysdata, which is used by the next patch in the series when trying to locate an IRQ domain associated with a root PCI bus. Signed-off-by: Jake Oshins --- arch/x86/include/asm/pci.h | 15 +++ include/linux/pci.h

RE: [PATCH RESEND v2 3/3] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Tuesday, February 16, 2016 8:46 AM > To: Jake Oshins > Cc: bhelg...@google.com; linux-...@vger.kernel.org; > gre...@linuxfoundation.org; KY Srinivasan ; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.

Re: [PATCH v2 4/5] Staging: gdm72xx: Replace BUG_ON with WARN_ON

On Wed, Feb 17, 2016 at 01:11:26AM +0530, Shraddha Barke wrote: > Replace the usage of BUG_ON with WARN_ON. > > Signed-off-by: Shraddha Barke > --- > Changes in v2- > No change > > drivers/staging/gdm72xx/gdm_wimax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dri

[PATCH] staging: rtl8712: Improve suspend/resume functionality.

Fix a driver hang caused by earlier suspend/resume cycles. By handling a ENODEV error during suspend as a real error we eventually end up stopping the whole driver. Fix this by handling the ENODEV error (during suspend) essentially by retrying. Signed-off-by: Hemmo Nieminen --- drivers/staging/

[PATCH v3 4/4] Staging: gdm72xx: Remove BUG_ON

Delete the BUG_ON check. Signed-off-by: Shraddha Barke --- Changes in v3- Deleted BUG_ON Changes in v2- Nothing drivers/staging/gdm72xx/gdm_wimax.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 859880c..5d

[PATCH v3 2/4] Staging: gdm72xx: Add space around that "+", "&" and "/"

Add missing spaces around "+", "&" and "/" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by: Shraddha Barke --- Changes in v2- Subject Changes in v3- Fix 80 line. drivers/staging/gdm72xx/gdm_qos.c | 12 ++-- drivers/staging/gdm72xx/gdm_sdio.c | 4 ++--

[PATCH v3 3/4] Staging: gdm72xx: Remove unnecessary parenthesis around function pointer

No need for the parentheses around any function pointer. Detected using checkpatch. Signed-off-by: Shraddha Barke --- Changes in v2 and v3- Nothing. drivers/staging/gdm72xx/gdm_wimax.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c

[PATCH v3 1/4] Staging: gdm72xx: Add space around that "+", "&" and "|"

Add missing spaces around "+", "&" and "|" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by: Shraddha Barke --- Changes in v2 and v3- No change. drivers/staging/gdm72xx/hci.h | 2 +- drivers/staging/gdm72xx/netlink_k.c | 6 +++--- drivers/staging/gdm72xx/sdi

[PATCH v3 0/4] Staging: gdm72xx: Checkpatch cleanups.

This patch series fixes last of checkpatch warnings in gdm72xx. Shraddha Barke (4): Staging: gdm72xx: Add space around that "+", "&" and "|" Staging: gdm72xx: Add space around that "+", "&" and "/" Staging: gdm72xx: Remove unnecessary parenthesis around function pointer Staging: gdm72x

Re: [PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE

From: Haiyang Zhang Date: Tue, 9 Feb 2016 15:31:34 + > 1) I share your concern as well. Is there a universal way to immediately > trigger > DHCP renew of all current and future daemons with a single event from kernel? > If not, can we put the delay (RNDIS_STATUS_NETWORK_CHANGE only) into a

Re: [PATCH 4/5] Staging: gdm72xx: Replace BUG_ON with WARN_ON

On Wed, Feb 17, 2016 at 12:55:47AM +0530, Shraddha Barke wrote: > Replace the usage of BUG_ON with WARN_ON. > > Signed-off-by: Shraddha Barke > --- > drivers/staging/gdm72xx/gdm_wimax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/gdm72xx/gdm_wimax.c

[PATCH v2 4/5] Staging: gdm72xx: Replace BUG_ON with WARN_ON

Replace the usage of BUG_ON with WARN_ON. Signed-off-by: Shraddha Barke --- Changes in v2- No change drivers/staging/gdm72xx/gdm_wimax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 2fa86ad.

[PATCH v2 3/5] Staging: gdm72xx: Remove unnecessary parenthesis around function pointer

No need for the parentheses around any function pointer. Detected using checkpatch. Signed-off-by: Shraddha Barke --- Changes in v2- Nothing drivers/staging/gdm72xx/gdm_wimax.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/driv

[PATCH v2 2/5] Staging: gdm72xx: Add space around that "+", "&" and "/"

Add missing spaces around "+", "&" and "|" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by: Shraddha Barke --- Changes in v2- Subject changed drivers/staging/gdm72xx/gdm_qos.c | 12 ++-- drivers/staging/gdm72xx/gdm_sdio.c | 4 ++-- drivers/staging/gdm72

[PATCH v2 1/5] Staging: gdm72xx: Add space around that "+", "&" and "|"

Add missing spaces around "+", "&" and "|" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by: Shraddha Barke --- Changes in v2- Nothing drivers/staging/gdm72xx/hci.h | 2 +- drivers/staging/gdm72xx/netlink_k.c | 6 +++--- drivers/staging/gdm72xx/sdio_boot.c |

[PATCH 2/5] Staging: gdm72xx: Add space around that "+", "&" and "/"

Add missing spaces around "+", "&" and "|" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by: Shraddha Barke --- drivers/staging/gdm72xx/gdm_qos.c | 12 ++-- drivers/staging/gdm72xx/gdm_sdio.c | 4 ++-- drivers/staging/gdm72xx/gdm_usb.c | 2 +- drivers/s

[PATCH 5/5] Staging: gdm72xx: Fix line over 80 characters

This patch fixes the checkpatch.pl warning of line over 80 characters. Signed-off-by: Shraddha Barke --- drivers/staging/gdm72xx/gdm_wimax.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 8861

[PATCH 4/5] Staging: gdm72xx: Replace BUG_ON with WARN_ON

Replace the usage of BUG_ON with WARN_ON. Signed-off-by: Shraddha Barke --- drivers/staging/gdm72xx/gdm_wimax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 2fa86ad..8861750 100644 --- a/drive

[PATCH 3/5] Staging: gdm72xx: Remove unnecessary parenthesis around function pointer

No need for the parentheses around any function pointer. Detected using checkpatch. Signed-off-by: Shraddha Barke --- drivers/staging/gdm72xx/gdm_wimax.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_w

[PATCH 2/5] Staging: gdm72xx: Add space around that "+", "&" and "|"

Add missing spaces around "+", "&" and "|" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by: Shraddha Barke --- drivers/staging/gdm72xx/gdm_qos.c | 12 ++-- drivers/staging/gdm72xx/gdm_sdio.c | 4 ++-- drivers/staging/gdm72xx/gdm_usb.c | 2 +- drivers/s

[PATCH 1/5] Staging: gdm72xx: Add space around that "+", "&" and "|"

Add missing spaces around "+", "&" and "|" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by: Shraddha Barke --- drivers/staging/gdm72xx/hci.h | 2 +- drivers/staging/gdm72xx/netlink_k.c | 6 +++--- drivers/staging/gdm72xx/sdio_boot.c | 2 +- drivers/staging/g

[PATCH 0/5] Staging: gdm72xx: Checkpatch cleanups

This patch series fixes last of checkpatch warnings in gdm72xx. Shraddha Barke (5): Staging: gdm72xx: Add space around that "+", "&" and "|" Staging: gdm72xx: Add space around that "+", "&" and "|" Staging: gdm72xx: Remove unnecessary parenthesis around function pointer Staging: gdm72x

Re: [PATCH] mm: add MM_SWAPENTS and page table when calculate tasksize in lowmem_scan()

On Tue, Feb 16, 2016 at 05:37:05PM +0800, Xishi Qiu wrote: > Currently tasksize in lowmem_scan() only calculate rss, and not include swap. > But usually smart phones enable zram, so swap space actually use ram. Yes, but does that matter for this type of calculation? I need an ack from the android

Good Day

I am Ms.Ella Golan, I am the Executive Vice President Banking Division with FIRST INTERNATIONAL BANK OF ISRAEL LTD (FIBI). I am getting in touch with you regarding an extremely important and urgent matter. If you would oblige me the opportunity, I shall provide you with details upon your respons

Re: [PATCH RESEND v2 3/3] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

Hi Jake, Looks good to me overall; I marked a few nits below. The only real question I have is about domain number allocation. See the note below. On Tue, Feb 09, 2016 at 07:24:28PM +, ja...@microsoft.com wrote: > From: Jake Oshins > > This patch introduces a new driver which exposes a ro

Re: whitespace error in some of commits

On Tue, Feb 16, 2016 at 03:47:00PM +0900, Tony Cho wrote: > Hi Janani, > > I can find the whitespace errors in your commits which is already accepted in > staging-testing branch. Ick, my fault, I should have caught them before they were merged, sorry about that. > The commit number is c611d48e6

Re: [PATCH 43/45] staging/lustre/libcfs: Replace use of printk with pr_

On Feb 16, 2016, at 12:55 AM, Joe Perches wrote: > On Tue, 2016-02-16 at 00:47 -0500, gr...@linuxhacker.ru wrote: >> From: Oleg Drokin >> >> This pacifies checkpatch amongst other things, also is shorter to write >> and avoiding calls to printk_ratelimit() is also good. > [] >> diff --git a/dri

Re: Time for a code audit?

On Sat, 2016-02-13 at 01:01 +0300, Dan Carpenter wrote: > I looked at the Smatch warnings, plus some bonus stuff I'm still > working > on. > > drivers/staging/unisys/include/iochannel.h:592 add_physinfo_entries() > warn: inconsistent indenting > drivers/staging/unisys/include/iochannel.h:596 add_p

Re: [PATCH] rtlwifi: Change long delays to sleeps

On 02/16/2016 12:17 AM, Souptick Joarder wrote: On Tue, Feb 16, 2016 at 3:42 AM, Larry Finger wrote: --snip-- else if (addr == 0xf9) - udelay(1); + usleep_range(1, 2); why udelay is replaced by usleep_range? I'm not sure of your level of soph

Re: staging: unisys: fix else statement in visornic_main.c

On 2/16/2016 4:02 AM, Joe Perches wrote: > On Tue, 2016-02-16 at 10:31 +0300, Dan Carpenter wrote: > > [ checkpatch.pl told someone to introduce a bug and they did... ] > > Yeah, it happens. > > People should not take a message like "generally" as > an absolute. > > "else is not generally useful a

[PATCH 2/2] staging: wilc1000: Removed braces from single block statements

This patch corrects warnings generated by checkpatch.pl by removing braces from single block statements. Signed-off-by: Roger H. Newell --- drivers/staging/wilc1000/wilc_spi.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/staging/wilc1000/

[PATCH 1/2] staging: wilc1000: Whitespaces removed from function call

This patch corrects errors generated by checkpatch.pl by removing whitespace between parameters passed to dev_err() Signed-off-by: Roger H. Newell --- drivers/staging/wilc1000/wilc_spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c

[PATCH] staging: wilc1000: Remove trailing whitespace errors

Remove trailing whitespace checkpatch errors. Signed-off-by: Janani Ravichandran --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/linux_mon.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/dri

[PATCH] mm: add MM_SWAPENTS and page table when calculate tasksize in lowmem_scan()

Currently tasksize in lowmem_scan() only calculate rss, and not include swap. But usually smart phones enable zram, so swap space actually use ram. Signed-off-by: Xishi Qiu --- drivers/staging/android/lowmemorykiller.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drive

Re: staging: unisys: fix else statement in visornic_main.c

On Tue, 2016-02-16 at 10:31 +0300, Dan Carpenter wrote: > [ checkpatch.pl told someone to introduce a bug and they did...  ] Yeah, it happens. People should not take a message like "generally" as an absolute. "else is not generally useful after a break or return" checkpatch isn't a flow control

[PATCH 6/7] staging: wilc1000: handle_set_mac_address: rename result

This patch renames result to ret that is used to get return value from wilc_send_config_pkt. It will be changed until all handle_*() function has same variable name as ret. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 5/7] staging: wilc1000: handle_set_mac_address: change data type of result

result variable gets value from wilc_send_config_pkt that has return value of int. This patch changes data type of result variable to int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 7/7] staging: wilc1000: handle_set_mac_address: use netdev_err

This patch uses netdev_err instead of PRINT_ER that is a custom debug print. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_in

[PATCH 1/7] staging: wilc1000: handle_set_mac_address: remove debug message of kmalloc failure

There is no need to print debug message when kmalloc is failed. This message is redundant. The code already show us that kmalloc is failed. The brace of if statement is remove as well due to have a single statement. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 5 ++

[PATCH 3/7] staging: wilc1000: handle_set_mac_address: use kmemdup

This patch replaces kmalloc followed by memcpy with kmemdup. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c ind

[PATCH 4/7] staging: wilc1000: handle_set_mac_address: change return type to void

When handle_set_mac_address is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes a brace of if statement due to have a single statement. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_

[PATCH 2/7] staging: wilc1000: handle_set_mac_address: fix kmalloc return error code

This patch fix return error code of kmalloc as -ENOMEM instead of -EFAULT. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_inte

恶魔法术石

你的老朋友邀你来Q群:343257759 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel