Re: [PATCH V2 00/26] use unified firmware and add ops in cfg

2016-01-25 Thread Greg KH
On Tue, Jan 26, 2016 at 11:44:30AM +0900, glen lee wrote: > > > On 2016년 01월 26일 02:21, Greg KH wrote: > >On Mon, Jan 25, 2016 at 03:15:31PM +0200, Kalle Valo wrote: > >>Glen Lee writes: > >> > >>>This patch series contains > >>>* support suspend and resume functionality > >>>* use a unified fir

Re: [PATCH V2 00/26] use unified firmware and add ops in cfg

2016-01-25 Thread glen lee
On 2016년 01월 26일 02:21, Greg KH wrote: On Mon, Jan 25, 2016 at 03:15:31PM +0200, Kalle Valo wrote: Glen Lee writes: This patch series contains * support suspend and resume functionality * use a unified firmware for all mode of operations(station, ap, p2p) * support Station/AP concurrency *

[PATCH 2/2] Staging: rts5208: Add missing dma_mapping_error

2016-01-25 Thread Shaun Ren
Signed-off-by: Shaun Ren --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c index eff9a4b621..43787df 100644 --- a/drivers/staging/rts5208/rtsx_transp

[PATCH 1/2] Staging: rts5208: Cleanup rtsx_transport.c

2016-01-25 Thread Shaun Ren
This patch fixes coding style issues in rtsx_transport.c. Signed-off-by: Shaun Ren --- drivers/staging/rts5208/rtsx_transport.c | 115 +-- 1 file changed, 65 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts52

[PATCH 0/2] Staging: rts5208: Coding style and dma mapping fixes

2016-01-25 Thread Shaun Ren
This set of patches fixes the coding style issues in rtsx_transport.c, and adds a missing dma_mapping_error check. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Huang, Ying
Dan Carpenter writes: > On Tue, Jan 26, 2016 at 08:32:48AM +0800, Huang, Ying wrote: >> Dan Carpenter writes: >> >> > On Mon, Jan 25, 2016 at 03:13:21PM +0530, Sudip Mukherjee wrote: >> >> Apart from the mail which Ying Huang sent to me last week for another >> >> error >> >> (which actually t

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Dan Carpenter
On Tue, Jan 26, 2016 at 08:32:48AM +0800, Huang, Ying wrote: > Dan Carpenter writes: > > > On Mon, Jan 25, 2016 at 03:13:21PM +0530, Sudip Mukherjee wrote: > >> Apart from the mail which Ying Huang sent to me last week for another error > >> (which actually turned out to be this one), i saw the f

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Huang, Ying
Dan Carpenter writes: > On Mon, Jan 25, 2016 at 03:13:21PM +0530, Sudip Mukherjee wrote: >> Apart from the mail which Ying Huang sent to me last week for another error >> (which actually turned out to be this one), i saw the first report by >> Ying Huang on November. >> https://lkml.org/lkml/2015

[PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs

2016-01-25 Thread Richard Weinberger
Not every arch has io memory. So, unbreak the build by fixing the dependencies. Signed-off-by: Richard Weinberger --- drivers/staging/iio/adc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig index 58d4517..b9519be 10064

Re: [PATCH] staging: nvec: replace led_classdev_register

2016-01-25 Thread Marc Dietrich
Am Donnerstag 21 Januar 2016, 10:23:46 schrieb Gujulan Elango, Hari Prasath: > From: Hari Prasath Gujulan Elango > > Replace the led_classdev_register() with the platform managed version > devm_led_classdev_register() & henceforth remove the redundant > nvec_paz00_remove() function. > > Signed-o

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Willy Tarreau
On Mon, Jan 25, 2016 at 06:19:44PM +0530, Sudip Mukherjee wrote: > On Mon, Jan 25, 2016 at 03:40:41PM +0300, Dan Carpenter wrote: > > Ying, could you CC the subsystem list for these reports? This one was > > CC'd to Sirnam, Greg and LKML. Sirnam is too new to understand what > > they mean, Greg i

Re: [dm-devel] [PATCH 22/26] iscsi_tcp: Use ahash

2016-01-25 Thread Mike Christie
On 01/24/2016 07:19 AM, Herbert Xu wrote: > This patch replaces uses of the long obsolete hash interface with > ahash. > > Signed-off-by: Herbert Xu > --- > > drivers/scsi/iscsi_tcp.c| 54 > ++-- > drivers/scsi/iscsi_tcp.h|4 +-- > drivers/

[PATCH] staging: unisys: visornic: remove useless memset

2016-01-25 Thread Hugo Camboulive
alloc_etherdev() calls alloc_netdev_mqs(), which already uses kzalloc/vzalloc. This clears a sparse warning : drivers/staging/unisys/visornic/visornic_main.c:1366:15: warning: memset with byte count of 1460112 Signed-off-by: Hugo Camboulive --- drivers/staging/unisys/visornic/visornic_main.c |

Re: [PATCH net-next] hv_netvsc: Fix book keeping of skb during batching process

2016-01-25 Thread David Miller
From: Haiyang Zhang Date: Mon, 25 Jan 2016 09:49:31 -0800 > Since eliminating send_completion_tid from struct hv_netvsc_packet, we > haven't add proper book keeping for the skb of the batched packet. This > patch fixes this issue and allows the previous skb is properly freed. > Otherwise, a panic

Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation

2016-01-25 Thread David Miller
From: Vitaly Kuznetsov Date: Mon, 25 Jan 2016 16:00:41 +0100 > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit but the > fact that netv

Re: Move wlan-ng out of staging?

2016-01-25 Thread Dan Carpenter
On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote: > Hi All, > > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > wlan-ng driver is maybe ready to be moved out of staging. Are there > any TODO tasks left to do beside checkpatch.pl clean-up? I happened to

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-01-25 Thread Mauro Carvalho Chehab
Em Mon, 25 Jan 2016 23:03:43 +0530 Sudip Mukherjee escreveu: > On Monday 25 January 2016 10:42 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 25 Jan 2016 22:32:31 +0530 > > Sudip Mukherjee escreveu: > > > >> On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: > >>> Em Fri, 1

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-01-25 Thread Sudip Mukherjee
On Monday 25 January 2016 10:42 PM, Mauro Carvalho Chehab wrote: Em Mon, 25 Jan 2016 22:32:31 +0530 Sudip Mukherjee escreveu: On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: Em Fri, 18 Dec 2015 18:35:29 +0530 Sudip Mukherjee escreveu: Modify lirc_parallel driver to u

Re: [PATCH V2 00/26] use unified firmware and add ops in cfg

2016-01-25 Thread Greg KH
On Mon, Jan 25, 2016 at 03:15:31PM +0200, Kalle Valo wrote: > Glen Lee writes: > > > This patch series contains > > > > * support suspend and resume functionality > > > > * use a unified firmware for all

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-01-25 Thread Mauro Carvalho Chehab
Em Mon, 25 Jan 2016 22:32:31 +0530 Sudip Mukherjee escreveu: > On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: > > Em Fri, 18 Dec 2015 18:35:29 +0530 > > Sudip Mukherjee escreveu: > > > > > Modify lirc_parallel driver to use the new parallel port device model. > > >

Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation

2016-01-25 Thread Eric Dumazet
On Mon, 2016-01-25 at 16:00 +0100, Vitaly Kuznetsov wrote: > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit but the > fact that netvsc_s

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-01-25 Thread Sudip Mukherjee
On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 18 Dec 2015 18:35:29 +0530 > Sudip Mukherjee escreveu: > > > Modify lirc_parallel driver to use the new parallel port device model. > > Did you or someone else tested this patch? Only build tested and tested by ins

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-01-25 Thread Mauro Carvalho Chehab
Em Fri, 18 Dec 2015 18:35:29 +0530 Sudip Mukherjee escreveu: > Modify lirc_parallel driver to use the new parallel port device model. Did you or someone else tested this patch? Regards, Mauro > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/media/lirc/lirc_parallel.c | 100 >

Re: [PATCH 4/5] staging: media: lirc: place operator on previous line

2016-01-25 Thread Mauro Carvalho Chehab
Em Fri, 18 Dec 2015 18:35:28 +0530 Sudip Mukherjee escreveu: > checkpatch complains about the logical operator, which should be on the > previous line. IMHO, this is a matter of personal taste. I prefer to keep the operator on the next line, as it makes clearer to see why the logic was broken.

Re: [PATCH 16/26] libceph: Use skcipher

2016-01-25 Thread Ilya Dryomov
On Sun, Jan 24, 2016 at 2:18 PM, Herbert Xu wrote: > This patch replaces uses of blkcipher with skcipher. > > Signed-off-by: Herbert Xu > --- > > net/ceph/crypto.c | 97 > +++--- > 1 file changed, 56 insertions(+), 41 deletions(-) Could you get

[PATCH net-next] hv_netvsc: Fix book keeping of skb during batching process

2016-01-25 Thread Haiyang Zhang
Since eliminating send_completion_tid from struct hv_netvsc_packet, we haven't add proper book keeping for the skb of the batched packet. This patch fixes this issue and allows the previous skb is properly freed. Otherwise, a panic may happen. Thanks to Simon Xiao for bisecting and analysis. Sign

[PATCH] iio: ade7753: avoid uninitialized data

2016-01-25 Thread Arnd Bergmann
The ade7753_spi_read_reg_16() will either successfully read a value from SPI, or return a failure code without delivering data. However, the ade7753_stop_device() and ade7753_reset() functions use the returned data without checking for an error condition first. Gcc detects this as a possible bug an

[PATCH] staging: iio: ad5933: avoid uninitialized variable in error case

2016-01-25 Thread Arnd Bergmann
The ad5933_i2c_read function returns an error code to indicate whether it could read data or not. However ad5933_work() ignores this return code and just accesses the data unconditionally, which gets detected by gcc as a possible bug: drivers/staging/iio/impedance-analyzer/ad5933.c: In function 'a

Re: Move skein out of staging?

2016-01-25 Thread Jason Cooper
Hi Ksenija, On Mon, Jan 25, 2016 at 01:18:46PM +0100, Ksenija Stanojević wrote: > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > skein driver is maybe ready to be moved out of staging. Are there > any TODO tasks left to do beside checkpatch.pl clean-up? Well, I haven't

[PATCH] staging: sm750fb, fix typos

2016-01-25 Thread Jiri Slaby
From: Matej Vasek The code contained typos like "structur", "fointers", etc. Fix that. No code change, only comments. Signed-off-by: Matej Vasek Cc: Sudip Mukherjee Cc: Teddy Wang Cc: Greg Kroah-Hartman Cc: Cc: Signed-off-by: Jiri Slaby --- drivers/staging/sm750fb/ddk750_hwi2c.c | 4 ++

[PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation

2016-01-25 Thread Vitaly Kuznetsov
Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add VLAN ID to flow_keys")) introduced a performance regression in netvsc driver. Is problem is, however, not the above mentioned commit but the fact that netvsc_set_hash() function did some assumptions on the struct flow_keys dat

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Joe Perches
On Mon, 2016-01-25 at 18:21 +0530, Sudip Mukherjee wrote: > On Mon, Jan 25, 2016 at 04:47:26AM -0800, Joe Perches wrote: > > On Mon, 2016-01-25 at 12:16 +0300, Dan Carpenter wrote: > > > Ugh...  Checkpatch told us to introduce bugs...  :(  We almost certainly > > > would have missed this bug in rev

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Joe Perches
On Mon, 2016-01-25 at 12:16 +0300, Dan Carpenter wrote: > Ugh...  Checkpatch told us to introduce bugs...  :(  We almost certainly > would have missed this bug in review, but it wasn't sent to the list so > I guess we'll never know. So when isn't usleep_range preferred over udelay? ___

Re: rtlwifi: rtl8821ae: Fix 5G failure when EEPROM is incorrectly encoded

2016-01-25 Thread Kalle Valo
> Recently, it has been reported that D-Link DWA-582 cards, which use an > RTL8812AE chip are not able to scan for 5G networks. The problems started > with kernel 4.2, which is the first version that had commit d10101a60372 > ("rtlwifi: rtl8821ae: Fix problem with regulatory information"). With th

Re: [PATCH V2 00/26] use unified firmware and add ops in cfg

2016-01-25 Thread Kalle Valo
Glen Lee writes: > This patch series contains > > * support suspend and resume functionality > > * use a unified firmware for all mode of operations(station, ap, p2p) > > * support Station/AP

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Sudip Mukherjee
On Mon, Jan 25, 2016 at 04:47:26AM -0800, Joe Perches wrote: > On Mon, 2016-01-25 at 12:16 +0300, Dan Carpenter wrote: > > Ugh...  Checkpatch told us to introduce bugs...  :(  We almost certainly > > would have missed this bug in review, but it wasn't sent to the list so > > I guess we'll never kno

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Sudip Mukherjee
On Mon, Jan 25, 2016 at 03:40:41PM +0300, Dan Carpenter wrote: > On Mon, Jan 25, 2016 at 03:13:21PM +0530, Sudip Mukherjee wrote: > > Apart from the mail which Ying Huang sent to me last week for another error > > (which actually turned out to be this one), i saw the first report by > > Ying Huang

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Dan Carpenter
On Mon, Jan 25, 2016 at 03:13:21PM +0530, Sudip Mukherjee wrote: > Apart from the mail which Ying Huang sent to me last week for another error > (which actually turned out to be this one), i saw the first report by > Ying Huang on November. > https://lkml.org/lkml/2015/11/2/93 Ying, could you CC t

Re: Move wlan-ng out of staging?

2016-01-25 Thread Sudip Mukherjee
On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote: > Hi All, > > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > wlan-ng driver is maybe ready to be moved out of staging. Are there > any TODO tasks left to do beside checkpatch.pl clean-up? I think the m

Move skein out of staging?

2016-01-25 Thread Ksenija Stanojević
Hi Jason, I'm helping Greg do a bit of cleanup in the staging tree, I noticed that skein driver is maybe ready to be moved out of staging. Are there any TODO tasks left to do beside checkpatch.pl clean-up? Thanks, Ksenija ___ devel mailing list de...@li

Move wlan-ng out of staging?

2016-01-25 Thread Ksenija Stanojević
Hi All, I'm helping Greg do a bit of cleanup in the staging tree, I noticed that wlan-ng driver is maybe ready to be moved out of staging. Are there any TODO tasks left to do beside checkpatch.pl clean-up? Thanks, Ksenija ___ devel mailing list de...@li

Re: [PATCH 00/11] sync framework de-staging: part 1 - clean up

2016-01-25 Thread Maarten Lankhorst
Hey, Op 21-01-16 om 13:49 schreef Gustavo Padovan: > From: Gustavo Padovan > > Hi, > > The following patches are some clean ups on the sync framework before > we start the actual de-staging. The main changes here are the move of > SW_SYNC_USER to debugfs. Removal of struct sync_pt in favor of dir

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Dan Carpenter
On Mon, Jan 25, 2016 at 03:13:21PM +0530, Sudip Mukherjee wrote: > On Mon, Jan 25, 2016 at 12:16:01PM +0300, Dan Carpenter wrote: > > Ugh... Checkpatch told us to introduce bugs... :( We almost certainly > > would have missed this bug in review, but it wasn't sent to the list so > > I guess we'l

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Sudip Mukherjee
On Mon, Jan 25, 2016 at 12:16:01PM +0300, Dan Carpenter wrote: > Ugh... Checkpatch told us to introduce bugs... :( We almost certainly > would have missed this bug in review, but it wasn't sent to the list so > I guess we'll never know. I can find the v1 of the patch in usb list. http://permali

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Dan Carpenter
Anyway, I'll update Smatch to warn about these in the future. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

2016-01-25 Thread Dan Carpenter
Ugh... Checkpatch told us to introduce bugs... :( We almost certainly would have missed this bug in review, but it wasn't sent to the list so I guess we'll never know. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://