Fix style of several comments.
Signed-off-by: Sushuruth Sadagopan
---
drivers/staging/lustre/lnet/lnet/config.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/config.c
b/drivers/staging/lustre/lnet/lnet/config.c
index 284
On 2016/1/16 7:23, Russell King - ARM Linux wrote:
> On Fri, Jan 15, 2016 at 03:03:42PM -0800, Laura Abbott wrote:
>> (adding linux-arm and a few people)
>>
>> On 01/14/2016 06:42 PM, Chen Feng wrote:
>>> The page is already alloc at ion_alloc function,
>>> ion_mmap map the alloced pages to user-
Fix checkpatch.pl issue:
WARNING: line over 80 characters
CHECK: No space is necessary after a cast
Signed-off-by: SirnamSwetha
---
drivers/staging/panel/panel.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/pan
Replace complex definition of POWER_MODE_CTRL register fields with BIT()
macro and use open-coded implementation for register manipulations.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_power.c | 10 --
drivers/staging/sm750fb/ddk750_reg.h | 12 +++-
2 files
Use more straight-forward definitions for multi-bit field of
POWER_MODE_CTRL register and use open-coded implementation for register
manipulations.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_power.c | 13 +
drivers/staging/sm750fb/ddk750_reg.h | 8
2
Replace complex definition of CURRENT_GATE register fields with BIT() macro
and use open-coded implementation for register manipulations.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 3 +--
drivers/staging/sm750fb/ddk750_power.c | 18 +++---
drivers/staging/
Use more straight-forward definitions for multi-bit fields of
CURRENT_GATE register and use open-coded implementation for register
manipulation.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 20 +--
drivers/staging/sm750fb/ddk750_reg.h | 36 +++
Use more straight-forward definitions for multi-bit fields of MODE0_GATE
register.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_reg.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_reg.h
b/drivers/stag
Replace complex definition of GPIO_MUX register fields with BIT() macro
and use open-coded implementation for register manipulations.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_hwi2c.c | 7 +-
drivers/staging/sm750fb/ddk750_reg.h | 128 +
Remove HungarianCamelCase notation
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/drivers/staging/sm750fb/ddk750_chip.c
index b11231
Replace complex definition of MODE0_GATE register fields with BIT() macro
and use open-coded implementation for register manipulations.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
drivers/staging/sm750fb/ddk750_reg.h | 44 +--
Remove HungarianCamelCase notation
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 52 +--
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/drivers/staging/sm750fb/ddk750_chip.c
index
Hi,
This is the first set of patches that aim to replace custom defines for
register fields. The ultimate goal is to have MSB:LSB notation for register
fields and FIELD_* macros removed.
Mike Rapoport (18):
staging: sm750fb: hw_sm750(le)_deWait: rename dwVal to val
staging: sm750fb: use BIT
Replace complex definition of DE_STATE1 field and usage of FIELD_SET with
BIT() macro and open-coded register value modifications
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_reg.h | 4 +---
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
2 files changed, 3 insertions(+), 5 del
Use more straight-forward definitions for multi-bit fields of MISC_CTRL
register and use open-coded implementation for register manipulations.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
drivers/staging/sm750fb/ddk750_reg.h | 28 ++--
For case when USE_HW_I2C is not defined, i2c{Read,Write}reg was wrongly
defined to use old function names.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c
b/d
Use more straight-forward definitions for multi-bit fields of
SYSTEM_CTRL register and replace FIELD_GET/SET for these fields with
open-coded implementation.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_power.c | 2 +-
drivers/staging/sm750fb/ddk750_reg.h | 20 ++---
Replace complex definition of DE_STATE1 fields and usage of FIELD_GET
with BIT() macro and open-coded register value modifications
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_reg.h | 12 +++-
drivers/staging/sm750fb/sm750_hw.c | 8
2 files changed, 7 inser
Replace complex definition of MISC_CTRL register fields with BIT() macro
and use open-coded implementation for register manipulations.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 4 +-
drivers/staging/sm750fb/ddk750_power.h | 11 ++
drivers/staging/sm750fb/ddk7
Remove HungarianCamelCase notation
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750_hw.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_hw.c
b/drivers/staging/sm750fb/sm750_hw.c
index 41822c6..f9908d9 100644
--- a
Definition of reserved fields in a register is not interesting
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_reg.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_reg.h
b/drivers/staging/sm750fb/ddk750_reg.h
index db13bdf..38ebe95 100644
--
Replace complex definition of SYSTEM_CTRL fields and usage of
FIELD_GET/SET with BIT() macro and open-coded register value modifications
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_display.c | 24 --
drivers/staging/sm750fb/ddk750_reg.h | 76 --
Use a function to unregister framebuffer info and release its resources.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm75
Several pr_info statements in lynxfb_pci_probe seem like debug leftovers
and may be removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index c33c7ff
Split framebuffer allocation and registration into a dedicated function
to simplify lynxfb_pci_probe
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 98 +
1 file changed, 41 insertions(+), 57 deletions(-)
diff --git a/drivers/staging/sm
Hi,
These patches refactor the lynxfb_pci_probe.
v4 changes:
* address Dan's comments
v3 changes:
* rebased on current Greg's staging-testing
v2 changes:
* add pci_disable_device on the cleanup path
* return actual error rather than ENODEV
Mike Rapoport (7):
staging: sm750fb: disable PCI dev
The par variable in lynxfb_pci_remove is only assigned a value and never
used afterwards. Remove it.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 7eb38
Will be used in futher refactoring of driver _probe and _remove methods.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 24 +---
drivers/staging/sm750fb/sm750.h | 2 +-
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/sm750
The lynxfb_pci_probe always returned -ENODEV in case of error. Modify it
so that actual error code will be propogated to the caller.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 37 +
1 file changed, 17 insertions(+), 20 deletions(-)
dif
In case of error during lynxfb_pci_probe, the function returned without
calling pci_disable_device. Fix it by adding pci_disable_device on the
error cleanup path.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/
Hi All,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards moving gs_fpgaboot out of staging
in over a year. Are there any plans to clean it up and move it out soon?
Or it should be deleted?
Thanks,
Ksenija
31 matches
Mail list logo