Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote: > Split comment in order to fit into 80 characters per line. > Found by checkpatch.pl > > Signed-off-by: Ksenija Stanojevic > --- Instead of multiline maybe this is better: diff --git a/drivers/staging/panel/panel.c b/drivers/s

Re: [PATCH] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE()

On Wednesday, December 30, 2015 10:17:50 AM Sudip Mukherjee wrote: > On Sat, Dec 26, 2015 at 09:12:42PM -0800, Joshua Clayton wrote: > > running sparse on drivers/staging/lustre results in dozens of warnings: > > include/linux/gfp.h:281:41: warning: > > odd constant _Bool cast (40 becomes 1) >

Re: [PATCH] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE()

On Sat, Dec 26, 2015 at 09:12:42PM -0800, Joshua Clayton wrote: > running sparse on drivers/staging/lustre results in dozens of warnings: > include/linux/gfp.h:281:41: warning: > odd constant _Bool cast (40 becomes 1) > > Use "!!" to explicitly convert the result to bool range. > --- Signed-o

Re: [PATCH 3/6] Staging: gdm72xx: Add appropriate comment for spinlock_t definition

On Sun, Dec 27, 2015 at 02:44:42AM +0530, shraddha.6...@gmail.com wrote: > From: Shraddha Barke > > Fix checkpatch issue: "CHECK: spinlock_t definition without comment". > > Signed-off-by: Shraddha Barke > --- This will also not apply because of: 2bc29a1abc5c ("staging: gdm72xx: Replace timeva

Re: [PATCH 2/6] Staging: gdm72xx: Add space around that " "

On Sun, Dec 27, 2015 at 02:44:41AM +0530, shraddha.6...@gmail.com wrote: > From: Shraddha Barke > > Add missing space around that " " to follow linux kernel coding > style. Warning detected by checkpatch > > Signed-off-by: Shraddha Barke > --- This will not apply due to: 2bc29a1abc5c ("staging

Re: [PATCH 1/6] Staging: gdm72xx: Add space around that "+", "&" and "|"

On Sun, Dec 27, 2015 at 02:44:40AM +0530, shraddha.6...@gmail.com wrote: > From: Shraddha Barke Why are you adding this extra From: line here? You can fix your gitconfig file so that the From: header of the email will contain this information. regards sudip __

Re: [PATCH 1/5] staging: media: lirc: replace NULL comparisons with !var

On Fri, Dec 18, 2015 at 06:35:25PM +0530, Sudip Mukherjee wrote: > A NULL comparison can be written as if (var) or if (!var). > Reported by checkpatch. > > Signed-off-by: Sudip Mukherjee > --- Hi Mauro, A gentle ping. Can this series be considered for 4.5? regards sudip

Re: [PATCH 3/5] Staging: panel: Remove ULL

On Tue, Dec 29, 2015 at 03:59:26PM -0500, Ilia Mirkin wrote: > On Tue, Dec 29, 2015 at 3:08 PM, Ksenija Stanojevic > wrote: > > Remove ULL since it's useless. > > > > Signed-off-by: Ksenija Stanojevic > > --- > > drivers/staging/panel/panel.c | 12 ++-- > > 1 file changed, 6 insertions(+

Re: [PATCH 3/5] Staging: panel: Remove ULL

On Tue, Dec 29, 2015 at 3:08 PM, Ksenija Stanojevic wrote: > Remove ULL since it's useless. > > Signed-off-by: Ksenija Stanojevic > --- > drivers/staging/panel/panel.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/panel/panel.c b/drivers/st

[PATCH 5/5] Staging: panel: Make statement more readable

Broke statement into 3 different lines to make it more readable. Signeded-off-by: Ksenija Stanojevic --- drivers/staging/panel/panel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index 70cb9f3..207d8d5 1006

[PATCH 4/5] Staging: panel: Reduce value range for *name

out is 0-9 so it's too much for om, therefore reduce value range for *name from '0'-'9' to '0'-'7'. Signed-off-by: Ksenija Stanojevic --- drivers/staging/panel/panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.

[PATCH 3/5] Staging: panel: Remove ULL

Remove ULL since it's useless. Signed-off-by: Ksenija Stanojevic --- drivers/staging/panel/panel.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index 7138ee7..6dc3efb 100644 --- a/drivers/staging/pa

[PATCH 2/5] Staging: panel: Remove typedef pmask_t

Use __u64 instead of pmask_t and remove pmask_t since is useless. Signed-off-by: Ksenija Stanojevic --- drivers/staging/panel/panel.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index

[PATCH 1/5] Staging: panel: Use u8 type

Declare om, im, omask and imask as u8 to remove any confusion if that describes the 8 bits of the data bus on the parallel port. Also change return type of lcd_write_data() to u8. Signed-off-by: Ksenija Stanojevic --- drivers/staging/panel/panel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 d

[PATCH 0/5] Staging: panel: TODO fixes

This patchset is based on patch sent by Bijosh Thykkoottathil. Here I tried to address all suggestions made by Dan and Willy. Signed-off-by: Ksenija Stanojevic Ksenija Stanojevic (5): Staging: panel: Use u8 type Staging: panel: Remove typedef pmask_t Staging: panel: Remove ULL Staging: p

Re: On Lindent shortcomings and massive style fixing

On Tue, 29 Dec 2015, Andrey Utkin wrote: > On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab > wrote: > > IMHO, there are two problems by letting indent breaking long > > lines: > > > > 1) indent would break strings on printks. This is something that we don't > > want to break strings on m

Re: On Lindent shortcomings and massive style fixing

On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab wrote: > IMHO, there are two problems by letting indent breaking long > lines: > > 1) indent would break strings on printks. This is something that we don't > want to break strings on multiple lines in the Kernel; Yeah, GNU indent does its wo