This patch renames u8security to security to remove u8 prefix.
There is no need to add prefix in order to show data type of this
variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 inse
This patch renames pfConnectResult to connect_result to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000
This patch renames pstrStatistics to stats to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interf
This patch renames pJoinParams to join_params to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/host_i
This patch renames u8channel to channel to remove u8 prefix.
There is no need to add prefix in order to show data type of this
variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insert
wilc_free_join_params call kfree. There is no need to use
wrapper function, so use kfree directly.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 3 ---
drivers/staging/wilc1000/wilc_wfi_cfgopera
This patch renames ps8Rssi to rssi_level to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interf
This patch changes return type of wilc_disconnect from s32 to int.
The result variable gets return value from wilc_disconnect that has
return type of int. It should be changed return type of this function as
well as data type of result variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wi
This patch renames pvUserArg to user_arg to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interfac
This patch changes return type of wilc_set_join_req from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wil
This patch renames IEsLen to ies_len to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interfac
This patch renames tenuAuth_type to auth_type to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_int
This patch changes kmalloc/memcpy to kmemdup.
It is also added error checking to return -ENOMEM if kmemdup is failed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc
This patch changes return type of wilc_flush_join_req from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/w
This patch renames ssidLen to ssid_len to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interf
This patch renames u16ReasonCode to reason_code to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_int
This patch changes return type of wilc_get_rssi from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc100
This patch renames pu8IEs to ies to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b
This patch changes return type of wilc_get_statistics from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/w
This patch renames pu8ssid to ssid to remove pu8 prefix.
There is no need to add this prefix in order to show data type of this
variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 ins
This patch renames pu8bssid to bssid to remove pu8 prefix.
There is no need to add this prefix in order to show data type of this
variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 i
I kind of feel like we have started to err on the side of breaking
things up into too many patches. Linus has said the same thing...
This patch is not hard to review, except that the title was bad.
Originally it was sent as:
[PATCH] staging: wilc1000: fix bug in sdio/spi
which is the correct ti
This patch fixes a bug that return always 0 so it fails every time.
Fixes: c1af9db78950 ("staging: wilc1000: call linux_sdio_init instead of
io_init")
Signed-off-by: Glen Lee
---
Changes in v2: separate v1 patch into two patches.
---
drivers/staging/wilc1000/wilc_sdio.c | 2 --
1 file changed,
wilc_sdio_init return always 1, which is needless. Remove it and it's related
codes also.
Signed-off-by: Glen Lee
---
Changes in v2: separate v1 patch into two patches.
---
drivers/staging/wilc1000/wilc_sdio.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/wilc100
Removed all checkpatch.pl CHECKs that suggested to check NULL by
!obj instead of obj == NULL.
Signed-off-by: Chase Metzger
---
drivers/staging/android/sync.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/an
On 2015년 12월 24일 12:07, Julian Calaby wrote:
Hi Glen,
On Thu, Dec 24, 2015 at 2:06 PM, glen lee wrote:
On 2015년 12월 24일 11:39, Julian Calaby wrote:
Hi Glen,
On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee wrote:
wilc_sdio_init return always 1. It is needless, so just remove it and
it's
relate
Hi Glen,
On Thu, Dec 24, 2015 at 2:06 PM, glen lee wrote:
>
>
> On 2015년 12월 24일 11:39, Julian Calaby wrote:
>>
>> Hi Glen,
>>
>> On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee wrote:
>>>
>>> wilc_sdio_init return always 1. It is needless, so just remove it and
>>> it's
>>> related codes also.
>>>
>>
On 2015년 12월 24일 11:39, Julian Calaby wrote:
Hi Glen,
On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee wrote:
wilc_sdio_init return always 1. It is needless, so just remove it and it's
related codes also.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_sdio.c | 12
1 fil
Hi Glen,
On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee wrote:
> wilc_sdio_init return always 1. It is needless, so just remove it and it's
> related codes also.
>
> Signed-off-by: Glen Lee
> ---
> drivers/staging/wilc1000/wilc_sdio.c | 12
> 1 file changed, 12 deletions(-)
>
> diff --g
>On 2015/12/23, 14:40, "Simmons, James A." wrote:
>
>>>From: Niranjan Dighe
>>>
>>>Remove IOC_LIBCFS_MEMHOG ioctl functionality as it is no longer needed
>>>thereby
>>>making functions like - kportal_memhog_alloc(), kportal_memhog_free()
>>>and type -
>>>struct libcfs_device_userstate unused.
>>
On Fri, Dec 18, 2015 at 09:31:39AM +0300, Dan Carpenter wrote:
> Possible off by one, but mostly the whitespace makes me itch.
>
> Jim was not on the CC list.
>
> On Thu, Dec 17, 2015 at 07:24:15PM -0500, Jubin John wrote:
> > From: Jim Snow
> >
> > The link state will transition from ARMED to
On 2015/12/23, 14:40, "Simmons, James A." wrote:
>>From: Niranjan Dighe
>>
>>Remove IOC_LIBCFS_MEMHOG ioctl functionality as it is no longer needed
>>thereby
>>making functions like - kportal_memhog_alloc(), kportal_memhog_free()
>>and type -
>>struct libcfs_device_userstate unused.
>
>Actually
On 2015/12/23, 02:40, "Dighe, Niranjan (N.)" wrote:
>From: Niranjan Dighe
>
>Remove IOC_LIBCFS_MEMHOG ioctl functionality as it is no longer needed
>thereby
>making functions like - kportal_memhog_alloc(), kportal_memhog_free() and
>type -
>struct libcfs_device_userstate unused.
>
>Signed-off-by
>From: Niranjan Dighe
>
>Remove IOC_LIBCFS_MEMHOG ioctl functionality as it is no longer needed thereby
>making functions like - kportal_memhog_alloc(), kportal_memhog_free() and type
>-
>struct libcfs_device_userstate unused.
Actually so much more can be cleaned up. This work is also being done
The functon libcfs_kkuc_msg_put() returns -ENOSYS which is not
correct. Return -ENXIO instead if the kuc header is corrupt.
Signed-off-by: James Simmons
---
.../staging/lustre/lustre/obdclass/kernelcomm.c|4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stag
Cleanup the last white space issues in the kernel comm code.
Signed-off-by: James Simmons
---
.../lustre/lustre/include/uapi_kernelcomm.h| 10 +-
.../staging/lustre/lustre/obdclass/kernelcomm.c|2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers
Add in missing braces for libcfs_kkuc_group_put();.
Signed-off-by: James Simmons
---
.../staging/lustre/lustre/obdclass/kernelcomm.c|4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/kernelcomm.c
b/drivers/staging/lustre/lustre
Fix checkpatch.pl reports of NULL comparison in kernel_comm.c.
Signed-off-by: James Simmons
---
.../staging/lustre/lustre/obdclass/kernelcomm.c| 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/kernelcomm.c
b/driv
The group variable was converted to an unsigned int in
libcfs_kkuc_group_add() to avoid a potential overflow.
The variable group is used in other kernelcomm functions
so it makes sense to convert the rest of the group
variables to unsigned int.
Signed-off-by: James Simmons
---
.../lustre/lustre/
During the removal of the cfs wrappers the kg_sem semaphore
was handled incorrectly. We need to take a write lock when
writing data to the kkuc_groups. The libcfs_kkuc_group_foreach
needs to only take a read lock. This makes use match the
OpenSFS development branch.
Signed-off-by: James Simmons
-
From: frank zago
Split the kernel comm header in libcfs into two new headers
to handle both kernel space and user space for the lustre layer.
This is broken out of the original patch 14270. The part covered
by this change is as follows:
The original libcfs_kernelcomm.h header is split into three
Doing if (rc != 0) or if (rc == 0) is bad form. This patch corrects
kernelcomm.c to behavior according to kernel coding standards.
Signed-off-by: James Simmons
---
.../staging/lustre/lustre/obdclass/kernelcomm.c|6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/dri
From: Henri Doreau
Associate copytool registration to a given MDC import so that
multiple mounts of the same filesystem do not lead to having the
copytool registered multiple time.
Signed-off-by: Henri Doreau
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3882
Reviewed-on: http://review.wh
From: Hongchao Zhang
In struct kkuc_reg, the "kr_data" is difficult to be freed
outside of libcfs, then it's better to change it to be
inline data instead of the data pointer.
Signed-off-by: Hongchao Zhang
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6485
Reviewed-on: http://review.whamc
Add in missing space arouund '+' in the kernel_comm code.
Signed-off-by: James Simmons
---
.../lustre/lustre/include/uapi_kernelcomm.h|2 +-
.../staging/lustre/lustre/obdclass/kernelcomm.c|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lu
From: frank zago
Move the kernel portion from libcfs to obdclass. This code is
only used by lustre. This is broken out of the original patch
14270. The part covered by this change is as follows:
The original code in kernel_user_comm.c is split into two parts:
* obdclass/kernelcomm.c for the k
The kernel communication code used for HSM and changelog is
entangled. Move the user space bits into the liblustreapi. This will
also help for a possible relicensing. The kernel portion is also moved
from libcfs to obdclass.
The original libcfs_kernelcomm.h header is split into three parts:
* l
Fixup the comments to the linux kernel style for the source and
headers related to the kernel_comm work.
Signed-off-by: James Simmons
---
.../lustre/lustre/include/uapi_kernelcomm.h| 10 ++
.../staging/lustre/lustre/obdclass/kernelcomm.c| 12
2 files changed,
The hfi1_filter_array structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/staging/rdma/hfi1/diag.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/stagin
On the interrupt path, we repeatedly establish the pointer to the
storvsc_device. While the compiler does inline
get_in_stor_device() (and other static functions) in the call chain
in the interrupt path, the compiler is repeatedly inlining
the call to get_in_stor_device() each time it is invoked.
T
Properly support FC hosts. Additional cleanup patches are also
included.
V2: Comments from Dan Carpenter and
from Johannes Thumshirn addressed.
V3: Fixed build issues reported by kbuild test robot
V4: Addressed comments from Hannes and James.
K. Y. Srin
The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in Linux match
the Window's definition.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Johannes Thumshirn
Reviewed-by: Long Li
Reviewed-by: Hannes Reinecke
Tested-by: Alex Ng
---
drivers/scsi/storvsc_drv.c |5 ++---
1 files
The function storvsc_channel_init() repeatedly interacts with the host to
extract various channel properties. Refactor this code to eliminate code
repetition.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
Reviewed-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Tested-by: Alex Ng
-
For FC devices managed by this driver, atttach the appropriate transport
template. This will allow us to create the appropriate sysfs files for
these devices. With this we can publish the wwn for both the port and the node.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
Tested-by: Alex Ng
From: Fan Yong
Cleanup the a style issues for the lu_object_header_flags
enum by adding a comma for the last field. This is
broken out of patch http://review.whamcloud.com/6321.
Signed-off-by: Fan Yong
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2914
Reviewed-on: http://review.whamcloud
From: Fan Yong
Add the ability to debug LFSCK to libcfs. This is
broken out of patch http://review.whamcloud.com/6321.
Signed-off-by: Fan Yong
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2914
Reviewed-on: http://review.whamcloud.com/6321
Reviewed-by: Alex Zhuravlev
Reviewed-by: Andreas
From: frank zago
Adds __acquires / __releases / __must_hold sparse locking annotations to
several functions.
Fixes sparse warnings such as:
libcfs/libcfs/hash.c:127:1: warning: context imbalance in 'cfs_hash_spin_lock'
- wrong count at exit
libcfs/libcfs/hash.c:133:1: warning: context i
For UMP and SMP machines the struct cfs_cpt_table are
defined differently. In the case handled by this patch
nodemask is defined as a integer for the UMP case and
as a pointer for the SMP case. This will cause a problem
for ost_setup which reads the nodemask directly. Instead
we create a UMP versio
Remove libcfs function cfs_strncasecmp() since the kernel
already has its own strncasecmp(). Lastly remove from libcfs.h
cfs_get_blocked_sigs() since this function no longer exist.
Signed-off-by: James Simmons
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3963
Reviewed-on: http://review.wha
From: Niranjan Dighe
Remove IOC_LIBCFS_MEMHOG ioctl functionality as it is no longer needed thereby
making functions like - kportal_memhog_alloc(), kportal_memhog_free() and type -
struct libcfs_device_userstate unused.
Signed-off-by: Niranjan Dighe
---
.../lustre/include/linux/libcfs/libcfs_p
On Wed, Dec 23, 2015 at 02:33:29PM +0530, Niranjan Dighe wrote:
> From: Niranjan Dighe
>
> Remove IOC_LIBCFS_MEMHOG ioctl functionality as it is no longer needed thereby
> making functions like - kportal_memhog_alloc(), kportal_memhog_free() and
> type -
> struct libcfs_device_userstate unused.
From: Niranjan Dighe
Remove IOC_LIBCFS_MEMHOG ioctl functionality as it is no longer needed thereby
making functions like - kportal_memhog_alloc(), kportal_memhog_free() and type -
struct libcfs_device_userstate unused.
Signed-off-by: Niranjan Dighe
---
.../lustre/include/linux/libcfs/libcfs_p
62 matches
Mail list logo