Re: [PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection

2015-12-21 Thread SF Markus Elfring
>> 6. Apply a recommendation from the script "checkpatch.pl". > > That's 6 different things, shouldn't this be 6 different patches? > > please redo. Dan Carpenter requested to squash the previous update steps 5 and 6 into a single patch for better source code review. Now I see further software d

[PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

2015-12-21 Thread maomao xu
Fix up block comments to make a trailing */ on a separate line Signed-off-by: maomao xu --- drivers/staging/comedi/comedi.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index 66edda1..ec5e59c 100644 ---

Re: [staging:staging-testing 520/647] ERROR: "isa_io_base" [drivers/staging/comedi/drivers/adv_pci1760.ko] undefined!

2015-12-21 Thread Greg Kroah-Hartman
On Tue, Dec 22, 2015 at 01:17:33PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 2ce6bf2292742e0a4e71f08717ce314ce6332151 > commit: 14b93bb6bbf08c5002eddda1af1916e72e542eb8 [520/647] staging: comedi: > adv_

[staging:staging-testing 520/647] ERROR: "isa_io_base" [drivers/staging/comedi/drivers/adv_pci1760.ko] undefined!

2015-12-21 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 2ce6bf2292742e0a4e71f08717ce314ce6332151 commit: 14b93bb6bbf08c5002eddda1af1916e72e542eb8 [520/647] staging: comedi: adv_pci_dio: separate out PCI-1760 support config: microblaze-allmodconfig (attac

[PATCH v3 1/2] staging/rdma/hfi1: Clean up comments

2015-12-21 Thread Jubin John
From: Edward Mascarenhas Clean up comments by deleting numbering and terms internal to Intel. The information on the actual bugs is not deleted. Reviewed-by: Mike Marciniszyn Signed-off-by: Edward Mascarenhas Signed-off-by: Jubin John --- Changes in v2: - Added more information in co

[PATCH v3 0/2] Driver cleanup and misc fixes series 3

2015-12-21 Thread Jubin John
These patches were part of series: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-December/082248.html but did not apply cleanly to the staging-testing branch. Refreshed the remaining 2 patches against the latest staging-testing. Changes in v2: - Added more informa

[PATCH v3 2/2] staging/rdma/hfi1: Fix Xmit Wait calculation

2015-12-21 Thread Jubin John
From: Ira Weiny Total XMIT wait needs to sum the xmit wait values of all the VLs not just those requested in the query. Also, make the algorithm used for both PortStatus and PortDataCounters the same. Reviewed-by: Arthur Kepner Reviewed-by: Breyer, Scott J Signed-off-by: Ira Weiny Signed-off

[PATCH v3 5/6] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2015-12-21 Thread Jubin John
From: Vennila Megavannan Added the following per sdma engine stats: - SendDmaDescFetchedCnt - software maintained count of SDMA interrupts (SDmaInt, SDmaIdleInt, SDmaProgressInt) - software maintained counts of SDMA error cases Reviewed-by: Dennis Dalessandro Signed-off-by: Mike

[PATCH v3 6/6] staging/rdma/hfi1: Remove unneeded variable index

2015-12-21 Thread Jubin John
From: Dean Luick The variable "index" increments the same as dd->ndevcntrs. Just use the later. Remove uneeded usage of "index" in the fill loop - it is not used there or later in the function. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in

[PATCH v3 3/6] staging/rdma/hfi1: change krcvqs module parameter type from byte to uint

2015-12-21 Thread Jubin John
From: Mark F. Brown The krcvqs parameter is displayed incorrectly in sysfs. The workaround is to set the param type as uint. Reviewed-by: Mike Marciniszyn Reviewed-by: Mitko Haralanov Signed-off-by: Mark F. Brown Signed-off-by: Jubin John --- Changes in v2: - None Changes in v3:

[PATCH v3 2/6] staging/rdma/hfi1: Move s_sde to the read mostly portion of the hfi1_qp structure

2015-12-21 Thread Jubin John
From: Harish Chegondi This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send function when invoked from post_send thereby improving performance of post_send. Reviewed-by: Mike Marciniszyn Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- Changes in v2: - None

[PATCH v3 1/6] staging/rdma/hfi1: Use BIT macro

2015-12-21 Thread Jubin John
This patch fixes the checkpatch issue: CHECK: Prefer using the BIT macro Use of BIT macro for HDRQ_INCREMENT in chip.h causes a change in format specifier for error message in init.c in order to avoid a build warning. Reviewed-by: Dean Luick Reviewed-by: Ira Weiny Reviewed-by: Mike Marciniszyn

[PATCH v3 0/6] staging/rdma/hfi1: Driver cleanup and misc fixes

2015-12-21 Thread Jubin John
These patches were part of patch series: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-November/081566.html but did not apply cleanly to the staging-testing branch. Refreshed the remaining 6 patches against the latest staging-testing. Changes in v2: - 01/13: Updat

[PATCH v3 4/6] staging/rdma/hfi1: Change default krcvqs

2015-12-21 Thread Jubin John
Change the default number of krcvqs to number of numa nodes + 1 based on the performance data collected. Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- Changes in v2: - None Changes in v3: - Refreshed patch against latest staging-testing drivers/staging/rdma/hfi1/

Re: [PATCH RESEND 03/46] staging: wilc1000: rename index to tcp_pending_ack_idx

2015-12-21 Thread glen lee
Hi greg, On 2015년 12월 22일 06:17, Greg KH wrote: On Mon, Dec 21, 2015 at 02:18:07PM +0900, Glen Lee wrote: This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since this name could be confused index of txq_entry_t. It is index of tcp pending ack. It fixes 8e55639d066f4ef402

Re: staging: wilc1000: wilc_send_config_pkt: pass struct wilc

2015-12-21 Thread glen lee
Hi Dan On 2015년 12월 22일 01:05, Dan Carpenter wrote: Hello Glen Lee, This is a semi-automatic email about new static checker warnings. The patch ec62e6d1ec3f: "staging: wilc1000: wilc_send_config_pkt: pass struct wilc" from Nov 18, 2015, leads to the following Smatch complaint: drivers/stagin

[PATCH V5 1/2] staging/rdma/hfi1: add dd_dev_dbg

2015-12-21 Thread ira . weiny
From: Ira Weiny To be used in future patches add dd_dev_dbg. dd_* functions properly decode the hfi1_devdata structure used throughout the driver Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/hfi.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rdma/hfi1/hfi.

[PATCH V5 2/2] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-12-21 Thread ira . weiny
From: Dean Luick Correctly set half-swing for integrated devices. A0 needs all fields set for CcePcieCtrl. B0 and later only need a few fields set. Reviewed-by: Stuart Summers Signed-off-by: Dean Luick Signed-off-by: Ira Weiny --- Changes from V1: Add comments concerning the very l

[PATCH V5 0/2] staging/rdma/hfi1: set Gen 3 half-swing for integrated devices.

2015-12-21 Thread ira . weiny
From: Ira Weiny This was a single patch before. The change to dev_dbg required a precursor patch to add the dd_dev_dbg which is consistent with the other dev_* macros which automatically use struct hfi1_devdata. Changes from V4: Fix build error which arose from other patches being accep

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

2015-12-21 Thread gre...@linuxfoundation.org
On Mon, Dec 21, 2015 at 07:19:43PM -0500, ira.weiny wrote: > On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundation.org wrote: > > On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote: > > > Greg, Doug, > > > > > > As mentioned below, these patches depend on the new rdmavt library

Re: [PATCH V2] staging: dgnc: Creating and destroying sysfs files properly

2015-12-21 Thread Greg KH
On Tue, Dec 22, 2015 at 01:43:54AM +0100, Salah Triki wrote: > Hi, > > How to decide if an information should be exported or not to user space ? Why does no other serial driver need this? Odds are, there are already other ways to get this information and the driver authors were just "lazy" or di

[PATCH 13/13] staging: wilc1000: rename pu8MacAddress in wilc_set_mac_address

2015-12-21 Thread Chaehyun Lim
This patch changes pu8MacAddress to mac_addr to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_in

[PATCH 07/13] staging: wilc1000: fix return type of wilc_set_pmkid_info

2015-12-21 Thread Chaehyun Lim
This patch changes return type of wilc_set_pmkid_info from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/w

[PATCH 11/13] staging: wilc1000: rename pu8MacAddress in wilc_get_mac_address

2015-12-21 Thread Chaehyun Lim
This patch changes pu8MacAddress to mac_addr to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_inte

[PATCH 12/13] staging: wilc1000: fix return type of wilc_set_mac_address

2015-12-21 Thread Chaehyun Lim
This patch changes return type of wilc_set_mac_address from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/

[PATCH 08/13] staging: wilc1000: replace u32 with int

2015-12-21 Thread Chaehyun Lim
The data type of variable i changes u32 to int. It is used as array index to copy some data with memcpy function so that it is better to use data type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 10/13] staging: wilc1000: fix return type of wilc_get_mac_address

2015-12-21 Thread Chaehyun Lim
This patch changes return type of wilc_get_mac_address from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/

[PATCH 09/13] staging: wilc1000: rename pu8PmkidInfoArray in wilc_set_pmkid_info

2015-12-21 Thread Chaehyun Lim
This patch changes pu8PmkidInfoArray to pmkid to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host

[PATCH 05/13] staging: wilc1000: remove wilc_add_tx_gtk declaration

2015-12-21 Thread Chaehyun Lim
This patch deletes wilc_add_tx_gtk declaration. It is not find wilc_add_tx_gtk definition in this driver. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wi

[PATCH 04/13] staging: wilc1000: match argument name of wilc_add_rx_gtk declaration

2015-12-21 Thread Chaehyun Lim
Some argument name of wilc_add_rx_gtk declaration is different to those of this function definition. It is changed as same name of this function declaration and definition. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 8 1 file changed, 4 insertions(+), 4

[PATCH 06/13] staging: wilc1000: remove wilc_set_start_scan_req declaration

2015-12-21 Thread Chaehyun Lim
This patch deletes wilc_set_start_scan_req declaration. It is not find wilc_set_start_scan_req definition in this driver. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.h b/driv

[PATCH 01/13] staging: wilc1000: fix return type of wilc_add_pkt declaration

2015-12-21 Thread Chaehyun Lim
This patch changes return type of wilc_add_pkt declaration from s32 to int. The return type of this function declaration and definition should be same as data type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 03/13] staging: wilc1000: fix return type of wilc_add_rx_gtk declaration

2015-12-21 Thread Chaehyun Lim
This patch changes return type of wilc_add_rx_gtk declaration from s32 to int. The return type of this function declaration and definition should be same as data type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 02/13] staging: wilc1000: match argument name of wilc_add_ptk declaration

2015-12-21 Thread Chaehyun Lim
Some arguments name of wilc_add_pkt declaration is different to those of this function definition. It is changed as same name of this function declaration and definition. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 6 +++--- 1 file changed, 3 insertions(+), 3 dele

Re: [PATCH V2] staging: dgnc: Creating and destroying sysfs files properly

2015-12-21 Thread Salah Triki
Hi, How to decide if an information should be exported or not to user space ? best regards -- salah triki On Mon, Dec 21, 2015 at 03:52:26PM -0800, Greg KH wrote: > On Fri, Dec 18, 2015 at 11:57:18AM +0100, Salah Triki wrote: > > Delegate creation and destruction of sysfs files to device > > and

Re: [lustre-devel] [PATCH] staging: lustre: Handle nodemask on UMP machines

2015-12-21 Thread Dilger, Andreas
On 2015/12/21, 15:08, "lustre-devel on behalf of Greg Kroah-Hartman" wrote: >On Sun, Nov 08, 2015 at 11:34:55AM -0500, James Simmons wrote: >> For UMP and SMP machines the struct cfs_cpt_table are >> defined differently. In the case handled by this patch >> nodemask is defined as a integer for th

Re: [PATCH v2 0/5] Clean up SDMA engine code

2015-12-21 Thread ira.weiny
On Mon, Dec 21, 2015 at 04:13:49PM -0800, gre...@linuxfoundation.org wrote: > On Mon, Dec 21, 2015 at 06:48:03PM -0500, ira.weiny wrote: > > On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > Various improvements to the SDMA engine code. > > >

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

2015-12-21 Thread ira.weiny
On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundation.org wrote: > On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote: > > Greg, Doug, > > > > As mentioned below, these patches depend on the new rdmavt library > > submitted to > > Doug on linux-rdma. > > > > We continue to iden

Re: [PATCH v2 0/5] Clean up SDMA engine code

2015-12-21 Thread Greg KH
On Mon, Dec 21, 2015 at 06:48:03PM -0500, ira.weiny wrote: > On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Various improvements to the SDMA engine code. > > Greg, > > Thanks for reviewing and accepting our patches to staging-testing. I > apol

Re: [PATCH] comedi/comedilib.h: cleanup coding style

2015-12-21 Thread Greg KH
On Tue, Dec 15, 2015 at 12:34:11AM +0400, George Kobiashvili wrote: > Signed-off-by: George Kobiashvili > --- > drivers/staging/comedi/comedilib.h | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) Doesn't apply to my tree :( __

Re: [PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

2015-12-21 Thread Greg KH
On Mon, Dec 14, 2015 at 03:41:10PM +0800, maomao xu wrote: > Fix up block comments to make a trailing */ on a separate line > > Signed-off-by: maomao xu > --- > drivers/staging/comedi/comedi.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Doesn't apply to my tree :(

Re: [PATCH] Staging: dgnc: dgnc_neo.c: Coding Style issue (should be space before asterisk).

2015-12-21 Thread Greg KH
On Sun, Nov 15, 2015 at 12:01:10AM +0530, Nizam Haider wrote: > Patch will add a space in commentary line. > > Signed-off-by: Nizam Haider > --- > drivers/staging/dgnc/dgnc_neo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Doesn't apply to my tree :( _

Re: [PATCH V2] staging: dgnc: Creating and destroying sysfs files properly

2015-12-21 Thread Greg KH
On Fri, Dec 18, 2015 at 11:57:18AM +0100, Salah Triki wrote: > Delegate creation and destruction of sysfs files to device > and driver layers in order to eliminate races. Why are these files even present at all? They should not be needed, and can be removed instead. thanks, greg k-h ___

Re: [PATCH v3 1/5] Staging: dgnc: dgnc_neo.c: usleep_range is preferred over udelay

2015-12-21 Thread Greg KH
On Sat, Nov 14, 2015 at 08:10:42PM +0530, Nizam Haider wrote: > Fix ceckpatch warning spelling? > > Signed-off-by: Nizam Haider > --- > drivers/staging/dgnc/dgnc_neo.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers

Re: [PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection

2015-12-21 Thread Greg Kroah-Hartman
On Mon, Dec 21, 2015 at 08:12:12PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 21 Dec 2015 18:58:51 +0100 > > A few checks would be performed by the mgc_process_recover_log() function > even though it was determined that the passed variable "pages" contained > a null point

Re: [PATCH v2 0/5] Clean up SDMA engine code

2015-12-21 Thread ira.weiny
On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote: > From: Ira Weiny > > Various improvements to the SDMA engine code. Greg, Thanks for reviewing and accepting our patches to staging-testing. I apologize for the conflicts we had between the 3 of us submitting. However, in at

Re: [PATCH] staging: lustre: This patch fixes the following sparse warning:

2015-12-21 Thread Greg KH
On Fri, Dec 11, 2015 at 04:08:53PM +0800, Jandy Gou wrote: > drivers/staging/lustre/lustre/osc/osc_cache.c:622:19: warning: symbol > 'osc_extent_find' was not declared. Should it be static? > drivers/staging/lustre/lustre/osc/osc_cache.c:1423:6: warning: symbol > 'osc_unreserve_grant' was not decla

Re: [PATCH] staging: lustre/lustre/libcfs: Fix type mismatch reported by sparse

2015-12-21 Thread Greg Kroah-Hartman
On Wed, Dec 09, 2015 at 10:38:13PM +0530, Niranjan Dighe wrote: > The third argument to function kportal_memhog_alloc is expected to > be gfp_t whereas the actual argument was unsigned int. Fix this by > explicitly typecasting to gfp_t > > Signed-off-by: Niranjan Dighe > --- > drivers/staging/lu

Re: [PATCH v2 0/6] Patch series to make lustre safe(r) for W=1 compiles

2015-12-21 Thread Greg KH
On Fri, Dec 11, 2015 at 06:04:19PM -0500, Valdis Kletnieks wrote: > Start of a batch series to clean up the Lustre tree. Other people have > done some sparse and checkpatch cleanups, but I found a bunch of > stuff building with W=1. There's probably more, but this was the > really low-hanging obvio

Re: [PATCH 00/40] Sync upstream lustre client LNet core

2015-12-21 Thread Greg Kroah-Hartman
On Fri, Nov 20, 2015 at 06:35:36PM -0500, James Simmons wrote: > This is the majority of the fixes that have gone into the LNet layer. > Outside a few remaining patches this brings LNet close to what is > running in production world wide. > > This patch series needs the remove IOC_LIBCFS_PING_TEST

Re: [PATCH 00/13] bring lustre's kernel_comm code up to date

2015-12-21 Thread Greg Kroah-Hartman
On Sun, Nov 08, 2015 at 02:17:05PM -0500, James Simmons wrote: > This patch series brings the kernel_comm code used by Lustre up > to the latest verison with various fixes and style improvements > which makes the code compliant with the linux kernel standard. This series does not apply, please reb

[PATCH] rtlwifi: rtl_pci: Fix kernel panic

2015-12-21 Thread Larry Finger
In commit 38506ecefab9 (rtlwifi: rtl_pci: Start modification for new drivers), a bug was introduced that causes a NULL pointer dereference. As this bug only affects the infrequently used RTL8192EE and only under low-memory conditions, it has taken a long time for the bug to show up. The bug was re

Re: [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl

2015-12-21 Thread Greg Kroah-Hartman
On Mon, Dec 21, 2015 at 02:18:18PM -0800, Linus Torvalds wrote: > On Mon, Dec 21, 2015 at 2:06 PM, Greg Kroah-Hartman > wrote: > > > > No one told me it fixed a bug, let me see if it's still even needed... > > You were definitely cc'd on a couple of the threads.. > > But it's done now (well, two

Re: [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl

2015-12-21 Thread Linus Torvalds
On Mon, Dec 21, 2015 at 2:06 PM, Greg Kroah-Hartman wrote: > > No one told me it fixed a bug, let me see if it's still even needed... You were definitely cc'd on a couple of the threads.. But it's done now (well, two weeks ago), I applied it as commit d035e336287b ("staging/lustre: remove IOC_LI

RE: [PATCH 1/1] Drivers: hv: vmbus: Add vendor and device atttributes

2015-12-21 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, December 21, 2015 1:15 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com > Subj

Re: [PATCH] staging: lustre: Handle nodemask on UMP machines

2015-12-21 Thread Greg Kroah-Hartman
On Sun, Nov 08, 2015 at 11:34:55AM -0500, James Simmons wrote: > For UMP and SMP machines the struct cfs_cpt_table are > defined differently. In the case handled by this patch > nodemask is defined as a integer for the UMP case and > as a pointer for the SMP case. This will cause a problem > for os

Re: [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl

2015-12-21 Thread Greg Kroah-Hartman
On Fri, Nov 27, 2015 at 04:31:39AM +, Dilger, Andreas wrote: > On 2015/11/08, 09:34, "James Simmons" wrote: > > >The ioctl IOC_LIBCFS_PING_TEST has not been used in > >ages. The recent nidstring changes which moved all > >the nidstring operations from libcfs to the LNet > >layer but this ioct

Re: [PATCH] staging: lustre: export cfs_str2mask

2015-12-21 Thread Greg Kroah-Hartman
On Sun, Nov 08, 2015 at 11:34:59AM -0500, James Simmons wrote: > We need cfs_str2mask exported for our server code. > Even with the server code not available upstream > it would be nice to use the upstream code on Lustre > servers. Nope, sorry, we don't export symbols for any non-in-tree users, th

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

2015-12-21 Thread gre...@linuxfoundation.org
On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote: > Greg, Doug, > > As mentioned below, these patches depend on the new rdmavt library submitted > to > Doug on linux-rdma. > > We continue to identify (and rework) patches by our other developers which can > be submitted without conflicts

Re: [PATCH v2 05/17] staging/rdma/hfi1: Clean up comments

2015-12-21 Thread Greg KH
On Tue, Dec 01, 2015 at 03:38:14PM -0500, Jubin John wrote: > From: Edward Mascarenhas > > Clean up comments by deleting numbering and terms internal to Intel. > > The information on the actual bugs is not deleted. > > Reviewed-by: Mike Marciniszyn > Signed-off-by: Edward Mascarenhas > Signed

Re: [PATCH v4 2/2] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-12-21 Thread Greg KH
On Tue, Dec 01, 2015 at 02:47:57PM -0500, ira.we...@intel.com wrote: > From: Dean Luick > > Correctly set half-swing for integrated devices. A0 needs all fields set for > CcePcieCtrl. B0 and later only need a few fields set. > > Reviewed-by: Stuart Summers > Signed-off-by: Dean Luick > Signe

Re: [PATCH v2 01/13] staging/rdma/hfi1: Use BIT macro

2015-12-21 Thread Greg KH
On Mon, Nov 16, 2015 at 09:59:23PM -0500, Jubin John wrote: > This patch fixes the checkpatch issue: > CHECK: Prefer using the BIT macro > > Use of BIT macro for HDRQ_INCREMENT in chip.h causes a change in > format specifier for error message in init.c in order to avoid a > build warning. > > Rev

[PATCH 1/1] Drivers: hv: vmbus: Cleanup vmbus_set_event()

2015-12-21 Thread K. Y. Srinivasan
Cleanup vmbus_set_event() by inlining the hypercall to post the event and since the return value of vmbus_set_event() is not checked, make it void. As part of this cleanup, get rid of the function hv_signal_event() as it is only callled from vmbus_set_event(). Signed-off-by: K. Y. Srinivasan ---

[PATCH] staging: octeon-ethernet: fix TCP/UDP checksum calc

2015-12-21 Thread Hamish Martin
If the network portion of a frame is preceded by more than 14 bytes of data, the checksum calculated in the HW is done over the wrong data and is put in the wrong place. In our use case an Octeon ethernet controller is connected to a Broadcom switch chip. Extra data is included in the frame prior t

RE: [PATCH 3/3] Drivers: hv: vmbus: Cleanup vmbus_set_event()

2015-12-21 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, December 21, 2015 1:10 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com > Subj

Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup()

2015-12-21 Thread Greg Kroah-Hartman
On Mon, Dec 21, 2015 at 12:46:51AM +0300, Alexey Khoroshilov wrote: > If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(), > it calls release_bus() and continues execution. But it leads to double > release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex. > > Found by

Re: [PATCH RESEND 03/46] staging: wilc1000: rename index to tcp_pending_ack_idx

2015-12-21 Thread Greg KH
On Mon, Dec 21, 2015 at 02:18:07PM +0900, Glen Lee wrote: > This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since > this name could be confused index of txq_entry_t. It is index of tcp pending > ack. > > It fixes 8e55639d066f4ef402ba88fca08ed1be70e1c4da You didn't describe

Re: [PATCH 1/1] Drivers: hv: vmbus: Add vendor and device atttributes

2015-12-21 Thread Greg KH
On Thu, Dec 17, 2015 at 03:51:29PM -0800, K. Y. Srinivasan wrote: > Add vendor and device attributes to VMBUS devices. These will be used > by Hyper-V tools as well user-level RDMA libraries that will use the > vendor/device tuple to discover the RDMA device. > > Signed-off-by: K. Y. Srinivasan >

Re: [PATCH 3/3] Drivers: hv: vmbus: Cleanup vmbus_set_event()

2015-12-21 Thread Greg KH
On Tue, Dec 15, 2015 at 04:27:28PM -0800, K. Y. Srinivasan wrote: > > Signed-off-by: K. Y. Srinivasan No changelog text? Sorry, I can't take this :( You know better... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverpr

RE: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-21 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Monday, December 21, 2015 8:28 AM > To: KY Srinivasan ; Hannes Reinecke ; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; > jbo

[PATCH v2 4/4] staging: lustre: Fix a jump label position in osc_get_info()

2015-12-21 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 21 Dec 2015 19:30:42 +0100 The script "checkpatch.pl" pointed out that labels should not be indented. Thus delete a horizontal tab before the jump label "out" in the function "osc_get_info". Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/osc/osc

[PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection

2015-12-21 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 21 Dec 2015 18:58:51 +0100 A few checks would be performed by the mgc_process_recover_log() function even though it was determined that the passed variable "pages" contained a null pointer or a call of the alloc_page() function failed. 1. Let us return directly if

[PATCH v2 2/4] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover_log()

2015-12-21 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 21 Dec 2015 18:24:45 +0100 The variable "mne_swab" will eventually be set to an appropriate value from a call of the ptlrpc_rep_need_swab() function. Thus let us omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/staging

[PATCH v2 1/4] staging: lustre: Delete unnecessary goto statements in six functions

2015-12-21 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 21 Dec 2015 18:15:45 +0100 Six goto statements referred to a source code position directly behind them. Thus omit such unnecessary jumps. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/l

[PATCH v2 0/4] staging-Lustre: Fine-tuning for some function implementations

2015-12-21 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 21 Dec 2015 20:00:02 +0100 Several update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete unnecessary goto statements in six functions Delete an unnecessary variable initialisation in mgc_process_recover_log()

[PATCH 1/1] Drivers: hv: vmbus: fix the building warning with hyperv-keyboard

2015-12-21 Thread K. Y. Srinivasan
From: Dexuan Cui With the recent change af3ff643ea91ba64dd8d0b1cbed54d44512f96cd (Drivers: hv: vmbus: Use uuid_le type consistently), we always get this warning: CC [M] drivers/input/serio/hyperv-keyboard.o drivers/input/serio/hyperv-keyboard.c:427:2: warning: missing braces around in

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-21 Thread James Bottomley
On Sat, 2015-12-19 at 02:28 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Friday, December 18, 2015 8:48 AM > > To: KY Srinivasan ; Hannes Reinecke < > > h...@suse.de>; > > gre...@linuxfoundation

re: staging: wilc1000: wilc_send_config_pkt: pass struct wilc

2015-12-21 Thread Dan Carpenter
Hello Glen Lee, This is a semi-automatic email about new static checker warnings. The patch ec62e6d1ec3f: "staging: wilc1000: wilc_send_config_pkt: pass struct wilc" from Nov 18, 2015, leads to the following Smatch complaint: drivers/staging/wilc1000/host_interface.c:356 handle_set_wfi_drv_han

RE: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-21 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Friday, December 18, 2015 9:14 AM > To: Hannes Reinecke ; KY Srinivasan ; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; > jbo