On Mon, Dec 14, 2015 at 07:08:08PM -0500, Sanidhya Solanki wrote:
> The original code defined macros in the source code, making it
> harder to read. Moved them to the header file, as per the TODO file.
>
> Updated the TODO file.
I think the TODO file should not be updated now. There are still som
From: Mitko Haralanov
This commit "flips the switch" on the TID caching feature
implemented in this patch series.
As well as enabling the new feature by tying the new function
with the PSM API, it also cleans up the old unneeded code,
data structure members, and variables.
Due to difference in
From: Mitko Haralanov
Functions added by this patch are building blocks for the upcoming
TID caching functionality. The functions added are currently unsed
(and marked as such.)
The functions' purposes are to find physically contigous pages in
the user's virtual buffer, program the RcvArray grou
From: Mitko Haralanov
The previous patch in the series added the free/invalidate
function bodies. Now, it's time for the programming side.
This large function takes the user's buffer, breaks it up
into manageable chunks, allocates enough RcvArray groups
and programs the chunks into the RcvArray
From: Mitko Haralanov
Definitions and functions use to manage sets of TID/RcvArray groups.
These will be used by the TID cacheline functionality coming with
later patches.
TID groups (or RcvArray groups) are groups of TID/RcvArray entries
organized in sets of 8 and aligned on cacheline boundarie
From: Mitko Haralanov
The upcoming TID caching feature requires different data
structures and, by extension, different initialization for each
of the MPI processes.
The two new functions (currently unused) perform the required
initialization and freeing of required resources and structures.
Rev
From: Mitko Haralanov
Up to now, the functions which cleared the programmed
TID entries and gave PSM the list of invalidated TID entries
were just stubs. With this commit, the bodies of these
functions are added.
This commit is a bit asymmetric as it only contains the
free code path. This is don
From: Mitko Haralanov
There is no need to use a separate variable for a
return value and a label when returning right away
would do just as well.
Reviewed-by: Ira Weiny
Signed-off-by: Mitko Haralanov
---
drivers/staging/rdma/hfi1/file_ops.c | 11 ---
1 file changed, 4 insertions(+), 7
From: Mitko Haralanov
In preparation for adding the TID caching support, there is a set
of headers, structures, and variables which will be needed. This
commit adds them to the hfi.h header file.
Reviewed-by: Ira Weiny
Signed-off-by: Mitko Haralanov
---
drivers/staging/rdma/hfi1/hfi.h | 20 ++
From: Mitko Haralanov
The exp_lock lock does not need to be a spinlock as
all its uses are in process context and allowing the
process to sleep when the mutex is contended might
be benefitial.
Reviewed-by: Ira Weiny
Signed-off-by: Mitko Haralanov
---
drivers/staging/rdma/hfi1/file_ops.c | 12
From: Mitko Haralanov
TID caching will rely on the MMU notifier to be told
when memory is being invalidated. When the callback
is called, the driver will find all RcvArray entries
that span the invalidated buffer and "schedule" them
to be freed by the PSM library.
This function is currently unus
From: Mitko Haralanov
TID caching will use a new event to signal userland that cache
invalidation has occurred and needs a matching command code that
will be used to read the invalidated TIDs.
Add the event bit and the new command to the exported header file.
The command is also added to the sw
From: Mitko Haralanov
Convert bit definitions to use BIT() macro as per checkpatch.pl
requirements.
Reviewed-by: Ira Weiny
Signed-off-by: Mitko Haralanov
---
include/uapi/rdma/hfi/hfi1_user.h | 56 +++
1 file changed, 28 insertions(+), 28 deletions(-)
diff
From: Mitko Haralanov
The HFI1_CAP_TID_UNMAP comment was incorrectly implying the
opposite of what capability actually did. Correct this error.
Reviewed-by: Ira Weiny
Signed-off-by: Mitko Haralanov
---
include/uapi/rdma/hfi/hfi1_user.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
From: Mitko Haralanov
Add mmu notify helper functions and TID caching function
stubs in preparation for the TID caching implementation.
TID caching makes use of the MMU notifier to allow the driver
to respond to the user freeing memory which is allocated to
the HFI.
This patch implements the ba
From: Ira Weiny
Expected receives work by user-space libraries (PSM) calling into the driver
with information about the user's receive buffer and have the driver DMA-map
that buffer and program the HFI to receive data directly into it.
This is an expensive operation as it requires the driver to
On Tue, Dec 15, 2015 at 04:00:34PM +0100, SF Markus Elfring wrote:
> > If you were a lustre dev then I would accept these renames definitely.
>
> I find this information interesting.
> Would any more contributors like to share their opinion?
>
>
> > I do not think I have been unfair to you.
>
>
From: Haiyang Zhang
Date: Wed, 16 Dec 2015 19:20:44 +
> In our test, we have bisected and found the following patch introduced big
> overhead into skb_flow_dissect_flow_keys(), and caused performance
> regression:
> commit: d34af823
> net: Add VLAN ID to flow_keys
NEVER _EVER_ work around
This patch fixes following compiler warning:
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c: In function
‘RxReorderIndicatePacket’:
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:758:1: warning: the
frame size of 1064 bytes is larger than 1024 bytes
[-Wframe-larger-than=]
It replaces the st
On Wed, Dec 16, 2015 at 08:55:45PM +, Okash Khawaja wrote:
> Compiling drivers/staging/rtl8192u/ gives following compiler warning:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c: In function
> ‘RxReorderIndicatePacket’:
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:758:1: warning:
Compiling drivers/staging/rtl8192u/ gives following compiler warning:
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c: In function
‘RxReorderIndicatePacket’:
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:758:1: warning: the
frame size of 1064 bytes is larger than 1024 bytes
[-Wframe-larger-t
On Wed, 2015-12-16 at 19:20 +, Haiyang Zhang wrote:
> > -Original Message-
> > From: Eric Dumazet [mailto:eric.duma...@gmail.com]
> > Sent: Wednesday, December 16, 2015 12:08 PM
> >
> > This looks very very wrong to me.
> >
> > How many times this is called per second, for the 'one fl
On Wed, Dec 16, 2015 at 10:42 AM, Ian Abbott wrote:
> On 12/12/15 17:09, Moritz König wrote:
>>
>> This patch makes plx9080.h use kernel types.
>>
>> Signed-off-by: Moritz König
>> Signed-off-by: Fabian Lang
>> ---
>> drivers/staging/comedi/drivers/plx9080.h | 2 +-
>> 1 file changed, 1 inser
> -Original Message-
> From: Eric Dumazet [mailto:eric.duma...@gmail.com]
> Sent: Wednesday, December 16, 2015 12:08 PM
>
> This looks very very wrong to me.
>
> How many times this is called per second, for the 'one flow' case ?
>
> Don't you use TSO in this driver ?
>
> What about enc
On 12/16/2015 09:34 PM, Sergei Shtylyov wrote:
To avoid performance overhead when using skb_flow_dissect_flow_keys(),
we switch to the simple parsers to get the IP and port numbers.
Performance comparison: throughput (Gbps):
Number of connections, before patch, after patch
18.56
On 12/12/15 17:09, Moritz König wrote:
This patch makes plx9080.h use kernel types.
Signed-off-by: Moritz König
Signed-off-by: Fabian Lang
---
drivers/staging/comedi/drivers/plx9080.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/plx9080.
On 12/12/15 17:09, Moritz König wrote:
This patch adds spaces around binary operators in plx9080.h.
Signed-off-by: Moritz König
Signed-off-by: Fabian Lang
---
drivers/staging/comedi/drivers/plx9080.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/
On 12/12/15 17:09, Moritz König wrote:
This patch fixes the format of comments in plx9080.h.
Signed-off-by: Moritz König
Signed-off-by: Fabian Lang
---
drivers/staging/comedi/drivers/plx9080.h | 132 ++-
1 file changed, 95 insertions(+), 37 deletions(-)
diff --g
Hello.
On 12/16/2015 09:03 PM, Haiyang Zhang wrote:
To avoid performance overhead when using skb_flow_dissect_flow_keys(),
we switch to the simple parsers to get the IP and port numbers.
Performance comparison: throughput (Gbps):
Number of connections, before patch, after patch
1
On Wed, 2015-12-16 at 10:03 -0800, Haiyang Zhang wrote:
> To avoid performance overhead when using skb_flow_dissect_flow_keys(),
> we switch to the simple parsers to get the IP and port numbers.
>
> Performance comparison: throughput (Gbps):
> Number of connections, before patch, after patch
> 1
To avoid performance overhead when using skb_flow_dissect_flow_keys(),
we switch to the simple parsers to get the IP and port numbers.
Performance comparison: throughput (Gbps):
Number of connections, before patch, after patch
1 8.5610.18
4 1
On Tue, Dec 15, 2015 at 09:22:56AM -0800, Dmitry Torokhov wrote:
> On Tue, Dec 15, 2015 at 5:30 AM, Gustavo Padovan wrote:
> > 2015-12-14 Dmitry Torokhov :
> >
> >> Userspace can close the sync device while there are still active fence
> >> points, in which case kernel produces the following warni
On Tue, Dec 15, 2015 at 11:08:01AM -0800, Dmitry Torokhov wrote:
> On Tue, Dec 15, 2015 at 11:00 AM, Gustavo Padovan wrote:
> > 2015-12-15 Daniel Vetter :
> >
> >> On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote:
> >> > Userspace can close the sync device while there are still acti
Fixed four spelling errors.
Signed-off-by: Jiading Gai
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
index ec
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> ...
> >> @@ -109,7 +109,7 @@ static unsigned int hvt_op_poll(struct file *file,
> >> poll_table *wait)
> >>poll_wait(file, &hvt->outmsg_q, wait);
> >>
> >>if (hvt->mode == HVUTIL_TRANSPORT_DESTROY)
> >> - return -EBADF;
> >> +
Dexuan Cui writes:
>> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf
>> Of K. Y. Srinivasan
>> Sent: Wednesday, December 16, 2015 8:27
>> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
>> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.co
Op 15-12-15 om 18:19 schreef Dmitry Torokhov:
> On Tue, Dec 15, 2015 at 2:01 AM, Maarten Lankhorst
> wrote:
>> Op 15-12-15 om 02:29 schreef Dmitry Torokhov:
>>> Userspace can close the sync device while there are still active fence
>>> points, in which case kernel produces the following warning:
>
37 matches
Mail list logo
