On Fri, Nov 20, 2015 at 06:35:39PM -0500, James Simmons wrote:
> From: Chris Horn
>
> We consider routes "down" if the router is down or the router
> NI for the target network is down. This should be reflected
> in the output of /proc/sys/lnet/routes
>
> Signed-off-by: Chris Horn
> Intel-bug-id
On Fri, Nov 20, 2015 at 06:35:38PM -0500, James Simmons wrote:
> From: Sebastien Buisson
>
> Fix 'NULL pointer dereference' defects found by Coverity version
> 6.5.3:
> Dereference after null check (FORWARD_NULL)
> For instance, Passing null pointer to a function which dereferences
> it.
> Derefe
On Wed, Dec 2, 2015 at 12:30 PM, Sudip Mukherjee
wrote:
> On Wed, Dec 02, 2015 at 08:39:10AM +0530, punit vara wrote:
>> On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee
>> wrote:
>> > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote:
>> >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote
On Wed, Dec 02, 2015 at 08:39:10AM +0530, punit vara wrote:
> On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee
> wrote:
> > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote:
> >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote:
> >> >
> >> >
> >> > On 2015년 11월 09일 18:05, punit vara wrote
On Wed, Dec 02, 2015 at 10:32:49AM +0530, Sudip Mukherjee wrote:
> By "common exit path" do you mean mixing up of success and error paths?
Normally it's just the error paths which are mixed together. Back in
the day, this unisys driver had tons of error handling bugs so that I
didn't even bother
From: Ira Weiny
Rather than have a switch in a large else clause make the parameter checks
return immediately.
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 348 +++
1 file changed, 173 insertions(+), 175
From: Dennis Dalessandro
Now that the spinlock is not taken throughout hfi1_ioctl it is safe to return
early rather than setting a variable and falling through the switch.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
Changes from V1:
Sq
From: Ira Weiny
sizeof should use the variable rather than the struct definition to ensure that
type changes are properly accounted for.
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rdma/hfi1/d
From: Ira Weiny
Set link state is not supported remove from the switch statement and allow the
default to return -ENOTTY
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
Changes from v1:
Just remove the check for SETLINKSTATE and allow the switch to default
to -E
From: Ira Weiny
physState, linkState, and devState should be phys_state, link_state, and
dev_state
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/dri
From: Ira Weiny
Fix line alignment in various places as caught by checkpatch --strict.
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma/hfi1
From: Ira Weiny
Add or remove whitespace according to checkpatch --strict
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 30 ++
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma/h
From: Dennis Dalessandro
This patch avoids issues while calling into copy from/to user while holding the
lock by only taking the lock when it is absolutely required.
The only commands which require the snoop lock are: *Set Filter *Clear Filter
*Clear Queue
Reviewed-by: Mike Marciniszyn
Signed-
From: Ira Weiny
Else statements should continue using braces even if there is only 1 line in
the block. Found by checkpatch --strict
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rdma/hfi
From: Ira Weiny
Final clean up of the if/then/else clause for the parameter checks of
hfi1_ioctl
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
Changes from v1:
SETLINKSTATE is removed
drivers/staging/rdma/hfi1/diag.c | 23 +--
1 file changed, 13
From: Ira Weiny
Place logical operators at the end of the previous line when using a multi-line
statement. Found by checkpatch --strict
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rdma/
From: Ira Weiny
Use !foo rather than (foo == NULL) as recommended by checkpatch --strict
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/r
From: Ira Weiny
It was identified that hfi1_ioctl may sleep with a spin lock held.
This was identified publicly here:
http://www.spinics.net/lists/linux-rdma/msg29926.html
As well as by our internal development.
This series cleans up the code and parameter checks, as well as fixing the
lockin
From: Ira Weiny
Use BIT macros rather than shifts.
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma/hfi1/diag.c
index 0aaad7412842..8faad4556ae1 100644
-
On Tue, Dec 01, 2015 at 06:57:24PM +0300, Dan Carpenter wrote:
> On Tue, Dec 01, 2015 at 09:54:50AM -0500, Ben Romer wrote:
> > On 12/01/2015 03:00 AM, Dan Carpenter wrote:
> > >Doing One Err style error handling is often a mistake but it's ok here.
> >
> > Why is it okay here? I don't understand
On Tue, Dec 01, 2015 at 11:16:16AM -0500, Ben Romer wrote:
> On 12/01/2015 10:57 AM, Dan Carpenter wrote:
> >What I meant was that I'm generally opposed to "common exit paths".
> >Mixing all the exit paths together often makes the code more complicated
> >and leads to errors. That makes sense from
On Tue, Dec 01, 2015 at 07:05:19PM +0300, Dan Carpenter wrote:
> A lot of review is judgement calls. I try very hard to be predictable
> and machine like as possible.
>
> I have sometimes called you out for being too strict.
I usually try to guess what Greg will do if he notices those multiple
c
On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee
wrote:
> On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote:
>> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote:
>> >
>> >
>> > On 2015년 11월 09일 18:05, punit vara wrote:
>> >>
>> >> On Mon, Nov 9, 2015 at 2:25 PM, glen lee wrote:
>> >>>
>> >
From: "K. Y. Srinivasan"
Date: Tue, 1 Dec 2015 16:42:58 -0800
> In an attempt to avoid having to allocate memory on the send path, the netvsc
> driver was requesting additional head room so that both rndis header and the
> netvsc packet (the state that had to persist) could be placed in the skb.
struct set_multicast uses (implicitly) sizeof(bool) to determine how many bytes
to copy in
Handle_SetMulticastFilter. Since that is implementation defined, it triggered
sparse to
rightfully complain about shifting a bigger value than supported.
Since it was used as if assuming it was 32 bits, I r
Eliminate the channel field in hv_netvsc_packet structure.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 22 ++
drivers/net/hyperv/netvsc.c | 19 ---
drivers/net/hyperv/netvsc_drv.c |5 +++--
From: Vitaly Kuznetsov
Signed-off-by: Vitaly Kuznetsov
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h | 15 ---
drivers/net/hyperv/netvsc.c |5 ++---
drivers/net/hyperv/netvsc_drv.c |3 +++
3 files changed, 5 insertions(+), 18 deletions(-)
diff -
The rndis header is 116 bytes big and can be placed in the default
head room that will be available in the skb. Since the netvsc packet
is less than 48 bytes, we can use the skb control buffer
for the netvsc packet. With these changes we don't need to
ask for additional head room.
Signed-off-by: K
Rearrange the elements of struct hv_negtvsc_packet for optimal layout -
eliminate unnecessary padding.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/driver
Eliminate is_data_pkt from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |1 -
drivers/net/hyperv/netvsc.c | 14 --
drivers/net/hyperv/netvsc_drv.c |1 -
drivers/net/hyperv/rndis_filter.c |1 -
4 files changed, 8
Eliminate rndis_msg pointer from hv_netvsc_packet structure.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |8 +++-
drivers/net/hyperv/netvsc.c | 10 ++
drivers/net/hyperv/netvsc_drv.c |7 +++
drivers/net/hyper
Eliminate vlan_tci from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |4 ++--
drivers/net/hyperv/netvsc_drv.c | 14 +++---
drivers/net/hyperv/rndis_filter.c |7 +++
3 files changed, 12 insertions(+), 13 deletions(-)
diff
Eliminate send_completion_tid from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |8 ++--
drivers/net/hyperv/netvsc.c | 28 ++--
drivers/net/hyperv/netvsc_drv.c | 14 ++
drivers/net/hyperv/rn
Eliminate send_completion from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |3 +--
drivers/net/hyperv/netvsc.c |6 +++---
drivers/net/hyperv/netvsc_drv.c |2 +-
drivers/net/hyperv/rndis_filter.c |
Eliminate send_completion_ctx from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |1 -
drivers/net/hyperv/netvsc.c |3 +--
drivers/net/hyperv/netvsc_drv.c |1 -
3 files changed, 1 insertions(+), 4 deletion
As part of reducing the size of the hv_netvsc_packet, resize some of the
variables based on their usage.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/n
Eliminate completion_func from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |1 -
drivers/net/hyperv/netvsc_drv.c |3 ---
drivers/net/hyperv/rndis_filter.c |1 -
3 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers
Eliminate status from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |1 -
drivers/net/hyperv/netvsc.c |6 ++
drivers/net/hyperv/netvsc_drv.c |8 ++--
drivers/net/hyperv/rndis_filter.c | 20 +---
4 file
Eliminate page_buf from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |4 ++--
drivers/net/hyperv/netvsc.c | 25 ++---
drivers/net/hyperv/netvsc_drv.c | 11 ++-
drivers/net/hy
From: Vitaly Kuznetsov
Packet scheduler guarantees there won't be multiple senders for the same
queue and as we use q_idx for multi_send_data the spinlock is redundant.
Signed-off-by: Vitaly Kuznetsov
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |1 -
drivers/net/hy
Eliminatte the data field from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |5 ++---
drivers/net/hyperv/netvsc.c |5 +++--
drivers/net/hyperv/netvsc_drv.c |3 ++-
drivers/net/hyperv/rndis_filter.c
Eliminate xmit_more from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |1 -
drivers/net/hyperv/netvsc.c | 13 -
drivers/net/hyperv/netvsc_drv.c |1 -
drivers/net/hyperv/rndis_filter.c |2 --
4 files changed, 8 in
In an attempt to avoid having to allocate memory on the send path, the netvsc
driver was requesting additional head room so that both rndis header and the
netvsc packet (the state that had to persist) could be placed in the skb.
Since the amount of head room requested was exceeding the default head
On Tue, Dec 01, 2015 at 03:38:13PM -0500, Jubin John wrote:
> From: Kaike Wan
>
> This patch fixes a few incorrect header file comments in qp.h
FWIW, within drivers/infiniband we've been moving these comments
to the implementation, not the function prototype.
Jason
_
On Tue, Dec 01, 2015 at 12:03:09PM +0100, Boris Brezillon wrote:
> struct nand_chip now embeds an mtd device. Patch all drivers to make use
> of this mtd instance instead of using the instance embedded in their
> private struct or dynamically allocated.
>
> Signed-off-by: Boris Brezillon
> Cc: Ju
On Tue, Dec 01, 2015 at 12:03:14PM +0100, Boris Brezillon wrote:
> mtd_to_nand() now uses the container_of() approach to transform an
> mtd_info pointer into a nand_chip one. Drop useless mtd->priv
> assignments from NAND controller drivers.
>
> Signed-off-by: Boris Brezillon
> ---
> Patch genera
Hi Boris,
On Tue, Dec 01, 2015 at 12:03:09PM +0100, Boris Brezillon wrote:
> struct nand_chip now embeds an mtd device. Patch all drivers to make use
> of this mtd instance instead of using the instance embedded in their
> private struct or dynamically allocated.
>
> Signed-off-by: Boris Brezillo
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Tuesday, December 1, 2015 12:42 PM
> To: KY Srinivasan
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com
> Su
From: "K. Y. Srinivasan"
Date: Sat, 28 Nov 2015 12:20:36 -0800
> +#elseif defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25)
The correct CPP directive is "#elif".
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/
From: Dean Luick
Only warn when link up pkeys are not what we expect. Also, allow
for the pkey to already be initialized.
Reviewed-by: Arthur Kepner
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/chip.c |8
From: Andrea Lowe
Changing the 32-bit reserved field in opa_port_data_counters_msg
to the new 'resolution' field. PMA will use resolutions to right-
shift values for LocalLinkIntegrity and LinkErrorRecovery when
computing the ErrorCounterSummary for a DataPortCounters request.
Reviewed-by: Mike
From: Edward Mascarenhas
Clean up comments by deleting numbering and terms internal to Intel.
The information on the actual bugs is not deleted.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Edward Mascarenhas
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in co
From: Dean Luick
The longest quiet timeout is now 6s. Extend the driver wait to 6s.
The driver wasn't following our internal specification: 6 seconds.
This patch corrects that issue.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
From: Dean Luick
When sending a diagnostic packet, if the send context does not
have enough room, force a credit return and try again.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/diag.c
From: Joel Rosenzweig
Provides error status counters for CceErrStatus, Send*ErrStatus,
RcvErrStatus and MISC_ERR_STATUS
Reviewed-by: Mitko Haralanov
Reviewed-by: Mike Marciniszyn
Signed-off-by: Joel Rosenzweig
Signed-off-by: Jubin John
---
Changes in v2:
- Refreshed patch on top of l
From: Dean Luick
Change reported unknown frame messages into a counter.
These are informational, no errors.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/chip.c | 18 ++
From: Kaike Wan
This patch fixes a few incorrect header file comments in qp.h
Reviewed-by: Mike Marciniszyn
Signed-off-by: Kaike Wan
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in commit message
drivers/staging/rdma/hfi1/qp.h |8
1 files change
From: Dean Luick
An SPC freeze is not an error. Remove the messages.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/chip.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
dif
From: Ira Weiny
Total XMIT wait needs to sum the xmit wait values of all the VLs not just
those requested in the query. Also, make the algorithm used for both
PortStatus and PortDataCounters the same.
Reviewed-by: Arthur Kepner
Reviewed-by: Breyer, Scott J
Signed-off-by: Ira Weiny
Signed-off
From: Harish Chegondi
Currently, if hfi1_register_ib_device() call is unsuccessful, workqueues
are not being destroyed before bailing out. This patch fixes this issue.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
Changes in v2:
- No chan
From: Dean Luick
Correctly reduce the number of VLs when limited by the number
of SDMA engines.
The hardware has multiple egress mechanisms, SDMA and pio, and multiples
of those. These mechanisms are chosen using the VL (8)
The fix corrects a panic issue with one of the platforms that doesn't h
From: Dean Luick
Add one-time LCB reset on driver load to pre-emptively work
around any LCB power cycle issues.
Reviewed-by: Easwar Hariharan
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- Fixed driver name to hfi1 in subject line
drivers/staging/rdma/hfi1/
From: Harish Chegondi
Currently, only MTUs of VLs 0-7 are checked when calculating the maximum VL
MTU which is used to set the port MTU capability in DCC_CFG_PORT_CONFIG CSR
This can cause a port MTU capability to be set to 0 if MTUs of VLs 0-7 is 0
This would affect the VL15 traffic.
Reviewed-b
From: Dean Luick
Add CNP opcode decode.
Prior to this patch the trace appeared like:
-0 [001] d.h. 94062.578932: input_ibhdr: [:05:00.0] vl 0
lver 0 sl 0 lnh 2,LRH_BTH dlid 0003 len 6 slid 0001 op 0x80,0x80 se 0 m 0
pad 0 tver 0 pkey 0x8001 f 0 b 0 qpn 0x001234 a 0 psn 0x
Note
From: Dean Luick
Add support for an automatic fallback for firmware names to support
debug-signed and production-signed firmware images.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in commit message
From: Dean Luick
Add aeth name syndrome decode to enhance debugging.
The IBTA RC ACK contains an ACK extended transport header.
Part of that header is the syndrome field that qualifies the RC ACK as an
ACK, NAK, or RNR NAK.
Without the patch here is the syndrome decode:
aeth syn 0x00
Here is
Changes in v2:
- Added more information in commit messages of patches 01, 02
03, 04, 05, 07 and 09
- Fixed driver name to hfi1 in subject line of patch 06
- Refreshed patch 10 on top of staging-next
- Dropped patch 18 (staging/rdma/hfi1: Workaround
From: Vitaly Kuznetsov
Date: Fri, 27 Nov 2015 11:39:55 +0100
> There are several issues in hv_netvsc driver with regards to link status
> change handling:
> - RNDIS_STATUS_NETWORK_CHANGE results in calling userspace helper doing
> '/etc/init.d/network restart' and this is inappropriate and brok
From: Dean Luick
Correctly set half-swing for integrated devices. A0 needs all fields set for
CcePcieCtrl. B0 and later only need a few fields set.
Reviewed-by: Stuart Summers
Signed-off-by: Dean Luick
Signed-off-by: Ira Weiny
---
Changes from V1:
Add comments concerning the very l
From: Ira Weiny
This was a single patch before. The change to dev_dbg required a precursor
patch to add the dd_dev_dbg which is consistent with the other dev_* macros
which automatically use struct hfi1_devdata.
Dean Luick (1):
staging/rdma/hfi1: set Gen3 half-swing for integrated devices
Ir
From: Ira Weiny
To be used in future patches add dd_dev_dbg. dd_* functions properly decode
the hfi1_devdata structure used throughout the driver
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/hfi.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/rdma/hfi1/hfi.
On Tue, 2015-12-01 at 01:56PM +0100, Christian Colic wrote:
> Add blank line after struct declaration to fix checkpatch check.
>
> Signed-off-by: Christian Colic
Reviewed-by: Sören Brinkmann
Thanks,
Sören
___
devel mailing list
de...@l
On 12/01/2015 10:57 AM, Dan Carpenter wrote:
What I meant was that I'm generally opposed to "common exit paths".
Mixing all the exit paths together often makes the code more complicated
and leads to errors. That makes sense from a common sense perspective
that doing many things is more difficult
A lot of review is judgement calls. I try very hard to be predictable
and machine like as possible.
I have sometimes called you out for being too strict. I worry sometimes
that I am too strict. I ignore a lot of stuff. Feel free to call me
out though if you want because I welcome feedback.
re
On Tue, Dec 01, 2015 at 09:54:50AM -0500, Ben Romer wrote:
> On 12/01/2015 03:00 AM, Dan Carpenter wrote:
> >Doing One Err style error handling is often a mistake but it's ok here.
>
> Why is it okay here? I don't understand why this function would be
> any different than the other places where th
On Tue, Dec 01, 2015 at 08:42:28AM +, Sanidhya Solanki wrote:
> Patch moves the headers found in the "skein_block.c" to "skein_block.h".
Why?
> Compiled & checked: no errors found.
Why is this line here?
> Signed-off-by: Sanidhya Solanki
You sent this as a html patch, which can't be appli
On 12/01/2015 03:00 AM, Dan Carpenter wrote:
Doing One Err style error handling is often a mistake but it's ok here.
Why is it okay here? I don't understand why this function would be any
different than the other places where the code used a goto.
If we *have* to change it I would prefer tha
struct nand_chip now embeds an mtd device. Patch all drivers to make use
of this mtd instance instead of using the instance embedded in their
private struct or dynamically allocated.
Signed-off-by: Boris Brezillon
Cc: Julia Lawall
---
Most of those changes were generated with the coccinelle scri
Add blank line after struct declaration to fix checkpatch check.
Signed-off-by: Christian Colic
---
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
b/drivers/staging/clocking-wiz
Hi Boris,
[auto build test ERROR on next-20151127]
[cannot apply to mtd/master v4.4-rc3 v4.4-rc2 v4.4-rc1 v4.4-rc3]
url:
https://github.com/0day-ci/linux/commits/Boris-Brezillon/mtd-nand-refactor-the-NAND-subsystem-part-1/20151201-190822
config: arm-imx_v6_v7_defconfig (attached as .config
Hi,
On Tue, 1 Dec 2015 12:17:44 +0100 (CET)
Julia Lawall wrote:
>
>
> On Tue, 1 Dec 2015, Boris Brezillon wrote:
>
> > Add nand-priv-no-mtd.cocci to detect and correct NAND controller drivers
> > directly embedding an mtd_info struct in their private struct.
> >
> > Signed-off-by: Boris Brezi
On Tue, 1 Dec 2015, Boris Brezillon wrote:
> Add nand-priv-no-mtd.cocci to detect and correct NAND controller drivers
> directly embedding an mtd_info struct in their private struct.
>
> Signed-off-by: Boris Brezillon
> Cc: Julia Lawall
> ---
> Hi Julia,
>
> Not sure this is the correct way to
New helpers have been added to avoid directly accessing chip->field. Use
them where appropriate.
Signed-off-by: Boris Brezillon
---
arch/arm/mach-ixp4xx/ixdp425-setup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-ixp4xx/ixdp425-setup.c
b/arch/arm/mach-i
New helpers have been added to avoid directly accessing chip->field. Use
them where appropriate.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/ams-delta.c | 6 +--
drivers/mtd/nand/atmel_nand.c| 54 ++---
drivers/mtd/nand/bcm47xxnflash/main.
mtd_to_nand() now uses the container_of() approach to transform an
mtd_info pointer into a nand_chip one. Drop useless mtd->priv
assignments from NAND controller drivers.
Signed-off-by: Boris Brezillon
---
Patch generated with the following coccinelle script:
---8<
virtual patch
@@
struct m
mtd_to_nand() now uses the container_of() approach to transform an
mtd_info pointer into a nand_chip one. Drop useless mtd->priv
assignments from NAND controller drivers.
Signed-off-by: Boris Brezillon
---
Patch generated with the following coccinelle script:
---8<
virtual patch
@@
struct m
struct nand_chip now embeds an mtd device. Patch all drivers to make use
of this mtd instance instead of using the instance embedded in their
private struct or dynamically allocated.
Signed-off-by: Boris Brezillon
Cc: Julia Lawall
---
Most of those changes were generated with the coccinelle scri
New helpers have been added to avoid directly accessing chip->field. Use
them where appropriate.
Signed-off-by: Boris Brezillon
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/mt29f_spinand/mt29f_spi
Add two helpers to access the field reserved for private controller data.
This makes it clearer what this field is reserved for and ease future
refactoring.
Signed-off-by: Boris Brezillon
---
include/linux/mtd/nand.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/linux/m
Add a new helper to retrieve the MTD device attached to a NAND chip.
Signed-off-by: Boris Brezillon
---
include/linux/mtd/nand.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index c4e39ff..8ec071e 100644
--- a/include/linux/mtd/nand
Now that the nand_chip struct directly embeds an mtd_info struct we can
get rid of the ->flash_node field and forward set/get_flash_node requests
to the MTD layer.
As a side effect, we no longer need the mtd_set_of_node() call done in
nand_dt_init().
Signed-off-by: Boris Brezillon
---
drivers/m
mtd_to_nand() was recently introduced to avoid direct accesses to the
mtd->priv field. Update all NAND drivers to use it.
Signed-off-by: Boris Brezillon
---
Patch generated with the following coccinelle script:
--->8---
virtual patch
@@
struct nand_chip *c;
struct mtd_info *m;
@@
(
-c = (m)->pr
struct nand_chip now embeds an mtd device, use it instead of allocating
a new one.
Signed-off-by: Boris Brezillon
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c
b/drivers/stag
The MTD device is now directly embedded in the nand_chip struct. Update the
mtdnand documentation to mention this aspect and fix the different
examples.
Signed-off-by: Boris Brezillon
---
Documentation/DocBook/mtdnand.tmpl | 31 +++
1 file changed, 15 insertions(+), 1
mtd_to_nand() was recently introduced to avoid direct accesses to the
mtd->priv field. Update all SH specific implementations to use this
helper.
Signed-off-by: Boris Brezillon
---
arch/sh/boards/mach-migor/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/board
mtd_to_nand() was recently introduced to avoid direct accesses to the
mtd->priv field. Update all blackfin specific implementations to use
this helper.
Signed-off-by: Boris Brezillon
---
arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
arch/blackfin/mach-bf561/boards/acvilon.c | 2 +-
2 files c
mtd_to_nand() now uses the container_of() approach to transform an
mtd_info pointer into a nand_chip one. Drop useless mtd->priv
assignments from NAND controller drivers.
Signed-off-by: Boris Brezillon
---
Patch generated with the following coccinelle script:
---8<
virtual patch
@@
struct m
struct nand_chip now embeds an mtd device. Patch all drivers to make use
of this mtd instance instead of using the instance embedded in their
private struct or dynamically allocated.
Signed-off-by: Boris Brezillon
---
Most of those changes were generated with the coccinelle script added
in commit
Now that all drivers are using the mtd instance embedded in the nand_chip
struct we can safely update the mtd_to_nand() implementation to use
the container_of macro instead of returning the content of mtd->priv.
This will allow us to remove mtd->priv = chip assignments done in all
NAND controller d
nand_dt_init() function requires 3 arguments where it actually needs one
(dn and mtd can both be retrieved from chip). Drop these parameters.
Testing for dn != NULL inside nand_dt_init() also helps simplifying the
caller code.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/nand_base.c | 21
1 - 100 of 115 matches
Mail list logo
