Re: [PATCH v3 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

2015-11-22 Thread Greg KH
On Sun, Nov 22, 2015 at 09:15:02PM -0500, ira.weiny wrote: > On Thu, Nov 19, 2015 at 04:54:44PM -0800, Greg KH wrote: > > On Mon, Nov 09, 2015 at 06:34:44PM -0500, ira.we...@intel.com wrote: > > > From: Vennila Megavannan > > > > > > Add a module paramter to toggle prescan/Fast ECN Detection and

Re: [PATCH v2 1/7] staging/rdma/hfi1: diag.c Correct code style issues

2015-11-22 Thread ira.weiny
On Tue, Nov 17, 2015 at 02:27:46PM -0800, gre...@linuxfoundation.org wrote: > On Tue, Nov 17, 2015 at 03:30:24PM -0500, ira.weiny wrote: > > On Tue, Nov 17, 2015 at 10:17:26PM +0530, Sudip Mukherjee wrote: > > > On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com wrote: > > > > From: Jubi

Re: [PATCH v3 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

2015-11-22 Thread ira.weiny
On Thu, Nov 19, 2015 at 04:54:44PM -0800, Greg KH wrote: > On Mon, Nov 09, 2015 at 06:34:44PM -0500, ira.we...@intel.com wrote: > > From: Vennila Megavannan > > > > Add a module paramter to toggle prescan/Fast ECN Detection and remove the > > Kconfig option which used to control this. > > Ick, n

[PATCH] staging: rtl8712: Cleanup _io_ops wrappers

2015-11-22 Thread Mauro Dreissig
This removes ugly and unnecessary declarations. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl8712_io.c | 77 +++- 1 file changed, 22 insertions(+), 55 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_io.c b/drivers/staging/rtl8712/rtl871

Re: [PATCH] staging: comedi: Coding style warning fix for block comments

2015-11-22 Thread Andy Shevchenko
On Sun, Nov 22, 2015 at 9:19 PM, Jitendra Kumar Khasdev wrote: > This patch is to comedilib.h file that fixes up following warnings > reported by checkpatch.pl : > I) Block comments use * on subsequent lines > > Signed-off-by: Jitendra Kumar Khasdev > --- > drivers/staging/comedi/comedilib.h | 3

[PATCH] staging: comedi: Coding style warning fix for block comments

2015-11-22 Thread Jitendra Kumar Khasdev
This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl : I) Block comments use * on subsequent lines Signed-off-by: Jitendra Kumar Khasdev --- drivers/staging/comedi/comedilib.h | 32 1 file changed, 16 insertions(+), 16 dele

[GIT PULL] Staging driver fixes for 4.4-rc2

2015-11-22 Thread Greg KH
The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.4-rc2 for you to fetch changes up to b57f9f34e27bf

[PATCH 1/3] staging: most: fix error comparison

2015-11-22 Thread Sudip Mukherjee
device_create() returns ERR_PTR on error, it does not return NULL. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/mostcore/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index ed1ed2

[PATCH 3/3] staging: most: fix id leak

2015-11-22 Thread Sudip Mukherjee
If create_most_inst_obj() fails we returned an error pointer but we missed releasing id. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/mostcore/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index

[PATCH 2/3] staging: most: return proper error

2015-11-22 Thread Sudip Mukherjee
We were returning ENOMEM on all types of errors. Lets return the actual error code. At the same time remove the label which became unused as a result of this patch. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/mostcore/core.c | 22 +++--- 1 file changed, 15 insertions(