On Wed, Nov 18, 2015 at 04:26:52PM +, Ian Abbott wrote:
> >+#define DMM32AT_AI_CFG_SCINT_10US (BIT(5) & ~BIT(4))
> >+#define DMM32AT_AI_CFG_SCINT_5US(BIT(5) | BIT(4))
>
> The values of DMM32AT_AI_CFG_SCINT_20US etc. are numerically
> correct, but look a bit strange. The `(BIT(5) & ~BIT(
On Wed, Nov 18, 2015 at 01:43:50PM +0100, Christian Gromm wrote:
> This patch rearranges the code of function aim_write() of module aim-cdev.
> It is needed to remove the error lable and make the code straighter.
>
I like error labels.
> Signed-off-by: Christian Gromm
> ---
> drivers/staging/m
From: Leo Kim
This patch renames pJoinParams to join_params that is
fourth argument of CfgScanResult function to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
From: Leo Kim
This patch renames pstrNetworkInfo to network_info that is
first argument of get_rssi_avg function to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Leo Kim
This patch renames enuScanEvent to scan_event that is
first argument of CfgScanResult function to avoid camelcase.
And, remove the relation comment.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 +++---
1 file c
From: Leo Kim
This patch renames pUserVoid to user_void that is
second argument of is_network_in_shadow function to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
From: Leo Kim
This patch renames pstrNetworkInfo to network_info that is
second argument of CfgScanResult function to avoid camelcase.
And, remove the relation comment.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 41 ++
From: Leo Kim
This patch renames pUserVoid to user_void that is
third argument of CfgScanResult function to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
From: Leo Kim
This patch renames pUserVoid to user_void that is
second argument of add_network_to_shadow function to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
From: Leo Kim
This patch renames pUserVoid to user_void that is
first argument of refresh_scan function to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --gi
From: Leo Kim
This patch removes pUserVoid that is first argument of
update_scan_time function because it is not used in this function.
Remove argument in the function call also.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 5 ++---
1
From: Leo Kim
This patch renames bWilc_ie variable to wilc_ie to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/
From: Leo Kim
This patch removes pUserVoid that is first argument of
reset_shadow_found function because it is not used in this function.
Remove argument in the function call also.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 ++
From: Leo Kim
This patch renames s32Freq variable to freq to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgope
From: Leo Kim
This patch renames pstrNetworkInfo variable to network_info
to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/driver
From: Leo Kim
This patch renames bDirectScan to direct_scan that is
third argument of refresh_scan function to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
From: Leo Kim
This patch removes pUserVoid that is first argument of
clear_shadow_scan function because it is not used in this function.
Remove argument in the function call also.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--
1
From: Leo Kim
This patch renames duringIP_TIME variable to during_ip_time
to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/
From: Leo Kim
This patch renames u8P2Precvrandom variable to p2p_recv_random
to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 24 +++
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/d
From: Leo Kim
This patch renames wilc_connected_SSID variable to wilc_connected_ssid
to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 22 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
From: Leo Kim
This patch renames u8P2P_vendorspec variable to p2p_vendor_spec
to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging
From: Leo Kim
This patch renames WILC_WFI_2ghz_channels variable to ieee80211_2ghz_channels
to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/driver
From: Leo Kim
This patch renames u8P2Plocalrandom variable to p2p_local_random
to avoid camelcase.
And, remove the relation comment.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 35 ---
1 file changed, 18 insertions
From: Leo Kim
This patch renames u32LastScannedNtwrksCountShadow variable to last_scanned_cnt
to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 50 +++
1 file changed, 24 insertions(+), 26 deletions(-
From: Leo Kim
This patch renames u8P2P_oui variable to p2p_oui to avoid camelcase.
And, remove the relation comment.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
dif
From: Leo Kim
This patch renames astrLastScannedNtwrksShadow variable to last_scanned_shadow
to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 124 ++
1 file changed, 58 insertions(+), 66 deletions(-)
From: Leo Kim
This patch renames u8WLANChannel variable to wlan_channel to avoid camelcase.
And, remove the relation comment.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 29 +--
1 file changed, 11 insertions(+), 18
From: Leo Kim
This patch renames WILC_WFI_rates variable to ieee80211_bitrates
to avoid camelcase.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wil
On 2015년 11월 19일 15:23, Dan Carpenter wrote:
On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote:
This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since
this name could be confused index of txq_entry_t. It is index of tcp pending
ack.
It fixes 8e55639d066f4ef402ba8
On 2015년 11월 19일 15:19, Dan Carpenter wrote:
On Thu, Nov 19, 2015 at 11:05:58AM +0900, Glen Lee wrote:
This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed
by the following commit but the define was not removed. So remove completely.
b46d68825c2d3af70ad18b53dfed6516e3
On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote:
> This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since
> this name could be confused index of txq_entry_t. It is index of tcp pending
> ack.
>
> It fixes 8e55639d066f4ef402ba88fca08ed1be70e1c4da
>
It is just a cle
On Thu, Nov 19, 2015 at 11:05:58AM +0900, Glen Lee wrote:
> This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed
> by the following commit but the define was not removed. So remove completely.
>
> b46d68825c2d3af70ad18b53dfed6516e393b7fa
Put some human readable text next
On Thu, Nov 19, 2015 at 09:45:40AM +0530, Sudip Mukherjee wrote:
>
> David has mentioned it in bugzilla for 3.14-rc1.
> (https://bugzilla.kernel.org/show_bug.cgi?id=69881)
>
> The patch has been submitted multiple times.
> https://lkml.org/lkml/2014/2/15/24
>
> and then again on:
> http://driver
On Wed, Nov 18, 2015 at 01:43:30PM +0100, Christian Gromm wrote:
> This patch fixes a potential MBO leak in case function aim_read()
> exits right after the MBO has been fetched from kfifo and before
> it has been saved to the variable stacked_mbo.
>
> Signed-off-by: Christian Gromm
> ---
> driv
On Wed, Nov 18, 2015 at 09:31:36AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Nov 18, 2015 at 05:25:38PM +, David Binderman wrote:
> > Hello there Greg,
> >
> >
> > > Date: Wed, 18 Nov 2015 09:14:41 -0800
> > > From: gre...@linuxfoundation.org
> > > To:
On 2015년 11월 18일 19:30, Dan Carpenter wrote:
Hello Glen Lee,
The patch de11ee8b214e: "staging: wilc1000: call linux_sdio_init
instead of io_init" from Nov 6, 2015, leads to the following static
checker warning:
drivers/staging/wilc1000/wilc_sdio.c:574 sdio_init()
info: ignorin
This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since
this name could be confused index of txq_entry_t. It is index of tcp pending
ack.
It fixes 8e55639d066f4ef402ba88fca08ed1be70e1c4da
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 12 ++--
d
This patch remove memory allocation options in Kconfig. It was used a long time
ago to aquire memory, which we will not use this config anymore.
Remove it's config, related define and codes as well. We will take
PREALLOCATE_AT_LOADING_DRIVER as it is default.
Signed-off-by: Glen Lee
---
drivers/
This patch removes define BIG_ENDIAN and use kernel define byte order macros
instead of swap itself. Remove unused BYTE_SWAP macro and __CHECK_ENDIAN__
in Makefile also.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/Makefile| 2 +-
drivers/staging/wilc1000/wilc_sdio.c | 8 ++
This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed
by the following commit but the define was not removed. So remove completely.
b46d68825c2d3af70ad18b53dfed6516e393b7fa
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/Makefile | 2 --
1 file changed, 2 deletions
ARCH_SHMOBILE is coming to arm64, which creates new warnings in allmodconfig:
drivers/staging/emxx_udc/emxx_udc.c: In function '_nbu2ss_out_dma':
drivers/staging/emxx_udc/emxx_udc.c:843:45: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
_nbu2ss_writel(&preg->EP_
* Remove unused CamelCase in order to get rid of the corresponding
checkpatch.pl "CHECK: Avoid CamelCase: "
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/ieee80211.h
b/drivers/staging/rtl8712/i
* Fix checkpatch.pl output about not including the paragraph
about writing to the Free Software Foundation's mailing address
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee
* Fix alignment which did not match open parenthesis
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/ieee80211.h
b/drivers/staging/rtl8712/ieee80211.h
index 830452b..e5ec6c2 100644
* Do coding style cleanups on file ieee80211.h and get rid of
all checkpatch.pl output.
Michael Hornung (6):
staging: rtl8712: Coding style: Remove multiple blank lines
staging: rtl8712: Coding style: Make use of BIT macro
staging: rtl8712: Coding style: Fix missing spaces
staging: rtl87
* Remove multiple blank lines in order to get rid of checkpatch.pl
"CHECK" output
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.h
b/drivers/staging/rtl8712/ieee80211.h
i
* Add missing spaces around bitwise OR operation in order to get
rid of checkpatch.pl's "CHECK: spaces preferred around that '|'"
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/i
* Replace all occurences of (1<
---
drivers/staging/rtl8712/ieee80211.h | 92 ++---
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.h
b/drivers/staging/rtl8712/ieee80211.h
index bba978e..8ca3444 100644
--- a/drivers
Currently we have two policies for deciding when to signal the host:
One based on the ring buffer state and the other based on what the
VMBUS client driver wants to do. Consider the case when the client
wants to explicitly control when to signal the host. In this case,
if the client were to defer s
From: Andrey Smetanin
Hypervisor Top Level Functional Specification v3/4 says
that TSC page sequence value = -1(0x) is used to
indicate that TSC page no longer reliable source of reference
timer. Unfortunately, we found that Windows Hyper-V guest
side implementation uses sequence value =
Fix a couple of bugs.
Andrey Smetanin (1):
drivers/hv: correct tsc page sequence invalid value
K. Y. Srinivasan (1):
Drivers: hv: vmbus: Fix a Host signaling bug
drivers/hv/channel.c | 18 ++
drivers/hv/hv.c|4 ++--
include/linux/hyperv.h | 12
Fixed multiple comments and spacing coding style issues.
Signed-off-by: Daniel H. Hemmingsen
---
drivers/staging/comedi/comedi.h | 307 +++-
1 file changed, 177 insertions(+), 130 deletions(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/com
On Wednesday, November 18, 2015 11:34 AM, Ian Abbott wrote:
> On 18/11/15 17:07, H Hartley Sweeten wrote:
>> These defines are only used to initialize the diosubd_data 'addr' members
>> in the boardinfo. For aesthetics, just open-code the values and remove the
>> defines.
>>
>> Signed-off-by: H Har
On 18/11/15 17:07, H Hartley Sweeten wrote:
With the PCI-1760 support moved to a separate driver this one can now
be simplified and cleaned up pretty nicely.
Tidy up this driver and fix all the checkpatch.pl issues.
This series applies after:
"staging: comedi: adv_pci_dio: separate out PCI-1760
On 18/11/15 17:07, H Hartley Sweeten wrote:
These defines are only used to initialize the diosubd_data 'addr' members
in the boardinfo. For aesthetics, just open-code the values and remove the
defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
Em Wed, 18 Nov 2015 23:05:27 +0530
Jitendra escreveu:
>
>
> On Wednesday 18 November 2015 10:42 PM, Greg KH wrote:
> > On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote:
> >> This is a patch to the radio-bcm2048.c file that fixes up a brace warning
> >> found by the checkpa
If the "write" file operation handler, `comedi_write()` is passed 0 for
the amount to write, some error conditions are currently skipped and the
function just returns 0. Change it to check those error conditions and
return an error value if appropriate. The trickiest case is the check
for when th
`comedi_write()` copies data from the user buffer to the acquisition
data buffer, which is cyclic, using a single call to `copy_from_user()`.
It currently avoids having to deal with wraparound of the cyclic buffer
by limiting the amount it copies (and the amount returned to the user).
Change it to
At one point in `comedi_write()`, the variable `n` gets assigned to the
minimum of the parameter `nbytes` and the amount of writeable buffer
space. The way that is done currently is unsafe in the unlikely case
that `nbytes` exceeds `UINT_MAX`, so fix it.
Signed-off-by: Ian Abbott
---
drivers/st
In order to perform a "write" file operation, an asynchronous COMEDI
command in the "write" direction needs to have been set up by the
current file object on the COMEDI "write" subdevice associated with the
file object. If there is a "write" subdevice, but a command has not
been set up by the file
Rearrange the code in `comedi_write()` to reduce the amount of
indentation. The code never reiterates the `while` loop once `count`
has become non-zero, so we can check that in the `while` condition to
save an indentation level. (Note that `nbytes` has been checked to be
non-zero before entering
Tidy up the "write" file operation handler, `comedi_write()` a bit and
improve the error handling.
1) staging: comedi: rearrange comedi_write() code
2) staging: comedi: do extra checks for becoming non-busy for "write"
3) staging: comedi: make some variables unsigned in comedi_write()
4) staging:
In `comedi_write()`, the `n` and `m` variables are of type `int`.
Change them to `unsigned int` as they are used to measure a positive
number of bytes. The `count` variable is also of type `int` and holds
the returned number of bytes written. Change it to type `ssize_t` to
match the function's re
The "write" file operation handler, `comedi_write()` returns an error
for pretty much any condition that prevents a "write" going ahead. One
of the conditions that prevents a "write" going ahead is that no
asynchronous command has been set up, but that currently results in a
return value of 0 (unl
`comedi_write()` is the handler for the "write" file operation for
COMEDI devices. It mostly runs without using the main mutex of the
COMEDI device, but uses the `attach_lock` rw_semaphore to protect
against the COMEDI device becoming "detached". A file object can write
data for a COMEDI asynchon
On Wednesday 18 November 2015 10:42 PM, Greg KH wrote:
> On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote:
>> This is a patch to the radio-bcm2048.c file that fixes up a brace warning
>> found by the checkpatch.pl tool.
>>
>> Signed-off-by: Jitendra Kumar Khasdev
>> ---
>>
On Wed, Nov 18, 2015 at 05:25:38PM +, David Binderman wrote:
> Hello there Greg,
>
>
> > Date: Wed, 18 Nov 2015 09:14:41 -0800
> > From: gre...@linuxfoundation.org
> > To: dcb...@hotmail.com
> > CC: de...@driverdev.osuosl.org
> > Subject: Re: linux-4.4-
On Wed, Nov 18, 2015 at 08:53:51AM +, David Binderman wrote:
> hello there,
>
> [linux-4.4-rc1/drivers/staging/rts5208/sd.c:4170]: (style) Expression '(X &
> 0x1e) != 0x3' is always true.
>
> Source code is
>
> if ((ptr[3] & 0x1E) != 0x03) {
>
> Suggest code rework.
Great, please send a
On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote:
> This is a patch to the radio-bcm2048.c file that fixes up a brace warning
> found by the checkpatch.pl tool.
>
> Signed-off-by: Jitendra Kumar Khasdev
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
> 1 fil
For aesthetics, use a default case in the switch (board->cardtype) used
to reset the various boards.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --gi
This function is called as part of the pci_driver (*probe) before
doing the (*auto_attach) of the comedi driver. For aesthetics, move
the function to a more logical place in the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ad
All the boards use PCI BAR2 for the dev->iobase except for the pci1736
which uses PCI BAR0. Just use the board->cardtype to determine which
PCI BAR to use.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 30 +++--
These defines are only used to initialize the diosubd_data 'addr' members
in the boardinfo. For aesthetics, just open-code the values and remove the
defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 14 +--
For aesthetics, move these defines after the register defines and rename
them to have namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 22 +++---
1 file changed, 11 in
These boards use the same offsets for the interrupt control registers.
For aesthetics, remove the current defines and use common ones.
Fix the switch() in pci_dio_reset() to use common code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/driv
For aesthetics, use a common define for the interrupt control and status
registers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
These boards use the same offsets for the interrupt control registers.
For aesthetics, remove the current defines and use common ones.
Fix the switch() in pci_dio_reset() to use common code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/driv
For aesthetics, move this enum after the register defines and rename
it to have namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 29
1 file changed, 17 in
Currently the di/do subdevices store a pointer to the diosubd_data in
s->private.
The (*insn_bits) functions then use that to get to the 'addr' needed to access
the registers.
The only member of diosubd_data that is needed by the (*insn_bits) functions is
the 'addr'. For aesthetics, just store th
Currently the board reset function also resets the digital output channels
to 0. This works but it makes the reset function a bit messy and each
board type has to be handled special.
Move the digital output reset into the subdevice init where it can be
handle based on the subdevice setup.
Signed-
These are not necessary and just add cruft. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci_dio.c
b/drivers/s
These defines are only used to initialize the 'timer_regbase' boardinfo.
For aesthetics, just open-code the values and remove the defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 6 ++
1 file changed, 2 inser
For aesthetics, use a common comment for the switch() that disables and clears
interrupts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 24 ++--
1 file changed, 6 insertions(+), 18 deletions(-)
di
For aesthetics, replace these defines with some macros.
Refactor the switch in pci_dio_reset() to not require the fallthrough
comment.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 33
1 f
Change the MODULE_DESCRIPTION to something more useful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
This member of the boardinfo is identical to the offset of the boardinfo
in the boardtypes array. It's also passed as the 'context' to the driver
(*auto_attach).
The 'cardtype' is only needed by the (*auto_attach) to determine which
PCI BAR to use and in pci_dio_reset() to handle the board specifi
For aesthetics, move the disable of the channel freeze for the PCI-1752
and PCI-1756 boards out of the switch used to disable and clear interrupts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 10 --
1 file ch
This function initializes a digitial input subdevices. For aesthetics,
absorb it into the (*auto_attach).
Remove the improper initialization of the SDF_LSAMPL subdev_flag and
len_chanlist. These are only used by subdevices that support async
commands.
Also, remove the unnecessary 'specflags' from
The board reset function disables and clears all interrupts. It also
resets all the digital output channels to 0.
Interrupts are not currently used by this driver. For asthetics, do
the board reset early in the (*auto_attach) to make sure the interrupts
are disabled in case this feature is added.
The Description is a bit long winded and the same information is in
the Devices. Shorten the Description and tidy up the Devices.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 9 +++--
1 file changed, 3 insertions(
The "board id" register is always 4-bits (4 di channels) and the register
used to read the bits is always > 0.
Simplify the 'boardid' boardinfo by replacing it with a 'id_reg' member
and open-coding the subdevice n_chan.
For aesthetics, remove all the *_BOARDID defines and just open-code the
regi
This function initializes a digitial output subdevice. For aesthetics,
absorb it into the (*auto_attach).
Remove the improper initialization of the SDF_LSAMPL subdev_flag and
len_chanlist. These are only used by subdevices that support async
commands.
Also remove the unnecessary initilaization of
With the PCI-1760 support moved to a separate driver this one can now
be simplified and cleaned up pretty nicely.
Tidy up this driver and fix all the checkpatch.pl issues.
This series applies after:
"staging: comedi: adv_pci_dio: separate out PCI-1760 support"
H Hartley Sweeten (33):
staging:
Currently the (*insn_bits) functions used the 'regs' member to determine how
many registers need to be read or written to update the subdevice. We can use
the subdevice 'n_chan' to determine this and make the code a bit clearer.
The (*auto_attach) also uses this member to determine how many 8255 d
For aesthetics, use a const pointer to access the diosubd_data in the
boardinfo when doing the (*auto_attach)..
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 31 +---
1 file changed, 19 insertio
For aesthetics, rename this define and fix the alignment.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci_dio.
Reformat the bolck comment in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 40
1 file changed, 17 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/comed
For aesthetics, replace these defines with a macro.
Refactor the switch in pci_dio_reset() to use common code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 21 +
1 file changed, 9 insertions(+), 1
The boards supported by this driver either use 8-bit or 16-bit I/O. The
'io_access' member of the boardinfo is used by the (*auto_attach) to
determine which (*insn_bits) function to use.
Simplify the boardinfo a bit by refactoring the 'io_access' member into
a bit-field flag 'is_16bit'. Use the ne
The board reset function disables and clears all interrupts. It also
resets all the digital output channels to 0.
Interrupts are not used by this driver so the disable/clear during the
(*detach) is not necessary.
Reseting all the digital outputs to 0 might not be desired depending
on what the out
1 - 100 of 157 matches
Mail list logo
