Added a blank line after declaration to fix the coding style
error detected by checkpatch.pl
WARNING: Missing a blank line after declarations
Signed-off-by: Anjali Menon
---
drivers/staging/android/ion/ion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/and
This patch removes host_int_get_assoc_req_info function definition and
declaration that is defined at host_interface.c and host_interface.h.
This function is defined but not used anywhere in this driver so just
remove it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c
This patch removes host_int_get_rx_power_level function definition and
declaration that is defined at host_interface.c and host_interface.h.
This function is defined but not used anywhere in this driver so just
remove it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c
This patch removes host_int_set_RSNAConfigPSKPassPhrase function
definition and declaration that is defined at host_interface.c and
host_interface.h. This function is defined but not used anywhere in this
driver so just remove it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_int
This patch removes host_int_disconnect_station function definition and
declaration that is defined at host_interface.c and host_interface.h.
This function is defined but not used anywhere so just remove it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 12 --
This patch removes host_int_get_RSNAConfigPSKPassPhrase function
definition and declaration that is defined at host_interface.c and
host_interface.h. This function is defined but not used anywhere in this
driver so just remove it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_int
This patch removes host_int_get_start_scan_req function definition and
declaration that is defined at host_interface.c and host_interface.h.
This function is defined but not used anywhere in this driver so just
remove it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c
This patch changes u8GtkKeylen to gtk_key_len to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/host_i
This patch changes pu8RxMic to rx_mic to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interfa
This patch removes host_int_set_start_scan_req function definition and
declaration that is defined at host_interface.c and host_interface.h.
This function is defined but not used anywhere in this driver so that
just remove it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interfa
This patch removes host_int_get_pmkid_info function definition and
declaration that is defined at host_interface.c and host_interface.h.
This function is defined but not used anywhere in this driver so just
remove it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 14
This patch changes kmalloc followed by memcpy to kmemdup.
The error checking is also added when kmemdup is failed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc100
This patch changes u8Ciphermode to cipher_mode to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_in
This patch removes host_int_add_tx_gtk declaration that is defined in
host_interface.h file. It can not find any host_int_add_tx_gtk
function definition in this driver so just remove it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 2 --
1 file changed, 2 deletions
This patch changes KeyRSC to key_rsc to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.
This patch changes u32KeyRSClen to key_rsc_len to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/hos
This patch changes u8KeyLen to key_len to avoid camelcase.
It is used as local variable in order to save gtk_key_len that is
argument of this function.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
This patch changes pu8TxMic to tx_mic to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interfa
This patch changes u8KeyIdx to index to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
This patch changes kmalloc followed by memcpy to kmemdup
The error checking is also added when kmemdup is failed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_inter
This patch changes u8Idx to index to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/
This patch changes struct host_if_drv of host_int_add_rx_gtk function
declaration from hWFIDrv to hif_drv.
With this change, first argument of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 2 +-
1 fi
This patch changes return type of host_int_add_rx_gtk from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/w
This patch changes u8KeyLen to key_len to avoid camelcase.
It is used as local variable in order to save pkt_key_len that is
argument of this function.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --
The data type of variable i changes u32 to int.
It is used as array index to print debug message so that it is better to
use data type of int.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
This patch changes u8PtkKeylen to ptk_key_len to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host
This patch changes pu8TxMic to tx_mic to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 10 +-
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/host_int
This patch changes pu8RxGtk to rx_gtk to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
This patch changes pu8RxMic to rx_mic to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 10 +-
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/host_int
This patch changes u8Ciphermode to cipher_mode to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_in
This patch changes pu8Ptk to ptk to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/d
This patch changes struct host_if_drv of host_int_add_ptk function
declaration from hWFIDrv to hif_drv.
With this change, first parameter of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 2 +-
1 file
This patch changes return type of host_int_add_ptk from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc
On Sun, Nov 08, 2015 at 09:35:08AM +0300, Dan Carpenter wrote:
> If it's a one line fix then just send it as a single patch.
It was two things, hence I made it a two-parter.
Should I send a new version or is it a note for next time?
Thanks,
Othmar Pasteka
The reg_macid variable used only once. Also idx renamed to i and Adapter to
adapter.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers
This driver is only for the Linux kernel.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 11 ---
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.
The reg_bssid variable used only once. Also idx renamed to i and Adapter to
adapter.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers
They are not needed.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index 62f83ab..0e2528a 1006
Most likely it is missed here.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index a076ede..7c79774 100644
--- a/d
It is looks bit better.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index 7c79774..62f83
memset clearer than the for loop.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index 7f1df4d..298e3e8 100644
--- a/drivers/st
_rtl88e_fill_dummy fills the array elemets with zeros if necessary.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index 1d8930a..7f1df
u8 *pfirmware and u32 fwsize of hal_data_8188e structure not used.
The pfwdata variable used to store a pointer to the buffer
in rtl88eu_download_fw and the pfwbody variable points to the body
of the firmware (without header).
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c
-EFBIG more sutiable then -1
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index 5b569ef..3e354eb 100644
--- a/drivers/staging/rtl8188
Ideally the function should not change the variables outside of its body.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index
Duplicated code removed.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 433b926..69f8744d9 100644
--- a/d
On 11/08/2015 01:53 PM, Ivan Safonov wrote:
This driver is only for the Linux kernel.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 11 ---
2 files changed, 13 deletions(-)
diff --git a
Most likely it is missed here.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index a076ede..7c79774 100644
--- a/d
u8 *pfirmware and u32 fwsize of hal_data_8188e structure not used.
The pfwdata variable used to store a pointer to the buffer
and the pfwbody variable points to the firmware body (firmware without
header).
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 16 +++
They are not needed.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index 62f83ab..0e2528a 1006
-EFBIG more sutiable then -1
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index 5b569ef..3e354eb 100644
--- a/drivers/staging/rtl8188
-EFBIG more sutiable then -1
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index 5b569ef..3e354eb 100644
--- a/drivers/staging/rtl8188
The reg_bssid variable used only once. Also idx renamed to i and Adapter to
adapter.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers
Duplicated code removed.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 433b926..69f8744d9 100644
--- a/d
u8 *pfirmware and u32 fwsize of hal_data_8188e structure not used.
The pfwdata variable used to store a pointer to the buffer
in rtl88eu_download_fw and the pfwbody variable points to the body
of the firmware (without header).
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c
This driver is only for the Linux kernel.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 11 ---
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.
_rtl88e_fill_dummy fills the array elemets with zeros if necessary.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index 1d8930a..7f1df
Ideally the function should not change the variables outside of its body.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index
The reg_macid variable used only once. Also idx renamed to i and Adapter to
adapter.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers
memset clearer than the for loop.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index 7f1df4d..298e3e8 100644
--- a/drivers/st
It is looks bit better.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index 7c79774..62f83
Ideally the function should not change the variables outside of its body.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/fw.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index
Duplicated code removed.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 433b926..69f8744d9 100644
--- a/d
On Sun, Nov 08, 2015 at 08:14:48AM +0200, Mike Rapoport wrote:
> The lynxfb_pci_probe always returned -ENODEV in case of error. Modify it
> so that actual error code will be propogated to the caller.
>
> Signed-off-by: Mike Rapoport
This one introduces bugs. If framebuffer_alloc() fails then we
If it's a one line fix then just send it as a single patch.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Split framebuffer allocation and registration into a dedicated function
to simplify lynxfb_pci_probe
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 105 +++-
1 file changed, 49 insertions(+), 56 deletions(-)
diff --git a/drivers/staging/sm
Will be used in futher refactoring of driver _probe and _remove methods.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 24 +---
drivers/staging/sm750fb/sm750.h | 2 +-
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/sm750
Use a function to unregister framebuffer info and release its resources.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm75
In case of error during lynxfb_pci_probe, the function returned without
calling pci_disable_device. Fix it by adding pci_disable_device on the
error cleanup path.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/
The lynxfb_pci_probe always returned -ENODEV in case of error. Modify it
so that actual error code will be propogated to the caller.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers
The par variable in lynxfb_pci_remove is only assigned a value and never
used afterwards. Remove it.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 8f666
Hi,
These patches refactor the lynxfb_pci_probe
v3 changes:
* rebased on current Greg's staging-testing
v2 changes:
* add pci_disable_device on the cleanup path
* return actual error rather than ENODEV
Mike Rapoport (6):
staging: sm750fb: disable PCI device if lynxfb_pci_probe fails
stagin
checkpatch.pl says: CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Othmar Pasteka
---
drivers/staging/sm750fb/sm750_cursor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c
b/drivers/staging/sm750fb/sm750_cursor.c
inde
Fixes the checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Othmar Pasteka
---
drivers/staging/sm750fb/sm750_cursor.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c
b/drivers/staging/sm750fb/
On Sat, 2015-11-07 at 19:30 +0300, Dan Carpenter wrote:
> The original is easier to read, sorry. Checkpatch is a tool not the
> king of the world to obeyed at all times.
Completely agree.
Perhaps there could be some comment indicators added
to tell checkpatch to ignore certain warnings like
80 c
The tree has to be git bisectable. Don't break and then fix, send the
combo.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
I haven't looked at it, sorry. You'll have to figure it out or if you
complain to the original person who broken the build he can figure it
out. You are still missing a Fixes tag.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.o
Don't resend, it's fine. I don't like re-reviewing patches and you
don't like sending them. It's not like it introduces a bug or generate
a warning with our current tools.
But it's still important to understand how the one thing per patch rule
works (don't do half a thing per patch) so I wanted
On Sat, Nov 07, 2015 at 10:02:04AM -0800, Joe Perches wrote:
> On Sat, 2015-11-07 at 19:30 +0300, Dan Carpenter wrote:
> > The original is easier to read, sorry. Checkpatch is a tool not the
> > king of the world to obeyed at all times.
>
> Completely agree.
>
> Perhaps there could be some comme
Remove unnecessary variable 'err' from functions c2_reject() and
c2_service_destroy() since it can be replaced by a single line of
code instead.
Signed-off-by: Amitoj Kaur Chawla
---
drivers/staging/rdma/amso1100/c2_provider.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
dif
On Sat, 2015-11-07 at 11:35 -0800, Eric Dumazet wrote:
> On Fri, 2015-11-06 at 14:30 -0700, David Ahern wrote:
> > On 11/6/15 2:18 PM, Simon Xiao wrote:
> > > The .config file used to build linux-next kernel is attached to this mail.
> >
> > Thanks.
> >
> > Failed to notice this on the first resp
On Fri, 2015-11-06 at 14:30 -0700, David Ahern wrote:
> On 11/6/15 2:18 PM, Simon Xiao wrote:
> > The .config file used to build linux-next kernel is attached to this mail.
>
> Thanks.
>
> Failed to notice this on the first response; my brain filled in. Why
> linux-next tree? Can you try net-nex
On Nov 7, 2015, at 04:15, Dan Carpenter wrote:
>
> On Fri, Nov 06, 2015 at 10:04:41PM +, Simmons, James A. wrote:
>>> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
>>> Behalf Of Shivani Bhardwaj
>>> Sent: Friday, November 06, 2015 12:18 PM
>>> To: gre...@linuxfoundat
On Sat, Nov 7, 2015 at 7:24 PM, Dan Carpenter wrote:
> On Sat, Nov 07, 2015 at 05:01:49PM +0530, Punit Vara wrote:
>> int wilc1000_wlan_init(struct net_device *dev, perInterface_wlan_t *p_nic)
>> {
>> @@ -1791,6 +1794,7 @@ int wilc_netdev_init(struct wilc **wilc)
>> /*The 1st function called af
The original is easier to read, sorry. Checkpatch is a tool not the
king of the world to obeyed at all times.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-
On Sat, Nov 7, 2015 at 4:15 PM, Dan Carpenter wrote:
> This one should have been folded in with the last one. Really the whole
> series could have been sent as one patch, but especially the last two
> should have been folded together.
>
> regards,
> dan carpenter
>
Thanks Dan! Could you please s
This patch moves extern declarations to respective header files.
This patch also removes extern keyword from function declarations
since functions have the extern specifier by default.
Signed-off-by: Amitoj Kaur Chawla
---
drivers/staging/lustre/lustre/obdclass/cl_internal.h | 3 +++
drivers/
Resolved some character line limit warnings emitted by the checkpatch.pl
tool in some ADI accelerometer modules.
Signed-off-by: Evan Hosseini
---
drivers/staging/iio/accel/adis16201.h | 157
drivers/staging/iio/accel/adis16203.h | 135 +-
On Sat, Nov 07, 2015 at 05:01:49PM +0530, Punit Vara wrote:
> int wilc1000_wlan_init(struct net_device *dev, perInterface_wlan_t *p_nic)
> {
> @@ -1791,6 +1794,7 @@ int wilc_netdev_init(struct wilc **wilc)
> /*The 1st function called after module inserted*/
> static int __init init_wilc_driver(
This patch is to the linux_wlan.c file that fixes up break found during
make drivers/staging/wilc1000/linux_wlan.o
Patch add following things to file :
-struct wilc *wilc declaration
-init_irq declaration
-At preprocessor (!defined WILC_SDIO) to defination of init_irq
-At preprocessor (!defined WI
On Fri, Nov 06, 2015 at 10:04:41PM +, Simmons, James A. wrote:
> >From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> >Behalf Of Shivani Bhardwaj
> >Sent: Friday, November 06, 2015 12:18 PM
> >To: gre...@linuxfoundation.org
> >Cc: oleg.dro...@intel.com; de...@driverdev.osu
This one should have been folded in with the last one. Really the whole
series could have been sent as one patch, but especially the last two
should have been folded together.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
h
On Fri, Nov 06, 2015 at 05:11:09PM -0800, Greg KH wrote:
> On Thu, Oct 29, 2015 at 03:00:24AM +0200, Aya Mahfouz wrote:
> > Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
> > been replaced by is_power_of_2
> >
> > Signed-off-by: Aya Mahfouz
> > ---
> > v2:
> > -became patch num
Remove the function agl_list_empty() and replace its calls with the
function it wrapped.
Signed-off-by: Shivani Bhardwaj
---
drivers/staging/lustre/lustre/llite/statahead.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/st
Remove the wrapper sa_received_empty() and replace its calls with the
function it wrapped.
Signed-off-by: Shivani Bhardwaj
---
drivers/staging/lustre/lustre/llite/statahead.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/lustre/lustr
Remove the wrapper function agl_first_entry() and replace its calls with
the function list_entry() that it wraps.
Signed-off-by: Shivani Bhardwaj
---
drivers/staging/lustre/lustre/llite/statahead.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/s
Remove the function sa_first_received_entry() and replace all its calls
with the function list_entry() that it wraps.
Signed-off-by: Shivani Bhardwaj
---
drivers/staging/lustre/lustre/llite/statahead.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging
Remove the function ll_sa_entry_unhashed() and replace all its calls
with the function list_empty() that it wrapped.
Signed-off-by: Shivani Bhardwaj
---
drivers/staging/lustre/lustre/llite/statahead.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lu
This patchset removes unnecessary wrapper functions as the purpose of
clarifying the job of function is still served by the arguments in wrapped
functions. Hence, all the calls to wrapper functions are replaced by the
standard function they wrapped.
After applying this patch, code becomes cleaner.
Remove the function stride_page_count() and replace its calls with the
function stride_pg_count() that it wraps.
Signed-off-by: Shivani Bhardwaj
---
drivers/staging/lustre/lustre/llite/rw.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/lustre/lu
100 matches
Mail list logo
