From: Leo Kim
This patch renames strWILC_UsrConnReq of struct host_if_drv to usr_conn_req
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 167 +++---
drivers/staging/wilc1000/host_inte
From: Leo Kim
This patch renames au8AssociatedBSSID of struct host_if_drv to assoc_bssid
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files c
From: Leo Kim
This patch renames u8RemainOnChan_pendingreq of struct host_if_drv to
remain_on_ch_pending to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 10 +-
drivers/staging/wilc1000/host_interface.
From: Leo Kim
This patch renames strHostIfRemainOnChan of struct host_if_drv to remain_on_ch
to avoid CamelCase naming convention.
And, remove the relation comment.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 24
driv
From: Leo Kim
This patch renames enuHostIFstate of struct host_if_drv to hif_state
to avoid CamelCase naming convention.
And, some comments modification that has been included name 'enuHostIFstate'.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c |
From: Leo Kim
This patch renames u32Mode of struct op_mode to mode
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+),
From: Leo Kim
This patch fixes the checks reported by checkpatch.pl
for Please don't use multiple blank lines.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 39 ---
1 file changed, 39 deletions(-)
diff --git a/drive
From: Leo Kim
This patch renames u8MacAddress of struct get_mac_addr to mac_addr
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 in
From: Leo Kim
This patch renames u32Address of struct drv_handler to handler
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 inse
From: Leo Kim
This patch fixes the warnings reported by checkpatch.pl
for Missing a blank line after declarations.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a
From: Leo Kim
This patch renames strWILC_UsrScanReq of struct host_if_drv to usr_scan_req
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 78 +++
drivers/staging/wilc1000/host_inte
From: Leo Kim
This patch renames u8MacAddress of struct set_mac_addr to mac_addr
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 in
From: Leo Kim
This patch removes unused functions at host_interface files.
- host_int_send_join_leave_info_to_host
- host_int_send_network_info_to_host
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 11 --
drivers/staging/wilc1000/host
From: Leo Kim
This patch renames au8StartTime of struct join_bss_param to start_time
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 10 --
1 file changed, 4 insertions(+), 6
From: Leo Kim
This patch renames variable strWID to wid
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 595 +++---
1 file changed, 297 insertions(+), 298 deletions(-)
diff --git a/dr
From: Leo Kim
This patch removes the checks reported by checkpatch.pl
for unnecessary parentheses around.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 48 +++
1 file changed, 23 insertions(+), 25 deletions(-)
diff
From: Leo Kim
This patch fixes the checks reported by checkpatch.pl
for Blank lines aren't necessary after an open brace '{' and
Blank lines aren't necessary before a close brace '}'.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 33 ---
From: Leo Kim
This patch fixes the warnings reported by checkpatch.pl
for braces {} are not necessary for single statement blocks
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 34 +++
1 file changed, 16 insertions(+)
On Tue, Oct 27, 2015 at 07:45:22PM +0200, Aya Mahfouz wrote:
> Replaces IS_PO2 by is_power_of_2. It is more accurate to use
> is_power_of_2 since it returns 1 for numbers that are powers
> of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
> powers of 2.
>
> Signed-off-by: Aya Mahfouz
On Tue, Oct 27, 2015 at 07:43:34PM +0200, Aya Mahfouz wrote:
> Replaces IS_PO2 by is_power_of_2. It is more accurate to use
> is_power_of_2 since it returns 1 for numbers that are powers
> of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
> powers of 2.
>
> Reviewed-by: Andreas Dilger
On Tue, Oct 27, 2015 at 10:26:00PM +0700, Ivan Safonov wrote:
> x = x + a and x += a equivalen, but second preferably.
equivalent?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo
From: Leo Kim
This patch removes goto statement and moves the spin lock position.
If a memory allocation fails, directly returns an error.
The spin lock actually protects the pHandle. Therefore, call spin lock just
before pHandle is used.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
Signed-o
On Tue, Oct 27, 2015 at 10:19:50PM +0700, Ivan Safonov wrote:
> min_t macro better conveys the meaning of the code.
>
> Signed-off-by: Ivan Safonov
> ---
> Changes in v2:
> - min replaced by mit_t.
>
> drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
> drivers/staging/rtl8188eu/core/rtw
On Tue, Oct 27, 2015 at 10:18:10PM +0700, Ivan Safonov wrote:
> min_t macro better conveys the meaning of the code.
>
> Signed-off-by: Ivan Safonov
> ---
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
> b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
> index 2d88c5a..5808763 100644
On Tue, Oct 27, 2015 at 02:04:54PM +0200, Dzonatans Melgalvis wrote:
> Fixed checkpatch.pl warning about comment block coding style.
>
> Signed-off-by: Dzonatans Melgalvis '.
This change has already been done by:
7e4161747bc6 ("staging: android: Fix checkpatch block comments warnings")
which tre
On Tue, Oct 27, 2015 at 06:20:14PM +0900, Glen Lee wrote:
> wilc_netdev_init function has parameters to pass but no argument is passed
> when bus type SPI is selected. Which causes build error.
> This patch passes argument &wilc to the function wilc_netdev_init.
>
> Signed-off-by: Glen Lee
Fixes:
On Tue, Oct 27, 2015 at 05:33:37PM +0900, Glen Lee wrote:
> From: Leo Kim
>
> This patch removes goto statement and moves the spin lock position.
> If a memory allocation fails, directly returns an error.
> The spin lock actually protects the pHandle. Therefore, call spin lock just
> before pHand
On 2015/10/28 4:38, Jake Oshins wrote:
>> -Original Message-
>> From: Jiang Liu [mailto:jiang@linux.intel.com]
>> Sent: Tuesday, October 27, 2015 12:11 AM
>> To: Jake Oshins ; gre...@linuxfoundation.org; KY
>> Srinivasan ; linux-ker...@vger.kernel.org;
>> de...@linuxdriverproject.org; o
Hi Ivan,
[auto build test WARNING on staging/staging-next -- if it's inappropriate base,
please suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/Ivan-Safonov/staging-rtl8188eu-integer-type-replaced-by-size_t-in-length-variables/201
This patch fixes line over 80 characters found by checkpatch.
WARNING: line over 80 characters
FILE: drivers/staging/wilc1000/host_interface.h:424:
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dr
This patch replaces kmalloc followed by memcpy with kmemdup.
It is also added error checking to return -ENOMEM when kmemdup is
failed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
This patch changes u8Keyidx to index that is fourth argument of this
function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/d
This patch changes u8mode to mode that is fifth argument of this
function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
This patch changes tenuAuth_type to auth_type that is sixth argument of
this function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff -
This patch changes u8WepKeylen to len that is third argument of this
function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 10 +-
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff -
This patch changes struct host_if_drv of host_int_add_wep_key_bss_ap
function declaration from hWFIDrv to hif_drv.
With this change, first parameter name of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.
This patch changes pu8WepKey to key that is second argument of this
function to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/
This patch changes return type of host_int_add_wep_key_bss_ap from s32
to int. The result variable gets return value from wilc_mq_send that has
return type of int. It should be changed return type of this function as
well as data type of result variable.
Signed-off-by: Chaehyun Lim
---
drivers/s
This patch changes data type of variable i from u8 to int.
It is used as index of an array to print its content. It's better
to use as data type of int.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
On Mon, Jun 23, 2014 at 10:10 PM, David Miller wrote:
> From: Haiyang Zhang
> Date: Mon, 23 Jun 2014 16:09:59 +
>
>> So, what's the equivalent or similar command to "network restart" on SLES12?
>> Could
>> you update the command line for the usermodehelper when porting this patch
>> to SLES
On Tue, Oct 27, 2015 at 05:00:22PM -0400, ira.weiny wrote:
> On Tue, Oct 27, 2015 at 05:46:41PM +0900, Greg KH wrote:
> > On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.we...@intel.com wrote:
> > > From: Jubin John
> > >
> > > Signed-off-by: Jubin John
> > > Signed-off-by: Ira Weiny
> > > ---
>
On Tue, Oct 27, 2015 at 04:51:15PM -0400, ira.weiny wrote:
> On Tue, Oct 27, 2015 at 05:19:10PM +0900, Greg KH wrote:
> > On Mon, Oct 26, 2015 at 10:28:38AM -0400, ira.we...@intel.com wrote:
> > > From: Mitko Haralanov
> > >
> > > Clean up the context and sdma macros and move them to a more logic
On Tue, Oct 27, 2015 at 05:46:41PM +0900, Greg KH wrote:
> On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.we...@intel.com wrote:
> > From: Jubin John
> >
> > Signed-off-by: Jubin John
> > Signed-off-by: Ira Weiny
> > ---
> > drivers/staging/rdma/hfi1/common.h | 2 +-
> > 1 file changed, 1 inser
On Tue, Oct 27, 2015 at 05:19:10PM +0900, Greg KH wrote:
> On Mon, Oct 26, 2015 at 10:28:38AM -0400, ira.we...@intel.com wrote:
> > From: Mitko Haralanov
> >
> > Clean up the context and sdma macros and move them to a more logical place
> > in
> > hfi.h
> >
> > Signed-off-by: Mitko Haralanov
>
> -Original Message-
> From: Jiang Liu [mailto:jiang@linux.intel.com]
> Sent: Tuesday, October 27, 2015 12:11 AM
> To: Jake Oshins ; gre...@linuxfoundation.org; KY
> Srinivasan ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...
On Tue, Oct 27, 2015 at 10:51:39PM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch:
>
> -prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file ch
On Tue, Oct 27, 2015 at 03:32:45PM -0200, Albino B Neto wrote:
> 2015-10-27 15:33 GMT-02:00 Ivan Safonov :
> > Not tested. Is this transformation can to break the code?
>
> Send email to mailing.
>
> Read: https://www.kernel.org/doc/Documentation/SubmittingPatches
What? What was done wrong here
On Tue, Oct 27, 2015 at 03:05:44PM -0200, Albino B Neto wrote:
> 2015-10-27 13:13 GMT-02:00 Ivan Safonov :
> > ARRAY_SIZE shorter and more difficult to create bugs.
> >
> > Signed-off-by: Ivan Safonov
>
> You tested ?
>
Probably most changes on this list have not been tested... It's fine
since
2015-10-27 15:33 GMT-02:00 Ivan Safonov :
> Not tested. Is this transformation can to break the code?
Send email to mailing.
Read: https://www.kernel.org/doc/Documentation/SubmittingPatches
Albino
___
devel mailing list
de...@linuxdriverproject.org
Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
been replaced by is_power_of_2
Signed-off-by: Aya Mahfouz
---
v2:
-became patch number 5 in the series
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz
---
v2:
-added new patch in patch set for selftest.h
drivers/st
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
drivers/staging/lustre/lustre/l
Concerned with the removal of IS_PO2 by replacing its uses
with is_power_of_2 and then removing the definition.
This is the second version of the patch set. The commit messages
were changed and a new patch was added for a use of IS_PO2 indicated
by kbuild test robot.
Aya Mahfouz (5):
staging: l
On 10/28/2015 12:05 AM, Albino B Neto wrote:
2015-10-27 13:13 GMT-02:00 Ivan Safonov :
ARRAY_SIZE shorter and more difficult to create bugs.
Signed-off-by: Ivan Safonov
You tested ?
Albino
Not tested. Is this transformation can to break the code?
___
2015-10-27 13:13 GMT-02:00 Ivan Safonov :
> ARRAY_SIZE shorter and more difficult to create bugs.
>
> Signed-off-by: Ivan Safonov
You tested ?
Albino
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman
On 10/28/2015 12:05 AM, Albino B Neto wrote:
2015-10-27 13:13 GMT-02:00 Ivan Safonov :
ARRAY_SIZE shorter and more difficult to create bugs.
Signed-off-by: Ivan Safonov
You tested ?
Albino
Not tested. Is this transformation can to break the code?
___
This patch is to the host_interface.c that fixes up following
warning by checkpatch:
-prefer eth_broadcast_addr() over memset()
Signed-off-by: Punit Vara
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/ho
> -Original Message-
> From: Jiang Liu [mailto:jiang@linux.intel.com]
> Sent: Tuesday, October 27, 2015 12:10 AM
> To: Jake Oshins ; gre...@linuxfoundation.org; KY
> Srinivasan ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...
`waveform_ai_interrupt()` is a timer expiry function used to generate
fake waveform data for an analog input subdevice. Rename it to
`waveform_ai_timer()`.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/comedi_test.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
For asynchronous command handling on the analog input subdevice, a
kernel timer routine is used to generate the fake waveform data. A
"scan" consists of a number of conversions separated in time by a
conversion period. Successive scans are separated in time by a scan
period, which is at least the
The asynchronous command handling for the analog input subdevice uses a
kernel timer which expires approximately `HZ` times a second. However,
it only needs to do anything after each scan period. Set the timer to
expire just after the next scan period.
Although the timer expiry function `wavefor
The private data structure `struct waveform_private` currently uses
member `last` to remember the time of the last timer interrupt, and the
member `usec_remainder` to keep track of how far into a simulated scan
the interrupt occurred. Replace these with a single new member
`ai_last_scan_time` that
Rename the members of `struct waveform_private` that are used to handle
AI commands, apart from those members used to control fake waveform
generation. The renames are `timer` --> `ai_timer`, `scan_period` -->
`ai_scan_period`, and `convert_period` --> `ai_convert_period`.
Signed-off-by: Ian Abbo
The `static const int nano_per_micro` variable is set to 1000, the
number of nanoseconds in a microsecond. Remove it and use the
`NSEC_PER_USEC` macro from instead.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/comedi_test.c | 17 +++--
1 file changed, 7 insertions(+
The fake waveform generator functions, `fake_sawtooth()` and
`fake_squarewave()`, called from `fake_waveform()`, have a
`current_time` parameter which is the time since the start of a waveform
period. The parameter value may be greater than the waveform period so
they do a modulo operation to brin
Implement COMEDI asynchronous commands on the fake analog output
subdevice. This is useful for testing asynchronous commands in the
"write" direction when no real hardware is available.
A normal kernel timer is used to drive the command. The new timer
expiry function `waveform_ao_timer()` handle
The last sample values written to the AO subdevice channels by its
"insn_write" handler `waveform_ao_insn_write()` are stored in the member
array `ao_loopbacks[]` in the device private data `struct
waveform_private`. They can be read back via the "insn_read" handler of
the AI subdevice `waveform_a
Use `unsigned int` instead of `unsigned long` to hold the period of the
fake waveform generator and the current time within each waveform. The
waveform period will be no more than `INT_MAX` and the current time
within the waveform (prior to the modulo operation to bring it actually
within the wave
Rename the members `struct waveform_private` associated with fake
waveform generation. The affected members are `uvolt_amplitude` -->
`wf_amplitude` (the amplitude of the waveform), `usec_period` -->
`wf_period` (the period of the waveform), and `usec_current` -->
`wf_current` (the current time wi
COMEDI drivers often allow the last value written to a channel on an
analog output subdevice to be read back via the "insn_read" handler.
The "comedi_test" driver does not currently support that. It is a bit
special because it loops back the last values written to the channel on
the analog output
The "comedi_test" module is a driver for a dummy COMEDI device. It has
an analog input subdevice and an analog output subdevice. The analog
input subdevice supports COMEDI asynchronous acquisition commands using
waveform generators to generate the input data for each channel. A
kernel timer is u
It is quite common for COMEDI subdevices that support commands to
support setting `scan_begin_src` to `TRIG_FOLLOW`. This means the next
scan begins once all conversions in the current scan are complete.
Support the following timing combinations for the AI subdevice:
scan_begin_src == TRIG_TIME
When testing the parameters for setting up an asynchronous command on
the AI subdevice, limit the maximum conversion period
(`cmd->convert_arg`) so that the number of conversions in a scan
(`cmd->scan_end_arg`, same as `cmd->chanlist_len`) multiplied by the
conversion period fits within an `unsigne
Use the preferred style for multi-line comments.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/comedi_test.c | 94 ++--
1 file changed, 47 insertions(+), 47 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_test.c
b/drivers/staging/comedi/dr
While an asynchronous command is running on the analog input subdevice,
fake waveform generators are connected to each channel to provide the
input voltages that are converted to sample value. Channel 0 is
connected to a sawtooth generator, channel 1 is connected to a
squarewave generator, and the
Channel numbers greater than 14 are used here, which are possible only
for the 5 GHz frequency.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rtl8188eu/hal/rtl81
hal_data->MCSTxPowerLevelOriginalOffset[pwrGrpCnt] frequent in this function,
so it replaced by the power_level_offset new variable.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/bb_cfg.c | 34 ++
1 file changed, 18 ins
This patch removes unused SUCCESS and FAIL macros in include/basic_types.h.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/include/basic_types.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/basic_types.h
b/drivers
The increment at the end of the cycle, and it can be placed in the loop header.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_
This variable used only once in the beginning of the function,
it can be removed.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- subject corrected.
drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_c
x = x + a and x += a equivalen, but second preferably.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/core/rtw_recv.c | 6 +++---
drivers/staging/rtl8188eu/hal/mac_cfg.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/stagin
This is checkpatch fixes for hal/bb_cfg.c file:
spaces preferred around that '|'.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/bb_cfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c
b/drive
abs macro is useful for determining the difference between the two integers.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/phy.c
b/drivers/staging/
This is checkpatch fixes for hal/bb_cfg.c file:
unnecessary parentheses around .
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/bb_cfg.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c
ARRAY_SIZE shorter and more difficult to create bugs.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/mac_cfg.c| 2 +-
drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +-
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +-
3 files changed,
Kernel macros used,
unnecessary macro removed,
some checkpatch fixes performed
and other changes added.
---
Changes in v2:
- patch 21 subject corrected.
- patch 15 (staging: rtl8188eu: BITn macro replaced by BIT(n) in hal/bb_cfg.c)
removed. It is no longer relevant.
- min replaced by mit_
min_t macro better conveys the meaning of the code.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- min replaced by mit_t.
drivers/staging/rtl8188eu/core/rtw_ap.c| 2 +-
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 ++--
This is checkpatch fixes for hal/bb_cfg.c file:
alignment should match open parenthesis.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/bb_cfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c
This patch removes unused MIN macro from include/rtw_security.h.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/include/rtw_security.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_security.h
b/drivers/staging/
min (or max) kernel macro better conveys the meaning of the code.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 6 ++
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++--
drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 2 +-
This is checkpatch fixes for hal/bb_cfg.c file: Avoid CamelCase.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/bb_cfg.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c
b/drivers/s
To limit the range of integers there is clamp macro.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c
b/drivers/staging/rtl8188e
This patch replaces while loop with for loop, because the initial condition and
the increment clearly and briefly defined for this loop.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/core/rtw_mlme.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(
This is checkpatch fixes for hal/bb_cfg.c file:
line over 80 characters.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/hal/bb_cfg.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c
b/d
min_t macro better conveys the meaning of the code.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- min replaced by mit_t.
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +-
3 fi
This patch removes unused MEM_ALIGNMENT_OFFSET and MEM_ALIGNMENT_PADDING macros
from include/basic_types.h.
Signed-off-by: Ivan Safonov
---
Changes in v2: no changes.
drivers/staging/rtl8188eu/include/basic_types.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
On Tue, Oct 27, 2015 at 3:27 PM, Tomeu Vizoso
wrote:
> PM domains shouldn't be modified after a device is probed, so set it
> before device registration to be sure of that.
>
> In the future the PM domain pointer will be set through a setter that
> will WARN if the device has been probed already.
PM domains shouldn't be modified after a device is probed, so set it
before device registration to be sure of that.
In the future the PM domain pointer will be set through a setter that
will WARN if the device has been probed already.
Signed-off-by: Tomeu Vizoso
Cc: Geert Uytterhoeven
---
driv
1 - 100 of 156 matches
Mail list logo
