abs macro is useful for determining the difference between the two integers.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- big patchset splitted into some small independent patches.
drivers/staging/rtl8188eu/hal/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
On Sun, Oct 25, 2015 at 05:41:22PM -0500, Lijun Pan wrote:
> Introduce the rescan attribute as a bus attribute to
> synchronize the fsl-mc bus objects and the MC firmware.
>
> To rescan the fsl-mc bus, e.g.,
> echo 1 > /sys/bus/fsl-mc/rescan
>
> Signed-off-by: Lijun Pan
> ---
> drivers/staging/
On Tue, Oct 27, 2015 at 01:21:46AM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch.pl:
>
> -Prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file
On Sun, 2015-10-25 at 17:41 -0500, Lijun Pan wrote:
> The kernel support for the restool (a user space resource management
> tool) is a driver for the /dev/dprc.N device file.
> Its purpose is to provide an ioctl interface,
> which the restool uses to interact with the MC bus driver
> and with the
min_t macro better conveys the meaning of the code.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- big patchset splitted into some small independent patches.
- min replaced by min_t.
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
min macro better conveys the meaning of the code.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- big patchset splitted into some small independent patches.
- before replacing (?:) to macro min variables given to the appropriate type.
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
wpa_ie_len and copy_len variables never take negative values and are used to
indicate the length of the string, so more suitable for them size_t type.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- big patchset splitted into some small independent patches.
- before replacing (?:) to macro
> -Original Message-
> From: Lijun Pan [mailto:lijun@freescale.com]
> Sent: Sunday, October 25, 2015 5:41 PM
> To: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org;
> linux-ker...@vger.kernel.org
> Cc: Yoder Stuart-B08248; katz Itai-RM05202; Rivera Jose-B46482; L
Hi Jake,
[auto build test ERROR on next-20151022 -- if it's inappropriate base, please
suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/jakeo-microsoft-com/New-paravirtual-PCI-front-end-for-Hyper-V-VMs/20151027-072118
config: powerpc-defconfig
Hi Jake,
[auto build test ERROR on next-20151022 -- if it's inappropriate base, please
suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/jakeo-microsoft-com/New-paravirtual-PCI-front-end-for-Hyper-V-VMs/20151027-072118
config: parisc-b180_defco
Hi Jake,
[auto build test WARNING on next-20151022 -- if it's inappropriate base, please
suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/jakeo-microsoft-com/New-paravirtual-PCI-front-end-for-Hyper-V-VMs/20151027-072118
config: i386-allmodconf
Hi Jake,
[auto build test ERROR on next-20151022 -- if it's inappropriate base, please
suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/jakeo-microsoft-com/New-paravirtual-PCI-front-end-for-Hyper-V-VMs/20151027-072118
config: x86_64-randconfig
From: Jake Oshins
This patch introduces a new driver which exposes a root PCI bus whenever a PCI
Express device is passed through to a guest VM under Hyper-V. The device can
be single- or multi-function. The interrupts for the devices are managed by an
IRQ domain, implemented within the driver.
From: Jake Oshins
The Linux kernel already has the concept of IRQ domain, wherein a component
can expose a set of IRQs which are managed by a particular interrupt controller
chip or other subsystem. The PCI driver exposes the notion of an IRQ domain
for Message-Signaled Interrupts (MSI) from PCI
From: Jake Oshins
This patch series updates the one sent on Sept. 10, mostly by rebasing on
Mark Zyngier's changes around IRQ domains and the OF tree.
First, export functions that allow correlating Hyper-V virtual processors
and Linux cpus, along with the means for invoking a hypercall that targ
From: Jake Oshins
This patch exposes the mapping between Linux CPU number and Hyper-V virtual
processor number. This is necessary because the hypervisor needs to know which
virtual processors to target when making a mapping in the Interrupt Redirection
Table in the I/O MMU.
Signed-off-by: Jake O
From: Jake Oshins
This defines the channel type for PCI front-ends in Hyper-V VMs.
Signed-off-by: Jake Oshins
---
include/linux/hyperv.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index ea0a0e3..5587899 100644
--- a/include/
From: Jake Oshins
This patch exposes the function that hv_vmbus.ko uses to make hypercalls. This
is necessary for retargeting an interrupt when it is given a new affinity.
Signed-off-by: Jake Oshins
---
drivers/hv/hv.c | 20 ++--
drivers/hv/hyperv_vmbus.h | 2 +-
inc
From: Jake Oshins
This patch allows a PCI front-end implementation to supply an fwnode_handle
associated with a root PCI bus, optionally. If supplied, the PCI driver
records this.
This patch supports the next patch in the series, which looks up an IRQ domain
through this handle.
Signed-off-by:
From: Jake Oshins
The existing PCI code looks for an IRQ domain associated with a root PCI bus
by looking in the Open Firmware tree. This patch introduces a second way
to identify the associated IRQ domain, if the lookup in the OF tree fails.
The handle used for the IRQ domain lookup was introdu
On 10/25/15 3:16 PM, Dzonatans Melgalvis wrote:
Fixed checkpatch.pl warning about comment block coding style.
The right aligned comments aren't great style.
How about moving the comments (with the correct style) right
above the macro they are describing.
Signed-off-by: Dzonatans Melgalvis
-
This patch is to the host_interface.c that fixes up following
warning by checkpatch.pl:
-Prefer eth_broadcast_addr() over memset()
Signed-off-by: Punit Vara
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000
min_t macro better conveys the meaning of the code.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- big patchset splitted into some small independent patches.
- min replaced by min_t.
drivers/staging/rtl8188eu/core/rtw_ap.c| 2 +-
drivers/staging/rtl8188eu/core/rtw_ieee80211.c |
min (or max) kernel macro better conveys the meaning of the code.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- big patchset splitted into some small independent patches.
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 6 ++
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++--
dri
There is no need to use fixed width data types.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c
b/drivers/staging/rtl8188eu/core/rtw_debug.c
index 993c7d
To limit the range of integers there is clamp macro.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- big patchset splitted into some small independent patches.
drivers/staging/rtl8188eu/core/rtw_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl
ARRAY_SIZE shorter and more difficult to create bugs.
Signed-off-by: Ivan Safonov
---
Changes in v2:
- big patchset splitted into some small independent patches
drivers/staging/rtl8188eu/hal/mac_cfg.c| 2 +-
drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +-
drivers/staging/rtl818
Created an MSI domain for the fsl-mc bus-- including functions
to create a domain, find a domain, alloc/free domain irqs, and
bus specific overrides for domain and irq_chip ops.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/Kconfig | 1 +
drivers/staging/fsl-mc/bus/Ma
The interrupt handler for DPRC IRQs is added. DPRC IRQs are
generated for hot plug events related to DPAA2 objects in a given
DPRC. These events include, creating/destroying DPAA2 objects in
the DPRC, changing the "plugged" state of DPAA2 objects and moving
objects between DPRCs.
Signed-off-by: J.
All the IRQs for DPAA2 objects in the same DPRC must use
the ICID of that DPRC, as their device Id in the GIC-ITS.
Thus, all these IRQs must share the same ITT table in the GIC.
As a result, a pool of IRQs with the same device Id must be
preallocated per DPRC (fsl-mc bus instance). So, the fsl-mc
b
The DPRC built-in portal's mc_io is used to send commands to the MC
to program MSIs for MC objects. This is done by the
fsl_mc_msi_write_msg() callback, which is invoked by the generic MSI
layer with interrupts disabled. As a result, the mc_io used in
fsl_mc_msi_write_msg needs to be an atomic mc_i
On Mon, Oct 26, 2015 at 08:41:06PM +0700, Ivan Safonov wrote:
> On 10/26/2015 04:06 PM, Dan Carpenter wrote:
> >On Sat, Oct 24, 2015 at 08:42:29PM +0700, Ivan Safonov wrote:
> >>diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> >>b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> >>ind
Scan the corresponding DPRC container to get total count
of IRQs needed by all its child DPAA2 objects. Then,
preallocate a set of MSI IRQs with the DPRC's ICID
(GIT-ITS device Id) to populate the the DPRC's IRQ pool.
Each child DPAA2 object in the DPRC and the DPRC object itself
will allocate thei
Added platform-specific MSI support layer for FSL-MC devices.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/Makefile| 1 +
.../staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 127 +
drivers/staging/fsl-mc/include/mc-private.h| 4 +
Initialize/Cleanup ITS-MSI support for the MC bus driver at driver
init/exit time. Associate an MSI domain with each DPAA2 child device.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/mc-bus.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/fsl-m
Destroy mc_io in error path in dprc_probe() only if the mc_io was
created in this function. Minor refactoring in error labels.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/d
Since an FSL-MC bus is a new bus type that is neither PCI nor
PLATFORM, we need a new domain bus token to disambiguate the
IRQ domain for FSL-MC MSIs.
Signed-off-by: J. German Rivera
---
include/linux/irqdomain.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/irqdomain.h b/inc
This patch series addresses the following item from the TODO list
for the MC bus driver to exit staging:
* Interrupt support. For meaningful driver support we need
interrupts, and thus need message interrupt support by the bus
driver.
MC Bus MSI Support Architecture
==
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Sunday, October 25, 2015 7:13 PM
> To: Pan Lijun-B44306
> Cc: a...@arndb.de; de...@driverdev.osuosl.org; linux-
> ker...@vger.kernel.org; Yoder Stuart-B08248 ;
> katz Itai-RM05202 ; Rivera Jose-B46482
> ; Li
THE MSI domain associated with a root DPRC object is
obtained form the device tree. Child DPRCs inherit
the parent DPRC MSI domain.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 39
1 file changed, 39 insertions(+)
diff --git a/d
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, October 26, 2015 1:20 AM
> To: Pan Lijun-B44306
> Cc: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org;
> linux-ker...@vger.kernel.org; Yoder Stuart-B08248
> ; katz Itai-RM05
> -Original Message-
> From: Lijun Pan [mailto:lijun@freescale.com]
> Sent: Sunday, October 25, 2015 5:41 PM
> To: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org;
> linux-ker...@vger.kernel.org
> Cc: Yoder Stuart-B08248; katz Itai-RM05202; Rivera Jose-B46482; L
From: Jubin John
The name used to create the verbs txreq cache was not qualified with the unit
number. This causes a panic when destroying the cache on a dual HFI systems.
Create a unique name with the unit number with this patch
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
Signed-o
From: Mike Marciniszyn
The workqueue is currently single threaded per port which for a small number of
SDMA engines is ok.
For hfi1, the there are up to 16 SDMA engines that can be fed descriptors in
parallel.
This patch:
- Converts to use alloc_workqueue
- Changes the workqueue limit from 1 to
From: Jubin John
Signed-off-by: Jubin John
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rdma/hfi1/common.h
b/drivers/staging/rdma/hfi1/common.h
index 7809093eb55e..5dd92720faae 100644
--- a/
From: Mike Marciniszyn
Add additional rc traces to aid in debugging rc retry logic.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Mike Marciniszyn
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/rc.c| 4
drivers/staging/rdma/hfi1/trace.c | 4 ++--
drivers/staging/rdma/hfi1
From: Mitko Haralanov
Expected receives work by user-space libraries (PSM) calling into the
driver with information about the user's receive buffer and have the driver
DMA-map that buffer and program the HFI to receive data directly into it.
This is an expensive operation as it requires the driv
From: Easwar Hariharan
Using fw_sbus_load to control SBus firmware load doesn't scale across multiple
HFI1 cards in a single system. This patch ensures that the SBus firmware is
loaded once per ASIC.
Reviewed-by: Dean Luick
Reviewed-by: Dennis Dalessandro
Signed-off-by: Easwar Hariharan
Signe
From: Dean Luick
When under heavy load, the receive interrupt handler can run too long with IRQs
disabled. Add a mixed-mode threading scheme. Initially process packets in the
handler for quick responses (latency). If there are too many packets to
process move to a thread to continue (bandwidth
From: Dean Luick
When under heavy load, the send handler can run too long without allowing other
tasks to run. Add a conditional resched to break this up.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dean Luick
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/chip.c | 10 ++
From: Mitko Haralanov
The address being mapped into a process's memory for notification events was
improperly calculated due to cast that was happening too early. dd->events is a
pointer and should have been casted to unsigned long after the pointer
arithmetic was done, not before.
As a result,
From: Mitko Haralanov
Clean up the context and sdma macros and move them to a more logical place in
hfi.h
Signed-off-by: Mitko Haralanov
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/hfi.h | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/dr
From: Easwar Hariharan
The DC firmware overwrites the enable_lane_tx register and does not update it
on a host request to go to Poll. This causes an infinite loop through the LNI
state machine if a link width downgrade occurs. This patch re-sets the
enable_lane_tx register to all 4 lanes.
Review
From: Dean Luick
In preparation for threading the receive interrupt, add irqsaves in the packet
processing path.
When the receive interrupt is threaded, the packet processing path is no longer
guaranteed to have IRQs disabled. Add irqsaves where needed on several locks
in the packet processing
From: Easwar Hariharan
The QSFP interface code has been running without issues and the flag is
never set to off. This patch removes the QSFP_ENABLED bit from HFI1_CAP.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Easwar Hariharan
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/chip.c
From: Mitko Haralanov
The SDMA engines were configured to generate progress interrupts every time they
processed N/2 descriptors (where N is the size of the descriptor queue). This
interval was too infrequent, leading to degraded performance.
This commit adds a module parameter, as well as a rec
From: Mitko Haralanov
User SDMA keeps track of progress into the submitted IO vectors by tracking an
offset into the vectors when packets are submitted. This offset is updated
after a successful submission of a txreq to the SDMA engine.
The same offset was used when determining whether an IO vec
From: Niranjana Vishwanathapura
This fixes transmit errors when the number of scatter gather elements in the
request is more that the number of per packet descriptors supported by the
hardware, allocate and coalesce the extra scatter gather elements into a single
buffer. The last descriptor is re
From: Jareer Abdel-Qader
Driver does not verify userid for shared context assignments, allowing
malicious user access.
Reviewed by: Mike Marciniszyn
Signed-off-by: Jareer H Abdel-Qader
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 1 +
1 file changed, 1 insertion(+)
di
From: Caz Yokoyama
Reset firmware instead of reloading Sbus firmware if it's already done for this
ASIC. To work around thermal polling problem in firmware, don't reload Sbus
firmware, instead, reset the firmware on the initialization of the second HFI.
Reviewed-by: Easwar Hariharan
Reviewed-b
From: Ignacio Hernandez
A value of 2048 increased PSM performance while not impacting verbs
performance.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Mitko Haralanov
Signed-off-by: Ignacio Hernandez
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/sdma.c | 2 +-
1 file changed, 1 insert
From: Easwar Hariharan
The ASIC registers were not reset on FLR, and the code to
protect the ASIC block against multiple initializations by
peer HFIs did not extend to multiple ASICs in a system. This
patch addresses this gap.
Reviewed-by: Dean Luick
Signed-off-by: Easwar Hariharan
Signed-off-
From: Dean Luick
The latest version of the 8051 firmware will wait longer
when bringing the link down. Extend the driver's timeout
to go with that.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/chip.c | 2 +-
1 file changed,
From: Mike Marciniszyn
The clear_ahg call is new in hfi1 vs qib. For small messages the progress
routine always builds one and clears out the ahg state when the queue has gone
to empty which is the predominant case for small messages.
Inline the routine and avoid the call to sdma_ahg_free to mi
From: Ira Weiny
The following are fixes to the hfi1 driver for stability, security, and
performance.
Changes from v2:
Rebased to latest staging-next
Update commit messages
Squashed these patches together:
0006-staging-rdma-hfi1-Add-coalescing-support-for
From: Vennila Megavannan
If packets stop egressing the hardware link, software can lock up.
Implement a timeout for send context halt recovery. This patch increases the
timeout for packet egress to 500 us and timer resets to zero if the packet
occupancy changes. Also we bounce the link on time
On 10/26/2015 04:06 PM, Dan Carpenter wrote:
On Sat, Oct 24, 2015 at 08:42:29PM +0700, Ivan Safonov wrote:
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index 98bdc95..735e24b 100644
--- a/drivers/staging/rtl8188eu/os_dep/ioctl_linu
James Simmons wrote:
> From: frank zago
>
> Point to the right place for GNU license. Update Intel copyright.
> Update Nathan Rutmans email address. This was broken out of the
> original patch 14270.
>
> [...]
>
> - * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
> - *
> - * Please
On 2015년 10월 26일 17:23, Greg KH wrote:
On Mon, Oct 26, 2015 at 11:08:43AM +0900, glen lee wrote:
On 2015년 10월 25일 10:29, Greg KH wrote:
On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote:
Use netdev private member wilc instead of g_linux_wlan and Change argument wilc
with dev in the f
On Sat, Oct 24, 2015 at 08:42:29PM +0700, Ivan Safonov wrote:
> diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> index 98bdc95..735e24b 100644
> --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8188eu/os
On Sat, Oct 24, 2015 at 08:34:55PM +0700, Ivan Safonov wrote:
> min macro better conveys the meaning of the code.
>
Don't these introduce warnings that min_t() is more appropriate?
regards,
dan carpetner
___
devel mailing list
de...@linuxdriverproject
On Fri, Oct 23, 2015 at 03:59:14PM -0400, James Simmons wrote:
> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> index 635a93c..d6d70d8 100644
> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> +++ b/drivers/staging/lustre/lustre/lmv/lm
On Mon, Oct 26, 2015 at 11:08:43AM +0900, glen lee wrote:
>
>
> On 2015년 10월 25일 10:29, Greg KH wrote:
> >On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote:
> >>Use netdev private member wilc instead of g_linux_wlan and Change argument
> >>wilc
> >>with dev in the function request_threade
Hi,
These patches replace usage of OBD_PAGE_ALLOC and OBD_PAGE_FREE with alloc_page
and __free_page respectively and remove the OBD_PAGE_ALLOC/FREE and supporting
macros
Mike Rapoport (2):
staging: lustre: get rid of OBD_PAGE_ALLOC/FREE
staging: lustre: remove unused OBD_PAGE_ALLOC/FREE and f
Use alloc_page and __free_page instead
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/obdecho/echo_client.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c
b/drivers/staging/lustre/lustre/obdecho/echo_cl
The OBD_PAGE_ALLOC/FREE and related macros are not used and can be
removed
Signed-off-by: Mike Rapoport
---
.../staging/lustre/lustre/include/obd_support.h| 30 --
1 file changed, 30 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd_support.h
b/drivers
Fix wrong indentation of a line in lynxfb_set_fbinfo
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 707e91d..8f6908b 100644
--- a/drivers/
There are several occurencies of '#ifdef CAP_EXP', spelled
differently each time. None of these is ever defined and therefore they
enclose dead code that can be removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 18 --
1 file changed, 18 deletions(-)
dif
The lynx_share field in lynx_cursor structure is never used and can be
removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 1 -
drivers/staging/sm750fb/sm750.h | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/
Both struct lynx_share and struct sm750_dev reprsent some parts of the
SM750 graphics adapter. There is no point to keep these parts in
different structures.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c| 209 +
drivers/staging/sm750fb/s
The {x,y}LCD fields of struct sm750_dev are not used and can be removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 6002e37..b0a93cd 100644
--- a/dri
Use sm750_dev as private driver data for the PCI device
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index ac8e2a4..707e91d 100
The custom macro PADDING differs from standard kernel ALIGN only in
parameters order. Replace PADDING with ALIGN and remove it's definition.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c| 8
drivers/staging/sm750fb/sm750.h| 2 --
drivers/staging/sm750fb/sm750_
The struct sm750_share represents the device state and name sm750_dev
seems more appropriate.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c| 16
drivers/staging/sm750fb/sm750.h| 4 ++--
drivers/staging/sm750fb/sm750_hw.c | 8
3 files changed
The PROC_SPEC* typedefs are not used and can be removed
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index ad20a8a..46c236e 100644
--- a/drivers/staging/sm
The struct sm750_state is never used on its own. Merge it into the
struct sm750_dev.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c| 40 +++---
drivers/staging/sm750fb/sm750.h| 17 +++-
drivers/staging/sm750fb/sm750_hw.c | 10
Use proper 'struct sm750_dev *' type instead of 'void *'
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 58fcea5..ac8e2a4 100644
--- a/driv
There is no actual need to split type definitions and global function
declarations between lots of small headers.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c| 1 -
drivers/staging/sm750fb/sm750.h| 88 +-
drivers/staging/sm750fb/sm750_
Use sm750_dev rather than lynx_share as parameter for hw_sm750_map,
hw_sm750_inithw and hw_sm750_initAccel functions.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c| 15 ---
drivers/staging/sm750fb/sm750.h| 6 +++---
drivers/staging/sm750fb/sm750_hw.c | 16
The smi_indent variable is only declared, but never used. Remove it.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 2 --
drivers/staging/sm750fb/sm750.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
in
The hw_sm750_getVMSize wraps ddk750_getVMSize without any added
functionality. Call ddk750_getVMSize directly and remove
hw_sm750_getVMSize.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.h| 1 -
drivers/staging/sm750fb/sm750_hw.c | 13 ++---
2 files changed, 2 inser
Use consistent naming for 'struct sm750_dev' variables
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c| 66 +++---
drivers/staging/sm750fb/sm750_hw.c | 18 +--
2 files changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/st
Use sm750_dev instead of lynx_share in the private data of the
frambuffer device.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c| 18 +-
drivers/staging/sm750fb/sm750.h| 2 +-
drivers/staging/sm750fb/sm750_hw.c | 6 +++---
3 files changed, 13 insertion
The methods in lynx_cursor always use the same implementation and there is
no point to use redirection rather than direct function call.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.c | 34 ++
drivers/staging/sm750fb/sm750.h | 7 ---
2 files
Hi,
The sm750 adapter state is currently represented with several structures that
are nested into each other. That division does not seem necessary and single
structure is quite enough to hold the adapter state.
These patchset refactors the code to merge the adapter state representaion into
a sing
The SPC_SM750 define is not used and can be removed
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/sm750.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index c2c217f..2a785ca 100644
--- a/drivers/staging/sm750fb/
96 matches
Mail list logo
