[PATCH V2 11/12] staging: wilc1000: introduce struct wilc_sdio for sdio data

This patch introduces struct wilc_sdio for sdio driver data. The wilc_sdio is allocated and set as driver data when the sdio is probed and deallocated when the sdio is removed. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan_sdio.c | 16 1 file changed, 16 insert

[PATCH V2 12/12] staging: wilc1000: assign pointer of g_linux_wlan to sdio device data

This patch assigns wl pointer to sdio device data. The global variable g_linux_wlan will be removed finally. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 5 +++-- drivers/staging/wilc1000/linux_wlan_sdio.c| 5 +++-- drivers/staging/wilc1000/wilc_wfi_netdevice.h

[PATCH V2 10/12] staging: wilc1000: remove COMPLEMENT_BOOT

This patch removes a preprocessor definition, COMPLEMENT_BOOT which is not used anymore. This is just workaround to avoid weird issue, which is that 11b core is not ready after the power is givin to the chip. However, this issue happened only in the unstable hardware a long time ago and no more see

[PATCH V2 08/12] staging: wilc1000: move clean up codes into wl_wlan_cleanup function

This patch moves clean up codes from exit_wilc_driver into the wl_wlan_cleanup newly introduced in this patch. In addition, it is called by linux_sdio_remove function. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 95 --- drivers/staging/wilc

[PATCH V2 09/12] staging: wilc1000: rename wilc_firmware in the struct wilc

This patch renames wilc_firmware in the struct wilc to the firmware. In addition, null assignments to the wl->firmware after release_firmware are removed because it is not necessary. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 15 +++ drivers/staging/w

[PATCH V2 05/12] staging: wilc1000: rename aBSSID in the sturct wilc_vif

This patch renames aBSSID in the struct wilc_vif to the bssid. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 14 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 3 files chan

[PATCH V2 02/12] staging: wilc1000: rename u8NoIfcs in the struct wilc

This patch renames u8NoIfcs of the struct wilc to the vif_num to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 18 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 2 files changed, 10 insertions(+), 10 dele

[PATCH V2 07/12] staging: wilc1000: rename wilc_netdev in the struct wilc_vif

This patch renames wilc_netdev in the struct wilc_vif to the ndev. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 50 +++ drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 34 +++ drivers/staging/wilc1000/wilc_wfi_netdevice.h

[PATCH V2 04/12] staging: wilc1000: rename aSrcAddress in the struct wilc_vif

This patch renames aSrcAddress in the struct wilc_vif to the src_addr. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 3 files changed

[PATCH V2 03/12] staging: wilc1000: rename strInterfaceInfo in the sturct wilc

This patch renames strInterfaceInfo in the struct wilc to the vif. In addition, unnecessary print statements around it are removed in this patch. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 91 +++ drivers/staging/wilc1000/wilc_wfi_cfgopera

[PATCH 00/12] WILC1000 V2 for the g_linux_wlan

The series of V2 restore the global variable, wl to g_linux_wlan which is its original name becasue it will be replaced with local structure and deleted. Tony Cho (12): staging: wilc1000: change the type of wilc1000_initialized staging: wilc1000: rename u8NoIfcs in the struct wilc staging: w

[PATCH V2 06/12] staging: wilc1000: rename drvHandler in the struct wilc_vif

This patch renames drvHandler in the struct wilc_vif to the hif_drv. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 24 +++ drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 3

[PATCH V2 01/12] staging: wilc1000: change the type of wilc1000_initialized

This patch changes the type of wilc1000_initialized in the struc wilc from int to bool and also renames it to the initialized. In addition, unnecessary wilc1000_initialized codes are removed in this patch. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 13 +--

[PATCH v2 18/22] staging/rdma/hfi: modify workqueue for parallelism

From: Mike Marciniszyn The workqueue is currently single threaded per port which for a small number of SDMA engines is ok. For hfi1, the there are up to 16 SDMA engines that can be fed descriptors in parallel. This patch: - Converts to use alloc_workqueue - Changes the workqueue limit from 1 to

[PATCH v2 21/22] staging/rdma/hfi1: add additional rc traces

From: Mike Marciniszyn Add additional rc traces to aid in debugging rc retry logic. Reviewed-by: Dennis Dalessandro Signed-off-by: Mike Marciniszyn Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/rc.c| 4 drivers/staging/rdma/hfi1/trace.c | 4 ++-- drivers/staging/rdma/hfi1

[PATCH v2 19/22] staging/rdma/hfi1: Load SBus firmware once per ASIC

From: Easwar Hariharan Using fw_sbus_load to control SBus firmware load doesn't scale across multiple HFI1 cards in a single system. This patch ensures that the SBus firmware is loaded once per ASIC. Reviewed-by: Dean Luick Reviewed-by: Dennis Dalessandro Signed-off-by: Easwar Hariharan Signe

[PATCH v2 16/22] staging/rdma/hfi1: Add irqsaves in the packet processing path

From: Dean Luick In preparation for threading the receive interrupt, add irqsaves in the packet processing path. When the receive interrupt is threaded, the packet processing path is no longer guaranteed to have IRQs disabled. Add irqsaves where needed on several locks in the packet processing

[PATCH v2 22/22] staging/rdma/hfi1: Update driver version string to 0.9-294

From: Jubin John Signed-off-by: Jubin John Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rdma/hfi1/common.h b/drivers/staging/rdma/hfi1/common.h index 7809093eb55e..5dd92720faae 100644 --- a/

[PATCH v2 14/22] staging/rdma/hfi1: Implement Expected Receive TID caching

From: Mitko Haralanov Expected receives work by user-space libraries (PSM) calling into the driver with information about the user's receive buffer and have the driver DMA-map that buffer and program the HFI to receive data directly into it. This is an expensive operation as it requires the driv

[PATCH v2 17/22] staging/rdma/hfi1: Thread the receive interrupt.

From: Dean Luick When under heavy load, the receive interrupt handler can run too long with IRQs disabled. Add a mixed-mode threading scheme. Initially process packets in the handler for quick responses (latency). If there are too many packets to process move to a thread to continue (bandwidth

[PATCH v2 15/22] staging/rdma/hfi1: Allow tuning of SDMA interrupt rate

From: Mitko Haralanov The SDMA engines were configured to generate progress interrupts every time they processed N/2 descriptors (where N is the size of the descriptor queue). This interval was too infrequent, leading to degraded performance. This commit adds a module parameter, which allows for

[PATCH v2 20/22] staging/rdma/hfi1: Add unit # to verbs txreq cache name

From: Jubin John The name used to create the verbs txreq cache was not qualified with the unit number. This causes a panic when destroying the cache on a dual HFI systems. Create a unique name with the unit number with this patch Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John Signed-o

[PATCH v2 13/22] staging/rdma/hfi1: Macro code clean up

From: Mitko Haralanov Clean up the context and sdma macros and move them to a more logical place in hfi.h Signed-off-by: Mitko Haralanov Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/hfi.h | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/dr

[PATCH v2 12/22] staging/rdma/hfi1: Prevent silent data corruption with user SDMA

From: Mitko Haralanov User SDMA keeps track of progress into the submitted IO vectors by tracking an offset into the vectors when packets are submitted. This offset is updated after a successful submission of a txreq to the SDMA engine. The same offset was used when determining whether an IO vec

[PATCH v2 11/22] staging/rdma/hfi1: Fix port bounce issues with 0.22 DC firmware

From: Easwar Hariharan The DC firmware overwrites the enable_lane_tx register and does not update it on a host request to go to Poll. This causes an infinite loop through the LNI state machine if a link width downgrade occurs. This patch re-sets the enable_lane_tx register to all 4 lanes. Review

[PATCH v2 06/22] staging/rdma/hfi1: Add coalescing support for SDMA TX descriptors

From: Niranjana Vishwanathapura This fixes transmit errors when the number of scatter gather elements in the request is more that the number of per packet descriptors supported by the hardware, allocate and coalesce the extra scatter gather elements into a single buffer. The last descriptor is re

[PATCH v2 09/22] staging/rdma/hfi1: Reset firmware instead of reloading Sbus

From: Caz Yokoyama Reset firmware instead of reloading Sbus firmware if it's already done for this ASIC. To work around thermal polling problem in firmware, don't reload Sbus firmware, instead, reset the firmware on the initialization of the second HFI. Reviewed-by: Easwar Hariharan Reviewed-b

[PATCH v2 04/22] staging/rdma/hfi1: Prevent host software lock up

From: Vennila Megavannan If packets stop egressing the hardware link, software can lock up. Implement a timeout for send context halt recovery. This patch increases the timeout for packet egress to 500 us and timer resets to zero if the packet occupancy changes. Also we bounce the link on time

[PATCH v2 10/22] staging/rdma/hfi1: Add a schedule in send thread

From: Dean Luick When under heavy load, the send handler can run too long without allowing other tasks to run. Add a conditional resched to break this up. Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/chip.c | 10 ++

[PATCH v2 07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file

From: Niranjana Vishwanathapura Use NULL instead of 0 for pointer argument to fix the sparse error. Reviewed-by: Mike Marciniszyn Reviewed-by: Mitko Haralanov Reviewed-by: Dennis Dalessandro Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/sdm

[PATCH v2 08/22] staging/rdma/hfi1: close shared context security hole

From: Jareer Abdel-Qader Driver does not verify userid for shared context assignments, allowing malicious user access. Reviewed by: Mike Marciniszyn Signed-off-by: Jareer H Abdel-Qader Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/file_ops.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH v2 05/22] staging/rdma/hfi1: Remove QSFP_ENABLED from HFI capability mask

From: Easwar Hariharan The QSFP interface code has been running without issues and the flag is never set to off. This patch removes the QSFP_ENABLED bit from HFI1_CAP. Reviewed-by: Mike Marciniszyn Signed-off-by: Easwar Hariharan Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/chip.c

[PATCH v2 03/22] staging/rdma/hfi1: Extend the offline timeout

From: Dean Luick The latest version of the 8051 firmware will wait longer when bringing the link down. Extend the driver's timeout to go with that. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/chip.c | 2 +- 1 file changed,

[PATCH v2 02/22] staging/rdma/hfi1: Fix code to reset ASIC CSRs on FLR

From: Easwar Hariharan The ASIC registers were not reset on FLR, and the code to protect the ASIC block against multiple initializations by peer HFIs did not extend to multiple ASICs in a system. This patch addresses this gap. Reviewed-by: Dean Luick Signed-off-by: Easwar Hariharan Signed-off-

[PATCH v2 01/22] staging/rdma/hfi1: Fix regression in send performance

From: Mike Marciniszyn This additional call is a regression from qib. For small messages the progress routine always builds one and clears out the ahg state when the queue has gone to empty which is the predominant case for small messages. Inline the routine to mitigate the call and move the ro

[PATCH v2 00/22] staging/rdma/hfi1: Fix bugs and performance issues

From: Ira Weiny The following are fixes to the hfi1 driver for stability, security, and performance. Changes from v1: Reviewed each patch for new features. Found 2 which fixed congestion notification in some corner cases but they could be considered additional features,

[PATCH 10/10] staging: comedi: adl_pci9118: tidy up pci9118_ai_setup_dma()

For aesthetics, init the dmalen[01] local variables when they are declared. Use a local variable, 'scan_bytes', for the (devpriv->ai_n_realscanlen << 1) calculation. For aesthetics and clarification, use comedi_bytes_per_sample() instead of the '<< 1' shift to calculate the value. The local varia

[PATCH 08/10] staging: comedi: adl_pci9118: rename move_block_from_dma()

Rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH 07/10] staging: comedi: adl_pci9118: rename valid_samples_in_act_dma_buf()

Rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/driver

[PATCH 09/10] staging: comedi: adl_pci9118: rename interrupt_*() functions

For aesthetics, rename these functions so it they namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH 06/10] staging: comedi: adl_pci9118: rename interrupt_pci9118_ai_mode4_switch()

For aesthetics, remove "interrupt_" from this functions name to shorten it a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/sta

[PATCH 01/10] staging: comedi: adl_pci9118: TRIG_INT is not vaild for scan_begin_src

The (*do_cmdtest) in this driver validated the scan_begin_src as being TRIG_FOLLOW | TRIG_TIMER | TRIG_EXT. The TRIG_INT source is not valid. Remove the Step 2 mutual compatibility check that makes sure that TRIG_INT is only used for the start_src or the scan_begin_src. Signed-off-by: H Hartley S

[PATCH 04/10] staging: comedi: adl_pci9118: remove unused defines

These defines are not used in the driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/c

[PATCH 05/10] staging: comedi: adl_pci9118: remove PCI9118_CHANLEN

This define is only used to initialize the analog input sudevice 'len_chanlist'. Remove the define and just open code the value. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 7 +-- 1 file changed, 1 insertion(+),

[PATCH 02/10] staging: comedi: adl_pci9118: remove unnecessary check in check_channel_list()

Step 3 of the AI (*do_cmdtest) validates that the cmd->chanlist_len is >= 1. If it's not the (*do_cmdtest) fails and check_channel_list() is never called. This This function is also called by the AI (*do_cmd) and the comedi core ensures that the async command has a valid chanlist. Remove the unnece

[PATCH 03/10] staging: comedi: adl_pci9118: tidy up check_channel_list()

Rename this function to give it namespace associated with the driver. Currently this function is called by both the AI (*do_cmdtest) and the (*do_cmd) functions. It really only needs to be called by the (*do_cmdtest) to validate that the chanlist meets the requirements of the hardware. It's only c

[PATCH 00/10] staging: comedi: adl_pci9118: tidy up ai command support

Clean up the analog input async command support code and the interrupt handler. H Hartley Sweeten (10): staging: comedi: adl_pci9118: TRIG_INT is not vaild for scan_begin_src staging: comedi: adl_pci9118: remove unnecessary check in check_channel_list() staging: comedi: adl_pci9118: tidy up

[PATCH 12/16] staging: rtl8192e: Add _rtl92e_fw_prepare

Add function to request and prepare firmware image. Signed-off-by: Mateusz Kulikowski --- .../staging/rtl8192e/rtl8192e/r8192E_firmware.c| 71 -- 1 file changed, 39 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers

[PATCH 13/16] staging: rtl8192e: Swap firmware endian in _rtl92e_fw_prepare()

Remove endian swap from _rtl92e_fw_download_code(), this way it can be replaced with _rtl92e_send_cmd_pkt(). Signed-off-by: Mateusz Kulikowski --- .../staging/rtl8192e/rtl8192e/r8192E_firmware.c| 25 -- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drive

[PATCH 08/16] staging: rtl8192e: Add rt_fw_blob

rt_fw_blob contains single firmware blob and its size. Update firmware loading code accordingly. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 19 +-- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.h | 12 2 files chan

[PATCH 09/16] staging: rtl8192e: Rename rt_firmware::firmware_status to status

Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 14 +++--- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.h | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff -

[PATCH 15/16] staging: rtl8192e: fw: Use netdev_dbg instead of RT_TRACE

Drop legacy logging system. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_f

[PATCH 14/16] staging: rtl8192e: Remove _rtl92e_fw_download_code()

Reuse rtl92e_send_cmd_pkt() instead. Signed-off-by: Mateusz Kulikowski --- .../staging/rtl8192e/rtl8192e/r8192E_firmware.c| 56 ++ 1 file changed, 3 insertions(+), 53 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl819

[PATCH 10/16] staging: rtl8192e: init_fw: Drop unneded check

rst_opt is always equal to OPT_SYSTEM_RESET in this scope. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl81

[PATCH 07/16] staging: rtl8192e: cmd_pkt: Handle INIT packets

Add support for DESC_PACKET_TYPE_INIT to rtl92e_send_cmd_pkt(). With this generalization, _rtl92e_fw_download_code() may be removed after slight modification. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 32 +-- 1 file changed, 24

[PATCH 16/16] staging: rtl8192e: _rtl92e_fw_boot_cpu: Remove unneeded goto

Drop ugly label as no resource cleanup is needed. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/r

[PATCH 11/16] staging: rtl8192e: Add _rtl92e_wait_for_fw()

Add function waiting for firmware load/boot; Remove _rtl92e_is_fw_ready() that is obsolete (can be replaced with _rtl92e_wait_for_fw(). Signed-off-by: Mateusz Kulikowski --- .../staging/rtl8192e/rtl8192e/r8192E_firmware.c| 73 ++ 1 file changed, 18 insertions(+), 55 dele

[PATCH 06/16] staging: rtl8192e: Use macro to represent fragmentation threshold

Add CMDPACKET_FRAG_SIZE macro and use it as fragmentation threshold in send_cmd_pkt functions. This makes rt_firmware::cmdpacket_frag_thresold and rtl92e_init_fw_param() obsolete. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 8 ++-- drivers/st

[PATCH 01/16] staging: rtl8192e: rtl_dm: Use proper packet type

rtl92e_send_cmd_packet sends only NORMAL packets, passing invalid type (even it it's ignored) is confusing. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_d

[PATCH 02/16] staging: rtl8192e: cmdpkt: Use packettype properly

rtl92e_send_cmd_pkt used hardcoded NORMAL packet type. As it may be used to send other packet types as well - use provided packet type instead of defaults. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH 04/16] staging: rtl8192e: cmdpkt: Reorder arguments

Use send_cmd_pkt(dev, type, data , size) order to avoid confusion Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c| 2 +- 3 files changed, 3

[PATCH 03/16] staging: rtl8192e: cmdpkt: Simplify argument names

Rename: codevirtualaddress -> data buffer_len -> len packettype -> type Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 17 - drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 3 +-- 2 files changed, 9 insertions(+), 11 deletions(-) d

[PATCH 05/16] staging: rtl8192e: cmdpkt: Pass data as const void*

Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 3 ++- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/

[PATCH 00/16] staging: rtl8192e: Cleanup firmware loading code

This series cleans up a bit firmware loading code. I had it stashed for some time, but finally was able to repackage patches to a "reviewable" format. It generates one new LONG_LINE warning, but breaking it would make code less readable (and it's just 1 character). Series was target tested and

[PATCH 2/2] staging: octeon: Remove explicit NULL comparison

Remove the explicit NULL comparison and rewrite in a compact form. Signed-off-by: Muhammad Falak R Wani --- drivers/staging/octeon/ethernet-tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c index

[PATCH 1/2] staging: octeon: Remove explicit NULL comparison

Remove the explicit NULL comparison and rewrite in a compact form. Signed-off-by: Muhammad Falak R Wani --- drivers/staging/octeon/ethernet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index fbbe866..

Re: [PATCH 00/23] Update driver to 0.9-294

On Mon, Oct 19, 2015 at 06:16:55PM +, Weiny, Ira wrote: > > > > On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > The following series has bug fixes and updates to the staging hfi1 driver. > > > > Why are you adding new functionality to th

RE: [PATCH 00/23] Update driver to 0.9-294

> > On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The following series has bug fixes and updates to the staging hfi1 driver. > > Why are you adding new functionality to this driver before it is moved out of > drivers/staging/ ? I _REALLY_ don't

[PATCH] staging: dgnc: Remove explicit NULL comparison

Rewrite explicit NULL comparison in its simpler form. @NULL_REPLACE@ expression e; @@ -e == NULL + !e Signed-off-by: Muhammad Falak R Wani --- drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/

[PATCH v2 3/3] staging: rtl8712: spaces preferred around operands

Clean up all instances of checkpatch.pl checks: CHECK: spaces preferred around that '+' (and other operands) Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8712/ieee80211.c | 21 ++--- drivers/staging/rtl8712/mlme_linux.c | 2 +- drivers/staging/rtl8712/os_intfs.

[PATCH v2 2/3] staging: rtl8712: braces should be used on all arms

Fix all instances of the following checkpatch.pl check: CHECK: braces {} should be used on all arms of this statement Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8712/hal_init.c| 11 +++--- drivers/staging/rtl8712/ieee80211.c | 15 +--- drivers/staging/rtl

[PATCH v2 1/3] staging: rtl8712: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8712/os_intfs.c| 4 +- drivers/staging/rtl8712/rtl8712_cmd.c | 9 +- drivers/staging/rtl8712/rtl8712_efuse.c | 56 - drivers/staging/rt

[PATCH v2 0/3] staging: code cleanup

Hi, I initially submitted a patch to remove all the explicit boolean comparisons in rtl8712. These code changes included two instances where braces needed to be added to clean the output of checkpatch.pl on this patch. Mike Rapaport correctly pointed out those changes had to go in a separate patc

[PATCH] staging: ion: Remove explicit NULL comparison

Rewrite explicit NULL comparison in its simpler form. @NULL_REPLACE@ expression e; @@ -e == NULL + !e Signed-off-by: Muhammad Falak R Wani --- drivers/staging/android/ion/ion_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_heap.c b/dr

Re: [PATCH 39/45] staging: comedi: cb_pcidas: split ai code out of interrupt handler

On Mon, Oct 19, 2015 at 04:34:01PM +, Hartley Sweeten wrote: > On Friday, October 16, 2015 11:21 PM, Greg KH wrote: > > On Tue, Oct 13, 2015 at 05:48:03PM -0700, H Hartley Sweeten wrote: > >> Clarify the interrupt handler by splitting the analog input handling > >> into a new function. > >> >

Re: [PATCH 15/23] staging/rdma/hfi1: Implement Expected Receive TID caching

On Mon, Oct 19, 2015 at 12:43:39PM -0400, ira.we...@intel.com wrote: > From: Mitko Haralanov > > Expected receives work by user-space libraries (PSM) calling into the driver > with information about the user's receive buffer and have the driver DMA-map > that buffer and program the HFI to receive

Re: [PATCH 00/23] Update driver to 0.9-294

On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote: > From: Ira Weiny > > The following series has bug fixes and updates to the staging hfi1 driver. Why are you adding new functionality to this driver before it is moved out of drivers/staging/ ? I _REALLY_ don't like to see tha

[PATCH 16/23] staging/rdma/hfi1: Allow tuning of SDMA interrupt rate

From: Mitko Haralanov The SDMA engines were configured to generate progrss interrupts every time they processed N/2 descriptors (where N is the size of the descriptor queue). This interval was too infrequent, leading to degraded performance. This commit adds a module parameter, which allows for

[PATCH 04/23] staging/rdma/hfi1: Implement time-out for send context halt recovery

From: Vennila Megavannan This patch increases the timout for packet egress to 500 us and timer resets to zero if the packet occupancy changes. Also we bounce the link on time out. Reviewed-by: Dean Luick Signed-off-by: Vennila Megavannan Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1

[PATCH 4/7] staging: comedi: cb_pcidas: remove superfluous comment

The ao (*cancel) function does not need commented. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/com

[PATCH 23/23] staging/rdma/hfi1: Update driver version string to 0.9-294

From: Jubin John Signed-off-by: Jubin John Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rdma/hfi1/common.h b/drivers/staging/rdma/hfi1/common.h index 7809093eb55e..5dd92720faae 100644 --- a/

[PATCH 1/7] staging: comedi: cb_pcidas: split ai code out of interrupt handler

Clarify the interrupt handler by splitting the analog input handling into a new function. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas.c | 80 ++ 1 file changed, 47 insertions(+), 33 del

[PATCH 22/23] staging/rdma/hfi1: add additional rc traces

From: Mike Marciniszyn Add additional rc traces to aid in debugging rc retry logic. Reviewed-by: Dennis Dalessandro Signed-off-by: Mike Marciniszyn Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/rc.c| 4 drivers/staging/rdma/hfi1/trace.c | 4 ++-- drivers/staging/rdma/hfi1

[PATCH 11/23] staging/rdma/hfi1: Reset firmware instead of reloading Sbus

From: Caz Yokoyama Reset firmware instead of reloading Sbus firmware if it's already done for this ASIC. To work around thermal polling problem in firmware, don't reload Sbus firmware, instead, reset the firmware on the initialization of the second HFI. Reviewed-by: Easwar Hariharan Reviewed-b

[PATCH 6/7] staging: comedi: cb_pcidas: fix cb_pcidas_ao_nofifo_insn_write()

The comedi core expects (*insn_write) functions to write insn->n data values to the hardware. Fix this function to work like the core expects. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas.c | 11 +++ 1 file

[PATCH 3/7] staging: comedi: cb_pcidas: absorb cal_enable_bits()

This inline function just returns the bits needd to enable a calibration source. For aethetics, absorb it into the callers. Sorten the variable name in the private data used to hold the current calibration source. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman -

[PATCH 7/7] staging: comedi: cb_pcidas: update MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something more useful than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 19/23] staging/rdma/hfi: modify workqueue for parallelism

From: Mike Marciniszyn The workqueue is currently single threaded per port which for a small number of SDMA engines is ok. For hfi1, the there are up to 16 SDMA engines that can be fed descriptors in parallel. This patch: - Converts to use alloc_workqueue - Changes the workqueue limit from 1 to

[PATCH 5/7] staging: comedi: cb_pcidas: fix cb_pcidas_ao_fifo_insn_write()

The comedi core expects (*insn_write) functions to write insn->n data values to the hardware. Fix this function to work like the core expects. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas.c | 11 +++ 1 file

[PATCH 10/23] staging/rdma/hfi1: close shared context security hole

From: Jareer Abdel-Qader Driver does not verify userid for shared context assignments, allowing malicious user access. Reviewed by: Mike Marciniszyn Signed-off-by: Jareer H Abdel-Qader Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/file_ops.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 2/7] staging: comedi: cb_pcidas: consolidate interrupt clear code

The analog output and analog input interrupts are currently cleared as they are handled. Refactor the code to gather all the bits needed to clear the interrupts and do it once at the end of the interrupt handler. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --

[PATCH 15/23] staging/rdma/hfi1: Implement Expected Receive TID caching

From: Mitko Haralanov Expected receives work by user-space libraries (PSM) calling into the driver with information about the user's receive buffer and have the driver DMA-map that buffer and program the HFI to receive data directly into it. This is an expensive operation as it requires the driv

[PATCH 09/23] staging/rdma/hfi1: Fix sparse error in sdma.h file

From: Niranjana Vishwanathapura Use NULL instead of 0 for pointer argument to fix the sparse error. Reviewed-by: Mike Marciniszyn Reviewed-by: Mitko Haralanov Reviewed-by: Dennis Dalessandro Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/sdm

[PATCH 21/23] staging/rdma/hfi1: Add unit # to verbs txreq cache name

From: Jubin John The name used to create the verbs txreq cache was not qualified with the unit number. This causes a panic when destroying the cache on a dual HFI systems. Create a unique name with the unit number with this patch Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John Signed-o

[PATCH 08/23] staging/rdma/hfi1: Method to toggle "fast ECN" detection

From: Vennila Megavannan Add a module paramter to toggle prescan/Fast ECN Detection. In addition change the PRESCAN_RXQ Kconfig default to "yes". Reviewed-by: Arthur Kepner Reviewed-by: Mike Marciniszyn Signed-off-by: Vennila Megavannan Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/K

[PATCH 07/23] staging/rdma/hfi1: optionally prescan rx queue for {B, F}ECNs - UC, RC

From: Arthur Kepner (This patch adds RC, and UC processing based on commit 48c479f.) To more rapidly respond to Explicit Congestion Notifications, prescan the receive queue, and process FECNs, and BECNs first. When a UC, or RC packet containing a FECN, or BECN is found, immediately react to the

[PATCH 13/23] staging/rdma/hfi1: Fix port bounce issues with 0.22 DC firmware

From: Easwar Hariharan The DC firmware overwrites the enable_lane_tx register and does not update it on a host request to go to Poll. This causes an infinite loop through the LNI state machine if a link width downgrade occurs. This patch re-sets the enable_lane_tx register to all 4 lanes. Review

[PATCH 14/23] staging/rdma/hfi1: Prevent silent data corruption with user SDMA

From: Mitko Haralanov User SDMA keeps track of progress into the submitted IO vectors by tracking an offset into the vectors when packets are submitted. This offset is updated after a successful submission of a txreq to the SDMA engine. The same offset was used when determining whether an IO vec

[PATCH 20/23] staging/rdma/hfi1: Load SBus firmware once per ASIC

From: Easwar Hariharan Using fw_sbus_load to control SBus firmware load doesn't scale across multiple HFI1 cards in a single system. This patch ensures that the SBus firmware is loaded once per ASIC. Reviewed-by: Dean Luick Reviewed-by: Dennis Dalessandro Signed-off-by: Easwar Hariharan Signe

[PATCH 18/23] staging/rdma/hfi1: Thread the receive interrupt.

From: Dean Luick When under heavy load, the receive interrupt handler can run too long with IRQs disabled. Add a mixed-mode threading scheme. Initially process packets in the handler for quick responses (latency). If there are too many packets to process move to a thread to continue (bandwidth

  1   2   >