[PATCH] IB/ipath: use TASK_COMM_LEN in ipath_portdata

2015-10-08 Thread Geliang Tang
Use comm[TASK_COMM_LEN] instead of comm[16]. Add linux/sched.h header in ipath_kernel.h, and remove linux/sched.h header from ipath_*.c which have included ipath_kernel.h. Signed-off-by: Geliang Tang --- drivers/staging/rdma/ipath/ipath_driver.c | 1 - drivers/staging/rdma/ipath/ipath_intr.

[PATCH] IB/hfi1: use TASK_COMM_LEN in hfi1_ctxtdata

2015-10-08 Thread Geliang Tang
Use comm[TASK_COMM_LEN] instead of comm[16]. Signed-off-by: Geliang Tang --- drivers/staging/rdma/hfi1/hfi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rdma/hfi1/hfi.h b/drivers/staging/rdma/hfi1/hfi.h index 8ca171b..a35213e 100644 --- a/drivers/staging/r

Re: [PATCH] staging: comedi: 8255_pci: prefer using the BIT macro

2015-10-08 Thread Ian Abbott
On 08/10/15 21:05, H Hartley Sweeten wrote: As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/8255_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH v2 00/14] staging: comedi: dt3000: cleanup driver

2015-10-08 Thread Ian Abbott
On 08/10/15 18:48, H Hartley Sweeten wrote: This series fixes all the checkpatch.pl issues and cleans up the driver a bit. There are still some issues with this driver but I have not been able to locate a datasheet... :-( v2: fix patch 9 as pointed out by Ian Abbott The comedi_alloc_subdev

Re: [PATCH v2 0/3] staging: comedi: ii_pci20kc: cleanup driver

2015-10-08 Thread Ian Abbott
On 08/10/15 18:30, H Hartley Sweeten wrote: Fix a minor checkpatch.pl issue and cleanup this driver a bit. v2: as Ian abbott pointed out, it appears that the analog output data always needs munging to 2's complement. Fix patch 2 and merge with patch 3. H Hartley Sweeten (3): stagin

Re: [PATCH 1/3] staging: sm750fb: merge calcPLL and getPllValue into getChipClock

2015-10-08 Thread Mike Rapoport
On Thu, Oct 08, 2015 at 12:58:04PM +0530, Sudip Mukherjee wrote: > On Tue, Oct 06, 2015 at 09:42:15AM +0100, Mike Rapoport wrote: > > The getChipClock function is used only to get MXCLK frequency, which > > makes most of getPllValue function unused and thus. The detection of > > MXCLK frequency may

Re: [PATCH 0/3] staging: sm750fb: remove sii164 DVI controller support

2015-10-08 Thread Mike Rapoport
Hi Sudip, On Thu, Oct 08, 2015 at 11:46:28AM +0530, Sudip Mukherjee wrote: > On Tue, Oct 06, 2015 at 04:49:13PM +0100, Mike Rapoport wrote: > > Currently the sii164 DVI controller support is unused anywhere in the rest > > of > > the driver, and, anyway it does not belong to framebuffer device dr

[PATCH] staging: comedi: 8255_pci: prefer using the BIT macro

2015-10-08 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/8255_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/driv

[PATCH] Staging: vt6655: Renamed uRATE to rate

2015-10-08 Thread paulmcquad
From: Paul McQuade Renamed uRATE to rate to avoid camelcase Signed-off-by: Paul McQuade --- drivers/staging/vt6655/rf.c | 12 ++-- drivers/staging/vt6655/rf.h | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/

Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-08 Thread Greg KH
On Thu, Oct 08, 2015 at 09:29:35PM +0300, Stanislav Kholmanskikh wrote: > Hi! > > I noticed that drivers/staging/wilc1000/Kconfic defines: > > config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY > bool "Dynamically allocate memory in real time" > ---help--- > This choice support

staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-08 Thread Stanislav Kholmanskikh
Hi! I noticed that drivers/staging/wilc1000/Kconfic defines: config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY bool "Dynamically allocate memory in real time" ---help--- This choice supports dynamic allocation of the memory for the receive buffer. The driver will all

[PATCH 2/2] staging: wilc1000: linux_wlan_spi: include header

2015-10-08 Thread Stanislav Kholmanskikh
A check using 'sparse' shows warnings in linux_wlan_spi.c: drivers/staging/wilc1000/linux_wlan_spi.c:43:19: warning: symbol 'wilc_spi_dev' was not declared. Should it be static? drivers/staging/wilc1000/linux_wlan_spi.c:71:19: warning: symbol 'wilc_bus' was not declared. Should it be static? dri

[PATCH 1/2] staging: wilc1000: linux_wlan_spi: correct types

2015-10-08 Thread Stanislav Kholmanskikh
linux_spi_write(), linux_spi_read(), linux_spi_write_read(): nwi->io_func.u.spi.spi_tx = linux_spi_write; nwi->io_func.u.spi.spi_rx = linux_spi_read; nwi->io_func.u.spi.spi_trx = linux_spi_write_read; are expected to accept arguments of 'u8 *', u32 types: struct { int (*s

[PATCH v2 14/14] staging: comedi: dt3000: update the MODULE_DESCRIPTION

2015-10-08 Thread H Hartley Sweeten
Change the MODULE_DESCRIPTION to something more ueeful than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stag

[PATCH v2 12/14] staging: comedi: dt3000: tidy up memory subdevice init

2015-10-08 Thread H Hartley Sweeten
Remove the unnecessary 'len_chanlist' initialization. This member is only used by subdevices that support async commands. For aesthetics, reorder the initialization a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 5 ++

[PATCH v2 13/14] staging: comedi: dt3000: remove #if 0'ed out code

2015-10-08 Thread H Hartley Sweeten
Replace the disabled code in dt3k_dio_config() with a comment in case it's actually needed. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/stag

[PATCH v2 11/14] staging: comedi: dt3000: tidy up digital i/o subdevice init

2015-10-08 Thread H Hartley Sweeten
Remove the unnecessary 'len_chanlist' initialization. This member is only used by subdevices that support async commands. For aesthetics, reorder the initialization a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 7 ++

[PATCH v2 10/14] staging: comedi: dt3000: rename dt3k_ai_insn()

2015-10-08 Thread H Hartley Sweeten
For aesthetics, rename this subdevice (*insn_read) function to follow the normal naming in comedi drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff -

[PATCH v2 08/14] staging: comedi: dt3000: refactor 'adbits' boardinfo

2015-10-08 Thread H Hartley Sweeten
All the board supported by this driver have analog inputs. The input resolution is either 12-bit or 16-bit. Replace the 'adbits' member of the boardinfo with a bit-field flag 'ai_is_16bits' and just set if for the 16-bit boards. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Har

[PATCH v2 09/14] staging: comedi: dt3000: the dt3002 board does not have analog outputs

2015-10-08 Thread H Hartley Sweeten
According to the boardinfo, the dt3002 board does not have analog outputs. The rest of the board have two 12-bit analog output channels. Replace the 'dachan' and 'dabits' members of the boardinfo with a bit- field flag 'has_ao'. Use the new member to conditionally initialize the analog output subd

[PATCH v2 07/14] staging: comedi: dt3000: remove proc subdevice

2015-10-08 Thread H Hartley Sweeten
This subdevice is not allocated or defined in the driver. Remove the disabled subdevice initialization. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/co

[PATCH v2 05/14] staging: comedi: dt3000: rename the interrupt flag defines

2015-10-08 Thread H Hartley Sweeten
For aesthetics, rename these defines so they have association with the register. Move them closer to the register define and use the BIT macro to define them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 24 +++

[PATCH v2 04/14] staging: comedi: dt3000: rename the SUBS_* defines

2015-10-08 Thread H Hartley Sweeten
For aesthetics, rename these defines to avoid any confusion with the similar comedi defines. Move them closer to the register they are associated with. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 31 +++---

[PATCH v2 06/14] staging: comedi: dt3000: tidy up remaining defines

2015-10-08 Thread H Hartley Sweeten
Move the remaining defines and prefix them with 'DPR_' for consistency. Define a macro to set the analog input trigger bits to fix the checkpatch.pl issues about: CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: Prefer using the BIT macro Signed-off-by: H Hartley Sweeten Cc: Ian Abbott

[PATCH v2 03/14] staging: comedi: dt3000: tidy up the command mailbox defines

2015-10-08 Thread H Hartley Sweeten
For aesthetics, rename these defines so they are associated with the register. Move the defines closer to the register define. Define some macros for the "completion" and "cmd" bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt30

[PATCH v2 00/14] staging: comedi: dt3000: cleanup driver

2015-10-08 Thread H Hartley Sweeten
This series fixes all the checkpatch.pl issues and cleans up the driver a bit. There are still some issues with this driver but I have not been able to locate a datasheet... :-( v2: fix patch 9 as pointed out by Ian Abbott The comedi_alloc_subdev_readback() also needs to be moved into the

[PATCH v2 01/14] staging: comedi: dt3000: tidy up multi-line comments

2015-10-08 Thread H Hartley Sweeten
Reformat the multi-line comments in the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 91 + 1 file changed, 46 insertions(+), 45 deletions(-) diff --git a/drivers/staging

[PATCH v2 02/14] staging: comedi: dt3000: rename dual-ported RAM location defines

2015-10-08 Thread H Hartley Sweeten
Rename these CamelCase defines and fix the checkpatch.pl issues: CHECK: Avoid CamelCase: CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) For aesthetics, move the defines to after the includes. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott

RE: [PATCH 09/14] staging: comedi: dt3000: the dt3002 board does not have analog outputs

2015-10-08 Thread Hartley Sweeten
On Thursday, October 08, 2015 3:38 AM, Ian Abbott wrote: > On 08/10/15 02:26, H Hartley Sweeten wrote: >> According to the boardinfo, the dt3002 board does not have analog outputs. >> The rest of the board have two 12-bit analog output channels. >> >> Replace the 'dachan' and 'dabits' members of th

[PATCH v2 3/3] staging: rtl8188eu: spaces preferred around that + inserted

2015-10-08 Thread Ivan Safonov
This patch inserts spaces preferred around that '+' found by checkpatch. --- Changes in v2: - inserted description to this patch, - added Signed-off record. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) d

[PATCH v2 3/3] staging: comedi: ii_pci20kc: update the MODULE_DESCRIPTION

2015-10-08 Thread H Hartley Sweeten
Change the MODULE_DESCRIPTION to something more useful than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ii_pci20kc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH v2 2/3] staging: comedi: ii_pci20kc: use comedi_offset_munge()

2015-10-08 Thread H Hartley Sweeten
For aesthetics, use the helper function to handle the munging of the analog output data from offset binary to 2's complement and the analog input data from 2's complement to offset binary. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- v2: as Ian abbott pointed out,

[PATCH v2 0/3] staging: comedi: ii_pci20kc: cleanup driver

2015-10-08 Thread H Hartley Sweeten
Fix a minor checkpatch.pl issue and cleanup this driver a bit. v2: as Ian abbott pointed out, it appears that the analog output data always needs munging to 2's complement. Fix patch 2 and merge with patch 3. H Hartley Sweeten (3): staging: comedi: ii_pci20kc: prefer using the BIT macro

[PATCH v2 1/3] staging: comedi: ii_pci20kc: prefer using the BIT macro

2015-10-08 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ii_pci20kc.c | 70 ++--- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git

Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed

2015-10-08 Thread Denis V. Lunev
On 10/08/2015 08:28 PM, KY Srinivasan wrote: -Original Message- From: Denis V. Lunev [mailto:d...@openvz.org] Sent: Thursday, October 8, 2015 10:20 AM To: KY Srinivasan ; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canoni

RE: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed

2015-10-08 Thread KY Srinivasan
> -Original Message- > From: Denis V. Lunev [mailto:d...@openvz.org] > Sent: Thursday, October 8, 2015 10:20 AM > To: KY Srinivasan ; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; vkuzn...@redhat.com; jasow

Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed

2015-10-08 Thread Denis V. Lunev
On 10/08/2015 05:01 AM, K. Y. Srinivasan wrote: From: Denis V. Lunev K.Y., there is one subtle thing in this submission. You have changed "From:" field in comparison with the original letter. I have submitted the patch with "From: Andrey Smetanin " In this case Author: in the resulted git mai

RE: [PATCH 2/4] staging: comedi: ii_pci20kc: only bipolar ao ranges are 2's complement

2015-10-08 Thread Hartley Sweeten
On Thursday, October 08, 2015 3:03 AM, Ian Abbott wrote: > On 07/10/15 19:09, H Hartley Sweeten wrote: >> According the the PCI-2006M user's manual, bipolar ranges use 2's >> complement coding and unipolar ranges are straight binary. Fix >> ii20k_ao_insn_write() to use the correct coding based on t

[PATCH v2 3/3] staging: rtl8188eu: spaces preferred around that + inserted

2015-10-08 Thread Ivan Safonov
This patch inserts spaces preferred around that '+' found by checkpatch. --- Changes in v2: - inserted description to this patch. --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/driv

[PATCH v2 2/3] staging: rtl8188eu: ARRAY_SIZE instead of sizeof/sizeof used

2015-10-08 Thread Ivan Safonov
This patch inserts ARRAY_SIZE instead of sizeof(type array[])/sizeof(type). --- Changes in v2: - inserted description to this patch Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH v2 1/3] staging: rtl8188eu: unused macro read_nexp_pair removed

2015-10-08 Thread Ivan Safonov
This patch removes unused macro read_nexp_pair. --- Changes in v2: - added description to this patch. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8

[PATCH v2 0/3] staging: rtl8188eu: ARRAY_SIZE instead of sizeof/sizeof and some code cleanups

2015-10-08 Thread Ivan Safonov
This patchset: - removes unused macro read_nexp_pair, - inserts ARRAY_SIZE instead of sizeof(type array[])/sizeof(type), - inserts spaces preferred around that '+' found by checkpatch. --- Changes in v2: - some patches aggregated into this patchset - added description to all patches Ivan

RE: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Thursday, October 8, 2015 6:53 AM > To: Olaf Hering > Cc: KY Srinivasan ; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; a...@canonical.com; > jasow...@redhat.co

RE: [PATCH 01/10] Drivers: hv: util: Increase the timeout for util services

2015-10-08 Thread KY Srinivasan
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Thursday, October 8, 2015 6:24 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com >

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread Vitaly Kuznetsov
Olaf Hering writes: > On Thu, Oct 08, Vitaly Kuznetsov wrote: > >> > @@ -295,9 +288,6 @@ static int fcopy_on_msg(void *msg, int len) >> >if (fcopy_transaction.state == HVUTIL_DEVICE_INIT) >> >return fcopy_handle_handshake(*val); >> > >> > - if (fcopy_transaction.state != HVUTIL_U

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread Olaf Hering
On Thu, Oct 08, Vitaly Kuznetsov wrote: > > @@ -295,9 +288,6 @@ static int fcopy_on_msg(void *msg, int len) > > if (fcopy_transaction.state == HVUTIL_DEVICE_INIT) > > return fcopy_handle_handshake(*val); > > > > - if (fcopy_transaction.state != HVUTIL_USERSPACE_REQ) > > -

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-08 Thread Vitaly Kuznetsov
"K. Y. Srinivasan" writes: > From: Olaf Hering > > All channel interrupts are bound to specific VCPUs in the guest > at the point channel is created. While currently, we invoke the > polling function on the correct CPU (the CPU to which the channel > is bound to) in some cases we may run the pol

Re: [PATCH 01/10] Drivers: hv: util: Increase the timeout for util services

2015-10-08 Thread Olaf Hering
On Wed, Oct 07, K. Y. Srinivasan wrote: > Util services such as KVP and FCOPY need assistance from daemon's running > in user space. Increase the timeout so we don't prematurely terminate > the transaction in the kernel. Is this an arbitrary number, or does the host allow such a large delay for t

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-08 Thread kbuild test robot
Hi Chen, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] config: arm-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/mak

Re: [PATCH 00/17] staging: comedi: icp_multi: cleanup driver

2015-10-08 Thread Ian Abbott
On 07/10/15 22:52, H Hartley Sweeten wrote: Fix the checkpatch.pl issues and tidy up this driver a bit. H Hartley Sweeten (17): staging: comedi: icp_multi: tidy up multi-line comments staging: comedi: icp_multi: tidy up the ADC command/status register bits staging: comedi: icp_multi: ti

Re: [PATCH 09/14] staging: comedi: dt3000: the dt3002 board does not have analog outputs

2015-10-08 Thread Ian Abbott
On 08/10/15 02:26, H Hartley Sweeten wrote: According to the boardinfo, the dt3002 board does not have analog outputs. The rest of the board have two 12-bit analog output channels. Replace the 'dachan' and 'dabits' members of the boardinfo with a bit- field flag 'has_ao'. Use the new member to c

Re: [PATCH 10/10] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

2015-10-08 Thread Vitaly Kuznetsov
"K. Y. Srinivasan" writes: > From: Jake Oshins > > This defines the channel type for PCI front-ends in Hyper-V VMs. > > Signed-off-by: Jake Oshins > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/channel_mgmt.c |3 +++ > include/linux/hyperv.h| 11 +++ > 2 files changed,

Re: [PATCH 0/3] staging: comedi: dt9812: minor cleanup

2015-10-08 Thread Ian Abbott
On 07/10/15 23:58, H Hartley Sweeten wrote: Fix the checkpatch.pl issues in this driver. H Hartley Sweeten (3): staging: comedi: dt9812: tidy up multi-line comment staging: comedi: dt9812: rename F020_MASK_DACxCN_DACxEN staging: comedi: dt9812: reword comments to fix checkpatch.pl issue

Re: [PATCH 01/10] staging: wilc1000: remove typedef from tstrWID

2015-10-08 Thread Greg KH
On Tue, Oct 06, 2015 at 06:42:12PM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes typedef from the struct tstrWID and > rename it to wid. > > Signed-off-by: Leo Kim > Signed-off-by: Tony Cho > --- > drivers/staging/wilc1000/coreconfigurator.c | 2 +- > drivers/staging/wilc1000

Re: [PATCH 01/11] staging: wilc1000: replace drvHandler and hWFIDrv with hif_drv

2015-10-08 Thread Greg KH
On Thu, Oct 08, 2015 at 06:10:46PM +0900, Tony Cho wrote: > This patch replaces the variable names of struct host_if_drv used as the > functions' input parameter, drvHandler and hWFIDrv with hif_drv. In > addition, the local variable declared in many functions, pstrWFIDrv is > removed and hif_drv i

Re: [PATCH 01/14] staging: wilc1000: remove typedef from tstrWILC_UsrScanReq

2015-10-08 Thread Greg KH
On Thu, Oct 08, 2015 at 10:49:08AM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes typedef from the struct tstrWILC_UsrScanReq with > related comments and renames it to user_scan_req. > > Signed-off-by: Leo Kim > Signed-off-by: Tony Cho > --- > drivers/staging/wilc1000/host_inte

Re: [PATCH] staging: comedi: fl512: usleep_range is preferred over udelay

2015-10-08 Thread Ian Abbott
On 07/10/15 23:43, H Hartley Sweeten wrote: Fix checkpatch.pl issue: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt Replace the udelay() with usleep_range() with a reasonable upper limit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Gre

Re: [PATCH] staging: comedi: gsc_hpdi: use preferred kernel types

2015-10-08 Thread Ian Abbott
On 07/10/15 23:31, H Hartley Sweeten wrote: Fix the checkpatch.pl issues about: CHECK: Prefer kernel type 'u32' over 'uint32_t' CHECK: Prefer kernel type 'u8' over 'uint8_t' Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c

Re: [PATCH 1/6] staging: wilc1000: remove typedef from tstrWILC_WFIDrv

2015-10-08 Thread Greg KH
On Mon, Oct 05, 2015 at 07:28:09PM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes typedef from the struct tstrWILC_WFIDrv and > rename it to host_if_drv. > This patch includes the removal of the comment for tstrWILC_WFIDrv as well. > > Signed-off-by: Leo Kim > Signed-off-by: Tony

Re: [PATCH 2/4] staging: comedi: ii_pci20kc: only bipolar ao ranges are 2's complement

2015-10-08 Thread Ian Abbott
On 07/10/15 19:09, H Hartley Sweeten wrote: According the the PCI-2006M user's manual, bipolar ranges use 2's complement coding and unipolar ranges are straight binary. Fix ii20k_ao_insn_write() to use the correct coding based on the range. For aesthetics, use the comedi_offset_munge() helper to

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-08 Thread Greg KH
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote: > Signed-off-by: Chen Feng > Signed-off-by: Yu Dongbin I can't take a patch with no changelog entry at all, sorry. You are going to have to at least explain what this driver is, what it does, and what hardware it supports. thanks, ___

Re: [PATCH] staging: rtl8188eu: ARRAY_SIZE instead of sizeof/sizeof used

2015-10-08 Thread Michał Kępień
> Signed-off-by: Ivan Safonov The commit message cannot be empty. Please include a brief description of what you're doing in the patch. Also, if you're redoing a patch you've already sent before, make sure you mark it as [PATCH v2] and that you include a changelog below the "---" mark so that r

[PATCH 11/11] staging: wilc1000: rename tenuAuth_type of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames tenuAuth_type of struct host_if_wep_attr to auth_type to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 06/11] staging: wilc1000: rename strHostIFpmkidAttr of union host_if_key_attr

2015-10-08 Thread Tony Cho
This patch renames strHostIFpmkidAttr of union host_if_key_attr to pmkid to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/hos

[PATCH 08/11] staging: wilc1000: rename u8WepKeylen of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames u8WepKeylen of struct host_if_wep_attr to key_len to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/hos

[PATCH 10/11] staging: wilc1000: rename u8mode of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames u8mode of struct host_if_wep_attr to mode to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/

[PATCH 09/11] staging: wilc1000: rename u8Wepidx of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames u8Wepidx of struct host_if_wep_attr to index to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/host_int

[PATCH 07/11] staging: wilc1000: rename pu8WepKey of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames pu8WepKey of struct host_if_wep_attr to key in order to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/host

[PATCH 04/11] staging: wilc1000: rename strHostIFwepAttr of union host_if_key_attr

2015-10-08 Thread Tony Cho
This patch renames strHostIFwepAttr of union host_if_key_attr to wep to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 70 ++- 1 file changed, 31 insertions(+), 39 deletions(-) diff --git a/drivers/staging/w

[PATCH 01/11] staging: wilc1000: replace drvHandler and hWFIDrv with hif_drv

2015-10-08 Thread Tony Cho
This patch replaces the variable names of struct host_if_drv used as the functions' input parameter, drvHandler and hWFIDrv with hif_drv. In addition, the local variable declared in many functions, pstrWFIDrv is removed and hif_drv is directly used. A debug message printing pstrWFIDrv is deleted wh

[PATCH 05/11] staging: wilc1000: rename strHostIFwpaAttr of union host_if_key_attr

2015-10-08 Thread Tony Cho
This patch renames strHostIFwpaAttr of union host_if_key_attr to wpa to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 95 ++- 1 file changed, 44 insertions(+), 51 deletions(-) diff --git a/drivers/staging/w

[PATCH 02/11] staging: wilc1000: rename pstrCfgParamVal in struct cfg_param_attr

2015-10-08 Thread Tony Cho
This patch renames a variable of struct cfg_param_val in struct cfg_param_attr, pstrCfgParamVal to cfg_attr_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 144 +++--- 1 file changed, 72 insertions(+), 72

[PATCH 03/11] staging: wilc1000: rename u32SetCfgFlag of struct cfg_param_val

2015-10-08 Thread Tony Cho
This patch renames u32SetCfgFlag of struct cfg_param_val to flag to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 36 +++ drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/w

[PATCH 1/3] docs: dts: Add documentation for hi6220 SoC ION node

2015-10-08 Thread Chen Feng
Documentation for hi6220 SoC ION node Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- .../devicetree/bindings/staging/ion/hi6220-ion.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt diff --

[PATCH 3/3] arm64: dts: Add dts files to enable ION on Hi6220 SoC.

2015-10-08 Thread Chen Feng
Add ION node to enable ION on hi6220 SoC platform Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + arch/arm64/boot/dts/hisilicon/hi6220-ion.dtsi | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 arch

[PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-08 Thread Chen Feng
Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- drivers/staging/android/ion/Kconfig| 7 + drivers/staging/android/ion/Makefile | 1 + drivers/staging/android/ion/hisilicon/Kconfig | 5 + drivers/staging/android/ion/hisilicon/Makefile | 1 + d

Re: [PATCH 1/3] staging: sm750fb: merge calcPLL and getPllValue into getChipClock

2015-10-08 Thread Sudip Mukherjee
On Tue, Oct 06, 2015 at 09:42:15AM +0100, Mike Rapoport wrote: > The getChipClock function is used only to get MXCLK frequency, which > makes most of getPllValue function unused and thus. The detection of > MXCLK frequency may be implemented directly in getChipClock rendering > getPllValue and calc

Re: [PATCH V2] staging: dgnc: Remove dgnc_ports_state_show

2015-10-08 Thread Dan Carpenter
On Thu, Oct 08, 2015 at 07:26:37AM +0100, Salah Triki wrote: > dgnc_ports_state_show is removed, since it exposes ports status which help an > adversary to > plan an attack. No. It doesn't export anything harmful and it only is readable by root. regards, dan carpenter