[PATCH v2] staging: rtl8723au: Fix sparse errors in rtl8723a_cmd.c

From: Jacob Kiefer This patch fixes the following sparse errors: CHECK drivers/staging/rtl8723au/hal/rtl8723a_cmd.c ... drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:118:25: \ warning: incorrect type in assignment (different base types) drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:118:25: \

[PATCH] Staging: fbtft: Use BIT macro

Replace (1 << x) by BIT(x) Signed-off-by: Ronit halder --- drivers/staging/fbtft/fb_ssd1351.c | 4 +-- drivers/staging/fbtft/fbtft.h | 56 +++--- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/s

[PATCH 9/9] staging: comedi: mpc624: change type of private data 'ai_speed'

For aesthetics, change the type of this member to unsigned int. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/mpc624.c b/driv

[PATCH 6/9] staging: comedi: mpc624: rename mpc624_ai_rinsn()

For aesthetics, rename this function to follow the normal convention in comedi drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/stagin

[PATCH 8/9] staging: comedi: mpc624: use tabs for whitespace instead of spaces

For aesthetics, use tabs instead of spaces for the whitespace in the register defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff

[PATCH 4/9] staging: comedi: mpc624: tidy up subdevice init

For aesthetics, add some whitespace to the subdevice init. Remove the unnecessary switch() code used to set the maxdata and range_table. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 25 - 1 file cha

[PATCH 7/9] staging: comedi: mpc624: introduce mpc624_ai_get_sample()

Introduce a helper function to read the analog sample from the serially connected A/D converter and handle the munging of the data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 172 +++- 1 file

[PATCH 5/9] staging: comedi: mpc624: there are only 4 analog inputs

According to the datasheet, this board has 4 differential analog input channels not 8. Fix the subdevice init. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 2/9] staging: comedi: mpc624: tidy up the ai conversion speed code

Rename the CamelCase private data 'ulConvertionRate' and MPC624_SPEED_* defines. Create a macro to set the OSR bits that set the ai conversion speed and use it for the various MPC624_SPEED_* defines. Remove the unnecessary comment describing the speeds, this information is alread in the comedi dri

[PATCH 3/9] staging: comedi: mpc624: update MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something more useful than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stag

[PATCH 1/9] staging: comedi: mpc624: tidy up multi-line comments

Reformat the multi-line comments in the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 101 1 file changed, 51 insertions(+), 50 deletions(-) diff --git a/drivers/staging

[PATCH 0/9] staging: comedi: mpc624: cleanup driver

Fix the checkpatch.pl issues and tidy up this driver a bit. H Hartley Sweeten (9): staging: comedi: mpc624: tidy up multi-line comments staging: comedi: mpc624: tidy up the ai conversion speed code staging: comedi: mpc624: update MODULE_DESCRIPTION staging: comedi: mpc624: tidy up subdevic

RE: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Monday, August 31, 2015 7:02 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; > jbottom...@parallels

[PATCH] staging: comedi: pcl711: prefer using the BIT marco

Fix the checkpatch.pl issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl711.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl711.c b/drivers/staging/c

[PATCH 3/3] staging: comedi: pcl812: rename private data 'IRQbits'

Rename this CamelCase symbol. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 34 - 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl812.c b/dr

[PATCH 2/3] staging: comedi: pcl812: prefer using the BIT macro

Fix the checkpatch.pl issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/come

[PATCH 0/3] staging: comedi: pcl812: fix checkpatch.pl issues

Some minor cleanup to fix the checkpatch.pl issues. H Hartley Sweeten (3): staging: comedi: pcl812: convert hardware type defines into an enum staging: comedi: pcl812: prefer using the BIT macro staging: comedi: pcl812: rename private data 'IRQbits' drivers/staging/comedi/drivers/pcl812.c

[PATCH 1/3] staging: comedi: pcl812: convert hardware type defines into an enum

For aesthetics, convert these defines into an enum and rename the CamelCase. Fix the switch() code to use the enum without warnings. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 135 ++-- 1 file

[PATCH 3/3] staging: comedi: pcl816: remove #if 0'ed out code

Remove the #if 0'ed out code that would initialize an analog output subdevice. The hardware does not normally support an analog output subdevice. Analog outputs are only supported with additional "piggyback" modules. Support for these modules is not included in the driver. Signed-off-by: H Hartle

[PATCH 1/3] staging: comedi: pcl816: tidy up multi-line comments

Reformat the multi-line comments in the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 57 - 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/drivers/staging

[PATCH 2/3] staging: comedi: pcl816: prefer using the BIT macro

Fix the checkpatch.pl issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 38 +++-- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl816.c b/dr

[PATCH 0/3] staging: comedi: pcl816: checkpatch.pl issues

Some minor cleanup to fix the checkpatch.pl issues. H Hartley Sweeten (3): staging: comedi: pcl816: tidy up multi-line comments staging: comedi: pcl816: prefer using the BIT macro staging: comedi: pcl816: remove #if 0'ed out code drivers/staging/comedi/drivers/pcl816.c | 109 ++

[PATCH 2/2] staging: comedi: pcl818: remove unused "boards constants"

These defines are not used. Remove them to get rid of the checkpatch.pl issue about avoiding CamelCase. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging

[PATCH 1/2] staging: comedi: pcl818: prefer using the BIT macro

Fix the checkpatch.pl issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/driv

[PATCH 0/2] staging: comedi: pcl818: fix checkpatch.pl issues

Some minor cleanup to fix the checkpatch.pl issues. H Hartley Sweeten (2): staging: comedi: pcl818: prefer using the BIT macro staging: comedi: pcl818: remove unused "boards constants" drivers/staging/comedi/drivers/pcl818.c | 40 + 1 file changed, 15 insertio

[PATCH v2 14/14] staging: comedi: multiq3: update the MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something more useful than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sta

[PATCH v2 13/14] staging: comedi: multiq3: add 8254 counter/timer subdevice support

The board has an 8254 timer/counter. Add support for this subdevice. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 147 ++- 1 file changed, 146 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 11/14] staging: comedi: multiq3: tidy up multiq3_encoder_insn_read()

Encoders are not a "normal" subdevice in comedi. For aesthetics, tidy up this function and add a couple comments to clarify the function and explain the strange munging of the data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq

[PATCH v2 12/14] staging: comedi: multiq3: remove unnecessary include

This driver does not use interrupts. Remove the include. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/multiq3.c b/drivers/s

[PATCH v2 10/14] staging: comedi: multiq3: remove unnecessary define

This define is not needed. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/multiq3.c b/drivers/staging/comedi/drivers/multiq3.c in

[PATCH v2 09/14] staging: comedi: multiq3: allow user to reset encoder channels

Currently this driver resets all the encoder channels when the driver is first attached. Add a (*insn_config) to the subdevice to allow the use to reset the channels manually. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c |

[PATCH v2 06/14] staging: comedi: multiq3: introduce multiq3_set_ctrl()

According to the programming manual. the 'SH' and 'CLK' bits in the control register need to be kept high at all times. Clarify this by introducing a helper function to set the control register. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/d

[PATCH v2 08/14] staging: comedi: multiq3: document the encoder chip commands

Add some comments to document the commands that are sent to the encoder chips. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/

[PATCH v2 07/14] staging: comedi: multiq3: tidy up control register bit defines

For aesthetics, move these defines closer to the register define and use the BIT macro to define the bits. Add macros to set the bits needed to select the channel for the analog output, analog input, and encoder (counter) subdevices as well as the realtime clock registers. Signed-off-by: H Hartle

[PATCH v2 05/14] staging: comedi: multiq3: tidy up status register bit defines

For aesthetics, move these defines closer to the register define and use the BIT macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --g

[PATCH v2 00/14] staging: comedi: multiq3: cleanup driver

Cleanup this driver a bit and add support for the 8254 counter/timer. v2: Fix patch 11/14, Ian Abbott pointed out that the odd munging of the encoder data does make sense. Add a comment about it. H Hartley Sweeten (14): staging: comedi: multiq3: tidy up multi-line comments staging: comedi

[PATCH v2 04/14] staging: comedi: multiq3: tidy up register map defines

For auesthetics, rename the register map defines. Convert the offset values to hex and add some whitespace. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 70 1 file changed, 35 insertions(+

[PATCH v2 03/14] staging: comedi: multiq3: tidy up subdevice init

For aesthetics, add some whitespace to the subdevice init and rearrange the initialization a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 77 1 file changed, 38 insertions(+), 39 dele

[PATCH v2 01/14] staging: comedi: multiq3: tidy up multi-line comments

Reformat the multi-line comments in the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 54 +++- 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/drivers/staging

[PATCH v2 02/14] staging: comedi: multiq3: tidy up multiq3_ai_insn_read()

For aesthetics, use the proper symbol when reading the A/D data register to get the 16-bit sample data. Use the comedi_offset_munge() to do the 2's complement to offset binary munging of the sample data. Tidy up the function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah

RE: [PATCH 11/14] staging: comedi: multiq3: tidy up multiq3_encoder_insn_read()

On Monday, October 05, 2015 9:12 AM, Ian Abbott wrote: > On 03/10/15 01:30, H Hartley Sweeten wrote: >> Encoders are not a "normal" subdevice in comedi. For aesthetics, tidy >> up this function and add a couple comments to clarify the function. >> >> Remove the strange munging of the data. The enco

[PATCH v3 24/24] staging: comedi: quatech_daqp_cs: avoid calculating pacer divisor multiple times

The pacer will either be used to trigger each conversion or to start each scan. Modify the (*do_cmdtest) so that one one divisor calculation is needed. Save the divisor value in the private data so that the (*do_cmd) does not have to do the calculation again. Signed-off-by: H Hartley Sweeten Cc:

[PATCH v3 22/24] staging: comedi: quatech_daqp_cs: cleanup Step 3 of ai (*do_cmdtest)

Step 3 of the (*do_cmdtest) trivially validates the async command arguments. The validations also modify the arguments if they are invalid so that the user gets valid values if the test fails. Reorder the checks so that if any of the checks fail proper values are used for subsequent checks. Signe

[PATCH v3 21/24] staging: comedi: quatech_daqp_cs: fix daqp_ai_cancel()

Make sure interrupts are disabled and the event flags are cleared when an analog input async command is canceled. Remove the unnecessary calls to stop any running conversions in the (*insn_read) and (*do_cmd) functions. The comedi core will only call these functions if the subdevice is not busy (i

[PATCH v3 20/24] staging: comedi: quatech_daqp_cs: handle shared interrupt

This is a PCMCIA driver and interrupts are always shared. Detect if the hardware did not produce the interrupt and return IRQ_NONE so that other drivers might handle it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c

[PATCH v3 23/24] staging: comedi: quatech_daqp_cs: ai async command requires a pacer

The ai (*do_cmd) assumes that either the convert_src is TRIG_TIMER or the scan_begin_src is TRIG_TIMER and always programs the pacer clock with the appropriate trigger argument. Add a Step 2b check to the (*do_cmdtest) to ensure that at least one of the triggers is TRIG_TIMER. Signed-off-by: H Ha

[PATCH v3 19/24] staging: comedi: quatech_daqp_cs: remove 'interrupt_mode'

The interrupt handler is now only used for the ai async command. Remove the unnecessary 'interrupt_mode' from the private data and tidy up the interrupt handler. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 66 +++

[PATCH v3 17/24] staging: comedi: quatech_daqp_cs: don't use interrupts for ai (*insn_read)

The comedi (*insn_read) functions are supposed to do simple one-shot reading of an analog input channel. Currently this driver enables interrupts and uses wait_for_completion_interruptible() to allow the interrupt routine to let the analog input (*insn_read) know that the end-of-conversion has occu

[PATCH v3 16/24] staging: comedi: quatech_daqp_cs: tidy up aux register bitss

For aesthetics, and use the BIT macro to define the bits and define some macros for the timer mode and d/a update bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 48 1 file changed, 24

[PATCH v3 18/24] staging: comedi: quatech_daqp_cs: only hook up cmd support if we have an IRQ

Interrupts are only needed by this driver to support the analog input async commands. Don't hook up the command support if pcmcia_request_irq() fails instead of completely failing the (*auto_attach). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/com

[PATCH v3 15/24] staging: comedi: quatech_daqp_cs: document the 16-bit registers

All the registers are 8-bit except for the analog output and timer registers. For clarity, add some comments. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH v3 14/24] staging: comedi: quatech_daqp_cs: tidy up command register bits

For aesthetics, move the bit defines for this register and use the BIT macro to define the bits. Define a macro for the scanrate bits and use it to remove the CamelCase. Rename the defines to match the register. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers

[PATCH v3 13/24] staging: comedi: quatech_daqp_cs: tidy up status register bits

For aesthetics, move the bit defines for this register and use the BIT macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 23 +-- 1 file changed, 13 insertions(+), 10 deleti

[PATCH v3 12/24] staging: comedi: quatech_daqp_cs: tidy up control register bits

For aesthetics, move the bit defines for this register and use the BIT macro to define the bits. Rename the defines to match the register. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 39 +++-

[PATCH v3 11/24] staging: comedi: quatech_daqp_cs: tidy up scanlist register bits

For aesthetics, move the bit defines for this register and use the BIT macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) di

[PATCH v3 10/24] staging: comedi: quatech_daqp_cs: rename register offsets

For aesthetics, rename the register map defines and convert the values to hex. Also, move the private data definition and DAQP_FIFO_SIZE define after the register definitions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp

[PATCH v3 09/24] staging: comedi: quatech_daqp_cs: tidy up multi-line comments

Reformat the multi-line comments in the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 84 +++- 1 file changed, 38 insertions(+), 46 deletions(-) diff --git a/drivers/staging

[PATCH v3 07/24] staging: comedi: quatech_daqp_cs: redefine pacer clock options

For aesthetics, define a macro for the pacer clock options and rename the CamelCase. Remove the unnecessary local variables used to set the control register. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 28 ++

[PATCH v3 06/24] staging: comedi: quatech_daqp_cs: spaces preferred around that '<<'

Fix the checkpatch.pl issues about: CHECK: spaces preferred around that '<<' (ctx:VxV) Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/s

[PATCH v3 05/24] staging: comedi: quatech_daqp_cs: use comedi_timeout() in ao (*insn_write)

The data link between the D/A data port and the D/A converter is a serial link. The serial link requires about 8ms to complete a transfer. Use the comedi_timeout() helper to ensure that there is not a previous transfer still happening before trying to write new data to the channel. For aesthetics,

[PATCH v3 08/24] staging: comedi: quatech_daqp_cs: introduce daqp_clear_events()

Introduce a helper function for the common code used to clear any pending interrupts. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 50 1 file changed, 25 insertions(+), 25 deletions(-) di

[PATCH v3 03/24] staging: comedi: quatech_daqp_cs: introduce daqp_ai_get_sample()

Introduce a helper function to get a two's complement sample from the FIFO and munge it to the offset binary format that comedi uses. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 23 --- 1 file

[PATCH v3 04/24] staging: comedi: quatech_daqp_cs: use comedi_offset_munge() in ao (*insn_write)

Use the comedi_offset_munge() helper to do the offset binary to two's complement conversion when writing a new analog output value. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 8 +++- 1 file changed, 3 insert

[PATCH v3 02/24] staging: comedi: quatech_daqp_cs: there are 4 digital inputs

This board has 4 digital inputs not 1. Fix the subdevice init. The digital input lines are shared with other functions. Add a comment about this. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 13 - 1 f

[PATCH v3 01/24] staging: comedi: quatech_daqp_cs: there are 4 digital outputs

This board has 4 digital outputs not 1. Fix the subdevice init. The digital output lines are used for the external channel selection when the expansion mode is enabled. Add a comment about this. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/

[PATCH v3 00/24] staging: comedi: quatech_daqp_cs: cleanup driver

Following is the cleanup series for the comedi quatech_daqp_cs PCMCIA driver. v2: fix patch 08/17 as pointed out by the kbuild test robot daqp_ai_get_sample() should be static v3: drop the patch that changed the ai cmd timing (patch 03/17) rebase the remaining patches and split up the pat

Staging: rtl8188eu: Correct coding style errors

Correct errors reported by checkpatch.pl because space prohibited before ','. Also split one line into two as it was longer than 80 characters Signed-off-by: Iban Rodriguez --- drivers/staging/rtl8188eu/hal/odm.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/driver

Re: [PATCH v2 03/17] staging: comedi: quatech_daqp_cs: fix ai cmd timing

On 05/10/15 17:17, Hartley Sweeten wrote: On Monday, October 05, 2015 8:54 AM, Ian Abbott wrote: On 02/10/15 01:23, H Hartley Sweeten wrote: According to the users manual, the conversion timing (scanrate) is fixed to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan. Curren

RE: [PATCH v2 03/17] staging: comedi: quatech_daqp_cs: fix ai cmd timing

On Monday, October 05, 2015 8:54 AM, Ian Abbott wrote: > On 02/10/15 01:23, H Hartley Sweeten wrote: >> According to the users manual, the conversion timing (scanrate) is fixed >> to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan. >> >> Currently this driver tries to fake oth

Re: [PATCH 11/14] staging: comedi: multiq3: tidy up multiq3_encoder_insn_read()

On 03/10/15 01:30, H Hartley Sweeten wrote: Encoders are not a "normal" subdevice in comedi. For aesthetics, tidy up this function and add a couple comments to clarify the function. Remove the strange munging of the data. The encoder data is decoded in quadrature and used to increment or decreme

Re: [PATCH v2 03/17] staging: comedi: quatech_daqp_cs: fix ai cmd timing

On 02/10/15 01:23, H Hartley Sweeten wrote: According to the users manual, the conversion timing (scanrate) is fixed to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan. Currently this driver tries to fake other conversion speeds by always sampling the inputs at 100 kHz and

[PATCH 4/5] Drivers: hv: util: catch allocation errors

Catch allocation errors in hvutil_transport_send. Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport abstraction') Signed-off-by: Olaf Hering --- drivers/hv/hv_utils_transport.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/hv/hv_utils_

[PATCH 2/5] tools: hv: report ENOSPC errors in hv_fcopy_daemon

Currently some "Unspecified error 0x80004005" is reported on the Windows side if something fails. Handle the ENOSPC case and return ERROR_DISK_FULL, which allows at least Copy-VMFile to report a meaning full error. Signed-off-by: Olaf Hering --- include/uapi/linux/hyperv.h | 1 + tools/hv/hv_fc

[PATCH 0/5] various hyperv fixes

Various hyperv changes, based on v4.3-rc4 linux.git Olaf Olaf Hering (5): Drivers: hv: utils: run polling callback always in interrupt context tools: hv: report ENOSPC errors in hv_fcopy_daemon tools: hv: remove repeated HV_FCOPY string Drivers: hv: util: catch allocation errors Drive

[PATCH 3/5] tools: hv: remove repeated HV_FCOPY string

HV_FCOPY is already used as identifier in syslog. Signed-off-by: Olaf Hering --- tools/hv/hv_fcopy_daemon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c index f1d7426..fdc9ca4 100644 --- a/tools/hv/hv_fcopy_daemon

[PATCH 5/5] Drivers: hv: utils: use memdup_user in hvt_op_write

Use memdup_user to handle OOM. Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport abstraction') Signed-off-by: Olaf Hering --- drivers/hv/hv_utils_transport.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/hv/hv_utils_transport.c b/drive

[PATCH 1/5] Drivers: hv: utils: run polling callback always in interrupt context

Currently hv_fcopy_onchannelcallback is called from interrupts and also via the ->write function of hv_utils. Since the used global variables to maintain state are not thread safe the state can get out of sync. This affects the variable state as well as the channel inbound buffer. As suggested by

Re: [PATCH 0/3] staging: comedi: pcm3724: cleanup driver

On 01/10/15 19:59, H Hartley Sweeten wrote: Some minor cleanup to the comedi pcm3724 PC/104 legacy driver. H Hartley Sweeten (3): staging: comedi: pcm3724: tidy up multi-line comments staging: comedi: pcm3724: tidy up register map defines staging: comedi: pcm3724: update the MODULE_DESC

Re: [PATCH] staging: comedi: 8255: prefer using the BIT macro

On 01/10/15 19:05, H Hartley Sweeten wrote: Fix the checkpatch.pl issues. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/8255.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/8255.h b/drivers/staging/comed

[PATCH 20/20] staging: wilc1000: remove unnecessary parentheses in host_int_remove_wep_key

This patch removes unnecessary parentheses in host_int_remove_wep_key found by checkpatch. CHECK: Unnecessary parentheses around wfi_drv->hSemTestKeyBlock FILE: drivers/staging/wilc1000/host_interface.c:4320: Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 fi

[PATCH 14/20] staging: wilc1000: rename hWFIDrv in host_int_remove_wep_key

This patch replaces hWFIDrv with wfi_drv that is first argument of host_int_remove_wep_key to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 16/20] staging: wilc1000: rename s32Error in host_int_remove_wep_key

This patch replaces s32Error with result in host_int_remove_wep_key to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/

[PATCH 19/20] staging: wilc1000: fix NULL comparison in host_int_remove_wep_key

This patch fixes NULL comparison style in host_int_remove_wep_key found by checkpatch. CHECK: Comparison to NULL could be written "!wfi_drv" FILE: drivers/staging/wilc1000/host_interface.c:4300 Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 i

[PATCH 15/20] staging: wilc1000: rename u8keyIdx in host_int_remove_wep_key

This patch replaces u8keyIdx with index that is secondard argument of host_int_remove_wep_key to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 17/20] staging: wilc1000: remove pstrWFIDrv in host_int_remove_key

This patch remove pstrWFIDrv in host_int_remove_key. There is no need to make another variable to check if first argument is NULL or not. It is able to use wfi_drv directly that is first argument of this function. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 5 ++--

[PATCH 18/20] staging: wilc1000: remove multiple blank in host_int_remove_wep_key

This patch removes multiple blank in host_int_remove_wep_key found by checkpatch. CHECK: Please don't use multiple blank lines FILE: drivers/staging/wilc1000/host_interface.c:4299: FILE: drivers/staging/wilc1000/host_interface.c:4309: FILE: drivers/staging/wilc1000/host_interface.c:4315: Signed-o

[PATCH 11/20] staging: wilc1000: remove host_int_get_pmkid_info

This function is defined but never used anywhere, so just delete it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 35 --- drivers/staging/wilc1000/host_interface.h | 25 -- 2 files changed, 60 deletions(-) diff --git

[PATCH 09/20] staging: wilc1000: delete multiple blank lines

This patch deletes multiple blank lines found by checkpatch CHECK: Please don't use multiple blank lines FILE: drivers/staging/wilc1000/host_interface.c:5393: Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/sta

[PATCH 13/20] staging: wilc1000: fix return type of host_int_remove_wep_key

This patch changes return type of host_int_remove_wep_key from s32 to int. s32Error gets return value from wilc_mq_send that has return type of int. It should be changed return type by int as well as data type of s32Error. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c

[PATCH 08/20] staging: wilc1000: rename u32mode in host_int_set_operation_mode

This patch replaces u32mode with mode that is second argument of host_int_set_operation_mode to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 10/20] staging: wilc1000: remove host_int_test_set_int_wid

This function is defined but never used anywhere, so just delete it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 43 --- 1 file changed, 43 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

[PATCH 12/20] staging: wilc1000: remove host_int_set_RSNAConfigPSKPassPhrase

This function is defined but never used anywhere, so just delete it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 31 --- drivers/staging/wilc1000/host_interface.h | 16 2 files changed, 47 deletions(-) diff --git a/dri

[PATCH 07/20] staging: wilc1000: rename hWFIDrv in host_int_set_operation_mode

This patch replaces hWFIDrv with wfi_drv that is first argument of host_int_set_operation_mode to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-

[PATCH 04/20] staging: wilc1000: rename u32address in host_int_set_wfi_drv_handler

This patch replaces u32address with address to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_int

[PATCH 02/20] staging: wilc1000: remove multiple blank lines

This patch removes multiple blank lines found by checkpatch CHECK: Please don't use multiple blank lines FILE: drivers/staging/wilc1000/host_interface.c:5343: FILE: drivers/staging/wilc1000/host_interface.c:5372: FILE: drivers/staging/wilc1000/host_interface.c:5389: Signed-off-by: Chaehyun Lim -

[PATCH 06/20] staging: wilc1000: rename s32Error in host_int_set_operation_mode

This patch replaces s32Error with result to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interfa

[PATCH 01/20] staging: wilc1000: fix return type of host_int_set_wfi_drv_handler

This patch changes return type of host_int_set_wfi_drv_handler from s32 to int. s32Error gets return value from wilc_mq_send that has return type of int. It should be changed return type by int as well as data type of s32Error. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interf

[PATCH 05/20] staging: wilc1000: fix return type of host_int_set_operation_mode

This patch changes return type of host_int_set_operation_mode from s32 to int. s32Error gets return value from wilc_mq_send that has return type of int. It should be changed return type by int as well as data type of s32Error. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interfa

[PATCH 03/20] staging: wilc1000: rename s32Error in host_int_set_wfi_drv_handler

This patch replaces s32Error with result to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interfa

[PATCH 3/6] staging: wilc1000: host_interface.c : removes unused local variables

From: Leo Kim This patch removes unused local variables from host_interface.c. The unused local variable, s32Error is used just to return zero, so this patch calls "returns 0" instead of "return s32Error" after removing s32Error. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/stag

  1   2   >