On 10/3/2015 11:55 PM, Martin Kletzander wrote:
Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl.
Hi Greg,
Is there a way to signal people/tools that a certain driver parks in
staging on their way **out** of the kernel
and not the other way around? I guess you (nor Doug)
Reads of dgnc_poll_tick are protected by dgnc_poll_lock spinlock, but the write
to dgnc_poll_tick is not. It could theoretically race.
Signed-off-by: Salah Triki
---
drivers/staging/dgnc/dgnc_driver.c | 2 +-
drivers/staging/dgnc/dgnc_driver.h | 1 +
drivers/staging/dgnc/dgnc_sysfs.c | 9 ++
Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl.
Signed-off-by: Martin Kletzander
---
There is one warning reported in this patch though. That's because of
the multiline string and it's pre-existing. Feel free to let me know
if that should be fixed too, I'd also remove the
This is a patch to remove the function ieee80211_ccmp_null().
This function does nothing and can therefore be safely removed.
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80
This is a patch to remove the function ieee80211_wep_null().
This function does nothing and can therefore be safely removed.
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c| 1 -
2 files c
This is a patch to remove the function ieee80211_tkip_null().
This function does nothing, and can therefore be safely removed.
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 --
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 -
2 f
This is a series of patches to remove three functions that do no
processing in staging/rtl8192u/ieee80211/.
Before:
drivers/staging/rtl8192u/$ grep _null\( *.c
drivers/staging/rtl8192u/$
drivers/staging/rtl8192u/ieee80211/$ grep _null\( *.c
ieee80211_crypt_ccmp.c:void ieee80211_ccmp_null(void)
ie
It looks like this is worth checking. The direct return preceeded by a
failure path with a goto may also be a problem.
julia
On Wed, 30 Sep 2015, kbuild test robot wrote:
> CC: kbuild-...@01.org
> TO: Leo Kim
> CC: "Greg Kroah-Hartman"
> CC: Tony Cho
> CC: de...@driverdev.osuosl.org
>
> tr
This patch to ad7746.c makes the comment block end with a */
on a separate line.
Signed-off-by: Hugo Camboulive
---
drivers/staging/iio/cdc/ad7746.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 10fa3
On Oct 3, 2015, at 7:39 AM, Anjali Menon wrote:
> Added a blank line after declaration to fix the coding
> style warning detected by checkpatch.pl
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Anjali Menon
> ---
> drivers/staging/lustre/lustre/llite/llite_capa.c | 1 +
The dgnc_init_globals() function is only initializing the timer so
initialize it directly and remove dgnc_init_globals() and change the
comment appropriately.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_driver.c | 18 ++
1 file changed, 2 insertions(+), 16 deleti
This NULL test is not required as iounmap will validate the argument.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_cls.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index d62b745..75040da
checkpatch was warning us that the alignment should match the open
parenthesis.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_cls.c| 14 +++---
drivers/staging/dgnc/dgnc_driver.c | 2 +-
drivers/staging/dgnc/dgnc_neo.c| 2 +-
drivers/staging/dgnc/dgnc_tty.c|
Space is not necessary after typecast.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_cls.c| 6 +++---
drivers/staging/dgnc/dgnc_driver.c | 6 +++---
drivers/staging/dgnc/dgnc_mgmt.c | 6 +++---
drivers/staging/dgnc/dgnc_neo.c| 12 ++--
drivers/staging/dgnc/dgn
Blank lines are not needed after opening braces. checkpatch was giving
us warnings about this.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_cls.c| 4
drivers/staging/dgnc/dgnc_driver.c | 3 ---
drivers/staging/dgnc/dgnc_mgmt.c | 1 -
drivers/staging/dgnc/dgnc_neo.c
Change the NULL comparison style as warned by checkpatch.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_tty.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 35f3ec4..b40fd67 100644
-
globals variable will be initialied to 0 and the global pointers will be
to NULL. No need to initialize them separately.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_driver.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/s
checkpatch warns us about multiple blank lines which are not needed.
Remove them.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_driver.c | 10
drivers/staging/dgnc/dgnc_mgmt.c | 5
drivers/staging/dgnc/dgnc_neo.c| 37 ---
drivers/stagin
Blank lines are not needed before closing braces. checkpatch was giving
warning about this.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_cls.c| 7 ---
drivers/staging/dgnc/dgnc_driver.c | 2 --
drivers/staging/dgnc/dgnc_mgmt.c | 1 -
drivers/staging/dgnc/dgnc_neo.c|
checkpatch was warning us about extra unneeded parenthesis.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_neo.c | 2 +-
drivers/staging/dgnc/dgnc_sysfs.c | 48 +++
drivers/staging/dgnc/dgnc_tty.c | 14 ++--
3 files changed, 32 inser
These variables were only assigned some values but were never used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_cls.c | 4 +---
drivers/staging/dgnc/dgnc_tty.c | 11 ++-
2 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/dr
Replace memcmp() with ether_addr_equal(). In every location where the
replacement was done, the addresses accessed are
__aligned(2). Structures accessed either stack or heap allocated, no
direct memory casts to possibly unaligned structs are used.
Involved structures:
typedef struct hfa384x_authe
Added a blank line after declaration to fix the coding
style warning detected by checkpatch.pl
WARNING: Missing a blank line after declarations
Signed-off-by: Anjali Menon
---
drivers/staging/lustre/lustre/llite/llite_capa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lu
On Sat, Oct 03, 2015 at 09:41:40PM +1300, Leslie Viljoen wrote:
> Add support for the Bosto 14WA graphics tablet. This is originally based
> off the hanwang.c tablet driver since the chip is similar. Unfortunately
> the usbhid driver grabs the tablet first so that has to be unbound for
> this drive
Please disregard this patch for now - I made a bunch of style fixes
and I think I've killed it. I'll have to go over it and find what I've
broken. Sorry for the noise.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject
On 15/08/15 21:05, Jonathan Cameron wrote:
> On 08/08/15 20:16, Dan Carpenter wrote:
>> "num_read" is in byte units but we are write u16s so we end up write
>> twice as much as intended.
>>
>> Signed-off-by: Dan Carpenter
> Hi Dan,
>
> This is fine. Given it's an old bug, Greg is not going to tak
The spin_lock_irqsave is moved to just beginning of critical section.
This change moves a couple of return statements out of the lock.
Signed-off-by: Chandra S Gorentla
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/st
- kfree is being called for the members of the queue without
de-queuing them; they are just inserted within this function;
they are supposed to be de-queued and freed in a function
for receiving the queue items
- goto statements are removed
- After kfree correction, there is no need for
Add support for the Bosto 14WA graphics tablet. This is originally based
off the hanwang.c tablet driver since the chip is similar. Unfortunately
the usbhid driver grabs the tablet first so that has to be unbound for
this driver to work.
Signed-off-by: Leslie Viljoen
---
drivers/input/tablet/bo
29 matches
Mail list logo
