Re: [PATCH staging 2/3] wilc1000 : Remove leftover comment delimiters

2015-09-28 Thread Greg KH
On Mon, Sep 28, 2015 at 11:25:04PM -0700, Anish Bhatt wrote: > On Mon, Sep 28, 2015 at 5:42 PM, Greg KH wrote: > > On Fri, Sep 25, 2015 at 12:45:16AM -0700, Anish Bhatt wrote: > >> Remove leftover comment delimiters that were only partially removed > >> in a previous cleanup. > > > > You also chan

Re: [PATCH staging 2/3] wilc1000 : Remove leftover comment delimiters

2015-09-28 Thread Anish Bhatt
On Mon, Sep 28, 2015 at 5:42 PM, Greg KH wrote: > On Fri, Sep 25, 2015 at 12:45:16AM -0700, Anish Bhatt wrote: >> Remove leftover comment delimiters that were only partially removed >> in a previous cleanup. > > You also changed code formatting, which isn't ok to do in the same > patch, please bre

[PATCH 26/29] staging/lustre: Remove server-only recovery-related bits

2015-09-28 Thread green
From: Oleg Drokin This patch is a first stab at trying to remove structure fields from obd_export and obd structures that are only used on the server or make sense on the server. These include tracking requests in recovery, various recovery stages, lists of recovered and not yet recovered clients

[PATCH 27/29] staging/lustre: Remove ccc_attr/conf_set()

2015-09-28 Thread green
From: Oleg Drokin These seem to be unused. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lclient.h| 4 drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 15 --- 2 files changed, 19 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/

[PATCH 28/29] staging/lustre: Remove unused ccc_io_fini()

2015-09-28 Thread green
From: Oleg Drokin Does not appear to be used anywhere. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lclient.h| 1 - drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 7 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lc

[PATCH 29/29] staging/lustre: Remove ccc_transient_page_* methods

2015-09-28 Thread green
From: Oleg Drokin All of them but the ccc_transient_page_prep are unused, so remove the unused ones. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lclient.h| 19 - drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 48 -- 2 files changed

[PATCH 19/29] staging/lustre: remove lots of dead code

2015-09-28 Thread green
From: Arnd Bergmann This is a large patch to remove all dead code from obdclass and ptlrpc, purely removing functions and declarations now, so despite the size should be easy enough to verify. Signed-off-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_

[PATCH 16/29] staging/lustre/ptlrpc: Drop unused client code

2015-09-28 Thread green
From: Oleg Drokin These client request/import functions are not used anywhere, so drop them. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_net.h | 13 --- drivers/staging/lustre/lustre/ptlrpc/client.c | 95 -- d

[PATCH 15/29] staging/lustre/obdclass: Drop unused code from obdo.c

2015-09-28 Thread green
From: Oleg Drokin These functions are not even referenced in any header files anymore. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/obdo.c | 170 -- 1 file changed, 170 deletions(-) diff --git a/drivers/staging/lustr

[PATCH 12/29] staging/lustre/obdclass: Remove unused functions from genops.c

2015-09-28 Thread green
From: Oleg Drokin These functions are mostly used on the server. class_uuid2obd, get_devices_count, class_obd_list, class_conn2obd, class_conn2cliimp, class_connected_export, obd_exports_barrier, kuc_* (kernel-userspace communications). Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --

[PATCH 23/29] staging/lustre/fid: Get rid of lcs_srv in lu_client_seq

2015-09-28 Thread green
From: Oleg Drokin Since we know lcs_srv is always NULL, just get rid of it completely and fix up all the code to assumee it was never there. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fid/fid_request.c| 48 -- drivers/staging/lustre/lustre/fid/lproc_fi

[PATCH 25/29] staging/lustre/obdclass: Remove unused nid_hash

2015-09-28 Thread green
From: Oleg Drokin nid_hash is used on export to faster find clients based on their NID. There's no use for that on the client. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lustre_export.h | 1 - drivers/staging/lustre/lustre/include/obd.h| 2 - drivers/staging/lu

[PATCH 13/29] staging/lustre: Remove unused function class_handle_hash_back()

2015-09-28 Thread green
From: Oleg Drokin No callers left. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_handles.h | 1 - drivers/staging/lustre/lustre/obdclass/lustre_handles.c | 13 - 2 files changed, 14 deletions(-) diff --git a/drivers/stagi

[PATCH 14/29] staging/lustre: Remove unused function server_name2svname()

2015-09-28 Thread green
From: Oleg Drokin All users are only in the server code Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lustre_disk.h| 2 -- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 27 -- 2 files changed, 29 deletions(-) diff

[PATCH 20/29] staging/lustre/fid: Remove server fid function declarations

2015-09-28 Thread green
From: Oleg Drokin Those functions are not present anywhere in the client code. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_fid.h | 24 -- 1 file changed, 24 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_fid.h b/driv

[PATCH 21/29] staging/lustre/fid: seq_client_init/fini don't need to be exported

2015-09-28 Thread green
From: Oleg Drokin In fact they could be static as they are only used inside this file, so remove EXPORT_SYMBOL and declarations. Also seq_client_init is always called with srv = NULL, so just drop this argument. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fid/fid_request.c

[PATCH 17/29] staging/lustre/ptlrpc: secure wrapping code cleanup

2015-09-28 Thread green
From: Oleg Drokin Drop unused functions. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_sec.h | 20 -- drivers/staging/lustre/lustre/ptlrpc/sec.c | 116 drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c| 329 -

[PATCH 22/29] staging/lustre/fid: Remove unused seq_client_get_seq function

2015-09-28 Thread green
From: Oleg Drokin Also while we are at it, remove seq_site_fini forward declaration as there's no such function anymore. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fid/fid_request.c| 51 -- drivers/staging/lustre/lustre/include/lustre_fid.h | 3 -- 2

[PATCH 24/29] staging/lustre/fid: Remove unused struct lu_server_seq

2015-09-28 Thread green
From: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_fid.h | 51 -- 1 file changed, 51 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_fid.h b/drivers/staging/lustre/lustre/include/lustre_fid.h index bbe3ff8..

[PATCH 11/29] staging/lustre/ldlm: Remove unused round_timeout function

2015-09-28 Thread green
From: Oleg Drokin It's not referenced anywhere anymore. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c b/drivers/staging/lustre/l

[PATCH 18/29] staging/lustre: Drop unused obdo_from_la() and la_from_obdo()

2015-09-28 Thread green
From: Oleg Drokin They are no longer used anywhere. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- .../lustre/lustre/obdclass/linux/linux-obdo.c | 137 - 1 file changed, 137 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-obdo.

[PATCH 09/29] staging/lustre: Remove unused functions and definitions from cl_object

2015-09-28 Thread green
From: Oleg Drokin cl_object_header_fini, cl_object_has_locks, cl_attr2lvb, cl_page_list_own, cl_page_list_unmap, cl_2queue_assume, cl_io_print, cl_enqueue, also cleanup extern declarations in cl_object.h Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/i

[PATCH 10/29] staging/lustre: Remove unused lu_object functions.

2015-09-28 Thread green
From: Oleg Drokin Quite a bunch of them are only used on the server. lu_object_put_nocache, lu_object_invariant, lu_dev_del_linkage, lu_context_tags_update, lu_context_tags_clear, lu_session_tags_update, lu_session_tags_clear, lu_env_refill_by_tags, lu_printk_printer, lu_object_assign_fid, lu_obj

[PATCH 05/29] staging/lustre: Remove unused reply state batches code

2015-09-28 Thread green
From: Oleg Drokin rs_batch is used on the server only. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_net.h | 6 +- drivers/staging/lustre/lustre/ptlrpc/service.c | 145 - 2 files changed, 1 insertion(+), 150 de

[PATCH 04/29] staging/lustre: Remove unused req_capsule_server_grow

2015-09-28 Thread green
From: Oleg Drokin It's only used on the server Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre_req_layout.h | 3 -- drivers/staging/lustre/lustre/ptlrpc/layout.c | 62 -- 2 files changed, 65 deletions(-) diff --git a/d

[PATCH 01/29] staging/lustre: Remove unused target_print_req()

2015-09-28 Thread green
From: Oleg Drokin This is a server-side request printing function, so we don't really need it on the client. Signed-off-by: Oleg Drokin Reported-by: Arnd Bergmann --- .../staging/lustre/lustre/include/lprocfs_status.h | 4 --- .../staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c| 30 -

[PATCH 08/29] staging/lustre: Remove unused ptlrpcd_add_rqset()

2015-09-28 Thread green
From: Oleg Drokin No point in retaining it if it's unused. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_net.h | 1 - drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c | 42 -- 2 files changed, 43 deletions(-) dif

[PATCH 06/29] staging/lustre: Remove high-priority request callbacks

2015-09-28 Thread green
From: Oleg Drokin This function is only used on the server where real high-priority requests actually exist. This deletes ptlrpc_hpreq_handler() and ptlrpc_request_change_export() Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_net.h | 3

[PATCH 02/29] staging/lustre: Remove unused lustre_acl_xattr_merge2posix()

2015-09-28 Thread green
From: Oleg Drokin Apparently this is only used only on the metadata server. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lustre_eacl.h| 4 - drivers/staging/lustre/lustre/obdclass/acl.c | 119 - 2 files changed, 12

[PATCH 07/29] staging/lustre: Remove unused statfs_pack()

2015-09-28 Thread green
From: Oleg Drokin It's only used on the server. Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_lib.h | 1 - drivers/staging/lustre/lustre/obdclass/statfs_pack.c | 14 -- 2 files changed, 15 deletions(-) diff --git a/drive

[PATCH 03/29] staging/lustre/ptlrpc: Remove server-specific health checks

2015-09-28 Thread green
From: Oleg Drokin ptlrpc_service_health_check is only used on a service, so it makes no point to retain it in the client code. Also removing it's helpers: ptlrpc_svcpt_health_check and ptlrpc_nrs_req_peek_nolock Reported-by: Arnd Bergmann Signed-off-by: Oleg Drokin --- drivers/staging/lustre/

[PATCH 00/29] Removal of unused Lustre code

2015-09-28 Thread green
From: Oleg Drokin This set removes a bunch of lustre code that is no lonver relevant, is server specific or is otherwise unused. Please consider. More to come later. Arnd Bergmann (1): staging/lustre: remove lots of dead code Oleg Drokin (28): staging/lustre: Remove unused target_print_re

Re: [PATCH] Staging: rtl8188eu: os_dep: Stop using DBG_88E

2015-09-28 Thread Greg Kroah-Hartman
On Fri, Sep 25, 2015 at 10:23:44PM +0530, Shraddha Barke wrote: > Stop using DBG_88E which is a custom macro for printing debugging > messages. Instead start using pr_debug and in the process define > pr_fmt. > > Signed-off-by: Shraddha Barke > --- > drivers/staging/rtl8188eu/os_dep/os_intfs.c |

Re: [PATCH 66/73] staging/lustre: remove lots of dead code

2015-09-28 Thread Oleg Drokin
On Sep 28, 2015, at 10:08 PM, Greg Kroah-Hartman wrote: > On Mon, Sep 28, 2015 at 11:36:01AM +0200, Arnd Bergmann wrote: >> On Sunday 27 September 2015 16:46:06 gr...@linuxhacker.ru wrote: >>> From: Oleg Drokin >>> >>> This is a large patch to remove all dead code from obdclass and >>> ptlrpc,

Re: [PATCH 66/73] staging/lustre: remove lots of dead code

2015-09-28 Thread Greg Kroah-Hartman
On Mon, Sep 28, 2015 at 11:36:01AM +0200, Arnd Bergmann wrote: > On Sunday 27 September 2015 16:46:06 gr...@linuxhacker.ru wrote: > > From: Oleg Drokin > > > > This is a large patch to remove all dead code from obdclass and > > ptlrpc, purely removing functions and declarations now, so > > despit

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-28 Thread Dan Carpenter
On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > - The message queue is replaced with standard Linux linked list > - kmem_cache is used for list members > - A check for return value of receive method is added > - GFP_ATOMIC is changed to GFP_KERNEL > - A few other related

Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code

2015-09-28 Thread Greg KH
On Mon, Sep 28, 2015 at 10:10:42PM +0100, Luis de Bethencourt wrote: > Remove the disabled code, for now, with #if 0. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > The code after the return is dead code. There is a comment saying it is > disabled for now, it would be good if the code

Re: [PATCH] staging: comedi: ni_tiocmd: remove unused code

2015-09-28 Thread Greg KH
On Mon, Sep 28, 2015 at 09:54:45PM +0100, Luis de Bethencourt wrote: > Remove the unused code, which isn't implemented yet, using #if 0. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > The code after the return is dead code. My understanding is that it is > there for when the output co

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-28 Thread Greg KH
On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > - The message queue is replaced with standard Linux linked list > - kmem_cache is used for list members Why? > - A check for return value of receive method is added > - GFP_ATOMIC is changed to GFP_KERNEL Why? Are you sur

Re: [PATCH 00/29] staging: most: update driver

2015-09-28 Thread Greg KH
On Mon, Sep 28, 2015 at 05:18:29PM +0200, Christian Gromm wrote: > This patchset is needed to pull Microchip's latest driver changes into > the staging tree. The patches include bug fixes, feature updates and > coding style changes. I'll take these, but I really don't want to see new "features" ad

Re: [PATCH staging 2/3] wilc1000 : Remove leftover comment delimiters

2015-09-28 Thread Greg KH
On Fri, Sep 25, 2015 at 12:45:16AM -0700, Anish Bhatt wrote: > Remove leftover comment delimiters that were only partially removed > in a previous cleanup. You also changed code formatting, which isn't ok to do in the same patch, please break it up into different patches. thanks, greg k-h __

Re: [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove code that no effect

2015-09-28 Thread Greg KH
On Tue, Sep 29, 2015 at 12:07:43AM +0530, Chandra Gorentla wrote: > Please do not review this. This is duplicate to - > [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove ineffective > code I don't understand, you sent 2 2/2 patches, which one do I look at? Please just resend the w

Re: [PATCH 5/6] staging: wilc1000: remove wilc_platform include file

2015-09-28 Thread Greg KH
On Wed, Sep 23, 2015 at 06:03:49PM +0900, Chaehyun Lim wrote: > This patch removes wilc_platform.h include file in wilc_oswrapper.h > Because wilc_platform.h have several standard header files so that some > header file should be included .c file to avoid compilation errors. > > Signed-off-by: Cha

Re: [PATCH 3/4] staging: wilc1000: remove define WILC_PARSE_SCAN_IN_HOST

2015-09-28 Thread Greg KH
On Wed, Sep 23, 2015 at 04:10:54PM +0900, Glen Lee wrote: > The define WILC_PARSE_SCAN_IN_HOST is always used in the driver, so just > delete ifdef WILC_PARSE_SCAN_IN_HOST line, ifndef WILC_PARSE_SCAN_IN_HOST > line and it's related codes. Finally, remove define in Makefile. > > Signed-off-by: Gle

Re: [PATCH 3/3] Staging: rts5208: Coding style warnings fix for block comments

2015-09-28 Thread Greg KH
On Mon, Sep 21, 2015 at 11:29:50PM +0530, Punit Vara wrote: > This patch is to rtsx_chip.h that fixes up following warning reported > by checkpatch.pl : > > -Block comments use * on subsequent lines > -Block comments use a trailing */ on a separate line > > Signed-off-by: Punit Vara > --- > dri

Re: [PATCHv4 3/3] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2015-09-28 Thread drinkcat
Hi Enric, On Fri, Sep 25, 2015 at 09:29:28PM +0200, Enric Balletbo i Serra wrote: > At the moment it only supports ANX7814. > > The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > designed for portable devices. > > This driver adds initial support and supports HDMI to DP p

[PATCH] staging:rtl8188eu: style fix comparisons moved to right

2015-09-28 Thread BryanSPaul
fixed style issue comparisons should place the constant on the right side of the test Signed-off-by: BryanSPaul --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rt

Re: [PATCH] staging:rtl8188eu: style fix comparisons moved to right

2015-09-28 Thread Greg KH
On Mon, Sep 28, 2015 at 06:02:34PM -0600, BryanSPaul wrote: > fixed style issue comparisons should place the constant on the right side of > the test > > Signed-off-by: BryanSPaul I doubt you sign legal papers without a ' ' in them :( Please fix this up, and properly wrap your changelog at 72

Re: [lustre-devel] [PATCH 30/73] staging/lustre: use 64-bit times for request times

2015-09-28 Thread Dilger, Andreas
On 2015/09/28, 2:19 AM, "lustre-devel on behalf of Arnd Bergmann" wrote: >On Monday 28 September 2015 01:09:18 Dilger, Andreas wrote: >> On 2015/09/27, 10:45 PM, "gr...@linuxhacker.ru" >> wrote: >> >diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c >> >b/drivers/staging/lustre/lustre/pt

[PATCH] staging: rtl8712: remove dead code

2015-09-28 Thread Luis de Bethencourt
The while() loop will only exit in a return or a goto ask_for_joinbss, which means it will never break and execute the return after it. Removing return _FAIL since it is dead code. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8712/rtl871x_mlme.c | 2 +- 1 file changed, 1 insertion(+

[PATCH] staging: comedi: cb_pcidas64: remove unused code

2015-09-28 Thread Luis de Bethencourt
Remove the disabled code, for now, with #if 0. Signed-off-by: Luis de Bethencourt --- Hi, The code after the return is dead code. There is a comment saying it is disabled for now, it would be good if the code is removed with #if 0 as well. Thanks, Luis drivers/staging/comedi/drivers/cb_pcida

[PATCH] staging: comedi: ni_tiocmd: remove unused code

2015-09-28 Thread Luis de Bethencourt
Remove the unused code, which isn't implemented yet, using #if 0. Signed-off-by: Luis de Bethencourt --- Hi, The code after the return is dead code. My understanding is that it is there for when the output commands are implemented in the future. Meanwhile it would be clearer if the code is remo

Re: [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove code that no effect

2015-09-28 Thread Chandra Gorentla
Please do not review this. This is duplicate to - [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove ineffective code On Mon, Sep 28, 2015 at 11:43:56PM +0530, Chandra S Gorentla wrote: > Signed-off-by: Chandra S Gorentla > --- > drivers/staging/wilc1000/wilc_msgqueue.c | 5 - >

Re: [PATCH v2] staging: rtl8723au: Fix resource leak

2015-09-28 Thread Jes Sorensen
Mateusz Kulikowski writes: > Firmware was not released properly if kmemdup fails. > > Addresses-Coverity-Id: 1269118 > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Jes Sorensen

[PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove ineffective code

2015-09-28 Thread Chandra S Gorentla
Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index a01ada4..1a411d3 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove code that no effect

2015-09-28 Thread Chandra S Gorentla
Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index a01ada4..1a411d3 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-28 Thread Chandra S Gorentla
- The message queue is replaced with standard Linux linked list - kmem_cache is used for list members - A check for return value of receive method is added - GFP_ATOMIC is changed to GFP_KERNEL - A few other related minor changes Signed-off-by: Chandra S Gorentla --- - Comments of Dan Carpe

[PATCH RESEND] staging/rdma: Kconfig change STAGING_RDMA to be tristate.

2015-09-28 Thread ira . weiny
From: Ira Weiny STAGING_RDMA was failing to build when INFINIBAND was set to 'm' and STAGING_RDMA was set to 'y'. Making this a tristate properly inherits the 'm' from the INFINIBAND setting. Reviewed-by: Dalessandro, Dennis Reviewed-by: John, Jubin Reviewed-by: Mike Marciniszyn Signed-off-b

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-28 Thread Sudip Mukherjee
On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > On 09/28/2015 06:18 AM, Sudip Mukherjee wrote: > >On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: > >>On 09/26/2015 11:49 AM, Punit Vara wrote: > >>>This patch is to the rtl871x_ioctl_linux.c that fixes up following > >>>

[PATCH 01/29] staging: most: change structure initialization

2015-09-28 Thread Christian Gromm
By applying this patch the initialization of the most_aim structure is performed at compile time. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/aim-network/networking.c | 14 -- drivers/staging/most/aim-v4l2/video.c | 13 +++--

[PATCH 11/29] staging: most: fix buffer size for DIM2

2015-09-28 Thread Christian Gromm
This patch reduces the DBR buffer size to prevent an overflow in the DIM2 module. It is needed, because the MediaLB hardware has problems with DBR buffers that exceed the size of 255 messages. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-dim2/dim2_h

[PATCH 16/29] staging: most: add fair buffer distribution

2015-09-28 Thread Christian Gromm
This patch ensures a fair distribution of buffers, when two AIMs share a single channel. The AIMs then won't be able to use more than half of all pre-allocated buffers of the linked channel. However, in case the channel is not shared, the AIM can exclusively use all available buffers. Signed-off-b

[PATCH 02/29] staging: most: remove aim reset

2015-09-28 Thread Christian Gromm
This patch partly reverts a modification of function most_stop_channel() that is trying to reset an established link between an AIM and an HDM in all suitable places. But since the function most_stop_channel() is stopping the data transfer it is the wrong place to do so. Signed-off-by: Andrey Shve

[PATCH 26/29] staging: most: fix style problems

2015-09-28 Thread Christian Gromm
This patch simply corrects style violations. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c index dff8f74..18c3

[PATCH 18/29] staging: most: add multi channel support to sound AIM

2015-09-28 Thread Christian Gromm
This patch adds 5.1 surround configuration with subbuffer cross-check, when establishing a link to the core. For the sake of simplicity, only one specific channel configuration is allowed. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c | 27 +-

[PATCH 25/29] staging: most: move initialization code

2015-09-28 Thread Christian Gromm
This pathch moves the initialization of the PCM middle layer hardware parameters to function audio_set_hw_params(). Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drive

[PATCH 13/29] staging: most: simplify code

2015-09-28 Thread Christian Gromm
This patch simply rearranges code for better readability. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-usb/hdm_usb.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/dr

[PATCH 22/29] staging: most: purge unecessary variable

2015-09-28 Thread Christian Gromm
This patch purges a temp. variable to store the functions return value. Since the content is never being evaluated, it can safely be removed. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drive

[PATCH 19/29] staging: most: include vendor in audio card's shortname

2015-09-28 Thread Christian Gromm
This patch adds Microchip as vendor to the audio card's shortname to be displayed, when playback and capture devices are queried. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/

[PATCH 20/29] staging: most: make hardware parameters channel exclusive

2015-09-28 Thread Christian Gromm
Since the PCM interface's hardware parameters are channel/substream exclusive, the struct snd_pcm_hardware needs to be embedded in the channel structure. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c | 68 +--- 1 file changed, 36 insertio

[PATCH 28/29] staging: most: add poll syscall to AIM cdev

2015-09-28 Thread Christian Gromm
This patch adds the implementation of the poll syscall to the AIM cdev. To have the full functionality, a helper function is needed in the core module to retrieve the instantaneous availability of tx buffers. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-cdev/cdev.c | 26

[PATCH 23/29] staging: most: add missing channel initialization

2015-09-28 Thread Christian Gromm
This patch adds missing initialization of channel count for 8-bit mono audio resolution. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sou

[PATCH 24/29] staging: most: rename function

2015-09-28 Thread Christian Gromm
This patch renames the function audio_set_pcm_format(). Since the function doesn't only set the PCM format anymore and to guard against misunderstandings, its name needs to be changed. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c |4 ++-- 1 file changed, 2 insert

[PATCH 21/29] staging: most: squash AIM sound

2015-09-28 Thread Christian Gromm
This patch removes debug messages and prevents the sound AIM from being noisy in kernel log. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/mo

[PATCH 29/29] staging: most: fix pcm_write input/output error

2015-09-28 Thread Christian Gromm
This patch keeps the process from sleeping after the PCM middle layer has stopped playback by calling the pcm trigger callback. The patch is needed to prevent aplay from causing a pcm_write Input/Output error. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c | 17 +

[PATCH 27/29] staging: most: remove audio resolution format check

2015-09-28 Thread Christian Gromm
This patch removes the audio format cross-check, because the definitions are not compatible. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-sound/sound.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/stagin

[PATCH 05/29] staging: most: fix USB babble on IN pipe

2015-09-28 Thread Christian Gromm
This patch prevents the HDM USB from submitting an URB with a buffer size unaligned to 512 bytes to the USB subsystem. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-usb/hdm_usb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 17/29] staging: most: refactor channel structure

2015-09-28 Thread Christian Gromm
The struct most_c_obj has the same set of attributes for each of two AIMs. This patch cleans up the code by introducing the new struct most_c_aim_obj hat contains those fields. Signed-off-by: Christian Gromm --- drivers/staging/most/mostcore/core.c | 108 +- 1 fi

[PATCH 14/29] staging: most: prevent DMA on stack

2015-09-28 Thread Christian Gromm
This patch is needed to avoid having DMA on the stack. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-usb/hdm_usb.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb

[PATCH 15/29] staging: most: consolidate code

2015-09-28 Thread Christian Gromm
The function drci_rd_reg() always delivers little endian representation of the 16-bit DCI register. The value returned by this function must always be carefully converted from __le16 to u16 type. This patch moves all those conversions to the function itself. Signed-off-by: Andrey Shvetsov Signed-

[PATCH 06/29] staging: most: fix channel operation in multi-aim context

2015-09-28 Thread Christian Gromm
This patch fixes the opening and closing process of a physical channel when used by different AIMs. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/aim-cdev/cdev.c |5 +- drivers/staging/most/aim-network/networking.c | 11 ++-- drivers/stagi

[PATCH 12/29] staging: most: fix MAC address representation

2015-09-28 Thread Christian Gromm
This patch fixes the representation of the MAC address within the HDM USB module. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-usb/hdm_usb.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/stag

[PATCH 08/29] staging: most: remove dead code

2015-09-28 Thread Christian Gromm
The case where the channel type is neither synchronous nor isochronous is already covered by a previous condition. Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-usb/hdm_usb.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drive

[PATCH 03/29] staging: most: fix race condition in AIM networking

2015-09-28 Thread Christian Gromm
If the network device is being opened right after it has been registered via function register_netdev(), the device state is not yet consistent in the context of function ndo_open(). This patch cares about having the initialization done right, before the networking device is registered. Signed-off

[PATCH 07/29] staging: most: remove unnecessary field initialization

2015-09-28 Thread Christian Gromm
Since conf->extra_len has already been reset in most_start_channel() when function hdm_configure_channel() gets called, it can safely be removed here. Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-usb/hdm_usb.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/m

[PATCH 09/29] staging: most: fix buffer synchronization request

2015-09-28 Thread Christian Gromm
Revision D of OS81118 network interface controller have the internal buffer synchronization mechanism changed. This patch adapts the driver to this. Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-usb/hdm_usb.c | 41 1 file changed, 10 insertions(+)

[PATCH 10/29] staging: most: remove macro cpu_to_le16

2015-09-28 Thread Christian Gromm
This patch removes the wrongly used macros cpu_to_le16 Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-usb/hdm_usb.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c index 3

[PATCH 00/29] staging: most: update driver

2015-09-28 Thread Christian Gromm
This patchset is needed to pull Microchip's latest driver changes into the staging tree. The patches include bug fixes, feature updates and coding style changes. Christian Gromm (29): staging: most: change structure initialization staging: most: remove aim reset staging: most: fix race condi

[PATCH 04/29] staging: most: remove shared IRQ request

2015-09-28 Thread Christian Gromm
Since there is no way find out whether the INIC has generated an interrupt, the I2C interrupt must not be registered as a shared interrupt. Reported-by: PrasannaKumar Muralidharan Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-i2c/hdm_i2c.c |2 +- 1 file changed, 1 insertion(+

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-28 Thread Larry Finger
On 09/28/2015 06:18 AM, Sudip Mukherjee wrote: On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: On 09/26/2015 11:49 AM, Punit Vara wrote: This patch is to the rtl871x_ioctl_linux.c that fixes up following warning reported by checkpatch.pl : - Comparisons should place the constant

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-28 Thread punit vara
On Mon, Sep 28, 2015 at 4:48 PM, Sudip Mukherjee wrote: > On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: >> On 09/26/2015 11:49 AM, Punit Vara wrote: >> >This patch is to the rtl871x_ioctl_linux.c that fixes up following >> >warning reported by checkpatch.pl : >> > >> >- Comparisons

Re: [PATCH v2] staging: rtl8723au: Fix resource leak

2015-09-28 Thread Sudip Mukherjee
On Sun, Sep 27, 2015 at 09:48:19PM +0200, Mateusz Kulikowski wrote: > Firmware was not released properly if kmemdup fails. > > Addresses-Coverity-Id: 1269118 > Signed-off-by: Mateusz Kulikowski > --- Not seen your v2 while replying to your v1. Sorry for the noise. regards sudip _

Re: [PATCH] staging: rtl8723au: Fix resource leak

2015-09-28 Thread Sudip Mukherjee
On Sun, Sep 27, 2015 at 09:30:54PM +0200, Mateusz Kulikowski wrote: > Firmware was not released properly if kmemdup fails. > > Addresses-Coverity-Id: 1269118 > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-28 Thread Sudip Mukherjee
On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: > On 09/26/2015 11:49 AM, Punit Vara wrote: > >This patch is to the rtl871x_ioctl_linux.c that fixes up following > >warning reported by checkpatch.pl : > > > >- Comparisons should place the constant on the right side of the test > > > >

Re: [PATCH 66/73] staging/lustre: remove lots of dead code

2015-09-28 Thread Arnd Bergmann
On Sunday 27 September 2015 16:46:06 gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > This is a large patch to remove all dead code from obdclass and > ptlrpc, purely removing functions and declarations now, so > despite the size should be easy enough to verify. > > Signed-off-by: Arnd Bergma

Re: [PATCH] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-28 Thread Dan Carpenter
On Sun, Sep 27, 2015 at 07:43:18PM +0530, Chandra S Gorentla wrote: > The message queue is replaced with standard Linux linked list. A check for > return value of receive method is added. > > Signed-off-by: Chandra S Gorentla > --- > drivers/staging/wilc1000/host_interface.c | 7 +++- > driver

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-28 Thread Dan Carpenter
Don't worry too much. I think your patches are basically fine. I'm a fairly experience kernel dev but I don't know what an N/M patch is... Just don't work on staging/rtl* any more. The rest of staging is fine. regards, dan carpenter ___ devel mailin

Re: [PATCH 30/73] staging/lustre: use 64-bit times for request times

2015-09-28 Thread Arnd Bergmann
On Monday 28 September 2015 01:09:18 Dilger, Andreas wrote: > On 2015/09/27, 10:45 PM, "gr...@linuxhacker.ru" > wrote: > >diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c > >b/drivers/staging/lustre/lustre/ptlrpc/events.c > >index 53f6b62..afd869b 100644 > >--- a/drivers/staging/lustre/l

Re: [PATCH 04/73] staging/lustre: tracefile: document seconds overflow

2015-09-28 Thread Arnd Bergmann
On Monday 28 September 2015 00:38:37 Dilger, Andreas wrote: > >Changing this would unfortunately change the format in an incompatible > >way, breaking all existing user space tools that access the data. > > It seems that it would be possible to fix this declaration to be > compatible with current

Re: [PATCH 25/73] staging/lustre: use 64-bit times in debug print

2015-09-28 Thread Arnd Bergmann
On Sunday 27 September 2015 23:57:30 Dilger, Andreas wrote: > >diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c > >b/drivers/staging/lustre/lustre/libcfs/debug.c > >index e93f556..ae325f7 100644 > >--- a/drivers/staging/lustre/lustre/libcfs/debug.c > >+++ b/drivers/staging/lustre/lustre/li

  1   2   >