On Sun, Sep 27, 2015 at 09:37:08PM -0700, Anish Bhatt wrote:
> If you mean -Woverflow, then that's a gcc warning, not a static checker
> warning.
Yes, I know. GCC doesn't warn for me. What are you doing different.
It is a stupid warning. It would be better to fix GCC instead.
regards,
dan ca
On Fri, Sep 25, 2015 at 10:47 PM, Dan Carpenter
wrote:
> On Fri, Sep 25, 2015 at 09:14:29AM -0700, Anish Bhatt wrote:
>> On Fri, Sep 25, 2015 at 3:50 AM, Dan Carpenter
>> wrote:
>> > On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote:
>> >> @@ -1672,11 +1673,11 @@ static int wilc_wlan_s
On 2015/09/27, 10:45 PM, "gr...@linuxhacker.ru"
wrote:
>From: Arnd Bergmann
>
>All request timestamps and deadlines in lustre are recorded in time_t
>and timeval units, which overflow in 2038 on 32-bit systems.
>
>In this patch, I'm converting them to time64_t and timespec64,
>respectively. Unfo
On Sep 27, 2015, at 8:38 PM, Dilger, Andreas wrote:
> On 2015/09/27, 10:45 PM, "gr...@linuxhacker.ru"
> wrote:
>
>> From: Arnd Bergmann
>>
>> The lustre tracefile has a timestamp defined as
>>
>> __u32 ph_sec;
>> __u64 ph_usec;
>>
>> which seems completely backwards, as the micros
On 2015/09/27, 10:45 PM, "gr...@linuxhacker.ru"
wrote:
>From: Arnd Bergmann
>
>The lustre tracefile has a timestamp defined as
>
> __u32 ph_sec;
> __u64 ph_usec;
>
>which seems completely backwards, as the microsecond portion of
>a time stamp will always fit into a __u32 value, while
On 2015/09/27, 10:45 PM, "gr...@linuxhacker.ru"
wrote:
>From: Arnd Bergmann
>
>This adapts the format string and get_seconds() call to not
>overflow in 2038 in the libcfs_debug_dumplog_internal()
>function.
>
>Signed-off-by: Arnd Bergmann
>Signed-off-by: Oleg Drokin
>---
> drivers/staging/lust
Attn: This is a legal confidential text for public records search. My name is
Abdon Deguenon,a personal attorney to a deceased who may relate to you (name
withheld for security reason) who died with no Will or Next of Kin.My firm is
seeking for the next of kin.He died with his family in an auto
From: Arnd Bergmann
Most of the code in llog.c and llog_cat.c is completely unused
on the client and can be removed, as a preparation for removing
the dt_object code.
Two tricky parts are:
- In llog_cat_close(), we rely on the fact that llh_flags never
contains LLOG_F_ZAP_WHEN_EMPTY, becaus
From: Oleg Drokin
nid_hash is used on export to faster find clients based on
their NID. There's no use for that on the client.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_export.h | 1 -
drivers/staging/lustre/lustre/include/obd.h| 2 -
drivers/staging/lu
From: Oleg Drokin
Client capabilities is an outdated feature that never worked properly,
so let's get rid of the client support since modern servers
don't have this support either.
The patch is big, but since it just removes one large feature,
so it's hopefully easy to verify.
Signed-off-by: Ol
From: Oleg Drokin
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_fid.h | 51 --
1 file changed, 51 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_fid.h
b/drivers/staging/lustre/lustre/include/lustre_fid.h
index bbe3ff8..
From: Arnd Bergmann
The connection starting/failing time stamps will overflow in 2038
on 32-bit machines, so we need to use time64_t and ktime_get_real_seconds()
instead.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c| 2 +-
From: Oleg Drokin
Also while we are at it, remove seq_site_fini forward declaration
as there's no such function anymore.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fid/fid_request.c| 51 --
drivers/staging/lustre/lustre/include/lustre_fid.h | 3 --
2
From: Oleg Drokin
ptlrpc_service_health_check is only used on a service, so
it makes no point to retain it in the client code.
Also removing it's helpers: ptlrpc_svcpt_health_check and
ptlrpc_nrs_req_peek_nolock
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustr
From: Oleg Drokin
It's only used on the server.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_lib.h | 1 -
drivers/staging/lustre/lustre/obdclass/statfs_pack.c | 14 --
2 files changed, 15 deletions(-)
diff --git a/dri
From: Oleg Drokin
rs_batch is used on the server only.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_net.h | 6 +-
drivers/staging/lustre/lustre/ptlrpc/service.c | 145 -
2 files changed, 1 insertion(+), 150
From: Oleg Drokin
In fact they could be static as they are only used inside
this file, so remove EXPORT_SYMBOL and declarations.
Also seq_client_init is always called with srv = NULL, so just
drop this argument.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fid/fid_request.c
From: Oleg Drokin
Apparently this is only used only on the metadata server.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_eacl.h| 4 -
drivers/staging/lustre/lustre/obdclass/acl.c | 119 -
2 files changed,
From: Oleg Drokin
No callers left.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_handles.h | 1 -
drivers/staging/lustre/lustre/obdclass/lustre_handles.c | 13 -
2 files changed, 14 deletions(-)
diff --git a/drivers/sta
From: Oleg Drokin
This code is not called anywhere in the current client code,
so we can remove it.
Also remove a helper function lprocfs_init_mps_stats
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lprocfs_status.h | 4 -
.../lustre/lustre/obd
From: Arnd Bergmann
Nothing uses dt_object now, so we can kill the implementation
and the stale references.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fid/lproc_fid.c |1 -
drivers/staging/lustre/lustre/fld/fld_cache.c |1 -
dri
From: Oleg Drokin
This is a server-side request printing function, so we don't
really need it on the client.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lprocfs_status.h | 4 ---
.../staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c| 30 ---
From: Oleg Drokin
No point in retaining it if it's unused.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_net.h | 1 -
drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c | 42 --
2 files changed, 43 deletions(-)
d
From: Oleg Drokin
It's only used on the server
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre_req_layout.h | 3 --
drivers/staging/lustre/lustre/ptlrpc/layout.c | 62 --
2 files changed, 65 deletions(-)
diff --git a
From: Arnd Bergmann
The llite debugfs interface contains timestamps that are computed
from timeval, which overflows in 2038 on 32-bit systems.
This changes the output to use a timespec64 type to avoid the
overflow. I also change the format to print the sub-second portion
as 9 digits (nanoseconds
From: Oleg Drokin
This function is only used on the server where real high-priority
requests actually exist.
This deletes ptlrpc_hpreq_handler() and ptlrpc_request_change_export()
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_net.h |
From: Oleg Drokin
obd_stats in the form present were only used on the server,
so let's remove them from the client code
This also removes lprocfs_init_ops_stats helper.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lprocfs_status.h | 4 -
.../
From: Oleg Drokin
All users are only in the server code
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_disk.h| 2 --
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 27 --
2 files changed, 29 deletions(-)
dif
From: Oleg Drokin
These particular helpers are unused so let's get rid of them:
ldebugfs_add_symlink, lprocfs_rd_u64, lprocfs_rd_atomic,
lprocfs_wr_atomic, lprocfs_rd_name, lprocfs_seq_read_frac_helper
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/inclu
From: Arnd Bergmann
Here, we actually have a problem in 2038 or at the latest in 2106 when
the lc_expiry variable on the wire protocol overflows, including on
64-bit architectures.
Now that the actual code was removed, only on-the wire structure
is left so we add in a y2038 warning to remind who
From: Oleg Drokin
This is unused anywhere in the client code.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lprocfs_status.h | 1 -
.../lustre/lustre/obdclass/lprocfs_status.c| 23 --
2 files changed, 24 deletions(-)
From: Oleg Drokin
Since we know lcs_srv is always NULL, just get rid of it completely
and fix up all the code to assume it was never there.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fid/fid_request.c| 48 --
drivers/staging/lustre/lustre/fid/lproc_fid
From: Oleg Drokin
Those functions are not present anywhere in the client code.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_fid.h | 24 --
1 file changed, 24 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_fid.h
b/driv
From: Arnd Bergmann
A bunch of API functions deal with time values but are now
completely unused in lustre. This removes them in order to
remove all references to time_t from the header files.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../lustre/include/linux/libcfs/libcfs_t
From: Oleg Drokin
These functions only make sense on the server.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_class.h | 2 -
drivers/staging/lustre/lustre/obdclass/genops.c | 90 ---
2 files changed, 92 deletions(-)
diff --git a/drivers/stagi
From: Oleg Drokin
Drop unused functions.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_sec.h | 20 --
drivers/staging/lustre/lustre/ptlrpc/sec.c | 116
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c| 329 ---
From: Oleg Drokin
They are no longer used anywhere.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/obdclass/linux/linux-obdo.c | 137 -
1 file changed, 137 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-obd
From: Arnd Bergmann
Several functions in Lustre call cfs_srand with do_gettimeofday
as the seed to get a pseudo-random number.
There is no bug here, but changing it to use ktime_get_ts64()
gets us closer to deprecating do_gettimeofday() and makes it slightly
more random.
Affected functions are:
From: Oleg Drokin
This patch is a first stab at trying to remove structure fields
from obd_export and obd structures that are only used on the
server or make sense on the server. These include tracking
requests in recovery, various recovery stages, lists of
recovered and not yet recovered clients
From: Oleg Drokin
These functions are mostly used on the server.
class_uuid2obd, get_devices_count, class_obd_list, class_conn2obd,
class_conn2cliimp, class_connected_export, obd_exports_barrier,
kuc_* (kernel-userspace communications).
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
From: Arnd Bergmann
More code that makes no sense on the client and that can be
removed without replacement.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_class.h | 3 -
drivers/staging/lustre/lustre/obdclass/genops.c| 115 ---
From: Arnd Bergmann
lov_stripe_md_cmp lov_lum_lsm_cmp lov_lum_swab_if_needed functions
have not been in used for a long time, so lets just remove them.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h | 62 -
1
From: Arnd Bergmann
This code is never used on the client and can simply be removed.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_net.h | 2 -
drivers/staging/lustre/lustre/include/obd.h| 1 -
drivers/staging/lustre/lustr
From: Oleg Drokin
This is only used on the servers to evict clients.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lprocfs_status.h | 2 -
.../staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c| 49 --
2 files changed, 51 deletions(-)
diff --git a/drivers/
From: Arnd Bergmann
The ll_setattr_raw() function prints the new inode timestamps
along with the current time using '%lu', which overflows in
2106. This changes the printing of the current time for
now, the other two will change when we migrate the VFS code
to use 64-bit timestamps.
Signed-off-b
From: Arnd Bergmann
The CFS_TIME_T macro serves no real purpose as we stopped using time_t
and changed over to time64_t, so we can remove the last remaining uses
of this.
Two uses of this macro are incorrect and refer to jiffies values
rather than time_t, and one refers to an inode timespec that
From: Arnd Bergmann
The exp_flvr_expire and imp_sec_expire are defined as 'unsigned long',
which doesn't overflow until 2106, but to be on the safe side, this
changes the code to use time64_t like we do everywhere else.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../staging/l
From: Oleg Drokin
It's not referenced anywhere anymore.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c
b/drivers/staging/lustre
From: Oleg Drokin
This is only used on the server to keep track of alive clients
and feeds into ping evictor (that was removed from the client code).
Also remove struct obd's obd_exports_timed and
struct obd_export's exp_obd_chain_timed used to keep track of that
Signed-off-by: Oleg Drokin
---
From: Oleg Drokin
These client request/import functions are not used anywhere,
so drop them.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_net.h | 13 ---
drivers/staging/lustre/lustre/ptlrpc/client.c | 95 --
From: Oleg Drokin
These functions are not even referenced in any header files anymore.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/obdo.c | 170 --
1 file changed, 170 deletions(-)
diff --git a/drivers/staging/lus
From: Arnd Bergmann
The wire protocol for the ping uses a 64-bit seconds/microseconds
pair, but this won't work when one side uses a 32-bit timeval
to look up the current time beyond 2038.
This changes the code to use ktime_get_real_ts64() to create
a timestamp that has the right format on all m
From: Oleg Drokin
This is a large patch to remove all dead code from obdclass and
ptlrpc, purely removing functions and declarations now, so
despite the size should be easy enough to verify.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre/lustre_id
From: Arnd Bergmann
This is a simple cleanup that I did after noticing that the abstraction
for the timer functions in completely pointless, and the one user (ptlrpc)
can just as well call the native Linux functions.
For good measure, this also removes the empty libcfs_arch_init()
and libcfs_arc
From: Arnd Bergmann
All request timestamps and deadlines in lustre are recorded in time_t
and timeval units, which overflow in 2038 on 32-bit systems.
In this patch, I'm converting them to time64_t and timespec64,
respectively. Unfortunately, this makes a relatively large patch,
but I could not
From: Arnd Bergmann
The ni_last_alive member of lnet_ni uses a 'long' to store a timestamp,
which breaks on 32-bit systems in 2038.
This changes it to use time64_t and the respective functions for it.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/include/
From: Arnd Bergmann
Here we use an unsigned long to store the timeout for gc,
which is probably safe until 2106, but this patch converts it
to use ktime_get_real_seconds() and time64_t for consistency.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/i
From: Arnd Bergmann
The lustre selftest code has multiple time stamps that are kept
as 'time_t' or 'unsigned long' and can therefore overflow on
32-bit systems.
This changes the code to use time64_t instead.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/l
From: Arnd Bergmann
ptlrpc_enc_page_pool computes time deltas using 'long' values from
get_seconds(). This is probably safe beyond y2038, but it's better
to go use monotonic times and 64-bit here for consistency.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lust
From: Arnd Bergmann
This adapts the format string and get_seconds() call to not
overflow in 2038 in the libcfs_debug_dumplog_internal()
function.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/debug.c | 4 ++--
1 file changed, 2 insertions(+),
From: Arnd Bergmann
These three are timestamps that are sent over the wire in mdc_lib
and the obd logging 64-bit values, but are generated using the 32-bit
get_seconds() function, which will eventually overflow.
Changing them to use 64-bit ktime_get_real_seconds() solves the problem.
Signed-off
From: Oleg Drokin
Quite a bunch of them are only used on the server.
lu_object_put_nocache, lu_object_invariant, lu_dev_del_linkage,
lu_context_tags_update, lu_context_tags_clear, lu_session_tags_update,
lu_session_tags_clear, lu_env_refill_by_tags, lu_printk_printer,
lu_object_assign_fid, lu_obj
From: Oleg Drokin
cl_object_header_fini, cl_object_has_locks, cl_attr2lvb,
cl_page_list_own, cl_page_list_unmap, cl_2queue_assume,
cl_io_print, cl_enqueue,
also cleanup extern declarations in cl_object.h
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre
From: Arnd Bergmann
The adaptive timeout handling stores absolute times in 32-bit time_t
quantities, which will overflow in 2038.
This changes it to use time64_t.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_import.h | 6 +++---
dri
From: Arnd Bergmann
The cfs_duration_sec() converts a relative jiffies value into seconds,
and returns that number as a time_t. We know that a 32-bit type is
enough here, because the result is order of magnitudes smaller than
the difference in jiffies that is also expressed as a 'long', so
we can
From: Arnd Bergmann
This time is only printed in debugfs, and can be easily converted
to 64-bit to avoid overflowing on 32-bit systems in 2038.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_import.h | 4 +--
.../lustre/lustre/obdclass/l
From: Arnd Bergmann
ibn_incarnation is a 64-bit value, but using timeval to compute
it will cause an overflow in 2038. This changes it to use
ktime_get_real_ts64() instead.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 7
From: Arnd Bergmann
This ioctl function passes a 64-bit time argument but then performs
a computation with a 32-bit get_seconds() value.
In order to avoid overflow here, this changes the code to use
64-bit math and ktime_get_real_seconds().
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drok
From: Arnd Bergmann
The cfs_duration_usec() function has a timeval as its output, which we
want to avoid in general because of the y2038 problem.
There are only two locations remaining in lustre, so we can for now
replace one with jiffies_to_timeval(), which is a generic kernel function
that doe
From: Arnd Bergmann
The ldlm pool calculates elapsed time by comparing the previous and
current get_seconds() values, which is unsafe on 32-bit machines
after 2038.
This changes the code to use time64_t and ktime_get_real_seconds(),
keeping the 'real' instead of 'monotonic' time because of the
d
From: Arnd Bergmann
The s2dhms computes the day/hour/minute/second values from a time_t,
which stops working in 2038. This changes the code to take a time64_t
argument, and use div_u64_rem() to implement the first division.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/s
From: Arnd Bergmann
The lnet_eq_wait_locked tries to wait for time to pass or an event to
wake up the wait queue. The entire logic seems to be a very elaborate
reimplementation of wait_event().
I'm not trying to clean up the entire logic here, but this at least
gets rid of the multi-way conversi
From: Oleg Drokin
This big set of patches started with Arnd Bergmann doing some
y2038 proofing on the Lustre code and then it was noticed that some
parts f the code are not really needed on the client so some of the
unused functionality (both time related and not) piled on.
I did some chopping o
From: Arnd Bergmann
The lustre tracefile has a timestamp defined as
__u32 ph_sec;
__u64 ph_usec;
which seems completely backwards, as the microsecond portion of
a time stamp will always fit into a __u32 value, while the second
portion will overflow in 2038 or 2106 (in case of unsi
From: Arnd Bergmann
Lustre has 64-bit timestamps in its network data structures, but
on 32 bit systems, it converts them directly into time_t, which is
32 bit wide.
This changes the code to use 64-bit time stamps for files. The Linux
VFS code still uses time_t though, and will be changed in a se
From: Arnd Bergmann
Some lustre debugfs files contain the current time. Make sure
we use a format here that does not overflow in 2038.
Signed-off-by: Arnd Bergmann
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/lproc_osc.c | 16
1 file changed, 8 insertions(
From: Arnd Bergmann
The rq_at_index member of ptlrpc_request is incorrectly declared as
time_t, when it is only used as an index into an array, and assigned
from a __u32 variable.
This changes the type to u32, so we can kill off another use of time_t.
Signed-off-by: Arnd Bergmann
Signed-off-by
From: Arnd Bergmann
We want to get rid of all uses of time_t, and it turns out
that obd.h contains a bunch of them that are completely unused.
This removes those structures, along with a couple of other
structures and functions in the same file that also turned
out to be unused.
Signed-off-by:
From: Arnd Bergmann
process_param2_config() tries to print how much time has passed
across a call_usermodehelper() function, and uses struct timeval
for that.
We want to remove this structure, so this is better expressed
in terms of ktime_t and ktime_us_delta().
Signed-off-by: Arnd Bergmann
Si
From: Arnd Bergmann
The l_last_activity struct member is used to keep track lock hold
times, and it is printed for debugging purposes. For the elapsed
time, we can use 'long' here, but it's better to use time64_t
for storing the real time to avoid an overflow in 2038.
Signed-off-by: Arnd Bergman
From: Arnd Bergmann
The recently introduced lnet_peer_set_alive() function uses
get_seconds() to read the current time into a shared variable,
but all other uses of that variable compare it to jiffies values.
This changes the current use to jiffies as well for consistency.
Signed-off-by: Arnd B
Firmware was not released properly if kmemdup fails.
Addresses-Coverity-Id: 1269118
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
b
On Sun, 27 Sep 2015, Jonathan Cameron wrote:
On 26/09/15 18:14, Lars-Peter Clausen wrote:
On 09/25/2015 07:23 PM, Shraddha Barke wrote:
Replace bit shifting on 1 with the BIT(x) macro
Signed-off-by: Shraddha Barke
Acked-by: Lars-Peter Clausen
This is a good little patch, so applied to
Firmware was not released properly if kmemdup fails.
Addresses-Coverity-Id: 1269118
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
b/dri
On Sun, Sep 27, 2015 at 01:59:17PM +0530, Pinkesh Jain wrote:
> There were many warnings and error given by checkpatch.pl and most of them
> were
> almost of the same type so i believed a single patch is enough to do the
> cleanup.
>
> 1. Remove errors of the struct declaration (foo*bar to foo *b
The message queue is replaced with standard Linux linked list. A check for
return value of receive method is added.
Signed-off-by: Chandra S Gorentla
---
drivers/staging/wilc1000/host_interface.c | 7 +++-
drivers/staging/wilc1000/wilc_msgqueue.c | 62 ++-
drivers/
On 26/09/15 18:14, Lars-Peter Clausen wrote:
> On 09/25/2015 07:23 PM, Shraddha Barke wrote:
>> Remove dev_info as the information can be obtained by other means
>>
>> Signed-off-by: Shraddha Barke
>
> Acked-by: Lars-Peter Clausen
Applied, thanks Shraddha,
Keep up the good work, these drivers h
On 26/09/15 18:14, Lars-Peter Clausen wrote:
> On 09/25/2015 07:23 PM, Shraddha Barke wrote:
>> Replace bit shifting on 1 with the BIT(x) macro
>>
>> Signed-off-by: Shraddha Barke
>
> Acked-by: Lars-Peter Clausen
>
This is a good little patch, so applied to the togreg branch
of iio.git. This w
The function twoToPowerOfx that iteratively calculates the power of 2
may be replaced with shift operator
Signed-off-by: Mike Rapoport
---
v2:
- fix changelog spelling
- break long line
drivers/staging/sm750fb/ddk750_chip.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(
Attn: This is a legal confidential text for public records search. My name is
Abdon Deguenon,a personal attorney to a deceased who may relate to you (name
withheld for security reason) who died with no Will or Next of Kin.My firm is
seeking for the next of kin.He died with his family in an auto
90 matches
Mail list logo
