Re: [PATCH] Staging: lustre: ptlrpc: Make struct static

2015-09-25 Thread Sudip Mukherjee
On Sat, Sep 26, 2015 at 12:22:34AM +0530, Shraddha Barke wrote: > Make struct static and remove definition from header file since the > struct is accessed only in this particular file > > Signed-off-by: Shraddha Barke > --- Build fails with this patch with the error: In function ‘ptlrpc_init’:

Re: [PATCH staging 3/3] wilc1000 : Use BIT() macro where possible

2015-09-25 Thread Dan Carpenter
On Fri, Sep 25, 2015 at 09:14:29AM -0700, Anish Bhatt wrote: > On Fri, Sep 25, 2015 at 3:50 AM, Dan Carpenter > wrote: > > On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote: > >> @@ -1672,11 +1673,11 @@ static int wilc_wlan_stop(void) > >> } > >> > >> } while (timeou

drivers/gpu/drm/bridge/anx78xx/slimport_tx_drv.c:610:33: sparse: symbol 'pxtal_data' was not declared. Should it be static?

2015-09-25 Thread kbuild test robot
Hi Enric, FYI, build test results on v4.3-rc2 (pls ignore if it's inappropriate base for your patch). reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/gpu/drm/bridge/anx78xx/slimport_tx

[PATCH linux-review] drm: bridge: anx78xx: pxtal_data[] can be static

2015-09-25 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- slimport_tx_drv.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/anx78xx/slimport_tx_drv.c b/drivers/gpu/drm/bridge/anx78xx/slimport_tx_drv.c index 7721326..9afebab 100644 --- a/drivers/gpu/drm/bridge/anx78xx/s

[PATCHv4 3/3] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2015-09-25 Thread Enric Balletbo i Serra
At the moment it only supports ANX7814. The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. This driver adds initial support and supports HDMI to DP pass-through mode. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/Kconfig

[PATCHv4 2/3] devicetree: Add new ANX7814 SlimPort transmitter binding.

2015-09-25 Thread Enric Balletbo i Serra
The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. You can add support to your board with current binding. Example: anx7814: anx7814@38 { compatible = "analogix,anx7814"; reg = <0x38>; pd

[PATCHv4 1/3] of: Add vendor prefix for Analogix Semiconductor, Inc.

2015-09-25 Thread Enric Balletbo i Serra
Analogix Semiconductor develops analog and mixed-signal devices for digital media and communications interconnect applications. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCHv4 0/3] Add initial support for slimport anx78xx

2015-09-25 Thread Enric Balletbo i Serra
Hi all, This is the fouth version with fixes suggested by Nicolas Boichat and Dan Carpenter. See the changelog below for details. The following series add initial support for the Slimport ANX7814 transmitter, a ultra-low power Full-HD (1080p60) transmitter designed for portable device. The dri

[PATCH] Staging: lustre: ptlrpc: Make struct static

2015-09-25 Thread Shraddha Barke
Make struct static and remove definition from header file since the struct is accessed only in this particular file Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 2 +- drivers/staging/lustre/lustre/ptlrpc/service.c | 2 +- 2 files changed, 2 i

[PATCH 2/2] Staging: iio: cdc: Remove unnecessary dev_info

2015-09-25 Thread Shraddha Barke
Remove dev_info as the information can be obtained by other means Signed-off-by: Shraddha Barke --- drivers/staging/iio/cdc/ad7746.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index 55cc8bb..ca7d33f 100644 --- a/driver

[PATCH 1/2] Staging: iio: cdc: Prefer using the BIT macro

2015-09-25 Thread Shraddha Barke
Replace bit shifting on 1 with the BIT(x) macro Signed-off-by: Shraddha Barke --- drivers/staging/iio/cdc/ad7746.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index 10fa372..55cc8bb 100644 --

[PATCH 0/2] Staging: iio: cdc: Use BIT macro and remove dev_info

2015-09-25 Thread Shraddha Barke
These patches use the BIT macro and remove dev_info Shraddha Barke (2): Staging: iio: cdc: Prefer using the BIT macro Staging: iio: cdc: Remove unnecessary dev_info drivers/staging/iio/cdc/ad7746.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) -- 2.1.4 _

Re: [Y2038] [lustre-devel] [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-25 Thread Arnd Bergmann
On Friday 25 September 2015 16:53:14 Drokin, Oleg wrote: > > On Sep 25, 2015, at 12:09 PM, Arnd Bergmann wrote: > > > > I have updated the branch now to reflect our discussions so far. Can you > > handle > > forwarding the patches to Greg from there, or complain if there are still > > problems w

[PATCH] Staging: rtl8188eu: os_dep: Stop using DBG_88E

2015-09-25 Thread Shraddha Barke
Stop using DBG_88E which is a custom macro for printing debugging messages. Instead start using pr_debug and in the process define pr_fmt. Signed-off-by: Shraddha Barke --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 31 +++-- 1 file changed, 16 insertions(+), 15 deleti

Re: [lustre-devel] [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-25 Thread Drokin, Oleg
On Sep 25, 2015, at 12:09 PM, Arnd Bergmann wrote: > On Friday 25 September 2015 01:39:49 Drokin, Oleg wrote: >> On Sep 24, 2015, at 9:07 PM, Drokin, Oleg wrote: >> >>> >>> On Sep 24, 2015, at 4:15 PM, Arnd Bergmann wrote: >>> Anyway this does remove a lot of stuff that we don't really need

[PATCH] staging: fsl-mc: Fixed uintX_t CHECK checkpatch warnings

2015-09-25 Thread J. German Rivera
Replaced all uses of uintX_t types to uX types, to be checkpatch clean. Signed-off-by: J. German Rivera --- This patch depends on the patch posted at http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg981518.html drivers/staging/fsl-mc/bus/dpbp.c | 112 +++ driver

Re: [PATCH staging 3/3] wilc1000 : Use BIT() macro where possible

2015-09-25 Thread Anish Bhatt
On Fri, Sep 25, 2015 at 3:50 AM, Dan Carpenter wrote: > On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote: >> @@ -1672,11 +1673,11 @@ static int wilc_wlan_stop(void) >> } >> >> } while (timeout); >> - reg = ((1 << 0) | (1 << 1) | (1 << 2) | (1 << 3) | (1 << 8) | >

Re: [lustre-devel] [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-25 Thread Arnd Bergmann
On Friday 25 September 2015 01:39:49 Drokin, Oleg wrote: > On Sep 24, 2015, at 9:07 PM, Drokin, Oleg wrote: > > > > > On Sep 24, 2015, at 4:15 PM, Arnd Bergmann wrote: > > Anyway this does remove a lot of stuff that we don't really need in the > > client, > > I'll try to get it built

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-09-25 Thread Sudip Mukherjee
On Thu, Sep 24, 2015 at 02:58:31PM +0300, Tomi Valkeinen wrote: > > On 02/09/15 15:48, Sudip Mukherjee wrote: > > > Is there a public datasheet for the HW? I could not find one in Silicon Motion website. I will try to find else I can talk to them and keep it in my github. And can send you also

Re: [PATCH staging 3/3] wilc1000 : Use BIT() macro where possible

2015-09-25 Thread Dan Carpenter
On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote: > @@ -1672,11 +1673,11 @@ static int wilc_wlan_stop(void) > } > > } while (timeout); > - reg = ((1 << 0) | (1 << 1) | (1 << 2) | (1 << 3) | (1 << 8) | > -(1 << 9) | (1 << 26) | (1 << 29) | (1 << 30) |

Re: [Y2038] [PATCH 04/37] staging/lustre: tracefile: use 64-bit seconds

2015-09-25 Thread Arnd Bergmann
On Friday 25 September 2015 12:17:18 Arnd Bergmann wrote: > On Friday 25 September 2015 01:52:37 Drokin, Oleg wrote: > > On Sep 24, 2015, at 3:46 AM, Arnd Bergmann wrote: > > > On Thursday 24 September 2015 04:02:09 Drokin, Oleg wrote: > > These are all the users. > > Seems to be pretty much u32 (o

Re: [PATCH V4] staging: dgnc: take lock when storing value in dgnc_poll_tick

2015-09-25 Thread Dan Carpenter
On Fri, Sep 25, 2015 at 08:25:32AM +0100, Salah Triki wrote: > dgnc_driver_pollrate_store needs to take a lock before modifying the > shared variable dgnc_poll_tick. > Nope. This patch is useless. Patch v3 was correct, you just need to fix the changelog. Reads of dgnc_poll_tick are protected b

Re: [PATCH 04/37] staging/lustre: tracefile: use 64-bit seconds

2015-09-25 Thread Arnd Bergmann
On Friday 25 September 2015 01:52:37 Drokin, Oleg wrote: > On Sep 24, 2015, at 3:46 AM, Arnd Bergmann wrote: > > On Thursday 24 September 2015 04:02:09 Drokin, Oleg wrote: > These are all the users. > Seems to be pretty much u32 (or unsigned int when printing) everywhere. Ok, I'll the patch then t

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-25 Thread Dan Carpenter
On Thu, Sep 24, 2015 at 03:47:26PM -0500, atull wrote: > Interesting. The amount of code bloat here compiles down to about two > machine instructions (in two places). Actually a little more since I should > be using IS_ERR_OR_NULL. But the main question is whether I should do > it at all. > Th

Re: [lustre-devel] [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-25 Thread Arnd Bergmann
On Friday 25 September 2015 01:07:43 Drokin, Oleg wrote: > > These do seem to be working fine in my testing. > > I also noticed we can remove some more stuff in at least fid/ dir so > I created some patches on top of your tree: > https://github.com/verygreen/linux/tree/fidcleanup > > Also I've l

Re: [PATCH v2 00/12] staging: comedi: rtd520: tidy up driver

2015-09-25 Thread Ian Abbott
On 25/09/15 01:52, H Hartley Sweeten wrote: Tidy up this driver and fix all the checkpatch.pl issues. v2: fix patch 08/12 based on comments from Ian Abbott add patch 12/12 to hook up the 8254 timer/counter H Hartley Sweeten (12): staging: comedi: rtd520: prefer using the BIT macro st

[PATCH staging 2/3] wilc1000 : Remove leftover comment delimiters

2015-09-25 Thread Anish Bhatt
Remove leftover comment delimiters that were only partially removed in a previous cleanup. Fixes : c3ca63728ad8 ("staging: wilc1000: remove useless comment") Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/wilc_wlan.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH staging 0/3] wilc1000 code cleanups

2015-09-25 Thread Anish Bhatt
Patchset removes extraneous macro defines and cleans some code as recommended by checkpatch.pl Anish Bhatt (3): wilc1000 : Remove unused macro definitions wilc1000 : Remove leftover comment delimiters wilc1000 : Use BIT() macro where possible drivers/staging/wilc1000/host_interface.c |

[PATCH staging 3/3] wilc1000 : Use BIT() macro where possible

2015-09-25 Thread Anish Bhatt
Replace (1 << x) by BIT(x) as recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/host_interface.c | 4 +- drivers/staging/wilc1000/host_interface.h | 38 +++ drivers/staging/wilc1000/linux_wlan_common.h | 8 ++-- drivers/staging/wilc1000/w

[PATCH staging 1/3] wilc1000 : Remove unused macro definitions

2015-09-25 Thread Anish Bhatt
Remove all unused TCP_*_MASK macro definitions Signed-off-by: Anish Bhatt --- drivers/staging/wilc1000/wilc_wlan.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index 0a930ec..bf7e900 100644 --- a/drivers/stagin

[PATCH V4] staging: dgnc: take lock when storing value in dgnc_poll_tick

2015-09-25 Thread Salah Triki
dgnc_driver_pollrate_store needs to take a lock before modifying the shared variable dgnc_poll_tick. Signed-off-by: Salah Triki --- drivers/staging/dgnc/dgnc_sysfs.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/stag