On Wed, Sep 23, 2015 at 03:28:07AM +0100, Salah Triki wrote:
> dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store needs to
> take the
> lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the
> appropriate lock, since it is intended for poll scheduling and dgnc_poll
On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote:
> This patch is to rtl8712_gp_bitdef.h file that fixes up following
> warning reported by checkpatch :
>
> -Block comments use a trailing */ on a separate line
>
> Signed-off-by: Punit Vara
> ---
I am getting confused. One of your previ
On Tue, Sep 22, 2015 at 12:01:18PM +0300, Mike Rapoport wrote:
> The MB(x) and KB(x) macros are not used and therefore they can be
> removed
>
> Signed-off-by: Mike Rapoport
> ---
ohh.. discard my earlier mail. I have not seen that you have done that
in this patch. Sorry for the noise.
regards
s
On Tue, Sep 22, 2015 at 12:01:17PM +0300, Mike Rapoport wrote:
> Use SZ_xM defined in linux/sizes.h instead of custom MB(x) macro
>
> Signed-off-by: Mike Rapoport
> ---
If you are removing the use of MB(x) please also remove the
#define MB(x) ((x)<<20)
regards
sudip
_
On Tue, Sep 22, 2015 at 06:08:56PM -0500, J. German Rivera wrote:
> Add cmd_flags parameter to all dpbp APIs to comply
> with the dpbp 2.0 MC interface. Updated MC version
> major number. Pass irq args in struct instead of
> separate args.
>
> Signed-off-by: J. German Rivera
> ---
> drivers/stag
dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store needs to take
the
lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the
appropriate lock, since it is intended for poll scheduling and dgnc_poll_tick
contains the poll rate. dgnc_poll_lock needs to be declare not
The global variable dgnc_poll_tick is read in the function dgnc_poll_handler
and modified in dgnc_driver_pollrate_store. The read access is protected by
spin_lock_irqsave whereas the write is not. The protection of write access
is needed, since it is possible to have multiple programs that try
On Tue, Sep 22, 2015 at 8:21 AM, wrote:
> From: Alan Tull
>
> Add documentation under drivers/staging for new fpga manager's
> sysfs interface.
>
Reviewed-by: Moritz Fischer
> Signed-off-by: Alan Tull
> ---
> v5 : (actually second version, but keeping version numbers
> aligned with rest
Hi Alan,
On Tue, Sep 22, 2015 at 8:21 AM, wrote:
> From: Alan Tull
>
> Add a document on the new FPGA manager core.
>
Reviewed-by: Moritz Fischer
> Signed-off-by: Alan Tull
> ---
> v9: initial version where this patch was added
>
> v10: requested cleanups to formatting and otherwise
>
On Tue, Sep 22, 2015 at 10:21:10AM -0500, at...@opensource.altera.com wrote:
> From: Alan Tull
>
> API to support programming FPGA's.
>
> The following functions are exported as GPL:
> * fpga_mgr_buf_load
>Load fpga from image in buffer
>
> * fpga_mgr_firmware_load
>Request firmware and
Add cmd_flags parameter to all dprc APIs to comply
with the dprc 4.0 MC interface. Updated MC version
major number. Pass irq args in struct instead of
separate args.
dprc 4.0 uses MC-relative offsets to specify object regions,
instead of physical addresses. So, translate_mc_addr() and
struct fsl_
Add cmd_flags parameter to all dpbp APIs to comply
with the dpbp 2.0 MC interface. Updated MC version
major number. Pass irq args in struct instead of
separate args.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dpbp.c | 136 --
drivers/stagin
Add cmd_flags parameter to all dpbp APIs to comply
with the dpmcp 2.0 MC interface. Updated version
major number. Pass irq args in struct instead of
separate args.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dpmcp-cmd.h| 2 +-
drivers/staging/fsl-mc/bus/dpmcp.c|
Add cmd_flags parameter to all dpmng APIs to comply
with 8.0 MC firmware interface. Updated MC version
major number.
---
drivers/staging/fsl-mc/bus/dpmng.c | 14 ++
drivers/staging/fsl-mc/bus/mc-bus.c| 4 ++--
drivers/staging/fsl-mc/include/dpmng.h | 14 ++
3 files
The Management Complex (MC) binary interface added a new "flags"
field to the command header.
Add the definitions for this field in preparation for adding the
new cmd_flags parameter to all MC interface APIs.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/include/mc-cmd.h | 30 ++
The DPAA2 management complex has a versioned binary interface
that has to be kept in sync with the DPAA2 drivers. This patch
series uprevs the APIs that build MC commands and parse results.
This uprev is needed to support object interrupts.
MC binary interface changes
-overall version from 6.0
dpcon object minor version number updated to match latest
MC firmware. This change is needed because the dpcon
object binds to the allocator and the current driver match
logic uses object version numbers.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/include/dpcon-cmd.h | 2 +-
1 fi
On Tue, Sep 22, 2015 at 10:21:11AM -0500, at...@opensource.altera.com wrote:
> From: Alan Tull
>
> Add driver to fpga manager framework to allow configuration
> of FPGA in Altera SoCFPGA parts.
>
> Signed-off-by: Alan Tull
> Acked-by: Michal Simek
> Acked-by: Moritz Fischer
[..]
> +++ b/drive
Declare non-exported functions in pack_generic.c as static.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
b/drivers/staging/lu
Include the header with declaations of variables that are shared between
several sources in ptlrpc module into the appropriate source files.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 ++
drivers/staging/lustre/lustre/ptlrpc/wiretest.c | 2 ++
2 files
This patch adds declarations for variables used in several files
across the ptlrpc module to the local header.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/
This series of patches eliminates some sparse warnings concerning
static variables in lustre rtlrpc module where it seemed reasonable.
Symbols that are really local to a source file are made static and
declarations added to a header for symbols that are shared between
source files.
Anton Gerasimov
On Tue, Sep 22, 2015 at 06:27:50PM +0200, Vitaly Kuznetsov wrote:
> Storvsc driver needs to ensure there are no 'holes' in the presented
> sg list (all segments in the middle of the list need to be of PAGE_SIZE).
I think it should instead set a virt_boundary. That's what we added for
the NVMe dri
The 'pbuf' and 'source' arguments to rtw_set_fixed_ie() are (void *), the
explicit typecasts are not needed. They just make code less readable.
Also fix checkpatch issues in the lines touched:
ERROR: space prohibited before that ',' (ctx:WxW)
WARNING: line over 80 characters
CHECK: Unnecessa
pmlmeinfo->ADDBA_req is accessed three times in this function, but it
contributes to generating lines above 80 characters that are not easy to
split in a nice way.
Extract a pointer to it to make code slightly more concise and fix some
lines over 80 characters.
Signed-off-by: Luca Ceresoli
Cc: L
rtw_set_ie() is a memcpy-like function, taking addresses of memory buffers
among its parameters. Similarly to memcpy, change the parameters to be
void*. This will allow to get rid of typecasts whenever it is called.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drive
This comment gives pretty much the same information as the name of the
function that it immediately precedes.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/stagin
This patch is to the rtl8712_rercv.c that fixes up typo error in word
"calculated"
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl8712_recv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_recv.c
b/drivers/staging/rtl8712/rtl8712_re
Declare non-exported functions in pack_generic.c as static.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
b/drivers/staging/lu
Include the header with declaations of variables that are shared between
several sources in ptlrpc module into the appropriate source files.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 ++
drivers/staging/lustre/lustre/ptlrpc/wiretest.c | 2 ++
2 files
This patch adds declarations for variables used in several files
across the ptlrpc module to the local header.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/
This series of patches eliminates some sparse warnings concerning
static variables in lustre rtlrpc module where it seemed reasonable.
Symbols that are really local to a source file are made static and
declarations added to a header for symbols that are shared between
source files.
Anton Gerasimov
On 09/22/2015 02:24 AM, Lars Svensson wrote:
Fixing Sparse warnings about intentional type casts in rtw_security.c
as below.
CHECK drivers/staging/rtl8723au/core/rtw_security.c
drivers/staging/rtl8723au/core/rtw_security.c:248:22: \
warning: cast to restricted __le32
drivers/staging/rtl8723
This patch is to the rtl8712_recv.c file that fixes up following warning
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl8712_recv.c | 111 ++---
1 file changed, 74 insertions(+
This is patch to the rtl8712_led.c that fixes up following
warnings reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl8712_led.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git
This is the patch to rtl8712_cmdctrl_bitdef.h file that fixes up
following warning reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
This is the patch to rtl8712_hal.h file that fixes up following warning
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl8712_hal.h | 24
1 file changed, 16 insertions(+), 8 deletio
This patch is to rtl8712_gp_bitdef.h file that fixes up following
warning reported by checkpatch :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl8712_gp_bitdef.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --g
This is the patch to recv_linux.c file that fixes up following warning
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
This patch is to the rtl8712_cmd.c file that fixes up warnings
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl8712_cmd.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
di
This is the patch to recv_linux.c file that fixes up following warning
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/recv_linux.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/dr
This patch is to the os_intfs.c that fixes up warning
reported by checkpatch.pl :
-Block commens use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/os_intfs.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl871
On Thu, Sep 10, 2015 at 06:35:52PM +0200, Enric Balletbo i Serra wrote:
> diff --git a/drivers/gpu/drm/bridge/anx78xx/anx78xx.h
> b/drivers/gpu/drm/bridge/anx78xx/anx78xx.h
> new file mode 100644
> index 000..4f6dd1d
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/anx78xx/anx78xx.h
> @@ -0,0 +1
This patch is to the ieee80211.h that fixes up following
warnings reported by checkpatch.pl :
-Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/ieee80211.h | 59 +--
This patch is to the ieee80211.c that fixes up following
warnings reported by checkpatch.pl :
-Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/ieee80211.c | 7 ---
1 file changed, 4 insertions
This patch is to the drv_types.h that fixes up following warnings
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/drv_types.h | 11 ++-
1 file changed, 6 ins
This patch is to the hal_init.c that fixes up following warning
reported by checkpatch.pl :
-Block comments use * subsequent lines
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/hal_init.c | 24
1 file changed,
This patch is to the drv_types.h that fixes up following warnings
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/drv_types.h | 11 ++-
1 file changed, 6 ins
On Thu, Sep 10, 2015 at 05:24:59PM +0530, Sudip Mukherjee wrote:
> Removed them but kept one call to ioread8() as it might affect the
> hardware.
Just leave the extra variable until someone has the hardware and can
verify the right fix. Static checker warnings are good, don't silence
them just to
On Sun, Sep 13, 2015 at 05:23:27PM +0200, Julian Andres Klode wrote:
> My device broke a long time ago, so I do not have any
> chance of testing things or any reason to continue
> maintaining it.
>
> Signed-off-by: Julian Andres Klode
> Cc: Marc Dietrich
> ---
> MAINTAINERS | 1 -
> 1 file chan
On Tuesday, September 22, 2015 10:03 AM, Ian Abbott wrote:
> 1) staging: comedi: comedi_buf.c: tweak existing kernel-doc
> 2) staging: comedi: comedi_buf.c: document remaining exported functions
>
> drivers/staging/comedi/comedi_buf.c | 106
> ++--
> 1 file changed
On Monday, September 21, 2015 10:53 AM, Ian Abbott wrote:
> This series fixes an incorrectly formatted block comment, adds more
> kernel-doc documenation and tweaks the existing documentation for
> consistency and to document return values of inline functions.
>
> 01) staging: comedi: comedidev.h:
Add kernel-doc headers to the remaining functions marked for export.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_buf.c | 69 ++---
1 file changed, 65 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/comedi_buf.c
b/drivers/staging
1) staging: comedi: comedi_buf.c: tweak existing kernel-doc
2) staging: comedi: comedi_buf.c: document remaining exported functions
drivers/staging/comedi/comedi_buf.c | 106 ++--
1 file changed, 88 insertions(+), 18 deletions(-)
___
Expand the kernel-doc descriptions of those exported functions that
already have kernel-doc comments.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_buf.c | 37 +++--
1 file changed, 23 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/come
Storvsc driver needs to ensure there are no 'holes' in the presented
sg list (all segments in the middle of the list need to be of PAGE_SIZE).
When a hole is detected storvsc driver creates a 'bounce sgl' without
holes and copies data over with its own copy_{to,from}_bounce_buffer()
functions. Scsi
From: Alan Tull
Add documentation under drivers/staging for new fpga manager's
sysfs interface.
Signed-off-by: Alan Tull
---
v5 : (actually second version, but keeping version numbers
aligned with rest of patch series)
Move document to drivers/staging/fpga/Documentation/ABI
v6 :
From: Alan Tull
Add driver to fpga manager framework to allow configuration
of FPGA in Altera SoCFPGA parts.
Signed-off-by: Alan Tull
Acked-by: Michal Simek
Acked-by: Moritz Fischer
---
v2: fpga_manager struct now contains struct device
fpga_manager_register parameters now take device
v3
From: Alan Tull
Add a document on the new FPGA manager core.
Signed-off-by: Alan Tull
---
v9: initial version where this patch was added
v10: requested cleanups to formatting and otherwise
s/fpga/FPGA/g
rewrite implementation section to not reference socfpga.c by name
other rew
From: Alan Tull
This patch set adds the FPGA manager core which exports API functions that
write an image to a FPGA
I'm holding off on the DT overlay support a little for now.
The core's API is minimal to start with: only 6 functions. This gives a
manufacturer-agnostic interface for programmin
From: Alan Tull
API to support programming FPGA's.
The following functions are exported as GPL:
* fpga_mgr_buf_load
Load fpga from image in buffer
* fpga_mgr_firmware_load
Request firmware and load it to the FPGA.
* fpga_mgr_register
* fpga_mgr_unregister
FPGA device drivers can be ad
The IEEE80211_STYPE_PROBE_REQ flag appears twice in the expression
and coccicheck complains with:
wilc_wfi_cfgoperations.h:80:3-38: duplicated argument to & or |
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 1 -
1 file changed, 1 deletion(-)
On Tue, Sep 22, 2015 at 11:48:05AM +0100, Salah Triki wrote:
> >On Wed, 2 Sep 2015 18:15:29 -0700, Greg KH wrote:
> >>On Tue, Aug 25, 2015 at 08:09:47PM +0100, Salah Triki wrote:
> >> poll_tick is declared global, so dgnc_driver_pollrate_store needs to
> >> take
> >> the lock dgnc_poll_lock before
Fixing Sparse warnings about intentional type casts in rtw_security.c
as below.
CHECK drivers/staging/rtl8723au/core/rtw_security.c
drivers/staging/rtl8723au/core/rtw_security.c:248:22: \
warning: cast to restricted __le32
drivers/staging/rtl8723au/core/rtw_security.c:249:24: \
warning: cast t
Recent changes in Hyper-V driver ("Drivers: hv: vmbus: add special crash
handler") broke the build when CONFIG_KEXEC_CORE is not set:
arch/x86/built-in.o: In function `hv_machine_crash_shutdown':
arch/x86/kernel/cpu/mshyperv.c:112: undefined reference to
`native_machine_crash_shutdown'
Decorate
This patch replaces ParseNetworkInfo with parse_network_info to avoid
camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_interface.c | 2 +-
3 files changed, 3 insertio
This patch replaces kmalloc with kzalloc because it is initialized by 0
immediately after allcating memory.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigu
s32Error is defined, but not used anywhere in this function.
Then just delete it and return 0 at the end of this function.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/co
This patch removes CoreConfiguratorDeInit function, which is not doing
anything else except printing a PRINT_D message and returning a
s32Error. It is also removed the codes that is calling this function.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 20 --
This patch replaces SendConfigPkt with send_config_pkt to aovid
camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 4 +-
drivers/staging/wilc1000/coreconfigurator.h | 4 +-
drivers/staging/wilc1000/host_interface.c | 204 ++--
3
This patch replaces kmalloc followed by memset and memcpy with kmemdup.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/wilc
This patch replaces kmalloc_array followed by memset with kcalloc.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/wilc1000/corecon
This patch removes useless comment in coreconfigurator.c
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 38 -
drivers/staging/wilc1000/coreconfigurator.h | 29 ++
2 files changed, 8 insertions(+), 59 deletions(-)
dif
This patch removes extern declaration of *gpstrWlanOps in
coreconfigurator.c file. It is defined extern declaration in
wilc_wlan_if.h file and then is included in coreconfigurator.c file.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
drivers/staging/wilc1000
The wilc_wlan_cleanup() function iterates over the list of transmission
buffers freeing all of them and then iterates over the receive buffers
list to free all of them as well.
But on the receive loop a pointer to struct txq_entry_t is dereferenced
instead of the pointer to a struct rxq_entry_t. T
On Sat, Sep 05, 2015 at 09:21:58PM +0200, Anders Fridlund wrote:
> I resent it since no one responded to it for 10 days. From what I came
> to understand that is the common practice. If that is not the case I'm
> sorry (and please let me know so I don't do it again).
>
10 days is too short. Espe
Hello Sudip,
Thanks a lot for your feedback.
On 09/22/2015 02:16 PM, Sudip Mukherjee wrote:
> On Tue, Sep 22, 2015 at 12:24:50PM +0200, Javier Martinez Canillas wrote:
>> The wilc_wlan_cleanup() function iterates over the list of transmission
>> buffers freeing all of them and then iterates over
On Tue, Sep 01, 2015 at 12:46:43AM +0200, Luca Ceresoli wrote:
> But I don't see what added value this brings to the commit title.
> I really would like to understand why this is a good practice. Can you
> point me to an explanation (links are welcome)?
One thing is that when you look at online em
On Tue, Sep 22, 2015 at 12:55:02PM +0100, Salah Triki wrote:
> On Mon, Sep 21, 2015 at 07:17:08PM +0300, Dan Carpenter wrote:
> > On Sun, Sep 06, 2015 at 08:00:10PM -0700, Greg KH wrote:
> > > On Sat, Sep 05, 2015 at 01:12:01PM +0100, Salah Triki wrote:
> So please ignore this patch and consider i
On Tue, Sep 22, 2015 at 12:24:50PM +0200, Javier Martinez Canillas wrote:
> The wilc_wlan_cleanup() function iterates over the list of transmission
> buffers freeing all of them and then iterates over the receive buffers
> list to free all of them as well.
>
> But on the receive loop a pointer to
On Mon, Sep 21, 2015 at 07:17:08PM +0300, Dan Carpenter wrote:
> On Sun, Sep 06, 2015 at 08:00:10PM -0700, Greg KH wrote:
> > On Sat, Sep 05, 2015 at 01:12:01PM +0100, Salah Triki wrote:
> > > poll_tick is declared global, so dgnc_driver_pollrate_* need to
> > > take the lock dgnc_poll_lock before
>On Sun, 6 Sep 2015 20:00:10 -0700, Greg KH wrote:
>>On Sat, Sep 05, 2015 at 01:12:01PM +0100, Salah Triki wrote:
>> poll_tick is declared global, so dgnc_driver_pollrate_* need to
>> take the lock dgnc_poll_lock before accessing to this variable.
>
>Really? The scope of a variable doesn't matter
>On Wed, 2 Sep 2015 18:15:29 -0700, Greg KH wrote:
>>On Tue, Aug 25, 2015 at 08:09:47PM +0100, Salah Triki wrote:
>> poll_tick is declared global, so dgnc_driver_pollrate_store needs to
>> take
>> the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock
>> the
>> appropriate lock, sin
The wilc_wlan_cleanup() function iterates over the list of transmission
buffers freeing all of them and then iterates over the receive buffers
list to free all of them as well.
But on the receive loop a pointer to struct txq_entry_t is dereferenced
instead of the pointer to a struct rxq_entry_t. T
On Tue, Sep 22, 2015 at 10:25:09AM +0100, Salah Triki wrote:
> I'm sorry for wasting your time.
>
The patch was correct. Just respond to reply to review comments so that
people can follow what's going on.
regards,
dan carpenter
___
devel mailing list
On 09/22/2015 11:13 AM, Andrzej Hajda wrote:
On 09/21/2015 03:42 PM, David Howells wrote:
Andrzej Hajda wrote:
Semantic patch finds comparisons of types:
unsigned < 0
unsigned >= 0
The former is always false, the latter is always true.
Such comparisons are useless, so theoretically
This patch removes blank line before a close brace.
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc100
This patch removes multiple blank lines in host_int_init function.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/host_interface.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/
This patch removes unnecessary parentheses found by checkpatch.pl
Unnecessary parentheses around pstrWFIDrv->hSemTestKeyBlock
Unnecessary parentheses around pstrWFIDrv->hSemTestDisconnectBlock
Unnecessary parentheses around pstrWFIDrv->hSemGetRSSI
Unnecessary parentheses around pstrWFIDrv->hSemGet
This patch makes add_virtual_intf static. This function is used only at
wilc_wfi_cfgoperation.c file.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
This patch removes commented code in host_int_init function.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_
This patch replaces s32Error with result in host_int_init function to
avoid camelcase.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/host_interface.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging
This patch replaces kmalloc with kzalloc in host_int_init.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/stagi
This patch fixes error check when kzalloc is failed.
NULL comparison style is changed to use ! operator and
PRINT_ER is also removed.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(
This patch removes useless comment.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/d
This patch makes del_virtual_intf static. This function is used only at
wilc_wfi_cfgoperation.c file.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
This patch removes CoreConfiguratorInit function, which is not doing
anything else except printing a PRINT_D message and returing a s32Error.
It is also removed the code that is calling this function.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing and remove declaration of func
This patch makes mgmt_tx static. This function is used only at
wilc_wfi_cfgoperation.c file.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/st
This patch replaces WILC_WFI_set_cqm_rssi_config with
set_cqm_rssi_config to avoid CamelCase.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s
This patch removes meaningless comment in host_int_init function.
Signed-off-by: Chaehyun Lim
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wil
1 - 100 of 110 matches
Mail list logo
