ALLIANCE & LEICESTER LOANS
Do you need a loan? Arrangements to borrow up to £ 100,000,000.00, choose
between 1 to 25 years repayment period, choose between monthly and annual
repayment plan, flexible loan terms and conditions. All this plan and more by
contacting us
Dr. Richard Jose
Head of Fi
On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote:
> On 09/16/2015 02:22 AM, Dan Carpenter wrote:
> > __get_txreq() returns an ERR_PTR() but this checks for NULL so it would
> > oops on failure.
> >
> > Signed-off-by: Dan Carpenter
>
> Thanks, applied.
Applied to what? Should I just
On Thu, Sep 17, 2015 at 09:44:41PM +0530, Anjali Menon wrote:
> Removed the else statement along with some unwanted brackets
> to fix the following coding style warning detected by
> checkpatch.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Anjali Menon
> -
On Fri, Sep 18, 2015 at 06:11:05PM +0900, Tony Cho wrote:
> This patch changes the name, strHostIFmsg simply to msg because the
> camelcase notation is not recommended in Linux.
>
> Signed-off-by: Tony Cho
Because of the other patches I didn't accept, and I think because of
patches that communit
On Fri, Sep 18, 2015 at 01:41:07PM -0600, BryanSPaul wrote:
> fix Block comments use * on subsequent lines
That sentance makes no sense :(
> Signed-off-by: Bryan Paul
This name doesn't match the From: line :(
thanks,
greg k-h
___
devel mailing list
On Fri, Sep 18, 2015 at 10:22:59PM +0530, Punit Vara wrote:
> This patch is to comedidev.h file that fixes up following warnings
> reported by checkpatch.pl :
>
> -Block comments use a trailing */ on a separate line
> -Block comments use * on subsequent lines
Your subject needs to be very specifi
On Thu, Sep 17, 2015 at 07:02:18PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes the warnings reported by checkpatch.pl
> for using multiple blank lines.
>
> Signed-off-by: Leo Kim
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/wilc_wlan_if.h | 12
> 1
On Thu, Sep 17, 2015 at 07:02:17PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes the potential faults which may happen when unexpectedly
> getting access to invalid pointer. The pointer of pstrWFIDrv is unlikely
> to be invalid. However, it is safer to return error when the invali
On Fri, Sep 18, 2015 at 09:55:23PM +0530, Punit Vara wrote:
> This patch is to comedi_pcmcia.h that fixes up warning related
> character limitation given by checkpatch.pl.
> Warning " line over 80 characters" is removed now.
Nope, you just broke kerneldoc formatting :(
Sorry, it's tricky, and ker
On Thu, Sep 17, 2015 at 09:03:14PM +0900, Chaehyun Lim wrote:
> On Thu, Sep 17, 2015 at 7:34 PM, Sudip Mukherjee
> wrote:
> > On Thu, Sep 17, 2015 at 04:48:44PM +0900, Chaehyun Lim wrote:
> >> This patch replaces int8_t with int. just use return type as int.
> >>
> >> Signed-off-by: Chaehyun Lim
On Fri, Sep 18, 2015 at 06:18:13PM +0530, Anjali Menon wrote:
> Removed a space to fix the following coding style error detected
> by checkpatch.pl
>
> ERROR: space prohibited before that '++' (ctx:WxO)
>
> Signed-off-by: Anjali Menon
> ---
> drivers/staging/lustre/lustre/obdclass/llog.c | 2 +-
On Fri, Sep 18, 2015 at 05:56:19PM +0530, Punit Vara wrote:
> This patch is to the comedi.h file that fixes up following type
> of 42 warning in the file:
>
> -Blocking comments use a trailing */ on a separate line
> -Block comments use * on subsequent lines
Why
On Fri, Sep 18, 2015 at 02:24:16PM +0530, Punit Vara wrote:
> This patch is to the Kconfig file which fixes up lines which
> exceeded the standard 80 character limitation.
> This file also fixes up 3 warnings regarding paragraph.
Why is this indented?
>
> Signed-off-by: Punit
On 09/18/2015 03:19 PM, BryanSPaul wrote:
replaced memcpy functions with ether_addr_copy
Signed-off-by: Bryan Paul
You seem not to be aware that ether_addr_copy() requires alignment of the
operands. Until you demonstrate that you have investigated such alignment,
NACK
Larry
---
drive
This patch is to comedidev.h file that fixes up following warnings
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/comedi/comedidev.h | 62 ---
This patch is to comedi_pcmcia.h that fixes up warning related
character limitation given by checkpatch.pl.
Warning " line over 80 characters" is removed now.
Signed-off-by: Punit Vara
---
drivers/staging/comedi/comedi_pcmcia.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On Fri, Sep 18, 2015 at 5:46 AM, Martyn Welch wrote:
>
>
> On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote:
>>
>> From: Dmitry Kalinkin
>>
>> The current VME bus error handler adds errors to the bridge error list.
>> vme_master_{read,write} then traverses that list to look for relevant
>> erro
On 09/16/2015 02:42 AM, Dan Carpenter wrote:
> The cinfo struct has a hole after the last struct member so we need to
> zero it out. Otherwise we disclose some uninitialized stack data.
>
> Signed-off-by: Dan Carpenter
Thanks, applied.
--
Doug Ledford
GPG KeyID: 0E572FDD
s
On 09/16/2015 02:22 AM, Dan Carpenter wrote:
> mutex_trylock() returns zero on failure, not EBUSY.
>
> Signed-off-by: Dan Carpenter
Thanks, applied.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
On 09/16/2015 02:22 AM, Dan Carpenter wrote:
> __get_txreq() returns an ERR_PTR() but this checks for NULL so it would
> oops on failure.
>
> Signed-off-by: Dan Carpenter
Thanks, applied.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signatu
On 09/15/2015 06:35 AM, Dan Carpenter wrote:
> copy_to/from_user() returns the number of bytes which we were not able
> to copy. It doesn't return an error code.
>
> Also a couple places had a printk() on error and I removed that because
> people can take advantage of it to fill /var/log/messages
On 09/15/2015 10:19 AM, Mike Marciniszyn wrote:
> The boolean tests should have been or-ed.
>
> Reported-by: David Binderman
> Reviewed-by: Jubin John
> Signed-off-by: Mike Marciniszyn
Thanks, applied.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP
The comment before the `COMEDI_SRF_...` macros starts with a kernel-doc
mark but isn't valid kernel-doc. There isn't a kernel-doc template for
a group of macro constants. These macros are all private anyway, so
don't really need to be in kernel-doc. Just change it to a normal
comment.
Signed-of
On 18/09/15 15:34, Punit Vara wrote:
This patch is to the comedilib.h file that fixes up coding style issues
and following warning:
- Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/comedi/comedilib.h | 28 ++--
1 file changed,
This patch is to the comedilib.h file that fixes up coding style issues
and following warning:
- Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/comedi/comedilib.h | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff -
On Fri, Sep 18, 2015 at 01:32:57PM +0100, Viacheslav Kovalevskyi wrote:
> On Thu, Sep 17, 2015 at 4:53 PM Greg KH wrote:
> >
> > On Thu, Sep 17, 2015 at 03:24:37PM +0100, Viacheslav Kovalevskyi wrote:
> > > Hi there,
> > >
> > > Apologies for the complete nuby question, I want to help with porting
On 18/09/15 13:30, Punit Vara wrote:
This patch is to the comedi.h file that fixes up following type
of 42 warning in the file:
-Blocking comments use a trailing */ on a separate line
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
-
Removed a space to fix the following coding style error detected
by checkpatch.pl
ERROR: space prohibited before that '++' (ctx:WxO)
Signed-off-by: Anjali Menon
---
drivers/staging/lustre/lustre/obdclass/llog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/
On Thu, Sep 17, 2015 at 4:53 PM Greg KH wrote:
>
> On Thu, Sep 17, 2015 at 03:24:37PM +0100, Viacheslav Kovalevskyi wrote:
> > Hi there,
> >
> > Apologies for the complete nuby question, I want to help with porting
> > Android LMK (drivers/staging/android/lowmemorykiller.c) from the
> > staging to
This patch is to the comedi.h file that fixes up following type
of 42 warning in the file:
-Blocking comments use a trailing */ on a separate line
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/comedi/comedi.h
This patch is to the comedi.h file that fixes up following type
of 42 warning in the file:
-Blocking comments use a trailing */ on a separate line
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/comedi/comedi.h
On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote:
From: Dmitry Kalinkin
This will enable error messages for accesses done through mmap.
Signed-off-by: Dmitry Kalinkin
Acked-by: Martyn Welch
---
drivers/vme/vme.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers
On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote:
From: Dmitry Kalinkin
The current VME bus error handler adds errors to the bridge error list.
vme_master_{read,write} then traverses that list to look for relevant
errors.
Such scheme didn't work well for accesses going through vme_master_m
On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote:
From: Dmitry Kalinkin
Also changes vme_bus_error_handler to take generic address modifier code
instead of raw contents of a device-specific attribute register.
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
Acked-by: Martyn Welch
-
On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote:
From: Dmitry Kalinkin
Error handling code found in tsi148 is not device specific. In fact it
already relies on shared vme_bus_error struct and vme_bridge.vme_errors
field. The other bridge driver could reuse this code if it is shared.
This in
This patch removes typedef from the struct tstrHostIFDelAllSta and
renames it to del_all_sta in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/dr
The global variable msgQ_created is removed because it is not necessary.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index 5d7224
The comments in union message_body are not essential and cross 80 ending
line, so they are deleted and also a dead code commented out in the union
is deleted.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 27 +--
1 file changed, 13 insertions(+),
This patch removes the global variable, u32Intialized which is not
necessary from the host_interface.c file.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/driv
This patch removes typedef from the struct tstrHostIfRegisterFrame and
renames it to reg_frame in order to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 5 +++--
drivers/staging/wilc1000/host_interface.h | 7 ++-
2 files changed,
This patch removes typedef from the struct tstrHostIfRemainOnChan and
renames it to remain_ch in order to comply with the Linux coding style
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 8 +---
drivers/staging/wilc1000/host_interface.h | 6 +++---
2 files changed,
This patch removes typedef from the struct tstrHostIfPowerMgmtParam and
renames it to power_mgmt_param in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff -
This patch removes typedef from the struct tstrHostIfGetMacAddress and
renames it get_mac_addr in order to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 5 +++--
drivers/staging/wilc1000/host_interface.h | 5 ++---
2 files changed, 5
This patch removes typedef from the struct tstrHostIfStaInactiveT and
renames it to sta_inactive_t in oder to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
This patch removes typedef from the struct tstrHostIFSetIPAddr and
renames it to set_ip_addr in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/
This patch removes typedef from the struct tstrHostIFDelSta and renames
it del_sta in order to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/st
This patch removes typedef from the struct tstrHostIfSetMacAddress and
renames it set_mac_addr in order to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 5 +++--
drivers/staging/wilc1000/host_interface.h | 5 ++---
2 files changed, 5
This patch removes typedef from the struct tstrHostIFSetMulti and
renames it to set_multicast in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git
This patch removes typedef from the struct tstrHostIfBASessionInfo and
renames it to ba_session_info in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 17 ++---
drivers/staging/wilc1000/host_interface.h | 5 ++---
This patch removes typedef from the struct tstrHostIfSetDrvHandler and
renames it to drv_handler in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 7 ---
drivers/staging/wilc1000/host_interface.h | 4 ++--
2 files changed,
This patch removes typedef from the struct tstrHostIfSetOperationMode
and renames it to op_mode in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 5 +++--
drivers/staging/wilc1000/host_interface.h | 4 ++--
2 files changed, 5
This patch removes typedef from the struct tstrHostIFSetChan and ranames
it to set_channel in order to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drive
This patch removes typedef from the struct tstrHostIFSetBeacon and
renames it to set_beacon in order to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/dr
This patch removes typedef from the struct tstrHostIFDelBeacon and
renames it to del_beacon in order to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/driv
This patch removes typedef from the tstrTimerCb and renames it to
timer_cb in order to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/ho
This patch removes typedef from the struct tstrHostIFCfgParamAttr and
renames it to cfg_param_attr in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --gi
This patch removes typedef from the struct tstrWILC_AddStaParam and
renames it to add_sta_param in oder to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 37 +--
drivers/staging/wilc1000/host_interface.h
This patch removes typedef from the struct tstrRcvdGnrlAsyncInfo and
renames it to rcvd_async_info in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git
This patch removes typedef from the struct tstrHostIFkeyAttr and renames
it to key_attr in oder to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/s
This patch removes typedef from the struct tstrHostIFGetChan and renames
it to get_channel in order to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/sta
This patch changes the name, tstrHostIFmsg to host_if_msg not to use
camelcase notation in the Linux.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 294 +++---
1 file changed, 147 insertions(+), 147 deletions(-)
diff --git a/drivers/staging/wilc
This patch removes typedef from the struct tstrHostIFconnectAttr and
renames it to connect_attr to comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/s
This patch removes typedef from the struct tstrRcvdNetworkInfo and
renames it to rcvd_net_info in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 7 ---
drivers/staging/wilc1000/host_interface.h | 6 +++---
2 files changed,
This patch removes typedef from the structure tstrHostIFscanAttr and
changes the camelcase name, tstrHostIFscanAttr to scan_attr in order to
comply with the Linux coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 14 +++---
1 file changed, 7 insertions
This patch changes the name, u16MsgId simply to id to avoid the camelcase
notation.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 102 +++---
1 file changed, 51 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.
This patch changes the camelcase notation, uniHostIFmsgBody which is a member
variable of structure host_if_msg to body in order to comply with the Linux
coding style.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 296 +++---
1 file changed, 148
The Linux kernel coding style does not recommend to use typedef for the
structure. This patch removes typedef from the host_if_msg structure.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 294 +++---
1 file changed, 147 insertions(+), 147 deletio
This patch changes the name, strHostIFmsg simply to msg because the
camelcase notation is not recommended in Linux.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 794 +++---
1 file changed, 397 insertions(+), 397 deletions(-)
diff --git a/driver
This patch gets rid of typedef from the union and renames tuniHostIFmsgBody
with simply message_body because the Linux coding style does not recommend
camelcase notation and typedef for structure, enmu and also union.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 8
This patch is to the Kconfig file which fixes up lines which
exceeded the standard 80 character limitation.
This file also fixes up 3 warnings regarding paragraph.
Signed-off-by: Punit Vara
---
drivers/staging/android/Kconfig | 28
1 file cha
On Fri, Sep 18, 2015 at 12:38:21PM +0530, Punit Vara wrote:
> This patch is to the Kconfig file which fixes up lines which
> exceeded the standard 80 character limitation.
> This file also fixes up 3 warnings regarding paragraph.
>
> Signed-off-by: Punit Vara
> ---
Your subject
This patch is to the Kconfig file which fixes up lines which
exceeded the standard 80 character limitation.
This file also fixes up 3 warnings regarding paragraph.
Signed-off-by: Punit Vara
---
drivers/staging/android/Kconfig | 28
1 file cha
72 matches
Mail list logo
