The > should be >= here or we read beyond the end of the array.
Fixes: d42ab0838d04 ('staging: wilc1000: use id value as argument')
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index 59a1a9d..621fd18 100644
--- a
On 2015년 09월 15일 15:27, Sudip Mukherjee wrote:
On Tue, Sep 15, 2015 at 11:53:34AM +0900, Tony Cho wrote:
This patch aims to remove the wilc_errorsupport.h which is unnecessary in the
wilc driver. This patch replaces the error types defined by wilc driver with
kernel generic error types and rem
On Tue, Sep 15, 2015 at 11:53:34AM +0900, Tony Cho wrote:
> This patch aims to remove the wilc_errorsupport.h which is unnecessary in the
> wilc driver. This patch replaces the error types defined by wilc driver with
> kernel generic error types and removes macros which handles the errors.
Patch 2
From: Glen Lee
g_flushing_in_progress is never used so just delete it.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/
From: Glen Lee
g_num_total_switches is never used so just delete it.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.h
b/drivers/staging/wilc1000/cor
From: Glen Lee
The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver.
Delete two defines.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/corec
From: Glen Lee
SendRawpacket is declared but not implemented. It is not used also.
So just delete it.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.h
On Mon, Sep 14, 2015 at 10:31:05PM +, Martin Pietryka wrote:
> This patch fixes all alignment issues, as well as a multiple
> assignment and multiple blank lines issues.
These are too many things to be included in a single patch. Please break
them into a series. One patch should do only one typ
On Tue, Sep 15, 2015 at 02:59:01AM +0530, Shraddha Barke wrote:
> Replace pr_info with dev_info when appropriate device structure
> is present
>
> Signed-off-by: Shraddha Barke
> ---
This has already been done by 962539a068a5 ("staging: fbtft: use dev_*")
regards
sudip
__
On Mon, Sep 14, 2015 at 10:00:43PM +0300, Mike Rapoport wrote:
> In cases where WILC_ERRORREPORT does not require cleanup actions, but
> causes immediate return from the function it can be replaced with return
> statement.
>
> Signed-off-by: Mike Rapoport
> ---
Have you build tested? It introduce
On Mon, Sep 14, 2015 at 10:21:14PM +0530, Chandra S Gorentla wrote:
> NULL pointer deference is observed in the wilc1000.ko module
> with bus type SPI and when SPI is not ready.
>
> Signed-off-by: Chandra S Gorentla
> ---
A small spelling mistake in the subject. It should be "staging" and not
"st
The macros are not used anywhere in this driver, so just delete it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.h
b/drivers/staging/wilc1000/host_interface.h
index a4321a4.
This patch fix alignment of enum.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 76 +++
1 file changed, 38 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.h
b/drivers/staging/wilc1000/host_interface.h
This patch removes if defined codes of USE_SUPPLICANT_GO_INTENT.
This macro is deleted because it is commented out.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 66 ---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 9
2 files
This patch removes if defined codes of FORCE_P2P_CLIENT.
This macro is deleted because it it commented out.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations
This patch fix alignment of defines.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 42 +++
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.h
b/drivers/staging/wilc1000/host_interfac
This patch replaces uint32_t with u32 that is a preferred kernel type.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 +-
drivers/staging/wilc1000/linux_mon.c | 4 +-
drivers/staging/wilc1000/linux_wlan.c | 10 +-
drivers/stagi
On Mon, Sep 14, 2015 at 02:53:11PM +0530, Sakshi Vaid wrote:
> Fixed the following error.
> WARNING: More than 80 characters in a line.
>
> Signed-off-by: Sakshi Vaid
> ---
This has already been done by 159dc4bff27a ("staging: lustre: lclient:
remove extra parentheses around right
This patch replaces bit shift with BIT(x) macro.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h
b/drivers/staging/wilc1000/wi
This patch removes USE_SUPPLICANT_GO_INTENT macro that is commented.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h
b/drivers/staging/wilc1000/wilc_wfi_cfgoper
This patch fix alignment of some defines in wilc_wfi_cfgoperations.h
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 44 +++
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h
This patch removes FORCE_P2P_CLIENT that is commented.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h
b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h
index
This patch removes useless extern declarations. This function is not
existed in the driver.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_in
This patch remove bit shift macro that is custom defined, then it is
replaced BIT(x) macro.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.h
b/driver
This patch removes commented codes.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.h | 13 ---
drivers/staging/wilc1000/linux_mon.c | 59 ---
drivers/staging/wilc1000/wilc_sdio.c | 2 --
drivers/staging/wilc1000/wilc_spi.c
This patch replaces uint16_t with u16 that is preferred kernel type.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_spi.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.c | 12 ++--
drivers/staging/wilc1000/wilc_wlan.h | 6 +++---
drivers/staging/wilc1000/wilc_w
This patch replaces uint8_t with u8 that is a preferred kernel type.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/linux_mon.c | 2 +-
drivers/staging/wilc1000/linux_wlan.c | 30 ++--
drivers/stagi
This patch replaces WILC_WFI_cfg80211_ops with wilc_cfg80211_ops to
avoid CamelCase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/driv
This patch replaces WILC_WFI_priv with wilc_priv to avoid CamelCase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/linux_mon.c | 2 +-
drivers/staging/wilc1000/linux_wlan.c | 12 +--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 90 +++--
wilc_wfi_cfgoperations.h and linux_wlan_common.h are included as
duplicated in linux_wlan.c.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/linux_wlan.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
On Mon, Sep 14, 2015 at 08:48:04AM -0800, Mike Dupuis wrote:
> > In your previous patches this From: line was not there. Why now?
>
> I did not do that by hand. I changed some SSMTP and git configuration
> settings recently-- perhaps that is related. If this is a problem, I will
> correct it.
The
On Tue, 15 Sep 2015, Shraddha Barke wrote:
Replace pr_info with dev_info when appropriate device structure
is present
Signed-off-by: Shraddha Barke
---
drivers/staging/fbtft/fbtft_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_devi
From: Leo Kim
This patch replaces the wilc error types with kernel generic error type.
- WILC_SUCCESS 0
- WILC_FAIL -EFAULT
- WILC_BUSY -EBUSY
- WILC_INVALID_ARGUMENT -EINVAL
- WILC_INVALID_STATE
From: Leo Kim
This patch removes the definition WILC_NULLCHECK which is not used anymore.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 8 ++--
drivers/staging/wilc1000/wilc_errorsupport.h | 6 --
drivers/staging/wilc1000
From: Leo Kim
This patch removes the file, wilc_errorsupport which is not used anymore.
Remove #include "wilc_errorsupport.h" from the source code.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_errorsupport.h | 15 ---
drivers/staging/wilc1000/wi
From: Leo Kim
This patch removes the definition WILC_ERRORCHECK which is not used
anymore and replaces PRINT_ER with printk.
There are build warnings from some functions because WILC_CATCH definition is
not used. So, this patch also removes WILC_CATCH from the functions.
Signed-off-by: Leo Kim
From: Leo Kim
Remove the definitions which are not used anywhere.
- WILC_ALREADY_EXSIT
- WILC_EMPTY
- WILC_FULL
- WILC_CANCELED
- WILC_INVALID_FILE
- WILC_UNSUPPORTED_VERSION
- WILC_FILE_EOF
Remove the definition which is not used anymore.
- WILC_CATCH
Signed-off-by: Leo Kim
Signed-off-by: Ton
From: Leo Kim
This patch removes the definition WILC_ERRORREPORT which is not used
anymore, and also replace PRINT_ER with printk error log.
The compiler complains the build warnings in some functions for WILC_CATCH and
ERRORHANDLER as unused definitions. So, this patch also removes WILC_CATCH a
From: Leo Kim
This patch removes the definition WILC_IS_ERR which is not used anymore.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_errorsupport.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_errorsu
This patch aims to remove the wilc_errorsupport.h which is unnecessary in the
wilc driver. This patch replaces the error types defined by wilc driver with
kernel generic error types and removes macros which handles the errors.
Leo Kim (7):
staging: wilc1000: remove definition WILC_IS_ERR
stagi
Hi Greg,
I am sorry but please ignore this patch in this time.
It's my mistake to include this patch from my queue into the series of 7
patches.
Thanks,
Tony.
On 2015년 09월 11일 16:52, Tony Cho wrote:
This patch removes the preprocessor definition, RX_BH_TYPE and uses the
request_threaded_ir
On 09/14/2015 05:34 PM, Luca Ceresoli wrote:
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static,
and their declaration removed fr
From: Ben Evans
Remove unused MAY_ constants from lustre_idl.h
Signed-off-by: Ben Evans
Reviewed-on: http://review.whamcloud.com/15398
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6450
Reviewed-by: John L. Hammond
Reviewed-by: Dmitry Eremin
Reviewed-by: James Simmons
Signed-off-by: Ol
From: Olaf Weber
On NUMA systems, the placement of worker threads relative to the
memory they use greatly affects performance. The CPT mechanism can be
used to constrain a number of Lustre thread types, and this change
makes it possible to configure the placement of ptlrpcd threads in a
similar m
From: Li Xi
The per-osc request pools consume a lot of memory if there are
hundreds of OSCs on one client. This will be a critical problem
if the client doesn't have sufficient memory for both OSCs and
applications.
This patch replaces per-osc request pools with a global pool
osc_rq_pool. The to
From: Hiroya Nozaki
LASSERT touches cl_client_cache->ccc_lru without any protection.
So this patch the LASSERT moves to the section protected by
cl_client_cache->ccc_lru_lock
Signed-off-by: Hiroya Nozaki
Reviewed-on: http://review.whamcloud.com/14901
Intel-bug-id: https://jira.hpdd.intel.com/br
From: James Simmons
Remove the cfs_timer_done function in the libcfs
kernel module since it is not used anywhere.
Signed-off-by: James Simmons
Signed-off-by: frank zago
Reviewed-on: http://review.whamcloud.com/13917
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245
Reviewed-by: John L.
From: Isaac Huang
The kib_tx_t::tx_nfrags field is the # entries in
the kib_tx_t::tx_frags array, rather than # DMA
mapped entries. So kiblnd_send/kiblnd_recv should
use kib_rdma_desc_t::rd_nfrags instead.
Signed-off-by: Isaac Huang
Reviewed-on: http://review.whamcloud.com/12857
Intel-bug-id: h
From: Liang Zhen
cmid created by kiblnd_dev_need_failover should always be destroyed,
however it is not the case in current implementation and we will leak
cmid when this function detected a device failover.
Signed-off-by: Liang Zhen
Reviewed-on: http://review.whamcloud.com/14603
Intel-bug-id:
From: Niu Yawei
cfs_hash_for_each_relax() should break iteration when callback
returns non-zero value.
Signed-off-by: Niu Yawei
Reviewed-on: http://review.whamcloud.com/14927
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6636
Reviewed-by: Bobi Jam
Reviewed-by: Andreas Dilger
Reviewed-by
From: Andrew Perepechko
ll_iget_for_nfs() can call unbalanced iput() causing memory
leaks. This patch removes this iput() call.
Also, avoid unhashing disconnected dentries in
d_lustre_invalidate(), which is another source of memory
leaks.
One of the symptoms of the leak is the following crash p
From: Oleg Drokin
In lmv_disconnect_mdc do procfs removal only if we actually know the name.
Reviewed-on: http://review.whamcloud.com/14605
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6517
Reviewed-by: James Simmons
Reviewed-by: John L. Hammond
Reviewed-by: Dmitry Eremin
Signed-off-by
From: Liang Zhen
kiblnd_post_rx() can't refer to rx::rx_conn anymore after
ib_post_recv() because this rx can be polled out by another thread
which may drop this rx and destroy rx::rx_conn.
This patch fixes this issue by taking an extra refcount on connection
before calling ib_post_recv().
Sign
From: Ann Koehler
The lu_cache_shrink slab shrinker is too slow, accounting for > 90% of
the time spent in shrink_slab when allocating huge pages. Most of its
time is spent iterating over the buckets in each site's object hash
table to compute the number of freeable objects. This iteration is
eli
From: Bruno Faccini
Prior to this patch undefined flags bits and out of range
archive id can be set.
Signed-off-by: Bruno Faccini
Reviewed-on: http://review.whamcloud.com/13337
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5757
Reviewed-by: frank zago
Reviewed-by: Henri Doreau
Signed-of
From: Andreas Dilger
Remove the remains of LUSTRE_MSG_MAGIC_V1 support from ptlrpc.
It has not been supported since 1.8 and is not functional since 2.0.
In lustre_msg_check_version(), return an error for unsupported RPC
versions so that the server will reject such RPCs early. Otherwise
the serv
From: Oleg Drokin
It looks like router proc files were defined out, so I missed them
during debugfs conversion.
Reenable the code and move all the variables to debugfs.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 8 +
.../staging/lustre/include/linux/l
From: Niu Yawei
To avoid potential security problems, non-privileged users should
have no permission to run 'lfs changelog' & 'lfs changelog_clear'.
Signed-off-by: Niu Yawei
Reviewed-on: http://review.whamcloud.com/14280
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6415
Reviewed-by: Lai
From: Oleg Drokin
This batch of changes is for various accumulated fixes since the
last time I had a chance to look at it.
The only "exception" is the last patch in the series - the
CPT-aware ptlrpcd patch. This one is included because
there was a strange code in that area otherwise that was fla
From: Liang Zhen
ksocknal_push() should break the loop if it can't find matching peer
Signed-off-by: Liang Zhen
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4423
Reviewed-on: http://review.whamcloud.com/10128
Reviewed-by: James Simmons
Reviewed-by: Doug Oucharek
Reviewed-by: Isaac Huan
From: Frank Zago
Due to some accounting bug, lsb_busy of a hash bucket can become
larger than the total number of objects in said bucket. A busy object
can be counted more than once. When that happens, a negative value is
returned by the shrinker callback.
Instead of trying (and failing) to coun
From: Fan Yong
For open case, the client side open handling thread may hit error
after the MDT grant the open. Under such case, the client should
send close RPC to the MDT as cleanup; otherwise, the open handle
on the MDT will be leaked there until the client umount or evicted.
If the LFSCK mark
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static,
and their declaration removed from rtw_mlme_ext.h, in a later commit.
This wo
Replace pr_info with dev_info when appropriate device structure
is present
Signed-off-by: Shraddha Barke
---
drivers/staging/fbtft/fbtft_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
i
On Mon, 2015-09-14 at 16:29 -0400, Mark Hounschell wrote:
[...]
> +Driver: dgap - Digi International Acceleport Xr PCI, Acceleport Xr 920 PCI,
> + Acceleport Xem PCI, Acceleport C/X PCI, and Acceleport EPC/X
> + PCI families of adapters.
> +
> +File: dgap/cxcon.bin
> +Fi
On 09/13/15 06:14, Anjali Menon wrote:
> Added a space to fix the following coding style warning detected by
> checkpatch:
Both your commit title and message say (or imply) you've added a space,
but this patch, in fact, removes a space, doesn't it?
> WARNING: space prohibited between function nam
This patch fixes all alignment issues, as well as a multiple
assignment and multiple blank lines issues.
Signed-off-by: Martin Pietryka
---
drivers/staging/netlogic/platform_net.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/netlogic/platf
There are few WILC_CATCH() uses that still remain. They are not needed
and can be removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 68 ---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 --
drivers/staging/wilc1000/wilc_wfi
Use plain goto instead of WILC_ERRORREPORT
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 42 +++
1 file changed, 20 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_i
The macros WILC_IS_ERR, WILC_ERRORCHECK, WILC_ERRORREPORT,
WILC_NULLCHECK and WILC_CATCH are not used and may be removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/wilc_errorsupport.h | 27 ---
1 file changed, 27 deletions(-)
diff --git a/drivers/staging/
Fix the following compilation warning:
CC [M] drivers/staging/wilc1000/wilc_wfi_cfgoperations.o
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c: In function ‘CfgScanResult’:
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:378:6: warning: unused
variable ‘s32Error’ [-Wunused-variable]
s32
In cases when WILC_ERRORREPORT is immidiately followed by WILC_CATCH, no
goto is actually performed and therefore WILC_ERRORREPORT may be replaced
with either printout or assignment of the error value, and WILC_CATCH may
be completely removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/wil
Hi,
These patches replace usage of WILC_ERRORREPORT, WILC_ERRORCHECK,
WILC_NULLCHECK and WILC_CATCH by plain code that either returns the error
value or sets the error code and uses goto to jump to error handling code.
Mike Rapoport (13):
staging: wilc1000: replace WILC_ERRORREPORT with return
The WILC_ERRORCHECK macro is replaced with printout or direct call to
return statement, together with removal of several WILC_CATCH accompaniyng
WILC_ERRORCHECK.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 6 ++
drivers/staging/wilc1000/wilc_msgqueue
In cases where WILC_ERRORREPORT does not require cleanup actions, but
causes immediate return from the function it can be replaced with return
statement.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/coreconfigurator.c | 3 +-
drivers/staging/wilc1000/host_interface.c
In case SendConfigPkt fails, the error handling code performs deletion of
timer, calls Handle_ScanDone and falls through freeing of allocated memory
which is common for both success and error paths. The deletion of timer and
invocation of Handle_ScanDone can be performed in 'then' clause of check o
WILC_NULLPTR can be replaced with test for NULL pointer and return of
WILC_NULL_PTR.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 20
2 files changed, 16 insertions(+), 1
Use error value assignment and goto instead of WILC_ERRORREPORT and
WILC_CATCH.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 93 +--
1 file changed, 52 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface
Check whether the driver is initialized before getting the semaphore
thus eliminating the need for WILC_ERRORREPORT and WILC_CATCH constructs
and s32Error variable.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 13 +
1 file changed, 5 insertions(+), 8 d
Make memory allocations outside of spin lock, so that ellocation errors
handling will not require unlocking
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c
In case the first allocation fails, we can return directly, and if the
second allocation fails we can goto to the end of the function where we
free the memory and return error.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/wilc_msgqueue.c | 21 ++---
1 file changed, 1
2015-09-14 14:00 GMT-04:00 Nicolas Joseph :
> Remove N_DBPSOfRate used in ComputeTxTime, remove by
> commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
>
> Signed-off-by: Nicolas Joseph
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 44
> --
> 1
Remove N_DBPSOfRate used in ComputeTxTime, remove by
commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
Signed-off-by: Nicolas Joseph
---
drivers/staging/rtl8192u/r8192U_core.c | 44 --
1 file changed, 44 deletions(-)
diff --git a/drivers/staging/
> -Original Message-
> From: Marc Zyngier [mailto:marc.zyng...@arm.com]
> Sent: Monday, September 14, 2015 8:01 AM
> To: Jake Oshins ; gre...@linuxfoundation.org; KY
> Srinivasan ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@r
NULL pointer deference is observed in the wilc1000.ko module
with bus type SPI and when SPI is not ready.
Signed-off-by: Chandra S Gorentla
---
Following are the steps to reproduce.
$ sudo insmod drivers/staging/wilc1000/wilc1000.ko
$ sudo ifconfig wlan1 up
wlan1 in the above command is the de
On Mon, Sep 14, 2015 at 08:24:24PM +0530, Sudip Mukherjee wrote:
> On Mon, Sep 14, 2015 at 07:33:47AM -0700, Greg KH wrote:
> > On Mon, Sep 14, 2015 at 01:48:09PM +0530, Sudip Mukherjee wrote:
> > > On Sun, Sep 13, 2015 at 12:55:42AM +0200, lucasg wrote:
> > > > There was a stray '*' in a comment b
line 158: WARNING: Missing a blank line after declarations
line 183: WARNING: Missing a blank line after declarations
Added a missing blank line after declartions.
Signed-off-by: Sakshi Vaid
---
drivers/staging/lustre/lustre/lov/lov_dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/dr
Hi Jake,
In the future, please CC me on anything that touches irqdomains, along
with Jiang Liu as we both co-maintain this piece of code.
On 11/09/15 01:00, ja...@microsoft.com wrote:
> From: Jake Oshins
>
> The patch series updates the one sent about a month ago in three ways. It
> integrated
On Mon, Sep 14, 2015 at 07:33:47AM -0700, Greg KH wrote:
> On Mon, Sep 14, 2015 at 01:48:09PM +0530, Sudip Mukherjee wrote:
> > On Sun, Sep 13, 2015 at 12:55:42AM +0200, lucasg wrote:
> > > There was a stray '*' in a comment block.
> > >
> > > Signed-off-by: lucasg
> > > ---
> > Greg has already
There was a stray '*' in a comment block.
Signed-off-by: Lucas Georges
---
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
index 5f4794
On Mon, Sep 14, 2015 at 01:48:09PM +0530, Sudip Mukherjee wrote:
> On Sun, Sep 13, 2015 at 12:55:42AM +0200, lucasg wrote:
> > There was a stray '*' in a comment block.
> >
> > Signed-off-by: lucasg
> > ---
> Greg has already applied your patch, but next time you send a patch
> please use your fu
On Mon, Sep 14, 2015 at 07:54:30PM +0530, Shraddha Barke wrote:
>
>
> On Mon, 14 Sep 2015, Greg Kroah-Hartman wrote:
>
> >On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote:
> >>Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros.
> >>
> >>Build tested it.
> >
> >
On Mon, 14 Sep 2015, Greg Kroah-Hartman wrote:
On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote:
Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros.
Build tested it.
Why put this here in the changelog area? You always have to at least
build test your cha
On Mon, Sep 14, 2015 at 07:17:30PM +0530, Shraddha Barke wrote:
> Replace all occurrences of printk(KERN_* by pr_info and pr_alert macros.
>
> Build tested it.
Same comments as the other patch.
___
devel mailing list
de...@linuxdriverproject.org
http:/
On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote:
> Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros.
>
> Build tested it.
Why put this here in the changelog area? You always have to at least
build test your changes, so this is always implied.
And can some o
On Mon, Sep 14, 2015 at 02:41:24PM +0530, Sakshi Vaid wrote:
> Added a missing blank line after declarations.
>
> 158: WARNING: Missing a blank line after declarations
> 183: WARNING: Missing a blank line after declarations
>
> Signed-off-by: Sakshi Vaid
> ---
> drivers/staging/lustre/lustre/lc
Replace all occurrences of printk(KERN_* by pr_info and pr_alert macros.
Build tested it.
Signed-off-by: Shraddha Barke
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/i
Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros.
Build tested it.
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/libcfs/tracefile.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/lustre/lustre/li
On Mon, Sep 14, 2015 at 05:37:45PM +0530, Ronit Halder wrote:
> I checked but it didn't show me any warning.
> Can you please specify the warning?
try with --strict option of checkpatch.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
h
I checked but it didn't show me any warning.
Can you please specify the warning?
regards
On Mon, Sep 14, 2015 at 2:06 PM, Sudip Mukherjee
wrote:
> On Mon, Sep 14, 2015 at 11:03:34AM +0530, Ronit Halder wrote:
>> This patch fixes the warning generated by sparse
>> "Using plain integer as NULL poi
1 - 100 of 108 matches
Mail list logo
