[PATCHv2] staging: amso1100: change occurrences of foo* to foo *

2015-09-02 Thread Ivan Radanov Ivanov
As per the Linux coding style, when declaring a pointer or a function that returns a pointer, the use of '*' should be adjacent to the data name or function name and not to the type name. Signed-off-by: Ivan Radanov Ivanov --- drivers/staging/amso1100/c2_ae.c | 8 1 file changed, 4 inse

[PATCH v3] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Anish Bhatt
checkpatch.pl recommends that this is no longer required. Also replaces ASCII-art copyright notice with simple text Signed-off-by: Anish Bhatt --- v2 : Fix encoding issues accidentally introduced in git send-email v3 : Move patch versioning so that it wont show in changelog, cross fingers drive

Re: [PATCH v2] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Greg KH
On Wed, Sep 02, 2015 at 06:28:34PM -0700, Anish Bhatt wrote: > checkpatch.pl recommends that this is no longer required. > Also replaces ASCII-art copyright notice with simple text > > v2: Fix encoding issues accidentally introduced in git send-email This shouldn't be in the changelog section, it

Re: [PATCH 3/3] staging/wilc1000: Use %pM format specifier to print mac address

2015-09-02 Thread Greg Kroah-Hartman
On Thu, Aug 27, 2015 at 07:10:48PM +0600, Alexander Kuleshov wrote: > printk() supports %pM format specifier for printing 6-byte MAC/FDDI > addresses in hex notation small buffers, let's use it intead of %x:%x... > > Signed-off-by: Alexander Kuleshov > --- > drivers/staging/wilc1000/host_interfa

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

2015-09-02 Thread Greg KH
On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote: > From: Johnny Kim > > The driver communicates with the chipset via the address of handlers > to distinguish async data frame. The SendConfigPkt function gets the > pointer address indicating the handlers as the last argument, but this > r

[PATCH v2] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Anish Bhatt
checkpatch.pl recommends that this is no longer required. Also replaces ASCII-art copyright notice with simple text v2: Fix encoding issues accidentally introduced in git send-email Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_bd663474.c | 4 drivers/staging/fbtft/fb_hx8340bn.

Re: [PATCH 1/4] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Greg KH
On Wed, Sep 02, 2015 at 06:20:14PM -0700, Anish Bhatt wrote: > On Wed, Sep 2, 2015 at 6:13 PM, Greg KH wrote: > > On Wed, Sep 02, 2015 at 04:29:33PM -0700, Anish Bhatt wrote: > >> checkpatch.pl recommends that this is no longer required. > >> Also replaces ASCII-art copyright notice with simple te

Re: [PATCH 2/4] staging/fbtft : Use macro for common fbtft addr win debug print

2015-09-02 Thread Anish Bhatt
On Wed, Sep 2, 2015 at 6:12 PM, Greg KH wrote: > On Wed, Sep 02, 2015 at 04:29:34PM -0700, Anish Bhatt wrote: >> Same fbtft_par_dbg(DEBUG_SET_ADDR_WIN..) debug print is repeated in >> every set_addr_win handler, repalce with a macro. > > Ick. > >> static void set_addr_win(struct fbtft_par *par, i

Re: [PATCH 3/4] staging:fbtft : Fix whitespace issues

2015-09-02 Thread Anish Bhatt
On Wed, Sep 2, 2015 at 6:12 PM, Greg KH wrote: > On Wed, Sep 02, 2015 at 04:29:35PM -0700, Anish Bhatt wrote: >> * Add missing spaces after and before operators >> * Add blank lines where recommended by checkpatch.pl >> * Remove extra blank lines where recommended by checkpatch.pl > > That's a lot

Re: [PATCH 1/4] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Anish Bhatt
On Wed, Sep 2, 2015 at 6:13 PM, Greg KH wrote: > On Wed, Sep 02, 2015 at 04:29:33PM -0700, Anish Bhatt wrote: >> checkpatch.pl recommends that this is no longer required. >> Also replaces ASCII-art copyright notice with simple text >> >> Signed-off-by: Anish Bhatt > > Corrupted and can't be appli

Re: [PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER()

2015-09-02 Thread Greg Kroah-Hartman
On Tue, Aug 18, 2015 at 11:14:49PM -0400, Raphaël Beamonte wrote: > It was just a wrapper around kfree(), so call that instead. > > Signed-off-by: Raphaël Beamonte > --- > drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) Turns out thi

Re: [PATCH v3] staging: dgnc: take lock when storing value in dgnc_poll_tick

2015-09-02 Thread Greg KH
On Tue, Aug 25, 2015 at 08:09:47PM +0100, Salah Triki wrote: > poll_tick is declared global, so dgnc_driver_pollrate_store needs to take > the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock the > appropriate lock, since it is intended for poll scheduling and dgnc_poll_tick > con

Re: [PATCH 1/4] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Greg KH
On Wed, Sep 02, 2015 at 04:29:33PM -0700, Anish Bhatt wrote: > checkpatch.pl recommends that this is no longer required. > Also replaces ASCII-art copyright notice with simple text > > Signed-off-by: Anish Bhatt Corrupted and can't be applied :( ___ de

Re: [PATCH 4/4] staging/fbtft : Use BIT() macro when possible

2015-09-02 Thread Greg KH
On Wed, Sep 02, 2015 at 04:29:36PM -0700, Anish Bhatt wrote: > Signed-off-by: Anish Bhatt I always need a changelog text :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/4] staging:fbtft : Fix whitespace issues

2015-09-02 Thread Greg KH
On Wed, Sep 02, 2015 at 04:29:35PM -0700, Anish Bhatt wrote: > * Add missing spaces after and before operators > * Add blank lines where recommended by checkpatch.pl > * Remove extra blank lines where recommended by checkpatch.pl That's a lot of different things to do in one patch. Remember, one

Re: [PATCH 2/4] staging/fbtft : Use macro for common fbtft addr win debug print

2015-09-02 Thread Greg KH
On Wed, Sep 02, 2015 at 04:29:34PM -0700, Anish Bhatt wrote: > Same fbtft_par_dbg(DEBUG_SET_ADDR_WIN..) debug print is repeated in > every set_addr_win handler, repalce with a macro. Ick. > static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int > ye) > { > - fbtft_par_

Re: [PATCH] staging: fbtft: Removed a space

2015-09-02 Thread Greg KH
On Fri, Aug 21, 2015 at 06:31:33PM +0530, Aparna Karuthodi wrote: > I fetched it yesterday using git fetch origin master. So, I thought I am in > the recent kernel tree. That's a horrible changelog text :( ___ devel mailing list de...@linuxdriverprojec

Re: [PATCH 2/2] android, lmk: Reverse the order of setting TIF_MEMDIE and sending SIGKILL.

2015-09-02 Thread Greg KH
On Wed, Aug 26, 2015 at 09:19:48PM +0900, Tetsuo Handa wrote: > Hello. > > Should selected_tasksize be added to rem even when TIF_MEMDIE was not set? > > Please see a thread from http://www.spinics.net/lists/linux-mm/msg93246.html > if you want to know why to reverse the order. >

Re: [PATCH 0/8] fix drivers/staging/android several coding style issues

2015-09-02 Thread Greg KH
On Wed, Aug 26, 2015 at 11:52:09AM +0800, Peng Sun wrote: > patches based on linux-next next-20150825 > Corrections based on checkpatch.pl with --strict > > Peng Sun (8): > fix staging:android style issue:spaces preferred around that '-' > fix staging:android style issue:No space is necessary

Re: [PATCH] staging: android: fix typo

2015-09-02 Thread Greg KH
On Thu, Aug 20, 2015 at 08:29:12AM +0900, Junesung Lee wrote: > Fix typo. What typo? Be specific please. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes

2015-09-02 Thread Greg KH
On Tue, Aug 18, 2015 at 03:13:55PM -0400, Benjamin Romer wrote: > This patch series addresses several issues found during review, > testing, and by the kernel test bot. These aren't all "fixes" so I can't just add them to the 4.3-final release, but some look like they should go there. So please s

Re: [PATCH 7/8] staging: unisys: stop device registration before visorbus registration

2015-09-02 Thread Greg KH
On Wed, Aug 26, 2015 at 07:15:26AM -0400, Jes Sorensen wrote: > Sudip Mukherjee writes: > > On Tue, Aug 25, 2015 at 08:33:55AM -0400, Jes Sorensen wrote: > >> Sudip Mukherjee writes: > >> > On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote: > >> >> In cases where visorbus is compiled

[PATCH 3/4] staging:fbtft : Fix whitespace issues

2015-09-02 Thread Anish Bhatt
* Add missing spaces after and before operators * Add blank lines where recommended by checkpatch.pl * Remove extra blank lines where recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_agm1264k-fl.c | 5 ++--- drivers/staging/fbtft/fb_bd663474.c| 1 + driv

[PATCH 4/4] staging/fbtft : Use BIT() macro when possible

2015-09-02 Thread Anish Bhatt
Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_hx8340bn.c | 6 +++--- drivers/staging/fbtft/fb_hx8353d.c | 6 +++--- drivers/staging/fbtft/fb_s6d02a1.c | 6 +++--- drivers/staging/fbtft/fb_st7735r.c | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/s

[PATCH 2/4] staging/fbtft : Use macro for common fbtft addr win debug print

2015-09-02 Thread Anish Bhatt
Same fbtft_par_dbg(DEBUG_SET_ADDR_WIN..) debug print is repeated in every set_addr_win handler, repalce with a macro. Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_bd663474.c | 4 ++-- drivers/staging/fbtft/fb_hx8347d.c | 3 +-- drivers/staging/fbtft/fb_hx8353d.c | 3 +-- drive

[PATCH 1/4] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Anish Bhatt
checkpatch.pl recommends that this is no longer required. Also replaces ASCII-art copyright notice with simple text Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_bd663474.c | 4 drivers/staging/fbtft/fb_hx8340bn.c | 4 drivers/staging/fbtft/fb_hx8347d.c | 4 drive

[PATCH 0/4] staging/fbtft checkpatch and other fixes

2015-09-02 Thread Anish Bhatt
* Remove FSF mailing address * Remove stray unicode characters * Fix a bunch of whitespace issues * Use BIT() macros where recommended * Simplify addr_win debug prints Anish Bhatt (4): staging/fbtft : Remove FSF mailing address from GPL comments staging/fbtft : Use macro for common fbtft addr

[PATCH] staging: goldfish: Prefer kernel type u32 over uint32_t

2015-09-02 Thread Ravi Teja Darbha
Prefer kernel type u32 over uint32_t to maintain uniformity. Signed-off-by: Ravi Teja Darbha --- drivers/staging/goldfish/goldfish_nand_reg.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_nand_reg.h b/drivers/staging/goldfish/go

[PATCH] staging: amso1100: change occurrences of foo* to foo *

2015-09-02 Thread Ivan Radanov Ivanov
Signed-off-by: Ivan Radanov Ivanov --- drivers/staging/amso1100/c2_ae.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/amso1100/c2_ae.c b/drivers/staging/amso1100/c2_ae.c index cedda25..24faa77 100644 --- a/drivers/staging/amso1100/c2_ae.c +++ b/driver

Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

2015-09-02 Thread Noralf Trønnes
Den 01.09.2015 19:52, skrev Brüns, Stefan: On Tuesday, September 01, 2015 16:57:14 Noralf Trønnes wrote: IMHO, this is a bad idea. A controller supporting more than 32 bpw can not set the bpw mask, as the mask is limited to 32 bits. Thus it has to check the bpw in its own setup function, and ma

[PATCH] staging: goldfish: Fix NULL comparison style

2015-09-02 Thread Ravi Teja Darbha
Fixed NULL comparison style as suggested by checkpatch.pl with --strict option. Signed-off-by: Ravi Teja Darbha --- drivers/staging/goldfish/goldfish_nand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfis

Re: [PATCH] staging: rtl8723au: remove unnecessary le32_to_cpu

2015-09-02 Thread Jes Sorensen
Michał Bartoszkiewicz writes: > The values passed to le32_to_cpu are already in the correct byte order. > This fixes four "cast to restricted __le32" sparse warnings. > > Signed-off-by: Michał Bartoszkiewicz > --- > drivers/staging/rtl8723au/core/rtw_security.c | 8 > 1 file changed, 4

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-09-02 Thread Sudip Mukherjee
On Wed, Sep 02, 2015 at 02:58:19PM +0300, Tomi Valkeinen wrote: > On 01/09/15 16:55, Sudip Mukherjee wrote: > > On Tue, Sep 01, 2015 at 04:27:24PM +0300, Tomi Valkeinen wrote: > >> On 18/07/15 07:08, Sudip Mukherjee wrote: > >>> Now since all cleanups are done and the code is ready to be merged let

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-09-02 Thread Tomi Valkeinen
On 01/09/15 16:55, Sudip Mukherjee wrote: > On Tue, Sep 01, 2015 at 04:27:24PM +0300, Tomi Valkeinen wrote: >> >> >> On 18/07/15 07:08, Sudip Mukherjee wrote: >>> Now since all cleanups are done and the code is ready to be merged lets >>> move it out of staging into fbdev location. >> >> Have you