[PATCH] staging: rtl8723au: remove unnecessary le32_to_cpu

2015-09-01 Thread Michał Bartoszkiewicz
The values passed to le32_to_cpu are already in the correct byte order. This fixes four "cast to restricted __le32" sparse warnings. Signed-off-by: Michał Bartoszkiewicz --- drivers/staging/rtl8723au/core/rtw_security.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/

Re: [PATCH] staging: speakup: Fix warning reported by checkpatch

2015-09-01 Thread Chris Brannon
Aleksei Fedotov writes: > This patch fixes the checkpatch.pl warnings: > WARNING: Block comments use a trailing */ on a separate line > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Aleksey Fedotov Acked-by: Chris Brannon Seems fine to me. -- Chris ___

[PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA

2015-09-01 Thread Geert Uytterhoeven
If NO_DMA=y: ERROR: "dma_free_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined! ERROR: "dma_alloc_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined! As all MOST sub drivers use DMA functionality, add a dependency on HAS_DMA to MOSTCORE, and to MOST, which se

[PATCH][RESEND] staging/wlan-ng : Partial checkpatch cleanups

2015-09-01 Thread Anish Bhatt
* Replace memcmp(... ETH_ALEN) with ether_addr_equal_unaligned() * Replace memcpy(... ETH_ALEN) with ether_addr_copy() Fixes : * CHECK : No space is necessary after a cast * CHECK : Please don't use multiple blank lines * CHECK : Alignment should match open parenthesis * CHECK : Unnecessary parent

Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

2015-09-01 Thread Brüns , Stefan
On Tuesday, September 01, 2015 16:57:14 Noralf Trønnes wrote: > > > > IMHO, this is a bad idea. A controller supporting more than 32 bpw can > > not set the bpw mask, as the mask is limited to 32 bits. Thus it has to > > check the bpw in its own setup function, and may or may not reject 9 bpw. > >

Re: [PATCH] staging: ipath: fix build failure

2015-09-01 Thread Doug Ledford
On 09/01/2015 12:54 PM, Jim Davis wrote: > On Tue, Sep 1, 2015 at 7:52 AM, Doug Ledford wrote: >> On 09/01/2015 09:01 AM, Sudip Mukherjee wrote: >>> building of ipath depends on infiniband. And if ipath is selected and >>> infiniband is not then build fails with: >>> ERROR: "ib_alloc_device" [driv

Re: [PATCH] staging: ipath: fix build failure

2015-09-01 Thread Jim Davis
On Tue, Sep 1, 2015 at 7:52 AM, Doug Ledford wrote: > On 09/01/2015 09:01 AM, Sudip Mukherjee wrote: >> building of ipath depends on infiniband. And if ipath is selected and >> infiniband is not then build fails with: >> ERROR: "ib_alloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined! >> ER

Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

2015-09-01 Thread Noralf Trønnes
Den 01.09.2015 01:28, skrev Stefan Bruens: On Monday 24 August 2015 01:24:59 Noralf Trønnes wrote: Den 24.08.2015 00:24, skrev Stefan Brüns: Avoid a crash, as master->setup may be NULL (e.g. xilinx controller). Even if master->setup is set, spi_setup does several compatibility/ sanity checks w

Re: [PATCH] staging: ipath: fix build failure

2015-09-01 Thread Doug Ledford
On 09/01/2015 09:01 AM, Sudip Mukherjee wrote: > building of ipath depends on infiniband. And if ipath is selected and > infiniband is not then build fails with: > ERROR: "ib_alloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined! > ERROR: "ib_dealloc_device" [drivers/staging/ipath/ib_ipath.ko

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-09-01 Thread Sudip Mukherjee
On Tue, Sep 01, 2015 at 04:27:24PM +0300, Tomi Valkeinen wrote: > > > On 18/07/15 07:08, Sudip Mukherjee wrote: > > Now since all cleanups are done and the code is ready to be merged lets > > move it out of staging into fbdev location. > > Have you considered writing a DRM driver for this? I'm n

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-09-01 Thread Tomi Valkeinen
On 18/07/15 07:08, Sudip Mukherjee wrote: > Now since all cleanups are done and the code is ready to be merged lets > move it out of staging into fbdev location. Have you considered writing a DRM driver for this? I'm not happy at all adding new fbdev drivers, as the DRM framework is much better,

[PATCH] staging: ipath: fix build failure

2015-09-01 Thread Sudip Mukherjee
building of ipath depends on infiniband. And if ipath is selected and infiniband is not then build fails with: ERROR: "ib_alloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined! ERROR: "ib_dealloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined! ERROR: "ib_dispatch_event" [drivers/stagin