[PATCH] staging: android: fix typo

2015-08-19 Thread Junesung Lee
Fix typo. Signed-off-by: Junesung Lee --- drivers/staging/android/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig index 24d657b..0a9a7b3 100644 --- a/drivers/staging/android/Kconfig +++ b/drivers/stagin

[PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

2015-08-19 Thread Anders Fridlund
Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0 with NULL in the assignment. Signed-off-by: Anders Fridlund --- drivers/staging/most/aim-network/networking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/aim-network/networking.c

Re: [PATCH 00/14] MIPS/staging: OCTEON: enable ethernet/xaui on CN68XX

2015-08-19 Thread Ralf Baechle
On Fri, Aug 14, 2015 at 12:49:58PM -0700, David Daney wrote: > If what you have now works, I would merge this patch set, so: > > Acked-by: David Daney > > > Follow-on improvements can be made with additional patches. Cool, thanks. Queued for kernel $n + 1. Ralf ___

Re: [PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

2015-08-19 Thread Salah Triki
On Wed, Aug 19, 2015 at 10:36:14PM +0300, Dan Carpenter wrote: > On Wed, Aug 19, 2015 at 07:11:55PM +0100, Salah Triki wrote: > > poll_tick is declared global, so dgnc_driver_pollrate_store needs to take > > the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is > > the appropria

Re: [PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

2015-08-19 Thread Dan Carpenter
On Wed, Aug 19, 2015 at 07:11:55PM +0100, Salah Triki wrote: > poll_tick is declared global, so dgnc_driver_pollrate_store needs to take > the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is > the appropriate lock, since it is intended for poll scheduling and > dgnc_poll_tick

Re: [PATCH v10 5/8] staging: usage documentation for simple fpga bus

2015-08-19 Thread Moritz Fischer
Acked-by: Moritz Fischer On Wed, Aug 19, 2015 at 11:28 AM, atull wrote: > On Mon, 17 Aug 2015, Pavel Machek wrote: > >> On Thu 2015-08-13 12:37:29, at...@opensource.altera.com wrote: >> > From: Alan Tull >> > >> > Add a document spelling out usage of the simple fpga bus. >> > >> > Signed-off-by

Re: [PATCH v10 5/8] staging: usage documentation for simple fpga bus

2015-08-19 Thread atull
On Mon, 17 Aug 2015, Pavel Machek wrote: > On Thu 2015-08-13 12:37:29, at...@opensource.altera.com wrote: > > From: Alan Tull > > > > Add a document spelling out usage of the simple fpga bus. > > > > Signed-off-by: Alan Tull > > Acked-by: Pavel Machek >

[PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

2015-08-19 Thread Salah Triki
poll_tick is declared global, so dgnc_driver_pollrate_store needs to take the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the appropriate lock, since it is intended for poll scheduling and dgnc_poll_tick contains the poll rate. dgnc_poll_lock needs to be declared not stati

Re: [PATCH 0/4] [media] Media entity cleanups and build fixes

2015-08-19 Thread Mauro Carvalho Chehab
Hi Javier, Em Wed, 19 Aug 2015 17:35:18 +0200 Javier Martinez Canillas escreveu: > Hello, > > This series contains a couple of build fixes and cleanups for the > Media Controller framework. The goal of the series is to get rid of > the struct media_entity .parent member since now that a media_g

[PATCH] hyper-v: mark TSC as unstable

2015-08-19 Thread Vitaly Kuznetsov
Hyper-V top-level functional specification states, that "algorithms should be resilient to sudden jumps forward or backward in the TSC value", this means that we should consider TSC as unstable. In some cases tsc tests are able to detect the instability, it was detected in 543 out of 646 boots in m

Re: USB, TTY, char/misc, and Staging trees now closed for 4.3

2015-08-19 Thread Albino B Neto
2015-08-19 11:52 GMT-03:00 Greg KH : > Given that 4.2 will be out in a few days, it's time to close my trees > for new patches until 4.3-rc1 is out. Ok -- Albino B Neto "Debian. Freedom to code. Code to freedom!" faw twitter.com/b1n0anb gplus.to/AlbinoBNeto __

[PATCH] /media/davinci_vpfe/dm365_resizer.c:Bug containing more than 80 characters in a line is fixed.

2015-08-19 Thread Ravinder Atla
Signed-off-by: Ravinder Atla --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c index 6218230..273aea3 100644 --

[PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-19 Thread Javier Martinez Canillas
The struct media_entity has a .parent field that stores a pointer to the parent struct media_device. But recently a media_gobj was embedded into the entities and since struct media_gojb already has a pointer to a struct media_device in the .mdev field, the .parent field becomes redundant and can be

[PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-19 Thread Javier Martinez Canillas
The struct media_entity does not have an .id field anymore since now the entity ID is stored in the embedded struct media_gobj. This caused the omap4iss driver fail to build. Fix by using the media_entity_id() macro to obtain the entity ID. Signed-off-by: Javier Martinez Canillas --- drivers/s

[PATCH 0/4] [media] Media entity cleanups and build fixes

2015-08-19 Thread Javier Martinez Canillas
Hello, This series contains a couple of build fixes and cleanups for the Media Controller framework. The goal of the series is to get rid of the struct media_entity .parent member since now that a media_gobj is embedded into entities, the media_gobj .mdev member can be used to store a pointer to t

Re: [PATCH] Staging: most: Use NULL instead of zero

2015-08-19 Thread Christian Gromm
On Wed, 19 Aug 2015 11:17:09 +0530 Ronit Halder wrote: > This patch fixes the warning generated by sparse > "Using plain integer as NULL pointer" by using NULL > instead of zero. > > Signed-off-by: Ronit halder Acked-by: Christian Gromm > --- > drivers/staging/most/aim-network/networking.c |

Re: [PATCHv7 5/5] Staging: most: aim-cdev/cdev.c. Fix "missing static keyword" warnings

2015-08-19 Thread Christian Gromm
On Fri, 14 Aug 2015 12:18:04 +0200 Adrian Remonda wrote: > This is a patch to the most/aim_cdev.c file. It makes several > local functions and structures static to prevent global visibility. > > Signed-off-by: Adrian Remonda Acked-by: Christian Gromm > --- > drivers/staging/most/aim-cdev/cdev

Re: [PATCHv7 4/5] Staging: most: hdm-dim2/dim2_hal.c. Fix "Using plain integer as NULL pointer" warnings

2015-08-19 Thread Christian Gromm
On Fri, 14 Aug 2015 12:18:03 +0200 Adrian Remonda wrote: > This patch fixes the warning generated by sparse: "Using plain integer > as NULL pointer" by replacing the offending 0 with NULL. > > Signed-off-by: Adrian Remonda > --- > drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- > 1 file chang

Re: [PATCHv7 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix "missing static keyword" warnings

2015-08-19 Thread Christian Gromm
On Fri, 14 Aug 2015 12:18:02 +0200 Adrian Remonda wrote: > This is a patch to the most/hdm-usb/hdm_usb.c file. It > makes several local functions and structures static to prevent global > visibility. > > Signed-off-by: Adrian Remonda Acked-by: Christian Gromm > --- > drivers/staging/most/hdm-

Re: [PATCH] staging: wilc1000: Set all options in region debugfs file

2015-08-19 Thread Greg KH
On Wed, Aug 19, 2015 at 06:00:12PM +0530, Chandra Gorentla wrote: > On Tue, Aug 18, 2015 at 08:01:00PM -0700, Greg KH wrote: > > On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote: > > > This patch allows setting all options in the module's debug region > > > options file 'wilc_debu

USB, TTY, char/misc, and Staging trees now closed for 4.3

2015-08-19 Thread Greg KH
Hi all, Given that 4.2 will be out in a few days, it's time to close my trees for new patches until 4.3-rc1 is out. Please feel free to send me patches for these trees, but note that I'll be ignoring them until 4.3-rc1 is out, at which point in time I'll start reviewing them again and applying th

Re: [PATCH 1/9] staging: most: NULL comparison style

2015-08-19 Thread Frans Klaver
On Wed, Aug 19, 2015 at 12:00 PM, Sudip Mukherjee wrote: > On Tue, Aug 18, 2015 at 01:31:00PM -0300, Fabio Estevam wrote: >> On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee >> wrote: >> > According to the kernel coding style the NULL check should not be >> > written as [variable] == NULL or [va

Re: [PATCHv7 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings

2015-08-19 Thread Christian Gromm
On Fri, 14 Aug 2015 12:18:01 +0200 Adrian Remonda wrote: > This patch fixes the warning generated by sparse: "Using plain integer > as NULL pointer" by replacing the pointer test against 0 with a logical test. > > Signed-off-by: Adrian Remonda Acked-by: Christian Gromm > --- > drivers/staging

Re: [PATCHv7 1/5] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings

2015-08-19 Thread Christian Gromm
On Fri, 14 Aug 2015 12:18:00 +0200 Adrian Remonda wrote: > This is a patch to the mostcore/core.c file. It makes > several local functions and structures static to prevent global > visibility. > > Signed-off-by: Adrian Remonda Acked-by: Christian Gromm > --- > drivers/staging/most/mostcore/co

Re: [PATCH] staging: wilc1000: Set all options in region debugfs file

2015-08-19 Thread Chandra Gorentla
On Tue, Aug 18, 2015 at 08:01:00PM -0700, Greg KH wrote: > On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote: > > This patch allows setting all options in the module's debug region > > options file 'wilc_debug_region'. This functionality allows the user > > to enable logging from

[PATCH v6 8/8] [media] media: rename the function that create pad links

2015-08-19 Thread Mauro Carvalho Chehab
Now that a link can be either between two different graph objects, we'll need to add more functions to create links. So, rename the existing one that create links only between two pads as media_create_pad_link(). No functional changes. This patch was created via this shell script: for i i

Re: [PATCHv2 19/19] staging: rtl8192u: r8192U_core: fix line over 80 characters code style issue

2015-08-19 Thread Dan Carpenter
On Tue, Aug 18, 2015 at 12:58:20PM -0400, Raphaël Beamonte wrote: > Light code refactoring to keep the lines under 80 characters to follow > the kernel code style. > The first patches seem fine but this one is too hard to review... Divide it up somehow. Maybe: patch #1: comments patch #2: add l

Re: [PATCH] staging: dgnc: take lock when storing value in dgnc_poll_tick

2015-08-19 Thread Dan Carpenter
On Tue, Aug 18, 2015 at 08:37:21PM +0100, Salah Triki wrote: > @@ -57,11 +57,17 @@ static ssize_t dgnc_driver_pollrate_store(struct > device_driver *ddp, > const char *buf, size_t count) > { > int ret; > + unsigned long flags; > > + spin_loc

Re: [PATCH 5/5] staging: wilc1000: use id value as argument

2015-08-19 Thread Dan Carpenter
> Real ID value means the value mapped to an alive NIC handler. Who is mapping it? It's all within the driver so it is not "real" unless there external requirements. > And when the driver transmits and receives some data frame with chipset, > the ID is used to distinguish the data frame's owner

Re: [PATCH 1/9] staging: most: NULL comparison style

2015-08-19 Thread Sudip Mukherjee
On Tue, Aug 18, 2015 at 01:31:00PM -0300, Fabio Estevam wrote: > On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee > wrote: > > According to the kernel coding style the NULL check should not be > > written as [variable] == NULL or [variable] != NULL. > > It seems this not documented in Documentat

[PATCH] drivers: staging: dgap: fixed all the block comments styling issues

2015-08-19 Thread Panos Vlachos
Signed-off-by: Panos Vlachos --- drivers/staging/dgap/dgap.c | 84 - 1 file changed, 52 insertions(+), 32 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 9112dd2..1cacd18 100644 --- a/drivers/staging/dgap/dgap.

Re: [PATCH RFC v5 8/8] [media] media: rename the function that create pad links

2015-08-19 Thread Hans Verkuil
On 08/18/2015 10:04 PM, Mauro Carvalho Chehab wrote: > Now that a link can be either between two different graph > objects, we'll need to add more functions to create links. > So, rename the existing one that create links only between > two pads as media_create_pad_link(). > > No functional change

Re: [PATCH 5/5] staging: wilc1000: use id value as argument

2015-08-19 Thread Johnny Kim
Hello Dan. On 2015년 08월 18일 18:12, Dan Carpenter wrote: On Tue, Aug 18, 2015 at 12:10:53PM +0900, Johnny Kim wrote: Hello Dan. On 2015년 08월 13일 23:49, Dan Carpenter wrote: On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote: +static u32 get_id_from_handler(tstrWILC_WFIDrv *handler) +{ +

[PATCH 12/13] staging: wilc1000: rename WILC_MsgQueueRecv to wilc_mq_recv

2015-08-19 Thread Chaehyun Lim
This patch replaces WILC_MsgQueueRecv with wilc_mq_recv to shorten function name and avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 3 files chan

[PATCH 13/13] staging: wilc1000: rename WILC_MsgQueueDestroy to wilc_mq_destroy

2015-08-19 Thread Chaehyun Lim
This patch replaces WILC_MsgQueueDestroy to wilc_mq_destroy to shorten function name and avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 3 file

[PATCH 11/13] staging: wilc1000: rename WILC_MsgQueueSend to wilc_mq_send

2015-08-19 Thread Chaehyun Lim
This patch replaces WILC_MsgQueueSend with wilc_mq_send to shorten function name and avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 98 +++ drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- drivers/staging/wilc1000/wilc_m

[PATCH 10/13] staging: wilc1000: rename WILC_MsgQueueCreate to wilc_mq_create

2015-08-19 Thread Chaehyun Lim
This patch replaces WILC_MsgQueueCreate with wilc_mq_create to shorten function name and avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 3 files

[PATCH 06/13] staging: wilc1000: wilc_msgqueue.c: use ! operator instead of NULL comparison

2015-08-19 Thread Chaehyun Lim
This patch uses ! operator instead of NULL comparison. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueu

[PATCH 07/13] staging: wilc1000: wilc_msgqueue.c: remove kfree NULL check

2015-08-19 Thread Chaehyun Lim
This patch removes kfree NULL check. WARNING: kfree(NULL) is safe and this check is probably not required. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/d

[PATCH 09/13] staging: wilc1000: replace WILC_ErrNo by int type

2015-08-19 Thread Chaehyun Lim
This patch replaces WILC_ErrNo with int type. WILC_ErrNo typedef is also removed. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_errorsupport.h | 2 -- drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++-- drivers/staging/wilc1000/wilc_msgqueue.h | 8 3 fi

[PATCH 08/13] staging: wilc1000: wilc_msgqueue.c: fix bool comparison style

2015-08-19 Thread Chaehyun Lim
This patch changes bool comparison style found by checkpatch.pl CHECK: Using comparison to true is error prone Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c