[PATCH 03/13] staging: wilc1000: wilc_msgqueue.c: remove multiple blank lines

This patch removes multiple blank lines. CHECK: Please don't use multiple blank lines Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.

[PATCH 04/13] staging: wilc1000: wilc_msgqueue.c: remove blank line before a close brace

This patch removes blank line before a close brace "}" CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/stag

[PATCH 02/13] staging: wilc1000: wilc_msgqueue.c: remove blank line after open brace

This patch removes a blank line for open brace "{" CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging

[PATCH 05/13] staging: wilc1000: wilc_msgqueue.c: remove unnecessary parentheses

This patch remove unnecessary parentheses found by checkpatch.pl CHECK: Unnecessary parentheses around pHandle->hSem Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgq

[PATCH 01/13] staging: wilc1000: wilc_msgqueue.c: remove braces for single statement

This patch removes braces for single statement blocks. WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wi

[PATCH] Staging: most: Use NULL instead of zero

This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder --- drivers/staging/most/aim-network/networking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/aim-network

Re: [PATCH] Kconfig: add temporary PCI dependency

> On Aug 18, 2015, at 9:10 PM, Greg KH wrote: > >> >> a library for their transfer engine, which also requires writing said >> library), I’m wondering if it isn’t worthwhile to create a >> staging/infiniband directory, remove your name and driverdevel from >> the maintainer entry for the direct

Re: [PATCH] Kconfig: add temporary PCI dependency

On Tue, Aug 18, 2015 at 08:11:26PM -0700, Doug Ledford wrote: > > > On Aug 18, 2015, at 7:49 PM, Greg KH wrote: > > > > On Tue, Aug 18, 2015 at 06:24:40PM -0700, Doug Ledford wrote: > >> > >> > >>> Are > >>> you going to be responsible for all of the patches sent to it and you > >>> just want

[PATCHv4 0/2] staging: wilc1000: code improvements

Hi, As requested, here are the two remaining ready patches of this patchset. I pulled and rebased against staging-testing just now. They should thus be usable without problem! Thanks, Raphaël Raphaël Beamonte (2): staging: wilc1000: remove FREE_WILC_BUFFER() staging: wilc1000: replace MALLO

[PATCHv4 2/2] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't take care of possible memory leaks and subsequent bugs when it was failing after succeeding some allocations. This patch corrects this behavior. Signed-off-by: Raphaël Beamonte --- drivers/staging/wilc1000/wilc_exported_buf.

[PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER()

It was just a wrapper around kfree(), so call that instead. Signed-off-by: Raphaël Beamonte --- drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c b/drivers/staging/wilc1000/wilc_

Re: [PATCH] Kconfig: add temporary PCI dependency

> On Aug 18, 2015, at 7:49 PM, Greg KH wrote: > > On Tue, Aug 18, 2015 at 06:24:40PM -0700, Doug Ledford wrote: >> >> >>> Are >>> you going to be responsible for all of the patches sent to it and you >>> just want me to ignore them, or will you send patches to me for me to >>> apply? >> >> I

Re: [PATCH] staging: wilc1000: Set all options in region debugfs file

On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote: > This patch allows setting all options in the module's debug region > options file 'wilc_debug_region'. This functionality allows the user > to enable logging from all regions (initialization, locks, firmware > etc.) of the drive

Re: [PATCHv3] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

On Tue, Aug 18, 2015 at 01:06:39PM -0400, Raphaël Beamonte wrote: > 2015-08-18 5:15 GMT-04:00 Dan Carpenter : > > To be honest, I have lost track of this patchset. If you are planning > > to redo the other patches can you send it in a new thread? > > Actually, Greg already included the "return st

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

On Mon, Aug 17, 2015 at 07:06:40PM -0400, Raphaël Beamonte wrote: > Signed-off-by: Raphaël Beamonte You can't submit a patch with no changelog information, sorry. Always build your patches, otherwise you make maintainers really grumpy as it breaks their build. greg k-h _

Re: [PATCH] Kconfig: add temporary PCI dependency

On Tue, Aug 18, 2015 at 06:24:40PM -0700, Doug Ledford wrote: > > > On Aug 18, 2015, at 4:11 PM, Greg KH wrote: > > > > On Tue, Aug 18, 2015 at 10:00:39AM -0700, Doug Ledford wrote: > >> > >>> On Aug 18, 2015, at 9:50 AM, Greg KH wrote: > >>> > >>> On Tue, Aug 18, 2015 at 04:29:50PM +, Ma

Re: [PATCH] Kconfig: add temporary PCI dependency

> On Aug 18, 2015, at 4:11 PM, Greg KH wrote: > > On Tue, Aug 18, 2015 at 10:00:39AM -0700, Doug Ledford wrote: >> >>> On Aug 18, 2015, at 9:50 AM, Greg KH wrote: >>> >>> On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: > Subject: Re: [PATCH] Kconfig: add temporary PCI d

BONUS TNB

Tenaga Nasional Berhad (TNB HQ) 129 Jalan Bangsar, 59200 Kuala Lumpur, Kuala Lumpur, Malaysia Ini adalah satu pemberitahuan rasmi daripada ibu pejabat daripada Tenaga Nasional Berhad sempena Persatuan Air Malaysia (PAM) untuk memaklumkan anda mengenai Hadiah Khas Eksklusif Tenaga Nasional Berha

Re: linux-next: Tree for Aug 17 (staging/hfi1)

Hi Mike, On Tue, 18 Aug 2015 14:24:32 + "Marciniszyn, Mike" wrote: > > > A: these and other similar errors: > > > > In file included from ../drivers/staging/hfi1/chip.c:61:0: > > ../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_LINKVERB’: > > ../drivers/staging/hfi1/trace.h:13

Re: [PATCH] Kconfig: add temporary PCI dependency

On Tue, Aug 18, 2015 at 10:00:39AM -0700, Doug Ledford wrote: > > > On Aug 18, 2015, at 9:50 AM, Greg KH wrote: > > > > On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: > >>> Subject: Re: [PATCH] Kconfig: add temporary PCI dependency > >>> > >>> On Tue, Aug 18, 2015 at 10:15:4

[PATCH RFC v5 8/8] [media] media: rename the function that create pad links

Now that a link can be either between two different graph objects, we'll need to add more functions to create links. So, rename the existing one that create links only between two pads as media_create_pad_link(). No functional changes. This patch was created via this shell script: for i i

[PATCH] staging: dgnc: take lock when storing value in dgnc_poll_tick

dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store needs to take the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the appropriate lock, since it is inteded for poll scheduling and dgnc_poll_tick contains the poll rate. dgnc_poll_lock needs to be declared not s

[PATCH 1/8] staging: unisys: unregister netdev when create debugfs fails

From: David Kershner Noticed we were not unregistering the netdevice if we failed to create the debugfs entries. This patch fixes that problem. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 5 - 1 file changed, 4 insertio

[PATCH 8/8] staging: unisys: visornic: handle error return from device registration

There is no code to handle an error return in visornic, when it tries to register with visorbus. This patch handles an error return from visorbus_register_visor_driver() by dropping out of initialization. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 5 +++--

[PATCH 6/8] staging: unisys: visorbus: Unregister driver on error

From: David Kershner If there is an error in registering driver attributes, unregister the driver as well. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/unis

[PATCH 5/8] staging: unisys: visornic: Fix receive bytes statistics

From: David Kershner The receive byte statistics was wrong in /proc/net/dev. Move the collection of statistics after the proper amount of bytes has been calculated and make sure you add it to rx_bytes instead of just replacing it. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --

[PATCH 2/8] staging: unisys: remove devdata->name use netdev->name

From: David Kershner The net device already has a name, use that instead Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/dri

[PATCH 0/8] staging: unisys: visornic/visorbus fixes

This patch series addresses several issues found during review, testing, and by the kernel test bot. Benjamin Romer (2): staging: unisys: stop device registration before visorbus registration staging: unisys: visornic: handle error return from device registration David Kershner (6): sta

[PATCH 4/8] staging: unisys: git rid of list of devices

From: David Kershner We don't need the list of devices, we can loop through the one provided by the network api and filter on ours. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 13 - 1 file changed, 13 deletions(

[PATCH 3/8] staging: unisys: get rid of devnum pool and dev num

From: David Kershner devnum pool and devnum are no longer needed. Just get rid of them. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 26 - 1 file changed, 26 deletions(-) diff --git a/drivers/staging

[PATCH 7/8] staging: unisys: stop device registration before visorbus registration

In cases where visorbus is compiled directly into the kernel, if visorbus registration fails for any reason, it is still possible for other drivers to call visorbus_register_visor_driver(), which could cause an oops. Prevent this by returning an error code when the bus hasn't been registered. Sign

[PATCH] staging: i2o: Used

Used #include instead of #include to remove a coding style warning detected by checkpatch. The warning is given below: drivers/staging/i2o/config-osm.c:22: WARNING: Use #include instead of Signed-off-by: Aparna Karuthodi --- drivers/staging/i2o/config-osm.c |2 +- 1 file changed, 1 ins

Re: [PATCH] Kconfig: add temporary PCI dependency

On 08/18/15 10:00, Doug Ledford wrote: > >> On Aug 18, 2015, at 9:50 AM, Greg KH wrote: >> >> On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: Subject: Re: [PATCH] Kconfig: add temporary PCI dependency On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wro

Re: [PATCHv3] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

2015-08-18 5:15 GMT-04:00 Dan Carpenter : > To be honest, I have lost track of this patchset. If you are planning > to redo the other patches can you send it in a new thread? Actually, Greg already included the "return statement" and "DECLARE_WILC_BUFFER" ones. The replacement of printk by netdev

[PATCHv2 14/19] staging: rtl8192u: r8192U_core: fix unnecessary else after return code style issue

An else statement is not useful after a return. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r819

[PATCHv2 00/19] staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports

Hi, Here is an update of the patches fixing all the checkpatch warnings and errors for the file drivers/staging/rtl8192u/r8192U_core.c, thanks to Sudop Mukherjee's remarks and advices. As a reminder, here is the checkpatch.pl tailed output before patches: total: 334 errors, 402 warnings,

[PATCHv2 10/19] staging: rtl8192u: r8192U_core: fix unecessary braces code style issue

braces {} are not necessary for any arm of a statement containing one statement on each side. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/driver

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

> On Aug 18, 2015, at 9:33 AM, Marciniszyn, Mike > wrote: > >> Subject: Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1 >> >> On Tue, Aug 18, 2015 at 04:04:15PM +, Marciniszyn, Mike wrote: > +HFI1 DRIVER > +M: Mike Marciniszyn > +L: linux-r...@vger.kernel.

[PATCH] staging: wilc1000: Set all options in region debugfs file

This patch allows setting all options in the module's debug region options file 'wilc_debug_region'. This functionality allows the user to enable logging from all regions (initialization, locks, firmware etc.) of the driver. Logging from the following regions is enabled during the driver initiali

Re: [PATCH] Kconfig: add temporary PCI dependency

> On Aug 18, 2015, at 9:50 AM, Greg KH wrote: > > On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: >>> Subject: Re: [PATCH] Kconfig: add temporary PCI dependency >>> >>> On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wrote: The move from infiniband to staging

[PATCHv2 19/19] staging: rtl8192u: r8192U_core: fix line over 80 characters code style issue

Light code refactoring to keep the lines under 80 characters to follow the kernel code style. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 1248 ++-- 1 file changed, 850 insertions(+), 398 deletions(-) diff --git a/drivers/staging/rtl8

[PATCHv2 09/19] staging: rtl8192u: r8192U_core: remove return statement of void function

void function return statement was not useful in this case. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 2ab0a98..90c5907 100644

[PATCHv2 12/19] staging: rtl8192u: r8192U_core: fix unnecessary check before kfree code style issue

kfree(NULL) is safe and the checks were not required. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c inde

[PATCHv2 13/19] staging: rtl8192u: r8192U_core: fix unnecessary parentheses code style issue

Two sets of parentheses were used to contain the same statement. In those cases, one of them has been removed, as unnecessary. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl819

[PATCHv2 18/19] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue

Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r81

[PATCHv2 17/19] staging: rtl8192u: r8192U_core: fix quoted string split across lines code style issue

Quoted strings should not be split to help text grep in the source. All quoted strings that were split have thus been merged to one unique quoted string each to follow the code style. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 8 1 file changed, 4 inser

[PATCHv2 16/19] staging: rtl8192u: r8192U_core: fix missing blank line after declarations code style issue

Adds whitespaces to separate the variables declarations and the function content. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 44 +++--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_cor

[PATCHv2 15/19] staging: rtl8192u: r8192U_core: fix unnecessary whitespace code style issue

Whitespaces are not necessary before a quoted newline. Remove those. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r819

[PATCHv2 11/19] staging: rtl8192u: r8192U_core: remove forward declarations in .c file

Checkpatch was giving a "externs should be avoided in .c files" because of these forward declarations. As these were not useful in this case, they have been removed. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCHv2 07/19] staging: rtl8192u: r8192U_core: clean C99 // comments

Replace C99 // comments by /* comments */ to follow the kernel code style. Remove some unuseful comments. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 636 - 1 file changed, 316 insertions(+), 320 deletions(-) diff --git a/drivers/

[PATCHv2 04/19] staging: rtl8192u: r8192U_core: fix else following close brace code style error

Fix "else should follow close brace" checkpatch error. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 3c20731..

[PATCHv2 05/19] staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing code style error

A missing struct keyword in variable declaration triggered a need consistent spacing around '*' code style error. The struct keyword thus has been added everywhere for the rtl8192_rx_info struct, and therefore its typedef removed as not needed anymore. Signed-off-by: Raphaël Beamonte --- drivers

[PATCHv2 01/19] staging: rtl8192u: r8192U_core: fix switch and case indent code style error

Some switch and case were not be at the same indent level. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 190 - 1 file changed, 95 insertions(+), 95 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging

[PATCHv2 06/19] staging: rtl8192u: r8192U_core: whitespace neatening to fix consistent spacing code style errors

Clean-up the file by using a cleaner spacing around symbols and words. Mostly use the automatic checkpatch whitespacing fixes. This takes care of the consistent spacing errors reported by checkpatch. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 288 +++

[PATCHv2 08/19] staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.h

Use #include instead of Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 9a658b4..2ab0a98 100644 --- a/drivers/st

[PATCHv2 02/19] staging: rtl8192u: r8192U_core: fix space before close parenthesis code style error

A space existed before the close parenthesis of an if statement. This patch removes it to follow the kernel code style. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_c

[PATCHv2 03/19] staging: rtl8192u: r8192U_core: fix code indent using spaces code style error

Fix "code indent should use tabs where possible" checkpatch error Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index

Re: [PATCH] Kconfig: add temporary PCI dependency

On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: > > Subject: Re: [PATCH] Kconfig: add temporary PCI dependency > > > > On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wrote: > > > The move from infiniband to staging requires a temporary PCI > > > dependency to fix 0-d

RE: [PATCH] MAINTAINERS: Add maintainer section for hfi1

> Subject: Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1 > > On Tue, Aug 18, 2015 at 04:04:15PM +, Marciniszyn, Mike wrote: > > > > +HFI1 DRIVER > > > > +M: Mike Marciniszyn > > > > +L: linux-r...@vger.kernel.org > > > > +L: de...@driverdev.osuosl.org > > > > +S: Su

Re: [PATCH 1/9] staging: most: NULL comparison style

On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee wrote: > According to the kernel coding style the NULL check should not be > written as [variable] == NULL or [variable] != NULL. It seems this not documented in Documentation/CodingStyle . ___ devel mai

RE: [PATCH] Kconfig: add temporary PCI dependency

> Subject: Re: [PATCH] Kconfig: add temporary PCI dependency > > On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wrote: > > The move from infiniband to staging requires a temporary PCI > > dependency to fix 0-day build issues. The > > drivers/infiniband/hw/Kconfig gratuitously added it

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

On Tue, Aug 18, 2015 at 04:04:15PM +, Marciniszyn, Mike wrote: > > > +HFI1 DRIVER > > > +M: Mike Marciniszyn > > > +L: linux-r...@vger.kernel.org > > > +L: de...@driverdev.osuosl.org > > > +S: Supported > > > +F: drivers/staging/hfi1 > > > > Why do this for a dri

Re: [PATCH] Kconfig: add temporary PCI dependency

On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wrote: > The move from infiniband to staging requires a temporary > PCI dependency to fix 0-day build issues. The > drivers/infiniband/hw/Kconfig gratuitously added it for all drivers. > > Signed-off-by: Mike Marciniszyn > --- > drivers

RE: [PATCH] MAINTAINERS: Add maintainer section for hfi1

> > +HFI1 DRIVER > > +M: Mike Marciniszyn > > +L: linux-r...@vger.kernel.org > > +L: de...@driverdev.osuosl.org > > +S: Supported > > +F: drivers/staging/hfi1 > > Why do this for a driver that is being deleted? > You are thinking of ipath. This is a new driver. Mike _

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

On Tue, Aug 18, 2015 at 10:06:09AM -0400, Mike Marciniszyn wrote: > Signed-off-by: Mike Marciniszyn > --- > 0 files changed > > diff --git a/MAINTAINERS b/MAINTAINERS > index b3c1a56..45953e9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9892,6 +9892,13 @@ M: Arnaud Patard > S: Od

[PATCH 3/9] staging: most: remove multiple blank line

Multiple blank lines are not recommended in the kernel coding style. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/aim-cdev/cdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c index e5853d0..818efc8 1006

[PATCH 6/9] staging: most: make functions static

split_arg_list() and audio_set_pcm_format() are being called from the same file and is not referenced from outside, so make them as static. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/aim-sound/sound.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 4/9] staging: most: out of memory error

If kzalloc fails it will print lots of debugging information in the log, no need to have another in the code. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/aim-cdev/cdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/ai

[PATCH 8/9] staging: most: remove unused variable

The variable conf was only assigned the value but was never used. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/hdm-usb/hdm_usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c index 305303f..34843b

[PATCH 9/9] staging: most: fix Makefile

The Makefile is including "drivers/media/video". But there is no such directory in kernel tree. Since it is aim-v4l2 this might have been "drivers/media/v4l2-core", but the Kconfig already mentions that it depends on VIDEO_V4L2. So no need to mention that again in the Makefile. Signed-off-by: Sud

[PATCH 5/9] staging: most: remove unused functions

These functions were only defined but not used anywhere. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/hdm-dim2/dim2_hal.c | 5 - drivers/staging/most/hdm-dim2/dim2_hal.h | 5 - drivers/staging/most/hdm-dim2/dim2_hdm.c | 10 -- 3 files changed, 20 deletions(-) diff -

[PATCH 7/9] staging: most: use NULL pointer

sparse was complaining that an integer is used as NULL pointer. Fix it by using NULL. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/hdm-dim2/dim2_hdm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/stagin

[PATCH 2/9] staging: most: bool comparison style

Mentioning true or false in the if comparison is error prone and also not according to the coding style. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/aim-cdev/cdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drive

[PATCH 1/9] staging: most: NULL comparison style

According to the kernel coding style the NULL check should not be written as [variable] == NULL or [variable] != NULL. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/aim-cdev/cdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/aim

RE: linux-next: Tree for Aug 17 (staging/hfi1)

> A: these and other similar errors: > > In file included from ../drivers/staging/hfi1/chip.c:61:0: > ../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_LINKVERB’: > ../drivers/staging/hfi1/trace.h:1357:20: error: function > ‘__hfi1_trace_LINKVERB’ can never be inlined because it u

[PATCH] staging: wilc1000: add a blank line after declaration

This patch adds a blank line after declaration found by checkpatch.pl WARNING: Missing a blank line after declarations. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 8 drivers/staging/wilc1000/linux_wlan.c | 18 ++ driv

[PATCH] Kconfig: add temporary PCI dependency

The move from infiniband to staging requires a temporary PCI dependency to fix 0-day build issues. The drivers/infiniband/hw/Kconfig gratuitously added it for all drivers. Signed-off-by: Mike Marciniszyn --- drivers/staging/hfi1/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] MAINTAINERS: Add maintainer section for hfi1

Signed-off-by: Mike Marciniszyn --- 0 files changed diff --git a/MAINTAINERS b/MAINTAINERS index b3c1a56..45953e9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9892,6 +9892,13 @@ M: Arnaud Patard S: Odd Fixes F: drivers/staging/xgifb/ +HFI1 DRIVER +M: Mike Marciniszyn +L

Re: [PATCH] Staging: fbtft: Fix iomem dereference

Yes, it is not I/O memory address. I was wrong on that. But it makes sparse happy. Is here any side effect of using ioread16() ? regards, ronit On Tue, Aug 18, 2015 at 2:27 PM, Dan Carpenter wrote: > On Tue, Aug 18, 2015 at 12:16:57PM +0530, Ronit Halder wrote: >> This patch fixes the warning ge

Re: [PATCH 00/18] staging: comedi: s526: tidy up driver

On 18/08/15 00:58, H Hartley Sweeten wrote: This series cleans up all of the driver code except for the counter subdevice. I still need to figure out how that subdevice works, right now it looks like it might be a bit broken... H Hartley Sweeten (18): staging: comedi: s526: tidy up multi-line

Re: [PATCH v2 0/3] staging: comedi: serial2002: tidy up

On 17/08/15 21:18, H Hartley Sweeten wrote: Fix all the remaining checkpatch.pl issues. v2: change errno in patch 3 to -ENOTTY H Hartley Sweeten (3): staging: comedi: serial2002: tidy up multi-line comments staging: comedi: serial2002: usleep_range is preferred over udelay staging: com

Re: [PATCH] staging: comedi: unioxx5: remove this flawed driver

On 17/08/15 21:03, H Hartley Sweeten wrote: I was going to clean up this driver but looking it over it has a number of serious flaws. Also, Fastwell published an End-Of-Life notification for the board on 24/Jan/2014 (End-of-sale 30/Jun/2014, End-of-delivery 30/Dec/2014). Since the driver has a c

Re: [PATCHv3] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

To be honest, I have lost track of this patchset. If you are planning to redo the other patches can you send it in a new thread? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/

Re: [PATCH 5/5] staging: wilc1000: use id value as argument

On Tue, Aug 18, 2015 at 12:10:53PM +0900, Johnny Kim wrote: > Hello Dan. > > On 2015년 08월 13일 23:49, Dan Carpenter wrote: > >On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote: > >>+static u32 get_id_from_handler(tstrWILC_WFIDrv *handler) > >>+{ > >>+ u32 id; > >>+ > >>+ if (!handler) >

Re: [PATCH] Staging: fbtft: Fix iomem dereference

On Tue, Aug 18, 2015 at 12:16:57PM +0530, Ronit Halder wrote: > This patch fixes the warning generated by sparse > "cast removes address space of expression" by using ioread16 > function insted of directly dereferencing I/O memory. > > Signed-off-by: Ronit halder Are these really iomem pointers?