Re: [PATCH RESEND V2 3/7] scsi: storvsc: Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-08-13 Thread Johannes Thumshirn
KY Srinivasan writes: >> -Original Message- >> From: Johannes Thumshirn [mailto:jthumsh...@suse.de] >> Sent: Thursday, August 13, 2015 7:34 AM >> To: KY Srinivasan ; Keith Mange >> >> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; >> de...@linuxdriverproject.org; oher...@s

Re: [PATCH 2/5] staging: wilc1000: change void pointer type to real type

2015-08-13 Thread Sudip Mukherjee
On Thu, Aug 13, 2015 at 01:41:20PM +0900, Tony Cho wrote: > From: Johnny Kim > > This patch changes the void pointer member of the tstrHostIFmsg to the > real data type because the void pointer type is ambiguous and not > readable. > > Signed-off-by: Johnny Kim > Signed-off-by: Tony Cho > ---

[PATCH] Staging: sm750fb: Fix "foo* bar" should be "foo *bar" errors

2015-08-13 Thread Shah, Yash (Y.)
From: Yash Shah Fix "foo* bar" should be "foo *bar" errors as detected by checkpatch.pl Signed-off-by: Yash Shah --- drivers/staging/sm750fb/sm750.h| 14 +++--- drivers/staging/sm750fb/sm750_cursor.c | 4 ++-- drivers/staging/sm750fb/sm750_cursor.h | 4 ++-- drivers/staging/s

RE: [PATCH 1/1] Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc

2015-08-13 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Thursday, August 13, 2015 4:09 PM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; > jbottom...@paralle

Re: [PATCH v10 3/8] add fpga manager core

2015-08-13 Thread Moritz Fischer
Hi Alan, I've updated my Zynq driver (it can be found in an older version against your v8 in the Xilinx tree, too) https://github.com/mfischer/linux/tree/alan-fpga-mgr-v10 to use your v10 version of the patch. Either I'm using the API wrong , or it never gets to the 'operating state'. Comments i

Re: [PATCH 1/1] Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc

2015-08-13 Thread Dan Carpenter
On Thu, Aug 13, 2015 at 04:09:10PM -0700, James Bottomley wrote: > On Thu, 2015-08-13 at 17:07 -0700, K. Y. Srinivasan wrote: > > From: Dexuan Cui > > > > This fixes the recent commit 3b71107d73b16074afa7658f3f0fcf837aabfe24: > > Which tree is this in? upstream linus is giving me bad object on

Re: [PATCH 1/1] Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc

2015-08-13 Thread James Bottomley
On Thu, 2015-08-13 at 17:07 -0700, K. Y. Srinivasan wrote: > From: Dexuan Cui > > This fixes the recent commit 3b71107d73b16074afa7658f3f0fcf837aabfe24: Which tree is this in? upstream linus is giving me bad object on that id. > Drivers: hv: vmbus: Further improve CPU affiliation logic > > W

Re: [PATCH v10 1/8] usage documentation for FPGA manager core

2015-08-13 Thread Moritz Fischer
Hi Alan, thanks for continuing to work on this :) A couple of minor nits ... On Thu, Aug 13, 2015 at 10:37 AM, wrote: > From: Alan Tull > > Add a document on the new FPGA manager core. > > Signed-off-by: Alan Tull > --- > v9: initial version where this patch was added > > v10: requested clea

[PATCH 1/1] Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc

2015-08-13 Thread K. Y. Srinivasan
From: Dexuan Cui This fixes the recent commit 3b71107d73b16074afa7658f3f0fcf837aabfe24: Drivers: hv: vmbus: Further improve CPU affiliation logic Without the fix, reloading hv_netvsc hangs the guest. Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c |

Re: [PATCH v10 4/8] fpga manager: add driver for socfpga fpga manager

2015-08-13 Thread Moritz Fischer
Acked-by: Moritz Fischer On Thu, Aug 13, 2015 at 10:37 AM, wrote: > From: Alan Tull > > Add driver to fpga manager framework to allow configuration > of FPGA in Altera SoCFPGA parts. > > Signed-off-by: Alan Tull > Acked-by: Michal Simek > --- > v2: fpga_manager struct now contains struct dev

Re: [PATCH 00/14] MIPS/staging: OCTEON: enable ethernet/xaui on CN68XX

2015-08-13 Thread David Daney
On 08/13/2015 06:21 AM, Aaro Koskinen wrote: Hi, Currently mainline Linux is unusable on OCTEON II CN68XX SOCs due to issues in Ethernet driver initialization. Some boards are hanging during init, and all the needed register differences compared to the older SOCs are not taken into account to ma

Re: [PATCH] staging: wilc1000: Process WARN, INFO options of debug levels from user

2015-08-13 Thread Dan Carpenter
On Wed, Aug 12, 2015 at 11:05:58PM +0530, Chandra S Gorentla wrote: > - if (copy_from_user(buffer, buf, count)) { > + ret = simple_write_to_buffer(buffer, sizeof(buffer), ppos, buf, count); This part doesn't make sense. Use copy_from_user(). Also it's not NUL terminated so it leads to a

Re: [PATCH] staging: wlan-ng: Made into two lines

2015-08-13 Thread Greg KH
On Thu, Aug 13, 2015 at 11:44:23PM +0530, Aparna Karuthodi wrote: > Broke the line into two lines to remove a coding style warning detected > by checkpatch. > > The warning is given below: > drivers/staging/wlan-ng/cfg80211.c:755: WARNING: line over 80 > characters > > Signed-off-by: Aparna Karut

[PATCH] staging: wlan-ng: Made into two lines

2015-08-13 Thread Aparna Karuthodi
Broke the line into two lines to remove a coding style warning detected by checkpatch. The warning is given below: drivers/staging/wlan-ng/cfg80211.c:755: WARNING: line over 80 characters Signed-off-by: Aparna Karuthodi --- drivers/staging/wlan-ng/cfg80211.c |3 ++- 1 file changed, 2 insert

[PATCH v10 2/8] fpga manager: add sysfs interface document

2015-08-13 Thread atull
From: Alan Tull Add documentation under drivers/staging for new fpga manager's sysfs interface. Signed-off-by: Alan Tull --- v5 : (actually second version, but keeping version numbers aligned with rest of patch series) Move document to drivers/staging/fpga/Documentation/ABI v6 :

[PATCH v10 7/8] staging: simple-fpga-bus: add TODO document

2015-08-13 Thread atull
From: Alan Tull Add a TODO document for the simple fpga bus. Signed-off-by: Alan Tull --- v10: This patch added in v10 of the patch set --- drivers/staging/simple-fpga-bus/TODO | 13 + 1 file changed, 13 insertions(+) create mode 100644 drivers/staging/simple-fpga-bus/TODO diff

[PATCH v10 8/8] staging: add simple-fpga-bus

2015-08-13 Thread atull
From: Alan Tull Add simple fpga bus. This is a bus that configures an fpga and its bridges before populating the devices below it. This is intended for use with device tree overlays. Note that FPGA bridges are seen as reset controllers so no special framework for FPGA bridges will need to be a

[PATCH v10 6/8] staging: add bindings document for simple fpga bus

2015-08-13 Thread atull
From: Alan Tull New bindings document for simple fpga bus. Signed-off-by: Alan Tull --- v9: initial version added to this patchset v10: s/fpga/FPGA/g replace DT overlay example with slightly more complicated example move to staging/simple-fpga-bus --- .../Documentation/bindings/sim

[PATCH v10 4/8] fpga manager: add driver for socfpga fpga manager

2015-08-13 Thread atull
From: Alan Tull Add driver to fpga manager framework to allow configuration of FPGA in Altera SoCFPGA parts. Signed-off-by: Alan Tull Acked-by: Michal Simek --- v2: fpga_manager struct now contains struct device fpga_manager_register parameters now take device v3: skip a version to align

[PATCH v10 5/8] staging: usage documentation for simple fpga bus

2015-08-13 Thread atull
From: Alan Tull Add a document spelling out usage of the simple fpga bus. Signed-off-by: Alan Tull --- v9: Initial version of this patch in patchset v10: s/fpga/FPGA/g improve formatting some rewriting move to staging/simple-fpga-bus --- .../Documentation/simple-fpga-bus.txt

[PATCH v10 0/8] FPGA Manager Framework and Simple FPGA Bus

2015-08-13 Thread atull
From: Alan Tull This patch set adds two chunks plus documentation: * FPGA manager core: exports API functions that write an image to a FPGA * DT Overlay support: simple-fpga-bus to handle FPGA from a DT overlay The FPGA manager core is mature enough to be in the regular kernel. simple-fpga-bu

[PATCH v10 3/8] add fpga manager core

2015-08-13 Thread atull
From: Alan Tull API to support programming FPGA. The following functions are exported as GPL: * fpga_mgr_buf_load Load fpga from image in buffer * fpga_mgr_firmware_load Request firmware and load it to the FPGA. * fpga_mgr_register * fpga_mgr_unregister FPGA device drivers can be adde

[PATCH v10 0/8] FPGA Manager Framework and Simple FPGA Bus

2015-08-13 Thread atull
From: Alan Tull This patchset adds two chunks plus documentation: * fpga manager core: exports API functions that write an image to a FPGA * DT Overlay support: simple-fpga-bus to handle FPGA from a DT overlay The fpga manager core is mature enough to be in the regular kernel. simple-fpga-bus

[PATCH v10 1/8] usage documentation for FPGA manager core

2015-08-13 Thread atull
From: Alan Tull Add a document on the new FPGA manager core. Signed-off-by: Alan Tull --- v9: initial version where this patch was added v10: requested cleanups to formatting and otherwise s/fpga/FPGA/g rewrite implementation section to not reference socfpga.c by name other rew

RE: [PATCH RESEND V2 3/7] scsi: storvsc: Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-08-13 Thread KY Srinivasan
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, August 13, 2015 7:34 AM > To: KY Srinivasan ; Keith Mange > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; > jbottom...@paralle

Re: [PATCH 5/5] staging: wilc1000: use id value as argument

2015-08-13 Thread Dan Carpenter
On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote: > +static u32 get_id_from_handler(tstrWILC_WFIDrv *handler) > +{ > + u32 id; > + > + if (!handler) > + return 0; > + > + for (id = 0; id < NUM_CONCURRENT_IFC; id++) { > + if (wfidrv_list[id] == handler) {

Re: [PATCH RESEND V2 3/7] scsi: storvsc: Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-08-13 Thread Johannes Thumshirn
"K. Y. Srinivasan" writes: > From: Keith Mange > > Currently we are making decisions based on vmbus protocol versions > that have been negotiated; use storage potocol versions instead. > > Tested-by: Alex Ng > Signed-off-by: Keith Mange > Signed-off-by: K. Y. Srinivasan > --- > drivers/scsi/

Re: [PATCH] staging: comedi: comedi_fops: fix possible overflow in do_chaninfo_ioctl()

2015-08-13 Thread Ian Abbott
On 12/08/15 19:39, Dan Carpenter wrote: On Wed, Aug 12, 2015 at 10:30:47AM -0700, H Hartley Sweeten wrote: @@ -1061,6 +1061,14 @@ static int do_chaninfo_ioctl(struct comedi_device *dev, if (it.maxdata_list) { if (s->maxdata || !s->maxdata_list) ret

[PATCH RESEND V2 4/7] scsi: storvsc: use correct defaults for values determined by protocol negotiation

2015-08-13 Thread K. Y. Srinivasan
From: Keith Mange Use correct defaults for values determined by protocol negotiation, instead of resetting them with every scsi controller. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c | 33 +++-- 1

[PATCH RESEND V2 5/7] scsi: storvsc: use storage protocol version to determine storage capabilities

2015-08-13 Thread K. Y. Srinivasan
From: Keith Mange Use storage protocol version instead of vmbus protocol version when determining storage capabilities. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c |8 1 files changed, 4 insertions(+), 4 deletions(

[PATCH RESEND V2 3/7] scsi: storvsc: Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-08-13 Thread K. Y. Srinivasan
From: Keith Mange Currently we are making decisions based on vmbus protocol versions that have been negotiated; use storage potocol versions instead. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c | 109 ++

[PATCH RESEND V2 2/7] scsi: storvsc: Use a single value to track protocol versions

2015-08-13 Thread K. Y. Srinivasan
From: Keith Mange Use a single value to track protocol versions to simplify comparisons and to be consistent with vmbus version tracking. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c | 35 +-- 1

[PATCH RESEND V2 1/7] scsi: storvsc: Rather than look for sets of specific protocol versions, make decisions based on ranges.

2015-08-13 Thread K. Y. Srinivasan
From: Keith Mange Rather than look for sets of specific protocol versions, make decisions based on ranges. This will be safer and require fewer changes going forward as we add more storage protocol versions. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- dr

[PATCH RESEND V2 7/7] scsi: storvsc: Set the error code correctly in failure conditions

2015-08-13 Thread K. Y. Srinivasan
In the function storvsc_channel_init(), error code was not getting set correctly in some of the failure cases. Fix this issue. Signed-off-by: K. Y. Srinivasan Reported-by: Dan Carpenter --- drivers/scsi/storvsc_drv.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --

[PATCH RESEND V2 6/7] scsi: storvsc: Allow write_same when host is windows 10

2015-08-13 Thread K. Y. Srinivasan
From: Keith Mange Allow WRITE_SAME for Windows10 and above hosts. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/sc

[PATCH RESEND V2 0/7] scsi: storvsc: Some miscellaneous cleanup

2015-08-13 Thread K. Y. Srinivasan
Cleanup version handling as well as base feature detection on storage version as opposed to host version. In this version, I have addressed comments from Dan Carpenter. K. Y. Srinivasan (1): scsi: storvsc: Set the error code correctly in failure conditions Keith Mange (6): scsi: storvsc: Rat

[PATCH 11/14] MIPS: OCTEON: initialize CN68XX PKO

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen CN68XX requires a different PKO configuration. This patch provides just enough setup to get the XAUI interfaces on CN6880 working with default parameters. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-pko.c | 149 +++

[PATCH 06/14] MIPS: OCTEON: add definitions for setting up SSO

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen Some Octeon II models have SSO instead of POW and use a different register for setting the interrupt thresholds. Add the necessary definitions for configuring the interrupts also on those models. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/inc

[PATCH 14/14] MIPS/staging: OCTEON: use common helpers for determining interface and port

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen Currently the Octeon Ethernet driver hardcodes the mapping between interface/port and IPD port number. Since we have generic helpers for the very same purpose, we might as well use them instead. This prevents having the same information in multiple places. Signed-off-by: Jan

[PATCH 02/14] MIPS: OCTEON: support additional interfaces on CN68XX

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen CN68XX has 9 interfaces. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c b/arch/mips/cavium-octeon/executi

[PATCH 00/14] MIPS/staging: OCTEON: enable ethernet/xaui on CN68XX

2015-08-13 Thread Aaro Koskinen
Hi, Currently mainline Linux is unusable on OCTEON II CN68XX SOCs due to issues in Ethernet driver initialization. Some boards are hanging during init, and all the needed register differences compared to the older SOCs are not taken into account to make interrupts and packet delivery to work. Thi

[PATCH 01/14] MIPS: OCTEON: fix CN6880 hang on XAUI init

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen Some CN68XX series Octeon II chips seem to hang if a reset is issued on XAUI initialization. Avoid the hang by disabling the reset on affected models. Tested on Cavium EBB6800 evaluation board and Kontron S1901 board. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskin

[PATCH 04/14] MIPS: OCTEON: configure XAUI pkinds

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen Configure the pkinds of XAUI interfaces on Octeon models that have them. This simple configuration uses 1:1 mapping between the PIP input port number and the selected pkind. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/c

[PATCH 10/14] MIPS/staging: OCTEON: support CN68XX style WQE

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen CN68XX has a bit different WQE structure. This patch provides the new definitions and converts the code to use the proper variant based on the actual model. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- .../cavium-octeon/executive/cvmx-helper-util.c |

[PATCH 03/14] MIPS: OCTEON: support all PIP input ports on CN68XX

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen CN68XX has 48 PIP input ports. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/include/asm/octeon/cvmx-pip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/include/asm/octeon/cvmx-pip.h b/arch/mips/include/asm/octeo

[PATCH 07/14] MIPS/staging: OCTEON: properly enable/disable SSO WQE interrupts

2015-08-13 Thread Aaro Koskinen
The Octeon models with SSO instead of POW need to use a different register for configuring the WQE interrupt thresholds. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 54 ++-- drivers/staging/octeon/ethernet.c| 5 +++- 2 files change

[PATCH 05/14] MIPS: OCTEON: configure minimum PKO packet sizes on CN68XX

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen CN68XX has common minimum packet size filters that need to be configured for the traffic to work. Just set them to a default value. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 15 +++ 1 file

[PATCH 08/14] MIPS/staging: OCTEON: set SSO group mask properly on CN68XX

2015-08-13 Thread Aaro Koskinen
CN68XX uses SSO instead of POW. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 1636bd9..abfe934 100

[PATCH 13/14] MIPS: OCTEON: support interfaces 4 and 5

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen Add the support for mapping between interface/port numbers and IPD port numbers also for the additional interfaces some Octeon II models have. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/cavium-octeon/executive/cvmx-helper-util.c | 12

[PATCH 09/14] MIPS/staging: OCTEON: increase output command buffers

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen The Octeon II models have more interfaces and thus require more output command buffers. Increase the allocation to support these models. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH 12/14] MIPS: OCTEON: set up 1:1 mapping between CN68XX PKO queues and ports

2015-08-13 Thread Aaro Koskinen
From: Janne Huttunen Use the internal port number also as the queue number on CN68XX. Signed-off-by: Janne Huttunen Signed-off-by: Aaro Koskinen --- arch/mips/include/asm/octeon/cvmx-pko.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/include/asm/octeon/cvmx-pko.h b/arch/m

Re: [PATCH 00/15] staging: comedi: hwdrv_apci3501: tidy up code

2015-08-13 Thread Ian Abbott
On 12/08/15 21:25, H Hartley Sweeten wrote: The hwdrv_apci3501.c file is included by the addi_apci_3501 driver to provide the support code for the timer subdevice. The code in this file is broken with respect to how comedi works with subdevices. Tidy it up so that it can be fixed. H Hartley Swe

Re: [PATCH 01/15] staging: comedi: hwdrv_apci3501: remove useless read/mask to stop watchdog

2015-08-13 Thread Ian Abbott
On 13/08/15 10:41, Ian Abbott wrote: On 12/08/15 21:25, H Hartley Sweeten wrote: The watchdog is stopped in apci3501_write_insn_timer() by writing a 0 to the timer control register. There is no need to read the register first and mask it (as done when the timer is used as a timer). Reported-by:

Re: [PATCH 08/15] staging: comedi: addi_apci_3501: rename private data 'i_IobaseAmcc'

2015-08-13 Thread Ian Abbott
On 12/08/15 21:25, H Hartley Sweeten wrote: Rename this CamelCase member of the private data. Also, fix the type of the member, it holds a pci_resource_start() address and should be an unsigned long. An 'int' or 'unsigned int' is fine in this case*, but 'unsigned long' is consistent with othe

Re: [PATCH 01/15] staging: comedi: hwdrv_apci3501: remove useless read/mask to stop watchdog

2015-08-13 Thread Ian Abbott
On 12/08/15 21:25, H Hartley Sweeten wrote: The watchdog is stopped in apci3501_write_insn_timer() by writing a 0 to the timer control register. There is no need to read the register first and mask it (as done when the timer is used as a timer). Reported-by: coverity (CID 1227052) Signed-off-by:

Re: [PATCH 4/5] staging: comedi: comedidev.h: fix comedi_offset_munge() for values > s->maxdata

2015-08-13 Thread Ian Abbott
On 13/08/15 01:00, H Hartley Sweeten wrote: The comedi_offset_munge() helper is used to convert unsigned int data values from the comedi offset binary format to two's complement values for hardware that needs the data in that format. The comedi data is always checked against s->maxdata before wri

Re: [PATCH] scsi: storvsc: be more picky about scmnd->sc_data_direction

2015-08-13 Thread Vitaly Kuznetsov
KY Srinivasan writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Thursday, June 25, 2015 9:12 AM >> To: linux-s...@vger.kernel.org >> Cc: Long Li; KY Srinivasan; Haiyang Zhang; James E.J. Bottomley; >> de...@linuxdriverproject.org; linux-ker...@v

Re: [PATCH] scsi: storvsc: use shost_for_each_device() instead of open coding

2015-08-13 Thread Vitaly Kuznetsov
Long Li writes: >> -Original Message- >> From: KY Srinivasan >> Sent: Friday, July 03, 2015 11:35 AM >> To: Vitaly Kuznetsov; linux-s...@vger.kernel.org >> Cc: Long Li; Haiyang Zhang; James E.J. Bottomley; >> de...@linuxdriverproject.org; >> linux-ker...@vger.kernel.org >> Subject: RE: [

Re: [PATCH RFC v3 10/16] media: rename link source/sink to pad0_source/pad1_sink

2015-08-13 Thread Hans Verkuil
On 08/12/15 22:14, Mauro Carvalho Chehab wrote: > Change the internal namespace for links between two pads to > have the "pad" there. > > We're also numbering it, as a common constructor is to do > things like: > > if (link->port1.type != MEDIA_GRAPH_PAD) > continue; > i