On Sun, Aug 09, 2015 at 08:39:56AM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-testing
> head: b963e7223cb3278dda35a6550a8df08ff2be2ee5
> commit: 1461d66728648540a043ba69ace1081ed5006faf [597/643] staging: sm7xxfb:
> merge
On Mon, Aug 10, 2015 at 11:42:27PM -0500, Junsu Shin wrote:
> This is a patch to the ion.c that fixes a warning that tells missing a blank
> line after declaration
>
> Signed-off-by: Junsu Shin
> ---
1) This is a false positive.
2) You need to refresh your tree. This has already been fixed.
reg
On Mon, Aug 10, 2015 at 08:56:02PM +0530, Aparna Karuthodi wrote:
> Added a new line to fix a coding style error no space after
> declaration detected by checkpatch.
>
> Signed-off-by: Aparna Karuthodi
> ---
Why are you sending this patch again? You have sent this one long back
and has already be
This is a patch to the ion.c that fixes a warning that tells missing a blank
line after declaration
Signed-off-by: Junsu Shin
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 6f
> -Original Message-
> From: Alexander Graf [mailto:ag...@suse.de]
> Sent: Sunday, August 09, 2015 9:25 AM
> To: Yoder Stuart-B08248; gre...@linuxfoundation.org; Rivera Jose-B46482; katz
> Itai-RM05202
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; a...@arndb.de
> Subjec
This patch remove unused memory functions because some macros with this
memory function are deleted.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_memory.c | 28 ---
drivers/staging/wilc1000/wilc_memory.h | 50 --
2 files changed, 7
Use kfree instead of WILC_FREE.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 12 +--
drivers/staging/wilc1000/host_interface.c | 112 +++---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_m
Remove unused define macro that is never used.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_memory.h | 51 --
1 file changed, 51 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_memory.h
b/drivers/staging/wilc1000/wilc_memory.h
index 372d
Remove WILC_FREE that is replaced by kfree.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_memory.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_memory.h
b/drivers/staging/wilc1000/wilc_memory.h
index 1c0cb82..5ec4ef3 100644
--- a/drivers/
On 08/10/2015 02:51 PM, Joe Perches wrote:
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
Acked-by: David Daney
---
drivers/staging/octeon/ethernet-mdio.h | 2 +-
drivers/staging/octeon/octeon-ethernet.h | 22 +++---
2 files chang
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches
---
drivers/staging/xgifb/vb_init.h| 4 ++--
drivers/staging/xgifb/vb_setmode.h | 34 +-
2 files changed, 19 insertions(+), 19 deletions(-)
From: Prarit Bhargava
This patch adds an module alias and a MODULE_DEVICE_TABLE to autoload the
visornic driver when an appropriate device is created by the visorbus.
Note, the correct way of fixing this is adding functionality to
scripts/mod/file2alias.c for the visorbus bus type.
Signed-off-b
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/rtl8712/rtl871x_ioctl.h | 28
1 file changed, 12 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl.h
b/drivers/staging/rtl8712/rt
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/octeon/ethernet-mdio.h | 2 +-
drivers/staging/octeon/octeon-ethernet.h | 22 +++---
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/octeon/
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches
---
drivers/staging/fbtft/fbtft.h | 52 +--
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches
---
drivers/staging/nvec/nvec.h | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/nvec/nvec.h b/drivers/staging/nvec/nvec.
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/rtl8188eu/include/osdep_service.h | 2 +-
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 8
drivers/staging/rtl8188eu/include/sta_info.h | 18 +-
3 files c
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 2 +-
.../staging/lustre/lnet/klnds/socklnd/socklnd.h| 141 +-
drivers/staging/lustre/lnet/selftest/consol
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches
---
drivers/staging/wilc1000/coreconfigurator.h | 30 +++
drivers/staging/wilc1000/linux_wlan_common.h | 4 +--
drivers/staging/wilc1000/wilc_wfi
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.h | 10 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 4 +-
.../staging/rtl8192e/rtl8192e/r8192E_firmware.h
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/dgnc/dgnc_sysfs.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.h
b/drivers/staging/dgnc/dgnc_sysfs.h
index be0f90a..7be
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignment
Signed-off-by: Joe Perches
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h | 19 +--
drivers/staging/ft1000/ft1000-usb/ft1000_usb.h | 4 ++--
2 files changed, 11 insertions(+), 12 delet
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/mt29f_spinand/mt29f_spinand.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.h
b/drivers/staging/mt29f_spinand/mt29f_spina
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches
---
drivers/staging/speakup/i18n.h| 12 +++
drivers/staging/speakup/speakup.h | 68 +++
2 files changed, 39 insertions(+), 41 deletio
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/olpc_dcon/olpc_dcon.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h
b/drivers/staging/olpc_dcon/olpc_dcon.h
index aec9895..d06e19d
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 345 +
drivers/staging/rtl8192u/r8190_rtl8256.h | 11 +-
drivers/staging/rtl8192u/r8192U.h
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/android/sync.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h
index a21b79f..61f8a3a 100644
---
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/netlogic/xlr_net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/netlogic/xlr_net.h
b/drivers/staging/netlogic/xlr_net.h
index 13e03f0..2f65ec5 100644
--
trivial neatening of prototypes
Joe Perches (19):
staging: android: Remove unnecessary externs
staging: dgnc: Remove unnecessary externs
staging: fbtft: Remove unnecessary externs
staging: ft1000: Remove unnecessary externs
staging: iio: Remove unnecessary externs
staging: lustre: Remo
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/most/hdm-dim2/dim2_hal.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.h
b/drivers/staging/most/hdm-dim2/dim2_hal.h
index
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches
---
drivers/staging/iio/meter/ade7854.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7854.h
b/drivers/staging/iio/meter/ade7854.h
index 52ca541..52f4195 10
The BUG_ON() checks in comedi_subdevice_from_minor() and
comedi_dev_get_from_subdevice_minor() are not necessary.
The 'minor' numbers for a given comedi driver are setup by
comedi_dev_get_from_subdevice_minor() and will always be in
the correct range.
Drivers should not crash the kernel, remove t
This function is only called by comedi_dev_get_from_minor() and the 'minor'
value will always be < COMEDI_NUM_BOARD_MINORS. Remove the unnecessary
BUG_ON().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/comedi_fops.c | 1 -
1 file changed, 1
Drivers should not crash the kernel.
This function is only called by comedi_device_detach_cleanup() and the
s->minor will always be valid or the device wouldn't have attached in
the first place.
Leave the checks for safety in accessing the comedi_subdevice_minor_table
array but remove the BUG_ON(
This function is only called by comedi_cleanup_board_minors() and the
'minor' parameter will always be < COMEDI_NUM_BOARD_MINORS.
For aesthetics, absorb the function and remove the unnecessary BUG_ON().
Split the comedi_clear_board_minor() out to clarify that the return value
is a comedi_device p
The BUG_ON() checks in this function are not necessary.
comedi_cleanup_board_minors() clears all the entries in the
comedi_board_minor_table array and will call comedi_device_cleanup()
for all attached devices. comedi_device_cleanup() will then
clear the entries in the comedi_subdevice_minor_table
Drivers should not crash the kernel.
H Hartley Sweeten (5):
staging: comedi: comedi_fops: absorb comedi_free_board_minor()
staging: comedi: comedi_fops: remove BUG_ON() in
comedi_dev_get_from_board_minor()
staging: comedi: comedi_fops: remove BUG_ON() in comedi_free_subdevice_minor()
stag
Warnings are not a bad thing they are a valuable marker to let us know
which code is broken. If we just silence the warning in the laziest
possible way then we are throwing away valuable information. It's
better to leave the warning there so that the next person can fix it
properly.
If you want
On Friday, August 07, 2015 10:34 PM, Sudip Mukherjee wrote:
> On Fri, Aug 07, 2015 at 11:45:03AM -0700, H Hartley Sweeten wrote:
>> Define the bits in this register. Remove the old defines in hwdrv_apci1564.c.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ian Abbott
>> Cc: Greg Kroah-Hartman
>>
On Mon, Aug 10, 2015 at 07:27:13PM +0300, Dan Carpenter wrote:
> On Mon, Aug 10, 2015 at 08:59:43PM +0530, Chandra Gorentla wrote:
> > I agree with your suggestion
> > that we need to take a broader look. Please help in understanding
> > how does that broader look is suggesting that the patch is n
Coverity reports a possible Out-of-bounds access (ARRAY_VS_SINGLETON)
with the 'const u8 *port' parameter passed to ni6501_port_command().
This param is an actual array for the SET_PORT_DIR operation, called
by ni6501_dio_insn_config(). But for the WRITE_PORT and READ_PORT
operations, called by ni6
On Mon, Aug 10, 2015 at 08:59:43PM +0530, Chandra Gorentla wrote:
> I agree with your suggestion
> that we need to take a broader look. Please help in understanding
> how does that broader look is suggesting that the patch is not
> addressing a right problem. The gcc version I am using is - 4.8.2
On Mon, Aug 10, 2015 at 03:47:19PM +0200, Jason A. Donenfeld wrote:
> Ozwpan is completely unmaintained and potentially a security problem. As
> this is a staging driver, it should be removed, since it has been
> abandoned. Marking it as orphaned is the first step here.
>
> Signed-off-by: Jason A.
On Mon, Aug 10, 2015 at 12:39:43PM +0300, Dan Carpenter wrote:
> On Sun, Aug 09, 2015 at 08:50:02PM +0530, Chandra S Gorentla wrote:
> > Removed pointer check with integer; this fixes 'sparse' error -
> > error: incompatible types for operation (>)
> >left side has type unsigned char [usertype]
Added a new line to fix a coding style error no space after
declaration detected by checkpatch.
Signed-off-by: Aparna Karuthodi
---
drivers/staging/lustre/lustre/llite/llite_capa.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c
b/drivers/
Fix checkpatch problem: move last argument of the hlist..() back to same line
Signed-off-by: Swee Hua Law
---
drivers/staging/lustre/lustre/llite/remote_perm.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c
b/drivers/s
Fix checkpatch problem: move */ from end of line to new line
Signed-off-by: Swee Hua Law
---
drivers/staging/lustre/lustre/llite/remote_perm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c
b/drivers/staging/lustre/lustre/
Fix checkpatch problem: change == NULL comparison to !symbol
Signed-off-by: Swee Hua Law
---
drivers/staging/lustre/lustre/llite/remote_perm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c
b/drivers/staging/lustre/lustr
Fix checkpatch problem: remove NULL assignment fro global variable
Signed-off-by: Swee Hua Law
---
drivers/staging/lustre/lustre/llite/remote_perm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c
b/drivers/staging/lustr
Split patch into series.
Fix various coding style issue in remote_perm.c:
[PATCH V2 1/4] staging: lustre: checkpatch: do not init global to NULL
[PATCH V2 2/4] staging: lustre: checkpatch: symbol == NULL should be !symbol
[PATCH V2 3/4] staging: lustre: checkpatch: move */ block comment to next li
Ozwpan is completely unmaintained and potentially a security problem. As
this is a staging driver, it should be removed, since it has been
abandoned. Marking it as orphaned is the first step here.
Signed-off-by: Jason A. Donenfeld
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletio
On Mon, Aug 10, 2015 at 3:31 PM, Jason A. Donenfeld wrote:
> Meanwhile Dan
> Carpenter has posted a patch for a security vulnerability in ozwpan
> that hasn't been reviewed or merged.
Sorry, I see that you did in fact pick up this patch, so I retract
that statement.
Nonetheless, the remainder of
Hi Greg,
We spoke about this several months ago. Since then, there has been no
life from any of the maintainers or anybody at Atmel. Meanwhile Dan
Carpenter has posted a patch for a security vulnerability in ozwpan
that hasn't been reviewed or merged. There is nobody willing to
maintain it. And no
KY Srinivasan writes:
>> -Original Message-
>> From: Greg KH [mailto:gre...@linuxfoundation.org]
>> Sent: Thursday, August 6, 2015 2:11 PM
>> To: KY Srinivasan
>> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
>> vkuzn...@redhat.com; s...@canb.auug.org.au; t...@linutroni
On Mon, Aug 10, 2015 at 02:58:24PM +0900, Tony Cho wrote:
> +static u32 add_handler_in_list(tstrWILC_WFIDrv *handler)
I am suspicous of code which uses u32 for something where the hardware
doesn't specify unsigned 32 bits. Why not just return "int"?
> +{
> + u32 id;
It looks like we have a
On Sat, Aug 08, 2015 at 02:31:40PM -0700, Greg KH wrote:
> > int libcfs_register_ioctl(struct libcfs_ioctl_handler *hand);
> > int libcfs_deregister_ioctl(struct libcfs_ioctl_handler *hand);
> > -int libcfs_ioctl_getdata(char *buf, char *end, void *arg);
> > -int libcfs_ioctl_popdata(void *arg, v
On Sun, Aug 09, 2015 at 06:15:36PM +0530, Bhaktipriya Shridhar wrote:
> Fixed coding style issue "warning line over 80 characters"
> detected by checkpatch.pl in dgnc_mgmt.c
No signed off by.
> ---
> drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
On Sun, Aug 09, 2015 at 08:50:02PM +0530, Chandra S Gorentla wrote:
> Removed pointer check with integer; this fixes 'sparse' error -
> error: incompatible types for operation (>)
>left side has type unsigned char [usertype] *[usertype] pu8Tail
>right side has type int
>
> Signed-off-by: C
On 07/08/15 19:45, H Hartley Sweeten wrote:
The hwdrv_apci1564.c file is included by the addi_apci_1564 driver to provide
the support code for the timer and counter subdevices. The code in this file
is broken with respect to how comedi works with subdevices.
Tidy it up so that it can be fixed.
This static can be made constant as it is never modified.
Found during sparse-cleanup.
Signed-off-by: Patrick Boettcher
---
drivers/staging/lustre/lustre/libcfs/module.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/module.c
b/driv
Fix sparse warnings of the following type:
warning: symbol '' was not declared. Should it be static?
Signed-off-by: Patrick Boettcher
---
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 13 +
drivers/staging/lustre/lustre/libcfs/linux/linux-module.c | 2 --
drivers/
Hello Julian.
On 2015년 08월 10일 15:47, Julian Calaby wrote:
Hi Tony and Johnny,
On Mon, Aug 10, 2015 at 3:58 PM, Tony Cho wrote:
From: Johnny Kim
The driver communicates with the chipset via the address of handlers
to distinguish async data frame. The SendConfigPkt function gets the
pointer
62 matches
Mail list logo
