Re: [PATCHv4 2/6] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings

2015-08-03 Thread Sudip Mukherjee
On Mon, Aug 03, 2015 at 11:22:35PM +0200, Adrian Remonda wrote: > This patch fixes the warning generated by sparse: "Using plain integer > as NULL pointer" by replacing the offending 0 with NULL. > > Signed-off-by: Adrian Remonda > --- This patch will not apply because of 7ac5c9f0a022 ("Staging:

Re: [PATCH 25/28] staging: wilc1000: change cast type from pointer to uintptr_t

2015-08-03 Thread tony . cho
Hi Greg, I'm scheduled to send new patch not using casting between a pointer and integer type. Rewriting the driver to change how to communicate with the firmware has been already started for the second patch but it takes more days. Thanks for your advice, Tony. On 2015년 08월 01일 05:50, Gre

[PATCH] staging: rtl8723au: fix up coding style warnings reported by checkpatch.pl.

2015-08-03 Thread Ting-Chih Hsiao
remove spaces at the start of a line align enum variable with other parameters Signed-off-by: Ting-Chih Hsiao --- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c b/drivers/s

Re: [PATCH] ion: Handle the memory mapping correctly on x86

2015-08-03 Thread Greg KH
On Tue, Aug 04, 2015 at 12:21:35AM +, Radhakrishna, Pradeep wrote: > >From b4069e7fe1b2aa1660b3f944e246c13b4947db21 Mon Sep 17 00:00:00 2001 > From: Zhebin Jin > Date: Wed, 8 Jul 2015 10:35:06 +0800 > Subject: [PATCH] ion: Handle the memory mapping correctly on x86 Why is all of this here in

[PATCH 2/2] staging/lustre: Properly reference kthread_run instead of cfs_daemonize

2015-08-03 Thread green
From: Oleg Drokin cfs_daemonize is long gone and replaced by a proper call to kthread_run, so update the comment to reflect that fact. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

[PATCH 0/2] Lustre: remove cfs_daemonize from comments

2015-08-03 Thread green
From: Oleg Drokin cfs_daemonize was removed long ago, but I just stumbled upon a couple of instances where it was still referenced in the comments, so here are the patches to clean it up and not cause any unnecessary confusion. Oleg Drokin (2): staging/lustre/ptlrpc: Remove stray daemonize com

[PATCH 1/2] staging/lustre/ptlrpc: Remove stray cfs_daemonize comment

2015-08-03 Thread green
From: Oleg Drokin Ever since daemonize was removed in 3.18, there are no longer any flags passed to kthread_run. Most of the comments were deleted, but this one lingered on until now. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/pinger.c | 2 -- 1 file changed, 2 deletio

Re: [PATCH 2/2] staging: unisys: visornic: Convert to using napi

2015-08-03 Thread Greg KH
On Fri, Jul 31, 2015 at 06:56:33PM -0400, Benjamin Romer wrote: > From: Neil Horman > > Switch the visornic over to use napi. Currently there is a kernel > thread > that sits and waits on a wait queue to get notified of incoming virtual > interrupts. It would be nice if we could handle frame rec

Re: [PATCH 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions

2015-08-03 Thread Greg KH
On Sun, Aug 02, 2015 at 09:23:51PM +0530, Chandra S Gorentla wrote: > Added 'void' keyword in the paranthesis of function definitions, when > there are no arguments to the functions. This fixes the checkpatch.pl > error - "Bad function definition 'function()' should probably be > function(void)".

Re: [PATCH] Staging : lustre :Replace comma with a semicolon

2015-08-03 Thread Greg Kroah-Hartman
On Mon, Aug 03, 2015 at 09:22:51PM +0530, Shraddha Barke wrote: > Should I resend the patches? > You have sent a bunch of patches, and I don't know what order to apply them in, or what ones should be applied and which should not. So please resend all of the outstanding patches that I have not ap

[PATCH] ion: Handle the memory mapping correctly on x86

2015-08-03 Thread Radhakrishna, Pradeep
>From b4069e7fe1b2aa1660b3f944e246c13b4947db21 Mon Sep 17 00:00:00 2001 From: Zhebin Jin Date: Wed, 8 Jul 2015 10:35:06 +0800 Subject: [PATCH] ion: Handle the memory mapping correctly on x86 This patch modifies the ion page pool code to address limitation in x86 PAT. That is, when one physical pa

Re: [PATCH] Fixed C99 style comment to C89 style.

2015-08-03 Thread Greg KH
On Mon, Aug 03, 2015 at 11:13:02PM +0300, Lior Pugatch wrote: > Patch created to satisfy checkpatch.pl > and fix possible compilation problems. Please fix up your subject line to say what part of the kernel you are modifying, as well as the driver. Look at the other patches for this driver for e

[PATCHv4 4/6] Staging: most: hdm-dim2/dim2_hal.c. Fix "Using plain integer as NULL pointer" warnings

2015-08-03 Thread Adrian Remonda
This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm-

[PATCHv4 1/6] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings

2015-08-03 Thread Adrian Remonda
This is a patch to the mostcore/core.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/stag

[PATCHv4 5/6] Staging: most: aim-cdev/cdev.c. Fix "missing static keyword" warnings

2015-08-03 Thread Adrian Remonda
This is a patch to the most/aim_cdev.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/aim-cdev/cdev.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/

[PATCHv4 3/6] Staging: most: hdm-usb/hdm_usb.c. Fix "missing static keyword" warnings

2015-08-03 Thread Adrian Remonda
This is a patch to the most/hdm-usb/hdm_usb.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-usb/hdm_usb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/

[PATCHv4 6/6] Staging: most: aim-network/networking.c. Fix "Using plain integer as NULL pointer" warnings

2015-08-03 Thread Adrian Remonda
This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/aim-network/networking.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/

[PATCHv4 2/6] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings

2015-08-03 Thread Adrian Remonda
This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcore

[PATCHv4 0/6] Staging: most: several warnings fix reported by sparse

2015-08-03 Thread Adrian Remonda
This patch series fix several warnings reported by the Sparse tool v2: Fixed patch format and comments as noted by Greg Kroah-Hartman and clear a few more warnings v3: Fixed patch format as noted by Greg Kroah-Hartman v4: Fixed patch format as noted by Greg Kr

Re: [PATCHv3 0/6] Staging: most: several warnings fix reported by sparse

2015-08-03 Thread AdrianRemonda
On Mon, Aug 03, 2015 at 11:30:18AM +0300, Dan Carpenter wrote: > The subjects still are not unique. Greg said this earlier. > > If you want just do it in two patches. > > [patch 1] add static > [patch 2] use NULL instead of zero > > regards, > dan carpenter > Yes, sorry. I totally messed it u

[PATCH] Fixed C99 style comment to C89 style.

2015-08-03 Thread Lior Pugatch
Patch created to satisfy checkpatch.pl and fix possible compilation problems. Signed-off-by: Lior Pugatch --- drivers/staging/vt6655/rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h index b9bd163..54694df 10

RE: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

2015-08-03 Thread Thomas Gleixner
On Mon, 3 Aug 2015, Jake Oshins wrote: > I do have a question about your last point, though. If I build this > into the kernel, it will need to depend on sending and receiving > messages through the hv_vmbus driver, which isn't built in. It Fair enough. I missed that detail. > seemed like the

RE: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

2015-08-03 Thread Jake Oshins
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Sunday, August 2, 2015 1:47 AM > To: Jake Oshins > Cc: gre...@linuxfoundation.org; KY Srinivasan ; LKML > ; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; linux- > p..

Re: [PATCH -next] staging: most: fix aim-sound build errors

2015-08-03 Thread Christian Gromm
cm_lib_get_vmalloc_page' > > Signed-off-by: Randy Dunlap Acked-by: Christian Gromm > Cc: Christian Gromm > --- > drivers/staging/most/aim-sound/Kconfig |1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20150803.orig/drivers/staging/most/aim-sou

[PATCH -next] staging: most: fix hdm-dim2 build error

2015-08-03 Thread Randy Dunlap
ce to `most_deliver_netinfo' Signed-off-by: Randy Dunlap Cc: Jain Roy Ambi Cc: Andrey Shvetsov --- drivers/staging/most/hdm-dim2/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-next-20150803.orig/drivers/staging/most/hdm-dim2/Kconfig +++ linux-next-20150803/drivers/st

[PATCH -next] staging: most: fix aim-sound build errors

2015-08-03 Thread Randy Dunlap
ndefined reference to `snd_pcm_lib_ioctl' drivers/built-in.o:(.data+0x95318): undefined reference to `snd_pcm_lib_get_vmalloc_page' Signed-off-by: Randy Dunlap Cc: Christian Gromm --- drivers/staging/most/aim-sound/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux-next-2015080

Re: vme_ca91cx42 doesn't touch VMEbus on read with vme_user

2015-08-03 Thread Eisch, Jonathan D [PHYSA]
Sorry for the noise, everyone. I swapped the CF card to another board and everything works perfectly. It must be a hardware problem somewhere. Thanks again to Dmitry for suggesting the board driver. -Jonathan > On Aug 3, 2015, at 12:25 PM, Eisch, Jonathan D [PHYSA] > wrote: > > Hello Dmitr

Re: vme_ca91cx42 doesn't touch VMEbus on read with vme_user

2015-08-03 Thread Eisch, Jonathan D [PHYSA]
Hello Dmitry, I hadn’t tried that, but the VME7807 has the same configuration registers so I should have. I am able to load that driver successfully, and I’ve checked to make sure the registers are the correct, but it doesn’t change the behavior of the board. I still don’t get any access to t

Re: [PATCH 4/6] drivers, staging, unisys Add visorbus module autoloading code

2015-08-03 Thread Prarit Bhargava
On 07/31/2015 07:07 PM, Greg KH wrote:> On Fri, Jul 24, 2015 at 12:06:54PM -0400, Benjamin Romer wrote: >> From: Prarit Bhargava >> >> This patch adds an module alias and a MODULE_DEVICE_TABLE to autoload the >> visorhba driver when an appropriate device is created by the visorbus. >> >> Signed-

[PATCH] Staging: lustre: Replace comma with a semicolon

2015-08-03 Thread Shraddha Barke
Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: about ENOSYS

2015-08-03 Thread Greg Kroah-Hartman
On Mon, Aug 03, 2015 at 06:41:22AM +, Drokin, Oleg wrote: > subject have been missing, so I filled in something. > > On Aug 3, 2015, at 2:18 AM, Shraddha Barke wrote: > > > From b67c6c20455b04b77447ab4561e44f1a75dd978d Mon Sep 17 00:00:00 2001 > > From: Shraddha Barke > > Date: Mon, 3 Aug 20

[PATCH] Staging: lustre: Code Indentation

2015-08-03 Thread Shraddha Barke
Correct indentation issues according to checkpatch.pl : WARNING: suspect code indent for conditional statements Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/llite/rw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/

Re: [PATCH] Staging : lustre :Replace comma with a semicolon

2015-08-03 Thread Greg Kroah-Hartman
On Mon, Aug 03, 2015 at 09:22:51PM +0530, Shraddha Barke wrote: > Should I resend the patches? > Why wouldn't you? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging : lustre :Replace comma with a semicolon

2015-08-03 Thread Dan Carpenter
The spacing in the subject lines is whacky. -Subject: [PATCH] Staging : lustre :Replace comma with a semicolon +Subject: [PATCH] Staging: lustre: Replace comma with a semicolon regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

[PATCH] Staging : netlogic : Replace comma with a semicolon

2015-08-03 Thread Shraddha Barke
Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; Signed-off-by: Shraddha Barke --- drivers/staging/netlogic/platform_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] Staging : lustre :Replace comma with a semicolon

2015-08-03 Thread Shraddha Barke
Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] Staging : lustre :Replace comma with a semicolon

2015-08-03 Thread Shraddha Barke
Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH] Staging : lustre : Code Indentation

2015-08-03 Thread Shraddha Barke
Correct indentation issues according to checkpatch.pl : WARNING: suspect code indent for conditional statements Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/llite/rw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/

[PATCH] Staging : lustre :Drop unnecessary cast

2015-08-03 Thread Shraddha Barke
This patch does away with the cast on void * as it is unnecessary. Semantic patch used is as follows: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/obdclass/lin

Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

2015-08-03 Thread Dave Hansen
On 08/02/2015 10:53 PM, Wang, Biao wrote: > Consider the following case: > Task A trigger lmk with a lock held, while task B try to > get this lock, but unfortunately B is the very culprit task lmk select to > kill. Then B will never be killed, and A will forever select B to kill. > Such dead lock

Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 15:09 +0300, Dan Carpenter wrote: > On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote: > > On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote: > > > On Mon, Aug 03, 2015 at 11:18:31AM +, Shah, Yash (Y.) wrote: > > > > From: Yash Shah > > > > > > > > Fixed c

Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl

2015-08-03 Thread Dan Carpenter
On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote: > On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote: > > On Mon, Aug 03, 2015 at 11:18:31AM +, Shah, Yash (Y.) wrote: > > > From: Yash Shah > > > > > > Fixed code indentation warning as detected by checkpatch.pl. > > > > > > S

Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote: > On Mon, Aug 03, 2015 at 11:18:31AM +, Shah, Yash (Y.) wrote: > > From: Yash Shah > > > > Fixed code indentation warning as detected by checkpatch.pl. > > > > Signed-off-by: Yash Shah > > Defines aren't allowed in .c files anyway. T

[PATCH] Staging: most: avoid possible integer overflow

2015-08-03 Thread Christian Gromm
This patch prevents a potential integer overlow. Reported-by: Dan Carpenter Signed-off-by: Christian Gromm --- drivers/staging/most/mostcore/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c

Urgent Mail

2015-08-03 Thread MirroSaver
Hello, I seek for your sincerity and trust in a deal which involved the total sum of 60,000,000.00 United States Dollars Only, Let me know if you will able to handle such transaction of large funds. I need to know you and know your location. This really matter to the success of this deal.If in

Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl

2015-08-03 Thread Dan Carpenter
On Mon, Aug 03, 2015 at 11:18:31AM +, Shah, Yash (Y.) wrote: > From: Yash Shah > > Fixed code indentation warning as detected by checkpatch.pl. > > Signed-off-by: Yash Shah Defines aren't allowed in .c files anyway. regards, dan carpenter ___ d

[PATCH] Staging: rtl8188eu/core: fixed code indentation warning as reported by checkpatch.pl

2015-08-03 Thread Bareja, Mayank (M.)
from: Mayank Bareja fixed code indentation warning as detected with checkpatch.pl. Replaced spaces with tabs. Signed-off-by: Mayank Bareja --- drivers/staging/rtl8188eu/core/rtw_debug.c|4 +-- drivers/staging/rtl8188eu/core/rtw_efuse.c|2 +- drivers/staging/rtl8188eu/core/rtw_m

[PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl

2015-08-03 Thread Shah, Yash (Y.)
From: Yash Shah Fixed code indentation warning as detected by checkpatch.pl. Signed-off-by: Yash Shah --- drivers/staging/rts5208/ms.c | 5 ++--- drivers/staging/rts5208/sd.c | 10 -- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rts5208/ms.c b/drivers

Greeting from U.S Embassy,

2015-08-03 Thread U.S EMBASSY
American Embassy Department United States 01BP 2012 Cotonou Benin Rep. Greeting from U.S Embassy, THIS MAIL IS ONLY FOR THE OWNER OF THIS E-MAIL ADDRESS Hello:Beneficiary, Please i want to inform you that your fund was brought to my desk this morning because the SECRETARY OF UNITED NATION here

Re: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

2015-08-03 Thread Dan Carpenter
On Mon, Aug 03, 2015 at 11:18:12AM +0200, Paul Bolle wrote: > On zo, 2015-08-02 at 00:54 +, ja...@microsoft.com wrote: > > --- /dev/null > > +++ b/drivers/pci/host/hv_pcifront.c > > > +static void exit_hv_pci_drv(void) > > +{ > > + vmbus_driver_unregister(&hv_pci_drv); > > +} > > + > > +stat

Re: [PATCHv3 3/6] Staging: most: Fix "missing static keyword" warnings

2015-08-03 Thread Christian Gromm
On Mon, 3 Aug 2015 09:40:24 +0200 Adrian Remonda wrote: > This is a patch to the most/hdm-usb/hdm_usb.c file. It > makes several local functions and structures static to prevent global > visibility. > > Signed-off-by: Adrian Remonda > --- > drivers/staging/most/hdm-usb/hdm_usb.c | 14 +++-

Re: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

2015-08-03 Thread Paul Bolle
On zo, 2015-08-02 at 00:54 +, ja...@microsoft.com wrote: > --- /dev/null > +++ b/drivers/pci/host/hv_pcifront.c > +static void exit_hv_pci_drv(void) > +{ > + vmbus_driver_unregister(&hv_pci_drv); > +} > + > +static int __init init_hv_pci_drv(void) > +{ > + int ret; > + > + /* Regis

Re: [PATCHv3 0/6] Staging: most: several warnings fix reported by sparse

2015-08-03 Thread Dan Carpenter
The subjects still are not unique. Greg said this earlier. If you want just do it in two patches. [patch 1] add static [patch 2] use NULL instead of zero regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linu

[PATCH V3] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

2015-08-03 Thread Wang, Biao
Consider the following case: Task A trigger lmk with a lock held, while task B try to get this lock, but unfortunately B is the very culprit task lmk select to kill. Then B will never be killed, and A will forever select B to kill. Such dead lock will trigger softlock up issue. This patch try to

Re: [PATCH 1/2] staging:media:lirc Remove the extra braces in if statement of lirc_imon

2015-08-03 Thread Dan Carpenter
Normally, I wait overnight between writing a patch and sending it. There is no rush and the delay helps me to be more careful. The subject is still not perfect. Do: git log --oneline drivers/staging/media/lirc/lirc_imon.c On Mon, Aug 03, 2015 at 02:56:31AM -0500, Pradheep Shrinivasan wr

Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 09:15 +0300, Dan Carpenter wrote: > On Mon, Aug 03, 2015 at 05:53:22AM +, Wang, Biao wrote: > > Consider the following case: > > Task A trigger lmk with a lock held, while task B try to > > get this lock, but unfortunately B is the very culprit task lmk > > select to > >

[PATCH 2/2] staging:media:lirc This fix changes the spaces to tab in lirc_sasem.c

2015-08-03 Thread Pradheep Shrinivasan
This fix changes the space in the code to tab to fix the ERROR "ERROR: code indent should use tabs where possible" Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_sasem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_s

[PATCH 1/2] staging:media:lirc Remove the extra braces in if statement of lirc_imon

2015-08-03 Thread Pradheep Shrinivasan
From: pradheep This patche removes the extra braces found in drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by checkpatch.pl Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_imon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

[PATCH 2/2] staging:media:lirc This fix changes the spaces to tab in lirc_sasem.c

2015-08-03 Thread Pradheep Shrinivasan
This fix changes the space in the code to tab to fix the ERROR "ERROR: code indent should use tabs where possible" Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_sasem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_s

[PATCH 1/2] staging:media:lirc Remove the extra braces in if statement of lirc_imon

2015-08-03 Thread Pradheep Shrinivasan
From: pradheep This patche removes the extra braces found in drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by checkpatch.pl Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_imon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

[PATCHv3 6/6] Staging: most: Fix "Using plain integer as NULL pointer" warnings

2015-08-03 Thread Adrian Remonda
This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/aim-network/networking.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/

[PATCHv3 4/6] Staging: most: Fix "Using plain integer as NULL pointer" warnings

2015-08-03 Thread Adrian Remonda
This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm

[PATCHv3 1/6] Staging: most: Fix "missing static keyword" warnings

2015-08-03 Thread Adrian Remonda
This is a patch to the mostcore/core.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/stag

[PATCHv3 2/6] Staging: most: Fix "Using plain integer as NULL pointer" warnings

2015-08-03 Thread Adrian Remonda
This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcor

[PATCHv3 3/6] Staging: most: Fix "missing static keyword" warnings

2015-08-03 Thread Adrian Remonda
This is a patch to the most/hdm-usb/hdm_usb.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-usb/hdm_usb.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dr

[PATCHv3 0/6] Staging: most: several warnings fix reported by sparse

2015-08-03 Thread Adrian Remonda
This patch series fix several warnings reported by the Sparse tool v2: Fixed patch format and comments as noted by Greg Kroah-Hartman and clear a few more warnings v3: Fixed patch format as noted by Greg Kroah-Hartman Adrian Remonda (6): Staging: most: Fix "missin

[PATCHv3 5/6] Staging: most: Fix "missing static keyword" warnings

2015-08-03 Thread Adrian Remonda
This is a patch to the most/aim_cdev.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/aim-cdev/cdev.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/stag

Re: [PATCH 1/2] Remove the extra braces in if statement of lirc_imon

2015-08-03 Thread Dan Carpenter
Oh. Also these patches have to go to linux-me...@vger.kernel.org. We will just ignore them on the de...@driverdev.osuosl.org list. Use scripts/get_maintainer.pl to find the correct mailing lists. regards, dan carpenter ___ devel mailing list de...@li

Re: [PATCH 1/2] Remove the extra braces in if statement of lirc_imon

2015-08-03 Thread Dan Carpenter
Fix the subject line (look at other patches to see how it is done). On Mon, Aug 03, 2015 at 02:15:55AM -0500, Pradheep Shrinivasan wrote: > From: pradheep Fix your git config to not include this. regards, dan carpenter ___ devel mailing list de...@li

Re: your mail

2015-08-03 Thread Dan Carpenter
Returning EINVAL here is the wrong thing. Just leave the code as is. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/2] Remove the extra braces in if statement of lirc_imon

2015-08-03 Thread Pradheep Shrinivasan
From: pradheep This patche removes the extra braces found in drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by checkpatch.pl Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_imon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

[PATCH 2/2] This fix changes the spaces to tab in lirc_sasem.c

2015-08-03 Thread Pradheep Shrinivasan
This fix changes the space in the code to tab to fix the ERROR "ERROR: code indent should use tabs where possible" Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_sasem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_s

Re: [PATCH] Staging : lustre: Struct file_operations should be const

2015-08-03 Thread Sudip Mukherjee
On Mon, Aug 03, 2015 at 11:17:06AM +0530, Shraddha Barke wrote: > Declare the file_operations structure ll_file_operations as const, as done > elsewhere in the kernel, as there are no modifications to its fields. > > Problem found using checkpatch: > > WARNING: struct file_operations should norma

Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

2015-08-03 Thread Dan Carpenter
On Mon, Aug 03, 2015 at 09:15:56AM +0300, Dan Carpenter wrote: > > Reviewed-by: Dan Carpenter > > I don't really feel comfortable saying I reviewed this code. I just > commented on a few process issues. I don't know the subsystem well > enough to give it a seal of approval. > Biao was asking

Re: your mail

2015-08-03 Thread Sudip Mukherjee
On Mon, Aug 03, 2015 at 11:48:59AM +0530, Shraddha Barke wrote: > From b67c6c20455b04b77447ab4561e44f1a75dd978d Mon Sep 17 00:00:00 2001 > From: Shraddha Barke > Date: Mon, 3 Aug 2015 11:34:19 +0530 > Subject: [PATCH] Staging : lustre : Use -EINVAL instead of -ENOSYS You do not need these in the

[PATCH] Staging : lustre :Remove typedef from struct names

2015-08-03 Thread Shraddha Barke
The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedefs for cfs_wi_sched. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case: