On Fri, 2015-07-31 at 11:02 +0530, Shraddha Barke wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: do not add new typedefs
> Signed-off-by: Shraddha Barke
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> d
This patch fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
Signed-off-by: Shraddha Barke
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging
This patch fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
Signed-off-by: Shraddha Barke
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/
On 31 Jul 2015 10:49, "Shraddha Barke" wrote:
>
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: braces {} are not necessary for single statement blocks
There should be one line space between your commit log
and Signed-off-by line.
> Signed-off-by: Shraddha Barke
> ---
> dr
This patch fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Shraddha Barke
---
drivers/staging/wilc1000/coreconfigurator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/
This patch fixes the following checkpatch.pl warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Shraddha Barke
---
drivers/staging/wilc1000/coreconfigurator.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/cor
Hi Greg,
I understand what you mention. I will first make it.
The 5 patches among the first series of patch was rejected and the 2nd patch
also has a problem. As you said, I will resend them later after
removing build warnings. They will be delivered soon.
Thanks,
Tony.
On 2015년 07월 31일 12
On Thu, Jul 30, 2015 at 06:10:09PM +0900, Tony Cho wrote:
> This patch V2 includes only patches rejected. The rejected patch for the
> following, #ifdef conditionals cover entire functions, introduced new error on
> required space before the open parenthesis '('. This is my mistake while
> rewritin
On Fri, Jul 31, 2015 at 12:27:04PM +0900, tony.cho wrote:
>
>
> On 2015년 07월 30일 20:56, Sudip Mukherjee wrote:
> >On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote:
> >>This patch lets preprocessor conditionals (#ifdef) related to
> >>WILC_SDIO_IRQ_GPIO to compile out the entire functions.
On 2015년 07월 30일 20:56, Sudip Mukherjee wrote:
On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote:
This patch lets preprocessor conditionals (#ifdef) related to
WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out
the entire functions is preferred rather than portions of
On 2015년 07월 30일 20:56, Sudip Mukherjee wrote:
On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote:
This patch lets preprocessor conditionals (#ifdef) related to
WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out
the entire functions is preferred rather than portions of
From: Oleg Drokin
New writeback changes in 4.2-RC1 have exposed that we incorrectly
set page_writeback on a page that is being written synchronously,
which aside from this new crash (dereference of NULL inode->i_wb
from set_page_writeback) likely threw off some related page
statistics in the past
From: Oleg Drokin
SEEK_DATA and SEEK_HOLE are always defined in the kernel,
drop the definition checks
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/linux/lustre_compat25.h | 38 --
1 file changed, 38 deletions(-)
diff --git a/drivers/staging/lustre/lustre/incl
From: Oleg Drokin
Get rid of ll_d_hlist* compat defines.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 9 -
drivers/staging/lustre/lustre/llite/dcache.c | 3 +--
drivers/staging/lustre/lustre/llite/namei.c
From: Oleg Drokin
This replaces cfs_bio_io_error with direct calls to bio_io_error
and cfs_bio_end_io with bio_end_io
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 4
drivers/staging/lustre/lustre/llite/lloop.c | 4 ++--
2
From: Oleg Drokin
It's not really used anywhere.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
b/drivers/staging/lustre/lustre/in
From: Oleg Drokin
Remove ATTR_TIMES_SET check as it's always present, move
the mask of times define close to where it's used.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 6 --
drivers/staging/lustre/lustre/llite/llite_lib.c |
From: Oleg Drokin
They are noop anyways.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 5 -
drivers/staging/lustre/lustre/llite/dir.c | 4
2 files changed, 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/i
From: Oleg Drokin
These primitives are long deprecated and unused.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 5 -
drivers/staging/lustre/lustre/llite/llite_lib.c | 5 +
drivers/staging/lustre/lustre/llite/vvp_io.c
From: Oleg Drokin
This patchset is a stroll through lustre/include/linux/lustre_compat25.h
that houses a bunch of our "compatibility with old/new kernels"
code and gettign rid of everything that we know for granted is available
because we are part of the tree.
These are the low hanging fruit, th
From: Oleg Drokin
ATTR_RAW is unused.
No point in redefining ATTR_OPEN as ATTR_FROM_OPEN
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/linux/lustre_patchless_compat.h| 12
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 2 +-
2 files changed, 1 inser
From: Oleg Drokin
umode_t is what we need anyway, so replace all users
and drop the define.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 6 --
drivers/staging/lustre/lustre/llite/namei.c | 2 +-
2 files changed, 1 insertio
From: Oleg Drokin
Lustre defines quite a bit of those compatibility defines
duplicating kernel vfs api, but they are not actually used
in the client so remove them all and also ll_dirty_inode,
ll_security_inode_unlink and cfs_path_put
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/li
From: Oleg Drokin
queue_max_phys_segments, queue_max_hw_segments and bio_hw_segments
are not used anywhere in the client code, so remove them
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/dr
From: Oleg Drokin
SLAB_DESTROY_BY_RCU is always defined in kernel slab.h, so
no point in checking for it.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/
From: Oleg Drokin
FS_HAS_FIEMAP was some sort of old RHEL5 construct that's not
really important anymore
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 5 -
drivers/staging/lustre/lustre/obdclass/obd_mount.c| 2 +-
2 files changed
Card configuration is stored in SPI EEPROM (93c46 or 93c56)
working in 128|256x16 mode.
Communication is handled using GPIO bitbang.
>From behaviour perspective, delay after read was removed.
It is not needed as we wait after reading GPIO mapped to
PCI-E register - it should have no side effects.
This patch is fixed version of RFC patch with the same subject:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-July/073860.html
Changes:
- Functions *gpio_set and *gpio_get changed as suggested by Dan
- Changed commit msg
Changes that were NOT made:
- I kept _rtl92e_ prefix
Pass platform_data as an argument to fbtft_framebuffer_alloc()
instead of using dev->platform_data.
This fixes an issue where the device comes from Device Tree
and fbtft_probe_common() sets dev->platform_data to allocated
memory. When the module is reloaded, dev->platform_data points
to freed memo
This patch replaces pr_*() functions with dev_*().
Reported-by: Greg Kroah-Hartman
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-usb/hdm_usb.c | 116
1 file changed, 59 insertions(+), 57 deletions(-)
diff --git a/drivers/staging/most/hdm-usb/hdm_
This patch fixes error "doing DMA on the stack" by using kzalloc
for buffer allocation.
Reported-by: Dan Carpenter
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-usb/hdm_usb.c | 36
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/d
On Thu, 2015-07-30 at 13:09 +0300, Dan Carpenter wrote:
> > diff --git a/drivers/staging/android/lowmemorykiller.c
> > b/drivers/staging/android/lowmemorykiller.c
[]
> > @@ -127,11 +127,15 @@ static unsigned long lowmem_scan(struct shrinker *s,
> > struct shrink_control *sc)
> > if (!
On Thu, Jul 30, 2015 at 07:40:14AM -0700, Greg KH wrote:
> On Thu, Jul 30, 2015 at 11:41:46AM +0300, Dan Carpenter wrote:
> > On Thu, Jul 30, 2015 at 10:31:04AM +0200, Mateusz Kulikowski wrote:
> > > As for other comments - could you take look at "Notes" from patch?
> > > This was one of main conce
On Thu, Jul 30, 2015 at 11:41:46AM +0300, Dan Carpenter wrote:
> On Thu, Jul 30, 2015 at 10:31:04AM +0200, Mateusz Kulikowski wrote:
> > As for other comments - could you take look at "Notes" from patch?
> > This was one of main concerns for me - Wouldn't it be better
> > if I rewrite that code to
On Thu, Jul 30, 2015 at 03:31:38PM +0200, Christian Gromm wrote:
> This patch fixes error "doing DMA on the stack" by using kzalloc
> for buffer allocation.
>
> Reported-by: Dan Carpenter
> Signed-off-by: Christian Gromm
> ---
> drivers/staging/most/hdm-usb/hdm_usb.c | 39
> +
Hi,
On Thu, Jul 30, 2015 at 09:15:38AM +0200, Robert Baldyga wrote:
> On 07/29/2015 05:20 PM, Felipe Balbi wrote:
> > On Mon, Jul 27, 2015 at 11:16:14AM +0200, Robert Baldyga wrote:
> >> Convert endpoint configuration to new capabilities model.
> >>
> >> Fixed typo in "epc-nulk" to "epc-bulk".
> >
This patch fixes double unlocking of a spinlock the aim-v4l2 module.
Reported-by: Dan Carpenter
Signed-off-by: Christian Gromm
Signed-off-by: Andrey Shvetsov
---
drivers/staging/most/aim-v4l2/video.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/aim-v4l2/video.c
This patch fixes error "doing DMA on the stack" by using kzalloc
for buffer allocation.
Reported-by: Dan Carpenter
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-usb/hdm_usb.c | 39 +---
1 file changed, 26 insertions(+), 13 deletions(-)
diff --git a/d
This patch fixes wrong casting.
Reported-by: Dan Carpenter
Signed-off-by: Christian Gromm
---
drivers/staging/most/mostcore/core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/most/mostcore/core.c
b/drivers/staging/most/mostcore/core.c
index 49d03a
On Thu, Jul 30, 2015 at 09:03:48PM +0900, Chaehyun Lim wrote:
> On Thu, Jul 30, 2015 at 8:41 PM, Chaehyun Lim wrote:
> >
> > First patch has 4 sites of kmalloc change in coreconfigurator.c
> > First one, it is used for gps8ConfigPacket at CoreconfiguratorInit and
> > CoreConfiguratorDeInit.
> > I
On Thu, Jul 30, 2015 at 06:10:12PM +0900, Tony Cho wrote:
> This patch removes the warnings reported by checkpatch.pl on missing
> a blank line after declarations.
>
> Signed-off-by: Tony Cho
> ---
> V2: This patch doesn't have a difference with the first one. However,
> it's resent becasue not a
I'm sorry that I have mistake the number of kmalloc changes. The total
change is 6, not 4.
On Thu, Jul 30, 2015 at 8:41 PM, Chaehyun Lim wrote:
> Hi, Greg
>
> I'm sorry that I did not say whether GFP_ATOMIC should be used or not.
> This is my review on it. If it's not correct, please give me any
On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote:
> This patch lets preprocessor conditionals (#ifdef) related to
> WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out
> the entire functions is preferred rather than portions of functions or
> expressions becausue doing so
Hi, Greg
I'm sorry that I did not say whether GFP_ATOMIC should be used or not.
This is my review on it. If it's not correct, please give me any comment or
direction.
First patch has 4 sites of kmalloc change in coreconfigurator.c
First one, it is used for gps8ConfigPacket at CoreconfiguratorIni
Add error check if memory allocation is failed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/wilc1000/coreconfigurator.c
index 37e09b8..
Return -ENOMEM if memory allocation is failed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/wilc1000/coreconfigurator.c
Use kmalloc and kmalloc_array instead of WILC_MALLOC.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/wilc1000/coreconfigur
> From: David Miller
> Sent: Thursday, July 30, 2015 6:27
>
> From: Dexuan Cui
> Date: Tue, 28 Jul 2015 05:35:11 -0700
>
> > With the 2 APIs supplied by the VMBus driver, the coming net/hvsock driver
> > can register 2 callbacks and can know when a new hvsock connection is
> > offered by the host
> From: David Miller
> Sent: Thursday, July 30, 2015 6:28
> >From: Dexuan Cui
> >Date: Tue, 28 Jul 2015 05:35:23 -0700
> >
> > +/* hvsock_release() can be invoked in 2 paths:
> > + * 1. on process termination:
> > + * hvsock_sk_destruct+0x1a/0x20
> > + * __sk_free+0x1d/0x130
> > + * sk_free+0x19/0x
> From: David Miller
> Sent: Thursday, July 30, 2015 6:28
> > From: Dexuan Cui
> > Date: Tue, 28 Jul 2015 05:35:30 -0700
> >
> > In the SMP guest case, when the per-channel callback hvsock_events() is
> > running on virtual CPU A, if the guest tries to close the connection on
> > virtual CPU B: we
I'm not an android dev but this patch seems reasonable enough. There
are some process issues though.
1) The subject should have a subsystem prefix:
[PATCH] Staing: android: lowmemorykiller: improve lmk to avoid deadlock issue
On Thu, Jul 30, 2015 at 06:49:53AM +, Wang, Biao wrote:
> From:
On 29/07/15 22:36, Dan Carpenter wrote:
We checked that "it->options[3]" was non-zero on the line before so
there is no need to check again.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/comedi/drivers/das16.c
b/drivers/staging/comedi/drivers/das16.c
index d7cf4b1..056bca9 100644
This patch removes the dead functions which are not used anymore.
- sdio_check_bs
- sdio_xfer_cnt
Signed-off-by: Tony Cho
---
V2: This patch doesn't have any difference with the first patch becasue
this patch just removes unnecessary functions. However, it is resent
because it's n
This patch lets preprocessor conditionals (#ifdef) related to
WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out
the entire functions is preferred rather than portions of functions or
expressions becausue doing so makes code harder to read.
Signed-off-by: Tony Cho
---
V2: Remov
This patch removes the errors reported by checkpatch.pl, which is the
space required before the open parenthesis '('.
Signed-off-by: Tony Cho
---
V2: This patch is not different with the first one. This patch includes
warnings on no space required before the open parenthesis in the
function, sdio
This patch removes the warnings reported by checkpatch.pl on missing
a blank line after declarations.
Signed-off-by: Tony Cho
---
V2: This patch doesn't have a difference with the first one. However,
it's resent becasue not accepted with the 9th patch.
---
drivers/staging/wilc1000/wilc_sdio.c |
This patch removes the following warnings reported by checkpatch.pl.
- Blank lines aren't necessary after an open brace '{'
- Blank lines aren't necessary before a close brace '}'
Signed-off-by: Tony Cho
---
V2: This patch doesn't have a difference with the first one but resent
because it's rejec
This patch V2 includes only patches rejected. The rejected patch for the
following, #ifdef conditionals cover entire functions, introduced new error on
required space before the open parenthesis '('. This is my mistake while
rewriting codes.
The original 13th patch didn't include new fix introduce
On Thu, 30 Jul 2015 11:28:43 +0300
Dan Carpenter wrote:
> On Thu, Jul 30, 2015 at 09:05:39AM +0200, Christian Gromm wrote:
> > On Wed, 29 Jul 2015 11:53:34 +0530
> > Sudip Mukherjee wrote:
> >
> > > On Tue, Jul 28, 2015 at 05:16:09PM +0200, Christian Gromm wrote:
> > > > This patch prevents snp
On Thu, Jul 30, 2015 at 10:31:04AM +0200, Mateusz Kulikowski wrote:
> As for other comments - could you take look at "Notes" from patch?
> This was one of main concerns for me - Wouldn't it be better
> if I rewrite that code to use GPIO/SPI/EEPROM subsystems?
I don't know. Let's just merge this
On Thu, Jul 30, 2015 at 09:18:56AM +0200, walter harms wrote:
>
>
> Am 29.07.2015 23:36, schrieb Dan Carpenter:
> > We checked that "it->options[3]" was non-zero on the line before so
> > there is no need to check again.
> >
> > Signed-off-by: Dan Carpenter
> >
> > diff --git a/drivers/staging
On Wed, Jul 29, 2015 at 02:04:42AM +0300, Dan Carpenter wrote:
> On Tue, Jul 28, 2015 at 11:52:42PM +0200, Mateusz Kulikowski wrote:
>
> > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c
> > b/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c
> > index ed54193..fe4e282 100644
> > --- a/d
On Thu, Jul 30, 2015 at 09:05:39AM +0200, Christian Gromm wrote:
> On Wed, 29 Jul 2015 11:53:34 +0530
> Sudip Mukherjee wrote:
>
> > On Tue, Jul 28, 2015 at 05:16:09PM +0200, Christian Gromm wrote:
> > > This patch prevents snprintf from exceeding a given buffer size.
> > >
> > > Reported-by: Da
Am 29.07.2015 23:36, schrieb Dan Carpenter:
> We checked that "it->options[3]" was non-zero on the line before so
> there is no need to check again.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/staging/comedi/drivers/das16.c
> b/drivers/staging/comedi/drivers/das16.c
> index d7cf
On 07/29/2015 05:20 PM, Felipe Balbi wrote:
> On Mon, Jul 27, 2015 at 11:16:14AM +0200, Robert Baldyga wrote:
>> Convert endpoint configuration to new capabilities model.
>>
>> Fixed typo in "epc-nulk" to "epc-bulk".
>>
>> Signed-off-by: Robert Baldyga
>> ---
>> drivers/staging/emxx_udc/emxx_udc.
On Wed, 29 Jul 2015 11:53:34 +0530
Sudip Mukherjee wrote:
> On Tue, Jul 28, 2015 at 05:16:09PM +0200, Christian Gromm wrote:
> > This patch prevents snprintf from exceeding a given buffer size.
> >
> > Reported-by: Dan Carpenter
> > Signed-off-by: Christian Gromm
> > ---
>
> > - snp
66 matches
Mail list logo
