[PATCH] Staging: rtl8188eu/hal: Fixed code indentation warning detected with checkpatch.pl

2015-07-27 Thread Bareja, Mayank (M.)
>From : Mayank Bareja fixed code indentation warning as reported by checkpatch.pl. Replaced Spaces with Tabs. Signed-off-by: Mayank Bareja --- drivers/staging/rtl8188eu/hal/bb_cfg.c |6 +++--- drivers/staging/rtl8188eu/hal/rf.c |2 +- 2 files changed, 4 insertions(+), 4 deletions(-

Re: [PATCH V3 0/8] clean up wlan_bssdef.h

2015-07-27 Thread Julia Lawall
Something horrible seems to have happened in your patch sending process, and you have the same message over and over. Also, you don't really need to seen the patch to everyone who has ever touched the file. The following arguments can be useful: --nokeywords --nogit --nogit-fallback --norolest

[PATCH V3 4/8] staging: rtl8712: removed unused wrapper structs

2015-07-27 Thread Joshua Clayton
Remove wrapper structs that just wrap struct ndis_wlan_bssid_ex, and are unused. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/rtl871x_cmd.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x

[PATCH V3 3/8] staging: rtl8712: fix comment

2015-07-27 Thread Joshua Clayton
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers

[PATCH V3 1/8] staging: rtl8712: fix buggy size calculation

2015-07-27 Thread Joshua Clayton
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)" where the underlying struct has a 6 * unsigned char. Simplify the calculation by just subtracting the variable part from the size of the struct. This also gets rid of a use of typedef NDIS_802_11_RATES_EX Signed-off-by: Joshua Clay

[PATCH V3 0/8] clean up wlan_bssdef.h

2015-07-27 Thread Joshua Clayton
The main goal of this series is to get rid of a needless typedef in the rtl8712 wlan driver. In the course of fixing that, I found a bug that can (at least in theory) lead to a overrun during a memcpy, as well as an identical struct with a different name, which use the typedef. Finally after clean

[staging:staging-testing 417/422] drivers/staging/most/hdm-dim2/dim2_hdm.c:774:2: error: implicit declaration of function 'ioremap'

2015-07-27 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 6e64e22449023dc89dfb92c6f19d4c5b03f46889 commit: ba3d7ddfb5c6a2529155ac24d7964adba8777419 [417/422] Staging: most: add MOST driver's hdm-dim2 module config: um-allmodconfig (attached as .config) repro

Re: [PATCH v2 5/5] staging: lustre: modified comparisons against NULL

2015-07-27 Thread Dan Carpenter
On Mon, Jul 27, 2015 at 09:20:25PM +0200, Mario Bambagini wrote: > The explicit comparisons against NULL has been modified to be shorter. > > The script checkpatch.pl does not return any other warning/error. > > MB Don't put MB in here. > > Signed-off-by: Mario Bambagini regards, dan carpent

Re: [PATCH v2 3/5] staging: lustre: fix bad alignment

2015-07-27 Thread Dan Carpenter
On Mon, Jul 27, 2015 at 09:20:23PM +0200, Mario Bambagini wrote: > This patch fixes 8 bad alignments. When a line is split on > more than one line, the other lines must be aligned with > paranthesis. > > Signed-off-by: Mario Bambagini I think you wrote this one against your old patch instead of

[PATCH v2 5/5] staging: lustre: modified comparisons against NULL

2015-07-27 Thread Mario Bambagini
The explicit comparisons against NULL has been modified to be shorter. The script checkpatch.pl does not return any other warning/error. MB Signed-off-by: Mario Bambagini --- drivers/staging/lustre/lustre/llite/llite_capa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 4/5] staging: lustre: added a space between concatenated strings

2015-07-27 Thread Mario Bambagini
A space has been inserted between two concatenated strings as required from checkpatch.pl These two updates do not lead to any problem as DFID is defined as a string in ./drivers/staging/lustre/lustre/include/lustre/lustre_user.h Signed-off-by: Mario Bambagini --- drivers/staging/lustre/lustre

[PATCH v2 3/5] staging: lustre: fix bad alignment

2015-07-27 Thread Mario Bambagini
This patch fixes 8 bad alignments. When a line is split on more than one line, the other lines must be aligned with paranthesis. Signed-off-by: Mario Bambagini --- drivers/staging/lustre/lustre/llite/llite_capa.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH v2 2/5] staging: lustre: fixed 80-char rule

2015-07-27 Thread Mario Bambagini
This patch fixes 2 lines longer than 80 chars The first one is a function whose argument has been moved to next line. The second one is a comment split on two lines Signed-off-by: Mario Bambagini --- drivers/staging/lustre/lustre/llite/llite_capa.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH v2 1/5] staging: lustre: fixed comments without */ on a separate line

2015-07-27 Thread Mario Bambagini
this set of patches fixes several code style problems: -patch 1: comments without */ on a separate line -patch 2: lines with more than 80 chars -patch 3: bad alignment of lines split on more than one line -patch 4: added spaces between concatenated strings -patch 5: modified comparisons against NUL

Re: [PATCH 2/2] staging: lustre: fixed 80-char rule

2015-07-27 Thread Mario Bambagini
On Sun, Jul 26, 2015 at 10:14:11PM +0300, Dan Carpenter wrote: > On Sat, Jul 25, 2015 at 06:22:52PM +0200, Mario Bambagini wrote: > > This patch fixes 2 lines longer than 80 chars > > > > The first one is a function whose argument has been moved to next line. > > The second one is a comment split

[PATCH] Staging:dgap :Compression of lines for immediate return

2015-07-27 Thread Shraddha Barke
This patch compresses two lines into a single line if immediate return statement is found. Remove variable rc as it is no longer needed. It is done using script Coccinelle. And coccinelle uses the following semantic patch for this compression function: @@ type T; identifier i,f; constant C; @@ -

[PATCH] Staging:dgap :Compression of lines for immediate return

2015-07-27 Thread Shraddha Barke
This patch compresses two lines in a single line in file dgap.c if immediate return statement is found.It also removes variable rc as it is no longer needed. It is done using script Coccinelle.And coccinelle uses the following semantic patch for this compression function: @@ expression ret; ident

[PATCH] staging: comedi: das1800: add missing break in switch

2015-07-27 Thread H Hartley Sweeten
Commit 06ad6bd8 "staging: comedi: das1800: cleanup das1800_probe()" Accidently removed the 'break' statement for case 0x8 of the switch. Add it back. Reported-by: coverity (CID 1309550) Signed-off-by: H Hartley Sweeten Cc: Ian Abbott CC: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/d

[PATCH] Staging: lustre: Drop unnecessary cast

2015-07-27 Thread Shraddha Barke
This patch does away with the cast on void * as it is unnecessary. Semantic patch used is as follows: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/libcfs/linux

Re: [PATCH V2 0/6] clean up wlan_bssdef.h

2015-07-27 Thread Joshua Clayton
Apologies all, Patch 4 of 6 is triggering an error in git-send-email apparently caused by perl 5.22. also seen here: http://www.spinics.net/lists/git/msg255933.html It did not happen when I test emailed the patch series to myself. I can look into it after work. -- ~Joshua Clayton

Re: [PATCH] Drop unnecessary cast

2015-07-27 Thread Dan Carpenter
Can you resend with a fixed subject line? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Drop unnecessary cast

2015-07-27 Thread Shraddha Barke
This patch does away with the cast on void * as it is unnecessary. Semantic patch used is as follows: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/libcfs/linux

Re: [PATCH 3/3] staging: most: core.c: move static static specifier into MOST_CHNL_ATTR

2015-07-27 Thread Greg KH
On Mon, Jul 27, 2015 at 10:31:10AM +0900, Chaehyun Lim wrote: > Move static specifier into MOST_CHNL_ATTR to fix checkpatch error. > ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/most/mostcore/core.c | 6 +++--- > 1 fi

Re: [PATCH 1/3] staging: most: core.c: move static specifier into MOST_INST_ATTR

2015-07-27 Thread Greg KH
On Mon, Jul 27, 2015 at 10:31:08AM +0900, Chaehyun Lim wrote: > Move static specifier into MOST_INST_ATTR to fix checkpatch error. > ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/most/mostcore/core.c | 4 ++-- > 1 file

[PATCH V2 3/6] staging: rtl8712: fix comment

2015-07-27 Thread Joshua Clayton
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers

[PATCH V2 2/6] staging: rtl8712: simplify size calculation

2015-07-27 Thread Joshua Clayton
replace item-by-item size calculation of a struct with the size of the struct. This gets rid of a use of typedef NDIS_802_11_RATES_EX Signed-off-by: Joshua Clayton diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c index e35854d..f07050d 100644 --- a/dr

[PATCH V2 1/6] staging: rtl8712: fix buggy size calculation

2015-07-27 Thread Joshua Clayton
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)" where the underlying struct has a 6 * unsigned char. Simplify the calculation by just subtracting the variable part from the size of the struct. This also gets rid of a use of typedef NDIS_802_11_RATES_EX Signed-off-by: Joshua Clay

[PATCH V2 0/6] clean up wlan_bssdef.h

2015-07-27 Thread Joshua Clayton
The main goal of this series is to get rid of a needless typedef in the rtl8712 wlan driver. In the course of fixing that, I found a bug that can (at least in theory) lead to a overrun during a memcpy, as well as an identical struct with a different name, which use the typedef. Finally after clean

[PATCH V2 3/6] staging: rtl8712: fix comment

2015-07-27 Thread Joshua Clayton
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers

[PATCH V2 1/6] staging: rtl8712: fix buggy size calculation

2015-07-27 Thread Joshua Clayton
r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)" where the underlying struct has a 6 * unsigned char. Simplify the calculation by just subtracting the variable part from the size of the struct. This also gets rid of a use of typedef NDIS_802_11_RATES_EX Signed-off-by: Joshua Clay

[PATCH V2 0/6] clean up wlan_bssdef.h

2015-07-27 Thread Joshua Clayton
The main goal of this series is to get rid of a needless typedef in the rtl8712 wlan driver. In the course of fixing that, I found a bug that can (at least in theory) lead to a overrun during a memcpy, as well as an identical struct with a different name, which use the typedef. Finally after clean

[PATCH V2 2/6] staging: rtl8712: simplify size calculation

2015-07-27 Thread Joshua Clayton
replace item-by-item size calculation of a struct with the size of the struct. This gets rid of a use of typedef NDIS_802_11_RATES_EX Signed-off-by: Joshua Clayton diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c index e35854d..f07050d 100644 --- a/dr

[PATCH] Staging : rtl8188eu : os_dep : Compression of lines for immediate return

2015-07-27 Thread Shraddha Barke
This patch compresses two lines into a single line if immediate return is found. Also remove variable ret as it is no longer needed. Semantic patch used for this is as follows: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(

[PATCH] Staging: dgnc: Merge lines and remove unused variable for immediate return

2015-07-27 Thread Shraddha Barke
This patch compresses two lines into a single line if immediate return is found. Variable rc is dropped as it is no longer needed. Semantic patch used for this is as follows: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(..

[PATCH] Staging: dgnc: Merge lines and remove unused variable for immediate return

2015-07-27 Thread Shraddha Barke
This patch compresses two lines into a single line if immediate return is found. Variable rc is dropped as it is no longer needed. Semantic patch used for this is as follows: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(..

[PATCH 5/5] staging: lustre: Remove unnecessary braces {} for single statement blocks

2015-07-27 Thread Incarnation P. Lee
From: "Pan Li" Remove unnecessary braces {} for single line statement blocks. Signed-off-by: Pan Li --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lus

[PATCH 5/5] Remove unnecessary braces {} for single statement blocks

2015-07-27 Thread Incarnation P. Lee
From: "Pan Li" Remove unnecessary braces {} for single line statement blocks. Signed-off-by: Pan Li --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lus

[PATCH 4/5] staging: lustre: Remove a trailing */ of a separate line.

2015-07-27 Thread Incarnation P. Lee
From: "Pan Li" Remove a trailing */ of a separate comments block line. Signed-off-by: Pan Li --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre

[PATCH 3/5] staging: lustre: Add a blank line after declarations.

2015-07-27 Thread Incarnation P. Lee
From: "Pan Li" Add a blank line after local variable declarations. Signed-off-by: Pan Li --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page

[PATCH 2/5] staging: lustre: Adjust code indent for macro and tail blackslash

2015-07-27 Thread Incarnation P. Lee
From: "Pan Li" Adjust code indent for macro with tab, as well as tail blackslash. Signed-off-by: Pan Li --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/driv

[PATCH 1/5] staging: lustre: Replace spaces at the start of a line.

2015-07-27 Thread Incarnation P. Lee
From: "Pan Li" Replace the spaces at the start of a line with tab for indent. Signed-off-by: Pan Li --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/l

[PATCH 0/5] staging: lustre: Fix a file 8 warnings of coding sytle.

2015-07-27 Thread Incarnation P. Lee
From: "Pan Li" Fix file cl_page.c 8 coding style warning issues as follow: Replace spaces at the start of a line. Adjust code indent for macro and tail blackslash Add a blank line after declarations. Remove a trailing */ of a separate line. Remove unnecessary braces {} for single statem

[PATCH] Staging : rtl8188eu : os_dep : Compression of lines for immediate return

2015-07-27 Thread Shraddha Barke
This patch compresses two lines into a single line if immediate return is found. Also remove variable ret as it is no longer needed. Semantic patch used for this is as follows: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(

[PATCH] Staging : android :Replace comma with a semicolon

2015-07-27 Thread Shraddha Barke
Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; Signed-off-by: Shraddha Barke --- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/androi

Re: [PATCH] Fixed spelling mistake. drivers: staging: lustre: lnet: klnds: o2iblnd: o2iblnd.c

2015-07-27 Thread Dan Carpenter
On Mon, Jul 27, 2015 at 03:13:05PM +0530, bharadwaj wrote: > Can you be more specific...? give example or something? > If you had run the command I told you: git log --oneline drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c it would give you this output: 323b0b2 staging/lustre/libc

Re: [PATCHv2,2/2] Staging: dgnc: dgnc_driver.c: Add end tag to dgnc_init_module()

2015-07-27 Thread Sudip Mukherjee
On Mon, Jul 27, 2015 at 04:10:29PM +0800, Navy Cheng wrote: > The work flow of dgnc_init_module() is base on if statment. Here is a > nest "if" in the function. > > To avoid the nest if statment, make the code easier to understand and > make the codingstyle to be identical with others, add "end" l

Re: [PATCH 2/2] Fixed Spelling mistake error. drivers: staging : media : davinci_vpfe : dma365_resizer.c drivers: staging : media : davinci_vpfe : dma365_resizer.h

2015-07-27 Thread Dan Carpenter
Same issue. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Fixed spelling mistake. drivers: staging: lustre: lnet: klnds: o2iblnd: o2iblnd.c

2015-07-27 Thread Dan Carpenter
The subject line is still all messed up. Do: git log --oneline drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c and base yours on the others. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linux

[PATCH 2/2] Fixed Spelling mistake error. drivers: staging : media : davinci_vpfe : dma365_resizer.c drivers: staging : media : davinci_vpfe : dma365_resizer.h

2015-07-27 Thread Bharadwaaj Ramakrishnan
From: "Bharadwaaj Ramakrishnan" Fixed some spelling mistake. Signed-off-by: Bharadwaaj Ramakrishnan --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 22 +++--- drivers/staging/media/davinci_vpfe/dm365_resizer.h | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-)

[PATCH] Fixed spelling mistake. drivers: staging: lustre: lnet: klnds: o2iblnd: o2iblnd.c

2015-07-27 Thread Bharadwaaj Ramakrishnan
From: "Bharadwaaj Ramakrishnan" Fixed spelling mistake. Signed-off-by: Bharadwaaj Ramakrishnan --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/

[PATCH v4 43/46] usb: gadget: move find_ep() from epautoconf to gadget.h

2015-07-27 Thread Robert Baldyga
Move find_ep() function to gadget.h, rename it to gadget_find_ep_by_name() and make it static inline. It can be used in UDC drivers, especially in 'match_ep' callback after moving chip-specific endpoint matching logic from epautoconf to UDC drivers. Replace all calls of find_ep() function with gad

[PATCH v4 44/46] usb: gadget: net2280: add net2280_match_ep() function

2015-07-27 Thread Robert Baldyga
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching process. Function does the same that was done by chip-specific code inside of epautoconf. Now this code can be removed from there to separate generic code from platform specific logic. Signed-off-by: Robert Baldyga --

[PATCH v4 45/46] usb: gadget: goku_udc: add goku_match_ep() function

2015-07-27 Thread Robert Baldyga
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching process. Function does the same that was done by chip-specific code inside of epautoconf. Now this code can be removed from there to separate generic code from platform specific logic. Signed-off-by: Robert Baldyga --

[PATCH v4 46/46] usb: musb: gadget: add musb_match_ep() function

2015-07-27 Thread Robert Baldyga
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching process. Function does the same that was done by chip-specific code inside of epautoconf. Now this code can be removed from there to separate generic code from platform specific logic. Signed-off-by: Robert Baldyga --

[PATCH v4 42/46] usb: gadget: move ep_matches() from epautoconf to udc-core

2015-07-27 Thread Robert Baldyga
Move ep_matches() function to udc-core and rename it to usb_gadget_ep_match_desc(). This function can be used by UDC drivers in 'match_ep' callback to avoid writing lots of repetitive code. Replace all calls of ep_matches() with usb_gadget_ep_match_desc(). Signed-off-by: Robert Baldyga --- driv

[PATCH v4 41/46] usb: gadget: add 'ep_match' callback to usb_gadget_ops

2015-07-27 Thread Robert Baldyga
Add callback that is called by epautoconf to allow UDC driver match the best endpoint for specific descriptor. It's intended to supply mechanism which allows to get rid of chip-specific endpoint matching code from epautoconf. If gadget has set 'ep_match' callback we prefer to call it first, and if

[PATCH v4 35/46] usb: renesas: gadget: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/renesas_usbhs/mod_gadget.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index 494dfe0..de4f97d 100

[PATCH v4 37/46] usb: gadget: epautoconf: add endpoint capabilities flags verification

2015-07-27 Thread Robert Baldyga
Introduce endpoint matching mechanism basing on endpoint capabilities flags. We check if endpoint supports transfer type and direction requested in ep descriptor. Since we have this new endpoint matching mechanism there is no need to have old code guessing endpoint capabilities basing on its name,

[PATCH v4 39/46] usb: gadget: epautoconf: remove ep and desc configuration from ep_matches()

2015-07-27 Thread Robert Baldyga
As function ep_matches() is used to match endpoint with usb descriptor it's highly unintuitive that it modifies endpoint and descriptor structures fields. This patch moves code configuring ep and desc from ep_matches() to usb_ep_autoconfig_ss(), so now function ep_matches() does nothing more than i

[PATCH v4 40/46] usb: gadget: epautoconf: rework ep_matches() function

2015-07-27 Thread Robert Baldyga
Rework ep_matches() function to make it shorter and more readable. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/epautoconf.c | 87 + 1 file changed, 35 insertions(+), 52 deletions(-) diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadge

Re: [RFC PATCH] checkpatch: Make --strict the default for drivers/staging files and patches

2015-07-27 Thread Dan Carpenter
I wish there were some way to say that, "this is important enough that we will make you redo your patch but not important enough to redo all the existing code." Although for staging I guess we welcome the churn so I am ok with this. regards, dan carpenter

[PATCH v4 36/46] usb: gadget: atmel_usba_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/atmel_usba_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 37d414e..2

[PATCH v4 38/46] usb: gadget: epautoconf: remove pxa quirk from ep_matches()

2015-07-27 Thread Robert Baldyga
The same effect can be achieved by using capabilities flags, so now we can get rid of handling of hardware specific limitations in generic code. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/epautoconf.c | 5 - drivers/usb/gadget/udc/pxa25x_udc.c | 9 +++-- 2 files changed, 3

[PATCH v4 34/46] usb: musb: gadget: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/musb/musb_gadget.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index 625d482f..043248a 100644 --- a/driver

[PATCH v4 31/46] usb: gadget: s3c2410_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/s3c2410_udc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c index 5d9aa81..eb3571e 100

[PATCH v4 33/46] usb: isp1760: udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/isp1760/isp1760-udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c index 3699962..1c3d0fd 100644 ---

[PATCH v4 32/46] usb: gadget: udc-xilinx: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/udc-xilinx.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c index 1f24274..1cbb0ac 100644 --

[PATCH v4 30/46] usb: gadget: s3c-hsudc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/s3c-hsudc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/usb/gadget/udc/s3c-hsudc.c b/drivers/usb/gadget/udc/s3c-hsudc.c index 85a712a..e9def42 1006

[PATCH v4 29/46] usb: gadget: r8a66597-udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/r8a66597-udc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c index 0293f71..baa0609

[PATCH v4 23/46] usb: gadget: net2272: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/net2272.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c index c2ed5da..18f5ebd 100644 --- a/dr

[PATCH v4 27/46] usb: gadget: pxa25x_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/pxa25x_udc.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c index f

[PATCH v4 26/46] usb: gadget: pch_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/pch_udc.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index dcf5def..fa9e

[PATCH v4 28/46] usb: gadget: pxa27x_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/pxa27x_udc.h | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.h b/drivers/usb/gadget/udc/px

[PATCH v4 24/46] usb: gadget: net2280: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/net2280.c | 50 ++-- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/ne

[PATCH v4 22/46] usb: gadget: mv_udc_core: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/mv_udc_core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index d32160d..306a7ff 100644

[PATCH v4 25/46] usb: gadget: omap_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/omap_udc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c index e2fcdb8..9b7d394

[PATCH v4 21/46] usb: gadget: mv_u3d_core: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/mv_u3d_core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c index ea35a24..4c48969 100644

[PATCH v4 18/46] usb: gadget: gr_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/gr_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c index c886887..8aa2593 100644 --- a/drive

[PATCH v4 19/46] usb: gadget: lpc32xx_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/lpc32xx_udc.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c inde

[PATCH v4 20/46] usb: gadget: m66592-udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/m66592-udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c index 309706f..e404553 10064

[PATCH v4 17/46] usb: gadget: goku_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/goku_udc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index 9e8d842..46b8d14 100644 --- a/dri

[PATCH v4 13/46] usb: gadget: fotg210-udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/fotg210-udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c index 1137e33..bf6bbee 10

[PATCH v4 09/46] usb: gadget: at91_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/at91_udc.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_ud

[PATCH v4 16/46] usb: gadget: fusb300_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/fusb300_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c index 3970f45..948845c 10

[PATCH v4 14/46] usb: gadget: fsl_qe_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/fsl_qe_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c index e0822f1..5fb6f8b 10064

[PATCH v4 08/46] usb: gadget: amd5536udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/amd5536udc.c | 57 ++--- 1 file changed, 47 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/udc/amd5536udc.c b/drivers/usb/gadget/ud

[PATCH v4 15/46] usb: gadget: fsl_udc_core: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/fsl_udc_core.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c index c60022b..aab52

[PATCH v4 11/46] usb: gadget: bdc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/bdc/bdc_ep.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c b/drivers/usb/gadget/udc/bdc/bdc_ep.c index b04980c..f9a8f57 100644 --

[staging:staging-testing 413/420] drivers/staging/most/aim-cdev/cdev.c:128 aim_close() error: dereferencing freed memory 'channel'

2015-07-27 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 59cc3399efd61fabb7f4aa23d4498bd9b01e5f6d commit: 9bc79bbcd0c526e3ec7b98e08c5d34648bb3c158 [413/420] Staging: most: add MOST driver's aim-cdev module drivers/staging/most/aim-cdev/cdev.c:128 aim_close

[PATCH v4 10/46] usb: gadget: bcm63xx_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/bcm63xx_udc.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_u

[PATCH v4 12/46] usb: gadget: dummy-hcd: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/dummy_hcd.c | 65 +- 1 file changed, 50 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc

[PATCH v4 03/46] usb: gadget: add endpoint capabilities helper macros

2015-07-27 Thread Robert Baldyga
Add macros useful while initializing array of endpoint capabilities structures. These macros makes structure initialization more compact to decrease number of code lines and increase readability of code. Signed-off-by: Robert Baldyga --- include/linux/usb/gadget.h | 20 1 fi

[PATCH v4 07/46] usb: dwc3: gadget: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/dwc3/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index d97fcfa..65fd959 100644 --- a/drivers/usb/dwc3/gadg

[PATCH v4 04/46] staging: emxx_udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Fixed typo in "epc-nulk" to "epc-bulk". Signed-off-by: Robert Baldyga --- drivers/staging/emxx_udc/emxx_udc.c | 60 ++--- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/drivers/staging/emx

[PATCH v4 06/46] usb: dwc2: gadget: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 731b13d..3ee5b4c 100644 --- a/drivers/usb/dwc2/gadg

[PATCH v4 05/46] usb: chipidea: udc: add ep capabilities support

2015-07-27 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/chipidea/udc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index b7cca3e..4aaa476 100644 --- a/drivers/usb/chipi

[PATCH v4 02/46] usb: gadget: add endpoint capabilities flags

2015-07-27 Thread Robert Baldyga
Introduce struct usb_ep_caps which contains information about capabilities of usb endpoints - supported transfer types and directions. This structure should be filled by UDC driver for each of its endpoints, and will be used in epautoconf in new ep matching mechanism which will replace ugly guessin

[PATCH v4 01/46] usb: gadget: encapsulate endpoint claiming mechanism

2015-07-27 Thread Robert Baldyga
So far it was necessary for usb functions to set ep->driver_data in endpoint obtained from autoconfig to non-null value, to indicate that endpoint is claimed by function (in autoconfig it was checked if endpoint has set this field to non-null value, and if it has, it was assumed that it is claimed)

[PATCH v4 00/46] usb: gadget: rework ep matching and claiming mechanism

2015-07-27 Thread Robert Baldyga
Hello, This patch series reworks endpoint matching and claiming mechanism in epautoconf. From v2 there are couple of new patches adding 'ep_match' to usb_gadget_ops and removing chip-specific quirk handling from generic code of autoconfig. I'm not sure if this patch set isn't too long, as it has

[staging:staging-testing 412/420] drivers/staging/most/mostcore/core.c:978 store_add_link() error: strlcpy() 'buffer' too small (80 vs u32max)

2015-07-27 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 59cc3399efd61fabb7f4aa23d4498bd9b01e5f6d commit: 57562a72414ca35b2e614cfe0a1b1a7b7e7813dd [412/420] Staging: most: add MOST driver's core module drivers/staging/most/mostcore/core.c:978 store_add_lin

  1   2   >