Add space after ',' to fix the error message provided by checkpatch.pl:
ERROR: space required after that ','
Signed-off-by: Freeman Zhang
---
drivers/staging/rtl8192u/r819xU_firmware.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_
On Tue, Jul 21, 2015 at 03:17:06PM +0530, Vinay Simha wrote:
> Joe,
>
> Just want to confirm, shall i delete this code in sm750_help.h, even the
> FIELD_START and FIELD_END is not required.
If they are not used anywhere feel free to send a patch to delete them.
regards
sudip
_
On Sat, Jul 18, 2015 at 09:38:57AM +0530, Sudip Mukherjee wrote:
> Now since all cleanups are done and the code is ready to be merged lets
> move it out of staging into fbdev location.
Hi Tomi,
A gentle ping
regards
sudip
___
devel mailing list
de...@li
On Sat, Jul 25, 2015 at 09:49:19AM +0800, Incarnation P. Lee wrote:
> From: "Pan Li"
>
> Add one space after ',' in function call parameters list.
> Signed-off-by: Pan Li
>
> ---
This has already been done by 574150f0d275 ("staging:lustre: fix "space
required after that ', '" error in cl_page.c
On Sun, Jul 26, 2015 at 11:04:54PM +0530, Shraddha Barke wrote:
> This patch compresses two lines into a single line if immediate return
> statement
> is found. Also,remove variable rc as it is no longer needed.
> It is done using tool Coccinelle. And semantic patch used for this is as
> follows:
On Sun, Jul 26, 2015 at 11:03:40PM +0530, Shraddha Barke wrote:
> This patch compresses two lines into a single line if immediate return
> statement
> is found. Also,remove variable rc as it is no longer needed.
> It is done using tool Coccinelle. And semantic patch used for this is as
> follows:
Hi,
This is not called in IRQ context and not even held in the spin lock.
All of the macros in the driver for the Linux APIs will be removed soon.
I expect all of concerns will be also removed at that time.
Thanks,
Tony.
On 2015년 07월 24일 09:44, Dan Carpenter wrote:
On Fri, Jul 24, 2015 at 08
Move static specifier into MOST_INST_ATTR to fix checkpatch error.
ERROR: Macros with complex values should be enclosed in parentheses
Signed-off-by: Chaehyun Lim
---
drivers/staging/most/mostcore/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/most
Move static specifier into MOST_CHNL_ATTR to fix checkpatch error.
ERROR: Macros with complex values should be enclosed in parentheses
Signed-off-by: Chaehyun Lim
---
drivers/staging/most/mostcore/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/mo
Remove semicolon at the end of define statement to fix checkpatch warning.
WARNING: macros should not use a trailing semicolon
Signed-off-by: Chaehyun Lim
---
drivers/staging/most/mostcore/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/mostcore/co
From: "K. Y. Srinivasan"
Date: Wed, 22 Jul 2015 11:42:32 -0700
> The current code returns from probe without waiting for the proper handling
> of subchannels that may be requested. If the netvsc driver were to be rapidly
> loaded/unloaded, we can trigger a panic as the unload will be tearing
> d
This patch fixes the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
+ unsigned long flags;
+ pshmem = (struct slic_shmem *)(unsigned long)
Signed-off-by: Ciprian Manea
---
drivers/staging/slicoss/slicoss.c | 1 +
1 file changed, 1 insertion(+
Making --strict the default for staging may help some people
submit patches without obvious defects.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 34ca400..50693f5 10075
On Sat, Jul 25, 2015 at 06:22:52PM +0200, Mario Bambagini wrote:
> This patch fixes 2 lines longer than 80 chars
>
> The first one is a function whose argument has been moved to next line.
> The second one is a comment split on two lines
>
> The script checkpatch does not complain anymore
>
> Si
On Sun, Jul 26, 2015 at 10:59:17AM +0530, Bharadwaaj wrote:
> From: "bhaaradw...@gmail.com"
Again, this has to match.
Your subject alsh needs to say what you are doing, not just what file
you are modifying.
___
devel mailing list
de...@linuxdriverproj
On Sun, Jul 26, 2015 at 11:03:28AM +0530, Bharadwaaj wrote:
> From: "bhaaradw...@gmail.com"
This has to match the string you use in the signed-off-by: line.
>
> Fixed some spelling mistake.
>
> Signed-off-by: Bharadwaaj Ramakrishnan
Please add a ' ' before the '<' character.
_
This patch compresses two lines into a single line if immediate return statement
is found. Also,remove variable rc as it is no longer needed.
It is done using tool Coccinelle. And semantic patch used for this is as
follows:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return
This patch compresses two lines into a single line if immediate return statement
is found. Also,remove variable rc as it is no longer needed.
It is done using tool Coccinelle. And semantic patch used for this is as
follows:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return
On Sun, Jul 26, 2015 at 09:00:23AM -0400, Jes Sorensen wrote:
> "Joglekar, Tejas (T.)" writes:
> > From: Joglekar Tejas
> >
> > This patch fixes the error given by checkpatch.pl
> >
> > Signed-off-by: Joglekar Tejas
> > ---
> > drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
> > 1 file chan
On Sun, Jul 26, 2015 at 10:01:34PM +0800, Geliang Tang wrote:
> Use macro "uip" instead of "unsigned int __force *", like "vuip" in
> arch/alpha/include/asm/core_cia.h.
>
> Signed-off-by: Geliang Tang
The original is easier to understand. Don't add pointless abstractions
just to get around a si
Use macro "uip" instead of "unsigned int __force *", like "vuip" in
arch/alpha/include/asm/core_cia.h.
Signed-off-by: Geliang Tang
---
drivers/staging/comedi/comedi_compat32.c | 3 +--
drivers/staging/comedi/comedi_compat32.h | 2 ++
drivers/staging/comedi/comedi_fops.c | 4 ++--
3 files cha
"Joglekar, Tejas (T.)" writes:
> From: Joglekar Tejas
>
> This patch fixes the error given by checkpatch.pl
>
> Signed-off-by: Joglekar Tejas
> ---
> drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723au/co
From: Joglekar Tejas
This patch fixes the error given by checkpatch.pl
Signed-off-by: Joglekar Tejas
---
drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c
b/drivers/staging/rtl8723au/core
23 matches
Mail list logo
