kernel coding style fixes for below messages from
scripts/checkpatch.pl
WARNING: line over 80 character
WARNING: Possible unnecessary 'out of memory' message
WARNING: unnecessary whitespace before a quoted newline
WARNING: Avoid line continuations in quoted strings
ERROR: "foo * bar" should be "fo
Remove all checkpatch error by using consistent spacing.
Signed-off-by: Sunil Shahu
---
drivers/staging/sm750fb/ddk750_chip.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/drivers/staging/sm750fb/ddk750_chip.c
index f4
On Tue, Jul 14, 2015 at 03:26:12AM +0200, Henri Chain wrote:
> This is a driver chip for 240x160 4-bit greyscale LCDs.
> It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been
> tested. (It also has a 6800 or 8080-style parallel interface, but I have
> not included support for it
On Mon, Jul 13, 2015 at 10:51:00PM -0400, Oleg Drokin wrote:
>
> On Jul 13, 2015, at 10:46 PM, Greg Kroah-Hartman wrote:
>
> > On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
> >> From: Oleg Drokin
> >>
> >> It's just a fancy libcfs_debug_mb module parameter wrapper,
> >>
From: Dmitry Eremin
Remove portal_enter_debugger because it's not used any more.
Signed-off-by: Dmitry Eremin
---
drivers/staging/lustre/lustre/libcfs/debug.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c
b/drivers/staging/lustre/lustre/lib
From: Dmitry Eremin
They are just fancy module parameters wrappers,
so just the same functionality now would be accessible via
/sys/module/libcfs/parameters/libcfs_console_{min,max}_delay
Also install compatibility symlinks
Signed-off-by: Dmitry Eremin
Signed-off-by: Oleg Drokin
---
drivers/
From: Oleg Drokin
Apparently kstrtouint could return not just -EINVAL, but also -ERANGE,
so make sure we just check the return value for something negative.
Noticed by Dan Carpenter
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/debug.c | 2 +-
1 file changed, 1 insertio
From: Oleg Drokin
Rediffed the last few patches as per Greg's instructions.
Also Added a folow on fix for the uint_min_max param to
properly take into account kstrtouint range of error return values.
Please consider.
Dmitry Eremin (2):
staging/lustre/libcfs: get rid of
debugfs/lnet/consol
From: Oleg Drokin
It's just a fancy libcfs_debug_mb module parameter wrapper,
so just add debug buffer size check and resizing and the same
functionality now would be accessible via
/sys/module/libcfs/parameters/libcfs_debug_mb
Also add a symlink for backwards compatibility.
Signed-off-by: Oleg
On Mon, Jul 13, 2015 at 10:45:36PM -0400, Oleg Drokin wrote:
>
> On Jul 13, 2015, at 10:43 PM, Greg Kroah-Hartman wrote:
>
> > On Wed, Jul 08, 2015 at 11:45:59AM +0300, Dan Carpenter wrote:
> >> On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
> >>> +static int libcfs_param_d
On Jul 13, 2015, at 10:49 PM, Greg Kroah-Hartman wrote:
> On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> It's just a fancy libcfs_debug_mb module parameter wrapper,
>> so just add debug buffer size check and resizing and the same
>> functionalit
On Mon, Jul 13, 2015 at 10:10:46PM +0200, Lukasz Janyst wrote:
> This is a patch to the libcfs/module.c file fixing whitespace warnings
> found by checkpatch.pl.
This patch no longer applies to my tree due to other patches sent right
before yours. Can you rebase it on the staging-testing branch o
On Jul 13, 2015, at 10:46 PM, Greg Kroah-Hartman wrote:
> On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> It's just a fancy libcfs_debug_mb module parameter wrapper,
>> so just add debug buffer size check and resizing and the same
>> functionalit
On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
> From: Oleg Drokin
>
> It's just a fancy libcfs_debug_mb module parameter wrapper,
> so just add debug buffer size check and resizing and the same
> functionality now would be accessible via
> /sys/module/libcfs/parameters/lib
On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
> From: Oleg Drokin
>
> It's just a fancy libcfs_debug_mb module parameter wrapper,
> so just add debug buffer size check and resizing and the same
> functionality now would be accessible via
> /sys/module/libcfs/parameters/lib
On Jul 13, 2015, at 10:43 PM, Greg Kroah-Hartman wrote:
> On Wed, Jul 08, 2015 at 11:45:59AM +0300, Dan Carpenter wrote:
>> On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
>>> +static int libcfs_param_debug_mb_set(const char *val,
>>> +const s
On Wed, Jul 08, 2015 at 11:45:59AM +0300, Dan Carpenter wrote:
> On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
> > +static int libcfs_param_debug_mb_set(const char *val,
> > +const struct kernel_param *kp)
> > +{
> > + int rc;
> > + unsign
On Fri, Jun 26, 2015 at 11:23:29PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Fri, 26 Jun 2015 23:10:42 +0200
Sorry, I'm not taking any of your patches until you fix this all up.
greg k-h
___
devel mailing list
de...@linuxdriverproj
On Tue, Jun 23, 2015 at 04:26:11PM +0200, Luis de Bethencourt wrote:
> Inverting the value of eof is a more direct way of passing to the debugging
> function if eof is false or not.
Really? I like the explicit-ness of the code as it is today, it's more
obvious what is going on, which is the most
Hi Chaehyun,
On Tue, Jul 14, 2015 at 11:48 AM, Chaehyun Lim wrote:
> When building this driver, I got a warning as below:
>
> host_interface.c: In function ‘host_int_add_beacon’:
> host_interface.c:7116:16: warning: ‘*((void *)&strHostIFmsg+8).pu8Head’ may
> be used
> uninitialized in this funct
Remove WILC_ERRORREPORT macro. If memory allocation is failed,
jump to a label to return this function with WILC_NO_MEM.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/h
When building this driver, I got a warning as below:
host_interface.c: In function ‘host_int_add_beacon’:
host_interface.c:7116:16: warning: ‘*((void *)&strHostIFmsg+8).pu8Head’ may be
used
uninitialized in this function [-Wmaybe-uninitialized]
Signed-off-by: Chaehyun Lim
---
drivers/staging/w
On Mon, Jul 13, 2015 at 04:42:22AM -0700, Joe Perches wrote:
> On Mon, 2015-07-13 at 17:29 +, Craig wrote:
> > Modified style issue in ion.c. Missing empty line after a definition
> >
> > Signed-off-by: Craig
> > ---
> > drivers/staging/android/ion/ion.c | 1 +
> > 1 file changed, 1 insertio
This is a driver chip for 240x160 4-bit greyscale LCDs.
It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been
tested. (It also has a 6800 or 8080-style parallel interface, but I have
not included support for it.)
Signed-off-by: Henri Chain
---
drivers/staging/fbtft/Kconfig
Found by checkpatch.pl
Signed-off-by: Perry Hooker
---
.../staging/lustre/include/linux/libcfs/libcfs_fail.h | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h
b/drivers/staging/lustre/include/linux/
Am Dienstag, 14. Juli 2015, 00:47:42 schrieb Greg KH:
> On Tue, Jul 14, 2015 at 12:44:09AM +0200, Peter Huewe wrote:
> > and mark them as static inline.
> > This shrinks the compiled module from 137442 to 117732 bytes and we also
> > get rid of vb_util.c
>
> How is making these inline making the c
On Tue, Jul 14, 2015 at 12:44:09AM +0200, Peter Huewe wrote:
> and mark them as static inline.
> This shrinks the compiled module from 137442 to 117732 bytes and we also
> get rid of vb_util.c
How is making these inline making the code go down in size? Usually
it's the opposite way around. This
and mark them as static inline.
This shrinks the compiled module from 137442 to 117732 bytes and we also
get rid of vb_util.c
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/Makefile | 2 +-
drivers/staging/xgifb/vb_util.c | 42 ---
drivers/staging/xgif
This is a patch to the libcfs/module.c file fixing whitespace warnings
found by checkpatch.pl.
Signed-off-by: Lukasz Janyst
---
drivers/staging/lustre/lustre/libcfs/module.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/modu
Remove some extra tabs in order to improve readalibility.
Signed-off-by: Christophe JAILLET
---
drivers/staging/unisys/visorbus/visorbus_main.c | 49 -
1 file changed, 24 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drive
This patch turns a kmalloc/memset into an equivalent kzalloc.
Signed-off-by: Christophe JAILLET
---
drivers/staging/unisys/visorbus/visorbus_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/viso
This patchset fixes pointer arithmetic and null-termination problems in
the visorbus driver.
Tim Sell (2):
staging: unisys: correctly NULL-terminate visorbus sysfs attribute
array
staging: unisys: fix random memory corruption in visorchannel_write()
drivers/staging/unisys/visorbus/visorb
From: Tim Sell
I'm not sure what adverse runtime effects the previously-omitted
NULL-termination would cause, but the code was definitely wrong.
Fixes: 795731627c ('staging: unisys: Clean up device sysfs attributes')
Signed-off-by: Tim Sell
Acked-by: Don Zickus
Signed-off-by: Benjamin Romer
-
From: Tim Sell
visorchannel_write() and it's user visorbus_write_channel() are
exported, so all visorbus function drivers (i.e., drivers that call
visorbus_register_visor_driver()) are potentially affected by the bug.
Because of pointer-arithmetic rules, the address being written to in the
affec
The current change mtu call only stops tx before removing RNDIS filter.
In case ringbufer is not empty, the rndis_filter_device_remove() may
hang on removing the buffers.
This patch adds close of RNDIS filter before removing it, also a
gradual waiting loop until the ring is empty. The change_mtu h
From: David Kershner
This driver create a host bus adapter device when s-Par sends a
device create message to create a storage adapter on the visorbus.
When the message is received by visorbus, the visorhba_probe function
is called and the hba device is created and managed by the visorhba
driver.
Vitaly Kuznetsov writes:
> Changes since v5:
> - Split PATCH 1 into two (PATCH 1/3 and 3/3), rewrite changelogs. [Thomas
> Gleixner]
Sorry for the ping but Greg won't probably take this into his tree
without some feedback on patches 1 and 3 from core kernel people. Could
you please take a look
KY Srinivasan writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Monday, July 13, 2015 5:19 AM
>> To: de...@linuxdriverproject.org
>> Cc: KY Srinivasan; Haiyang Zhang; Dexuan Cui; linux-ker...@vger.kernel.org
>> Subject: [PATCH] Drivers: hv: vmbu
Mr. Liu Yuezhen
Chief Financial Officer - CNPC
9 Dongzhimen North Street, Dongcheng District,
Beijing, P.R.China | Postcode: 17
Letter of Intent:
Dear Esteemed Colleague,
I hope this email find you in good health. In view of my
correspondence with you, I unassumingly solicit for your utmost
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Monday, July 13, 2015 5:19 AM
> To: de...@linuxdriverproject.org
> Cc: KY Srinivasan; Haiyang Zhang; Dexuan Cui; linux-ker...@vger.kernel.org
> Subject: [PATCH] Drivers: hv: vmbus: prevent new subchannel cr
Actually, commit message looks malformatted. Signed-off-by line is not
the last line. Not sure if that's a problem for Greg or not.
On 07/13/2015 07:50 AM, Patrick Farrell wrote:
Looks good, thanks!
From: HPDD-discuss [hpdd-discuss-boun...@lists.01.org
On Mon, 2015-07-13 at 17:29 +, Craig wrote:
> Modified style issue in ion.c. Missing empty line after a definition
>
> Signed-off-by: Craig
> ---
> drivers/staging/android/ion/ion.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ion/ion.c
> b/drivers/stagi
On Mon, Jul 13, 2015 at 03:50:30PM +0300, Dmitry Kalinkin wrote:
> Prevents false positive "missing empty line after a definition"
> checkpatch warning.
>
> Signed-off-by: Dmitry Kalinkin
> ---
Clap clap clap. :)
regards,
dan carpenter
___
devel mai
On Mon, Jul 13, 2015 at 03:24:28PM +0300, Dan Carpenter wrote:
> Subject is bad.
I guess I missed this patch because of the subject.
Vinay - the subject should be "staging: sm750fb: xyz ".
You place your subject in place of xyz.
regards
sudip
___
devel
Looks good, thanks!
From: HPDD-discuss [hpdd-discuss-boun...@lists.01.org] on behalf of Perry
Hooker [perry.hoo...@gmail.com]
Sent: Sunday, July 12, 2015 9:22 PM
To: oleg.dro...@intel.com; andreas.dil...@intel.com;
gre...@linuxfoundation.org; de...@driverd
Prevents false positive "missing empty line after a definition"
checkpatch warning.
Signed-off-by: Dmitry Kalinkin
---
drivers/staging/android/ion/ion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
inde
Nope. It is a false postive. Also use your full/legal name.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Subject is bad.
No patch description.
Mixing too many types of cleanups.
The const thing seems like it will break things (buggy).
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/
When a new subchannel offer from host comes during device shutdown (e.g.
when a netvsc/storvsc module is unloadedshortly after it was loaded) a
crash can happen as vmbus_process_offer() is not anyhow serialized with
vmbus_remove(). As an example we can try calling subchannel create
callback when th
On Sun, Jul 12, 2015 at 10:29:15PM +0200, Mateusz Kulikowski wrote:
> diff --git a/drivers/staging/rtl8192e/rtllib.h
> b/drivers/staging/rtl8192e/rtllib.h
> index 8ba92ed..dc0653a 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -691,27 +691,8 @@ stru
Modified style issue in ion.c. Missing empty line after a definition
Signed-off-by: Craig
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 6f48112..e44f5e6 100644
--- a/drivers/s
Since maxpacket_limit was introduced all UDC drivers should use
usb_ep_set_maxpacket_limit() function instead of setting maxpacket value
manually. ep.maxpacket_limit contains actual maximum maxpacket value
supported by hardware which is needed by epautoconf.
Signed-off-by: Robert Baldyga
Acked-by
Add missing return value check. In case of error print debug message
and return error code.
Signed-off-by: Robert Baldyga
Acked-by: Nicolas Ferre
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/gadget/u
Since maxpacket_limit was introduced all UDC drivers should use
usb_ep_set_maxpacket_limit() function instead of setting maxpacket value
manually. ep.maxpacket_limit contains actual maximum maxpacket value
supported by hardware which is needed by epautoconf.
Signed-off-by: Robert Baldyga
Acked-by
Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates
usb request and increments refcounts. These things needs to be cleaned
up by if further steps of initialization fail by calling functionfs_unbind().
Signed-off-by: Robert Baldyga
Acked-by: Michal Nazarewicz
---
drivers/us
Function midi registers two interfaces with single set_alt() function
which means that f_midi_set_alt() is called twice when configuration
is set. That means that endpoint initialization and ep request allocation
is done two times. To avoid this problem we do such things only once,
for interface nu
Hello,
This patch set contains few small bugfixes found in usb gadget functions
and UDC drivers. The most important is the [1] as it fixes bug causing
BUG_ON() in f_fs driver. Remaining patches contain minor fixes.
[1] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails
Best reg
On Sun, Jul 12, 2015 at 08:22:56PM -0600, Perry Hooker wrote:
> Found by checkpatch.pl
>
> Signed-off-by: Perry Hooker
>
> Please enter the commit message for your changes. Lines starting
This line should not be here. And please give the version numbers in your
patch. Like this one should have
On Sun, Jul 12, 2015 at 03:27:50PM -0600, Perry Hooker wrote:
> Found by checkpatch.pl
>
> Signed-off-by: Perry Hooker
> ---
> drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/include/l
On Sun, Jul 12, 2015 at 10:29:31PM +0200, Mateusz Kulikowski wrote:
> Function is not referenced outside of rtllib_rx.c
>
> Signed-off-by: Mateusz Kulikowski
> ---
> drivers/staging/rtl8192e/rtllib.h| 3 ---
> drivers/staging/rtl8192e/rtllib_rx.c | 10 +++---
> 2 files changed, 7 insert
60 matches
Mail list logo
