On Tue, Jul 07, 2015 at 09:27:58PM -0400, Sreenath Madasu wrote:
> When the checkpatch.pl script was run, it showed lines with length
> more than 80 characters in rtw_ap.c file. Fixed line number 382 by
> breaking it up into two lines within 80 characters.
Greg told you to fix the subject, its stil
> -Original Message-
> From: Olaf Hering
> Sent: Tuesday, July 7, 2015 18:59
> Subject: Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature
>
> On Tue, Jul 07, Dexuan Cui wrote:
>
> > OK, removing the line seems better than 'default n', though both reproduce
> > the same "# CONFI
> -Original Message-
> From: Stephen Hemminger
> Sent: Wednesday, July 8, 2015 2:31
> Subject: Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature
>
> On Mon, 6 Jul 2015 07:47:29 -0700
> Dexuan Cui wrote:
>
> > Hyper-V VM sockets (hvsock) supplies a byte-stream based communicatio
On Tue, 2015-07-07 at 22:08 -0400, valdis.kletni...@vt.edu wrote:
> On Tue, 07 Jul 2015 13:38:47 -0700, Joe Perches said:
>
> > The longest line in this file is 158 chars, that's
> > probably excessive, awk shows 35 lines > 80 chars.
>
> That doesn't count tabs. Checkpatch throws 98 warnings.
Y
On Tue, 07 Jul 2015 13:38:47 -0700, Joe Perches said:
> The longest line in this file is 158 chars, that's
> probably excessive, awk shows 35 lines > 80 chars.
That doesn't count tabs. Checkpatch throws 98 warnings.
pgpyA7aIF0_ni.pgp
Description: PGP signature
_
On Tue, 07 Jul 2015 21:08:10 -0400, Sreenath Madasu said:
> The kernelnewbies.org guide said "For your first patch, only pick one
> warning". That is the reason why I fixed one warning.
They mean "don't fix lines over 80 characters *and* missing-blank
warnings in the same patch".
pgpoBhFQVf2aM.p
When the checkpatch.pl script was run, it showed lines with length
more than 80 characters in rtw_ap.c file. Fixed line number 382 by
breaking it up into two lines within 80 characters.
Signed-off-by: Sreenath Madasu
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 3 ++-
1 file changed, 2 insertio
The kernelnewbies.org guide said "For your first patch, only pick one
warning". That is the reason why I fixed one warning.
Thanks
Sreenath
On Tue, Jul 07, 2015 at 03:32:50PM -0400, valdis.kletni...@vt.edu wrote:
> On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said:
> > When the checkpatch.p
On 07/07/2015 07:46 PM, Lee Jones wrote:
> On Mon, 29 Jun 2015, micky_ch...@realsil.com.cn wrote:
>
>> From: Micky Ching
>>
>> rts522a(rts5227s) is derived from rts5227, and mainly same with rts5227.
>> Add it to file mfd/rts5227.c to support this chip.
>>
>> Signed-off-by: Micky Ching
>> ---
>
Hi Markus,
On Wed, Jul 8, 2015 at 2:15 AM, SF Markus Elfring
wrote:
>> I can't remember ever changing or explicitly preserving the commit date.
>> I don't think I care enough.
>
> Would any more software developers and maintainers like to share
> their experiences around such details?
>
> When do
On Tue, Jul 07, 2015 at 11:37:55PM +0200, P. Varet wrote:
> On 07/07/15 11:54, Dan Carpenter wrote:
>
> >https://bugzilla.kernel.org/show_bug.cgi?id=57171
> >
> >This bug is a confusing mix of issues and it seems to be fixed. Just
> >use network manager.
>
> Hi Dan! Thank you for your reply!
>
On 07/07/15 11:54, Dan Carpenter wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=57171
This bug is a confusing mix of issues and it seems to be fixed. Just
use network manager.
Hi Dan! Thank you for your reply!
I gave it another try, then. The behavior was the same as described
before,
On Tue, Jul 07, 2015 at 07:35:24PM +0200, Mateusz Kulikowski wrote:
> Hi,
>
> One of TODOs for driver I'm working on is cleanup of function names;
>
> I'm working (amongst other things) on that and would like to know
> if and how would you like it submitted:
>
> 1 As a one big patch for whole d
On Tue, 2015-07-07 at 15:32 -0400, valdis.kletni...@vt.edu wrote:
> All: Is it time to kill that checkpatch test, or hide it behind a non-default
> flag, to prevent code churn?
I'm not an 80 column zealot.
This is for staging isn't it?
Code churn there is expected and somewhat desired.
A lot o
On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said:
> When the checkpatch.pl script was run, it showed lines with length
> more than 80 characters in rtw_ap.c file. Fixed line number 382 by
> breaking it up into two lines within 80 characters.
> - stainfo_offset
On Mon, 6 Jul 2015 07:47:29 -0700
Dexuan Cui wrote:
> Hyper-V VM sockets (hvsock) supplies a byte-stream based communication
> mechanism between the host and a guest. It's kind of TCP over VMBus, but
> the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM
> Sockets, applicati
Hi,
One of TODOs for driver I'm working on is cleanup of function names;
I'm working (amongst other things) on that and would like to know
if and how would you like it submitted:
1 As a one big patch for whole driver
(IMO it will be very hard to review unless you have scripts to verify it)
2
The analog output range is not programmable, but the ranges for each of
the two analog output channels are settable via jumpers. These jumper
settings are not readable by the driver. The driver
provides a range table containing all the possible internal ranges
(+/-10V, +/-5V, 0-10V, 0-5V) to prov
On 07/07/2015 05:01 PM, Dan Carpenter wrote:
On Tue, Jul 07, 2015 at 04:02:51PM +0200, Robert Baldyga wrote:
Should use usb_ep_set_maxpacket_limit instead of setting
maxpacket value manually.
This is a behavior change, right, since now we're setting
ep->ep.maxpacket and ep->ep.maxpacket_limit
On 07/07/2015 04:53 PM, Dan Carpenter wrote:
On Tue, Jul 07, 2015 at 04:02:49PM +0200, Robert Baldyga wrote:
diff --git a/drivers/usb/gadget/function/f_fs.c
b/drivers/usb/gadget/function/f_fs.c
index 6e7be91..966b214 100644
--- a/drivers/usb/gadget/function/f_fs.c
+++ b/drivers/usb/gadget/funct
> I can't remember ever changing or explicitly preserving the commit date.
> I don't think I care enough.
Would any more software developers and maintainers like to share
their experiences around such details?
When do commit timestamps become relevant as a documentation item
for contribution auth
If the "comedi" module has been loaded with the
"comedi_num_legacy_minors" module parameter set to a non-zero value,
some reserved comedi devices get created. These can be attached to a
low-level comedi driver using the `COMEDI_DEVCONFIG` ioctl command,
which checks for the `CAP_SYS_ADMIN` capabil
On Tue, Jul 07, 2015 at 04:02:52PM +0200, Robert Baldyga wrote:
> Should use usb_ep_set_maxpacket_limit instead of setting
> maxpacket value manually.
>
Same question.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://d
On Tue, Jul 07, 2015 at 04:02:51PM +0200, Robert Baldyga wrote:
> Should use usb_ep_set_maxpacket_limit instead of setting
> maxpacket value manually.
>
This is a behavior change, right, since now we're setting
ep->ep.maxpacket and ep->ep.maxpacket_limit where before we only set
the first. I don
KY Srinivasan writes:
>> -Original Message-
>> From: Christoph Hellwig [mailto:h...@infradead.org]
>> Sent: Friday, July 3, 2015 9:19 AM
>> To: Vitaly Kuznetsov
>> Cc: linux-s...@vger.kernel.org; Long Li; KY Srinivasan; Haiyang Zhang; James
>> E.J. Bottomley; de...@linuxdriverproject.org;
On Tue, Jul 07, 2015 at 04:02:49PM +0200, Robert Baldyga wrote:
> diff --git a/drivers/usb/gadget/function/f_fs.c
> b/drivers/usb/gadget/function/f_fs.c
> index 6e7be91..966b214 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -2897,11 +2897,19 @@
Hello.
On 7/7/2015 5:02 PM, Robert Baldyga wrote:
Should use usb_ep_set_maxpacket_limit instead of setting
maxpacket value manually.
Signed-off-by: Robert Baldyga
---
drivers/staging/emxx_udc/emxx_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/stagi
Add missing return value check. In case of error print debug message
and return error code.
Signed-off-by: Robert Baldyga
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c
b/drivers/usb/gadget/udc/atmel_us
Should use usb_ep_set_maxpacket_limit instead of setting
maxpacket value manually.
Signed-off-by: Robert Baldyga
---
drivers/staging/emxx_udc/emxx_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.
Function midi registers two interfaces with single set_alt() function
which means that f_midi_set_alt() is called twice when configuration
is set. That means that endpoint initialization and ep request allocation
is done two times. To avoid this problem we do such things only once,
for interface nu
Should use usb_ep_set_maxpacket_limit instead of setting
maxpacket value manually.
Signed-off-by: Robert Baldyga
---
drivers/usb/isp1760/isp1760-udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/isp1760/isp1760-udc.c
b/drivers/usb/isp1760/isp1760-udc.c
in
Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates
usb request and increments refcounts. These things needs to be cleaned
up by if further steps of initialization fail by calling functionfs_unbind().
Signed-off-by: Robert Baldyga
---
drivers/usb/gadget/function/f_fs.c | 10
Hello,
This patch set contains few small bugfixes found in usb gadget functions
and UDC drivers. The most important is the [1] as it fixes bug causing
BUG_ON() in f_fs driver. Remaining patches contain minor fixes.
Best regards,
Robert Baldyga
[1] usb: gadget: ffs: call functionfs_unbind() if _f
On Tue, Jul 7, 2015 at 1:53 PM, SF Markus Elfring
wrote:
>> I think that as far as these kernel mailing lists are concerned,
>> the date of the update suggestion is the date on which you submitted the
>> patch,
>> rather than the date you originally committed it to your local tree.
>
> I imagine
> On 07 Jul 2015, at 15:51, Alessio Igor Bogani
> wrote:
>
>> Current VME stack links windows not to the boards, but to device drivers.
>> Driver
>> could potentially minimise window usage within it’s scope (any sort of
>> window
>> reusing, like mapping whole A16 once to be used with all boar
Hi Dmitry,
On 7 July 2015 at 12:47, Dmitry Kalinkin wrote:
[...]
> The API I had in mind would have only vme_master_read and vme_master_write
> that would take absolute addresses (not relative to any window). These
> variants
> of access functions would then try to reuse any window that is alread
> I think that as far as these kernel mailing lists are concerned,
> the date of the update suggestion is the date on which you submitted the
> patch,
> rather than the date you originally committed it to your local tree.
I imagine that there are committers who would like to keep
corresponding so
On di, 2015-07-07 at 10:20 +, Dexuan Cui wrote:
> OK, removing the line seems better than 'default n', though both
> reproduce the same "# CONFIG_HYPERV_SOCK is not set".
Speaking from memory (so chances are I'm forgetting some silly detail)
that is because
# CONFIG_FOO is not set
will b
On Mon, 29 Jun 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> rts522a(rts5227s) is derived from rts5227, and mainly same with rts5227.
> Add it to file mfd/rts5227.c to support this chip.
>
> Signed-off-by: Micky Ching
> ---
> drivers/mfd/Kconfig | 7 ++--
> drivers
On Tue, Jul 07, Dexuan Cui wrote:
> OK, removing the line seems better than 'default n', though both reproduce
> the same "# CONFIG_HYPERV_SOCK is not set".
Perhaps "default VMBUS" (or whatever syntax is needed) may be the way to
enable it conditionally.
Olaf
Hi Alessio,
[Sorry for double post]
> On 07 Jul 2015, at 10:08, Alessio Igor Bogani
> wrote:
>
> Hi Dmitry,
>
> On 6 July 2015 at 19:24, Dmitry Kalinkin wrote:
> [...]
> I'm not a VME expert, but it seems that VME windows are a quiet limited
> resource
> no matter how you allocate your reso
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Tuesday, July 7, 2015 18:10
> To: Dexuan Cui; Paul Bolle
> Cc: gre...@linuxfoundation.org; da...@davemloft.net;
> net...@vger.kernel.org; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; a...@ca
On Tue, Jul 07, Paul Bolle wrote:
> On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote:
> > --- /dev/null
> > +++ b/net/hv_sock/Kconfig
>
> > +config HYPERV_SOCK
> > + tristate "Microsoft Hyper-V Socket (EXPERIMENTAL)"
> > + depends on HYPERV
> > + default m
> It's a bit odd to advise to s
> -Original Message-
> From: Paul Bolle
> Sent: Tuesday, July 7, 2015 17:38
> To: Dexuan Cui
> Subject: Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature
>
> Just two nits.
>
> On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote:
> > --- /dev/null
> > +++ b/net/hv_sock/Kconfig
>
On Tue, Jul 07, 2015 at 11:16:04AM +0200, P. Varet wrote:
> On 07/06/2015 07:13 PM, Greg KH wrote:
>
> >But, have you tried the in-kernel driver for this device?
>
> Hi Greg! Yes, I have. Sorry for not making this clear. The symptoms
> are as described in bug #57171. I haven't tested it again in
Just two nits.
On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote:
> --- /dev/null
> +++ b/net/hv_sock/Kconfig
> +config HYPERV_SOCK
> + tristate "Microsoft Hyper-V Socket (EXPERIMENTAL)"
> + depends on HYPERV
> + default m
> + help
> + Hyper-V Socket is a socket protocol si
Fix coding style error by removing spaces before ',' as suggested by
checkpatch.pl script.
Signed-off-by: Sunil Shahu
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
b/drivers/
On Mon, Jul 06, 2015 at 07:22:09PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jun 26, 2015 at 04:43:44PM +0200, Luis de Bethencourt wrote:
> > Patches to be applied on top of
> > https://patchwork.kernel.org/patch/6655831/
>
> I don't use patchwork, and when on an airplane with no internet access
On 07/06/2015 07:13 PM, Greg KH wrote:
But, have you tried the in-kernel driver for this device?
Hi Greg! Yes, I have. Sorry for not making this clear. The symptoms are as
described in bug #57171. I haven't tested it again in recent months but I can do
that for you when I'm back home if you
On Tue, Jul 7, 2015 at 9:54 AM, SF Markus Elfring
wrote:
>> No need to try and preserve it.
>
> I find that it might occasionally help to share and keep the record
> on timestamps about the evolution for an original update suggestion.
I think that as far as these kernel mailing lists are concern
These macros were only defined but not used anywhere.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xx.h | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
index 4bed094..31a21bd 100644
--- a/
Now since the Big-Endian and Little-Endian based calculations are moved
into a macro we can make fb_read() and fb_write() common for both
Little-Endian and Big-Endian.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 4
1 file changed, 4 deletions(-)
diff --git a/driv
We were checking smtc_regbaseaddress and that too at a place where it
can never be NULL. Real check should be on sfb->lfb immediately after
we do ioremap.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
d
We were only using the kernel commandline to set the mode if this driver
is builtin, but when it is built as a module we were not having any way
to set the mode. Start using commandline even if it is built as a
module.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 2 --
Define and use some new macros to work with different situations
based on little-endian and big-endian.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xx.h | 19
drivers/staging/sm7xxfb/sm7xxfb.c | 48 ---
2 files changed, 29
Few more changes in sm7xxfb, and hopefully the last changes before I
send the patch to move it to drivers/video/fbdev.
Has been tested with:
1) fbtest available at
https://git.kernel.org/cgit/linux/kernel/git/geert/fbtest.git/
2) read and write tested on Little-Endian system
regards
sudip
Sudi
> The date, as far as I know, is ignored. It is the commit date,
> not the authoring date, and once your patch is applied by a maintainer
> (i.e. committed), the date gets reset anyway.
Thanks for your feedback.
> No need to try and preserve it.
I find that it might occasionally help to share a
Hi Dmitry,
On 6 July 2015 at 19:24, Dmitry Kalinkin wrote:
[...]
>
> I'm not a VME expert, but it seems that VME windows are a quiet limited
> resource
> no matter how you allocate your resources. Theoretically we could put up to 32
> different boards in a single crate, so there won't be enough
58 matches
Mail list logo
