On Tue, Jul 7, 2015 at 8:21 AM, SF Markus Elfring
wrote:
>>> From: Markus Elfring
>>> Date: Sat, 27 Jun 2015 15:56:57 +0200
>>
>> Why is this in the body of the email?
>
> Does the canonical patch format support to preserve
> specific details about a shown commit by specification
> of fields like
>> From: Markus Elfring
>> Date: Sat, 27 Jun 2015 15:56:57 +0200
>
> Why is this in the body of the email?
Does the canonical patch format support to preserve
specific details about a shown commit by specification
of fields like "Date" and "From" in the message body?
Regards,
Markus
___
It is to fix:
hv_kvp_daemon.c:705:2: warning: format not a string literal and no format
arguments [-Wformat-security]
Signed-off-by: Dexuan Cui
---
tools/hv/hv_kvp_daemon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
in
On Mon, 2015-07-06 at 19:36 -0700, Greg KH wrote:
> On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote:
> > On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote:
[]
> > > Here is another version with macro expansion. Inline function
> > > expansion doesn't
> > > seem like a
On Mon, Jul 06, 2015 at 09:53:26PM -0400, Sreenath Madasu wrote:
> When the checkpatch.pl script was run, it showed lines with length
> more than 80 characters in rtw_ap.c file. Fixed line number 382 by
> breaking it up into two lines within 80 characters.
>
> Signed-off-by: Sreenath Madasu
> ---
On Sat, Jun 27, 2015 at 04:36:14PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 27 Jun 2015 15:56:57 +0200
Why is this in the body of the email? Please fix your email client or
just use git send-email properly.
___
devel mailing
On Sat, Jun 27, 2015 at 04:37:24PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 27 Jun 2015 16:00:59 +0200
Again, please fix.
>
> The kfree() function was called in two cases by the mac_ioctl() function
> during error handling even if the passed variable did not contain a
On Tue, Jun 30, 2015 at 05:34:37PM +0900, Dean Lee wrote:
> modify it
modify what?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote:
> On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote:
> > This patch fixes the checkpatch.pl error:
> >
> > ERROR: Macros with complex values should be enclosed in parentheses
> > +#define CONSUME(val, ptr) (val) = consume(sizeof
On Fri, Jun 26, 2015 at 04:43:44PM +0200, Luis de Bethencourt wrote:
> Patches to be applied on top of
> https://patchwork.kernel.org/patch/6655831/
I don't use patchwork, and when on an airplane with no internet access
(like right now), a url provides no context at all. Always use email
subject
On Tue, Jun 30, 2015 at 05:34:38PM +0900, Dean Lee wrote:
> Signed-off-by: Dean Lee
delete what unused value? And why?
Please rework this whole series and resend.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.
On Tue, Jun 30, 2015 at 05:34:34PM +0900, Dean Lee wrote:
> delete odd structure and rework it.
what do you mean by "rework it"? It looks like you just made it a void
* everywhere, which is what I explicitly said to not do.
sorry, can't take this.
greg k-h
__
When the checkpatch.pl script was run, it showed lines with length
more than 80 characters in rtw_ap.c file. Fixed line number 382 by
breaking it up into two lines within 80 characters.
Signed-off-by: Sreenath Madasu
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 3 ++-
1 file changed, 2 insertio
When packet encapsulation is in use, the MTU needs to be reduced for
headroom reservation.
The existing code takes the updated MTU value only from the host side.
But vSwitch extensions, such as Open vSwitch, require the flexibility
to change the MTU to different values from within a guest during th
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Friday, July 3, 2015 12:17 PM
> To: dan.carpen...@oracle.com
> Cc: Haiyang Zhang; net...@vger.kernel.org; o...@aepfle.de;
> jasow...@redhat.com; driverdev-devel@linuxdriverproject.org; linux-
> ker...@vger.kern
On Mon, Jul 6, 2015 at 5:48 PM, Martyn Welch wrote:
>
>
> On 06/07/15 14:50, Dmitry Kalinkin wrote:
>>
>> On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch wrote:
>>>
>>>
>>> Sorry about the *really* late reply, loads of emails some how missed my
>>> periodic search of the mailing list.
>>>
>>> I'm ha
On Mon, Jul 06, 2015 at 07:01:30PM +0200, P. Varet wrote:
> On 07/06/2015 06:47 PM, Greg KH wrote:
>
> >How about making it a patch for drivers/staging/ ? That way the code
> >can get cleaned up in-tree by others?
>
> Ah, I thought that was what I did? As in, I checked out the kernel git
> repos
On 07/06/2015 06:47 PM, Greg KH wrote:
How about making it a patch for drivers/staging/ ? That way the code
can get cleaned up in-tree by others?
Ah, I thought that was what I did? As in, I checked out the kernel git
repository, moved the driver code into drivers/staging/, and used git diff
From: Dmitry Eremin
It is no longer used anywhere.
Signed-off-by: Dmitry Eremin
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 1 -
drivers/staging/lustre/lustre/libcfs/debug.c | 3 ---
drivers/staging/lustre/lustre/libcfs/module.c | 12 --
From: Oleg Drokin
module parameter libcfs_console_backoff accessible through
/sys/module/libcfs/parameters/libcfs_console_backoff would
do the same thing, just add a special "uintpos" parameter
type to disallow 0 values too.
Also add a symlink to the module parameter variable for
backwards compat
From: Oleg Drokin
Since all of the variables from /proc/sys/lustre were moved to
/sys/fs/lustre, get rid of the remaining infrastructure.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_class.h | 1 -
drivers/staging/lustre/lustre/obdclass/class_obd.c | 1 -
.../lus
From: Oleg Drokin
ldlm_timeout is used server-side to determine AST timeouts,
so it makes no sense on the client, esp. since it's not really used
anywhere.
Remove all traces of it except from the config where make
it a noop.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/
From: Oleg Drokin
/proc/sys/lnet/console_ratelimit, debug_path and panic_on_lbug
are module parameters with no special magic accessible via
/sys/module/libcfs/parameters/libcfs_console_ratelimit,
/sys/module/libcfs/parameters/libcfs_debug_file_path and
/sys/module/libcfs/parameters/libcfs_panic_o
From: Oleg Drokin
It's just a fancy libcfs_debug_mb module parameter wrapper,
so just add debug buffer size check and resizing and the same
functionality now would be accessible via
/sys/module/libcfs/parameters/libcfs_debug_mb
Also add a symlink for backwards compatibility.
Signed-off-by: Oleg
From: Dmitry Eremin
/proc/sys/lnet/lnet_memused
Remove memory tracking for LNet.
Remove redundant enums definition.
Signed-off-by: Dmitry Eremin
---
.../lustre/include/linux/libcfs/libcfs_private.h | 28 +--
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 12 ---
.../sta
From: Dmitry Eremin
Remove portal_enter_debugger because it's not used any more.
Signed-off-by: Dmitry Eremin
---
drivers/staging/lustre/lustre/libcfs/debug.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c
b/drivers/staging/lustre/lustre/lib
From: Dmitry Eremin
They are just fancy module parameters wrappers,
so just the same functionality now would be accessible via
/sys/module/libcfs/parameters/libcfs_console_{min,max}_delay
Also install compatibility symlinks
Signed-off-by: Dmitry Eremin
Signed-off-by: Oleg Drokin
---
drivers/
From: Oleg Drokin
Parameters in lnet sysctl are of debug quantity, so let's move them
to debugfs instead.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/module.c | 86 +--
1 file changed, 56 insertions(+), 30 deletions(-)
diff --git a/drivers/stagi
From: Oleg Drokin
max_dirty_mb is now a parameter in /sys/fs/lustre/
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/obdclass/linux/linux-sysctl.c| 74 +-
drivers/staging/lustre/sysfs-fs-lustre | 12
2 files changed, 43 insertions(+), 43 deletions(-)
From: Oleg Drokin
In the past when Lustre did its own allocation amounts tracking
the results were shown in sysctl as current and overall max
number of bytes and pages allocated. Now that we don't
track these, remove the sysctls.
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/obdclass/linux/
From: Oleg Drokin
Adaptive Timeouts controls are being moved from /proc/sys/lustre
to /sys/fs/lustre
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/obdclass/linux/linux-sysctl.c| 45 --
drivers/staging/lustre/sysfs-fs-lustre | 53 ++
2 file
From: Oleg Drokin
debug_peer_on_timeout, dump_on_timeout and dump_on_eviction
controls from /proc/sys/lustre to /sys/fs/lustre
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/obdclass/linux/linux-sysctl.c| 28 ++
drivers/staging/lustre/sysfs-fs-lustre | 26
From: Oleg Drokin
This helps to avoid use after free on unmount.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_obd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c
b/drivers/staging/lustre/lustre/lo
From: Oleg Drokin
This is the first step of moving lustre sysctls from
/proc/sys/lustre to /sys/fs/lustre
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_class.h | 4 +-
drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +-
.../lustre/lustre/obdclass/linux/linu
From: Oleg Drokin
It was used to control allocation failure rate, but there is
in-kernel way of doing that that's more versatile too.
This is going to remove just the sysctl, the underlying variable
will be removed once all OBD_ALLOC* macros removal patchseries land.
Signed-off-by: Oleg Drokin
From: Oleg Drokin
ldebugfs_remove is usually called on directories with files passed in
as attributes, so simple debugfs_remove failes on them as not empty
Switch to debugfs_remove_recursive.
This fixes a number of problems where a new filesystem is mounted after
being unmounted first.
Signed-o
From: Oleg Drokin
Dan Carpenter noticed that procfs conversion patches introduced
a bug where should kobject_create_and_add, an error is not returned
from class_procfs_init.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 2 +-
1 file changed, 1 ins
From: Oleg Drokin
This patch series removes the sysctls (also under /proc) from Lustre.
/proc/sys/lnet is moved to debugfs and
/proc/sys/lustre content is moved to /sys/fs/lustre
Additionally we now have the tools that understand the new layout,
and so first few patches fix problems introduced b
From: Oleg Drokin
It turns out if you call ldlm_pools_fini without completing the
ldlm_pools_init, then attempt to unregister not yet registered
shrinkers makes the kernel very unhappy.
So make sure we have them registered first.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldl
On Mon, Jul 06, 2015 at 06:25:25PM +0200, P. Varet wrote:
> Hi all,
>
> This is me keeping a promise I made to Greg KH half a year ago. (Thread
> here:
> https://www.reddit.com/r/linux/comments/2ny1lz/im_greg_kroahhartman_linux_kernel_developer_ama/cmhyvqh)
>
>
> WHAT IS THIS?
> =
>
That's the ticket :-)
On 06/07/15 15:43, Dmitry Kalinkin wrote:
This will enable error messages for accesses done through mmap.
Signed-off-by: Dmitry Kalinkin
---
This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset.
---
drivers/vme/vme.c | 7 +++
1 file changed, 7 ins
On 06/07/15 14:50, Dmitry Kalinkin wrote:
On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch wrote:
Sorry about the *really* late reply, loads of emails some how missed my
periodic search of the mailing list.
I'm happy with the addition of DMA, just not sure whether it's worth adding
an extra dev
Hi Paul,
On Mon, 6 Jul 2015 09:42:47 -0400 Paul Gortmaker
wrote:
>
> [Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on
> CLKDEV_LOOKUP] On 06/07/2015 (Mon 08:48) Stephen Rothwell wrote:
>
> > On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven
> > wrote:
> > >
> > > On Sat,
This will enable error messages for accesses done through mmap.
Signed-off-by: Dmitry Kalinkin
---
This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset.
---
drivers/vme/vme.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index
On 13/06/15 01:28, Greg Kroah-Hartman wrote:
On Thu, May 28, 2015 at 03:07:05PM +0300, Dmitry Kalinkin wrote:
This introduces a new dma device that provides a single ioctl call that
provides DMA read and write functionality to the user space.
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
-
Hi Martyn,
> On 06 Jul 2015, at 15:31, Martyn Welch wrote:
>
> These are looking good to me.
Thank you for finding time to look at this and the others.
>
> You mention error handling in relation to vme_master_mmap, am I right in
> thinking patch 3 avoids errors being recorded when triggered by
On 06/07/15 14:41, Geert Uytterhoeven wrote:
Signed-off-by: Geert Uytterhoeven
---
drivers/staging/comedi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 7dee73dfbf88ff09..57e71f9f14a2385b 100644
Since this is turning into a long thread, the correct thing is to copy
3eb141511bd5 ('staging: dgap: get rid of nasty DGAP_VERIFY_BOARD macro').
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverprojec
Hi Paul,
On Mon, Jul 6, 2015 at 3:42 PM, Paul Gortmaker
wrote:
> BTW, Chen's patch is missing the OF_IRQ dependency Geert found in
> his build coverage; I'd folded that into the v2 above, figuring
> that is what he'd desired I do with it.
Which I'm very grateful for. Thanks!
Gr{oetje,eeting}s,
On 06/07/15 14:10, Dmitry Kalinkin wrote:
On Mon, Jul 6, 2015 at 3:51 PM, Martyn Welch wrote:
On 26/06/15 21:39, Dmitry Kalinkin wrote:
Signed-off-by: Dmitry Kalinkin
---
drivers/staging/vme/devices/vme_user.c | 47
--
1 file changed, 11 insertions(+),
On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch wrote:
>
> Sorry about the *really* late reply, loads of emails some how missed my
> periodic search of the mailing list.
>
> I'm happy with the addition of DMA, just not sure whether it's worth adding
> an extra device file just to handle DMA. Could th
[Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on
CLKDEV_LOOKUP] On 06/07/2015 (Mon 08:48) Stephen Rothwell wrote:
> Hi all,
>
> On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven
> wrote:
> >
> > On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang
> > wrote:
> > > It needs clk_add_
Signed-off-by: Geert Uytterhoeven
---
drivers/staging/comedi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 7dee73dfbf88ff09..57e71f9f14a2385b 100644
--- a/drivers/staging/comedi/Kconfig
+++ b/drive
Hyper-V VM Sockets (hvsock) is a byte-stream based communication mechanism
between Windowsd 10 (or later) host and a guest. It's kind of TCP over
VMBus, but the transportation layer (VMBus) is much simpler than IP.
With Hyper-V VM Sockets, applications between the host and a guest can
talk with eac
On Mon, 06 Jul 2015 18:50:12 +0530, Ravi Teja Darbha said:
> Why would you use a macro to avoid code duplication?
The macro does end up putting code in each place it's used.
However, the actual code is in one place rather than open-coded
in multiple places that can diverge over time (somebody patc
In the SMP guest case, when the per-channel callback hvsock_events() is
running on virtual CPU A, if the guest tries to close the connection on
virtual CPU B: we invoke vmbus_close() -> vmbus_close_internal(),
then we can have trouble: on B, vmbus_close_internal() will send IPI
reset_channel_cb() t
Hyper-V VM sockets (hvsock) supplies a byte-stream based communication
mechanism between the host and a guest. It's kind of TCP over VMBus, but
the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM
Sockets, applications between the host and a guest can talk with each
other direc
This will be used by the coming net/hvsock driver.
Signed-off-by: Dexuan Cui
---
include/linux/hyperv.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 307910b3..c52f4cb 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv
With the 2 APIs supplied by the VMBus driver, the coming net/hvsock driver
can register 2 callbacks and can know when a new hvsock connection is
offered by the host, and when a hvsock connection is being closed by the
host.
Signed-off-by: Dexuan Cui
---
drivers/hv/Makefile | 4 ++-
dr
This will be used by the coming net/hvsock driver.
Signed-off-by: Dexuan Cui
---
drivers/hv/channel.c | 131 ++
drivers/hv/hyperv_vmbus.h | 4 ++
drivers/hv/ring_buffer.c | 14 +
include/linux/hyperv.h| 33
4 files change
A function to send the type of message is also added.
The coming net/hvsock driver will use this function to proactively request
the host to offer a VMBus channel for a new hvsock connection.
Signed-off-by: Dexuan Cui
---
drivers/hv/channel.c | 15 +++
drivers/hv/channel_mgmt.c
A helper function is also added.
Signed-off-by: Dexuan Cui
---
include/linux/hyperv.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 30d3a1f..aa21814 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -236,6 +236,
Hi Dmitry,
These are looking good to me.
You mention error handling in relation to vme_master_mmap, am I right in
thinking patch 3 avoids errors being recorded when triggered by an mmap
access (so as not to appear as a spurious error on a later access)?
I think it would be worth at least log
Why would you use a macro to avoid code duplication?
Regards,
Ravi Teja
On Mon, Jul 06, 2015 at 05:57:06PM +0530, Sudip Mukherjee wrote:
> That is why the macro is there, to avoid the duplication of code.
___
devel mailing list
de...@linuxdriverproject.
Hyper-V VM Sockets (hvsock) is a byte-stream based communication mechanism
between Windowsd 10 (or later) host and a guest. It's kind of TCP over
VMBus, but the transportation layer (VMBus) is much simpler than IP.
With Hyper-V VM Sockets, applications between the host and a guest can
talk with eac
On Mon, Jul 6, 2015 at 3:51 PM, Martyn Welch wrote:
> On 26/06/15 21:39, Dmitry Kalinkin wrote:
>>
>> Signed-off-by: Dmitry Kalinkin
>> ---
>> drivers/staging/vme/devices/vme_user.c | 47
>> --
>> 1 file changed, 11 insertions(+), 36 deletions(-)
>>
>> diff --gi
On 26/06/15 21:39, Dmitry Kalinkin wrote:
Signed-off-by: Dmitry Kalinkin
---
drivers/staging/vme/devices/vme_user.c | 47 --
1 file changed, 11 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
b/drivers/staging/vme/devices/vm
On 25/06/15 13:05, Dmitry Kalinkin wrote:
This is why I think this is not a “we broke userspace” situation.
The vme_user module is also in the staging tree and (almost) by
definition the API shouldn't be considered as stable.
Martyn
--
Martyn Welch (Lead Software Engineer) | Registered
On Mon, Jul 06, 2015 at 05:45:24PM +0530, Ravi Teja Darbha wrote:
> What you need to do is to replace all DGNC_VERIFY_BOARD() macro calls with
> its definition.
And repeating the same code 12 times??
That is why the macro is there, to avoid the duplication of code.
regards
sudip
_
Joe Perches writes:
>> So, could we have the localized readability when it makes sense,
>> and the default rules when nothing else applies?
>
> Then the question becomes how local.
The answer seems easy to me: as much as it's needed to get the best
readability.
If that means 4 or 2 custom forma
What you need to do is to replace all DGNC_VERIFY_BOARD() macro calls with its
definition.
Regards,
Ravi Teja
On Sun, Jul 05, 2015 at 11:46:28PM +0530, Arjun Krishna Babu wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Macros with flow control statements should be avoided
>
>
On Mon, 2015-07-06 at 08:07 +0200, Krzysztof Hałasa wrote:
> Joe Perches writes:
> > Nah, you're not an extremist, you're just preferring narrowly
> > localized readability over global consistency.
> >
> > That's fine and all, until you come up to LCONSOLE_ERROR_MSG
> > type use which blows the ni
On Mon, Jul 06, 2015 at 08:07:52AM +0200, Krzysztof Hałasa wrote:
> Joe Perches writes:
>
> > Nah, you're not an extremist, you're just preferring narrowly
> > localized readability over global consistency.
> >
> > That's fine and all, until you come up to LCONSOLE_ERROR_MSG
> > type use which bl
On Sun, Jul 05, 2015 at 11:46:28PM +0530, Arjun Krishna Babu wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Macros with flow control statements should be avoided
>
> Replace the macro with a function doing the exact same task as the
> macro.
>
No. You haven't understood what
74 matches
Mail list logo
