Re: [PATCH v4 4/9] staging:lustre: merge socklnd_lib-linux.h into socklnd.h

On Thu, Jun 25, 2015 at 3:33 AM, Guenter Roeck wrote: > I have not tested it, but I think the following may fix the problem > while avoiding any include problems. Since pt_regs is used in the file, > one could argue that it should be declared. Indeed. I tried that, but... > -- > diff --git a/arc

Re: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error code

On Wed, Jun 24, 2015 at 11:22:24PM +0530, Santosh wrote: > try_module_get fails when the reference count of the module is not > allowed to be incremented ,and hence -ENXIO is returned indicating > no device or address. 1) this patch is 2/2, but then where is your 1/2 patch? 2) You have used "

Re: [PATCH v2] staging: rtl8192u: bool tests don't need comparisons

On Wed, Jun 24, 2015 at 12:12:01PM +0200, Luis de Bethencourt wrote: > On Wed, Jun 24, 2015 at 11:05:16AM +0530, Sudip Mukherjee wrote: > > On Tue, Jun 23, 2015 at 03:10:56PM +0200, Luis de Bethencourt wrote: > > I based the patch on staging's master and not on the staging-next branch. use staging

Re: [PATCH v2 07/10] staging: wilc1000: remove ununsed variable

On Wed, Jun 24, 2015 at 04:23:23PM +, Gujulan Elango, Hari Prasath (H.) wrote: > On Tue, Jun 23, 2015 at 11:49:24AM +0300, Dan Carpenter wrote: > > On Mon, Jun 22, 2015 at 01:13:58PM +, Gujulan Elango, Hari Prasath (H.) > > wrote: > > > From: Hari Prasath Gujulan Elango > > > > > > This

Re: [PATCH v4 4/9] staging:lustre: merge socklnd_lib-linux.h into socklnd.h

On Wed, Jun 24, 2015 at 02:37:51PM +0200, Geert Uytterhoeven wrote: > Hi James, > > On Thu, Jun 11, 2015 at 9:18 PM, James Simmons wrote: > > From: John L. Hammond > > > > Originally socklnd_lib-linux.h contained linux specific > > wrappers and defines but since the linux kernel is the > > only

RE: [lustre-devel] [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

>> Yes. I know Al's thoughts and kernel style. >> >> But Alan Cox and Andreas have both said they think (x == NULL) can help >> you avoid some kind of boolean vs pointer bugs. I've had co-workers who >> did massive seds changing !foo to foo == NULL on our code base. But >> I've never seen a real

[PATCH] Staging:rtl8192u: fixed coding style issues

Fixed the following coding style issues: r819xU_firmware.c:72: ERROR: space required after that ',' (ctx:VxO) r819xU_firmware.c:72: ERROR: space required before that '&' (ctx:OxV) r819xU_firmware.c:72: ERROR: space required after that ',' (ctx:VxV) r819xU_firmware.c:97: ERROR: space required after

[PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error code

try_module_get fails when the reference count of the module is not allowed to be incremented ,and hence -ENXIO is returned indicating no device or address. Signed-off-by: santhosh pai --- drivers/staging/comedi/comedi_fops.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()

On Wed, Jun 24, 2015 at 12:19:27PM +0200, Luis de Bethencourt wrote: > On Wed, Jun 24, 2015 at 10:53:30AM +0530, Sudip Mukherjee wrote: > > On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote: > > > On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote: > > > > Nope. Your p

[PATCHv2] staging: sm750fb: remove redundant __func__ in debug statement

From: Hari Prasath Gujulan Elango This patch removes the redundant __func__ from dynamic debug prints as the pr_xxx set of functions can be dynamically controlled to include function name.Also fix a typo in debug statement. Signed-off-by: Hari Prasath Gujulan Elango --- v2:Address Dan C

Re: [PATCH] staging: sm750fb: convert pr_err to pr_info

On Mon, Jun 22, 2015 at 06:15:06PM +0300, Dan Carpenter wrote: > On Thu, Jun 18, 2015 at 12:56:54PM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > From: Hari Prasath Gujulan Elango > > > > This patch modifies few debug prints from pr_err() to pr_info() as they > > fall under that category

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote: > On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote: > > /* WMM spec P.11: The minimum value for AIFSN shall be 2 */ > > qos_param->aifs[aci] = (qos_param->aifs[aci] < 2) ? > > 2:qos_param->aifs[aci]

Re: [PATCH] staging: sm750fb: use tabs for indentation

On Wed, Jun 24, 2015 at 2:28 AM, Dan Carpenter wrote: > Have you sent this patchset to the list? I don't see it in my inbox. > > regards, > dan carpenter Odd, I sent it on Saturday. Anyways made a change to it and just sent in v3. Thanks Juston ___ de

[PATCH v3 19/19] staging: sm750fb: add missing blank line after declarations

fixes checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 1 + drivers/staging/sm750fb/ddk750_display.c | 2 ++ drivers/staging/sm750fb/ddk750_dvi.c | 1 + drivers/staging/sm750fb/ddk750_mode.c| 3 +++ dr

[PATCH v3 09/19] staging: sm750fb: add space after struct definition

fixes checkpatch.pl warning: WARNING: missing space after struct definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 12 ++-- drivers/staging/sm750fb/sm750_hw.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/sm750fb/sm

[PATCH v3 14/19] staging: sm750fb: remove trailing whitespace

fixes checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 4 ++-- drivers/staging/sm750fb/sm750_hw.c| 24 3 files changed, 15 insertions(+), 15 deletions(

[PATCH v3 13/19] staging: sm750fb: add space after semicolon

fixes checkpatch.pl error: ERROR: space required after that ';' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/

[PATCH v3 12/19] staging: sm750fb: add spaces around operators

fixes checkpath.pl error: ERROR: spaces required around that '' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_power.c | 2 +- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_accel.c | 4 ++-- drivers/s

[PATCH v3 16/19] staging: sm750fb: fix brace placement

Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.h| 12 +++ drivers/staging/sm750fb/ddk750_display.c | 54 ++-- drivers/staging/sm750fb/d

[PATCH v3 15/19] staging: sm750fb: remove unnecessary whitespace

fixes checkpatch.pl warning: WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_hw.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750

[PATCH v3 18/19] staging: sm750fb: remove unnecessary braces

fixes checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 9 +++-- drivers/staging/sm750fb/sm750_hw.c| 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/driver

[PATCH v3 10/19] staging: sm750fb: add space after return type

fixes checkpatch.pl warning: WARNING: missing space after return type Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 124921e..320

[PATCH v3 08/19] staging: sm750fb: add space after enum definition

fixes checkpatch.pl warning: WARNING: missing space after enum definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/sm750_hw.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/dd

[PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

fixes checkpatch.pl error: ERROR: need consistent spacing around '' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 4 ++-- drivers/staging/sm750fb/ddk750_display.h | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 4 ++-

[PATCH v3 17/19] staging: sm750fb: move while statement to follow do close brace

fixes checkpatch.pl error: ERROR: while should follow close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_

[PATCH v3 06/19] staging: sm750fb: add space before open brace

fixes checkpatch.pl error: ERROR: space required before the open brace '{' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 14 drivers/staging/sm750fb/ddk750_mode.c| 8 ++--- drivers/staging/sm750fb/ddk750_power.c | 4 +-- drivers/staging/sm750fb/sm750_ac

[PATCH v3 07/19] staging: sm750fb: add space after close brace

fixes checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c| 2 +- drivers/staging/sm750fb/ddk750_power.c | 2 +- drivers/staging/sm750fb/sm750.h

[PATCH v3 04/19] staging: sm750fb: add space before open parenthesis

fixes checkpatch.pl error: ERROR: space required before the open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 20 +-- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_help.c| 2 +- drivers/staging/sm750fb/ddk

[PATCH v3 05/19] staging: sm750fb: remove space between function name and parenthesis

fixes checkpatch.pl warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st

[PATCH v3 03/19] staging: sm750fb: remove space before close parenthesis

fixes checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 2 +- 3 files changed, 3 insertions(+), 3 deletion

[PATCH v3 01/19] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl error ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 100 drivers/staging/sm750fb/ddk750_display

[PATCH v3 02/19] staging: sm750fb: remove spacing after open parenthesis

fixes checkpatch.pl warning: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_power.c | 8 drivers/staging/sm750fb/sm750_h

Re: [PATCH v2 07/10] staging: wilc1000: remove ununsed variable

On Tue, Jun 23, 2015 at 11:49:24AM +0300, Dan Carpenter wrote: > On Mon, Jun 22, 2015 at 01:13:58PM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > From: Hari Prasath Gujulan Elango > > > > This patch removes ununsed variable 'len' > > > > Signed-off-by: Hari Prasath Gujulan Elango > >

Re: [PATCH] staging/lustre/lnet: Move asm/irq.h include after linux includes

Hi Oleg, On Wed, Jun 24, 2015 at 4:07 PM, wrote: > From: Oleg Drokin > > Apparently m86k cannot build if you include asm/irq.h before > linux/* includes and fixing it there is hard. > So just move asm/irq.h include to where it does not cause any problems. > > Thanks to Geert Uytterhoeven for ge

[PATCH v3 00/19] staging: sm750fb: checkpatch.pl fixes

This patch set includes 19 patches fixing indentation, spacing, brace placement and missing blank lines from checkpatch.pl warnings/errors in staging/sm750fb. Regards Juston - Changes since v2: * Fix Subject * Don't rearrange lines in PATCH 01 * Split up spacing fixes patch by che

Patch Proof for Greg

Greetings Greg and others, I am sending a two part patch fix to prove to Greg I have changed. Below this message are the patches for a bug fix in the gma500 driver code. Unfortunately I haven't gotten a maintainer acknowledge and therefore it's not in the merge for the 4.1 release. Nick Patch 1

from david chen

hey. how are you? http://shotznaturalenergy.com/health/ ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

from david chen

hey. how are you? http://bigappleeventav.com/health/ ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging/lustre/lnet: Move asm/irq.h include after linux includes

From: Oleg Drokin Apparently m86k cannot build if you include asm/irq.h before linux/* includes and fixing it there is hard. So just move asm/irq.h include to where it does not cause any problems. Thanks to Geert Uytterhoeven for getting to the root of it. Signed-off-by: Oleg Drokin --- Geert,

[PATCH] staging/lustre/lov: Move target sysfs symlink removal to LOV freeing

From: Oleg Drokin This helps to avoid use after free on unmount. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_obd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/staging/lustre/lustre/lo

[PATCH v4 1/2] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

Loaded Hyper-V module will use these functions to disable CPU hotplug under certain circumstances. Convert cpu_hotplug_disabled to a counter (protected by cpu_add_remove_lock) to support e.g. disable -> disable -> enable call sequences. Signed-off-by: Vitaly Kuznetsov --- Documentation/power/sus

[PATCH v4 2/2] Drivers: hv: vmbus: use cpu_hotplug_enable/disable

Commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors") was altering smp_ops.cpu_disable to prevent CPU offlining. We can bo better by using cpu_hotplug_enable/disable functions instead of such hard-coding. Reported-by: Radim Krčmář Signed-off-by: Vitaly Kuznetsov

[PATCH v4 0/2] Drivers: hv: vmbus: use cpu_hotplug_enable/disable for CPU offlining prevention

Changes since v3: - add WARN_ON when decreasing cpu_hotplug_disabled [Peter Zijlstra] Changes since v2: - Rebase on top of current Greg's char-misc-next tree [K. Y. Srinivasan] Changes since v1: - Make cpu_hotplug_disabled a counter [Radim Krčmář] Export cpu_hotplug_enable/cpu_hotplug_disable fu

Re: [PATCH v4 4/9] staging:lustre: merge socklnd_lib-linux.h into socklnd.h

Hi James, On Thu, Jun 11, 2015 at 9:18 PM, James Simmons wrote: > From: John L. Hammond > > Originally socklnd_lib-linux.h contained linux specific > wrappers and defines but since the linux kernel is the > only supported platform now we can merge what little > remains in the header into socklnd

Do It Yourself, Clear, No Slip floor Treatment

Do It Yourself, Clear, No Slip floor Treatment Our Anti-Slip Floor Treatment Makes all types of hard mineral surface floors slip resistant and safe for a minimum of 4 Years-Guaranteed Indoors or outdoors Walk on immediately after a treatment. Use on ceramic, porcelain and quarry tiles, marble,

Re: [PATCH 1/1] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

Peter Zijlstra writes: > On Wed, Jun 24, 2015 at 11:43:33AM +0200, Vitaly Kuznetsov wrote: >> Peter Zijlstra writes: >> > On Tue, Jun 23, 2015 at 04:57:05PM +, KY Srinivasan wrote: >> > >> >> > diff --git a/kernel/cpu.c b/kernel/cpu.c >> >> > index 94bbe46..8f35ee6 100644 >> >> > --- a/kerne

Re: [PATCH 1/1] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

Thomas Gleixner writes: > On Wed, 24 Jun 2015, Vitaly Kuznetsov wrote: > >> Peter Zijlstra writes: >> >> > On Tue, Jun 23, 2015 at 04:57:05PM +, KY Srinivasan wrote: >> > >> >> > diff --git a/kernel/cpu.c b/kernel/cpu.c >> >> > index 94bbe46..8f35ee6 100644 >> >> > --- a/kernel/cpu.c >> >>

Re: [PATCH 1/1] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

On Wed, 24 Jun 2015, Vitaly Kuznetsov wrote: > Peter Zijlstra writes: > > > On Tue, Jun 23, 2015 at 04:57:05PM +, KY Srinivasan wrote: > > > >> > diff --git a/kernel/cpu.c b/kernel/cpu.c > >> > index 94bbe46..8f35ee6 100644 > >> > --- a/kernel/cpu.c > >> > +++ b/kernel/cpu.c > >> > @@ -190,1

Re: [PATCH 1/1] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

On Wed, Jun 24, 2015 at 11:43:33AM +0200, Vitaly Kuznetsov wrote: > Peter Zijlstra writes: > > On Tue, Jun 23, 2015 at 04:57:05PM +, KY Srinivasan wrote: > > > >> > diff --git a/kernel/cpu.c b/kernel/cpu.c > >> > index 94bbe46..8f35ee6 100644 > >> > --- a/kernel/cpu.c > >> > +++ b/kernel/cpu.c

Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()

On Wed, Jun 24, 2015 at 10:53:30AM +0530, Sudip Mukherjee wrote: > On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote: > > On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote: > > > Nope. Your patch is totally wrong (buggy). Please be more careful in > > > the future. >

Re: [PATCH v2] staging: rtl8192u: bool tests don't need comparisons

On Wed, Jun 24, 2015 at 11:05:16AM +0530, Sudip Mukherjee wrote: > On Tue, Jun 23, 2015 at 03:10:56PM +0200, Luis de Bethencourt wrote: > > Remove explicit true/false comparations to bool variables. > > > > Signed-off-by: Luis de Bethencourt > > --- > > > diff --git a/drivers/staging/rtl8192u/r8

[PATCH v2] staging: rtl8192u: remove bool comparisons

Remove explicit true/false comparisons to bool variables. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++-- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4 ++-- dri

Re: [PATCH 1/1] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

Peter Zijlstra writes: > On Tue, Jun 23, 2015 at 04:57:05PM +, KY Srinivasan wrote: > >> > diff --git a/kernel/cpu.c b/kernel/cpu.c >> > index 94bbe46..8f35ee6 100644 >> > --- a/kernel/cpu.c >> > +++ b/kernel/cpu.c >> > @@ -190,17 +190,19 @@ void cpu_hotplug_done(void) >> > void cpu_hotplug_

Re: [PATCH] staging: sm750fb: use tabs for indentation

On Mon, Jun 22, 2015 at 11:30:30AM -0700, Juston Li wrote: > On Mon, Jun 22, 2015 at 10:46 AM, Dan Carpenter > wrote: > > On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote: > >> void sii164ClearInterrupt(void) > >> { > >> -unsigned char detectReg; > >> + unsigned char detectReg;