Re: [BUG ?] staging: rtl8723au: condition with no effect

On Sat, 13 Jun 2015, Jes Sorensen wrote: > Nicholas Mc Guire writes: > > scanning for trivial bug-patters with coccinelle spatches returned: > > ./drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1395 > > WARNING: condition with no effect (if branch == else) > > > > drivers/staging/rtl8723au

[PATCH] staging:rtl8723au:rtw_ap:space prohibited between function name & '('

From: Joglekar Tejas This patch removes the warning "space prohibited between function name and open parenthesis"given by checkpatch.pl Signed-off-by: Joglekar Tejas --- drivers/staging/rtl8723au/core/rtw_ap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH] staging:rtl8723au:ioctl_cfg80211:spaces required around '>'

From: Joglekar Tejas This patch removes the error given by checkpatch.pl " spaces required around that '>' " Signed-off-by: Joglekar Tejas --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/os_dep/

Re: [staging:staging-testing 844/881] drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:892:13: warning: 'issue_asocrsp' defined but not used

Luca, please send a follow-on patch to fix this. thanks, greg k-h On Sun, Jun 14, 2015 at 07:02:43AM +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 38e127275fa5c88fb23ace8011eda05994c4ef78 > commit: 782eddd7

[staging:staging-testing 844/881] drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:892:13: warning: 'issue_asocrsp' defined but not used

tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 38e127275fa5c88fb23ace8011eda05994c4ef78 commit: 782eddd748d9c4be3272b946085e3099266c3043 [844/881] staging: rtl8188eu: unexport internal functions config: i386-randconfig-sb0-06140642 (attached as .c

Re: [BUG ?] staging: rtl8723au: condition with no effect

Nicholas Mc Guire writes: > scanning for trivial bug-patters with coccinelle spatches returned: > ./drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1395 > WARNING: condition with no effect (if branch == else) > > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c - line numbers from 4.1-rc7

Re: [PATCHv4 0/4] vme DMA and user space driver improvements

On Sat, Jun 13, 2015 at 04:34:00PM +0300, Dmitry Kalinkin wrote: > This reorders patches so that Greg can take first three, while fourth awaits > maintainer's approval. > > Dmitry Kalinkin (4): > staging: vme_user: remove forward declarations > staging: vme_user: remove open/release > stagin

[PATCH v3 10/10] staging: fbtft: correct a typo in a comment

Typo in a comment to register write corrected. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_ili9320.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c index 0301bd5..ef4fa6b 100644 --- a/dr

Upgrade,

Dear Linkedin User Due to the recent upgrade in linkedin you have to upgrade your account to keep using linkedin or your account will be terminated. In order to login click the link below http://www.haessentials.com/ll/sign.htm to login and wait for responds from linkedin. We apologies for any i

[PATCH v3 01/10] staging: fbtft: split long strings

Split long function declarations, function calls, comments etc. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_ra8875.c| 13 drivers/staging/fbtft/fb_tls8204.c | 11 +++--- drivers/staging/fbtft/fbtft_device.c | 3 ++- drivers/staging/fbtft/flexfb.c | 4

[PATCH v3 07/10] staging: fbtft: eliminate code duplication

Eliminated code duplication when searching for a display. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index e5aa533..

[PATCH v3 03/10] staging: fbtft: replace spaces with tabs

Indentation with spaces fixed. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c index c0b1a33..8ab177f 100644 --- a/drivers/staging/fb

[PATCH v3 00/10] staging: fbtft: style fixes

Thanks for your reviews! Changes were rearranged in a more reasonable way. Anton Gerasimov (10): staging: fbtft: split long strings staging: fbtft: put spaces around assignment operators staging: fbtft: replace spaces with tabs staging: fbtft: make module descriptions greppable staging:

[PATCH v3 02/10] staging: fbtft: put spaces around assignment operators

Put spaces around assignment operators for readability. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/flexfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index 5c813fc..3c76774 100644 --- a/dr

[PATCH v3 09/10] staging: fbtft: reformat hardcoded sequences

Added spaces after commas in initialization sequences and removed unnecessary line continuations. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/flexfb.c | 116 - 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/drivers/staging/fbt

[PATCH v3 05/10] staging: fbtft: remove unnecessary line continuations

Removed unnecessary line continuations in several lines. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fb

[PATCH v3 04/10] staging: fbtft: make module descriptions greppable

Split module description strings are merged for searchability. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index 6

[PATCH v3 06/10] staging: fbtft: remove unnecessary spaces before tabs

The patch removes spaces before tabs so that checkpatch.pl is content. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c inde

[PATCH v3 08/10] staging: fbtft: rearrange comments for readability

Placed comments to register writes before the function calls to eliminate long strings and make code more readable. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_ili9320.c | 118 +++-- 1 file changed, 88 insertions(+), 30 deletions(-) diff --git a/d

Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

On Sat, 2015-06-13 at 09:28 -0700, Greg KH wrote: > On Sat, Jun 13, 2015 at 02:16:18PM +0530, Sudip Mukherjee wrote: [] > > Your reply above was for a different thread but my doubt started from > > this. I was working on adding the Dual-Head support to sm7xxfb. So that > > is also a new functionali

Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

On Sat, Jun 13, 2015 at 02:16:18PM +0530, Sudip Mukherjee wrote: > On Fri, Jun 12, 2015 at 05:18:49PM -0700, Greg KH wrote: > > On Tue, Jun 09, 2015 at 04:59:01PM -0500, J. German Rivera wrote: > > > This patch series includes new functionality for the Freescale fsl-mc > > > bus driver. > > > > Wh

[PATCH 0/2] staging: unisys: fix coding style issues

fix coding style issues detected by checkpatch.pl script ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/2] staging: unisys: fix braces coding style

fix coding style issue "braces {} are not necessary for single statement blocks" detected by checkpatch.pl in visorchipset.c Signed-off-by: Alessandro Parini --- drivers/staging/unisys/visorbus/visorchipset.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/u

[PATCH 2/2] staging: unisys: fix "missing a blank line" coding style

fix coding style issue "Missing a blank line after declarations" detected by checkpatch.pl in visorchipset.c Signed-off-by: Alessandro Parini --- drivers/staging/unisys/visorbus/visorchipset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/d

[PATCHv4 1/4] staging: vme_user: remove forward declarations

Reorder code so that forward declarations are not needed. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 139 ++--- 1 file changed, 60 insertions(+), 79 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c

[PATCHv4 0/4] vme DMA and user space driver improvements

This reorders patches so that Greg can take first three, while fourth awaits maintainer's approval. Dmitry Kalinkin (4): staging: vme_user: remove forward declarations staging: vme_user: remove open/release staging: vme_user: remove buf_unalloc helper staging: vme_user: provide DMA functio

[PATCHv4 4/4] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 201 - drivers/staging/vme/devices/v

[PATCHv4 3/4] staging: vme_user: remove buf_unalloc helper

buf_unalloc is essentially a vme_free_consistent: 1) image[i].kern_buf is never NULL in buf_alloc call 2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 31 -

[PATCHv4 2/4] staging: vme_user: remove open/release

Checking for image[minor].resource != NULL is not needed since all resources are allocated before device is created. image[minor].users accounting is deleted because it's not being used. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/vme_user.c | 44 --

Re: [PATCH v2 11/11] staging: fbtft: add spaces to hardcoded sequences

On Sat, Jun 13, 2015 at 03:39:29PM +0300, Anton Gerasimov wrote: > Added spaces after commas in initialization sequences. and you are also removing the line continuations. regards sudip > ___ devel mailing list de...@linuxdriverproject.org http://driver

Re: [PATCH v2 10/11] staging: fbtft: rearrange comments for readability

On Sat, Jun 13, 2015 at 03:27:16PM +0300, Anton Gerasimov wrote: > Placed comments to register writes before the function call to > eliminate long strings and make code more readable. > > Signed-off-by: Anton Gerasimov > --- > > /* -- Set GRAM area --- */ > -

[PATCH v2 11/11] staging: fbtft: add spaces to hardcoded sequences

Added spaces after commas in initialization sequences. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/flexfb.c | 116 - 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.

Re: [PATCH v2 02/11] staging: fbtft: split long strings in fb_tls8204.c

On Sat, Jun 13, 2015 at 02:50:06PM +0300, Anton Gerasimov wrote: > Comments are rearranged for readability, one long function call is > split into several lines. you are splitting long functions calls in the previous patch. It could have been in that one. why here? regards sudip __

Re: [PATCH v2 01/11] staging: fbtft: split long function calls in flexfb.c

On Sat, Jun 13, 2015 at 02:50:05PM +0300, Anton Gerasimov wrote: > The patch splits long function calls and declarations into several shorter > lines. > > Signed-off-by: Anton Gerasimov > --- > > @@ -232,10 +242,12 @@ static int flexfb_verify_gpios_db(struct fbtft_par *par) > re

[PATCH v2 10/11] staging: fbtft: rearrange comments for readability

Placed comments to register writes before the function call to eliminate long strings and make code more readable. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_ili9320.c | 118 +++-- 1 file changed, 88 insertions(+), 30 deletions(-) diff --git a/dr

[PATCH v2 09/11] staging: fbtft: break long calls and conditions

Split several long lines into shorter ones to fit in 80 characters. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_ra8875.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c index

[PATCH v2 08/11] staging: fbtft: eliminate code duplication

Eliminated code duplication when searching for a display. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index e5aa533..

[PATCH] staging: rtl8712: fix else after break or return warning

This patch fixes checkpatch.pl warning. WARNING: else is not generally useful after a break or return Signed-off-by: Dogukan Ergun --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c

[PATCH v2 05/11] staging: fbtft: remove unnecessary line continuations

Removed unnecessary line continuations in several lines. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fb

[PATCH v2 06/11] staging: fbtft: remove unnecessary spaces before tabs

The patch removes spaces before tabs so that checkpatch.pl is content. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c inde

[PATCH v2 03/11] staging: fbtft: replace spaces with tabs

Indentation with spaces fixed. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c index c0b1a33..8ab177f 100644 --- a/drivers/staging/fb

[PATCH v2 02/11] staging: fbtft: split long strings in fb_tls8204.c

Comments are rearranged for readability, one long function call is split into several lines. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_tls8204.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb_tls8204.c b/drivers/staging

[PATCH v2 04/11] staging: fbtft: make module description greppable

Split module description strings are merged for searchability. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index d

[PATCH v2 07/11] staging: fbtft: sptlit long initialization string

Broken long initialization into two lines for readability. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index c19d34d..e5a

[PATCH v2 00/11] staging: fbtft: style fixes

Several style fixes for fbtft drivers. Had to split some drivers so the numeration differs from that of PATCH v1 Anton Gerasimov (11): staging: fbtft: split long function calls in flexfb.c staging: fbtft: style fix on fb_tls8204.c staging: fbtft: style fix on fb_tinylcd.c staging: fbtft: s

[PATCH v2 01/11] staging: fbtft: split long function calls in flexfb.c

The patch splits long function calls and declarations into several shorter lines. Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/flexfb.c | 45 +- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/d

[BUG ?] staging: rtl8723au: condition with no effect

scanning for trivial bug-patters with coccinelle spatches returned: ./drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1395 WARNING: condition with no effect (if branch == else) drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c - line numbers from 4.1-rc7 1395if (bWithoutHWSM) { 1396

doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

On Fri, Jun 12, 2015 at 05:18:49PM -0700, Greg KH wrote: > On Tue, Jun 09, 2015 at 04:59:01PM -0500, J. German Rivera wrote: > > This patch series includes new functionality for the Freescale fsl-mc > > bus driver. > > Why are people working on "new functionality" instead of working on > getting t