Re: [PATCH] staging: wilc1000: fix warning while printing

On Thu, Jun 11, 2015 at 12:42:23PM +0900, Chris Park wrote: > size_t should print using %zu, but here it was use %lu. > we were getting warning while printing. thanks, I made it to %lu seeing warning in x86_64 but that started warning in i386. Not this solves warning in both. regards sudip ___

LET`S WORK TOGETHER

>From Engr.Efe Omorogbe Nigeria National Petroleun Corporation P.O Box 6543 Victoria Island, Lagos Nigeria Dear Sir My name is Dr.Efe Omorogbe . It is my pleasure to write this mail basically to seek your consent on transaction which involves transfer of an over-invoiced sum of money from my mi

Re: [PATCH 1/4] staging: wilc1000: modify data type

On 2015년 06월 11일 09:40, Greg KH wrote: On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: -static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler) +static int wilc_wlan_cfg_commit(int type, size_t drvHandler) Shouldn't this just be a void *? And if so, why not the real functio

[PATCH v2 1/2] staging/lustre/llite: remove LL_IOC_REMOVE_ENTRY handler

From: Oleg Drokin It uses getname in unsafe manner and since it's to deal with corrupted or inconsistent filesystem, we are probably better to deal with it from lfsck anyway. Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_user.h | 1 - drivers/staging/lustre/lustre

[PATCH v2 0/2] Fixup lustre ll_getname

From: Oleg Drokin Some time ago Al Viro noticed that lustre ll_getname is broken. At the time a patch was submitted to convert lustre to use exported getname, that was rejected by hch on the grounds that filesystem code sould not really be reimplementing their own lookups which kind of made sense

[PATCH v2 2/2] staging/lustre/llite: fix ll_getname user buffer copy

From: Oleg Drokin strncpy_from_user could return negative values on error, so need to take those into account. Since ll_getname is used to get a single component name from userspace to transfer to server as-is, there's no need to allocate 4k buffer as done by __getname. Allocate NAME_MAX+1 buffer

Re: [PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote: > I mean, yes, it doesn't seem to make much sense to continue polling > after all the hardware has been removed. The problem is that we pass a > pci_dev pointer to dgap_remove_one() and it ignores it and removes > everything. > > Othe

Re: [PATCH] staging: wilc1000: modify odd print message

On 2015년 06월 11일 12:50, Greg KH wrote: On Thu, Jun 11, 2015 at 12:44:24PM +0900, Dean Lee wrote: This driver has odd message in print string. So this patch removes the data type. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+),

Re: [PATCH] staging: wilc1000: modify odd print message

On Thu, Jun 11, 2015 at 12:44:24PM +0900, Dean Lee wrote: > This driver has odd message in print string. > So this patch removes the data type. > > Signed-off-by: Dean Lee > --- > drivers/staging/wilc1000/host_interface.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

[PATCH] staging: wilc1000: modify odd print message

This driver has odd message in print string. So this patch removes the data type. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host

[PATCH] staging: wilc1000: fix warning while printing

size_t should print using %zu, but here it was use %lu. we were getting warning while printing. Signed-off-by: Chris Park --- drivers/staging/wilc1000/wilc_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wi

Re: [PATCH 3/4] staging: wilc1000: modify printk format

On 2015년 06월 11일 09:42, Greg KH wrote: On Wed, Jun 10, 2015 at 05:06:46PM +0900, Johnny Kim wrote: This remove compile warnings about printk format. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/linux_wlan.c

Re: [PATCH 1/1] staging: lustre/lustre/llite: get rid of incorrect type warning

On Mon, Jun 08, 2015 at 04:01:57PM -0700, Tolga Ceylan wrote: > In dir.c and llite_lib.c, sparse reports multiple warnings messages > due to different address spaces. This patch resolves these warnings > by adding the tag __user for username addresses. > > Signed-off-by: Tolga Ceylan Are you sur

Re: [PATCH 3/4] staging: wilc1000: modify printk format

On Wed, Jun 10, 2015 at 05:06:46PM +0900, Johnny Kim wrote: > This remove compile warnings about printk format. > > Signed-off-by: Johnny Kim > --- > drivers/staging/wilc1000/host_interface.c | 8 > drivers/staging/wilc1000/linux_wlan.c | 2 +- > drivers/staging/wilc

Re: [PATCH 1/4] staging: wilc1000: modify data type

On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: > -static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler) > +static int wilc_wlan_cfg_commit(int type, size_t drvHandler) Shouldn't this just be a void *? And if so, why not the real function pointer instead? Also, lots of these

[PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings ieee80211_softmac.c

Fix the following endinness warnings detected by sparse: drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:669:34: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:669:34:expected restricted __le16 [usertype] duration_id

Re: [PATCH v2 2/3] Staging: lustre: fix braces are not necessary in dt_object.c

On Wed, 2015-06-10 at 22:00 +0200, Zoltán Lajos Kis wrote: > Fixes a braces {} are not necessary for any arm of this statement > warning in lustre/lustre/obdclass/dt_object.c that was found by > the checkpatch.pl tool. > > Signed-off-by: Zoltán Lajos Kis > --- > drivers/staging/lustre/lustre/obd

[PATCH v2 2/3] Staging: lustre: fix braces are not necessary in dt_object.c

Fixes a braces {} are not necessary for any arm of this statement warning in lustre/lustre/obdclass/dt_object.c that was found by the checkpatch.pl tool. Signed-off-by: Zoltán Lajos Kis --- drivers/staging/lustre/lustre/obdclass/dt_object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[PATCH v2 3/3] Staging: lustre: fix space before and after comma in dt_object.c

Fixes a space prohibited before that ',' and space required after that ',' error in lustre/lustre/obdclass/dt_object.c that were found by the checkpatch.pl tool. Signed-off-by: Zoltán Lajos Kis --- drivers/staging/lustre/lustre/obdclass/dt_object.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v2 1/3] Staging: lustre: fix line over 80 characters in dt_object.c

Fixes a line over 80 characters warining in lustre/lustre/obdclass/dt_object.c that was found by the checkpatch.pl tool. Signed-off-by: Zoltán Lajos Kis --- drivers/staging/lustre/lustre/obdclass/dt_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lu

[PATCH v2 0/3] Staging: lustre: fix style issues in dt_object.c

v2: fixed patch format, separated into three commits Zoltán Lajos Kis (3): Staging: lustre: fix line over 80 characters in dt_object.c Staging: lustre: fix braces are not necessary in dt_object.c Staging: lustre: fix space before and after comma in dt_object.c drivers/staging/lustre/lustre

Re: [PATCH 2/4] staging: wilc1000: add syntax for 64-bit machine

On Wed, Jun 10, 2015 at 05:06:45PM +0900, Johnny Kim wrote: > The driver take pointer value to integer value for message packet. > So, The driver was fixed to save and load the address > on 64-bit machine. > > Signed-off-by: Johnny Kim > --- > drivers/staging/wilc1000/host_interface.c | 24 +

Re: [PATCH v4 2/2] staging: wilc1000: Align enum members in coreconfigurator

On Tue, Jun 09, 2015 at 10:39:55AM -0700, Greg KH wrote: > On Mon, Jun 08, 2015 at 11:54:29PM +0300, Stanislav Kholmanskikh wrote: > > Aligned enum members to follow a common style per enum. > > You also reformatted defines, which you didn't mention here :( Sorry. :( I've sent V5 adressing this

[PATCH v5 2/3] staging: wilc1000: coreconfigurator: Change return(X) to return X

Changed 'return(X)' to 'return X' in coreconfigurator.c to satisfy checkpatch.pl warning: ERROR: return is not a function, parentheses are not required Signed-off-by: Stanislav Kholmanskikh --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file changed, 4 insertions(+), 4 deletion

[PATCH v5 3/3] staging: wilc1000: coreconfigurator: Align enums and defines

Aligned enum members and defines to follow a common style per enum/(group of defines). Signed-off-by: Stanislav Kholmanskikh --- drivers/staging/wilc1000/coreconfigurator.c | 29 +++--- drivers/staging/wilc1000/coreconfigurator.h | 62 ++--- 2 files changed, 46 in

[PATCH v5 1/3] staging: wilc1000: coreconfigurator: Remove spaces before "\n"

In accordance to checkpatch.pl, a space before a quoted newline ("\n") is unnecessary, therefore substituted " \n" with "\n" in coreconfigurator.c Signed-off-by: Stanislav Kholmanskikh --- Changes since V4: * Split [PATCH V4 1/2] into two patches. I postponed the realignment of TAG_PARAM_OFFSET

Re: [PATCH 1/1 linux-next] staging: rtl8723au: use swap() in WMMOnAssocRsp23a()

Fabian Frederick writes: > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick > --- > drivers/staging/rtl8723au/core/rtw_wlan_util.c | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) Please make sure

RE: Working on client merge

On Wed, 10 Jun 2015, Simmons, James A. wrote: > > >Where would be a good place to get started with helping merge the client > into mainline? > >   > > Hi Ben > >   > > Thanks for helping out for this work. I added people in the chain that > have contributed a great > > deal to the upstream

[PATCH 1/1 linux-next] staging: speakup: use swap() in get_highlight_color()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/staging/speakup/main.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c

[PATCH 1/1 linux-next] Staging: rtl8188eu: use swap() in WMMOnAssocRsp()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_uti

[PATCH 1/1 linux-next] staging: lustre: lnet: o2iblnd: use swap() in kiblnd_dev_failover()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2ibl

[PATCH 1/1 linux-next] staging: rtl8712: use swap() in dequeue_xframe_ex()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/staging/rtl8712/rtl8712_xmit.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/sta

[PATCH 1/1 linux-next] staging: rtl8723au: use swap() in WMMOnAssocRsp23a()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_uti

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

On Sun, May 31, 2015 at 6:06 AM, Greg Kroah-Hartman wrote: > On Thu, May 28, 2015 at 03:06:57PM +0300, Dmitry Kalinkin wrote: >> The first item in this submission documents previously introduced >> vme_master_mmap() call. Following, there are three fixes for the tsi148 >> driver's DMA. There was

Re: [PATCH v4 6/7] staging: fsl-mc: Add locking to serialize mc_send_command() calls

On Tue, Jun 09, 2015 at 04:59:07PM -0500, J. German Rivera wrote: > Add a locking mechanism to serialize mc_send_command() calls that use > the same fsl_mc_io object (same MC portal). When the fsl_mc_io object is > created the owner needs to know in which type of context the fsl_mc_io > object is g

Re: [PATCH 2/4] staging: wilc1000: add syntax for 64-bit machine

Hi Johnny, On Wed, Jun 10, 2015 at 6:06 PM, Johnny Kim wrote: > The driver take pointer value to integer value for message packet. > So, The driver was fixed to save and load the address > on 64-bit machine. > > Signed-off-by: Johnny Kim > --- > drivers/staging/wilc1000/host_interface.c | 24 ++

Re: [PATCH 1/4] staging: wilc1000: modify data type

On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: > This replace the argument of the function to the independent data type > in system. > > Signed-off-by: Johnny Kim This changelog says what you are doing but not why. What is the point of ->u32Address? Now that it's not 32 bits, the

[PATCH 3/4] staging: wilc1000: modify printk format

This remove compile warnings about printk format. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 3 files changed, 9 insertions(

[PATCH 4/4] staging: wilc1000: remove uninitialized warnings

This patch is for the initialization of the local variables. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc10

[PATCH 2/4] staging: wilc1000: add syntax for 64-bit machine

The driver take pointer value to integer value for message packet. So, The driver was fixed to save and load the address on 64-bit machine. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/host_interface.c | 24 drivers/staging/wilc1000/wilc_wlan.c | 19 ++

[PATCH 1/4] staging: wilc1000: modify data type

This replace the argument of the function to the independent data type in system. Signed-off-by: Johnny Kim --- drivers/staging/wilc1000/coreconfigurator.c | 4 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 132

[PATCH 0/4] staging: wilc1000: fix compile warnings and clean other

Hello Greg. I have rebased on the lastest staging-testing and fixed compile warnings This patches is prepared to fix the compatibilty issue for 64bit machine and wrong casting. I am aware that the others should be patched additonally. However I need internally to discuss on the other patch. Then,

Re: [PATCH 2/2] staging/lustre/llite: fix ll_getname user buffer copy

On Jun 10, 2015, at 3:52 AM, Dan Carpenter wrote: > On Wed, Jun 10, 2015 at 12:41:23AM -0400, gr...@linuxhacker.ru wrote: >> From: Oleg Drokin >> >> strncpy_from_user could return negative values on error, >> so need to take those into account. >> Since ll_getname is used to get a single compon

Re: [PATCH 2/2] staging/lustre/llite: fix ll_getname user buffer copy

On Wed, Jun 10, 2015 at 12:41:23AM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > strncpy_from_user could return negative values on error, > so need to take those into account. > Since ll_getname is used to get a single component name from userspace > to transfer to server as-is, ther

Re: [PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote: > > Also this driver has active maintainers but somehow we have CC'd the > ATMEL people who maintain a different staging driver... The original patch had put the maintainers of WILC1000 WIFI DRIVER in the cc list. Now ccing the actual

Re: [PATCH 1/2] staging/lustre/llite: remove LL_IOC_REMOVE_ENTRY handler

On Jun 10, 2015, at 3:08 AM, Sudip Mukherjee wrote: > On Wed, Jun 10, 2015 at 12:41:22AM -0400, gr...@linuxhacker.ru wrote: >> From: Oleg Drokin >> >> It uses getname in unsafe manner and since it's to deal with corrupted >> or inconsistent filesystem, we are probably better to deal with >> it

Re: [PATCH] staging: android: uapi: Fixed coding style issue

On Tue, Jun 09, 2015 at 05:28:19PM -0500, Daniel Holman wrote: > Removed typedef > > Signed-off-by: Daniel Holman This is user API, I don't think you can change it. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://dri

Re: [PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

I mean, yes, it doesn't seem to make much sense to continue polling after all the hardware has been removed. The problem is that we pass a pci_dev pointer to dgap_remove_one() and it ignores it and removes everything. Otherwise, I would probably suggest that it start polling when the first hardwa

Re: [PATCH 1/2] staging/lustre/llite: remove LL_IOC_REMOVE_ENTRY handler

On Wed, Jun 10, 2015 at 12:41:22AM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > It uses getname in unsafe manner and since it's to deal with corrupted > or inconsistent filesystem, we are probably better to deal with > it from lfsck anyway. I am not sure but will it not break the us