On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote:
> As suggested by Sudip this patch removes the redundant 1360x768@60
> option from the fb_videomode struct array.
this can be in the comments but should not be there in the commit message.
regards
sudip
> The removed option and
Hi,
On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs
wrote:
> This patch fixes the init function for the iio_simple_dummy driver.
> The main issues were absence of kfree for the allocated array, and no
> devices being removed in case the probe function fails, running in a loop.
>
> The iio_du
On Wed, May 27, 2015 at 05:56:27AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
> > On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > replace kzalloc with devm_kzalloc thereby removing
On Wed, May 27, 2015 at 11:32:11AM +0530, Sudip Mukherjee wrote:
> On Tue, May 26, 2015 at 02:50:30PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > The Kconfig dependency for this driver should include the kernel
> > configuration FB_MODE_HELPERS which defines the vesa_modes
> > structure.
On Tue, May 26, 2015 at 02:50:30PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> The Kconfig dependency for this driver should include the kernel
> configuration FB_MODE_HELPERS which defines the vesa_modes
> structure.Without this dependency,the driver build generates a linker
> error if bui
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
> On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > replace kzalloc with devm_kzalloc thereby removing the corresponding
> > kfree.
> your patch is corrupt and can not be applied.
> But even the
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> replace kzalloc with devm_kzalloc thereby removing the corresponding
> kfree.
your patch is corrupt and can not be applied.
But even then, can this be called as code improvement?
regards
sudip
>
> Signed-off-by:
Fix spelling error in comment in function tegra_nvec_remove.
Signed-off-by: Shailendra Verma
---
drivers/staging/nvec/nvec.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 1bdc8d0..164634d 100644
--- a/driver
On Tue, May 26, 2015 at 10:25:42PM +0200, Mateusz Kulikowski wrote:
> Proposal for v5: I'll verify alignment of each array,
> and reorder variables where possible/needed to keep the alignment.
> Then I'll hopefully drop this patch.
That could work.
It's a unfortunate that the controversial trick
On Friday, May 22, 2015 10:16 AM, Ian Abbott wrote:
> A few coding style cleanups for the Comedi amplc_dio200* modules, and to
> make the "amplc_dio200.h" header file self-reliant.
>
> 1) staging: comedi: amplc_dio200.h: reformat copyright comment
> 2) staging: comedi: amplc_dio200.h: make self-rel
On Friday, May 22, 2015 9:32 AM, Ian Abbott wrote:
> The Comedi "addi_watchdog.h" header doesn't use anything form
> "comedidev.h" apart from `struct comedi_subdevice`, which it only uses
> to construct a corresponding pointer type within the parameter list of a
> function prototype. Just declare
On Friday, May 22, 2015 8:22 AM, Ian Abbott wrote:
> These patches are for the Comedi "8255" driver module (including the
> creation of a new "comedi_8255" module split off from it).
>
> Patch 1 fixes a problem cleaning up on failure in the Comedi "8255" driver.
>
> Patch 2 is just a minor change t
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Thursday, May 21, 2015 9:22 AM
> To: de...@linuxdriverproject.org
> Cc: KY Srinivasan; Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui;
> Ingo Molnar; Paul E. McKenney; Rafael J. Wysocki; Peter Zijl
Check for zero was added to the module parameter "instances" to
avoid the allocation of array of zero values. Although it is a valid call,
we don't want to allocate ZERO_SIZE_PTR, so need to disallow this case.
The type of variables which are compared to "instances" were also changed
to unsigned in
This patch fixes the init function for the iio_simple_dummy driver.
The main issues were absence of kfree for the allocated array, and no
devices being removed in case the probe function fails, running in a loop.
The iio_dummy_remove function was also changed:
* The return value was change
The current algorithm for deciding on the number of VRSS channels is
not optimal since we open up the min of number of CPUs online and the
number of VRSS channels the host is offering. So on a 32 VCPU guest
we could potentially open 32 VRSS subchannels. Experimentation has
shown that it is best to
Fix the following sparse warnings:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning:
incorrect type in assignment (different base types)
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:expected
restricted __le16 [usertype] frame_ctl
drivers/staging/rtl8192
On Tue, 2015-05-26 at 22:25 +0200, Mateusz Kulikowski wrote:
> On 25.05.2015 15:53, Dan Carpenter wrote:
> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> >> b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
[]
> >> + static const u8 bMac_Tmp_Addr[ETH_ALEN] __aligned(2) = {
> >> +
On Tue, May 26, 2015 at 10:06:17AM -0700, Joe Perches wrote:
> On Tue, 2015-05-26 at 09:35 -0700, Greg KH wrote:
> > On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote:
> > > > > The main point is that patches shouldn't be applied without
> > > > > being submitted to a more widely read lis
On Tue, May 26, 2015 at 10:06:17AM -0700, Joe Perches wrote:
> If you're collecting them, I suggest you stick them in
> a separate branch, post them to your driverdev list and
> cc the appropriate maintainers, wait a week, then apply
> them to your main branch.
That would work. A massive thread i
On 25.05.2015 15:53, Dan Carpenter wrote:
> On Thu, May 21, 2015 at 05:53:15PM +0200, Mateusz Kulikowski wrote:
>> Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
>> structures. Use ETH_ALEN as array length in places where it was hardcoded to
>> 6.
>
> To be honest, t
On Tue, May 26, 2015 at 01:14:05PM -0500, Jaime Arrocha wrote:
> gdm_endian.c: small changes were done to remove testing for host
> endianness and in-driver conversion for byte-ordering.
> The linux/kernel.h functions are used now.
>
> gdm_endian.h: removal of code no longer needed with changes
On Tue, May 26, 2015 at 09:35:55AM -0700, Greg KH wrote:
> Also, the outreachy patch process would overwhelm everyone else on the
> list, it's really high volume during the application phase, I'd prefer
> it to stick with the mentors that wish to help out with the process. If
> you and/or Dan, or
From: Keith Mange
Add support for Windows 10.
Signed-off-by: Keith Mange
Signed-off-by: K. Y. Srinivasan
---
V2: Fixed up the author's name.
drivers/hv/connection.c |8 +---
include/linux/hyperv.h |4 +++-
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/dr
On 25.05.2015 19:37, Joe Perches wrote:
> On Mon, 2015-05-25 at 17:03 +0300, Dan Carpenter wrote:
>> On Thu, May 21, 2015 at 05:53:19PM +0200, Mateusz Kulikowski wrote:
(...)
>>> bssid_match =
>>> - (memcmp(header->addr3, ieee->current_network.bssid, ETH_ALEN) != 0) &&
>>> + (!ether_add
On 25.05.2015 16:03, Dan Carpenter wrote:
> On Thu, May 21, 2015 at 05:53:19PM +0200, Mateusz Kulikowski wrote:
>> Use dedicated macro to compare ethernet addresses in probe_rq_parse().
>>
>> Signed-off-by: Mateusz Kulikowski
>> ---
>> drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
>> 1 file
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Sunday, May 24, 2015 12:20 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com; Keith Mang
This patch removes the legacy bus_info struct and instead creates
and passes around a traditional struct device.
This allows us to remove a lot of the various look up code and
removes the doubt if the struct exists or not.
Half of the churn is just the conversion of visorchipset_bus_info
to visor
From: Jes Sorensen
min_size/max_size aren't used anywhere, and they were just causing
headaches in the drivers being ported over to the new interfaces.
Signed-off-by: Jes Sorensen
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-
From: David Kershner
Get rid of unused values in the enum.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/diagchannel.h | 32 +++-
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/unisys/inc
From: David Kershner
Diagchannel.h is used primarily for the diagnostics channel. The
diagnostics channel is not being used by linux guests currently, so
the majority of the file is not needed. What is left is what is
needed to perform postcode vmcalls. Those postcodes will eventually
end up in t
From: David Kershner
Give the enum the correct values instead of based on other values.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/diagchannel.h | 34
1 file changed, 10 insertions(+), 24 deletions(-)
diff --git
The bus driver doesn't work in server mode, just remove the left over
pieces.
Signed-off-by: Don Zickus
---
drivers/staging/unisys/visorbus/visorbus_main.c| 66 +++---
drivers/staging/unisys/visorbus/visorbus_private.h | 5 --
drivers/staging/unisys/visorbus/visorchipset.c
The bus device and regular device were using two different
structs. Let's combine them as they are not entirely different
from one another.
This allows us to move this creation up the stack later and
actually remove bus/dev_info easily.
Most of the churn is just renaming devdata -> dev and 'stru
This patch removes the legacy dev_info struct and instead creates
and passes around a traditional struct device.
This allows us to remove a lot of the various look up code and
removes the doubt if the struct exists or not.
Half of the churn is just the conversion of visorchipset_device_info
to vi
I used 0 as the device id for the bus root, neglecting the fact that
device 0 is a valid id in Unisys's configuration. Modify this to
use UINT_MAX instead as a unique number.
As fallout from this change it was noticed the bus_no and dev_no was not
defined the same way consistently. Fix visorbus.
In order for bus/dev_info structs to become public structs, one
element, pending_msg_hdr, needs to become opaque. This is to keep
all the internals of the controlvm struct private to the bus layer.
So a simple conversion of embedding the pending_msg_hdr struct into
a pointer is done. The rest of
Instead of creating a channel struct to temporarily hold the channel
info and passing it through multiple functions until the device is
created, just create the channel from the start.
This allows us to remove the channel_info struct.
I noticed 'chan_info.addr_type' was not being used, so I just
In order to remove bus_info, we need to migrate vbus_hdr_info into
the public namespace of visor_device. Because the struct is private,
we use a void * to hide the contents.
As a result, we need to allocate vbus_hdr_info and manage it.
Also work around vbus_valid, as that variable will not be us
Removing stuff that isn't being used. Another prepartion patch to
allow us to use visor_device everywhere without the baggage of
bus/dev_info.
Signed-off-by: Don Zickus
---
drivers/staging/unisys/visorbus/visorbus_main.c| 72 --
drivers/staging/unisys/visorbus/visorbus_p
Hi,
GregKH ran into an issue where the last 13 patches didn't apply.
It looks like Ben cleaned up the patches to address checkpatch.pl
warnings and forgot to refresh the patchset.
I just refreshed the patchset and everything should apply on top
of staging-testing (commit a30baec189f7db458).
No
On Friday, May 22, 2015 10:33 AM, Ian Abbott wrote:
> The Comedi "comedi_8254.h" header file is included by various Comedi
> drivers with timer/counters based on the 8254 chip. The drivers do not
> compile cleanly if this header file is included first. It uses pointers
> to the `struct comedi_dev
O n Friday, May 22, 2015 10:45 AM, Ian Abbott wrote:
> The Comedi "comedi_isadma.h" header is included by the source for the
> "comedi_isadma" helper module and other modules that use it. It does
> not compile cleanly when it is the first header file included. It uses
> the `dma_addr_t` type, so
gdm_endian.c: small changes were done to remove testing for host
endianness and in-driver conversion for byte-ordering.
The linux/kernel.h functions are used now.
gdm_endian.h: removal of code no longer needed with changes
in gdm_endian.c.
Signed-off-by: Jaime Arrocha
---
drivers/staging/gdm
On Tue, 2015-05-26 at 09:35 -0700, Greg KH wrote:
> On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote:
> > > > The main point is that patches shouldn't be applied without
> > > > being submitted to a more widely read list.
> > >
> > > I take the blame for any problems with Outreachy patc
On 05/26/2015 10:59 AM, Dan Carpenter wrote:
On Tue, May 26, 2015 at 10:29:44AM -0500, Jaime Arrocha wrote:
This is the first patch of two. Both patches perform a small clean up
done to the section for host endian test. Instead of handling endianness
internally, kernel functions were added for
On 05/26/2015 10:48 AM, Dan Carpenter wrote:
On Tue, May 26, 2015 at 07:14:01AM -0700, Greg KH wrote:
I take the blame for any problems with Outreachy patches. Given the
huge volume of them, one bug out of 900 isn't that bad of a percentage.
We don't get many bugs through outreachy, but this
On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote:
> On Tue, 2015-05-26 at 07:14 -0700, Greg KH wrote:
> > On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote:
> > > As far as I understand, the Eudyptula Challenge list has
> > > internal mechanisms to nominally review patches befo
On Tue, May 26, 2015 at 10:29:44AM -0500, Jaime Arrocha wrote:
> This is the first patch of two. Both patches perform a small clean up
> done to the section for host endian test. Instead of handling endianness
> internally, kernel functions were added for use.
> The second patch depends on the fir
On Tue, May 26, 2015 at 07:14:01AM -0700, Greg KH wrote:
> I take the blame for any problems with Outreachy patches. Given the
> huge volume of them, one bug out of 900 isn't that bad of a percentage.
We don't get many bugs through outreachy, but this isn't the first one.
For example, in March an
Small code that is no longer needed after first part of the patch is
applied.
Signed-off-by: Jaime Arrocha
---
drivers/staging/gdm724x/gdm_endian.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_endian.h
b/drivers/staging/gdm724x/gdm_endian.h
index
On 05/26/2015 12:30 AM, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote:
On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
On Mon,
This is the first patch of two. Both patches perform a small clean up
done to the section for host endian test. Instead of handling endianness
internally, kernel functions were added for use.
The second patch depends on the first one, it is just a small piece
that is no longer needed.
Signed-off-b
As suggested by Sudip this patch removes the redundant 1360x768@60
option from the fb_videomode struct array.
The removed option and the option one it differ in a typo and a flag.
Signed-off-by: Michel von Czettritz
---
drivers/staging/sm750fb/sm750.c | 3 ---
1 file changed, 3 deletions(-)
dif
This reformats lines that were previously above 80 characters long,
improving readability and making checkpatch.pl happier.
Signed-off-by: Piotr S. Staszewski
---
drivers/staging/media/omap4iss/iss_csi2.c| 18 +++--
drivers/staging/media/omap4iss/iss_ipipe.c | 30 ++
On Tue, May 26, 2015 at 3:56 PM, Dan Carpenter wrote:
>> elt->length is a u8, so the upper bound is 255.
>
> Yes. I know that, but is 255 correct?
Eventually body->data is passed to oz_hcd_get_desc_cnf along with
data_len. In there, body->data (now called desc) is memcpy'd into a
URB transfer bu
The Kconfig dependency for this driver should include the kernel
configuration FB_MODE_HELPERS which defines the vesa_modes
structure.Without this dependency,the driver build generates a linker
error if build as a built-in driver.It gets build find as a module,but
may cause issue during runtime.
On Tue, 2015-05-26 at 07:14 -0700, Greg KH wrote:
> On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote:
> > As far as I understand, the Eudyptula Challenge list has
> > internal mechanisms to nominally review patches before some
> > patch is submitted to lkml.
>
> No it does not.
That's
On Tue, May 26, 2015 at 07:15:24AM -0700, Greg Kroah-Hartman wrote:
> > - WARN(1, KERN_ERR "CSI2: pixel format %08x unsupported!\n",
> > + WARN(1,
> > +KERN_ERR "CSI2: pixel format %08x unsupported!\n",
>
> That line wasn't over 80 characters long, why change it
On Tue, May 26, 2015 at 4:06 PM, Dan Carpenter wrote:
> You sure do like wrapping to a high value and testing the result for
> wrapping instead of validating before doing the subtraction...
I do indeed. It seems like asking "did it overflow?" is more
straight-forward and easier to read than tryin
On 05/25/2015 04:22 PM, Vladimirs Ambrosovs wrote:
> This patch fixes the leak, which was present in fwserial driver in the
> init function. In case the tty driver allocation failed the function
> returned error, leaving debugfs entry in the filesystem.
>
> To fix the issue additional error label
On Tue, May 26, 2015 at 10:54:18AM +0200, Piotr S. Staszewski wrote:
> This reformats lines that were previously above 80 characters long,
> improving readability and making checkpatch.pl happy.
>
> Signed-off-by: Piotr S. Staszewski
> ---
> drivers/staging/media/omap4iss/iss_csi2.c| 21
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote:
> On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote:
> > On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
> > > On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
> > > > On Mon, May 25, 2015 at 10:37:28AM -0700,
Juston Li writes:
> change cast to __le16 to fix the following warning:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to
> restricted __le16
>
> Signed-off-by: Juston Li
> ---
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
> 1 file changed, 1 insertion(
On Tue, May 26, 2015 at 02:17:49PM +0200, Jason A. Donenfeld wrote:
> diff --git a/drivers/staging/ozwpan/ozusbsvc1.c
> b/drivers/staging/ozwpan/ozusbsvc1.c
> index 8552053..1bde6aa 100644
> --- a/drivers/staging/ozwpan/ozusbsvc1.c
> +++ b/drivers/staging/ozwpan/ozusbsvc1.c
> @@ -326,11 +326,13 @@
On Tue, May 26, 2015 at 03:49:27PM +0200, Jason A. Donenfeld wrote:
> On Tue, May 26, 2015 at 3:32 PM, Dan Carpenter
> wrote:
> > On Tue, May 26, 2015 at 02:17:46PM +0200, Jason A. Donenfeld wrote:
> >> + data_len = elt->length -
> >> size
On Tue, May 26, 2015 at 3:32 PM, Dan Carpenter wrote:
> On Tue, May 26, 2015 at 02:17:46PM +0200, Jason A. Donenfeld wrote:
>> + data_len = elt->length -
>> sizeof(struct oz_get_desc_rsp) + 1;
>
> This was in the original code, but I wonder
On Tue, May 26, 2015 at 02:17:46PM +0200, Jason A. Donenfeld wrote:
> + data_len = elt->length -
> sizeof(struct oz_get_desc_rsp) + 1;
This was in the original code, but I wonder where the + 1 comes from.
Does anyone know?
To be honest, I
The subtraction here was using a signed integer and did not have any
bounds checking at all. This commit adds proper bounds checking, made
easy by use of an unsigned integer. This way, a single packet won't be
able to remotely trigger a massive loop, locking up the system for a
considerable amount
This is v2 for this patch series, fixing a compiler warning.
The ozwpan driver accepts network packets, parses them, and converts
them into various USB functionality. There are numerous security
vulnerabilities in the handling of these packets. Two of them result in
a memcpy(kernel_buffer, network
Using signed integers, the subtraction between required_size and offset
could wind up being negative, resulting in a memcpy into a heap buffer
with a negative length, resulting in huge amounts of network-supplied
data being copied into the heap, which could potentially lead to remote
code execution
A network supplied parameter was not checked before division, leading to
a divide-by-zero. Since this happens in the softirq path, it leads to a
crash. A PoC follows below, which requires the ozprotocol.h file from
this module.
=-=-=-=-=-=
#include
#include
#include
#include
#include
#
Since elt->length is a u8, we can make this variable a u8. Then we can
do proper bounds checking more easily. Without this, a potentially
negative value is passed to the memcpy inside oz_hcd_get_desc_cnf,
resulting in a remotely exploitable heap overflow with network
supplied data.
This could resu
On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote:
> On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
> > On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
> > > On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
> > > > It'd be better if the approved patches fr
Hi Shailendra,
you should fill the patch description with something, even if trivial, and
trim the subject line a bit, e.g.
---
staging: nvec: fix typo in comment (all lowercase, no full stop at the end)
Fix spelling error in comment in function tegra_nvec_remove.
S-o-b
-
Thanks,
Marc
A
replace kzalloc with devm_kzalloc thereby removing the corresponding
kfree.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/sm750fb/sm750.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
inde
On 26/05/2015 00:41, Matthew Needes wrote:
pcl812.c (resend of earlier patch)
Fixed lines exceeding 80 columns, correcting some spelling in process
Signed-off-by: Matthew Needes
---
drivers/staging/comedi/drivers/pcl812.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
di
On 26/05/2015 00:41, Matthew Needes wrote:
pcl812.c / pcl816.c (resend of earlier patch)
Fixed indentation problems.
Signed-off-by: Matthew Needes
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
drivers/staging/comedi/drivers/pcl816.c | 2 +-
2 files changed, 2 insertions(+), 2 del
This reformats lines that were previously above 80 characters long,
improving readability and making checkpatch.pl happy.
Signed-off-by: Piotr S. Staszewski
---
drivers/staging/media/omap4iss/iss_csi2.c| 21 ---
drivers/staging/media/omap4iss/iss_ipipe.c | 30 ++
Btw, the subject should say "fix endian bug". "silence" means that
their is a warning and possible some messy code but no runtime bug.
On Mon, May 25, 2015 at 07:50:55PM -0300, Gaston Gonzalez wrote:
> On 25/05/15 13:35, Dan Carpenter wrote:
> > This is also wrong then.
> >
> > regards,
> > dan c
80 matches
Mail list logo
