On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
> This patch fixes coding style errors reported by checkpatch.pl for
> cb_pcidas64.c, about too long source code lines.
>
> Signed-off-by: Amaury Denoyelle
> ---
> drivers/staging/comedi/drivers/cb_pcidas64.c | 14 ++
>
A recent patch to simplify the lustre large memory allocation
causes new warnings as an unintended side-effect:
lustre/lov/lov_request.c: In function 'lov_finish_set':
lustre/lov/lov_request.c:78:7: warning: unused variable 'len'
[-Wunused-variable]
int len = set->set_oabufs * sizeof(*set->set
I was planning to leave this one for Greg but since you asked me to
comment...
This patch is ok as one patch. The subject is "clean up
prism2_wep_init()" and that's one thing. Breaking it up into tiny
patches would probably make it harder to review.
On Tue, May 19, 2015 at 01:32:22AM +0200, Ped
Barclays Bank PLC
1 Churchill Place
London, E14 5HP, United Kingdom
Dear Customer,
We are deeply sorry that your fund has not been transferred to you till now
because of the activities of some bad persons here in London and their evil
collaborators in Nigeria,Africa. Therefore, we have been na
On Tue, 2015-05-19 at 11:04 +0530, Sudip Mukherjee wrote:
> On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote:
> > Merge two pr_debug lines with literal strings splitted across several lines
> > into one single line, simplifying prism2_wep_init error check code.
>
> I would have sp
Hi,
Bernhard Kraft wrote:
Hi Alex,
On 2015-05-19 14:20, Alex Beregszaszi wrote:
So I sat down and wrote an Arduino implementation of that specification
just to see what the performance would be. You can find it at:
https://github.com/axic/dtiic
I already took a look at the robot-electronics
These two patches fixes various coding style error in cb_pcidas64.c file.
1/2:
- address line longer than 80 characters
2/2:
- format multi-line comments according to the kernel coding style
Amaury Denoyelle (2):
Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c
Staging: comedi:
This patch fixes coding style errors reported by checkpatch.pl for
cb_pcidas64.c, about too long source code lines.
Signed-off-by: Amaury Denoyelle
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
This patch reformat multi-line comments which are not properly written
according to the kernel coding style in cb_pcidas64.c
Signed-off-by: Amaury Denoyelle
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 140 ++-
1 file changed, 93 insertions(+), 47 deletions(-)
diff
In this patch:
1. the if condition is modified to remove
the unnecessary equality check.
2. The else if condition is replaced by an else condition
since the variable checked in the if statement is a bool
making the else if unnecessary.
3. Fixed indentation problem on line 1369.
These changes were d
Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c
Signed-off-by: Douglas Barbonaglia Sathler Figueiredo
---
drivers/staging/wlan-ng/prism2fw.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b/drivers/staging/wlan-ng
Peter Zijlstra writes:
> On Tue, May 19, 2015 at 02:15:41PM +0200, Vitaly Kuznetsov wrote:
>> Loaded Hyper-V module will use these functions to disable CPU hotplug
>> under certain circumstances.
>
> What's wrong with get_online_cpus() ?
We need to disable cpu offlining permanently (till the mod
On Tue, May 19, 2015 at 02:15:41PM +0200, Vitaly Kuznetsov wrote:
> Loaded Hyper-V module will use these functions to disable CPU hotplug
> under certain circumstances.
What's wrong with get_online_cpus() ?
___
devel mailing list
de...@linuxdriverproject
Hi Alex,
On 2015-05-19 14:20, Alex Beregszaszi wrote:
So I sat down and wrote an Arduino implementation of that specification
just to see what the performance would be. You can find it at:
https://github.com/axic/dtiic
I already took a look at the robot-electronics.co.uk link yesterday. I
wa
Fix to avoid possible memory leak if the ion device registration
get failed.Free the allocated device creation memory before return
in case the ion device registration get failed.
Signed-off-by: Shailendra Verma
---
drivers/staging/android/ion/ion.c |1 +
1 file changed, 1 insertion(+)
diff
On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
> From: douglasbsf
We need a "real" name here, and in the signed-off-by line.
Also fix up your subject line like mentioned.
>
> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
>
> Signed-off-by: douglasbsf
>
Unify spacing in variable declarations, and align indentation in headers.
General whitespace cleanups.
Signed-off-by: Mike Shuey
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 60 ++--
drivers/staging/lustre/lnet/selftest/conctl.c| 54 ++--
drivers/staging/lustre/lnet/selftest/co
Unify variable declarations to use a single space, and any other obvious
spacing flaws.
Signed-off-by: Mike Shuey
---
drivers/staging/lustre/lnet/lnet/acceptor.c| 32 ++--
drivers/staging/lustre/lnet/lnet/api-ni.c | 198 ++--
drivers/staging/lustre/lnet/lnet/config.c
Hi Angelo,
Angelo Compagnucci wrote:
Hi Alex,
2015-05-19 15:34 GMT+02:00 Angelo Compagnucci:
Hi Alex,
2015-05-19 13:59 GMT+02:00 Alex Beregszaszi:
Hi,
Angelo Compagnucci wrote:
Dear Bernhard Kraft,
2015-05-18 18:53 GMT+02:00 Bernhard Kraft:
But for now I think I will just publish the Ard
Unify variable declarations to use a single space. Also include several
miscellaneous whitespace cleanups, particularly in socklnd.h.
Signed-off-by: Mike Shuey
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 468
.../staging/lustre/lnet/klnds/socklnd/socklnd.h| 5
Unify variable declarations to use a single whitespace. Also line up
declarations and comments in o2iblnd.h.
Signed-off-by: Mike Shuey
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 458 +++---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 680 ++--
..
This patch series cleans up code in staging/lustre/lnet - mostly spacing
and dead function cleanup. Should apply against linux-next 20150518.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/dr
LNET_MUTEX_LOCK and LNET_MUTEX_UNLOCK are verbose wrappers to mutex_lock and
mutex_unlock. Get rid of these.
Signed-off-by: Mike Shuey
---
.../staging/lustre/include/linux/lnet/lib-lnet.h |2 -
drivers/staging/lustre/lnet/lnet/api-ni.c | 26 ++--
drivers/staging
LNetSetAsync() returns 0, and is never called. Doesn't exist in the Intel
tree, either. Remove it.
Signed-off-by: Mike Shuey
---
drivers/staging/lustre/include/linux/lnet/api.h |1 -
drivers/staging/lustre/lnet/lnet/lib-move.c | 24 ---
2 files changed, 0 insertio
Fix the module version to match upstream development.
Signed-off-by: Mike Shuey
---
drivers/staging/lustre/lnet/lnet/module.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/module.c
b/drivers/staging/lustre/lnet/lnet/module.c
index ff3
lnet_fini_locks() does nothing. Remove.
Signed-off-by: Mike Shuey
---
drivers/staging/lustre/lnet/lnet/api-ni.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c
b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 6910f56..1
2015-05-19 14:15+0200, Vitaly Kuznetsov:
> Loaded Hyper-V module will use these functions to disable CPU hotplug
> under certain circumstances.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> kernel/cpu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/cpu.c b/kern
Hi Alex,
2015-05-19 15:34 GMT+02:00 Angelo Compagnucci :
> Hi Alex,
>
> 2015-05-19 13:59 GMT+02:00 Alex Beregszaszi :
>> Hi,
>>
>> Angelo Compagnucci wrote:
>>
>> Dear Bernhard Kraft,
>>
>> 2015-05-18 18:53 GMT+02:00 Bernhard Kraft :
>>
>> But for now I think I will just publish the Arduino sketch
Hi Alex,
2015-05-19 13:59 GMT+02:00 Alex Beregszaszi :
> Hi,
>
> Angelo Compagnucci wrote:
>
> Dear Bernhard Kraft,
>
> 2015-05-18 18:53 GMT+02:00 Bernhard Kraft :
>
> But for now I think I will just publish the Arduino sketch and a sample
> implementation on how to access I2C devices with it.
>
>
Barclays Bank PLC
1 Churchill Place
London, E14 5HP, United Kingdom
Dear Customer,
We are deeply sorry that your fund has not been transferred to you till now
because of the activities of some bad persons here in London and their evil
collaborators in Nigeria,Africa. Therefore, we have been na
We can't save two different values in "flags" so it means that IRQs are
not enabled properly at the end of this function. This isn't a problem
in the current code because it's always called with IRQs disabled so we
don't want to enable them at the end.
This bug is old but it's thanks to David Mat
Hi,
Angelo Compagnucci wrote:
Dear Bernhard Kraft,
2015-05-18 18:53 GMT+02:00 Bernhard Kraft:
But for now I think I will just publish the Arduino sketch and a sample
implementation on how to access I2C devices with it.
Probably we should stick to other protocol driver implementation, but
fr
Commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer
hypervisors") was alteringd smp_ops.cpu_disable to prevent CPU offlining.
We can bo better by using cpu_hotplug_enable/disable functions instead of
such hard-coding.
Reported-by: Radim Krčmář
Signed-off-by: Vitaly Kuznetsov
Loaded Hyper-V module will use these functions to disable CPU hotplug
under certain circumstances.
Signed-off-by: Vitaly Kuznetsov
---
kernel/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 94bbe46..dc005e7 100644
--- a/kernel/cpu.c
+
Export cpu_hotplug_enable/cpu_hotplug_disable functions from cpu.c and use
them instead of altering the smp_ops.cpu_disable in Hyper-V vmbus module.
Vitaly Kuznetsov (2):
cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable
Drivers: hv: vmbus: use cpu_hotplug_enable/disable
drivers/hv/
As the first argument of gf_write64() was of type unsigned long, and as
some calls to gf_write64() were casting the first argument from void *
to u64 the compiler and/or sparse were printing warnings for casts of
wrong sizes when compiling for i386.
This patch changes the type of the first argumen
Also remove them from .h files.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_intf.h | 2 --
drivers/staging/rtl8188eu/include/recv_osdep.h | 3 ---
drivers/staging/rtl8188eu/os_dep/os_intfs.c| 15 +--
3 files
"If the name of a function is an action or an imperative command,
the function should return an error-code integer." (Documentation/CodingStyle)
Several action-like functions in this driver return a boolean: _SUCCESS = 1 on
success, _FAIL = 0 on error, defined in
drivers/staging/rtl8188eu/include/
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
Hi,
this is v2 for the cleanup patchset I sent lasy week [0]. I fixed the few
issues that were raised on patches 7 and 10. The other patches are unchanged.
Patches 1 to 9 are pretty trivial cleanups.
Patch 10 is the first little step to the removal of the _SUCCESS and _FAIL
constants. I'm sendin
"step 2" does mean much as there is no "step 1" stated anywhere...
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c
b/drivers/staging/rtl8712/os_intfs.c
index fd78d22..27a875b 100644
--- a/dri
Fixes checkpatch warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
Changes since v1:
- Fix a misplaced empty line (reported by Larry Finger).
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +++
1 file c
Even though these are not reported by checkpatch, they are coding style issues.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/o
"step 2" does mean much as there is no "step 1" stated anywhere...
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c
b/driver
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
dif
On Mon, May 18, 2015 at 09:56:33PM +0300, Dmitry Kalinkin wrote:
> +static int vme_user_sg_to_dma_list(const struct vme_dma_op *dma_op,
> + struct sg_table *sgt, int sg_count, struct vme_dma_list *dma_list)
> +{
> + ssize_t pos = 0;
> + struct scatterlist *sg;
> + int i, ret;
> +
>
Memory notifiers are being executed in a sequential order and when one of
them fails returning something different from NOTIFY_OK the remainder of
the notification chain is not being executed. When a memory block is being
onlined in online_pages() we do memory_notify(MEM_GOING_ONLINE, ) and if
one
[[PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary
equality checks. This change was detected with the help of coccinelle tool.] On
18/05/2015 (Mon 16:00) Dhere, Chaitanya (C.) wrote:
> Signed-off-by: Chaitanya Dhere
> Reply-To:
>
> ---
> drivers/staging/rtl8192u/
50 matches
Mail list logo
